Timeline
Jan 9, 2004:
- 5:07 PM Changeset in webkit [5884] by
-
- 3 edits in branches
Reviewed by me
Did some caret adjustments to make the caret position
itself into the correct position when between text nodes.
- khtml/editing/edit_caretimpl.cpp: (CaretImpl::setPosition): (CaretImpl::moveForwardByCharacter): (CaretImpl::moveBackwardByCharacter): (CaretImpl::adjustPosition): (CaretImpl::notifyChanged):
- khtml/editing/edit_caretimpl.h:
- 4:44 PM Changeset in webkit [5883] by
-
- 3 edits in trunk/WebKit
- rolled out most of Dave's change for 3510669 and 3515442; it is not working yet
- WebView.subproj/WebHTMLViewPrivate.h:
- WebView.subproj/WebHTMLView.m:
- 3:31 PM Changeset in webkit [5882] by
-
- 2 edits in trunk/WebKit
Reviewed by Chris.
<rdar://problem/3514446>: cert downloaded from BofA or MIT is rejected (ACL issue on private key?)
- WebCoreSupport.subproj/WebKeyGeneration.cpp: (createPair): Cut & paste hunk of code from Security framework. (Safari_SecKeyCreatePair): Ditto. (signedPublicKeyAndChallengeString): Instead of creating a normal ACL, use our hacked version of the SecKeyCreatePair call that doesn't put in any kind of ACL. This works around a SecureTransport bug.
- 2:47 PM Changeset in webkit [5881] by
-
- 3 edits in trunk/WebCore
Fixes for 3510669 and 3515442, blank frame problems caused by WebKit's use of a separate needsLayout boolean.
Reviewed by darin
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge setNeedsLayout]):
- 2:43 PM Changeset in webkit [5880] by
-
- 4 edits in trunk/WebKit
Fixes for 3510669 and 3515442, blank frame problems caused by WebKit's resizing not scheduling actual
layouts via WebCore.
Reviewed by darin
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _web_layoutIfNeededRecursive:testDirtyRect:]): (-[WebHTMLView initWithFrame:]): (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): (-[WebHTMLView setNeedsLayout:]):
- WebView.subproj/WebHTMLViewPrivate.h:
- 1:42 PM Changeset in webkit [5879] by
-
- 4 edits in branches
Reviewed by me
Made it so the cursor does not blink while you are
navigating with the arrow keys.
- khtml/editing/edit_caretimpl.cpp: (CaretImpl::setPosition):
- khtml/editing/edit_caretimpl.h: (khtml::CaretImpl::setOffset):
- khtml/khtmlview.cpp: (KHTMLView::timerEvent): (KHTMLView::caretOn): (KHTMLView::caretOff): (KHTMLView::showCaret): (KHTMLView::paintCaret):
- 1:09 PM Changeset in webkit [5878] by
-
- 13 edits in branches
Reviewed by me
Moved contenteditable to use the style system.
- khtml/css/cssparser.cpp: (CSSParser::parseValue):
- khtml/css/cssproperties.c: (findProp):
- khtml/css/cssproperties.h:
- khtml/css/cssproperties.in:
- khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
- khtml/css/cssvalues.c: (hash_val): (findValue):
- khtml/css/cssvalues.h:
- khtml/css/cssvalues.in:
- khtml/editing/htmlediting.cpp: (EditCommand::pruneEmptyNodes):
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::HTMLElementImpl): (HTMLElementImpl::isContentEditable): (HTMLElementImpl::contentEditable): (HTMLElementImpl::setContentEditable): (HTMLElementImpl::defaultEventHandler):
- khtml/html/html_elementimpl.h:
- khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::setBitDefaults): (khtml::RenderStyle::userModify): (khtml::RenderStyle::setUserModify):
- 12:11 PM Changeset in webkit [5877] by
-
- 2 edits in trunk/WebKit
Reviewed by Chris.
- fixed 3510805: "PoolCleaner" in Carbon WebKit leads to overrelease and crash using color picker in BBEdit
- Carbon.subproj/CarbonUtils.m: (PoolCleaner): Only do the autorelease pool stuff in the default run loop mode. If we're in another run loop mode that means we are in some Cocoa code that sets up its own autorelease pool; it's important that we don't release ours in that case.
- 8:53 AM Changeset in webkit [5876] by
-
- 15 edits in branches
Reviewed by me
A whole host of editing improvements
- khtml/editing/edit_caret.cpp: (Caret::Caret): (Caret::setPosition): (Caret::moveForwardByCharacter): (Caret::moveBackwardByCharacter): (Caret::setStartOfLine): (Caret::adjustPosition): (Caret::adjustedForEditing):
- khtml/editing/edit_caret.h:
- khtml/editing/edit_caretimpl.cpp: (CaretImpl::CaretImpl): (CaretImpl::setNode): (CaretImpl::setPosition): (CaretImpl::moveForwardByCharacter): (CaretImpl::moveBackwardByCharacter): (CaretImpl::adjustPosition): (EditNodeFilter::acceptNode):
- khtml/editing/edit_caretimpl.h:
- khtml/editing/htmlediting.cpp: (EditCommand::EditCommand): (EditCommand::~EditCommand): (EditCommand::notifyChanged): (EditCommand::notifyNodesChanged): (EditCommand::deleteSelection): (EditCommand::pruneEmptyNodes): (EditCommand::removeNode): (InputTextCommand::InputTextCommand): (InputTextCommand::isLineBreak): (InputTextCommand::isSpace): (InputTextCommand::apply): (DeleteTextCommand::DeleteTextCommand): (DeleteTextCommand::apply):
- khtml/editing/htmlediting.h: (khtml::EditCommand::document):
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::defaultEventHandler):
- khtml/khtml_part.cpp: (KHTMLPart::clear): (KHTMLPart::findTextNext): (KHTMLPart::setSelection): (KHTMLPart::slotClearSelection): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::selectAll): (KHTMLPart::caret): (KHTMLPart::moveCaretTo):
- khtml/khtml_part.h:
- khtml/khtmlview.cpp: (KHTMLView::focusNextPrevNode): (KHTMLView::initCaret): (KHTMLView::caretOverrides): (KHTMLView::recalcAndStoreCaretPos): (KHTMLView::foldSelectionToCaret): (KHTMLView::placeCaret): (KHTMLView::moveCaretTo):
- khtml/xml/dom_docimpl.cpp:
- khtml/xml/dom_docimpl.h:
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::remove): (NodeImpl::previousLeafNode):
- khtml/xml/dom_nodeimpl.h:
Jan 8, 2004:
- 5:49 PM Changeset in webkit [5875] by
-
- 2 edits in trunk/WebCore
Fix for 3524118, floats don't repaint when moved.
Reviewed by darin
- khtml/rendering/render_block.cpp:
(khtml::RenderBlock::positionNewFloats):
- 3:47 PM Changeset in webkit [5874] by
-
- 2 edits in trunk/WebKit
Reviewed by John.
<rdar://problem/3522298>: Error on MIT's x509 certificate site
- WebCoreSupport.subproj/WebKeyGeneration.cpp: (addCertificatesToKeychainFromData): Sign the freshly minted public key using RSA/MD5 instead of RSA/SHA-1, because MIT only supports MD5.
- 3:36 PM Changeset in webkit [5873] by
-
- 2 edits in trunk/WebKit
Fixed 3524430. This was a regression introduced when we added '-' and '?' to the word boundary detection.
Also backed out workaround for 3521759 as it's no longer needed with correct argument passing to ATSUPositionToOffset.
Reviewed by Hyatt.
- WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]): (widthForNextCharacter):
- 3:35 PM Changeset in webkit [5872] by
-
- 2 edits in trunk/WebCore
Fix for 3519003, crash in mail because <dir> and <menu> don't allow the same children as <ul> and <ol>.
Reviewed by darin
- khtml/html/dtd.cpp: (DOM::checkChild):
- 3:07 PM Changeset in webkit [5871] by
-
- 4 edits in trunk/WebKit
Fixed: <rdar://problem/3522900>: REGRESSION (100-117): Java plug-in description is garbled when displaying Plug-ins.html
Reviewed by darin.
- Misc.subproj/WebKitNSStringExtras.h:
- Misc.subproj/WebKitNSStringExtras.m: (+[NSString _web_encodingForResource:]): new method, returns the encoding for a resource handle given its file system path
- Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage stringForStringListID:andIndex:]): call _web_encodingForResource when creating the NSString
- 2:23 PM Changeset in webkit [5870] by
-
- 2 edits in trunk/WebCore
- fixed <rdar://problem/3524359>: REGRESSSION (119-120): Double click to select text in form broken
Reviewed by Dave and Darin.
- khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent): Don't blur the focused node if that's the one you clicked on.
Jan 7, 2004:
- 4:45 PM Changeset in webkit [5869] by
-
- 2 edits in trunk/WebCore
WebCore:
Fixed 3517550. Named array lookup of applet failed, i.e.:
var appletobj = document.appletsmyapplet
Reviewed by Chris.
- khtml/ecma/kjs_html.cpp: (KJS::HTMLCollection::getNamedItems):
Tests:
Added lookup test for all three variants of applet access:
named, indexed array, and named array.
- LiveConnect/Blink/Blink.java: (Blink): (Blink.init):
- LiveConnect/Blink/Blink.pbproj/project.pbxproj:
- LiveConnect/Blink/test.html:
- 10:58 AM Changeset in webkit [5868] by
-
- 3 edits in trunk
ok, back to 121u now. tree is still closed.
- 10:51 AM Changeset in webkit [5867]
-
- 3 copies in tags/Safari-120
This commit was manufactured by cvs2svn to create tag 'Safari-120'.
- 10:51 AM Changeset in webkit [5866] by
-
- 3 edits in trunk
silly me. i forgot to actually tag before updating the version number to 121u.
- 10:35 AM Changeset in webkit [5865] by
-
- 3 edits in trunk
set version number to 121u -- the tree is still closed
- 10:32 AM Changeset in webkit [5864] by
-
- 6 edits in trunk
Safari-120 stamp
Jan 6, 2004:
- 5:15 PM Changeset in webkit [5863] by
-
- 4 edits in trunk/WebCore
Possible fix for table bugs 3510005 and 3492945, repainting glitches that occurred when table cells moved.
Fix for 33522497, empty AXElements appear in AXBrowser.
Reviewed by darin
- khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows): (RenderTableCell::setWidth):
- khtml/rendering/render_table.h:
- kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityIsIgnored]):
- 3:39 PM Changeset in webkit [5862] by
-
- 2 edits in trunk/WebCore
- fixed <rdar://problem/3484465>: REGRESSION (118): button click does not take focus away from <textarea>; breaks Outlook Web Access
Reviewed by Dave.
- khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent): Removed nodeimpl == nil test that was preventing button/link clicks from blurring previously-focused text field.
- 3:09 PM Changeset in webkit [5861] by
-
- 2 edits in trunk/WebKit
Fixed 3513660. Make ATSU layout and draw with integer glyph boundaries. This fix should be removed if/when we convert WebCore to use floats for measuring/positioning (3521781).
Reviewed by John.
- WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _createATSUTextLayoutForRun:]):
- 1:59 PM Changeset in webkit [5860] by
-
- 1 edit in trunk/WebCore/kwq/WebCoreBridge.mm
I meant kMax not kMin here.
- 1:55 PM Changeset in webkit [5859] by
-
- 2 edits in trunk/JavaScriptCore
Fixed 3521814. Finalize messages weren't being dispatched!
Reviewed by John.
- bindings/jni_jsobject.cpp: (JSObject::invoke):
- 12:52 PM Changeset in webkit [5858] by
-
- 3 edits in trunk/WebCore
Fix for 3520636, infinite loop in page breaking code when printing.
Reviewed by darin
- khtml/rendering/render_text.cpp: (RenderText::paintObject):
- kwq/WebCoreBridge.mm: (-[WebCoreBridge computePageRectsWithPrintWidth:printHeight:]):
Jan 5, 2004:
- 3:24 PM Changeset in webkit [5857] by
-
- 2 edits in trunk/WebCore
Fix for 3521466, generated image content should not try to calcWidth/height when it isn't yet rooted in
the rendering tree.
Reviewed by john
- khtml/rendering/render_image.cpp: (RenderImage::setPixmap):
- 2:52 PM Changeset in webkit [5856] by
-
- 2 edits in trunk/WebKit
Fix for 3514454. Work-around added for 3521759.
Filed 3521781 to cover deeper problem.
Reviewed by Kocienda.
- WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]):
- 9:44 AM Changeset in webkit [5855] by
-
- 8 edits in trunk/JavaScriptCore
Added cache of JNI method IDs to minimize allocations. This mitigates the problem
described by 3515579.
Also cleanup up logging of Java exceptions.
Reviewed by John.
- bindings/jni/jni_class.cpp: (JavaClass::classForInstance):
- bindings/jni/jni_instance.cpp: (JavaInstance::JavaInstance): (JavaInstance::getClass): (JavaInstance::invokeMethod): (JObjectWrapper::JObjectWrapper): (JObjectWrapper::~JObjectWrapper):
- bindings/jni/jni_instance.h: (KJS::Bindings::JavaInstance::operator=):
- bindings/jni/jni_runtime.cpp: (JavaMethod::JavaMethod): (JavaMethod::methodID):
- bindings/jni/jni_runtime.h: (KJS::Bindings::JavaMethod::JavaMethod):
- bindings/jni/jni_utility.cpp: (callJNIMethod): (callJNIMethodIDA): (callJNIMethodA): (KJS::Bindings::getMethodID): (KJS::Bindings::callJNIVoidMethodIDA): (KJS::Bindings::callJNIObjectMethodIDA): (KJS::Bindings::callJNIByteMethodIDA): (KJS::Bindings::callJNICharMethodIDA): (KJS::Bindings::callJNIShortMethodIDA): (KJS::Bindings::callJNIIntMethodIDA): (KJS::Bindings::callJNILongMethodIDA): (KJS::Bindings::callJNIFloatMethodIDA): (KJS::Bindings::callJNIDoubleMethodIDA): (KJS::Bindings::callJNIBooleanMethodIDA): (KJS::Bindings::getCharactersFromJStringInEnv): (KJS::Bindings::getUCharactersFromJStringInEnv): (KJS::Bindings::getJNIField):
- bindings/jni/jni_utility.h:
