Timeline
Jan 12, 2004:
- 9:04 AM Changeset in webkit [5892] by
-
- 4 edits in branches
Reviewed by me
Some more clean up to basic caret movement and basic editing.
Fixed deleting BR's, which I broke late last week.
- khtml/editing/htmlediting.cpp: (EditCommand::notifyChanged): (EditCommand::deleteSelection): (EditCommand::pruneEmptyNodes): (InputTextCommand::apply): (DeleteTextCommand::apply):
- khtml/editing/htmlediting.h:
- khtml/khtml_part.cpp: (KHTMLPart::moveCaretTo):
Jan 11, 2004:
- 4:42 PM Changeset in webkit [5891] by
-
- 3 edits in trunk
changed version number from '121' to '122u'
- 4:27 PM Changeset in webkit [5890]
-
- 3 copies in tags/Safari-121
This commit was manufactured by cvs2svn to create tag 'Safari-121'.
- 4:27 PM Changeset in webkit [5889] by
-
- 3 edits in trunk
Safari-121 stamp
(Ordinarily this checkin would show the version number change to project.pbxproj files, but I accidentally changed the version number to '121' instead of '121u' when I opened the tree after Safari-120.)
- 12:09 PM Changeset in webkit [5888] by
-
- 2 edits in trunk/WebCore
- fixed Dave's check-in so it compiles; I assume he forgot to land one source file
- khtml/khtmlview.h: Add RenderPart to the friends of KHTMLView.
- 11:06 AM Changeset in webkit [5887] by
-
- 3 edits in trunk/WebCore
Fix for frame repainting bugs (3510669, 3515442). This is a narrower fix than the previous attempt.
Reviewed by darin
- khtml/rendering/render_frames.cpp: (RenderPart::updateWidgetPositions):
- khtml/rendering/render_frames.h:
- khtml/rendering/render_replaced.cpp: (RenderWidget::updateWidgetPositions):
Jan 10, 2004:
- 4:08 PM Changeset in webkit [5886] by
-
- 4 edits in trunk/WebKit
Reviewed by John.
- fixed 3524906: REGRESSION (114-115): page with plug-in content never stops loading (travelking.com.tw)
Put the plug-in streams clients into their own separate set. Now a plug-in client is not considered part
of "loading", but it does participate in the callback deferral mechanism, which was the real goal of the
change I made that introduced this regression. Also remove the plug-in client in one case I had missed
before (cancel).
- WebView.subproj/WebDataSourcePrivate.h: Added a new set of plugInStreamClients.
- WebView.subproj/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): Release the set. (-[WebDataSource _addPlugInStreamClient:]): Added. Adds to the set. (-[WebDataSource _removePlugInStreamClient:]): Added. Removes from the set. (-[WebDataSource _defersCallbacksChanged]): Added code to loop through plugInStreamClients too.
- Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream start]): Use _add/removePlugInStreamClient instead of _add/removeSubresourceClient. (-[WebNetscapePluginConnectionDelegate connectionDidFinishLoading:]): Ditto. (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): Ditto. (-[WebNetscapePluginConnectionDelegate cancelWithError:]): Override to call _removePlugInStreamClient and then call super.
- 12:10 PM Changeset in webkit [5885] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
- fixed 3525468: REGRESSION (114-115): HOMEPAGE: after hitting textarea limit, backspace key is ignored
- kwq/KWQEvent.mm: (keyIdentifierForKeyEvent): Treat 7F as 08; matches other browsers. (QKeyEvent::QKeyEvent): Ditto.
Jan 9, 2004:
- 5:07 PM Changeset in webkit [5884] by
-
- 3 edits in branches
Reviewed by me
Did some caret adjustments to make the caret position
itself into the correct position when between text nodes.
- khtml/editing/edit_caretimpl.cpp: (CaretImpl::setPosition): (CaretImpl::moveForwardByCharacter): (CaretImpl::moveBackwardByCharacter): (CaretImpl::adjustPosition): (CaretImpl::notifyChanged):
- khtml/editing/edit_caretimpl.h:
- 4:44 PM Changeset in webkit [5883] by
-
- 3 edits in trunk/WebKit
- rolled out most of Dave's change for 3510669 and 3515442; it is not working yet
- WebView.subproj/WebHTMLViewPrivate.h:
- WebView.subproj/WebHTMLView.m:
- 3:31 PM Changeset in webkit [5882] by
-
- 2 edits in trunk/WebKit
Reviewed by Chris.
<rdar://problem/3514446>: cert downloaded from BofA or MIT is rejected (ACL issue on private key?)
- WebCoreSupport.subproj/WebKeyGeneration.cpp: (createPair): Cut & paste hunk of code from Security framework. (Safari_SecKeyCreatePair): Ditto. (signedPublicKeyAndChallengeString): Instead of creating a normal ACL, use our hacked version of the SecKeyCreatePair call that doesn't put in any kind of ACL. This works around a SecureTransport bug.
- 2:47 PM Changeset in webkit [5881] by
-
- 3 edits in trunk/WebCore
Fixes for 3510669 and 3515442, blank frame problems caused by WebKit's use of a separate needsLayout boolean.
Reviewed by darin
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge setNeedsLayout]):
- 2:43 PM Changeset in webkit [5880] by
-
- 4 edits in trunk/WebKit
Fixes for 3510669 and 3515442, blank frame problems caused by WebKit's resizing not scheduling actual
layouts via WebCore.
Reviewed by darin
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _web_layoutIfNeededRecursive:testDirtyRect:]): (-[WebHTMLView initWithFrame:]): (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): (-[WebHTMLView setNeedsLayout:]):
- WebView.subproj/WebHTMLViewPrivate.h:
- 1:42 PM Changeset in webkit [5879] by
-
- 4 edits in branches
Reviewed by me
Made it so the cursor does not blink while you are
navigating with the arrow keys.
- khtml/editing/edit_caretimpl.cpp: (CaretImpl::setPosition):
- khtml/editing/edit_caretimpl.h: (khtml::CaretImpl::setOffset):
- khtml/khtmlview.cpp: (KHTMLView::timerEvent): (KHTMLView::caretOn): (KHTMLView::caretOff): (KHTMLView::showCaret): (KHTMLView::paintCaret):
- 1:09 PM Changeset in webkit [5878] by
-
- 13 edits in branches
Reviewed by me
Moved contenteditable to use the style system.
- khtml/css/cssparser.cpp: (CSSParser::parseValue):
- khtml/css/cssproperties.c: (findProp):
- khtml/css/cssproperties.h:
- khtml/css/cssproperties.in:
- khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
- khtml/css/cssvalues.c: (hash_val): (findValue):
- khtml/css/cssvalues.h:
- khtml/css/cssvalues.in:
- khtml/editing/htmlediting.cpp: (EditCommand::pruneEmptyNodes):
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::HTMLElementImpl): (HTMLElementImpl::isContentEditable): (HTMLElementImpl::contentEditable): (HTMLElementImpl::setContentEditable): (HTMLElementImpl::defaultEventHandler):
- khtml/html/html_elementimpl.h:
- khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::setBitDefaults): (khtml::RenderStyle::userModify): (khtml::RenderStyle::setUserModify):
- 12:11 PM Changeset in webkit [5877] by
-
- 2 edits in trunk/WebKit
Reviewed by Chris.
- fixed 3510805: "PoolCleaner" in Carbon WebKit leads to overrelease and crash using color picker in BBEdit
- Carbon.subproj/CarbonUtils.m: (PoolCleaner): Only do the autorelease pool stuff in the default run loop mode. If we're in another run loop mode that means we are in some Cocoa code that sets up its own autorelease pool; it's important that we don't release ours in that case.
- 8:53 AM Changeset in webkit [5876] by
-
- 15 edits in branches
Reviewed by me
A whole host of editing improvements
- khtml/editing/edit_caret.cpp: (Caret::Caret): (Caret::setPosition): (Caret::moveForwardByCharacter): (Caret::moveBackwardByCharacter): (Caret::setStartOfLine): (Caret::adjustPosition): (Caret::adjustedForEditing):
- khtml/editing/edit_caret.h:
- khtml/editing/edit_caretimpl.cpp: (CaretImpl::CaretImpl): (CaretImpl::setNode): (CaretImpl::setPosition): (CaretImpl::moveForwardByCharacter): (CaretImpl::moveBackwardByCharacter): (CaretImpl::adjustPosition): (EditNodeFilter::acceptNode):
- khtml/editing/edit_caretimpl.h:
- khtml/editing/htmlediting.cpp: (EditCommand::EditCommand): (EditCommand::~EditCommand): (EditCommand::notifyChanged): (EditCommand::notifyNodesChanged): (EditCommand::deleteSelection): (EditCommand::pruneEmptyNodes): (EditCommand::removeNode): (InputTextCommand::InputTextCommand): (InputTextCommand::isLineBreak): (InputTextCommand::isSpace): (InputTextCommand::apply): (DeleteTextCommand::DeleteTextCommand): (DeleteTextCommand::apply):
- khtml/editing/htmlediting.h: (khtml::EditCommand::document):
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::defaultEventHandler):
- khtml/khtml_part.cpp: (KHTMLPart::clear): (KHTMLPart::findTextNext): (KHTMLPart::setSelection): (KHTMLPart::slotClearSelection): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::selectAll): (KHTMLPart::caret): (KHTMLPart::moveCaretTo):
- khtml/khtml_part.h:
- khtml/khtmlview.cpp: (KHTMLView::focusNextPrevNode): (KHTMLView::initCaret): (KHTMLView::caretOverrides): (KHTMLView::recalcAndStoreCaretPos): (KHTMLView::foldSelectionToCaret): (KHTMLView::placeCaret): (KHTMLView::moveCaretTo):
- khtml/xml/dom_docimpl.cpp:
- khtml/xml/dom_docimpl.h:
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::remove): (NodeImpl::previousLeafNode):
- khtml/xml/dom_nodeimpl.h:
Jan 8, 2004:
- 5:49 PM Changeset in webkit [5875] by
-
- 2 edits in trunk/WebCore
Fix for 3524118, floats don't repaint when moved.
Reviewed by darin
- khtml/rendering/render_block.cpp:
(khtml::RenderBlock::positionNewFloats):
- 3:47 PM Changeset in webkit [5874] by
-
- 2 edits in trunk/WebKit
Reviewed by John.
<rdar://problem/3522298>: Error on MIT's x509 certificate site
- WebCoreSupport.subproj/WebKeyGeneration.cpp: (addCertificatesToKeychainFromData): Sign the freshly minted public key using RSA/MD5 instead of RSA/SHA-1, because MIT only supports MD5.
- 3:36 PM Changeset in webkit [5873] by
-
- 2 edits in trunk/WebKit
Fixed 3524430. This was a regression introduced when we added '-' and '?' to the word boundary detection.
Also backed out workaround for 3521759 as it's no longer needed with correct argument passing to ATSUPositionToOffset.
Reviewed by Hyatt.
- WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]): (widthForNextCharacter):
- 3:35 PM Changeset in webkit [5872] by
-
- 2 edits in trunk/WebCore
Fix for 3519003, crash in mail because <dir> and <menu> don't allow the same children as <ul> and <ol>.
Reviewed by darin
- khtml/html/dtd.cpp: (DOM::checkChild):
- 3:07 PM Changeset in webkit [5871] by
-
- 4 edits in trunk/WebKit
Fixed: <rdar://problem/3522900>: REGRESSION (100-117): Java plug-in description is garbled when displaying Plug-ins.html
Reviewed by darin.
- Misc.subproj/WebKitNSStringExtras.h:
- Misc.subproj/WebKitNSStringExtras.m: (+[NSString _web_encodingForResource:]): new method, returns the encoding for a resource handle given its file system path
- Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage stringForStringListID:andIndex:]): call _web_encodingForResource when creating the NSString
- 2:23 PM Changeset in webkit [5870] by
-
- 2 edits in trunk/WebCore
- fixed <rdar://problem/3524359>: REGRESSSION (119-120): Double click to select text in form broken
Reviewed by Dave and Darin.
- khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent): Don't blur the focused node if that's the one you clicked on.
