⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 13, 2004:

8:57 PM Changeset in webkit [5899] by rjw
  • 2 edits in trunk/JavaScriptCore

Fixed 3528324.

The run loop that is used to execute JavaScript (in practice, always the main run loop) is held in a class variable. It is set and retained once and should not be released. Unfortunately is it being released when the 'root' object on a LiveConnect applet is released. This has the symptom of eventually causing an deallocation of the main run loop! Usually after about 5 instantiations/destructions of a LiveConnect applet. The CFRelease of the run loop was removed.

Reviewed by Hyatt.

  • bindings/jni_jsobject.h: (KJS::Bindings::RootObject::~RootObject):
6:32 PM Changeset in webkit [5898]
  • 5 copies
    2 deletes in tags/HTML-editing-hacks-anchor

This commit was manufactured by cvs2svn to create tag
'HTML-editing-hacks-anchor'.

6:32 PM Changeset in webkit [5897] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3527707, crash on w3c css page. Make sure height isn't allowed to be negative when computing
positioned elements' heights. Also bulletproof the crash in case there are other negative height code
paths.

Reviewed by john

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::getAbsoluteRepaintRectIncludingFloats):
  • khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteVertical):
5:12 PM Changeset in webkit [5896] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3527853>: REGRESSION (119-120): Peoplesoft menus do not work

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scrollToAnchor): Right before calling checkCompleted(), set m_bComplete to false, so it can get set right back to true if we're actually done loading and fire all the right signals.
11:36 AM Changeset in webkit [5895] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3526710, applets need to have the correct initial size after a layout has been done, since our
Java applets can't yet resize.

Reviewed by john

  • khtml/rendering/render_applet.cpp: (RenderApplet::createWidgetIfNecessary): (RenderApplet::layout): (RenderEmptyApplet::layout):
10:04 AM Changeset in webkit [5894]
  • 350 copies in branches/HTML-editing-hacks-branch

This commit was manufactured by cvs2svn to create branch
'HTML-editing-hacks-branch'.

10:04 AM Changeset in webkit [5893] by kocienda
  • 31 edits in branches

Reviewed by me

Merged TOT onto the branch

  • ChangeLog:
  • WebCore.pbproj/project.pbxproj:
  • khtml/css/css_valueimpl.h:
  • khtml/css/cssparser.cpp:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLCollection::getNamedItems):
  • khtml/ecma/kjs_html.lut.h: (KJS::):
  • khtml/html/dtd.cpp: (DOM::checkChild):
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance):
  • khtml/khtml_part.cpp: (KHTMLPart::text): (KHTMLPart::setSelection): (KHTMLPart::slotClearSelection): (KHTMLPart::setZoomFactor): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::emitCaretPositionChanged): (KHTMLPart::moveCaretTo):
  • khtml/khtml_part.h:
  • khtml/khtmlview.cpp: (KHTMLViewPrivate::KHTMLViewPrivate): (KHTMLViewPrivate::editorContext): (KHTMLView::clear): (KHTMLView::resizeEvent): (KHTMLView::drawContents): (KHTMLView::layout): (KHTMLView::dispatchMouseEvent): (KHTMLView::moveCaretTo):
  • khtml/khtmlview.h:
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::positionNewFloats):
  • khtml/rendering/render_frames.cpp: (RenderPart::updateWidgetPositions):
  • khtml/rendering/render_frames.h:
  • khtml/rendering/render_image.cpp: (RenderImage::setPixmap):
  • khtml/rendering/render_style.cpp: (StyleCSS3InheritedData::~StyleCSS3InheritedData):
  • khtml/rendering/render_style.h:
  • khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows): (RenderTableCell::setStyle):
  • khtml/rendering/render_table.h: (khtml::RenderTableCol::lineHeight):
  • khtml/rendering/render_text.cpp: (RenderText::paintObject):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::attach): (DocumentImpl::setInPageCache):
  • khtml/xml/dom_docimpl.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject roleDescription]): (-[KWQAccObject value]): (-[KWQAccObject accessibilityIsIgnored]): (-[KWQAccObject accessibilityActionDescription:]):
  • kwq/KWQEvent.mm: (keyIdentifierForKeyEvent): (QKeyEvent::QKeyEvent):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache): (KWQKHTMLPart::scrollToAnchor): (KWQKHTMLPart::attributedString):
  • kwq/KWQPageState.h:
  • kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:interpreterBuiltins:]): (-[KWQPageState clear]): (-[KWQPageState invalidate]): (-[KWQPageState dealloc]): (-[KWQPageState interpreterBuiltins]):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge computePageRectsWithPrintWidth:printHeight:]): (-[WebCoreBridge setTextSizeMultiplier:]): (-[WebCoreBridge needsLayout]): (-[WebCoreBridge setNeedsLayout]):
  • kwq/WebCoreJavaScript.mm: (+[WebCoreJavaScript rootObjectClasses]): (+[WebCoreJavaScript garbageCollect]):

Jan 12, 2004:

9:04 AM Changeset in webkit [5892] by kocienda
  • 4 edits in branches

Reviewed by me

Some more clean up to basic caret movement and basic editing.
Fixed deleting BR's, which I broke late last week.

  • khtml/editing/htmlediting.cpp: (EditCommand::notifyChanged): (EditCommand::deleteSelection): (EditCommand::pruneEmptyNodes): (InputTextCommand::apply): (DeleteTextCommand::apply):
  • khtml/editing/htmlediting.h:
  • khtml/khtml_part.cpp: (KHTMLPart::moveCaretTo):

Jan 11, 2004:

4:42 PM Changeset in webkit [5891] by vicki
  • 3 edits in trunk

changed version number from '121' to '122u'

4:27 PM Changeset in webkit [5890]
  • 3 copies in tags/Safari-121

This commit was manufactured by cvs2svn to create tag 'Safari-121'.

4:27 PM Changeset in webkit [5889] by vicki
  • 3 edits in trunk

Safari-121 stamp

(Ordinarily this checkin would show the version number change to project.pbxproj files, but I accidentally changed the version number to '121' instead of '121u' when I opened the tree after Safari-120.)

12:09 PM Changeset in webkit [5888] by darin
  • 2 edits in trunk/WebCore
  • fixed Dave's check-in so it compiles; I assume he forgot to land one source file
  • khtml/khtmlview.h: Add RenderPart to the friends of KHTMLView.
11:06 AM Changeset in webkit [5887] by hyatt
  • 3 edits in trunk/WebCore

Fix for frame repainting bugs (3510669, 3515442). This is a narrower fix than the previous attempt.

Reviewed by darin

  • khtml/rendering/render_frames.cpp: (RenderPart::updateWidgetPositions):
  • khtml/rendering/render_frames.h:
  • khtml/rendering/render_replaced.cpp: (RenderWidget::updateWidgetPositions):

Jan 10, 2004:

4:08 PM Changeset in webkit [5886] by darin
  • 4 edits in trunk/WebKit

Reviewed by John.

  • fixed 3524906: REGRESSION (114-115): page with plug-in content never stops loading (travelking.com.tw)

Put the plug-in streams clients into their own separate set. Now a plug-in client is not considered part
of "loading", but it does participate in the callback deferral mechanism, which was the real goal of the
change I made that introduced this regression. Also remove the plug-in client in one case I had missed
before (cancel).

  • WebView.subproj/WebDataSourcePrivate.h: Added a new set of plugInStreamClients.
  • WebView.subproj/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): Release the set. (-[WebDataSource _addPlugInStreamClient:]): Added. Adds to the set. (-[WebDataSource _removePlugInStreamClient:]): Added. Removes from the set. (-[WebDataSource _defersCallbacksChanged]): Added code to loop through plugInStreamClients too.
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream start]): Use _add/removePlugInStreamClient instead of _add/removeSubresourceClient. (-[WebNetscapePluginConnectionDelegate connectionDidFinishLoading:]): Ditto. (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): Ditto. (-[WebNetscapePluginConnectionDelegate cancelWithError:]): Override to call _removePlugInStreamClient and then call super.
12:10 PM Changeset in webkit [5885] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed 3525468: REGRESSION (114-115): HOMEPAGE: after hitting textarea limit, backspace key is ignored
  • kwq/KWQEvent.mm: (keyIdentifierForKeyEvent): Treat 7F as 08; matches other browsers. (QKeyEvent::QKeyEvent): Ditto.

Jan 9, 2004:

5:07 PM Changeset in webkit [5884] by kocienda
  • 3 edits in branches

Reviewed by me

Did some caret adjustments to make the caret position
itself into the correct position when between text nodes.

  • khtml/editing/edit_caretimpl.cpp: (CaretImpl::setPosition): (CaretImpl::moveForwardByCharacter): (CaretImpl::moveBackwardByCharacter): (CaretImpl::adjustPosition): (CaretImpl::notifyChanged):
  • khtml/editing/edit_caretimpl.h:
4:44 PM Changeset in webkit [5883] by darin
  • 3 edits in trunk/WebKit
  • rolled out most of Dave's change for 3510669 and 3515442; it is not working yet
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebHTMLView.m:
3:31 PM Changeset in webkit [5882] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Chris.

<rdar://problem/3514446>: cert downloaded from BofA or MIT is rejected (ACL issue on private key?)

  • WebCoreSupport.subproj/WebKeyGeneration.cpp: (createPair): Cut & paste hunk of code from Security framework. (Safari_SecKeyCreatePair): Ditto. (signedPublicKeyAndChallengeString): Instead of creating a normal ACL, use our hacked version of the SecKeyCreatePair call that doesn't put in any kind of ACL. This works around a SecureTransport bug.
2:47 PM Changeset in webkit [5881] by hyatt
  • 3 edits in trunk/WebCore

Fixes for 3510669 and 3515442, blank frame problems caused by WebKit's use of a separate needsLayout boolean.

Reviewed by darin

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setNeedsLayout]):
2:43 PM Changeset in webkit [5880] by hyatt
  • 4 edits in trunk/WebKit

Fixes for 3510669 and 3515442, blank frame problems caused by WebKit's resizing not scheduling actual
layouts via WebCore.

Reviewed by darin

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _web_layoutIfNeededRecursive:testDirtyRect:]): (-[WebHTMLView initWithFrame:]): (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): (-[WebHTMLView setNeedsLayout:]):
  • WebView.subproj/WebHTMLViewPrivate.h:
1:42 PM Changeset in webkit [5879] by kocienda
  • 4 edits in branches

Reviewed by me

Made it so the cursor does not blink while you are
navigating with the arrow keys.

  • khtml/editing/edit_caretimpl.cpp: (CaretImpl::setPosition):
  • khtml/editing/edit_caretimpl.h: (khtml::CaretImpl::setOffset):
  • khtml/khtmlview.cpp: (KHTMLView::timerEvent): (KHTMLView::caretOn): (KHTMLView::caretOff): (KHTMLView::showCaret): (KHTMLView::paintCaret):
1:09 PM Changeset in webkit [5878] by kocienda
  • 13 edits in branches

Reviewed by me

Moved contenteditable to use the style system.

  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssproperties.c: (findProp):
  • khtml/css/cssproperties.h:
  • khtml/css/cssproperties.in:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
  • khtml/css/cssvalues.c: (hash_val): (findValue):
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
  • khtml/editing/htmlediting.cpp: (EditCommand::pruneEmptyNodes):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::HTMLElementImpl): (HTMLElementImpl::isContentEditable): (HTMLElementImpl::contentEditable): (HTMLElementImpl::setContentEditable): (HTMLElementImpl::defaultEventHandler):
  • khtml/html/html_elementimpl.h:
  • khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::setBitDefaults): (khtml::RenderStyle::userModify): (khtml::RenderStyle::setUserModify):
12:11 PM Changeset in webkit [5877] by darin
  • 2 edits in trunk/WebKit

Reviewed by Chris.

  • fixed 3510805: "PoolCleaner" in Carbon WebKit leads to overrelease and crash using color picker in BBEdit
  • Carbon.subproj/CarbonUtils.m: (PoolCleaner): Only do the autorelease pool stuff in the default run loop mode. If we're in another run loop mode that means we are in some Cocoa code that sets up its own autorelease pool; it's important that we don't release ours in that case.
8:53 AM Changeset in webkit [5876] by kocienda
  • 15 edits in branches

Reviewed by me

A whole host of editing improvements

  • khtml/editing/edit_caret.cpp: (Caret::Caret): (Caret::setPosition): (Caret::moveForwardByCharacter): (Caret::moveBackwardByCharacter): (Caret::setStartOfLine): (Caret::adjustPosition): (Caret::adjustedForEditing):
  • khtml/editing/edit_caret.h:
  • khtml/editing/edit_caretimpl.cpp: (CaretImpl::CaretImpl): (CaretImpl::setNode): (CaretImpl::setPosition): (CaretImpl::moveForwardByCharacter): (CaretImpl::moveBackwardByCharacter): (CaretImpl::adjustPosition): (EditNodeFilter::acceptNode):
  • khtml/editing/edit_caretimpl.h:
  • khtml/editing/htmlediting.cpp: (EditCommand::EditCommand): (EditCommand::~EditCommand): (EditCommand::notifyChanged): (EditCommand::notifyNodesChanged): (EditCommand::deleteSelection): (EditCommand::pruneEmptyNodes): (EditCommand::removeNode): (InputTextCommand::InputTextCommand): (InputTextCommand::isLineBreak): (InputTextCommand::isSpace): (InputTextCommand::apply): (DeleteTextCommand::DeleteTextCommand): (DeleteTextCommand::apply):
  • khtml/editing/htmlediting.h: (khtml::EditCommand::document):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::defaultEventHandler):
  • khtml/khtml_part.cpp: (KHTMLPart::clear): (KHTMLPart::findTextNext): (KHTMLPart::setSelection): (KHTMLPart::slotClearSelection): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::selectAll): (KHTMLPart::caret): (KHTMLPart::moveCaretTo):
  • khtml/khtml_part.h:
  • khtml/khtmlview.cpp: (KHTMLView::focusNextPrevNode): (KHTMLView::initCaret): (KHTMLView::caretOverrides): (KHTMLView::recalcAndStoreCaretPos): (KHTMLView::foldSelectionToCaret): (KHTMLView::placeCaret): (KHTMLView::moveCaretTo):
  • khtml/xml/dom_docimpl.cpp:
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::remove): (NodeImpl::previousLeafNode):
  • khtml/xml/dom_nodeimpl.h:
Note: See TracTimeline for information about the timeline view.