Timeline
Jan 14, 2004:
- 5:41 PM Changeset in webkit [5907] by
-
- 3 edits in trunk
- change version numbers to "124u", since I spun WebBrowser-123 for the Info.plist change in rdar://problem/3529511
- 5:10 PM Changeset in webkit [5906] by
-
- 2 edits in trunk/JavaScriptCore
Fixed 3529466. With recent changes to Java plugin we must no
longer call DeleteLocalRef(). Not a problem, it was an optimization anyway.
Reviewed by John.
- bindings/jni/jni_instance.cpp: (JObjectWrapper::JObjectWrapper):
- 5:04 PM Changeset in webkit [5905] by
-
- 3 edits in trunk
- change version number to "123u". The tree is open for Safari-123
- 4:47 PM Changeset in webkit [5904]
-
- 3 copies in tags/Safari-122
This commit was manufactured by cvs2svn to create tag 'Safari-122'.
- 4:47 PM Changeset in webkit [5903] by
-
- 6 edits in trunk
Safari-122 stamp (we'll have to change the release marker in WebBrowser after john's check in)
- 4:16 PM Changeset in webkit [5902] by
-
- 2 edits in trunk/WebCore
Fix for 3527819, marquee makes page layout too wide. Make sure marquees have a minimum width of 0.
Reviewed by john
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::calcMinMaxWidth): (khtml::RenderBlock::calcInlineMinMaxWidth):
- 1:00 PM Changeset in webkit [5901] by
-
- 2 edits in trunk/JavaScriptCore
Fixed 3529010.
Finalize may be called on an JSObject after we've already remove all our references. The assert in this case is firing because we've received a finalize call from Java for an instance that we no longer know about. The fix is to check in finalize that we're getting a call on an instance that we still care about.
Reviewed by John.
- bindings/jni_jsobject.cpp: (addJavaReference): (removeJavaReference): (RootObject::removeAllJavaReferencesForRoot): (JSObject::invoke):
- 10:41 AM Changeset in webkit [5900] by
-
- 12 edits in branches/HTML-editing-hacks-branch/WebCore
Reviewed by me
Did quite a lot of cleanup in the way that
the caret position is set programmatically.
The attempt was to funnel more code through
KHTMLPart::moveCaretTo.
- khtml/editing/edit_caret.cpp:
- khtml/editing/edit_caret.h:
- khtml/editing/edit_caretimpl.cpp: (CaretImpl::moveForwardByCharacter): (CaretImpl::moveBackwardByCharacter): (CaretImpl::setNode): (CaretImpl::setPosition): (CaretImpl::adjustPosition):
- khtml/editing/edit_caretimpl.h:
- khtml/editing/htmlediting.cpp: (InputTextCommand::apply): (DeleteTextCommand::apply):
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::isFocusable): (HTMLElementImpl::defaultEventHandler):
- khtml/html/html_elementimpl.h:
- khtml/khtml_part.cpp: (KHTMLPart::moveCaretTo): (KHTMLPart::collapseSelectionToCaret): (KHTMLPart::nextNodeWithRenderer):
- khtml/khtml_part.h:
- khtml/khtmlview.cpp: (KHTMLView::focusNextPrevNode): (KHTMLView::initCaret):
- khtml/khtmlview.h:
Jan 13, 2004:
- 8:57 PM Changeset in webkit [5899] by
-
- 2 edits in trunk/JavaScriptCore
Fixed 3528324.
The run loop that is used to execute JavaScript (in practice, always the main run loop) is held in a class variable. It is set and retained once and should not be released. Unfortunately is it being released when the 'root' object on a LiveConnect applet is released. This has the symptom of eventually causing an deallocation of the main run loop! Usually after about 5 instantiations/destructions of a LiveConnect applet. The CFRelease of the run loop was removed.
Reviewed by Hyatt.
- bindings/jni_jsobject.h: (KJS::Bindings::RootObject::~RootObject):
- 6:32 PM Changeset in webkit [5898]
-
- 5 copies2 deletes in tags/HTML-editing-hacks-anchor
This commit was manufactured by cvs2svn to create tag
'HTML-editing-hacks-anchor'.
- 6:32 PM Changeset in webkit [5897] by
-
- 3 edits in trunk/WebCore
Fix for 3527707, crash on w3c css page. Make sure height isn't allowed to be negative when computing
positioned elements' heights. Also bulletproof the crash in case there are other negative height code
paths.
Reviewed by john
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::getAbsoluteRepaintRectIncludingFloats):
- khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteVertical):
- 5:12 PM Changeset in webkit [5896] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/3527853>: REGRESSION (119-120): Peoplesoft menus do not work
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scrollToAnchor): Right before calling checkCompleted(), set m_bComplete to false, so it can get set right back to true if we're actually done loading and fire all the right signals.
- 11:36 AM Changeset in webkit [5895] by
-
- 2 edits in trunk/WebCore
Fix for 3526710, applets need to have the correct initial size after a layout has been done, since our
Java applets can't yet resize.
Reviewed by john
- khtml/rendering/render_applet.cpp: (RenderApplet::createWidgetIfNecessary): (RenderApplet::layout): (RenderEmptyApplet::layout):
- 10:04 AM Changeset in webkit [5894]
-
- 350 copies in branches/HTML-editing-hacks-branch
This commit was manufactured by cvs2svn to create branch
'HTML-editing-hacks-branch'.
- 10:04 AM Changeset in webkit [5893] by
-
- 31 edits in branches
Reviewed by me
Merged TOT onto the branch
- ChangeLog:
- WebCore.pbproj/project.pbxproj:
- khtml/css/css_valueimpl.h:
- khtml/css/cssparser.cpp:
- khtml/ecma/kjs_html.cpp: (KJS::HTMLCollection::getNamedItems):
- khtml/ecma/kjs_html.lut.h: (KJS::):
- khtml/html/dtd.cpp: (DOM::checkChild):
- khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance):
- khtml/khtml_part.cpp: (KHTMLPart::text): (KHTMLPart::setSelection): (KHTMLPart::slotClearSelection): (KHTMLPart::setZoomFactor): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::emitCaretPositionChanged): (KHTMLPart::moveCaretTo):
- khtml/khtml_part.h:
- khtml/khtmlview.cpp: (KHTMLViewPrivate::KHTMLViewPrivate): (KHTMLViewPrivate::editorContext): (KHTMLView::clear): (KHTMLView::resizeEvent): (KHTMLView::drawContents): (KHTMLView::layout): (KHTMLView::dispatchMouseEvent): (KHTMLView::moveCaretTo):
- khtml/khtmlview.h:
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::positionNewFloats):
- khtml/rendering/render_frames.cpp: (RenderPart::updateWidgetPositions):
- khtml/rendering/render_frames.h:
- khtml/rendering/render_image.cpp: (RenderImage::setPixmap):
- khtml/rendering/render_style.cpp: (StyleCSS3InheritedData::~StyleCSS3InheritedData):
- khtml/rendering/render_style.h:
- khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows): (RenderTableCell::setStyle):
- khtml/rendering/render_table.h: (khtml::RenderTableCol::lineHeight):
- khtml/rendering/render_text.cpp: (RenderText::paintObject):
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::attach): (DocumentImpl::setInPageCache):
- khtml/xml/dom_docimpl.h:
- kwq/KWQAccObject.mm: (-[KWQAccObject roleDescription]): (-[KWQAccObject value]): (-[KWQAccObject accessibilityIsIgnored]): (-[KWQAccObject accessibilityActionDescription:]):
- kwq/KWQEvent.mm: (keyIdentifierForKeyEvent): (QKeyEvent::QKeyEvent):
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache): (KWQKHTMLPart::scrollToAnchor): (KWQKHTMLPart::attributedString):
- kwq/KWQPageState.h:
- kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:interpreterBuiltins:]): (-[KWQPageState clear]): (-[KWQPageState invalidate]): (-[KWQPageState dealloc]): (-[KWQPageState interpreterBuiltins]):
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge computePageRectsWithPrintWidth:printHeight:]): (-[WebCoreBridge setTextSizeMultiplier:]): (-[WebCoreBridge needsLayout]): (-[WebCoreBridge setNeedsLayout]):
- kwq/WebCoreJavaScript.mm: (+[WebCoreJavaScript rootObjectClasses]): (+[WebCoreJavaScript garbageCollect]):
Jan 12, 2004:
- 9:04 AM Changeset in webkit [5892] by
-
- 4 edits in branches
Reviewed by me
Some more clean up to basic caret movement and basic editing.
Fixed deleting BR's, which I broke late last week.
- khtml/editing/htmlediting.cpp: (EditCommand::notifyChanged): (EditCommand::deleteSelection): (EditCommand::pruneEmptyNodes): (InputTextCommand::apply): (DeleteTextCommand::apply):
- khtml/editing/htmlediting.h:
- khtml/khtml_part.cpp: (KHTMLPart::moveCaretTo):
Jan 11, 2004:
- 4:42 PM Changeset in webkit [5891] by
-
- 3 edits in trunk
changed version number from '121' to '122u'
- 4:27 PM Changeset in webkit [5890]
-
- 3 copies in tags/Safari-121
This commit was manufactured by cvs2svn to create tag 'Safari-121'.
- 4:27 PM Changeset in webkit [5889] by
-
- 3 edits in trunk
Safari-121 stamp
(Ordinarily this checkin would show the version number change to project.pbxproj files, but I accidentally changed the version number to '121' instead of '121u' when I opened the tree after Safari-120.)
- 12:09 PM Changeset in webkit [5888] by
-
- 2 edits in trunk/WebCore
- fixed Dave's check-in so it compiles; I assume he forgot to land one source file
- khtml/khtmlview.h: Add RenderPart to the friends of KHTMLView.
- 11:06 AM Changeset in webkit [5887] by
-
- 3 edits in trunk/WebCore
Fix for frame repainting bugs (3510669, 3515442). This is a narrower fix than the previous attempt.
Reviewed by darin
- khtml/rendering/render_frames.cpp: (RenderPart::updateWidgetPositions):
- khtml/rendering/render_frames.h:
- khtml/rendering/render_replaced.cpp: (RenderWidget::updateWidgetPositions):
Jan 10, 2004:
- 4:08 PM Changeset in webkit [5886] by
-
- 4 edits in trunk/WebKit
Reviewed by John.
- fixed 3524906: REGRESSION (114-115): page with plug-in content never stops loading (travelking.com.tw)
Put the plug-in streams clients into their own separate set. Now a plug-in client is not considered part
of "loading", but it does participate in the callback deferral mechanism, which was the real goal of the
change I made that introduced this regression. Also remove the plug-in client in one case I had missed
before (cancel).
- WebView.subproj/WebDataSourcePrivate.h: Added a new set of plugInStreamClients.
- WebView.subproj/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): Release the set. (-[WebDataSource _addPlugInStreamClient:]): Added. Adds to the set. (-[WebDataSource _removePlugInStreamClient:]): Added. Removes from the set. (-[WebDataSource _defersCallbacksChanged]): Added code to loop through plugInStreamClients too.
- Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream start]): Use _add/removePlugInStreamClient instead of _add/removeSubresourceClient. (-[WebNetscapePluginConnectionDelegate connectionDidFinishLoading:]): Ditto. (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): Ditto. (-[WebNetscapePluginConnectionDelegate cancelWithError:]): Override to call _removePlugInStreamClient and then call super.
- 12:10 PM Changeset in webkit [5885] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
- fixed 3525468: REGRESSION (114-115): HOMEPAGE: after hitting textarea limit, backspace key is ignored
- kwq/KWQEvent.mm: (keyIdentifierForKeyEvent): Treat 7F as 08; matches other browsers. (QKeyEvent::QKeyEvent): Ditto.
