Timeline



Jan 19, 2004:

5:18 PM Changeset in webkit [5931] by mjs
  • 2 edits in branches/Safari-1-0-branch/WebCore

Merged security fix from HEAD. Clone for this branch is:

<rdar://problem/3533737>: Safari allows upload of arbitrary local files w/o user's knowledge or permission (SUJagBullet)

2004-01-19 Maciej Stachowiak <​mjs@apple.com>

Reviewed by John, Ken, Dave.

<rdar://problem/3533319>: Safari allows upload of arbitrary local files w/o user's knowledge or permission

  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::value): Don't fall back to the value attribute for file inputs, since that way malicious HTML could force the user to upload files unexpectedly.
5:13 PM Changeset in webkit [5930] by mjs
  • 2 edits in branches/SUPanBisque-branch/WebCore

Merged fix from HEAD to address. Clone for this branch is:

<rdar://problem/3533734>: Safari allows upload of arbitrary local files w/o user's knowledge or permission (SUPanXpress)

2004-01-19 Maciej Stachowiak <​mjs@apple.com>

Reviewed by John, Ken, Dave.

<rdar://problem/3533319>: Safari allows upload of arbitrary local files w/o user's knowledge or permission

  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::value): Don't fall back to the value attribute for file inputs, since that way malicious HTML could force the user to upload files unexpectedly.
4:58 PM Changeset in webkit [5929] by mjs
  • 2 edits in trunk/WebCore

Reviewed by John, Ken, Dave.

<rdar://problem/3533319>: Safari allows upload of arbitrary local files w/o user's knowledge or permission

  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::value): Don't fall back to the value attribute for file inputs, since that way malicious HTML could force the user to upload files unexpectedly.
4:09 PM Changeset in webkit [5928] by kocienda
  • 17 edits in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me.

Made KHTMLPart now use a KHTMLSelection object rather
than its own member variables to track the selection.

Reorganized KHTMLSelection to use a "base and extent"
rather than a "start and end". This makes the "pivot
around mouse click" behavior while clicking and
dragging to make a selection much easier to implement.

Some other improvements to KHTMLSelection as well,
like some more overloaded operators.

  • khtml/editing/htmlediting.cpp: (EditCommand::deleteSelection):
  • khtml/khtml_part.cpp: (KHTMLPart::init): (KHTMLPart::clear): (KHTMLPart::findTextNext): (KHTMLPart::hasSelection): (KHTMLPart::selection): (KHTMLPart::setSelection): (KHTMLPart::slotClearSelection): (startAndEndLineNodesIncludingNode): (KHTMLPart::isPointInsideSelection): (KHTMLPart::handleMousePressEventDoubleClick): (KHTMLPart::handleMousePressEventTripleClick): (KHTMLPart::handleMousePressEventSingleClick): (KHTMLPart::handleMouseMoveEventSelection): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::selectAll): (KHTMLPart::caret):
  • khtml/khtml_part.h:
  • khtml/khtml_selection.cpp: (KHTMLSelection::KHTMLSelection): (KHTMLSelection::~KHTMLSelection): (KHTMLSelection::operator=): (KHTMLSelection::setSelection): (KHTMLSelection::setBase): (KHTMLSelection::setExtent): (KHTMLSelection::clearSelection): (KHTMLSelection::setBaseNode): (KHTMLSelection::setBaseOffset): (KHTMLSelection::setExtentNode): (KHTMLSelection::setExtentOffset): (KHTMLSelection::invalidate): (KHTMLSelection::isEmpty): (KHTMLSelection::repaint): (KHTMLSelection::nodeIsBeforeNode):
  • khtml/khtml_selection.h: (KHTMLSelection::startNode): (KHTMLSelection::startOffset): (KHTMLSelection::endNode): (KHTMLSelection::endOffset): (KHTMLSelection::dump): (operator==): (operator!=):
  • khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): (KHTMLPartPrivate::~KHTMLPartPrivate):
  • khtml/khtmlview.cpp:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setSelection):
  • khtml/xml/dom_docimpl.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::jumpToSelection): (KWQKHTMLPart::selectionStartOffset): (KWQKHTMLPart::selectionEndOffset): (KWQKHTMLPart::selectionStart): (KWQKHTMLPart::selectionEnd):
10:12 AM Changeset in webkit [5927] by kocienda
  • 9 edits
    8 adds in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me

Initial pass at trying to clean up mouse event handling
in KHTMLPart, with emphasis on making the selection
code more readable. Actually, this breaks editing, but
the point the code is in now is a good checkpoint.
I will fix editing soon, and it will be much better for it.

  • WebCore.pbproj/project.pbxproj:
  • khtml/editing/edit_caret.cpp: (Caret::Caret): (Caret::moveTo): (Caret::moveForwardByCharacter): (Caret::moveBackwardByCharacter): (Caret::adjustPosition): (Caret::invalidate): (Caret::repaint): (Caret::paint): (Caret::ensureNodeHasFocus):
  • khtml/editing/edit_caret.h: (khtml::Caret::size):
  • khtml/editing/htmlediting.cpp: (EditCommand::pruneEmptyNodes): (InputTextCommand::apply): (DeleteTextCommand::apply):
  • khtml/khtml_part.cpp: (KHTMLPart::init): (KHTMLPart::findTextNext): (KHTMLPart::setSelection): (KHTMLPart::checkSelectionPoint): (KHTMLPart::handleMousePressEventDoubleClick): (KHTMLPart::handleMousePressEventTripleClick): (KHTMLPart::handleMousePressEventSingleClick): (KHTMLPart::khtmlMousePressEvent): (isBeforeNode): (KHTMLPart::handleMouseMoveEventDrag): (KHTMLPart::handleMouseMoveEventOver): (KHTMLPart::handleMouseMoveEventSelection): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::selectAll): (KHTMLPart::caret):
  • khtml/khtml_part.h:
  • khtml/khtml_selection.cpp: Added. (KHTMLSelection::KHTMLSelection): (KHTMLSelection::~KHTMLSelection): (KHTMLSelection::setSelection): (KHTMLSelection::clearSelection): (KHTMLSelection::setStartNode): (KHTMLSelection::setStartOffset): (KHTMLSelection::setEndNode): (KHTMLSelection::setEndOffset): (KHTMLSelection::setVisible): (KHTMLSelection::invalidate): (KHTMLSelection::paint): (KHTMLSelection::setPart): (KHTMLSelection::timerEvent): (KHTMLSelection::repaint):
  • khtml/khtml_selection.h: Added. (KHTMLSelection::): (KHTMLSelection::state): (KHTMLSelection::startNode): (KHTMLSelection::startOffset): (KHTMLSelection::endNode): (KHTMLSelection::endOffset): (KHTMLSelection::caretNode): (KHTMLSelection::caretOffset): (KHTMLSelection::visible):
  • khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): (KHTMLPartPrivate::~KHTMLPartPrivate):
  • khtml/khtmlview.cpp: (KHTMLView::focusNextPrevNode):
10:12 AM Changeset in webkit [5926] by kocienda
  • in /

file khtml_selection.cpp was initially added on branch HTML-editing-hacks-branch.

10:12 AM Changeset in webkit [5925] by kocienda
  • in /

file khtml_selection.h was initially added on branch HTML-editing-hacks-branch.

Jan 18, 2004:

6:10 PM Changeset in webkit [5924] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3532569, bugzilla patch viewer doesn't work. My previous fix for 3531983 caused moves to happen
when they should not have, due to childX and childY not being implemented at all on KWQScrollView.

Reviewed by darin

  • kwq/KWQScrollView.mm: (QScrollView::childX): (QScrollView::childY):

Jan 16, 2004:

6:45 PM Changeset in webkit [5923] by vicki
  • 3 edits in trunk

set version number to '125u'. The tree is open for Safari-125.

6:26 PM Changeset in webkit [5922]
  • 3 copies in tags/Safari-124

This commit was manufactured by cvs2svn to create tag 'Safari-124'.

6:26 PM Changeset in webkit [5921] by vicki
  • 6 edits in trunk

Safari-124 stamp

3:42 PM Changeset in webkit [5920] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3531983, fixed positioning not working for widgets. Make sure to move widgets at paint time
if necessary.

Reviewed by darin

  • khtml/rendering/render_replaced.cpp: (RenderWidget::paintObject):
3:23 PM Changeset in webkit [5919] by rjw
  • 13 edits in trunk/JavaScriptCore

JavaScriptCore:

Fixed 3525853. We weren't handling mapping to overloaded Java
methods very well. Even though this is undefined the other
browsers support it. Also fixed a bug with returning arrays
from Java functions.

Reviewed by John.

  • bindings/jni/jni_class.cpp: (JavaClass::_commonInit): (JavaClass::methodsNamed):
  • bindings/jni/jni_class.h:
  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_runtime.cpp: (JavaArray::convertJObjectToArray): (JavaField::valueFromInstance): (JavaMethod::signature): (JavaArray::valueAt):
  • bindings/jni/jni_runtime.h:
  • bindings/jni_jsobject.cpp: (JSObject::call): (JSObject::convertJObjectToValue):
  • bindings/runtime.cpp: (MethodList::addMethod): (MethodList::length): (MethodList::methodAt): (MethodList::~MethodList):
  • bindings/runtime.h: (KJS::Bindings::MethodList::MethodList):
  • bindings/runtime_method.cpp: (RuntimeMethodImp::RuntimeMethodImp): (RuntimeMethodImp::get): (RuntimeMethodImp::call):
  • bindings/runtime_method.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::get): (RuntimeObjectImp::hasProperty):

Tests:

Extending test to cover issues in 3525853.

Reviewed by John.

  • ChangeLog:
  • LiveConnect/Blink/Blink.java: (Blink.init): (Blink.getStrings): (Blink): (Blink.getManyNumbers): (Blink.overloadedFunction):
  • LiveConnect/Blink/Blink.pbproj/project.pbxproj:
  • LiveConnect/Blink/test.html:
10:59 AM Changeset in webkit [5918] by rjw
  • 2 edits in trunk/JavaScriptCore

Fixed 3531229. Another place that needs the Push/PopLocalFrame
protection implemented for 3530401.

Reviewed by John.

  • bindings/runtime_method.cpp: (RuntimeMethodImp::call):

Jan 15, 2004:

5:58 PM Changeset in webkit [5917] by rjw
  • 8 edits in trunk/JavaScriptCore

Fixed 3530401. JNI doesn't cleanup local refs created on the
main thread. IMO this is a bad bug in our JMI implementation.

To work-around the problem I explicitly delete all local refs.
Further, I've added Push/PopLocalFrame calls to catch any refs
that I may have missed. This will guarantee that we don't leak
any Java references.

Reviewed by John.

  • bindings/jni/jni_class.cpp: (JavaClass::_commonInit): (JavaClass::JavaClass):
  • bindings/jni/jni_instance.cpp: (JavaInstance::begin): (JavaInstance::end):
  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_runtime.cpp: (JavaConstructor::JavaConstructor): (JavaMethod::JavaMethod):
  • bindings/jni_jsobject.cpp: (JSObject::listFromJArray):
  • bindings/runtime.h: (KJS::Bindings::Instance::begin): (KJS::Bindings::Instance::end):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::get): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut): (RuntimeObjectImp::hasProperty): (RuntimeObjectImp::defaultValue):
4:53 PM Changeset in webkit [5916] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3530734, many java applets don't show up. Go ahead and just use the width/height from the style
system as the initial size when the width/height are fixed.

Reviewed by rjw

  • khtml/rendering/render_applet.cpp: (RenderApplet::createWidgetIfNecessary):
4:14 PM Changeset in webkit [5915] by kocienda
  • 7 edits in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me

A lot of clean up in the caret class now that the
old khtmlview functions have been moved in. Many
functions have been factored together and the
API now makes a lot more sense.

  • khtml/editing/edit_caret.cpp: (Caret::Caret): (Caret::setPosition): (Caret::moveForwardByCharacter): (Caret::moveBackwardByCharacter): (Caret::adjustPosition): (Caret::invalidate): (Caret::setVisible): (Caret::repaint): (Caret::paint): (Caret::timerEvent):
  • khtml/editing/edit_caret.h: (khtml::Caret::visible):
  • khtml/editing/htmlediting.cpp: (InputTextCommand::apply):
  • khtml/khtml_part.cpp: (KHTMLPart::setSelection): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::moveCaretTo):
  • khtml/khtmlview.cpp: (KHTMLView::init): (KHTMLView::clear): (KHTMLView::focusNextPrevNode): (KHTMLView::focusInEvent): (KHTMLView::focusOutEvent):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint):
3:44 PM Changeset in webkit [5914] by rjw
  • 1 edit in trunk/WebCore/kwq/KWQKHTMLPart.mm

I previously checked the fix for 3529426, but the fix was commented out. Oops.

1:36 PM Changeset in webkit [5913] by kocienda
  • 15 edits
    2 adds in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me

Purged all caret member functions from KHTMLView,
rolling them all into the Caret class.

  • khtml/dom/dom_node.cpp:
  • khtml/dom/dom_node.h:
  • khtml/editing/edit_caret.cpp: (Caret::Caret): (Caret::part): (Caret::view): (Caret::initCaret): (Caret::invalidate): (Caret::recalcAndStoreCaretPos): (Caret::caretOn): (Caret::caretOff): (Caret::showCaret): (Caret::hideCaret): (Caret::updateView): (Caret::placeCaret): (Caret::paintCaret): (Caret::timerEvent): (Caret::ensureNodeHasFocus):
  • khtml/editing/edit_caret.h: (khtml::Caret::node): (khtml::Caret::offset): (khtml::Caret::xPos): (khtml::Caret::yPos): (khtml::Caret::height): (khtml::Caret::visible): (khtml::Caret::displayed):
  • khtml/editing/htmlediting.cpp: (InputTextCommand::apply):
  • khtml/html/html_elementimpl.cpp:
  • khtml/khtml_part.cpp: (KHTMLPart::setSelection): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::moveCaretTo):
  • khtml/khtml_part.h:
  • khtml/khtmlview.cpp: (KHTMLView::init): (KHTMLView::clear): (KHTMLView::resizeEvent): (KHTMLView::layout): (KHTMLView::focusNextPrevNode): (KHTMLView::focusInEvent): (KHTMLView::focusOutEvent): (KHTMLView::timerEvent): (KHTMLView::complete):
  • khtml/khtmlview.h:
  • khtml/rendering/render_object.h:
  • khtml/xml/dom_nodeimpl.cpp:
  • khtml/xml/dom_nodeimpl.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint):
1:18 PM Changeset in webkit [5912] by rjw
  • 2 edits in trunk/WebCore

Fixed 3529426. Exclude pages that contain Java applets from
the page cache. The means applets get the normal stop/destroy
messages that they expect when a user leaves a page.

Reviewed by John.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canCachePage):
11:06 AM Changeset in webkit [5911] by vicki
  • 7 edits in trunk

JavaScriptCore:

Reviewed by Darin.

  • JavaScriptCore.pbproj/project.pbxproj: Update copyright date to 2004.

WebCore:

Reviewed by Darin.

  • WebCore.pbproj/project.pbxproj: Update copyright date to 2004.

WebKit:

Reviewed by Darin.

  • WebKit.pbproj/project.pbxproj: Update copyright date to 2004.
  • English.lproj/InfoPlist.strings: Update copyright date to 2004.

WebBrowser:

Reviewed by Darin.

  • WebBrowser.pbproj/project.pbxproj: Update copyright date to 2004.
8:29 AM Changeset in webkit [5910] by kocienda
  • 1 edit
    2 deletes in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me

Files now obsolete.

  • khtml/editing/edit_caretimpl.cpp: Removed.
  • khtml/editing/edit_caretimpl.h: Removed.
8:28 AM Changeset in webkit [5909] by kocienda
  • 27 edits in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me

First batch of changes from my notes I wrote while chatting
with Dave. Many small improvements.

  • WebCore.pbproj/project.pbxproj:
  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
  • khtml/css/cssvalues.c: (hash_val): (findValue):
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
  • khtml/editing/edit_caret.cpp: (Caret::Caret): (Caret::~Caret): (Caret::node): (Caret::offset): (Caret::setPosition): (Caret::moveForwardByCharacter): (Caret::moveBackwardByCharacter): (Caret::adjustPosition): (Caret::notifyChanged):
  • khtml/editing/edit_caret.h: (khtml::Caret::Caret):
  • khtml/editing/edit_caretimpl.h:
  • khtml/editing/htmlediting.cpp: (EditCommand::pruneEmptyNodes): (InputTextCommand::apply): (DeleteTextCommand::apply):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute): (HTMLElementImpl::contentEditable): (HTMLElementImpl::setContentEditable): (HTMLElementImpl::defaultEventHandler):
  • khtml/khtml_part.cpp: (KHTMLPart::clear): (KHTMLPart::findTextNext): (KHTMLPart::setSelection): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::selectAll): (KHTMLPart::isEditingAtCaret): (KHTMLPart::caret): (KHTMLPart::moveCaretTo): (KHTMLPart::collapseSelectionToCaret):
  • khtml/khtml_part.h:
  • khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): (KHTMLPartPrivate::~KHTMLPartPrivate):
  • khtml/khtmlview.cpp: (KHTMLViewPrivate::KHTMLViewPrivate): (KHTMLViewPrivate::~KHTMLViewPrivate): (KHTMLViewPrivate::caretViewContext): (KHTMLView::initCaret): (KHTMLView::caretOverrides): (KHTMLView::recalcAndStoreCaretPos): (KHTMLView::placeCaret):
  • khtml/rendering/render_br.cpp: (RenderBR::caretMinOffset): (RenderBR::caretMaxOffset):
  • khtml/rendering/render_br.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::caretPos):
  • khtml/rendering/render_line.cpp: (InlineBox::caretMinOffset): (InlineBox::caretMaxOffset):
  • khtml/rendering/render_line.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::caretMinOffset): (RenderReplaced::caretMaxOffset):
  • khtml/rendering/render_replaced.h:
  • khtml/rendering/render_style.cpp: (userModify): (StyleCSS3InheritedData): (StyleCSS3InheritedData::shadowDataEquivalent):
  • khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::setBitDefaults): (khtml::RenderStyle::userModify): (khtml::RenderStyle::setUserModify):
  • khtml/rendering/render_text.h:
  • kwq/KWQKHTMLPart.mm: (KHTMLPart::caretPositionChanged): (KWQKHTMLPart::paint):
8:26 AM Changeset in webkit [5908] by darin
  • 2 edits in trunk/WebCore

Reviewed by Ken.

  • fixed 3529943: REGRESSION (119-120): nil-deref in KHTMLPart::javaEnabled when hitting back button
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance): Add missing nil check that the other call to javaEnabled has.
Note: See TracTimeline for information about the timeline view.