Context Navigation

← Previous Period
Next Period →

Timeline

Jan 22, 2004:

6:34 PM Changeset in webkit [5968] by hyatt

3 edits
8 adds in trunk

Fix a bug I accidentally introduced in static positioned elements. Add more margin collapsing tests.

ChangeLog:
khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlockChildren):
layout-tests/fast/block/margin-collapse/044-expected.txt: Added.
layout-tests/fast/block/margin-collapse/044.html: Added.
layout-tests/fast/block/margin-collapse/045-expected.txt: Added.
layout-tests/fast/block/margin-collapse/045.html: Added.
layout-tests/fast/block/margin-collapse/062-expected.txt: Added.
layout-tests/fast/block/margin-collapse/062.html: Added.
layout-tests/fast/block/margin-collapse/063-expected.txt: Added.
layout-tests/fast/block/margin-collapse/063.html: Added.
layout-tests/fast/block/positioning/007-expected.txt:

5:53 PM Changeset in webkit [5967] by hyatt

23 edits
18 adds in trunk/WebCore

(1) Implement better XML error handling.
(2) Fix a minor z-index bug with the 'initial' value.
(3) Initial landing of XBL support. Code is all ifnef KHTML_NO_XBL so that it can be turned off easily if
XBL never comes to fruition.

Reviewed by darin

ForwardingHeaders/xbl/xbl_binding_manager.h: Added.
ForwardingHeaders/xbl/xbl_docimpl.h: Added.
WebCore.pbproj/project.pbxproj:
khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssproperties.c: (hash_prop): (findProp):
khtml/css/cssproperties.h:
khtml/css/cssproperties.in:
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
khtml/dom/dom_element.cpp: (Element::getAttributeNS):
khtml/misc/loader.cpp: (CachedXBLDocument::CachedXBLDocument): (CachedXBLDocument::~CachedXBLDocument): (CachedXBLDocument::ref): (CachedXBLDocument::deref): (CachedXBLDocument::data): (CachedXBLDocument::checkNotify): (CachedXBLDocument::error): (DocLoader::requestXBLDocument): (Cache::requestXBLDocument): (CachedObjectClient::setXBLDocument): (Cache::getStatistics):
khtml/misc/loader.h: (khtml::CachedObject::): (khtml::CachedXBLDocument::document): (khtml::CachedXBLDocument::schedule):
khtml/misc/loader_client.h:
khtml/rendering/render_style.cpp: (bindingURI): (marquee): (StyleCSS3NonInheritedData::~StyleCSS3NonInheritedData): (StyleCSS3NonInheritedData::bindingsEquivalent): (StyleCSS3NonInheritedData::operator==): (:m_next): (BindingURI::~BindingURI): (BindingURI::copy): (BindingURI::operator==): (RenderStyle::addBindingURI):
khtml/rendering/render_style.h: (khtml::BindingURI::operator!=): (khtml::BindingURI::next): (khtml::BindingURI::setNext): (khtml::BindingURI::uri): (khtml::RenderStyle::bindingURIs): (khtml::RenderStyle::setHasAutoZIndex): (khtml::RenderStyle::setZIndex): (khtml::RenderStyle::deleteBindingURIs): (khtml::RenderStyle::inheritBindingURIs):
khtml/xbl/xbl_binding.cpp: Added. (XBL::m_markedForDeath): (XBL::XBLBindingChain::~XBLBindingChain): (XBL::XBLBindingChain::firstStyleBindingChain): (XBL::XBLBindingChain::lastBindingChain): (XBL::XBLBindingChain::insertBindingChain): (XBL::XBLBindingChain::markForDeath): (XBL::XBLBindingChain::loaded): (XBL::XBLBindingChain::hasStylesheets): (XBL::XBLBindingChain::failed): (XBL::m_nextBinding): (XBL::XBLBinding::~XBLBinding): (XBL::XBLBinding::loaded): (XBL::XBLBinding::setXBLDocument):
khtml/xbl/xbl_binding.h: Added. (XBL::): (XBL::XBLBindingChain::uri): (XBL::XBLBindingChain::nextChain): (XBL::XBLBindingChain::previousChain): (XBL::XBLBindingChain::setNextBindingChain): (XBL::XBLBindingChain::setPreviousBindingChain): (XBL::XBLBindingChain::markedForDeath): (XBL::XBLBindingChain::element):
khtml/xbl/xbl_binding_manager.cpp: Added. (XBL::m_bindingChainTable): (XBL::XBLBindingManager::~XBLBindingManager): (XBL::XBLBindingManager::getBindingChain): (XBL::XBLBindingManager::setBindingChain): (XBL::XBLBindingManager::loadBindings): (XBL::XBLBindingManager::checkLoadState):
khtml/xbl/xbl_binding_manager.h: Added.
khtml/xbl/xbl_docimpl.cpp: Added. (XBL:::DocumentImpl): (XBL::XBLDocumentImpl::~XBLDocumentImpl): (XBL::XBLDocumentImpl::createTokenHandler): (XBL::XBLDocumentImpl::setPrototypeBinding): (XBL::XBLDocumentImpl::prototypeBinding):
khtml/xbl/xbl_docimpl.h: Added. (XBL::):
khtml/xbl/xbl_protobinding.cpp: Added. (XBL::m_handler): (XBL::XBLPrototypeBinding::initialize): (XBL::XBLPrototypeBinding::document): (XBL::XBLPrototypeBinding::addResource):
khtml/xbl/xbl_protobinding.h: Added. (XBL::XBLPrototypeBinding::element): (XBL::XBLPrototypeBinding::setHandler): (XBL::XBLPrototypeBinding::handler):
khtml/xbl/xbl_protohandler.cpp: Added. (XBL::m_unused): (XBL::XBLPrototypeHandler::~XBLPrototypeHandler): (XBL::XBLPrototypeHandler::appendData):
khtml/xbl/xbl_protohandler.h: Added. (XBL::XBLPrototypeHandler::setNext): (XBL::XBLPrototypeHandler::next):
khtml/xbl/xbl_protoimplementation.cpp: Added. (XBL::m_compiled): (XBL::m_next): (XBL::XBLPrototypeMember::appendData): (XBL:::XBLPrototypeMember): (XBL::XBLPrototypeMethod::isConstructor): (XBL::XBLPrototypeMethod::isDestructor): (XBL::XBLPrototypeMethod::addParameter): (XBL:::XBLPrototypeMethod): (XBL::XBLPrototypeConstructor::isConstructor): (XBL::XBLPrototypeDestructor::isDestructor): (XBL::m_readonly): (XBL::XBLPrototypeProperty::appendGetterText): (XBL::XBLPrototypeProperty::appendSetterText):
khtml/xbl/xbl_protoimplementation.h: Added. (XBL::XBLPrototypeMember::~XBLPrototypeMember): (XBL::XBLPrototypeMember::setNext): (XBL::XBLPrototypeMember::next): (XBL::XBLPrototypeImplementation::~XBLPrototypeImplementation): (XBL::XBLPrototypeImplementation::setMember): (XBL::XBLPrototypeParameter::m_next): (XBL::XBLPrototypeParameter::~XBLPrototypeParameter): (XBL::XBLPrototypeParameter::next): (XBL::XBLPrototypeParameter::setNext): (XBL::):
khtml/xbl/xbl_tokenizer.cpp: Added. (XBL::XBLTokenHandler::XBLTokenHandler): (XBL::XBLTokenHandler::~XBLTokenHandler): (XBL::XBLTokenHandler::xblDocument): (XBL::XBLTokenHandler::startElement): (XBL::XBLTokenHandler::endElement): (XBL::XBLTokenHandler::characters): (XBL::XBLTokenHandler::createBinding): (XBL::XBLTokenHandler::createHandler): (XBL::XBLTokenHandler::createResource): (XBL::XBLTokenHandler::createImplementation): (XBL::XBLTokenHandler::addMember): (XBL::XBLTokenHandler::createConstructor): (XBL::XBLTokenHandler::createDestructor): (XBL::XBLTokenHandler::createField): (XBL::XBLTokenHandler::createProperty): (XBL::XBLTokenHandler::createMethod): (XBL::XBLTokenHandler::createParameter):
khtml/xbl/xbl_tokenizer.h: Added. (XBL::):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::createTokenHandler): (DocumentTypeImpl::DocumentTypeImpl): (DocumentTypeImpl::~DocumentTypeImpl):
khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::bindingManager):
khtml/xml/dom_elementimpl.cpp: (ElementImpl::getAttributeNS): (ElementImpl::childAllowed):
khtml/xml/dom_elementimpl.h: (DOM::ElementImpl::getAttribute):
khtml/xml/dom_nodeimpl.cpp:
khtml/xml/xml_tokenizer.cpp: (XMLHandler::XMLHandler): (XMLHandler::startDocument): (XMLHandler::startElement): (XMLHandler::endElement): (XMLHandler::startCDATA): (XMLHandler::endCDATA): (XMLHandler::characters): (XMLHandler::comment): (XMLHandler::processingInstruction): (XMLHandler::warning): (XMLHandler::error): (XMLHandler::fatalError): (XMLTokenizer::finish):
khtml/xml/xml_tokenizer.h:
kwq/KWQXmlSimpleReader.h: (QXmlSimpleReader::sawError): (QXmlSimpleReader::recordError):
kwq/KWQXmlSimpleReader.mm: (warningHandler): (fatalErrorHandler): (normalErrorHandler): (QXmlSimpleReader::parse):

5:14 PM Changeset in webkit [5966] by rjw

4 edits
2 adds in trunk/JavaScriptCore

Added stubs for ObjC language binding to JavaScript.

JavaScriptCore.pbproj/project.pbxproj:
bindings/jni/jni_runtime.h:
bindings/objc/objc_runtime.h: Added. (KJS::Bindings::ObjcParameter::ObjcParameter): (KJS::Bindings::ObjcParameter::~ObjcParameter): (KJS::Bindings::ObjcParameter::operator=): (KJS::Bindings::ObjcParameter::type): (KJS::Bindings::ObjcConstructor::ObjcConstructor): (KJS::Bindings::ObjcConstructor::~ObjcConstructor): (KJS::Bindings::ObjcConstructor::_commonCopy): (KJS::Bindings::ObjcConstructor::operator=): (KJS::Bindings::ObjcConstructor::value): (KJS::Bindings::ObjcConstructor::parameterAt): (KJS::Bindings::ObjcConstructor::numParameters): (KJS::Bindings::ObjcField::ObjcField): (KJS::Bindings::ObjcField::~ObjcField):
bindings/runtime.h:

5:10 PM Changeset in webkit [5965] by cblu

10 edits in trunk

WebCore:

Fixed: <rdar://problem/3537542>: support for copying HTML

Reviewed by dave.

khtml/xml/dom2_rangeimpl.cpp: (RangeImpl::toHTML): implemented
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::recursive_toHTMLWithRange): new
khtml/xml/dom_nodeimpl.h:
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge selectedHTML]): new (-[WebCoreBridge reconstructedSource]): new

WebKit:

Fixed: <rdar://problem/3537542>: support for copying HTML

Reviewed by dave.

WebView.subproj/WebHTMLRepresentation.h:
WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation reconstructedSource]): for BLOT's eventual use
WebView.subproj/WebHTMLView.m: (+[WebHTMLView _pasteboardTypes]): provide NSHTMLPboardType (-[WebHTMLView _writeSelectionToPasteboard:]): add HTML to the pasteboard

4:42 PM Changeset in webkit [5964] by rjw

5 edits in trunk/JavaScriptCore

Simplified JavaString by using UString as backing store. This
revealed a bug in CString's assignment operator which I fixed.

Removed some dead code.

Reviewed by John.

bindings/jni/jni_runtime.h: (KJS::Bindings::JavaString::JavaString): (KJS::Bindings::JavaString::_commonInit): (KJS::Bindings::JavaString::UTF8String): (KJS::Bindings::JavaString::uchars): (KJS::Bindings::JavaString::length): (KJS::Bindings::JavaString::ustring):
bindings/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp):
bindings/runtime_object.h:
kjs/ustring.cpp: (KJS::CString::CString): (KJS::CString::operator=):

2:59 PM Changeset in webkit [5963] by rjw

1 edit in trunk/JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj

Forgot to export this as a private header.

2:29 PM Changeset in webkit [5962] by rjw

1 edit
2 adds
2 deletes in trunk/JavaScriptCore

Moved jni_jsobject.* to the jni directory.

11:42 AM Changeset in webkit [5961] by sullivan

2 edits in trunk/WebKit

Tests:

Blot/blot-tasks.txt Added tasks for supporting preference panels

WebKit:

Reviewed by Chris.

English.lproj/StringsNotToBeLocalized.txt: brought this file back up to date

WebBrowser:

fixed <rdar://problem/3522522>: Tooltip typo: "word of phrase" instead of "word or phrase"
removed hack that we added at the last minute to get the copyright string correct

Reviewed by Chris.

BrowserApplication.m: (-[BrowserApplication orderFrontStandardAboutPanel:]): removed AppKit-string-snarfing hack; now we use a normal localizable string for the copyright string in the About box.

BrowserWindowController.m: (-[BrowserWindowController setUpSearchField]): fixed typo that was previously fixed only in the English localization

English.lproj/Localizable.strings:
English.lproj/StringsNotToBeLocalized.txt: brought these two files up to date

8:45 AM Changeset in webkit [5960] by darin

2 edits in trunk/WebKit

fixed 3536624: Webkit 1.2 links against SecurityNssAsn1.framework

WebKit.pbproj/project.pbxproj: Remove SecurityNssAsn1.framework from the list we link against. It's still included in the list for places to find headers.

1:18 AM Changeset in webkit [5959] by hyatt

4 adds in trunk/LayoutTests/fast/block/margin-collapse

Adding even more margin collapsing tests... courtesy of Hixie.

Jan 21, 2004:

7:10 PM Changeset in webkit [5958] by hyatt

1 edit in trunk/WebCore/WebCore.pbproj/project.pbxproj

Fix build bustage.

6:59 PM Changeset in webkit [5957] by hyatt

1 edit in trunk/WebCore/WebCore.pbproj/project.pbxproj

Fix build bustage with libxml include path.

6:52 PM Changeset in webkit [5956] by hyatt

6 adds in trunk/LayoutTests/fast/block/margin-collapse

Add margin collapsing tests.

6:49 PM Changeset in webkit [5955] by hyatt

2 edits in trunk/WebCore

Fix for two margin collapsing edge cases.

Reviewed by darin

khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlockChildren):

6:45 PM Changeset in webkit [5954] by hyatt

6 edits
1 delete in trunk/WebCore

Switch from expat to libxml and implement namespace support in the simplereader.

Reviewed by darin

ChangeLog:
expat/Changes: Removed.
expat/MANIFEST: Removed.
expat/README: Removed.
expat/expat_config.h: Removed.
expat/lib/ascii.h: Removed.
expat/lib/asciitab.h: Removed.
expat/lib/expat.h: Removed.
expat/lib/iasciitab.h: Removed.
expat/lib/internal.h: Removed.
expat/lib/latin1tab.h: Removed.
expat/lib/nametab.h: Removed.
expat/lib/utf8tab.h: Removed.
expat/lib/xmlparse.c: Removed.
expat/lib/xmlrole.c: Removed.
expat/lib/xmlrole.h: Removed.
expat/lib/xmltok.c: Removed.
expat/lib/xmltok.h: Removed.
expat/lib/xmltok_impl.c: Removed.
expat/lib/xmltok_impl.h: Removed.
expat/lib/xmltok_ns.c: Removed.
kwq/KWQXmlAttributes.h: (QXmlAttributes::QXmlAttributes): (QXmlAttributes::qName): (QXmlAttributes::uri):
kwq/KWQXmlAttributes.mm: (QXmlAttributes::QXmlAttributes): (QXmlAttributes::~QXmlAttributes): (QXmlAttributes::operator=): (QXmlAttributes::localName): (QXmlAttributes::split):
kwq/KWQXmlSimpleReader.h: (KWQXmlNamespace::m_ref): (KWQXmlNamespace::uriForPrefix): (KWQXmlNamespace::ref): (KWQXmlNamespace::deref): (QXmlParseException::QXmlParseException): (QXmlParseException::message): (QXmlParseException::columnNumber): (QXmlParseException::lineNumber): (QXmlSimpleReader::errorHandler): (QXmlSimpleReader::xmlNamespace): (QXmlSimpleReader::parserStopped):
kwq/KWQXmlSimpleReader.mm: (startElementHandler): (endElementHandler): (charactersHandler): (processingInstructionHandler): (cdataBlockHandler): (commentHandler): (warningHandler): (fatalErrorHandler): (QXmlSimpleReader::pushNamespaces): (QXmlSimpleReader::popNamespaces): (QXmlSimpleReader::parse): (QXmlSimpleReader::stopParsing): (QXmlSimpleReader::lineNumber): (QXmlSimpleReader::columnNumber):

6:30 PM Changeset in webkit [5953] by hyatt

4 edits in trunk/WebCore

Add some methods to dicts and stacks that exist in Qt.

Reviewed by darin

kwq/KWQDict.h: (QDict::replace):
kwq/KWQPtrDict.h: (QPtrDict::replace): (QPtrDict::find):
kwq/KWQPtrStack.h: (QPtrStack::current): (QPtrStack::setAutoDelete):

2:25 PM Changeset in webkit [5952] by vicki

3 edits in trunk

change version number to from '125' to '126u'

2:13 PM Changeset in webkit [5951]

3 copies in tags/Safari-125

This commit was manufactured by cvs2svn to create tag 'Safari-125'.

2:13 PM Changeset in webkit [5950]

3 copies in branches/Safari-1-2-tarballs-branch

This commit was manufactured by cvs2svn to create branch
'Safari-1-2-tarballs-branch'.

2:13 PM Changeset in webkit [5949]

3 copies in tags/Safari-1-2-tarballs-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-1-2-tarballs-anchor'.

2:13 PM Changeset in webkit [5948]

3 copies in tags/Safari-1-2-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-1-2-anchor'.

2:13 PM Changeset in webkit [5947]

3 copies in tags/Safari-1-2

This commit was manufactured by cvs2svn to create tag 'Safari-1-2'.

2:13 PM Changeset in webkit [5946]

3 copies
1 delete in branches/SUPanFeldspar-branch

This commit was manufactured by cvs2svn to create branch
'SUPanFeldspar-branch'.

2:13 PM Changeset in webkit [5945] by vicki

6 edits in trunk

Safari-125 stamp

Jan 20, 2004:

4:58 PM Changeset in webkit [5944] by vicki

1 edit in branches/SUPanBisque-branch/WebCore/ChangeLog-2005-08-23

added a release marker for Security Update fix, WebCore-106.4

4:55 PM Changeset in webkit [5943] by vicki

1 edit in branches/Safari-1-0-branch/WebCore/ChangeLog-2005-08-23

added a release marker for Security Update fix, WebCore-85.6

4:51 PM Changeset in webkit [5942] by kocienda

3 edits in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me.

With one very small exception, deleting new lines,
editing is back to where it was before I started
my caret-to-selection makeover.

khtml/editing/htmlediting.cpp: (EditCommand::EditCommand): (EditCommand::notifyChanged): (EditCommand::deleteSelection): (EditCommand::pruneEmptyNodes): (DeleteTextCommand::apply):
khtml/editing/htmlediting.h: (khtml::EditCommand::document):

4:39 PM Changeset in webkit [5941]

9 copies
2 deletes in tags/WebCore-85~6

This commit was manufactured by cvs2svn to create tag 'WebCore-85~6'.

4:39 PM Changeset in webkit [5940] by vicki

1 edit in branches/Safari-1-0-branch/WebCore/WebCore.pbproj/project.pbxproj

bump WebCore version number from 85.5 to 85.6, for Security Update fix <rdar://problem/3533737>: Safari allows upload of arbitrary local files w/o user's knowledge or permission (SUJagBullet)

4:24 PM Changeset in webkit [5939] by kocienda

10 edits in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me.

Editing is basically working again. I have
some crashers to hunt down when deleting, but
this is a good checkpoint.

khtml/editing/htmlediting.cpp: (EditCommand::pruneEmptyNodes): (InputTextCommand::apply): (DeleteTextCommand::apply):
khtml/khtml_selection.cpp: (KHTMLSelection::KHTMLSelection): (KHTMLSelection::operator=): (KHTMLSelection::setSelection): (KHTMLSelection::startNode): (KHTMLSelection::startOffset): (KHTMLSelection::endNode): (KHTMLSelection::endOffset): (KHTMLSelection::setStart): (KHTMLSelection::setStartOffset): (KHTMLSelection::setEnd):
khtml/khtml_selection.h: (KHTMLSelection::dump):

3:27 PM Changeset in webkit [5938] by kocienda

13 edits
1 delete in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me

Some more clean up. Removed vestiges of old
standalone caret object. Fixed up some caret
repaint issues. Switched over editing commands
to use new selection object.

ForwardingHeaders/editing/edit_caret.h: Removed.
WebCore.pbproj/project.pbxproj:
khtml/editing/htmlediting.cpp: (EditCommand::pruneEmptyNodes): (InputTextCommand::apply): (DeleteTextCommand::apply):
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::defaultEventHandler):
khtml/khtml_part.cpp: (KHTMLPart::topLevelFrameCount):
khtml/khtml_part.h:
khtml/khtml_selection.cpp: (KHTMLSelection::invalidate): (KHTMLSelection::repaint):
khtml/khtmlpart_p.h:
khtml/khtmlview.cpp: (KHTMLView::clear): (KHTMLView::resizeEvent): (KHTMLView::focusInEvent): (KHTMLView::focusOutEvent):
kwq/KWQKHTMLPart.mm:

3:16 PM Changeset in webkit [5937]

30 copies
2 deletes in tags/WebCore-106~4

This commit was manufactured by cvs2svn to create tag
'WebCore-106~4'.

3:16 PM Changeset in webkit [5936] by vicki

1 edit in branches/SUPanBisque-branch/WebCore/WebCore.pbproj/project.pbxproj

bumped the WebCore version from 106.3 to 106.4, for Security Update fix <rdar://problem/3533734>: Safari allows upload of arbitrary local files w/o user's knowledge or permission (SUPanXpress)

2:30 PM Changeset in webkit [5935] by kocienda

7 edits in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me

Cleanups to caret painting.

khtml/khtml_part.cpp: (KHTMLPart::khtmlMouseReleaseEvent):
khtml/khtml_selection.cpp: (KHTMLSelection::clearSelection): (KHTMLSelection::paint):
khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject):

2:05 PM Changeset in webkit [5934] by kocienda

10 edits in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me

Gor caret painting limping along again.

khtml/khtml_part.cpp: (KHTMLPart::init): (KHTMLPart::getKHTMLSelection): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::isEditingAtCaret):
khtml/khtml_part.h:
khtml/khtml_selection.cpp: (KHTMLSelection::clearSelection): (KHTMLSelection::invalidate):
khtml/khtmlview.cpp: (KHTMLView::layout):
khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject):
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint):

11:29 AM Changeset in webkit [5933] by kocienda

2 edits in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me

Removed the last remnants of the now-obsolete
CaretViewContext class.

khtml/khtmlview.cpp: (KHTMLViewPrivate::KHTMLViewPrivate): (KHTMLViewPrivate::~KHTMLViewPrivate): (KHTMLView::drawContents):

11:23 AM Changeset in webkit [5932] by kocienda

14 edits in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me

A lot of cleanup to the way selections are made
with the mouse by clicking and dragging. A lot
of code was made simpler, and much of the
remaining logic was moved from KHTMLPart to
KHTMLSelection.

khtml/khtml_part.cpp: (KHTMLPart::hasSelection): (KHTMLPart::handleMousePressEventDoubleClick): (KHTMLPart::handleMousePressEventTripleClick): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::handleMouseMoveEventSelection): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::selectAll):
khtml/khtml_selection.cpp: (KHTMLSelection::KHTMLSelection): (KHTMLSelection::operator=): (KHTMLSelection::startNode): (KHTMLSelection::startOffset): (KHTMLSelection::endNode): (KHTMLSelection::endOffset): (KHTMLSelection::invalidate): (KHTMLSelection::setBaseNode): (KHTMLSelection::setBaseOffset): (KHTMLSelection::setExtentNode): (KHTMLSelection::setExtentOffset): (KHTMLSelection::setStartNode): (KHTMLSelection::setStartOffset): (KHTMLSelection::setEndNode): (KHTMLSelection::setEndOffset): (KHTMLSelection::expandSelection): (KHTMLSelection::calculateStartAndEnd): (findWordBoundary): (firstRunAt): (lastRunAt): (startAndEndLineNodesIncludingNode):
khtml/khtml_selection.h: (KHTMLSelection::): (KHTMLSelection::baseNode): (KHTMLSelection::baseOffset): (KHTMLSelection::extentNode): (KHTMLSelection::extentOffset): (operator==):
khtml/khtmlpart_p.h:
khtml/xml/dom_docimpl.cpp: (DocumentImpl::setSelection):
khtml/xml/dom_docimpl.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent):

Jan 19, 2004:

5:18 PM Changeset in webkit [5931] by mjs

2 edits in branches/Safari-1-0-branch/WebCore

Merged security fix from HEAD. Clone for this branch is:

<rdar://problem/3533737>: Safari allows upload of arbitrary local files w/o user's knowledge or permission (SUJagBullet)

2004-01-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by John, Ken, Dave.

<rdar://problem/3533319>: Safari allows upload of arbitrary local files w/o user's knowledge or permission

khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::value): Don't fall back to the value attribute for file inputs, since that way malicious HTML could force the user to upload files unexpectedly.

5:13 PM Changeset in webkit [5930] by mjs

2 edits in branches/SUPanBisque-branch/WebCore

Merged fix from HEAD to address. Clone for this branch is:

<rdar://problem/3533734>: Safari allows upload of arbitrary local files w/o user's knowledge or permission (SUPanXpress)

2004-01-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by John, Ken, Dave.

<rdar://problem/3533319>: Safari allows upload of arbitrary local files w/o user's knowledge or permission

khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::value): Don't fall back to the value attribute for file inputs, since that way malicious HTML could force the user to upload files unexpectedly.

4:58 PM Changeset in webkit [5929] by mjs

2 edits in trunk/WebCore

Reviewed by John, Ken, Dave.

<rdar://problem/3533319>: Safari allows upload of arbitrary local files w/o user's knowledge or permission

khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::value): Don't fall back to the value attribute for file inputs, since that way malicious HTML could force the user to upload files unexpectedly.

4:09 PM Changeset in webkit [5928] by kocienda

17 edits in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me.

Made KHTMLPart now use a KHTMLSelection object rather
than its own member variables to track the selection.

Reorganized KHTMLSelection to use a "base and extent"
rather than a "start and end". This makes the "pivot
around mouse click" behavior while clicking and
dragging to make a selection much easier to implement.

Some other improvements to KHTMLSelection as well,
like some more overloaded operators.

khtml/editing/htmlediting.cpp: (EditCommand::deleteSelection):
khtml/khtml_part.cpp: (KHTMLPart::init): (KHTMLPart::clear): (KHTMLPart::findTextNext): (KHTMLPart::hasSelection): (KHTMLPart::selection): (KHTMLPart::setSelection): (KHTMLPart::slotClearSelection): (startAndEndLineNodesIncludingNode): (KHTMLPart::isPointInsideSelection): (KHTMLPart::handleMousePressEventDoubleClick): (KHTMLPart::handleMousePressEventTripleClick): (KHTMLPart::handleMousePressEventSingleClick): (KHTMLPart::handleMouseMoveEventSelection): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::selectAll): (KHTMLPart::caret):
khtml/khtml_part.h:
khtml/khtml_selection.cpp: (KHTMLSelection::KHTMLSelection): (KHTMLSelection::~KHTMLSelection): (KHTMLSelection::operator=): (KHTMLSelection::setSelection): (KHTMLSelection::setBase): (KHTMLSelection::setExtent): (KHTMLSelection::clearSelection): (KHTMLSelection::setBaseNode): (KHTMLSelection::setBaseOffset): (KHTMLSelection::setExtentNode): (KHTMLSelection::setExtentOffset): (KHTMLSelection::invalidate): (KHTMLSelection::isEmpty): (KHTMLSelection::repaint): (KHTMLSelection::nodeIsBeforeNode):
khtml/khtml_selection.h: (KHTMLSelection::startNode): (KHTMLSelection::startOffset): (KHTMLSelection::endNode): (KHTMLSelection::endOffset): (KHTMLSelection::dump): (operator==): (operator!=):
khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): (KHTMLPartPrivate::~KHTMLPartPrivate):
khtml/khtmlview.cpp:
khtml/xml/dom_docimpl.cpp: (DocumentImpl::setSelection):
khtml/xml/dom_docimpl.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::jumpToSelection): (KWQKHTMLPart::selectionStartOffset): (KWQKHTMLPart::selectionEndOffset): (KWQKHTMLPart::selectionStart): (KWQKHTMLPart::selectionEnd):

10:12 AM Changeset in webkit [5927] by kocienda

9 edits
8 adds in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me

Initial pass at trying to clean up mouse event handling
in KHTMLPart, with emphasis on making the selection
code more readable. Actually, this breaks editing, but
the point the code is in now is a good checkpoint.
I will fix editing soon, and it will be much better for it.

WebCore.pbproj/project.pbxproj:
khtml/editing/edit_caret.cpp: (Caret::Caret): (Caret::moveTo): (Caret::moveForwardByCharacter): (Caret::moveBackwardByCharacter): (Caret::adjustPosition): (Caret::invalidate): (Caret::repaint): (Caret::paint): (Caret::ensureNodeHasFocus):
khtml/editing/edit_caret.h: (khtml::Caret::size):
khtml/editing/htmlediting.cpp: (EditCommand::pruneEmptyNodes): (InputTextCommand::apply): (DeleteTextCommand::apply):
khtml/khtml_part.cpp: (KHTMLPart::init): (KHTMLPart::findTextNext): (KHTMLPart::setSelection): (KHTMLPart::checkSelectionPoint): (KHTMLPart::handleMousePressEventDoubleClick): (KHTMLPart::handleMousePressEventTripleClick): (KHTMLPart::handleMousePressEventSingleClick): (KHTMLPart::khtmlMousePressEvent): (isBeforeNode): (KHTMLPart::handleMouseMoveEventDrag): (KHTMLPart::handleMouseMoveEventOver): (KHTMLPart::handleMouseMoveEventSelection): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::selectAll): (KHTMLPart::caret):
khtml/khtml_part.h:
khtml/khtml_selection.cpp: Added. (KHTMLSelection::KHTMLSelection): (KHTMLSelection::~KHTMLSelection): (KHTMLSelection::setSelection): (KHTMLSelection::clearSelection): (KHTMLSelection::setStartNode): (KHTMLSelection::setStartOffset): (KHTMLSelection::setEndNode): (KHTMLSelection::setEndOffset): (KHTMLSelection::setVisible): (KHTMLSelection::invalidate): (KHTMLSelection::paint): (KHTMLSelection::setPart): (KHTMLSelection::timerEvent): (KHTMLSelection::repaint):
khtml/khtml_selection.h: Added. (KHTMLSelection::): (KHTMLSelection::state): (KHTMLSelection::startNode): (KHTMLSelection::startOffset): (KHTMLSelection::endNode): (KHTMLSelection::endOffset): (KHTMLSelection::caretNode): (KHTMLSelection::caretOffset): (KHTMLSelection::visible):
khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): (KHTMLPartPrivate::~KHTMLPartPrivate):
khtml/khtmlview.cpp: (KHTMLView::focusNextPrevNode):

10:12 AM Changeset in webkit [5926] by kocienda

in /

file khtml_selection.cpp was initially added on branch HTML-editing-hacks-branch.

10:12 AM Changeset in webkit [5925] by kocienda

in /

file khtml_selection.h was initially added on branch HTML-editing-hacks-branch.

Jan 18, 2004:

6:10 PM Changeset in webkit [5924] by hyatt

2 edits in trunk/WebCore

Fix for 3532569, bugzilla patch viewer doesn't work. My previous fix for 3531983 caused moves to happen
when they should not have, due to childX and childY not being implemented at all on KWQScrollView.

Context Navigation

Timeline

Jan 22, 2004:

Jan 21, 2004:

Jan 20, 2004:

Jan 19, 2004:

Jan 18, 2004:

Download in other formats: