Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Jan 27, 2004:

6:25 PM Changeset in webkit [5997] by sullivan

• 3 edits in trunk/WebKit

Tests:

• Blot/Blot.xcode/project.pbxproj: added blot-api.txt

WebKit:

WebKit part of fixes for:
<rdar://problem/3123975>: ER: please list the source URL in the header
or footer when printing the contents of a page
<rdar://problem/3184091>: Safari - Configurable printing header/footer
<rdar://problem/3306826>: Please allow printing the date (as well as URL)
in the header or footer

Reviewed by Dave.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _headerHeight]): new method, gets result from WebView's UI delegate or returns 0 (-[WebHTMLView _footerHeight]): new method, gets result from WebView's UI delegate or returns 0 (-[WebHTMLView _drawHeaderInRect:]): new method, gives WebView's UI delegate a chance to draw header (-[WebHTMLView _drawFooterInRect:]): new method, gives WebView's UI delegate a chance to draw footer (-[WebHTMLView _adjustPrintingMarginsForHeaderAndFooter]): new method, adds header and footer heights into page margins so AppKit printing code will compute and use the right area (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]): now calls _adjustPrintingMarginsForHeaderAndFooter if starting to print (-[WebHTMLView drawPageBorderWithSize:]): new method, computes rects for header and footer and calls new drawing methods

• WebView.subproj/WebUIDelegatePrivate.h: add header and footer-related delegate methods

WebBrowser:

WebBrowser part of fixes for:
<rdar://problem/3123975>: ER: please list the source URL in the header
or footer when printing the contents of a page
<rdar://problem/3184091>: Safari - Configurable printing header/footer
<rdar://problem/3306826>: Please allow printing the date (as well as URL)
in the header or footer

Reviewed by Dave.

• BrowserWebController.m: moved webViewPrint: from here to new file

• BrowserWebViewPrinting.m: Added. (-[BrowserWebView webViewPrint:]): moved this here from BrowserWebController.m (headerFooterFont): new function, returns the font used in header and footer (printHeadersAndFooters): new function, returns the preference value (-[BrowserWebView webViewHeaderHeight:]): new method, bases the header height on the font height, with some pleasant whitespace (-[BrowserWebView webViewFooterHeight:]): new method, bases the footer's height on the font height, with some pleasant whitespace (-[BrowserWebView drawLeftString:rightString:inRect:atBaseline:withFont:]): new method, used to draw a long truncated string on the left and short nontruncated string on the right (-[BrowserWebView webView:drawHeaderInRect:forPage:of:]): new method, draws title on left and date/time on right (-[BrowserWebView webView:drawFooterInRect:forPage:of:]): new method, draws URL on left and page x of n on right

• PreferenceKeys.h: new preference key PrintHeaderAndFooterPreferenceKey

• Defaults.plist: default value of PrintHeaderAndFooterPreferenceKey is true

• English.lproj/PrintingAccessoryView.nib: added checkbox for "Print Headers and Footers"

• PrintingAccessoryViewController.h:
• PrintingAccessoryViewController.m: (-[PrintingAccessoryViewController togglePrintHeadersAndFooters:]): new method, toggles the preference (-[PrintingAccessoryViewController accessoryView]): now updates the setting of the Print Headers and Footers checkbox

• English.lproj/Localizable.strings: updated for these changes

• WebBrowser.pbproj/project.pbxproj: updated to add new file

5:50 PM Changeset in webkit [5996] by cblu

• 8 edits in trunk

WebCore:

Fixed:
<rdar://problem/3541812>: Implement Paste menu item
<rdar://problem/3541814>: Implement Delete menu item
<rdar://problem/3541811>: Implement Cut menu item

Reviewed by dave.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::deleteSelection): new (DocumentImpl::pasteHTMLString): new
• khtml/xml/dom_docimpl.h:
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge isEditable]): new (-[WebCoreBridge pasteHTMLString:]): new (-[WebCoreBridge deleteSelection]): new (-[WebCoreBridge haveSelection]): new

WebKit:

Fixed:
<rdar://problem/3541812>: Implement Paste menu item
<rdar://problem/3541814>: Implement Delete menu item
<rdar://problem/3541811>: Implement Cut menu item

Reviewed by dave.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _haveSelection]): new, renamed from hasSelection, calls haveSelection on the bridge, quicker than generating string rep of selection (-[WebHTMLView _canDelete]): new (-[WebHTMLView _canPaste]): new (-[WebHTMLView takeFindStringFromSelection:]): call renamed _haveSelection (-[WebHTMLView cut:]): new (-[WebHTMLView delete:]): new (-[WebHTMLView paste:]): new (-[WebHTMLView validateUserInterfaceItem:]): updated for new methods (-[WebHTMLView validRequestorForSendType:returnType:]): call renamed _haveSelection
• WebView.subproj/WebHTMLViewPrivate.h:

3:45 PM Changeset in webkit [5995] by cblu

• 1 edit in trunk/WebKit/ChangeLog

Fixed typo in previous ChangeLog.

3:44 PM Changeset in webkit [5994] by cblu

• 2 edits in trunk/WebKit

Fixed build breakage.

Reviewed by darin.

• WebKit.pbproj/project.pbxproj: Use full patch instead of -L to get at WebKitSecurity.a

3:39 PM Changeset in webkit [5993] by cblu

• 1 edit in trunk/WebKit/ChangeLog

Fix some tabs (Darin made me do it).

3:38 PM Changeset in webkit [5992] by cblu

• 5 edits
  1 add in trunk/WebKit

Fixed: <rdar://problem/3536624>: Webkit 1.2 links against SecurityNssAsn1.framework

Reviewed by Darin.

• WebCoreSupport.subproj/WebKeyGeneration.h: Set DISABLE_WEB_KEY_GENERATION on Merlot for now.

Then don't include anything if that's set.

• WebCoreSupport.subproj/WebKeyGeneration.cpp: Don't compile anything if DISABLE_WEB_KEY_GENERATION

is set.

• WebCoreSupport.subproj/WebKeyGenerator.m: (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]):

Always return nil if DISABLE_WEB_KEY_GENERATION is set.

(-[WebKeyGenerator addCertificatesToKeychainFromData:]): Always return failure if

DISABLE_WEB_KEY_GENERATION is set.

• WebKit.pbproj/project.pbxproj: Added shell build step to make library with security

libraries in it. On Merlot, makes empty library. Also added library to link options.

• WebKitSecurityDummy.c: Added. Used to make empty version of library for build on Merlot.

11:08 AM Changeset in webkit [5991] by hyatt

• 16 edits
  3 adds in trunk/WebCore

Add a new AtomicString type (that is really just a KJS::Identifier). Define a Name class that will eventually
be used for element and attribute names.

Atomize the CSS selector's "value" field, used to hold class names, identifier names, attribute values, and
pseudo-element names.

Reviewed by rjw

• ForwardingHeaders/kjs/identifier.h: Added.
• WebCore.pbproj/project.pbxproj:
• khtml/css/css_base.cpp: (CSSSelector::print): (CSSSelector::specificity): (CSSSelector::extractPseudoType): (CSSSelector::selectorText):
• khtml/css/css_base.h: (DOM::CSSSelector::):
• khtml/css/cssparser.cpp: (ParseString::lower):
• khtml/css/cssparser.h: (DOM::atomicString):
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector):
• khtml/css/parser.cpp:
• khtml/css/parser.y:
• khtml/html/html_elementimpl.cpp: (:NamedAttrMapImpl): (HTMLNamedAttrMapImpl::clearAttributes): (HTMLNamedAttrMapImpl::isHTMLAttributeMap): (HTMLNamedAttrMapImpl::parseClassAttribute): (HTMLNamedAttrMapImpl::matchesCSSClass): (HTMLElementImpl::parseAttribute): (HTMLElementImpl::createAttributeMap): (HTMLElementImpl::matchesCSSClass):
• khtml/html/html_elementimpl.h:
• khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::recalcStyle):
• khtml/html/htmltokenizer.h: (khtml::Token::addAttribute):
• khtml/xml/dom_elementimpl.cpp: (ElementImpl::matchesCSSClass): (NamedAttrMapImpl::isHTMLAttributeMap): (NamedAttrMapImpl::operator=):
• khtml/xml/dom_elementimpl.h:
• khtml/xml/dom_nameimpl.cpp: Added. (DOM::AtomicStringList::clone): (DOM::operator==): (DOM::equalsIgnoreCase):
• khtml/xml/dom_nameimpl.h: Added. (DOM::AtomicStringList:::m_next): (DOM::AtomicStringList::m_next): (DOM::AtomicStringList::~AtomicStringList): (DOM::AtomicStringList::next): (DOM::AtomicStringList::setNext): (DOM::AtomicStringList::string): (DOM::AtomicStringList::setString): (DOM::AtomicStringList::clear): (DOM::Name::Name): (DOM::Name::m_localName): (DOM::Name::namespaceURI): (DOM::Name::localName): (DOM::operator==): (DOM::operator!=):
• khtml/xml/dom_nodeimpl.h:

8:33 AM Changeset in webkit [5990] by darin

• 2 edits in trunk/WebCore

Reviewed by Ken.

• fixed <rdar://problem/3526056>: W3C says that DEL key identifier should be U+00007F, we give ForwardDelete instead

• kwq/KWQEvent.mm: (keyIdentifierForKeyEvent): Correct the key identifiers for the Delete, Insert, Menu, Scroll Lock, and Select keys, as well as some obscure F25 and higher keys. Also add some explicit constants for the keys defined in NSEvent.h that we map to a key identifier using the vendor-area Unicode values (which are probably not appropriate).

2:01 AM Changeset in webkit [5989] by hyatt

• 5 edits in trunk/WebCore

Make a change suggested by kocienda to add a remove() method to InlineBoxes.

Reviewed by kocienda

• khtml/rendering/render_box.cpp: (RenderBox::detach): (RenderBox::position):
• khtml/rendering/render_line.cpp: (InlineBox::remove):
• khtml/rendering/render_line.h:
• khtml/rendering/render_text.cpp: (RenderText::detach): (RenderText::position):

Jan 26, 2004:

10:27 PM Changeset in webkit [5988] by darin

• 2 edits in trunk/WebCore

Reviewed by Maciej.

• follow-on to the text-align change I did earlier today

• khtml/css/html4.css: Set input and textarea so they do not inherit text-align from their parent by doing "text-align: -khtml-auto". This fixes google.com among others.

9:55 PM Changeset in webkit [5987] by darin

• 2 edits in trunk/WebCore

Reviewed by Maciej.

• fixed <rdar://problem/3539414>: pop-up windows appear very narrow because of bogus width (carad.com/ebaymotors)

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Check the "OK" result from toFloat in window.open, and omit any parameters that can't be parsed.

9:35 PM Changeset in webkit [5986] by darin

• 2 edits in trunk/WebCore

Reviewed by Maciej.

• fixed <rdar://problem/3537371>: REGRESSION (100-125): optgroup labels are no longer indented as they were before

• khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): Move code that adds spaces after code that strips whitespace. Also simplify the code a bit by using DOMString::string().

5:47 PM Changeset in webkit [5985] by darin

• 3 edits in trunk/WebCore

Reviewed by Dave.

• fixed <rdar://problem/3539286>: text with a transparent background color pastes as black on black

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Don't put color in the mutable string if it's entirely transparent.
• kwq/KWQColor.mm: (QColor::getNSColor): Fix bug where we would return nil for RGBA of 0.

5:37 PM Changeset in webkit [5984] by darin

• 6 edits in trunk/WebCore

Reviewed by Maciej.

• fixed <rdar://problem/3529120>: text-align style property not respected on input fields

• khtml/rendering/render_form.h: Added textAlignment function.
• khtml/rendering/render_form.cpp: (RenderFormElement::textAlignment): Added. Converts style alignment to Qt alignment. (RenderLineEdit::setStyle): Call textAlignment intead of using direction from style. (RenderTextArea::setStyle): Call textAlignment intead of using direction from style.

• kwq/KWQLineEdit.h: Added KWQNSTextAlignmentForAlignmentFlags function.
• kwq/KWQLineEdit.mm: (QLineEdit::setAlignment): Use KWQNSTextAlignmentForAlignmentFlags instead of code that handles only left and right alignment. (KWQNSTextAlignmentForAlignmentFlags): Added. Converts Qt alignment to NS alignment.
• kwq/KWQTextEdit.mm: (QTextEdit::setAlignment): Use KWQNSTextAlignmentForAlignmentFlags instead of code that handles only left and right alignment.

5:29 PM Changeset in webkit [5983] by darin

• 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Reviewed by Dave.

• fixed <rdar://problem/3477707>: background image with apostrophe in name missing at ​http://www.nbc.com

• khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute): Use addCSSImageProperty instead of addCSSProperty, obviating the need for the "url()" syntax (and fixing quoting issues).

• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::parseAttribute): Ditto. (HTMLTablePartElementImpl::parseAttribute): Ditto.

• khtml/html/html_elementimpl.h: Added addCSSStringProperty and addCSSImageProperty.
• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::addCSSStringProperty): Added. Calls setStringProperty. Not used yet. (HTMLElementImpl::addCSSImageProperty): Added. Calls setImageProperty.

• khtml/css/css_valueimpl.h: Added setStringProperty and setImageProperty.
• khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::setStringProperty): Added. Sets a property without parsing. (CSSStyleDeclarationImpl::setImageProperty): Added. Sets a property without parsing. You'd think we'd be able to just use setStringProperty, but that's not how the image properties work.

5:29 PM Changeset in webkit [5982] by darin

• 7 edits in trunk/WebCore

Reviewed by Dave.

• fixed <rdar://problem/3538433>: HomePage: table background URL with a single quote in it does not work

• khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute): Use addCSSImageProperty instead of addCSSProperty, obviating the need for the "url()" syntax (and fixing quoting issues).

• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::parseAttribute): Ditto. (HTMLTablePartElementImpl::parseAttribute): Ditto.

• khtml/html/html_elementimpl.h: Added addCSSStringProperty and addCSSImageProperty.
• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::addCSSStringProperty): Added. Calls setStringProperty. Not used yet. (HTMLElementImpl::addCSSImageProperty): Added. Calls setImageProperty.

• khtml/css/css_valueimpl.h: Added setStringProperty and setImageProperty.
• khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::setStringProperty): Added. Sets a property without parsing. (CSSStyleDeclarationImpl::setImageProperty): Added. Sets a property without parsing. You'd think we'd be able to just use setStringProperty, but that's not how the image properties work.

4:11 PM Changeset in webkit [5981] by darin

• 6 edits in trunk

Tools:

• CommitLogEditor/Makefile.am: Switch from pbxbuild to xcodebuild.
• HotSpotFinder/Makefile.am: Switch from pbxbuild to xcodebuild.

JavaScriptCore:

• Makefile.am: Switch from pbxbuild to xcodebuild.

Tests:

• Makefile.am: Switch from pbxbuild to xcodebuild.
• ObjcUnit/Makefile.am: Switch from pbxbuild to xcodebuild.
• TestPlugin/Makefile.am: Switch from pbxbuild to xcodebuild.
• WebFoundation-CacheLoader/Makefile.am: Switch from pbxbuild to xcodebuild.

WebCore:

• Makefile.am: Switch from pbxbuild to xcodebuild.

WebKit:

• Makefile.am: Switch from pbxbuild to xcodebuild.

WebBrowser:

• Makefile.am: Switch from pbxbuild to xcodebuild.

2:42 PM Changeset in webkit [5980] by hyatt

• 18 adds in trunk/LayoutTests/fast/css/namespaces

Namespace tests.

2:35 PM Changeset in webkit [5979] by darin

• 3 edits in trunk/WebKit

Reviewed by John.

• fixed <rdar://problem/3521379>: image dimensions uses lowercase x instead of multiplication sign

• WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation title]): Change string to use multiplication sign instead of x.
• English.lproj/Localizable.strings: Updated.

2:33 PM Changeset in webkit [5978] by hyatt

• 17 edits
  2 adds in trunk/WebCore

Add CSS3 @namespace support. The whole way namespaces, element, and attribute names are being handled
right now is temporary. This code gives us a baseline of functionality (for regression testing) that we
can use when we implement namespaces "the right way."

Reviewed by darin

• WebCore.pbproj/project.pbxproj:
• khtml/css/css_base.cpp: (CSSSelector::specificity): (CSSSelector::selectorText):
• khtml/css/css_base.h: (DOM::CSSNamespace::m_parent): (DOM::CSSNamespace::~CSSNamespace): (DOM::CSSNamespace::uri): (DOM::CSSNamespace::prefix): (DOM::CSSNamespace::namespaceForPrefix): (DOM::CSSSelector::CSSSelector):
• khtml/css/css_stylesheetimpl.cpp: (CSSStyleSheetImpl::CSSStyleSheetImpl): (CSSStyleSheetImpl::addNamespace): (CSSStyleSheetImpl::determineNamespace):
• khtml/css/css_stylesheetimpl.h: (DOM::CSSStyleSheetImpl::~CSSStyleSheetImpl):
• khtml/css/cssparser.cpp: (CSSParser::CSSParser): (CSSParser::parseSheet):
• khtml/css/cssparser.h:
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::styleForElement): (khtml::CSSStyleSelector::pseudoStyleForElement): (khtml::CSSStyleSelector::checkSelector): (khtml::CSSStyleSelector::checkOneSelector): (khtml::CSSStyleSelector::buildLists):
• khtml/css/html4.css:
• khtml/css/parser.cpp:
• khtml/css/parser.y:
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::attrId): (DocumentImpl::attrName): (DocumentImpl::tagId): (DocumentImpl::tagName): (DocumentImpl::namespaceURI):
• khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::getAttributeItem):
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::checkSetPrefix):
• khtml/xml/dom_nodeimpl.h: (DOM::namespacePart): (DOM::localNamePart): (DOM::makeId):
• khtml/xml/dom_xmlimpl.cpp: (ProcessingInstructionImpl::checkStyleSheet):
• khtml/xml/xml_namespace_table.cpp: Added. (DOM::XmlNamespaceTable::getNamespaceID): (DOM::XmlNamespaceTable::getNamespaceURI):
• khtml/xml/xml_namespace_table.h: Added. (DOM::XmlNamespaceEntry::m_uri):

2:31 PM Changeset in webkit [5977] by darin

• 2 edits in trunk/WebCore

Reviewed by Dave.

• fixed <rdar://problem/3532519>: <select> menus show label property instead of tag contents (ups.com time and cost site)

• khtml/html/html_formimpl.cpp: (HTMLOptionElementImpl::text): Ignore the label property as a quirk. Neither WinIE nor Mozilla implement the label property, so neither shall we (except on strict pages, where we just go crazy and do everything "right").

2:20 PM Changeset in webkit [5976] by kocienda

• 3 edits in trunk/WebCore

Reviewed by Hyatt

• khtml/rendering/render_line.h: (khtml::InlineBox::isFirstLineStyle): Helper to return whether the line box has the first line style bit set.
• khtml/rendering/render_text.cpp: (RenderText::caretPos): Noe correctly accounts for white space which can precede an inline text box.

1:56 PM Changeset in webkit [5975] by hyatt

• 17 edits in trunk/WebCore

Remove incremental repainting ifdef.

• khtml/khtmlview.h:
• khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
• khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::repaintObjectsBeforeLayout): (khtml::RenderBlock::positionNewFloats):
• khtml/rendering/render_block.h:
• khtml/rendering/render_box.cpp: (RenderBox::computeAbsoluteRepaintRect): (RenderBox::repaintDuringLayoutIfMoved):
• khtml/rendering/render_box.h:
• khtml/rendering/render_container.cpp: (RenderContainer::removeChildNode):
• khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutBlock): (khtml::RenderFlexibleBox::placeChild):
• khtml/rendering/render_flow.cpp: (RenderFlow::getAbsoluteRepaintRect):
• khtml/rendering/render_image.cpp: (RenderImage::layout):
• khtml/rendering/render_layer.cpp: (RenderLayer::RenderLayer): (RenderLayer::computeRepaintRects): (RenderLayer::updateLayerPositions): (RenderLayer::updateLayerPosition): (RenderLayer::paintLayer):
• khtml/rendering/render_layer.h: (khtml::RenderLayer::relativePositionOffset):
• khtml/rendering/render_object.cpp: (RenderObject::setNeedsLayout): (RenderObject::setChildNeedsLayout): (RenderObject::markContainingBlocksForLayout): (RenderObject::getAbsoluteRepaintRectIncludingFloats): (RenderObject::detach): (RenderObject::scheduleRelayout):
• khtml/rendering/render_object.h:
• khtml/rendering/render_table.cpp: (RenderTable::layout): (RenderTableSection::layoutRows):

11:24 AM Changeset in webkit [5974] by hyatt

• 22 edits in trunk/WebCore

Preserve the integrity of the line box tree when elements get removed. Change RenderText over to using
the same data structures as inlines and blocks for maintaining its list of line boxes.

Reviewed by kocienda

• khtml/khtml_part.cpp: (KHTMLPart::text): (KHTMLPart::customEvent):
• khtml/khtml_selection.cpp: (KHTMLSelection::nextCharacterPosition): (firstRunAt): (lastRunAt):
• khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
• khtml/rendering/render_block.cpp: (khtml::RenderBlock::removeChild):
• khtml/rendering/render_box.cpp: (RenderBox::RenderBox): (RenderBox::detach): (RenderBox::position): (RenderBox::inlineBoxWrapper): (RenderBox::deleteLineBoxWrapper):
• khtml/rendering/render_box.h:
• khtml/rendering/render_container.cpp: (RenderContainer::removeChildNode):
• khtml/rendering/render_flow.cpp: (RenderFlow::detach):
• khtml/rendering/render_line.cpp: (InlineFlowBox::removeChild):
• khtml/rendering/render_line.h: (khtml::InlineBox::nextOnLine): (khtml::InlineBox::prevOnLine): (khtml::InlineBox::setNextOnLine): (khtml::InlineBox::setPrevOnLine): (khtml::InlineRunBox::prevLineBox): (khtml::InlineRunBox::nextLineBox):
• khtml/rendering/render_object.cpp: (RenderObject::isEditable): (RenderObject::inlineBoxWrapper): (RenderObject::deleteLineBoxWrapper):
• khtml/rendering/render_object.h: (khtml::RenderObject::documentBeingDestroyed):
• khtml/rendering/render_text.cpp: (RenderText::RenderText): (RenderText::detach): (RenderText::deleteTextBoxes): (RenderText::absoluteRects): (RenderText::findNextInlineTextBox): (RenderText::nodeAtPoint): (RenderText::checkSelectionPointIgnoringContinuations): (RenderText::caretPos): (RenderText::paintObject): (RenderText::paint): (RenderText::minXPos): (RenderText::xPos): (RenderText::yPos): (RenderText::height): (RenderText::createInlineBox): (RenderText::position): (RenderText::width): (RenderText::caretMinOffset): (RenderText::caretMaxOffset):
• khtml/rendering/render_text.h: (khtml::InlineTextBox:::InlineRunBox): (khtml::InlineTextBox::nextTextBox): (khtml::InlineTextBox::prevTextBox): (khtml::RenderText::firstTextBox): (khtml::RenderText::lastTextBox):
• kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityIsIgnored]):
• kwq/KWQDef.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString):
• kwq/KWQRenderTreeDebug.cpp: (write):

Jan 24, 2004:

11:13 AM Changeset in webkit [5973] by hyatt

• 2 edits in trunk/WebCore

Polish the error message from the xml tokenizer.

• khtml/xml/xml_tokenizer.cpp: (XMLTokenizer::finish):

Jan 23, 2004:

4:59 PM Changeset in webkit [5972] by kocienda

• 4 edits in trunk

WebCore:

Reviewed by Richard

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setShowsFirstResponder): Now adjusts caret visibility apprpropriately.

WebKit:

Reviewed by Richard

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView updateShowsFirstResponder]): Renamed from updateFocusRing: since it is now used to kill caret blink timer. (-[WebHTMLView windowDidBecomeKey:]): Now calls new updateShowsFirstResponder method. (-[WebHTMLView windowDidResignKey:]): Ditto.

11:34 AM Changeset in webkit [5971] by hyatt

• 10 edits in trunk/WebCore

Stub out @namespace support. Implement the callbacks into the stylesheet that will enable us to
store namespace information for simple selectors.

Basically with this patch we no longer bomb when we encounter namespaced stylesheets, but we don't handle
them properly yet either.

Reviewed by kocienda

• khtml/css/css_stylesheetimpl.cpp: (CSSStyleSheetImpl::addNamespace): (CSSStyleSheetImpl::determineNamespace):
• khtml/css/css_stylesheetimpl.h:
• khtml/css/cssparser.cpp: (DOM::CSSParser::lex):
• khtml/css/cssparser.h:
• khtml/css/parser.cpp:
• khtml/css/parser.h:
• khtml/css/parser.y:
• khtml/css/tokenizer.cpp:
• khtml/css/tokenizer.flex:

10:55 AM Changeset in webkit [5970] by kocienda

• 49 edits
  13 adds in trunk/WebCore

Reviewed by Hyatt

Merged HTML editing progress to TOT from the branch
I have been maintaining.

• khtml/dom/dom_position.cpp: Added.
• khtml/dom/dom_position.h: Added.
• khtml/editing/htmlediting.cpp: Added.
• khtml/editing/htmlediting.h: Added.
• khtml/khtml_selection.cpp: Added.
• khtml/khtml_selection.h: Added.

9:27 AM Changeset in webkit [5969] by kocienda

• 29 edits
  2 adds in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me

Check in before moving to HEAD.
Many more cleanups and work on caret navigation.

• WebCore.pbproj/project.pbxproj:
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
• khtml/editing/htmlediting.cpp: (EditCommand::deleteSelection): (EditCommand::pruneEmptyNodes): (EditCommand::removeNode): (InputTextCommand::apply): (DeleteTextCommand::apply):
• khtml/editing/htmlediting.h:
• khtml/html/html_elementimpl.cpp:
• khtml/html/html_elementimpl.h:
• khtml/html/html_inlineimpl.h:
• khtml/khtml_part.cpp: (KHTMLPart::handleMousePressEventDoubleClick): (KHTMLPart::handleMousePressEventTripleClick): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::handleMouseMoveEventSelection): (KHTMLPart::khtmlMouseReleaseEvent):
• khtml/khtml_selection.cpp: (KHTMLSelection::setSelection): (KHTMLSelection::setBase): (KHTMLSelection::setExtent): (KHTMLSelection::alterSelection): (KHTMLSelection::clearSelection): (KHTMLSelection::setVisible): (KHTMLSelection::invalidate): (KHTMLSelection::update): (KHTMLSelection::repaint): (KHTMLSelection::expandSelection): (KHTMLSelection::calculateStartAndEnd): (KHTMLSelection::nextCharacterPosition): (startAndEndLineNodesIncludingNode):
• khtml/khtml_selection.h: (KHTMLSelection::):
• khtml/khtmlpart_p.h:
• khtml/khtmlview.cpp:
• khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject):
• khtml/rendering/render_object.cpp: (RenderObject::nextRenderer): (RenderObject::previousRenderer): (RenderObject::isEditable): (RenderObject::nextEditable): (RenderObject::previousEditable): (RenderObject::backslashAsCurrencySymbol):
• khtml/rendering/render_object.h:
• khtml/rendering/render_style.h: (khtml::RenderStyle::initialUserModify):
• khtml/rendering/render_text.cpp: (RenderText::setText): (RenderText::caretMaxOffset): (RenderText::precedesLineBreak): (RenderText::followsLineBreak):
• khtml/rendering/render_text.h:
• khtml/xml/dom_elementimpl.cpp: (ElementImpl::createAttributeMap): (ElementImpl::defaultEventHandler):
• khtml/xml/dom_elementimpl.h:
• khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::isHTMLElement):
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent):