Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Jan 29, 2004:

11:44 PM Changeset in webkit [6007] by hyatt

• 44 edits
  4 adds
  1 delete in trunk/WebCore

Atomize font families (KWQFontFamily) and all attribute values. Move atomic string into separate files.

In my testing, this patch yields the same score as Safari-125 in tests and recovers all lost performance
(mostly from excess copying of AtomicStrings where DOMStringImpl* used to be returned).

Reviewed by darin

• ForwardingHeaders/xml/dom_atomicstring.h: Added.
• WebCore.pbproj/project.pbxproj:
• khtml/css/css_base.cpp: (CSSSelector::print): (CSSSelector::extractPseudoType): (CSSSelector::selectorText):
• khtml/css/css_valueimpl.cpp: (FontFamilyValueImpl::FontFamilyValueImpl):
• khtml/css/cssparser.cpp: (CSSParser::parseFontFamily):
• khtml/css/cssparser.h:
• khtml/css/cssstyleselector.cpp: (khtml::checkPseudoState): (khtml::CSSStyleSelector::checkOneSelector): (khtml::CSSStyleSelector::applyRule):
• khtml/dom/dom_element.cpp: (Element::getAttributeNS):
• khtml/dom/dom_string.cpp: (DOMString::toInt): (DOMString::toLengthArray): (DOM::operator==):
• khtml/dom/dom_string.h: (DOM::operator==): (DOM::operator!=):
• khtml/ecma/kjs_navigator.cpp: (Plugins::get): (MimeTypes::get): (Plugin::get):
• khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute): (HTMLFrameElementImpl::isURLAllowed): (HTMLFrameElementImpl::openURL): (HTMLFrameElementImpl::parseAttribute): (HTMLFrameElementImpl::attach): (HTMLFrameElementImpl::setLocation): (HTMLFrameSetElementImpl::parseAttribute): (HTMLIFrameElementImpl::attach):
• khtml/html/html_baseimpl.h:
• khtml/html/html_blockimpl.cpp: (HTMLHRElementImpl::parseAttribute): (HTMLHRElementImpl::attach): (HTMLMarqueeElementImpl::parseAttribute):
• khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::documentElement):
• khtml/html/html_documentimpl.h:
• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute): (HTMLElementImpl::addCSSLength): (HTMLElementImpl::addHTMLAlignment):
• khtml/html/html_elementimpl.h:
• khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::parseAttribute): (HTMLInputElementImpl::parseAttribute): (HTMLInputElementImpl::attach): (HTMLSelectElementImpl::parseAttribute): (HTMLKeygenElementImpl::parseAttribute): (HTMLKeygenElementImpl::encoding): (HTMLOptionElementImpl::parseAttribute): (HTMLTextAreaElementImpl::parseAttribute):
• khtml/html/html_formimpl.h:
• khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::parseAttribute): (HTMLStyleElementImpl::parseAttribute):
• khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::parseAttribute): (HTMLAreaElementImpl::parseAttribute):
• khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::parseAttribute):
• khtml/html/html_listimpl.cpp: (HTMLOListElementImpl::parseAttribute): (HTMLLIElementImpl::parseAttribute):
• khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::getNamedItem): (HTMLFormCollectionImpl::getNamedFormItem): (HTMLFormCollectionImpl::getNamedImgItem):
• khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::parseAttribute): (HTMLObjectElementImpl::parseAttribute): (HTMLParamElementImpl::HTMLParamElementImpl): (HTMLParamElementImpl::~HTMLParamElementImpl): (HTMLParamElementImpl::parseAttribute):
• khtml/html/html_objectimpl.h: (DOM::HTMLParamElementImpl::name): (DOM::HTMLParamElementImpl::value):
• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::parseAttribute): (HTMLTablePartElementImpl::parseAttribute): (HTMLTableCellElementImpl::parseAttribute): (HTMLTableColElementImpl::parseAttribute):
• khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): (KHTMLParser::handleIsindex):
• khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseTag):
• khtml/html/htmltokenizer.h: (khtml::Token::addAttribute):
• khtml/khtml_part.cpp: (KHTMLPart::init):
• khtml/khtmlview.cpp: (KHTMLToolTip::maybeTip):
• khtml/xml/dom_atomicstring.cpp: Added. (DOM::AtomicStringStatisticsExitLogger::~AtomicStringStatisticsExitLogger): (DOM::AtomicString::equal): (DOM::AtomicString::add): (DOM::AtomicString::insert): (DOM::AtomicString::remove): (DOM::AtomicString::expand): (DOM::AtomicString::shrink): (DOM::AtomicString::rehash): (DOM::AtomicString::init): (DOM::operator==): (DOM::equalsIgnoreCase):
• khtml/xml/dom_atomicstring.h: Added. (DOM::AtomicString::AtomicString): (DOM::AtomicString:::m_string): (DOM::AtomicString::operator const DOMString&): (DOM::AtomicString::domString): (DOM::AtomicString::string): (DOM::AtomicString::implementation): (DOM::AtomicString::unicode): (DOM::AtomicString::length): (DOM::AtomicString::ascii): (DOM::AtomicString::find): (DOM::AtomicString::toInt): (DOM::AtomicString::percentage): (DOM::AtomicString::toLengthArray): (DOM::AtomicString::isNull): (DOM::AtomicString::isEmpty): (DOM::AtomicString::equal): (DOM::operator==): (DOM::operator!=):
• khtml/xml/dom_atomicstringlist.h: Added. (DOM::AtomicStringList:::m_next): (DOM::AtomicStringList::m_next): (DOM::AtomicStringList::~AtomicStringList): (DOM::AtomicStringList::next): (DOM::AtomicStringList::setNext): (DOM::AtomicStringList::string): (DOM::AtomicStringList::setString): (DOM::AtomicStringList::clone): (DOM::AtomicStringList::clear):
• khtml/xml/dom_docimpl.h:
• khtml/xml/dom_elementimpl.cpp: (AttrImpl::nodeValue): (AttrImpl::cloneNode): (ElementImpl::getAttribute): (ElementImpl::getAttributeNS): (ElementImpl::setAttribute): (ElementImpl::setAttributeMap): (ElementImpl::attach): (ElementImpl::detach): (ElementImpl::updateId): (NamedAttrMapImpl::setNamedItem): (NamedAttrMapImpl::removeNamedItem): (NamedAttrMapImpl::getAttributeItem): (NamedAttrMapImpl::operator=): (NamedAttrMapImpl::removeAttribute):
• khtml/xml/dom_elementimpl.h: (DOM::AttributeImpl::AttributeImpl): (DOM::AttributeImpl::value): (DOM::AttributeImpl::prefix): (DOM::AttributeImpl::isNull): (DOM::AttributeImpl::isEmpty): (DOM::AttributeImpl::setValue): (DOM::AttributeImpl::setPrefix): (DOM::ElementImpl::getAttribute):
• khtml/xml/dom_nameimpl.cpp: Removed.
• khtml/xml/dom_nameimpl.h: (DOM::Name::namespaceURI): (DOM::Name::localName):
• khtml/xml/dom_nodeimpl.h:
• khtml/xml/dom_stringimpl.cpp:
• kwq/KWQFont.mm: (QFont::family):
• kwq/KWQFontFamily.h: (KWQFontFamily::family):
• kwq/KWQFontFamily.mm: (retainDOMStringImpl): (releaseDOMStringImpl): (KWQFontFamily::getNSFamily): (KWQFontFamily::setFamily): (KWQFontFamily::operator==):
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::fileWrapperForElement):
• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

2:00 PM Changeset in webkit [6006] by cblu

• 2 edits in trunk/WebCore

Fixed: <rdar://problem/3543619>: copied HTML is strangely formatted, random whitespace and return characters

Reviewed by dave.

• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::recursive_toHTMLWithRange): remove all code that tries to format the HTML since we can rely on the existing white space to preserve the original formatting

Jan 28, 2004:

6:16 PM Changeset in webkit [6005]

• 2 copies in branches/Safari-1-0-branch/WebKit/Misc.subproj

This commit was manufactured by cvs2svn to create branch
'Safari-1-0-branch'.

6:16 PM Changeset in webkit [6004] by sullivan

• 10 edits
  2 adds in trunk

Tests:

Reviewed by Dave.

• Blot/blot-tasks.txt: Mentioned NSTextView's (and therefore Mail's) option-Escape behavior here since we will probably have to implement it also; clarified a comment.

WebCore:

Reviewed by Dave.

• khtml/rendering/render_text.cpp: (RenderText::paintObject): Increment s in the while() clause so it is incremented even after a continue statement. This fixes an infinite loop I ran into in the printing code path at certain scaled print sizes on certain pages.

WebKit:

More header/footer work: refactored the header/footer code so it could
be easily reused by other WebDocument classes; used it from WebImageView
and WebTextView; removed the page count parameters because it's possible
(though currently nasty, see 3543078) to determine this in the client.

Reviewed by Dave.

• Misc.subproj/WebNSPrintOperationExtras.h Added.
• Misc.subproj/WebNSPrintOperationExtras.m Added. (-[NSPrintOperation _web_pageSetupScaleFactor]): new convenience method.

• WebView.subproj/WebUIDelegatePrivate.h: Removed page index and page count parameters from delegate methods.

• WebView.subproj/WebViewPrivate.h: New private category for header/footer printing methods so that different WebDocument methods can share almost all of the code.

• WebView.subproj/WebView.m: (-[WebView _headerHeight]): (-[WebView _footerHeight]): (-[WebView _drawHeaderInRect:]): (-[WebView _drawFooterInRect:]): (-[WebView _adjustPrintingMarginsForHeaderAndFooter]): (-[WebView _drawHeaderAndFooter]): Moved all of these methods here, formerly in WebHTMLView. Removed the page index and page count parameters.

• WebView.subproj/WebHTMLView.m: Removed all the header/footer code that's now in WebView.m, and the method that's now -[NSPrintOperation _web_pageSetupScaleFactor] (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]): call methods differently that have now been moved (-[WebHTMLView _scaleFactorForPrintOperation:]): ditto (-[WebHTMLView knowsPageRange:]): ditto (-[WebHTMLView drawPageBorderWithSize:]): now just turns around and calls -[WebView _drawHeaderAndFooter]

• WebView.subproj/WebImageView.m: (-[WebImageView drawPageBorderWithSize:]): new method, just calls -[WebView _drawHeaderAndFooter] (-[WebImageView beginDocument]): now calls -[WebView _adjustPrintMarginsForHeaderAndFooter], also moved in file. (-[WebImageView endDocument]): just moved in file.

• WebView.subproj/WebTextView.m: (-[WebTextView drawPageBorderWithSize:]): new method, just calls -[WebView _drawHeaderAndFooter] (-[WebTextView knowsPageRange:]): overridden to call -[WebView _adjustPrintMarginsForHeaderAndFooter]

• WebKit.pbproj/project.pbxproj: updated for added files

WebBrowser:

Some header/footer cleanup.

Reviewed by Dave.

• BrowserWebViewPrinting.m: (-[BrowserWebView webView:drawHeaderInRect:]): Removed obsolete page index and count parameters. Use displayName rather than currentTitle because it works for all document types (currentTitle didn't work for plain text pages). (-[BrowserWebView webView:drawFooterInRect:]): Removed obsolete page index and count parameters. Did some AppKit hackery to get the total document page count in a way that works for any print operation. Now handles the case where the page count is unknown (by printing "Page <x>" instead of "Page <x> of <n>"). Also added a 1 pixel offset to the footer's baseline to work around AppKit bug where the descenders in the footer were getting slightly clipped at some scale factors.

• English.lproj/Localizable.strings: updated for these changes

5:26 PM Changeset in webkit [6003] by cblu

• 2 edits in trunk/WebCore

Fixed: <rdar://problem/3543041>: when pasting an image, cursor should be after the image, not before

Reviewed by rjw.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::pasteHTMLString): when the last node of the paste is non-text, use 1 instead of 0 as the start offset of the caret

4:22 PM Changeset in webkit [6002] by kocienda

• 18 edits
  1 add in trunk/WebCore

Reviewed by Hyatt

A small collection of fixes and improvements to editing.

Added a forwarding header for dom_position.h
Added some debugging output to KHTMLSelection
Added support for left arrow navigation.
Greatly improved support for right arrow navigation.
Added include guards to dom_position.h. Oops!
Removed pruneEmptyNodes() function from htmlediting.cpp. That was crack.
Improved the text insert command so that it splits the text node being

operated on only when necessary.

Added support for placing the caret in and arrowing into BR elements.
Moved precedesLineBreak/followsLineBreak from RenderText to RenderObject.

• ForwardingHeaders/dom/dom_position.h: Added.
• khtml/dom/dom_position.h:
• khtml/editing/htmlediting.cpp: (InputTextCommand::apply): (DeleteTextCommand::apply):
• khtml/khtml_selection.cpp: (KHTMLSelection::setSelection): (KHTMLSelection::alterSelection): (KHTMLSelection::update): (KHTMLSelection::previousCharacterPosition): (KHTMLSelection::nextCharacterPosition): (startAndEndLineNodesIncludingNode): (KHTMLSelection::debugRenderer): (KHTMLSelection::debugPosition):
• khtml/khtml_selection.h:
• khtml/rendering/render_br.cpp: (RenderBR::RenderBR): (RenderBR::position): (RenderBR::caretMaxOffset): (RenderBR::caretPos):
• khtml/rendering/render_br.h: (khtml::RenderBR::xPos): (khtml::RenderBR::yPos): (khtml::RenderBR::height):
• khtml/rendering/render_object.cpp: (RenderObject::precedesLineBreak): (RenderObject::followsLineBreak): (RenderObject::isEditable):
• khtml/rendering/render_object.h:
• khtml/rendering/render_text.cpp: (RenderText::caretPos): (RenderText::position): (RenderText::caretMaxOffset):
• khtml/rendering/render_text.h:
• khtml/xml/dom_elementimpl.cpp: (ElementImpl::defaultEventHandler):

1:26 PM Changeset in webkit [6001] by hyatt

• 2 adds in trunk/LayoutTests/fast/css

Add layout test for checking the cascade of the clear property.

1:22 PM Changeset in webkit [6000] by hyatt

• 2 edits in trunk/WebCore

Fix for 3537694, make blocks for parents of inline children be axobjects.

Reviewed by kocienda

• kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject accessibilityIsIgnored]):

1:19 PM Changeset in webkit [5999] by hyatt

• 9 edits in trunk/WebCore

Make AtomicString a new class that owns DOMStrings, instead of using KJS::Identifier. One day when we
convert DOMString and UString to have the same underlying rep, then these classes could possibly re-merge.
For now this provides an easy migration path for all the code that is using DOMStringImpl*.

Also fixed a bug with float clearing in the style cascade.

Reviewed by darin

• khtml/css/cssparser.h: (DOM::atomicString):
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector): (khtml::CSSStyleSelector::applyRule):
• khtml/dom/dom_string.cpp: (DOMString::DOMString):
• khtml/xml/dom_nameimpl.cpp: (DOM::AtomicStringStatisticsExitLogger::~AtomicStringStatisticsExitLogger): (DOM::AtomicString::equal): (DOM::AtomicString::add): (DOM::AtomicString::insert): (DOM::AtomicString::remove): (DOM::AtomicString::expand): (DOM::AtomicString::shrink): (DOM::AtomicString::rehash): (DOM::AtomicString::null): (DOM::AtomicString::init): (DOM::operator==): (DOM::equalsIgnoreCase):
• khtml/xml/dom_nameimpl.h: (DOM::AtomicString::AtomicString): (DOM::AtomicString:::m_string): (DOM::AtomicString::string): (DOM::AtomicString::qstring): (DOM::AtomicString::implementation): (DOM::AtomicString::unicode): (DOM::AtomicString::length): (DOM::AtomicString::ascii): (DOM::AtomicString::find): (DOM::AtomicString::isNull): (DOM::AtomicString::isEmpty): (DOM::AtomicString::equal): (DOM::operator==): (DOM::operator!=):
• khtml/xml/dom_stringimpl.cpp: (DOM::DOMStringImpl::empty): (DOM::DOMStringImpl::DOMStringImpl): (DOM::DOMStringImpl::~DOMStringImpl): (DOM::DOMStringImpl::append): (DOM::DOMStringImpl::insert): (DOM::DOMStringImpl::truncate): (DOM::DOMStringImpl::remove): (DOM::DOMStringImpl::split): (DOM::DOMStringImpl::substring): (DOM::DOMStringImpl::replace): (DOM::DOMStringImpl::computeHash):
• khtml/xml/dom_stringimpl.h: (DOM::DOMStringImpl::DOMStringImpl): (DOM::DOMStringImpl::hash):
• khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::CharacterDataImpl):

1:09 PM Changeset in webkit [5998] by cblu

• 4 edits in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3197222>: need context menu items for back, forward, refresh.

Reviewed by rjw.

• English.lproj/Localizable.strings:
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate menuItemWithTag:]): added support for WebMenuItemTagGoBack, WebMenuItemTagGoForward, WebMenuItemTagStop and WebMenuItemTagReload tags (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): added support for Back, Forward, Stop and Reload
• WebView.subproj/WebUIDelegate.h: added WebMenuItemTagGoBack, WebMenuItemTagGoForward, WebMenuItemTagStop and WebMenuItemTagReload tags

WebBrowser:

Fixed: <rdar://problem/3197222>: need context menu items for back, forward, refresh.

Reviewed by rjw.

• ContextMenuHandler.m: (-[BrowserWebView webView:contextMenuItemsForElement:defaultMenuItems:]): added support for Back, Forward, Stop and Reload

Jan 27, 2004:

6:25 PM Changeset in webkit [5997] by sullivan

• 3 edits in trunk/WebKit

Tests:

• Blot/Blot.xcode/project.pbxproj: added blot-api.txt

WebKit:

WebKit part of fixes for:
<rdar://problem/3123975>: ER: please list the source URL in the header
or footer when printing the contents of a page
<rdar://problem/3184091>: Safari - Configurable printing header/footer
<rdar://problem/3306826>: Please allow printing the date (as well as URL)
in the header or footer

Reviewed by Dave.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _headerHeight]): new method, gets result from WebView's UI delegate or returns 0 (-[WebHTMLView _footerHeight]): new method, gets result from WebView's UI delegate or returns 0 (-[WebHTMLView _drawHeaderInRect:]): new method, gives WebView's UI delegate a chance to draw header (-[WebHTMLView _drawFooterInRect:]): new method, gives WebView's UI delegate a chance to draw footer (-[WebHTMLView _adjustPrintingMarginsForHeaderAndFooter]): new method, adds header and footer heights into page margins so AppKit printing code will compute and use the right area (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]): now calls _adjustPrintingMarginsForHeaderAndFooter if starting to print (-[WebHTMLView drawPageBorderWithSize:]): new method, computes rects for header and footer and calls new drawing methods

• WebView.subproj/WebUIDelegatePrivate.h: add header and footer-related delegate methods

WebBrowser:

WebBrowser part of fixes for:
<rdar://problem/3123975>: ER: please list the source URL in the header
or footer when printing the contents of a page
<rdar://problem/3184091>: Safari - Configurable printing header/footer
<rdar://problem/3306826>: Please allow printing the date (as well as URL)
in the header or footer

Reviewed by Dave.

• BrowserWebController.m: moved webViewPrint: from here to new file

• BrowserWebViewPrinting.m: Added. (-[BrowserWebView webViewPrint:]): moved this here from BrowserWebController.m (headerFooterFont): new function, returns the font used in header and footer (printHeadersAndFooters): new function, returns the preference value (-[BrowserWebView webViewHeaderHeight:]): new method, bases the header height on the font height, with some pleasant whitespace (-[BrowserWebView webViewFooterHeight:]): new method, bases the footer's height on the font height, with some pleasant whitespace (-[BrowserWebView drawLeftString:rightString:inRect:atBaseline:withFont:]): new method, used to draw a long truncated string on the left and short nontruncated string on the right (-[BrowserWebView webView:drawHeaderInRect:forPage:of:]): new method, draws title on left and date/time on right (-[BrowserWebView webView:drawFooterInRect:forPage:of:]): new method, draws URL on left and page x of n on right

• PreferenceKeys.h: new preference key PrintHeaderAndFooterPreferenceKey

• Defaults.plist: default value of PrintHeaderAndFooterPreferenceKey is true

• English.lproj/PrintingAccessoryView.nib: added checkbox for "Print Headers and Footers"

• PrintingAccessoryViewController.h:
• PrintingAccessoryViewController.m: (-[PrintingAccessoryViewController togglePrintHeadersAndFooters:]): new method, toggles the preference (-[PrintingAccessoryViewController accessoryView]): now updates the setting of the Print Headers and Footers checkbox

• English.lproj/Localizable.strings: updated for these changes

• WebBrowser.pbproj/project.pbxproj: updated to add new file

5:50 PM Changeset in webkit [5996] by cblu

• 8 edits in trunk

WebCore:

Fixed:
<rdar://problem/3541812>: Implement Paste menu item
<rdar://problem/3541814>: Implement Delete menu item
<rdar://problem/3541811>: Implement Cut menu item

Reviewed by dave.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::deleteSelection): new (DocumentImpl::pasteHTMLString): new
• khtml/xml/dom_docimpl.h:
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge isEditable]): new (-[WebCoreBridge pasteHTMLString:]): new (-[WebCoreBridge deleteSelection]): new (-[WebCoreBridge haveSelection]): new

WebKit:

Fixed:
<rdar://problem/3541812>: Implement Paste menu item
<rdar://problem/3541814>: Implement Delete menu item
<rdar://problem/3541811>: Implement Cut menu item

Reviewed by dave.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _haveSelection]): new, renamed from hasSelection, calls haveSelection on the bridge, quicker than generating string rep of selection (-[WebHTMLView _canDelete]): new (-[WebHTMLView _canPaste]): new (-[WebHTMLView takeFindStringFromSelection:]): call renamed _haveSelection (-[WebHTMLView cut:]): new (-[WebHTMLView delete:]): new (-[WebHTMLView paste:]): new (-[WebHTMLView validateUserInterfaceItem:]): updated for new methods (-[WebHTMLView validRequestorForSendType:returnType:]): call renamed _haveSelection
• WebView.subproj/WebHTMLViewPrivate.h:

3:45 PM Changeset in webkit [5995] by cblu

• 1 edit in trunk/WebKit/ChangeLog

Fixed typo in previous ChangeLog.

3:44 PM Changeset in webkit [5994] by cblu

• 2 edits in trunk/WebKit

Fixed build breakage.

Reviewed by darin.

• WebKit.pbproj/project.pbxproj: Use full patch instead of -L to get at WebKitSecurity.a

3:39 PM Changeset in webkit [5993] by cblu

• 1 edit in trunk/WebKit/ChangeLog

Fix some tabs (Darin made me do it).

3:38 PM Changeset in webkit [5992] by cblu

• 5 edits
  1 add in trunk/WebKit

Fixed: <rdar://problem/3536624>: Webkit 1.2 links against SecurityNssAsn1.framework

Reviewed by Darin.

• WebCoreSupport.subproj/WebKeyGeneration.h: Set DISABLE_WEB_KEY_GENERATION on Merlot for now.

Then don't include anything if that's set.

• WebCoreSupport.subproj/WebKeyGeneration.cpp: Don't compile anything if DISABLE_WEB_KEY_GENERATION

is set.

• WebCoreSupport.subproj/WebKeyGenerator.m: (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]):

Always return nil if DISABLE_WEB_KEY_GENERATION is set.

(-[WebKeyGenerator addCertificatesToKeychainFromData:]): Always return failure if

DISABLE_WEB_KEY_GENERATION is set.

• WebKit.pbproj/project.pbxproj: Added shell build step to make library with security

libraries in it. On Merlot, makes empty library. Also added library to link options.

• WebKitSecurityDummy.c: Added. Used to make empty version of library for build on Merlot.

11:08 AM Changeset in webkit [5991] by hyatt

• 16 edits
  3 adds in trunk/WebCore

Add a new AtomicString type (that is really just a KJS::Identifier). Define a Name class that will eventually
be used for element and attribute names.

Atomize the CSS selector's "value" field, used to hold class names, identifier names, attribute values, and
pseudo-element names.

Reviewed by rjw

• ForwardingHeaders/kjs/identifier.h: Added.
• WebCore.pbproj/project.pbxproj:
• khtml/css/css_base.cpp: (CSSSelector::print): (CSSSelector::specificity): (CSSSelector::extractPseudoType): (CSSSelector::selectorText):
• khtml/css/css_base.h: (DOM::CSSSelector::):
• khtml/css/cssparser.cpp: (ParseString::lower):
• khtml/css/cssparser.h: (DOM::atomicString):
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector):
• khtml/css/parser.cpp:
• khtml/css/parser.y:
• khtml/html/html_elementimpl.cpp: (:NamedAttrMapImpl): (HTMLNamedAttrMapImpl::clearAttributes): (HTMLNamedAttrMapImpl::isHTMLAttributeMap): (HTMLNamedAttrMapImpl::parseClassAttribute): (HTMLNamedAttrMapImpl::matchesCSSClass): (HTMLElementImpl::parseAttribute): (HTMLElementImpl::createAttributeMap): (HTMLElementImpl::matchesCSSClass):
• khtml/html/html_elementimpl.h:
• khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::recalcStyle):
• khtml/html/htmltokenizer.h: (khtml::Token::addAttribute):
• khtml/xml/dom_elementimpl.cpp: (ElementImpl::matchesCSSClass): (NamedAttrMapImpl::isHTMLAttributeMap): (NamedAttrMapImpl::operator=):
• khtml/xml/dom_elementimpl.h:
• khtml/xml/dom_nameimpl.cpp: Added. (DOM::AtomicStringList::clone): (DOM::operator==): (DOM::equalsIgnoreCase):
• khtml/xml/dom_nameimpl.h: Added. (DOM::AtomicStringList:::m_next): (DOM::AtomicStringList::m_next): (DOM::AtomicStringList::~AtomicStringList): (DOM::AtomicStringList::next): (DOM::AtomicStringList::setNext): (DOM::AtomicStringList::string): (DOM::AtomicStringList::setString): (DOM::AtomicStringList::clear): (DOM::Name::Name): (DOM::Name::m_localName): (DOM::Name::namespaceURI): (DOM::Name::localName): (DOM::operator==): (DOM::operator!=):
• khtml/xml/dom_nodeimpl.h:

8:33 AM Changeset in webkit [5990] by darin

• 2 edits in trunk/WebCore

Reviewed by Ken.

• fixed <rdar://problem/3526056>: W3C says that DEL key identifier should be U+00007F, we give ForwardDelete instead

• kwq/KWQEvent.mm: (keyIdentifierForKeyEvent): Correct the key identifiers for the Delete, Insert, Menu, Scroll Lock, and Select keys, as well as some obscure F25 and higher keys. Also add some explicit constants for the keys defined in NSEvent.h that we map to a key identifier using the vendor-area Unicode values (which are probably not appropriate).

2:01 AM Changeset in webkit [5989] by hyatt

• 5 edits in trunk/WebCore

Make a change suggested by kocienda to add a remove() method to InlineBoxes.

Reviewed by kocienda

• khtml/rendering/render_box.cpp: (RenderBox::detach): (RenderBox::position):
• khtml/rendering/render_line.cpp: (InlineBox::remove):
• khtml/rendering/render_line.h:
• khtml/rendering/render_text.cpp: (RenderText::detach): (RenderText::position):

Jan 26, 2004:

10:27 PM Changeset in webkit [5988] by darin

• 2 edits in trunk/WebCore

Reviewed by Maciej.

• follow-on to the text-align change I did earlier today

• khtml/css/html4.css: Set input and textarea so they do not inherit text-align from their parent by doing "text-align: -khtml-auto". This fixes google.com among others.

9:55 PM Changeset in webkit [5987] by darin

• 2 edits in trunk/WebCore

Reviewed by Maciej.

• fixed <rdar://problem/3539414>: pop-up windows appear very narrow because of bogus width (carad.com/ebaymotors)

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Check the "OK" result from toFloat in window.open, and omit any parameters that can't be parsed.

9:35 PM Changeset in webkit [5986] by darin

• 2 edits in trunk/WebCore

Reviewed by Maciej.

• fixed <rdar://problem/3537371>: REGRESSION (100-125): optgroup labels are no longer indented as they were before

• khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): Move code that adds spaces after code that strips whitespace. Also simplify the code a bit by using DOMString::string().

5:47 PM Changeset in webkit [5985] by darin

• 3 edits in trunk/WebCore

Reviewed by Dave.

• fixed <rdar://problem/3539286>: text with a transparent background color pastes as black on black

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Don't put color in the mutable string if it's entirely transparent.
• kwq/KWQColor.mm: (QColor::getNSColor): Fix bug where we would return nil for RGBA of 0.

5:37 PM Changeset in webkit [5984] by darin

• 6 edits in trunk/WebCore

Reviewed by Maciej.

• fixed <rdar://problem/3529120>: text-align style property not respected on input fields

• khtml/rendering/render_form.h: Added textAlignment function.
• khtml/rendering/render_form.cpp: (RenderFormElement::textAlignment): Added. Converts style alignment to Qt alignment. (RenderLineEdit::setStyle): Call textAlignment intead of using direction from style. (RenderTextArea::setStyle): Call textAlignment intead of using direction from style.

• kwq/KWQLineEdit.h: Added KWQNSTextAlignmentForAlignmentFlags function.
• kwq/KWQLineEdit.mm: (QLineEdit::setAlignment): Use KWQNSTextAlignmentForAlignmentFlags instead of code that handles only left and right alignment. (KWQNSTextAlignmentForAlignmentFlags): Added. Converts Qt alignment to NS alignment.
• kwq/KWQTextEdit.mm: (QTextEdit::setAlignment): Use KWQNSTextAlignmentForAlignmentFlags instead of code that handles only left and right alignment.

5:29 PM Changeset in webkit [5983] by darin

• 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Reviewed by Dave.

• fixed <rdar://problem/3477707>: background image with apostrophe in name missing at ​http://www.nbc.com

• khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute): Use addCSSImageProperty instead of addCSSProperty, obviating the need for the "url()" syntax (and fixing quoting issues).

• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::parseAttribute): Ditto. (HTMLTablePartElementImpl::parseAttribute): Ditto.

• khtml/html/html_elementimpl.h: Added addCSSStringProperty and addCSSImageProperty.
• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::addCSSStringProperty): Added. Calls setStringProperty. Not used yet. (HTMLElementImpl::addCSSImageProperty): Added. Calls setImageProperty.

• khtml/css/css_valueimpl.h: Added setStringProperty and setImageProperty.
• khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::setStringProperty): Added. Sets a property without parsing. (CSSStyleDeclarationImpl::setImageProperty): Added. Sets a property without parsing. You'd think we'd be able to just use setStringProperty, but that's not how the image properties work.

5:29 PM Changeset in webkit [5982] by darin

• 7 edits in trunk/WebCore

Reviewed by Dave.

• fixed <rdar://problem/3538433>: HomePage: table background URL with a single quote in it does not work

• khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute): Use addCSSImageProperty instead of addCSSProperty, obviating the need for the "url()" syntax (and fixing quoting issues).

• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::parseAttribute): Ditto. (HTMLTablePartElementImpl::parseAttribute): Ditto.

• khtml/html/html_elementimpl.h: Added addCSSStringProperty and addCSSImageProperty.
• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::addCSSStringProperty): Added. Calls setStringProperty. Not used yet. (HTMLElementImpl::addCSSImageProperty): Added. Calls setImageProperty.

• khtml/css/css_valueimpl.h: Added setStringProperty and setImageProperty.
• khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::setStringProperty): Added. Sets a property without parsing. (CSSStyleDeclarationImpl::setImageProperty): Added. Sets a property without parsing. You'd think we'd be able to just use setStringProperty, but that's not how the image properties work.

4:11 PM Changeset in webkit [5981] by darin

• 6 edits in trunk

Tools:

• CommitLogEditor/Makefile.am: Switch from pbxbuild to xcodebuild.
• HotSpotFinder/Makefile.am: Switch from pbxbuild to xcodebuild.

JavaScriptCore:

• Makefile.am: Switch from pbxbuild to xcodebuild.

Tests:

• Makefile.am: Switch from pbxbuild to xcodebuild.
• ObjcUnit/Makefile.am: Switch from pbxbuild to xcodebuild.
• TestPlugin/Makefile.am: Switch from pbxbuild to xcodebuild.
• WebFoundation-CacheLoader/Makefile.am: Switch from pbxbuild to xcodebuild.

WebCore:

• Makefile.am: Switch from pbxbuild to xcodebuild.

WebKit:

• Makefile.am: Switch from pbxbuild to xcodebuild.

WebBrowser:

• Makefile.am: Switch from pbxbuild to xcodebuild.

2:42 PM Changeset in webkit [5980] by hyatt

• 18 adds in trunk/LayoutTests/fast/css/namespaces

Namespace tests.

2:35 PM Changeset in webkit [5979] by darin

• 3 edits in trunk/WebKit

Reviewed by John.

• fixed <rdar://problem/3521379>: image dimensions uses lowercase x instead of multiplication sign

• WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation title]): Change string to use multiplication sign instead of x.
• English.lproj/Localizable.strings: Updated.

2:33 PM Changeset in webkit [5978] by hyatt

• 17 edits
  2 adds in trunk/WebCore

Add CSS3 @namespace support. The whole way namespaces, element, and attribute names are being handled
right now is temporary. This code gives us a baseline of functionality (for regression testing) that we
can use when we implement namespaces "the right way."

Reviewed by darin

• WebCore.pbproj/project.pbxproj:
• khtml/css/css_base.cpp: (CSSSelector::specificity): (CSSSelector::selectorText):
• khtml/css/css_base.h: (DOM::CSSNamespace::m_parent): (DOM::CSSNamespace::~CSSNamespace): (DOM::CSSNamespace::uri): (DOM::CSSNamespace::prefix): (DOM::CSSNamespace::namespaceForPrefix): (DOM::CSSSelector::CSSSelector):
• khtml/css/css_stylesheetimpl.cpp: (CSSStyleSheetImpl::CSSStyleSheetImpl): (CSSStyleSheetImpl::addNamespace): (CSSStyleSheetImpl::determineNamespace):
• khtml/css/css_stylesheetimpl.h: (DOM::CSSStyleSheetImpl::~CSSStyleSheetImpl):
• khtml/css/cssparser.cpp: (CSSParser::CSSParser): (CSSParser::parseSheet):
• khtml/css/cssparser.h:
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::styleForElement): (khtml::CSSStyleSelector::pseudoStyleForElement): (khtml::CSSStyleSelector::checkSelector): (khtml::CSSStyleSelector::checkOneSelector): (khtml::CSSStyleSelector::buildLists):
• khtml/css/html4.css:
• khtml/css/parser.cpp:
• khtml/css/parser.y:
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::attrId): (DocumentImpl::attrName): (DocumentImpl::tagId): (DocumentImpl::tagName): (DocumentImpl::namespaceURI):
• khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::getAttributeItem):
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::checkSetPrefix):
• khtml/xml/dom_nodeimpl.h: (DOM::namespacePart): (DOM::localNamePart): (DOM::makeId):
• khtml/xml/dom_xmlimpl.cpp: (ProcessingInstructionImpl::checkStyleSheet):
• khtml/xml/xml_namespace_table.cpp: Added. (DOM::XmlNamespaceTable::getNamespaceID): (DOM::XmlNamespaceTable::getNamespaceURI):
• khtml/xml/xml_namespace_table.h: Added. (DOM::XmlNamespaceEntry::m_uri):

2:31 PM Changeset in webkit [5977] by darin

• 2 edits in trunk/WebCore

Reviewed by Dave.

• fixed <rdar://problem/3532519>: <select> menus show label property instead of tag contents (ups.com time and cost site)

• khtml/html/html_formimpl.cpp: (HTMLOptionElementImpl::text): Ignore the label property as a quirk. Neither WinIE nor Mozilla implement the label property, so neither shall we (except on strict pages, where we just go crazy and do everything "right").

2:20 PM Changeset in webkit [5976] by kocienda

• 3 edits in trunk/WebCore

Reviewed by Hyatt

• khtml/rendering/render_line.h: (khtml::InlineBox::isFirstLineStyle): Helper to return whether the line box has the first line style bit set.
• khtml/rendering/render_text.cpp: (RenderText::caretPos): Noe correctly accounts for white space which can precede an inline text box.

1:56 PM Changeset in webkit [5975] by hyatt

• 17 edits in trunk/WebCore

Remove incremental repainting ifdef.

• khtml/khtmlview.h:
• khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
• khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::repaintObjectsBeforeLayout): (khtml::RenderBlock::positionNewFloats):
• khtml/rendering/render_block.h:
• khtml/rendering/render_box.cpp: (RenderBox::computeAbsoluteRepaintRect): (RenderBox::repaintDuringLayoutIfMoved):
• khtml/rendering/render_box.h:
• khtml/rendering/render_container.cpp: (RenderContainer::removeChildNode):
• khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutBlock): (khtml::RenderFlexibleBox::placeChild):
• khtml/rendering/render_flow.cpp: (RenderFlow::getAbsoluteRepaintRect):
• khtml/rendering/render_image.cpp: (RenderImage::layout):
• khtml/rendering/render_layer.cpp: (RenderLayer::RenderLayer): (RenderLayer::computeRepaintRects): (RenderLayer::updateLayerPositions): (RenderLayer::updateLayerPosition): (RenderLayer::paintLayer):
• khtml/rendering/render_layer.h: (khtml::RenderLayer::relativePositionOffset):
• khtml/rendering/render_object.cpp: (RenderObject::setNeedsLayout): (RenderObject::setChildNeedsLayout): (RenderObject::markContainingBlocksForLayout): (RenderObject::getAbsoluteRepaintRectIncludingFloats): (RenderObject::detach): (RenderObject::scheduleRelayout):
• khtml/rendering/render_object.h:
• khtml/rendering/render_table.cpp: (RenderTable::layout): (RenderTableSection::layoutRows):

11:24 AM Changeset in webkit [5974] by hyatt

• 22 edits in trunk/WebCore

Preserve the integrity of the line box tree when elements get removed. Change RenderText over to using
the same data structures as inlines and blocks for maintaining its list of line boxes.

Reviewed by kocienda

• khtml/khtml_part.cpp: (KHTMLPart::text): (KHTMLPart::customEvent):
• khtml/khtml_selection.cpp: (KHTMLSelection::nextCharacterPosition): (firstRunAt): (lastRunAt):
• khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
• khtml/rendering/render_block.cpp: (khtml::RenderBlock::removeChild):
• khtml/rendering/render_box.cpp: (RenderBox::RenderBox): (RenderBox::detach): (RenderBox::position): (RenderBox::inlineBoxWrapper): (RenderBox::deleteLineBoxWrapper):
• khtml/rendering/render_box.h:
• khtml/rendering/render_container.cpp: (RenderContainer::removeChildNode):
• khtml/rendering/render_flow.cpp: (RenderFlow::detach):
• khtml/rendering/render_line.cpp: (InlineFlowBox::removeChild):
• khtml/rendering/render_line.h: (khtml::InlineBox::nextOnLine): (khtml::InlineBox::prevOnLine): (khtml::InlineBox::setNextOnLine): (khtml::InlineBox::setPrevOnLine): (khtml::InlineRunBox::prevLineBox): (khtml::InlineRunBox::nextLineBox):
• khtml/rendering/render_object.cpp: (RenderObject::isEditable): (RenderObject::inlineBoxWrapper): (RenderObject::deleteLineBoxWrapper):
• khtml/rendering/render_object.h: (khtml::RenderObject::documentBeingDestroyed):
• khtml/rendering/render_text.cpp: (RenderText::RenderText): (RenderText::detach): (RenderText::deleteTextBoxes): (RenderText::absoluteRects): (RenderText::findNextInlineTextBox): (RenderText::nodeAtPoint): (RenderText::checkSelectionPointIgnoringContinuations): (RenderText::caretPos): (RenderText::paintObject): (RenderText::paint): (RenderText::minXPos): (RenderText::xPos): (RenderText::yPos): (RenderText::height): (RenderText::createInlineBox): (RenderText::position): (RenderText::width): (RenderText::caretMinOffset): (RenderText::caretMaxOffset):
• khtml/rendering/render_text.h: (khtml::InlineTextBox:::InlineRunBox): (khtml::InlineTextBox::nextTextBox): (khtml::InlineTextBox::prevTextBox): (khtml::RenderText::firstTextBox): (khtml::RenderText::lastTextBox):
• kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityIsIgnored]):
• kwq/KWQDef.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString):
• kwq/KWQRenderTreeDebug.cpp: (write):