Context Navigation

kjs/array_object.cpp: (ArrayInstanceImp::ArrayInstanceImp): If the length is greater than 10,000, don't allocate an array until we start putting values in. This prevents new Array(2147483647) from causing trouble. (ArrayObjectImp::construct): Check number as described in specification, and raise a range error if the number is out of range. This prevents new Array(-1) from causing trouble.

fixed <rdar://problem/3545756>: Math.round screws up on numbers bigger than 2^{31 (incorrect results on HP-35 calculator page)}

kjs/math_object.cpp: (MathFuncImp::call): Change implementation to be much simpler and not involve casting to int. Results now match those in other browsers.

3:29 PM Changeset in webkit [6027] by sullivan

4 edits in trunk/WebKit

WebKit:

Reviewed by Darin.

Misc.subproj/WebNSURLExtras.h:
Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_URLWithLowercasedScheme]): new method, returns a URL whose scheme has been tolower'ed

English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

WebBrowser:

fixed <rdar://problem/3527598>: "(null)" appears for some malformed URLs in location bar

Reviewed by Darin.

BrowserWebController.m: (-[BrowserWebView webView:unableToImplementPolicyWithError:frame:]): Call new _web_URLWithLowercasedScheme; the old code here was subtly transforming some degenerate URLs

(-[BrowserWebView openURLExternallyWithRequest:inFrame:]):
New error message to handle the case where [URL scheme] returns nil.

English.lproj/Localizable.strings:
English.lproj/StringsNotToBeLocalized.txt: updated for these changes

3:23 PM Changeset in webkit [6026] by cblu

12 edits in trunk

WebCore:

Fixed: <rdar://problem/3546924>: REGRESSION: dragging text or images over a WebView is jerky

Reviewed by mjs.

WebCore-combined.exp:
WebCore.exp:
kwq/WebCoreBridge.h: added the DOM node element key constant (SPI for now)
kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): instead of calling toHTML for every node, put the node on the element so the caller can get the HTML string representation when it needs to.
kwq/WebCoreDOMNode.mm: (-[WebCoreDOMNode HTMLString]): new

WebKit:

Fixed: <rdar://problem/3546924>: REGRESSION: dragging text or images over a WebView is jerky

Reviewed by mjs.

DOM.subproj/WebDOMNode.h: added HTMLString to the protocol
WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate copyImageToClipboard:]): get the HTML representation via the DOM node
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _handleMouseDragged:]): get the HTML representation via the DOM node
WebView.subproj/WebView.h: removed the HTML string element key constant
WebView.subproj/WebView.m: removed the HTML string element key constant

1:23 PM Changeset in webkit [6025] by darin

7 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fixed <rdar://problem/3519285>: integer operations on large negative numbers yield bad results (discovered with "HTMLCrypt")
fixed other related overflow issues

kjs/value.h: Changed return types of toInteger, toInt32, toUInt32, and toUInt16.
kjs/value.cpp: (ValueImp::toInteger): Change to return a double, since this operation, from the ECMA specification, must not restrict values to the range of a particular integer type. (ValueImp::toInt32): Used a sized integer type for the result of this function, and also added proper handling for negative results from fmod. (ValueImp::toUInt32): Ditto. (ValueImp::toUInt16): Ditto. (ValueImp::dispatchToUInt32): Changed result type from unsigned to uint32_t.

kjs/array_object.cpp: (ArrayProtoFuncImp::call): Use a double instead of an int to handle out-of-integer-range values better in the slice function.
kjs/internal.cpp: (KJS::roundValue): Streamline the function, handling NAN and infinity properly.
kjs/number_object.cpp: (NumberProtoFuncImp::call): Use a double instead of an int to handle out-of-integer-range values better in the toString function.
kjs/string_object.cpp: (StringProtoFuncImp::call): Use a double instead of an int to handle out-of-integer-range values better in the charAt, charCodeAt, indexOf, lastIndexOf, slice, and substr functions.

11:14 AM Changeset in webkit [6024] by cblu

6 edits in trunk/WebKit

Fixed: <rdar://problem/3546426>: when copying images via context menus, only some data is added to the pasteboard

Reviewed by john.

Misc.subproj/WebNSPasteboardExtras.h:
Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:URL:title:fileWrapper:HTMLString:]): new, writes and image, URL and other optional arguments to the pasteboard
Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:fileWrapper:rect:URL:title:HTMLString:event:]): factored code out to _web_writeImage, call _web_writeImage
WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate copyImageToClipboard:]): call _web_writeImage
WebView.subproj/WebImageView.m: (-[WebImageView writeImageToPasteboard:]): call _web_writeImage

10:55 AM Changeset in webkit [6023] by darin

8 edits in trunk/WebCore

Reviewed by Maciej.

use toInt32 where we really need an int, rather than toInteger, because toInteger needs to return an integral number as a double, not as an int

khtml/ecma/kjs_css.cpp: (DOMCSSStyleDeclarationProtoFunc::tryCall): Call toInt32 intead of toInteger. (DOMStyleSheetListFunc::tryCall): Ditto. (KJS::DOMMediaListProtoFunc::tryCall): Ditto. (DOMCSSStyleSheetProtoFunc::tryCall): Ditto. (DOMCSSRuleListFunc::tryCall): Ditto. (DOMCSSRuleFunc::tryCall): Ditto. (DOMCSSPrimitiveValueProtoFunc::tryCall): Ditto. (DOMCSSValueListFunc::tryCall): Ditto.
khtml/ecma/kjs_dom.cpp: (DOMCharacterDataProtoFunc::tryCall): Ditto. (DOMTextProtoFunc::tryCall): Ditto.
khtml/ecma/kjs_events.cpp: (DOMUIEventProtoFunc::tryCall): Ditto. (DOMMouseEventProtoFunc::tryCall): Ditto. (DOMKeyboardEventProtoFunc::tryCall): Ditto. (DOMMutationEventProtoFunc::tryCall): Ditto.
khtml/ecma/kjs_html.cpp: (KJS::HTMLElementFunction::tryCall): Ditto. (KJS::HTMLElement::putValue): Ditto. (KJS::HTMLSelectCollection::tryPut): Ditto.
khtml/ecma/kjs_range.cpp: (DOMRangeProtoFunc::tryCall): Ditto.
khtml/ecma/kjs_traversal.cpp: (JSNodeFilter::acceptNode): Ditto.
khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Ditto. (HistoryFunc::tryCall): Ditto.

10:42 AM Changeset in webkit [6022] by darin

2 edits in trunk/WebCore

Reviewed by John.

fix at least some of <rdar://problem/3546393>: 10,000 leaks, many of DOM::AtomicString::add, after one run of cvs-base

khtml/xml/dom_atomicstring.cpp: (DOM::AtomicString::add): Remove extra allocation of strings. This should speed things up a bit as well as fixing one big leak.

10:11 AM Changeset in webkit [6021]

2 copies
3 deletes in tags/WebKit-126~0~1

This commit was manufactured by cvs2svn to create tag
'WebKit-126~0~1'.

10:11 AM Changeset in webkit [6020] by darin

2 edits in trunk/WebKit

fixed build failure on Merlot

Misc.subproj/WebNSPasteboardExtras.m: Import just CoreTranslationFlavorTypeNames.h rather than all of ApplicationServicesPriv.h; should compile faster and avoid build failure.

9:47 AM Changeset in webkit [6019] by cblu

12 edits in trunk

WebCore:

Fixed: <rdar://problem/3546379>: support for editing via drag & drop

Reviewed by kocienda.

khtml/xml/dom_docimpl.cpp: (DocumentImpl::deleteSelection): fixed a crash I encountered while attempting to delete and empty selection
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge isSelectionEditable]): renamed from isEditable (-[WebCoreBridge moveCaretToPoint:]): new (-[WebCoreBridge elementAtPoint:]): added support for WebCoreElementHTMLStringKey and WebCoreElementIsEditableKey

WebKit:

Fixed: <rdar://problem/3546379>: support for editing via drag & drop

Reviewed by kocienda.

Misc.subproj/WebNSViewExtras.h:
Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:fileWrapper:rect:URL:title:HTMLString:event:]): added a HTMLString argument so that we retain all attributes when dragging images
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _canDelete]): call renamed isSelectionEditable (-[WebHTMLView _canPaste]): call renamed isSelectionEditable (-[WebHTMLView _pasteHTMLFromPasteboard:]): new, factored out from paste: (-[WebHTMLView _handleMouseDragged:]): removed code that returned early if we were loading, this kind of protection is no longer needed since we now retain the view while dragging, call renamed _web_dragImage (-[WebHTMLView initWithFrame:]): register for drop types (-[WebHTMLView paste:]): call _pasteHTMLFromPasteboard (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): set new isDragging BOOL to YES (-[WebHTMLView draggedImage:endedAt:operation:]): set new isDragging BOOL to NO (-[WebHTMLView draggingEntered:]): new (-[WebHTMLView draggingUpdated:]): new, handle caret movement during the drag (-[WebHTMLView prepareForDragOperation:]): new (-[WebHTMLView performDragOperation:]): new (-[WebHTMLView concludeDragOperation:]): new, paste in the drag
WebView.subproj/WebHTMLViewPrivate.h:
WebView.subproj/WebImageView.m: (-[WebImageView mouseDragged:]): call renamed _web_dragImage
WebView.subproj/WebView.h:
WebView.subproj/WebView.m:

Jan 30, 2004:

5:30 PM Changeset in webkit [6018] by mjs

1 edit in branches/Safari-1-2-branch/WebCore/ChangeLog-2005-08-23

Merge the following changes from TOT for the Epiphany submission.

2004-01-28 David Hyatt <hyatt@apple.com>

Fix for 3537694, make blocks for parents of inline children be axobjects.

Reviewed by kocienda

kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject accessibilityIsIgnored]):

2004-01-30 David Hyatt <hyatt@apple.com>

Fix for 3522497, <br>s should not get AXObjects created.

Reviewed by mjs

kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityIsIgnored]):

5:30 PM Changeset in webkit [6017]

3 copies in branches/Safari-1-2-branch

This commit was manufactured by cvs2svn to create branch
'Safari-1-2-branch'.

4:29 PM Changeset in webkit [6016] by hyatt

2 edits in trunk/WebCore

Fix for 3522497, <br>s should not get AXObjects created.

Reviewed by mjs

kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityIsIgnored]):

4:16 PM Changeset in webkit [6015] by vicki

3 edits in trunk

change version number from '126' to '127u'

4:11 PM Changeset in webkit [6014]

3 copies in tags/Safari-126

This commit was manufactured by cvs2svn to create tag 'Safari-126'.

4:11 PM Changeset in webkit [6013] by vicki

6 edits in trunk

Safari-126 stamp

2:53 PM Changeset in webkit [6012] by rjw

2 edits in trunk/JavaScriptCore

Fixed 3542044. Create KJS::String using UString constructor instead of passing UTF8 string to char* constructor.

Reviewed by Darin.

bindings/jni/jni_instance.cpp: (JavaInstance::stringValue):

1:00 PM Changeset in webkit [6011] by hyatt

2 edits in trunk/WebCore

Fix a regression I introduced in my atomicstring patch. I meant to say !attr->isNull() in the contentedtiable
attribute parsing code.

Reviewed by cblu

khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute):

11:12 AM Changeset in webkit [6010] by hyatt

9 edits in trunk/WebCore

Make m_lineHeight be cached on RenderFlow instead of RenderText and avoid recomputing it so much when it
is not set by CSS (since calls to fontMetrics().lineSpacing() are expensive).

Yields ~1.5% performance improvement.

Reviewed by darin

khtml/rendering/render_block.cpp: (khtml::RenderBlock::setStyle):
khtml/rendering/render_flow.cpp: (RenderFlow::lineHeight):
khtml/rendering/render_flow.h:
khtml/rendering/render_inline.cpp: (RenderInline::setStyle):
khtml/rendering/render_object.cpp: (RenderObject::verticalPositionHint): (RenderObject::lineHeight):
khtml/rendering/render_object.h:
khtml/rendering/render_text.cpp: (RenderText::setStyle): (RenderText::checkSelectionPointIgnoringContinuations): (RenderText::height): (RenderText::lineHeight):
khtml/rendering/render_text.h:

10:36 AM Changeset in webkit [6009] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3536126>: REGRESSION (Merlot): WebKit dragging is in strange location

Reviewed by kocienda.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _handleMouseDragged:]): use the proper offset when dragging text

1:06 AM Changeset in webkit [6008] by hyatt

10 edits in trunk/WebCore

Disable XBL. The loadBindings call was taking 0.1-0.25%. While I know how to get rid of this overhead,
it's easier for now to just disable all of XBL.

WebCorePrefix.h:
khtml/misc/loader.h:
khtml/xbl/xbl_binding.cpp:
khtml/xbl/xbl_binding_manager.cpp:
khtml/xbl/xbl_docimpl.cpp:
khtml/xbl/xbl_protobinding.cpp:
khtml/xbl/xbl_protohandler.cpp:
khtml/xbl/xbl_protoimplementation.cpp:
khtml/xbl/xbl_tokenizer.cpp:

Jan 29, 2004:

11:44 PM Changeset in webkit [6007] by hyatt

44 edits
4 adds
1 delete in trunk/WebCore

Atomize font families (KWQFontFamily) and all attribute values. Move atomic string into separate files.

In my testing, this patch yields the same score as Safari-125 in tests and recovers all lost performance
(mostly from excess copying of AtomicStrings where DOMStringImpl* used to be returned).

Reviewed by darin

ForwardingHeaders/xml/dom_atomicstring.h: Added.
WebCore.pbproj/project.pbxproj:
khtml/css/css_base.cpp: (CSSSelector::print): (CSSSelector::extractPseudoType): (CSSSelector::selectorText):
khtml/css/css_valueimpl.cpp: (FontFamilyValueImpl::FontFamilyValueImpl):
khtml/css/cssparser.cpp: (CSSParser::parseFontFamily):
khtml/css/cssparser.h:
khtml/css/cssstyleselector.cpp: (khtml::checkPseudoState): (khtml::CSSStyleSelector::checkOneSelector): (khtml::CSSStyleSelector::applyRule):
khtml/dom/dom_element.cpp: (Element::getAttributeNS):
khtml/dom/dom_string.cpp: (DOMString::toInt): (DOMString::toLengthArray): (DOM::operator==):
khtml/dom/dom_string.h: (DOM::operator==): (DOM::operator!=):
khtml/ecma/kjs_navigator.cpp: (Plugins::get): (MimeTypes::get): (Plugin::get):
khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute): (HTMLFrameElementImpl::isURLAllowed): (HTMLFrameElementImpl::openURL): (HTMLFrameElementImpl::parseAttribute): (HTMLFrameElementImpl::attach): (HTMLFrameElementImpl::setLocation): (HTMLFrameSetElementImpl::parseAttribute): (HTMLIFrameElementImpl::attach):
khtml/html/html_baseimpl.h:
khtml/html/html_blockimpl.cpp: (HTMLHRElementImpl::parseAttribute): (HTMLHRElementImpl::attach): (HTMLMarqueeElementImpl::parseAttribute):
khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::documentElement):
khtml/html/html_documentimpl.h:
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute): (HTMLElementImpl::addCSSLength): (HTMLElementImpl::addHTMLAlignment):
khtml/html/html_elementimpl.h:
khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::parseAttribute): (HTMLInputElementImpl::parseAttribute): (HTMLInputElementImpl::attach): (HTMLSelectElementImpl::parseAttribute): (HTMLKeygenElementImpl::parseAttribute): (HTMLKeygenElementImpl::encoding): (HTMLOptionElementImpl::parseAttribute): (HTMLTextAreaElementImpl::parseAttribute):
khtml/html/html_formimpl.h:
khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::parseAttribute): (HTMLStyleElementImpl::parseAttribute):
khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::parseAttribute): (HTMLAreaElementImpl::parseAttribute):
khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::parseAttribute):
khtml/html/html_listimpl.cpp: (HTMLOListElementImpl::parseAttribute): (HTMLLIElementImpl::parseAttribute):
khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::getNamedItem): (HTMLFormCollectionImpl::getNamedFormItem): (HTMLFormCollectionImpl::getNamedImgItem):
khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::parseAttribute): (HTMLObjectElementImpl::parseAttribute): (HTMLParamElementImpl::HTMLParamElementImpl): (HTMLParamElementImpl::~HTMLParamElementImpl): (HTMLParamElementImpl::parseAttribute):
khtml/html/html_objectimpl.h: (DOM::HTMLParamElementImpl::name): (DOM::HTMLParamElementImpl::value):
khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::parseAttribute): (HTMLTablePartElementImpl::parseAttribute): (HTMLTableCellElementImpl::parseAttribute): (HTMLTableColElementImpl::parseAttribute):
khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): (KHTMLParser::handleIsindex):
khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseTag):
khtml/html/htmltokenizer.h: (khtml::Token::addAttribute):
khtml/khtml_part.cpp: (KHTMLPart::init):
khtml/khtmlview.cpp: (KHTMLToolTip::maybeTip):
khtml/xml/dom_atomicstring.cpp: Added. (DOM::AtomicStringStatisticsExitLogger::~AtomicStringStatisticsExitLogger): (DOM::AtomicString::equal): (DOM::AtomicString::add): (DOM::AtomicString::insert): (DOM::AtomicString::remove): (DOM::AtomicString::expand): (DOM::AtomicString::shrink): (DOM::AtomicString::rehash): (DOM::AtomicString::init): (DOM::operator==): (DOM::equalsIgnoreCase):
khtml/xml/dom_atomicstring.h: Added. (DOM::AtomicString::AtomicString): (DOM::AtomicString:::m_string): (DOM::AtomicString::operator const DOMString&): (DOM::AtomicString::domString): (DOM::AtomicString::string): (DOM::AtomicString::implementation): (DOM::AtomicString::unicode): (DOM::AtomicString::length): (DOM::AtomicString::ascii): (DOM::AtomicString::find): (DOM::AtomicString::toInt): (DOM::AtomicString::percentage): (DOM::AtomicString::toLengthArray): (DOM::AtomicString::isNull): (DOM::AtomicString::isEmpty): (DOM::AtomicString::equal): (DOM::operator==): (DOM::operator!=):
khtml/xml/dom_atomicstringlist.h: Added. (DOM::AtomicStringList:::m_next): (DOM::AtomicStringList::m_next): (DOM::AtomicStringList::~AtomicStringList): (DOM::AtomicStringList::next): (DOM::AtomicStringList::setNext): (DOM::AtomicStringList::string): (DOM::AtomicStringList::setString): (DOM::AtomicStringList::clone): (DOM::AtomicStringList::clear):
khtml/xml/dom_docimpl.h:
khtml/xml/dom_elementimpl.cpp: (AttrImpl::nodeValue): (AttrImpl::cloneNode): (ElementImpl::getAttribute): (ElementImpl::getAttributeNS): (ElementImpl::setAttribute): (ElementImpl::setAttributeMap): (ElementImpl::attach): (ElementImpl::detach): (ElementImpl::updateId): (NamedAttrMapImpl::setNamedItem): (NamedAttrMapImpl::removeNamedItem): (NamedAttrMapImpl::getAttributeItem): (NamedAttrMapImpl::operator=): (NamedAttrMapImpl::removeAttribute):
khtml/xml/dom_elementimpl.h: (DOM::AttributeImpl::AttributeImpl): (DOM::AttributeImpl::value): (DOM::AttributeImpl::prefix): (DOM::AttributeImpl::isNull): (DOM::AttributeImpl::isEmpty): (DOM::AttributeImpl::setValue): (DOM::AttributeImpl::setPrefix): (DOM::ElementImpl::getAttribute):
khtml/xml/dom_nameimpl.cpp: Removed.
khtml/xml/dom_nameimpl.h: (DOM::Name::namespaceURI): (DOM::Name::localName):
khtml/xml/dom_nodeimpl.h:
khtml/xml/dom_stringimpl.cpp:
kwq/KWQFont.mm: (QFont::family):
kwq/KWQFontFamily.h: (KWQFontFamily::family):
kwq/KWQFontFamily.mm: (retainDOMStringImpl): (releaseDOMStringImpl): (KWQFontFamily::getNSFamily): (KWQFontFamily::setFamily): (KWQFontFamily::operator==):
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::fileWrapperForElement):
kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

2:00 PM Changeset in webkit [6006] by cblu

2 edits in trunk/WebCore

Fixed: <rdar://problem/3543619>: copied HTML is strangely formatted, random whitespace and return characters

Reviewed by dave.

khtml/xml/dom_nodeimpl.cpp: (NodeImpl::recursive_toHTMLWithRange): remove all code that tries to format the HTML since we can rely on the existing white space to preserve the original formatting

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed