⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 4, 2004:

7:15 PM Changeset in webkit [6038] by hyatt
  • 2 edits in trunk/WebKit

Fix deployment build bustage.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (ConsoleConnectionChangeNotifyProc):
5:45 PM Changeset in webkit [6037] by hyatt
  • 34 edits in trunk/WebCore

Improve rule matching in the style system. Filter out most rules up front, so that only a small
number of rules need to be walked for any given element. Yields a ~4-5% improvement on the PLT.

Reviewed by kocienda

  • khtml/css/css_base.cpp: (StyleBaseImpl::setParsedValue): (CSSSelector::specificity): (CSSSelector::extractPseudoType): (CSSSelector::operator == ):
  • khtml/css/css_base.h: (DOM::CSSSelector::CSSSelector): (DOM::CSSSelector::~CSSSelector): (DOM::CSSSelector::append): (DOM::CSSSelector::next): (DOM::CSSSelector::): (DOM::StyleBaseImpl::StyleBaseImpl):
  • khtml/css/css_ruleimpl.cpp: (CSSStyleRuleImpl::selectorText): (CSSRuleListImpl::insertRule):
  • khtml/css/css_ruleimpl.h: (DOM::CSSStyleRuleImpl::setSelector): (DOM::CSSStyleRuleImpl::selector):
  • khtml/css/css_stylesheetimpl.cpp:
  • khtml/css/css_stylesheetimpl.h:
  • khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::getPropertyCSSValue): (CSSStyleDeclarationImpl::removeProperty): (CSSStyleDeclarationImpl::setProperty): (CSSStyleDeclarationImpl::setStringProperty): (CSSStyleDeclarationImpl::setImageProperty): (CSSStyleDeclarationImpl::setLengthProperty): (CSSStyleDeclarationImpl::cssText): (CSSStyleDeclarationImpl::setCssText):
  • khtml/css/css_valueimpl.h: (DOM::CSSStyleDeclarationImpl::node): (DOM::CSSProperty::CSSProperty): (DOM::CSSProperty::id): (DOM::CSSProperty::isImportant):
  • khtml/css/cssparser.cpp: (CSSParser::CSSParser): (ParseString::lower): (CSSParser::parseValue): (CSSParser::parseDeclaration): (CSSParser::addProperty): (CSSParser::parseShadow):
  • khtml/css/cssparser.h:
  • khtml/css/cssstyleselector.cpp: (khtml::): (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::CSSStyleSelector::init): (khtml::CSSStyleSelector::~CSSStyleSelector): (khtml::CSSStyleSelector::loadDefaultStyle): (khtml::CSSStyleSelector::addMatchedRule): (khtml::CSSStyleSelector::addMatchedDeclaration): (khtml::CSSStyleSelector::matchRules): (khtml::CSSStyleSelector::matchRulesForList): (khtml::operator >): (khtml::operator <=): (khtml::CSSStyleSelector::sortMatchedRules): (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::styleForElement): (khtml::CSSStyleSelector::pseudoStyleForElement): (khtml::checkPseudoState): (khtml::CSSStyleSelector::checkSelector): (khtml::CSSStyleSelector::checkOneSelector): (khtml::CSSRuleSet::CSSRuleSet): (khtml::CSSRuleSet::addToRuleSet): (khtml::CSSRuleSet::addRule): (khtml::CSSRuleSet::addRulesFromSheet): (khtml::CSSStyleSelector::applyDeclarations): (khtml::CSSStyleSelector::applyProperty): (khtml::CSSStyleSelector::smallerFontSize): (khtml::CSSStyleSelector::getColorFromPrimitiveValue):
  • khtml/css/cssstyleselector.h: (khtml::): (khtml::CSSRuleData::m_next): (khtml::CSSRuleData::~CSSRuleData): (khtml::CSSRuleData::position): (khtml::CSSRuleData::rule): (khtml::CSSRuleData::selector): (khtml::CSSRuleData::next): (khtml::CSSRuleDataList::CSSRuleDataList): (khtml::CSSRuleDataList::~CSSRuleDataList): (khtml::CSSRuleDataList::first): (khtml::CSSRuleDataList::last): (khtml::CSSRuleDataList::append): (khtml::CSSRuleSet::~CSSRuleSet): (khtml::CSSRuleSet::getIDRules): (khtml::CSSRuleSet::getClassRules): (khtml::CSSRuleSet::getTagRules): (khtml::CSSRuleSet::getUniversalRules):
  • khtml/css/cssvalues.c: (hash_val): (findValue):
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
  • khtml/css/html4.css:
  • khtml/css/parser.cpp:
  • khtml/css/parser.h:
  • khtml/css/parser.y:
  • khtml/dom/dom_element.cpp: (Element::style):
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::HTMLBodyElementImpl): (HTMLBodyElementImpl::~HTMLBodyElementImpl): (HTMLBodyElementImpl::createLinkDecl): (HTMLBodyElementImpl::parseAttribute):
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_elementimpl.cpp: (HTMLNamedAttrMapImpl::parseClassAttribute): (HTMLElementImpl::HTMLElementImpl): (HTMLElementImpl::~HTMLElementImpl): (HTMLElementImpl::createInlineStyleDecl): (HTMLElementImpl::createMappedAttributeDecl): (HTMLElementImpl::parseAttribute): (HTMLElementImpl::getClassList): (HTMLElementImpl::addCSSProperty): (HTMLElementImpl::addCSSStringProperty): (HTMLElementImpl::addCSSImageProperty): (HTMLElementImpl::addCSSLength): (HTMLElementImpl::addHTMLColor): (HTMLElementImpl::removeCSSProperty):
  • khtml/html/html_elementimpl.h: (DOM::HTMLNamedAttrMapImpl::getClassList): (DOM::HTMLElementImpl::inlineStyleDecl): (DOM::HTMLElementImpl::attributeStyleDecl): (DOM::HTMLElementImpl::getInlineStyleDecl):
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::createSharedCellDecls): (HTMLTableCellElementImpl::additionalAttributeStyleDecl):
  • khtml/html/html_tableimpl.h:
  • khtml/xml/dom_atomicstring.cpp: (DOM::AtomicString::add): (DOM::AtomicString::remove):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::resetLinkColor): (DocumentImpl::resetVisitedLinkColor): (DocumentImpl::resetActiveLinkColor): (DocumentImpl::recalcStyleSelector):
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::linkColor): (DOM::DocumentImpl::visitedLinkColor): (DOM::DocumentImpl::activeLinkColor): (DOM::DocumentImpl::setLinkColor): (DOM::DocumentImpl::setVisitedLinkColor): (DOM::DocumentImpl::setActiveLinkColor):
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::ElementImpl): (ElementImpl::~ElementImpl): (ElementImpl::getClassList): (ElementImpl::getIDAttribute): (ElementImpl::cloneNode): (XMLElementImpl::cloneNode):
  • khtml/xml/dom_elementimpl.h: (DOM::ElementImpl::inlineStyleDecl): (DOM::ElementImpl::attributeStyleDecl): (DOM::ElementImpl::getInlineStyleDecl): (DOM::ElementImpl::additionalAttributeStyleDecl): (DOM::NamedAttrMapImpl::id): (DOM::NamedAttrMapImpl::setID):
  • khtml/xml/dom_stringimpl.cpp: (DOM::DOMStringImpl::DOMStringImpl): (DOM::DOMStringImpl::~DOMStringImpl): (DOM::DOMStringImpl::append): (DOM::DOMStringImpl::insert): (DOM::DOMStringImpl::truncate): (DOM::DOMStringImpl::remove): (DOM::DOMStringImpl::split):
  • khtml/xml/dom_stringimpl.h: (DOM::DOMStringImpl::DOMStringImpl):
2:22 PM Changeset in webkit [6036] by hyatt
  • 4 edits in trunk/WebCore

Fix line-height regression on altavista.

  • khtml/rendering/render_br.cpp: (RenderBR::RenderBR): (RenderBR::position): (RenderBR::lineHeight): (RenderBR::setStyle):
  • khtml/rendering/render_br.h:
  • khtml/rendering/render_flow.h: (khtml::RenderFlow::RenderFlow):
1:49 PM Changeset in webkit [6035] by kocienda
  • 9 edits in trunk/LayoutTests

Committed new tests for RenderBR change

1:33 PM Changeset in webkit [6034] by hyatt
  • 3 edits in trunk/WebCore

Fix a regression in the line-height of first-lines and inline-blocks.

Reviewed by darin

  • khtml/rendering/render_flow.cpp: (RenderFlow::lineHeight):
  • khtml/rendering/render_text.cpp: (RenderText::lineHeight):
10:45 AM Changeset in webkit [6033] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3546028>: Safari should not give plug-ins any time, thus use 0% CPU, when not in the currently active session

Reviewed by john.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (+[WebBaseNetscapePluginView initialize]): observe CG changes (-[WebBaseNetscapePluginView addWindowObservers]): observe user switch notifications (-[WebBaseNetscapePluginView removeWindowObservers]): stop observing user switch notifications (-[WebBaseNetscapePluginView viewHasMoved:]): tweak (-[WebBaseNetscapePluginView windowWillClose:]): tweak (-[WebBaseNetscapePluginView windowBecameKey:]): tweak (-[WebBaseNetscapePluginView windowResignedKey:]): tweak (-[WebBaseNetscapePluginView windowDidMiniaturize:]): tweak (-[WebBaseNetscapePluginView windowDidDeminiaturize:]): tweak (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]): new, stop null events (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]): new, restart null events (ConsoleConnectionChangeNotifyProc): new, post user switch notifications

Feb 2, 2004:

5:32 PM Changeset in webkit [6032]
  • 5 copies
    2 deletes in tags/WebCore-125-tarball

This commit was manufactured by cvs2svn to create tag
'WebCore-125-tarball'.

5:32 PM Changeset in webkit [6031] by mjs
  • 2 edits in branches/Safari-1-2-tarballs-branch/WebCore

Changes for WebCore-125 tarball.

  • WebCore.pbproj/project.pbxproj: Made the usual tweaks.
5:22 PM Changeset in webkit [6030]
  • 3 copies
    3 deletes in tags/JavaScriptCore-125-tarball

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-125-tarball'.

5:22 PM Changeset in webkit [6029] by mjs
  • 2 edits in branches/Safari-1-2-tarballs-branch/JavaScriptCore

Changes for JavaScriptCore-125 tarball.

5:18 PM Changeset in webkit [6028] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • fixed <rdar://problem/3546613>: array of negative size leads to crash (test page at oscar.the-rileys.net)
  • kjs/array_object.cpp: (ArrayInstanceImp::ArrayInstanceImp): If the length is greater than 10,000, don't allocate an array until we start putting values in. This prevents new Array(2147483647) from causing trouble. (ArrayObjectImp::construct): Check number as described in specification, and raise a range error if the number is out of range. This prevents new Array(-1) from causing trouble.
  • fixed <rdar://problem/3545756>: Math.round screws up on numbers bigger than 231 (incorrect results on HP-35 calculator page)
  • kjs/math_object.cpp: (MathFuncImp::call): Change implementation to be much simpler and not involve casting to int. Results now match those in other browsers.
3:29 PM Changeset in webkit [6027] by sullivan
  • 4 edits in trunk/WebKit

WebKit:

Reviewed by Darin.

  • Misc.subproj/WebNSURLExtras.h:
  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_URLWithLowercasedScheme]): new method, returns a URL whose scheme has been tolower'ed
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

WebBrowser:

  • fixed <rdar://problem/3527598>: "(null)" appears for some malformed URLs in location bar

Reviewed by Darin.

  • BrowserWebController.m: (-[BrowserWebView webView:unableToImplementPolicyWithError:frame:]): Call new _web_URLWithLowercasedScheme; the old code here was subtly transforming some degenerate URLs

(-[BrowserWebView openURLExternallyWithRequest:inFrame:]):
New error message to handle the case where [URL scheme] returns nil.

  • English.lproj/Localizable.strings:
  • English.lproj/StringsNotToBeLocalized.txt: updated for these changes
3:23 PM Changeset in webkit [6026] by cblu
  • 12 edits in trunk

WebCore:

Fixed: <rdar://problem/3546924>: REGRESSION: dragging text or images over a WebView is jerky

Reviewed by mjs.

  • WebCore-combined.exp:
  • WebCore.exp:
  • kwq/WebCoreBridge.h: added the DOM node element key constant (SPI for now)
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): instead of calling toHTML for every node, put the node on the element so the caller can get the HTML string representation when it needs to.
  • kwq/WebCoreDOMNode.mm: (-[WebCoreDOMNode HTMLString]): new

WebKit:

Fixed: <rdar://problem/3546924>: REGRESSION: dragging text or images over a WebView is jerky

Reviewed by mjs.

  • DOM.subproj/WebDOMNode.h: added HTMLString to the protocol
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate copyImageToClipboard:]): get the HTML representation via the DOM node
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _handleMouseDragged:]): get the HTML representation via the DOM node
  • WebView.subproj/WebView.h: removed the HTML string element key constant
  • WebView.subproj/WebView.m: removed the HTML string element key constant
1:23 PM Changeset in webkit [6025] by darin
  • 7 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • fixed <rdar://problem/3519285>: integer operations on large negative numbers yield bad results (discovered with "HTMLCrypt")
  • fixed other related overflow issues
  • kjs/value.h: Changed return types of toInteger, toInt32, toUInt32, and toUInt16.
  • kjs/value.cpp: (ValueImp::toInteger): Change to return a double, since this operation, from the ECMA specification, must not restrict values to the range of a particular integer type. (ValueImp::toInt32): Used a sized integer type for the result of this function, and also added proper handling for negative results from fmod. (ValueImp::toUInt32): Ditto. (ValueImp::toUInt16): Ditto. (ValueImp::dispatchToUInt32): Changed result type from unsigned to uint32_t.
  • kjs/array_object.cpp: (ArrayProtoFuncImp::call): Use a double instead of an int to handle out-of-integer-range values better in the slice function.
  • kjs/internal.cpp: (KJS::roundValue): Streamline the function, handling NAN and infinity properly.
  • kjs/number_object.cpp: (NumberProtoFuncImp::call): Use a double instead of an int to handle out-of-integer-range values better in the toString function.
  • kjs/string_object.cpp: (StringProtoFuncImp::call): Use a double instead of an int to handle out-of-integer-range values better in the charAt, charCodeAt, indexOf, lastIndexOf, slice, and substr functions.
11:14 AM Changeset in webkit [6024] by cblu
  • 6 edits in trunk/WebKit

Fixed: <rdar://problem/3546426>: when copying images via context menus, only some data is added to the pasteboard

Reviewed by john.

  • Misc.subproj/WebNSPasteboardExtras.h:
  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:URL:title:fileWrapper:HTMLString:]): new, writes and image, URL and other optional arguments to the pasteboard
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:fileWrapper:rect:URL:title:HTMLString:event:]): factored code out to _web_writeImage, call _web_writeImage
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate copyImageToClipboard:]): call _web_writeImage
  • WebView.subproj/WebImageView.m: (-[WebImageView writeImageToPasteboard:]): call _web_writeImage
10:55 AM Changeset in webkit [6023] by darin
  • 8 edits in trunk/WebCore

Reviewed by Maciej.

  • use toInt32 where we really need an int, rather than toInteger, because toInteger needs to return an integral number as a double, not as an int
  • khtml/ecma/kjs_css.cpp: (DOMCSSStyleDeclarationProtoFunc::tryCall): Call toInt32 intead of toInteger. (DOMStyleSheetListFunc::tryCall): Ditto. (KJS::DOMMediaListProtoFunc::tryCall): Ditto. (DOMCSSStyleSheetProtoFunc::tryCall): Ditto. (DOMCSSRuleListFunc::tryCall): Ditto. (DOMCSSRuleFunc::tryCall): Ditto. (DOMCSSPrimitiveValueProtoFunc::tryCall): Ditto. (DOMCSSValueListFunc::tryCall): Ditto.
  • khtml/ecma/kjs_dom.cpp: (DOMCharacterDataProtoFunc::tryCall): Ditto. (DOMTextProtoFunc::tryCall): Ditto.
  • khtml/ecma/kjs_events.cpp: (DOMUIEventProtoFunc::tryCall): Ditto. (DOMMouseEventProtoFunc::tryCall): Ditto. (DOMKeyboardEventProtoFunc::tryCall): Ditto. (DOMMutationEventProtoFunc::tryCall): Ditto.
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElementFunction::tryCall): Ditto. (KJS::HTMLElement::putValue): Ditto. (KJS::HTMLSelectCollection::tryPut): Ditto.
  • khtml/ecma/kjs_range.cpp: (DOMRangeProtoFunc::tryCall): Ditto.
  • khtml/ecma/kjs_traversal.cpp: (JSNodeFilter::acceptNode): Ditto.
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Ditto. (HistoryFunc::tryCall): Ditto.
10:42 AM Changeset in webkit [6022] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fix at least some of <rdar://problem/3546393>: 10,000 leaks, many of DOM::AtomicString::add, after one run of cvs-base
  • khtml/xml/dom_atomicstring.cpp: (DOM::AtomicString::add): Remove extra allocation of strings. This should speed things up a bit as well as fixing one big leak.
10:11 AM Changeset in webkit [6021]
  • 2 copies
    3 deletes in tags/WebKit-126~0~1

This commit was manufactured by cvs2svn to create tag
'WebKit-126~0~1'.

10:11 AM Changeset in webkit [6020] by darin
  • 2 edits in trunk/WebKit
  • fixed build failure on Merlot
  • Misc.subproj/WebNSPasteboardExtras.m: Import just CoreTranslationFlavorTypeNames.h rather than all of ApplicationServicesPriv.h; should compile faster and avoid build failure.
9:47 AM Changeset in webkit [6019] by cblu
  • 12 edits in trunk

WebCore:

Fixed: <rdar://problem/3546379>: support for editing via drag & drop

Reviewed by kocienda.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::deleteSelection): fixed a crash I encountered while attempting to delete and empty selection
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge isSelectionEditable]): renamed from isEditable (-[WebCoreBridge moveCaretToPoint:]): new (-[WebCoreBridge elementAtPoint:]): added support for WebCoreElementHTMLStringKey and WebCoreElementIsEditableKey

WebKit:

Fixed: <rdar://problem/3546379>: support for editing via drag & drop

Reviewed by kocienda.

  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:fileWrapper:rect:URL:title:HTMLString:event:]): added a HTMLString argument so that we retain all attributes when dragging images
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _canDelete]): call renamed isSelectionEditable (-[WebHTMLView _canPaste]): call renamed isSelectionEditable (-[WebHTMLView _pasteHTMLFromPasteboard:]): new, factored out from paste: (-[WebHTMLView _handleMouseDragged:]): removed code that returned early if we were loading, this kind of protection is no longer needed since we now retain the view while dragging, call renamed _web_dragImage (-[WebHTMLView initWithFrame:]): register for drop types (-[WebHTMLView paste:]): call _pasteHTMLFromPasteboard (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): set new isDragging BOOL to YES (-[WebHTMLView draggedImage:endedAt:operation:]): set new isDragging BOOL to NO (-[WebHTMLView draggingEntered:]): new (-[WebHTMLView draggingUpdated:]): new, handle caret movement during the drag (-[WebHTMLView prepareForDragOperation:]): new (-[WebHTMLView performDragOperation:]): new (-[WebHTMLView concludeDragOperation:]): new, paste in the drag
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebImageView.m: (-[WebImageView mouseDragged:]): call renamed _web_dragImage
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m:
Note: See TracTimeline for information about the timeline view.