Timeline



Feb 15, 2004:

11:54 AM Changeset in webkit [6091] by darin
  • 2 edits in trunk/WebKit

Reviewed by Dave.

  • WebKit.pbproj/project.pbxproj: Tweak build styles a bit, fixing OptimizedWithSymbols, and removing redundant settings of things that match defaults in other build styles.
11:51 AM Changeset in webkit [6090] by darin
  • 2 edits in trunk/WebCore

Reviewed by Dave.

  • WebCore.pbproj/project.pbxproj: Tweak build styles a bit, fixing OptimizedWithSymbols, and removing redundant settings of things that match defaults in other build styles.
11:51 AM Changeset in webkit [6089] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Dave.

  • JavaScriptCore.pbproj/project.pbxproj: Tweak build styles a bit, fixing OptimizedWithSymbols, and removing redundant settings of things that match defaults in other build styles.
10:50 AM Changeset in webkit [6088] by darin
  • 2 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3548533: crash in XMLHttpRequest::slotData using Orkut's rating system
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::~XMLHttpRequest): Delete the QObject side, which has a side effect of disconnecting the signals which seem to be firing after the request is gone. There may be another way of addressing the crash by correcting some other problem with killing the job, but this demonstrably works and fixes a storage leak.

Feb 13, 2004:

6:10 PM Changeset in webkit [6087] by mjs
  • 7 edits in trunk

WebCore:

Reviewed by John.

  • redo visited link history checking for a 2% speed improvement
  • kwq/KWQKHistoryProvider.mm: (KParts::HistoryProvider::contains): Don't make a KURL or an NSString. Punt on canonicalization and directly pass the internal Latin1 or unicode buffer.
  • kwq/KWQString.h:
  • kwq/KWQString.mm: (QString::hasFastLatin1): New method to check whether getting the latin1 buffer is fast (doesn't allocate).
  • kwq/WebCoreHistory.h: add new methods to look up by raw latin1 or unicode buffer instead of NSString.

WebKit:

Reviewed by John.

  • redo visited link history checking for a 2% speed improvement
  • History.subproj/WebHistory.m: (-[_WebCoreHistoryProvider containsItemForURLString:]): Removed. (-[_WebCoreHistoryProvider containsItemForURLLatin1:length:]): Implemented. For https and http URLs with empty path, add a slash. Make a CFString using the passed-in latin1 buffer without copying. (-[_WebCoreHistoryProvider containsItemForURLUnicode:length:]): Ditto for unicode. (matchLetter): New static helper function. (matchUnicodeLetter): Ditto.
2:39 PM Changeset in webkit [6086] by rjw
  • 14 edits
    13 adds in trunk/JavaScriptCore

rk towards the JavaScript ObjC bindings. The bindings now work for

simple scalar types. testbindings.mm is an illustration of how the
bindings work.

Reviewed by Ken.

  • JavaScriptCore.pbproj/project.pbxproj:
  • Makefile.am:
  • bindings/jni/jni_class.cpp: (JavaClass::methodsNamed):
  • bindings/jni/jni_class.h:
  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_runtime.h: (KJS::Bindings::JavaMethod::returnType):
  • bindings/make_testbindings: Added.
  • bindings/objc/objc_class.h: Added. (KJS::Bindings::ObjcClass::~ObjcClass): (KJS::Bindings::ObjcClass::ObjcClass): (KJS::Bindings::ObjcClass::operator=): (KJS::Bindings::ObjcClass::constructorAt): (KJS::Bindings::ObjcClass::numConstructors):
  • bindings/objc/objc_class.mm: Added. (ObjcClass::_commonDelete): (ObjcClass::_commonCopy): (ObjcClass::_commonInit): (_createClassesByIsAIfNecessary): (ObjcClass::classForIsA): (ObjcClass::ObjcClass): (ObjcClass::name): (ObjcClass::methodsNamed): (ObjcClass::fieldNamed):
  • bindings/objc/objc_header.h: Added.
  • bindings/objc/objc_instance.h: Added. (KJS::Bindings::ObjcInstance::getObject):
  • bindings/objc/objc_instance.mm: Added. (ObjcInstance::ObjcInstance): (ObjcInstance::~ObjcInstance): (ObjcInstance::operator=): (ObjcInstance::begin): (ObjcInstance::end): (ObjcInstance::getClass): (ObjcInstance::invokeMethod): (ObjcInstance::defaultValue): (ObjcInstance::stringValue): (ObjcInstance::numberValue): (ObjcInstance::booleanValue): (ObjcInstance::valueOf):
  • bindings/objc/objc_jsobject.h: Added.
  • bindings/objc/objc_jsobject.mm: Added.
  • bindings/objc/objc_runtime.h: (KJS::Bindings::ObjcField::~ObjcField): (KJS::Bindings::ObjcField::ObjcField): (KJS::Bindings::ObjcField::operator=): (KJS::Bindings::ObjcMethod::ObjcMethod): (KJS::Bindings::ObjcMethod::~ObjcMethod): (KJS::Bindings::ObjcMethod::operator=):
  • bindings/objc/objc_runtime.mm: Added. (ObjcMethod::ObjcMethod): (ObjcMethod::name): (ObjcMethod::numParameters): (ObjcMethod::getMethodSignature): (ObjcField::ObjcField): (ObjcField::name): (ObjcField::type): (ObjcField::valueFromInstance): (ObjcField::setValueToInstance):
  • bindings/objc/objc_utility.h: Added. (KJS::Bindings::):
  • bindings/objc/objc_utility.mm: Added. (KJS::Bindings::JSMethodNameToObjCMethodName): (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue): (KJS::Bindings::objcValueTypeForType):
  • bindings/runtime.cpp: (MethodList::MethodList): (MethodList::operator=): (Instance::setValueOfField): (Instance::createBindingForLanguageInstance): (Instance::createRuntimeObject):
  • bindings/runtime.h:
  • bindings/runtime_method.cpp: (RuntimeMethodImp::RuntimeMethodImp): (RuntimeMethodImp::get): (RuntimeMethodImp::call):
  • bindings/runtime_method.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::get): (RuntimeObjectImp::hasProperty):
  • bindings/test.js: Added.
  • bindings/testbindings.mm: Added. (-[MySecondInterface init]): (-[MyFirstInterface init]): (-[MyFirstInterface dealloc]): (+[MyFirstInterface JavaScriptNameForSelector:]): (-[MyFirstInterface getInt]): (-[MyFirstInterface setInt:]): (-[MyFirstInterface getMySecondInterface]): (-[MyFirstInterface logMessage:]): (GlobalImp::className): (readJavaScriptFromFile): (main):
12:08 PM Changeset in webkit [6085] by vicki
  • 3 edits in trunk

Set version to '129u'. The tree is open!

12:04 PM Changeset in webkit [6084]
  • 3 copies in tags/Safari-128

This commit was manufactured by cvs2svn to create tag 'Safari-128'.

12:04 PM Changeset in webkit [6083] by vicki
  • 6 edits in trunk

Safari-128 stamp

Feb 12, 2004:

3:58 PM Changeset in webkit [6082] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3557850 and 3557607. Make sure to setParent(0) on the body's link declaration, so that TreeShared
will delete it.

  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::~HTMLBodyElementImpl):
2:40 PM Changeset in webkit [6081] by kocienda
  • 9 edits
    2 adds in trunk/WebCore

Reviewed by Hyatt

Refactored object design for edit commands into something that's
starting to feel more solid. Added some accessors to edit
commands.

  • WebCore.pbproj/project.pbxproj:
  • khtml/editing/htmlediting_impl.h: Added.
  • khtml/editing/htmlediting_impl.m: Added.
12:04 AM Changeset in webkit [6080] by hyatt
  • 1 edit in trunk/WebCore/khtml/rendering/render_block.cpp

Adjust shouldCollapseChild as per dirk's suggestion.

Feb 11, 2004:

5:50 PM Changeset in webkit [6079] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3550005, 936 leaks when loading checkbox page of pain. Make sure to nuke the inline box
wrapper when detaching the RenderWidget.

  • khtml/rendering/render_replaced.cpp: (RenderWidget::detach):
5:33 PM Changeset in webkit [6078] by hyatt
  • 2 edits
    4 adds in trunk

Add some more polish to ensure the ypos estimate is right. Correct the clearing of images so that
their top margins do not get added in when they clear the float because of having a large width.

Reviewed by kocienda

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlockChildren):
  • layout-tests/fast/block/margin-collapse/101-expected.txt: Added.
  • layout-tests/fast/block/margin-collapse/101.html: Added.
  • layout-tests/fast/block/margin-collapse/102-expected.txt: Added.
  • layout-tests/fast/block/margin-collapse/102.html: Added.
4:49 PM Changeset in webkit [6077] by hyatt
  • 2 adds in trunk/LayoutTests/fast/block/margin-collapse

Adding test of zeldman margin collapse bug.

4:47 PM Changeset in webkit [6076] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3556702, margin collapsing gets disabled when images spill out of the containing block.

Reviewed by kocienda

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlockChildren):
2:08 PM Changeset in webkit [6075] by hyatt
  • 2 adds in trunk/LayoutTests/fast/table

Add layout test that dumps .rows and .cells

2:07 PM Changeset in webkit [6074] by hyatt
  • 2 edits in trunk/WebCore

Fix the .rows and .cells arrays on tables by merging with the KHTML trunk. TH was being included
as a row instead of as a cell.

Reviewed by kocienda

  • khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::calcLength): (HTMLCollectionImpl::getItem): (HTMLCollectionImpl::getNamedItem):
1:47 PM Changeset in webkit [6073] by hyatt
  • 3 edits in trunk/WebCore

Remove my bogus refs of the elementSheet. Fixes 3554213 and 3555467.

  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::createLinkDecl):
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::additionalAttributeStyleDecl): (HTMLTableElementImpl::getSharedCellDecl):
1:45 PM Changeset in webkit [6072]
  • 3 copies
    3 deletes in tags/JavaScriptCore-125~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-125~1'.

1:45 PM Changeset in webkit [6071] by vicki
  • 2 edits in branches/SUPanFeldspar-branch/JavaScriptCore

-rolled this change onto the SUPanFeldspar branch

2004-01-30 Richard Williamson <​rjw@apple.com>

Fixed 3542044. Create KJS::String using UString constructor

instead of passing UTF8 string to char* constructor.

Reviewed by Darin.

  • bindings/jni/jni_instance.cpp: (JavaInstance::stringValue):
1:37 PM Changeset in webkit [6070] by hyatt
  • 2 adds in trunk/LayoutTests/fast/css-generated-content

Adding test for display:block generated content.

1:37 PM Changeset in webkit [6069] by hyatt
  • 25 edits in trunk

Fix for 3556037, regression where display:block generated content didn't work.

Reviewed by kocienda

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::setStyle): (khtml::RenderBlock::addChildToFlow): (khtml::RenderBlock::removeChild): (khtml::RenderBlock::renderName):
  • khtml/rendering/render_container.cpp: (RenderContainer::insertChildNode): (RenderContainer::removeLeftoverAnonymousBoxes):
  • khtml/rendering/render_inline.cpp: (RenderInline::splitFlow): (RenderInline::renderName):
  • khtml/rendering/render_list.cpp: (RenderListItem::updateMarkerLocation):
  • khtml/rendering/render_object.h: (khtml::RenderObject::isAnonymousBlock):
  • layout-tests/css1/pseudo/firstletter-expected.txt:
  • layout-tests/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • layout-tests/fast/css-generated-content/002-expected.txt:
  • layout-tests/fast/css-generated-content/004-expected.txt:
  • layout-tests/fast/css-generated-content/005-expected.txt:
  • layout-tests/fast/css-generated-content/006-expected.txt:
  • layout-tests/fast/css-generated-content/007-expected.txt:
  • layout-tests/fast/css-generated-content/009-expected.txt:
  • layout-tests/fast/css-generated-content/010-expected.txt:
  • layout-tests/fast/selectors/039-expected.txt:
  • layout-tests/fast/selectors/039b-expected.txt:
  • layout-tests/fast/selectors/041-expected.txt:
  • layout-tests/fast/selectors/042-expected.txt:
  • layout-tests/fast/selectors/166a-expected.txt:
  • layout-tests/fast/selectors/168-expected.txt:
  • layout-tests/fast/selectors/168a-expected.txt:
  • layout-tests/fast/selectors/169-expected.txt:
  • layout-tests/fast/selectors/169a-expected.txt:
  • layout-tests/fast/text/firstline/002-expected.txt:
  • layout-tests/fast/text/firstline/003-expected.txt:
11:56 AM Changeset in webkit [6068] by rjw
  • 2 edits in trunk/WebCore

Reviewed by Richard.

  • kwq/KWQTextCodec.mm: (KWQTextDecoder::convertLatin1): Fix off by one error.
11:52 AM Changeset in webkit [6067] by hyatt
  • 29 edits in trunk/WebCore

Convert paint methods over to use a new PaintInfo struct. Eliminate the paintObject method.

Reviewed by kocienda

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::paint): (khtml::RenderBlock::paintObject): (khtml::RenderBlock::paintFloats):
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_box.cpp: (RenderBox::paint): (RenderBox::paintRootBoxDecorations): (RenderBox::paintBoxDecorations):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_br.h: (khtml::RenderBR::paint):
  • khtml/rendering/render_canvas.cpp: (RenderCanvas::paint): (RenderCanvas::paintBoxDecorations):
  • khtml/rendering/render_canvas.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::paintLineBoxBackgroundBorder): (RenderFlow::paintLineBoxDecorations):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_form.cpp: (RenderFieldset::paintBoxDecorations):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_image.cpp: (RenderImage::paint): (RenderImage::updateFromElement):
  • khtml/rendering/render_image.h:
  • khtml/rendering/render_inline.cpp: (RenderInline::paint):
  • khtml/rendering/render_inline.h:
  • khtml/rendering/render_layer.cpp: (RenderLayer::paintLayer):
  • khtml/rendering/render_line.cpp: (InlineFlowBox::paintBackgroundAndBorder): (InlineFlowBox::paintDecorations):
  • khtml/rendering/render_line.h: (khtml::InlineRunBox::paintBackgroundAndBorder): (khtml::InlineRunBox::paintDecorations):
  • khtml/rendering/render_list.cpp: (RenderListItem::paint): (RenderListMarker::paint):
  • khtml/rendering/render_list.h:
  • khtml/rendering/render_object.cpp: (RenderObject::paint):
  • khtml/rendering/render_object.h: (khtml::RenderObject::PaintInfo::PaintInfo): (khtml::RenderObject::paintBoxDecorations):
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::shouldPaint): (RenderWidget::paint):
  • khtml/rendering/render_replaced.h:
  • khtml/rendering/render_table.cpp: (RenderTable::paint): (RenderTable::paintBoxDecorations): (RenderTableSection::paint): (RenderTableCell::paint): (RenderTableCell::paintBoxDecorations):
  • khtml/rendering/render_table.h:
  • khtml/rendering/render_text.cpp: (RenderText::paint):
  • khtml/rendering/render_text.h:
9:00 AM Changeset in webkit [6066] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by me

Removed include file I was considering checking, but
decided against. Of course, this dangling include
broke the build.

  • kwq/KWQKHTMLPart.mm
  • kwq/WebCoreBridge.mm
Note: See TracTimeline for information about the timeline view.