Timeline



Feb 20, 2004:

5:06 PM Changeset in webkit [6106] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3552346>: REGRESSION 100-125: nil-dereference in KHTMLPart::isPointInsideSelection (progz.ru, many other sites)

  • khtml/rendering/render_layer.cpp: (RenderLayer::nodeAtPointForLayer): To cover the case of positioned generated content, make sure to find an element if we don't have one yet when we get to the layer level.
4:51 PM Changeset in webkit [6105] by vicki
  • 3 edits in trunk

set version from '129' to '130u'. the tree is open!

4:46 PM Changeset in webkit [6104]
  • 3 copies in tags/Safari-129

This commit was manufactured by cvs2svn to create tag 'Safari-129'.

4:46 PM Changeset in webkit [6103] by vicki
  • 6 edits in trunk

Safari-129 stamp

3:53 PM Changeset in webkit [6102] by vicki
  • 2 edits in trunk/WebKit

Reviewed by mjs.

  • fix build breakage caused by removal of kWindowNoBufferingAttribute.
  • Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): always used a retained backing store type
10:57 AM Changeset in webkit [6101] by cblu
  • 27 edits in trunk

Tests:

Reviewed by dave.

  • Blot/BlotDocument.m: (-[BlotDocument dataRepresentationOfType:]): call renamed HTMLString on WebHTMLRepresentation

WebCore:

Fixed: <rdar://problem/3563402>: when copying HTML, relative URLs should be made absolute

  • Added isSubresourceURLAttribute to ElementImpl which is overridden by subclasses determine if an attribute refers to a subresource.
  • Added isURLAttribute to ElementImpl which is overridden by subclasses determine if an attribute refers to any kind of URL.

Reviewed by Dave.

  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::isSubresourceURLAttribute): (HTMLFrameElementImpl::isSubresourceURLAttribute): (HTMLIFrameElementImpl::openURL): (HTMLIFrameElementImpl::isSubresourceURLAttribute):
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::isURLAttribute):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::isSubresourceURLAttribute): (HTMLScriptElementImpl::id): (HTMLScriptElementImpl::isSubresourceURLAttribute):
  • khtml/html/html_headimpl.h:
  • khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::isSubresourceURLAttribute): (HTMLAreaElementImpl::getRegion): (HTMLAreaElementImpl::isSubresourceURLAttribute):
  • khtml/html/html_imageimpl.h:
  • khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isURLAttribute):
  • khtml/html/html_inlineimpl.h:
  • khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::isSubresourceURLAttribute): (HTMLObjectElementImpl::isSubresourceURLAttribute): (HTMLParamElementImpl::parseHTMLAttribute): (HTMLParamElementImpl::isSubresourceURLAttribute):
  • khtml/html/html_objectimpl.h:
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::isSubresourceURLAttribute): (HTMLTableCellElementImpl::attach): (HTMLTableCellElementImpl::isSubresourceURLAttribute):
  • khtml/html/html_tableimpl.h:
  • khtml/xml/dom2_rangeimpl.cpp: (RangeImpl::toHTMLWithOptions): take completeURLs and subresourceURLs arguments (RangeImpl::toHTML): call toHTMLWithOptions with default options
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::isURLAttribute): (ElementImpl::isSubresourceURLAttribute):
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::recursive_toHTMLWithOptions): take completeURLs and subresourceURLs arguments (NodeImpl::recursive_toHTML): call recursive_toHTML with default options
  • khtml/xml/dom_nodeimpl.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge selectedHTML:]): renamed to return subresource URL strings

WebKit:

Fixed: <rdar://problem/3563402>: when copying HTML, relative URLs should be made absolute

Reviewed by dave.

  • WebView.subproj/WebHTMLRepresentation.h:
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation HTMLString]): renamed from reconstructed source to be more analogous with other data get methods
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _writeSelectionToPasteboard:]): call renamed selectedHTML on the bridge

Feb 19, 2004:

3:14 PM Changeset in webkit [6100] by sullivan
  • 2 edits in trunk/WebKit

WebKit:

  • WebKit part of fix for <rdar://problem/3292380>: Cycle Tabs keyboard shortcut (cmd-shift-arrows) conflicts with text editing

Reviewed by Chris.

  • WebView.subproj/WebFrameView.m: (-[WebFrameView keyDown:]): If shift key is down along with an arrow key, call super rather than eating event since we don't handle any shifted events here.

WebBrowser:

  • fixed <rdar://problem/3292380>: Cycle Tabs keyboard shortcut (cmd-shift-arrows) conflicts with text editing

Reviewed by Chris.

  • BrowserNSEventExtras.h:
  • BrowserNSEventExtras.m: (-[NSEvent isCommandLeftArrowKeyDown]): (-[NSEvent isCommandRightArrowKeyDown]): New methods
  • BrowserWindow.m: (-[BrowserWindow keyDown:]): Still honor old shortcuts of command-shift-arrows, but only if no other view has intercepted them already.
  • English.lproj/MainMenu.nib: Changed keyboard shortcuts for Select Next Tab and Select Previous Tab menu items to option-command-] and [
  • Debug/Shortcuts.html: Updated for these changes

Feb 18, 2004:

4:14 PM Changeset in webkit [6099] by rjw
  • 1 edit in trunk/JavaScriptCore/bindings/objc/objc_runtime.mm

Fixed Deployment build problem (longjmp clobber warning)

2:30 PM Changeset in webkit [6098] by rjw
  • 3 edits in trunk/JavaScriptCore

Added NSNumber/Number conversion.

Removed some unnecessary KJS
namespace specifiers.

Reviewed by Ken.

  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue):
  • bindings/runtime_array.h:
1:58 PM Changeset in webkit [6097] by rjw
  • 11 edits in trunk/JavaScriptCore

Added support for export NSArrays.

Updated valueAt() to take an ExecState so we can throw
JS exceptions.

Implemented excludeSelectorFromJavaScript: in ObjcClass. This allows
ObjectiveC classes to control the visibility of their methods in
JavaScript.

Reviewed by Ken.

  • bindings/jni/jni_runtime.cpp: (JavaField::valueFromInstance): (JavaArray::valueAt):
  • bindings/jni/jni_runtime.h:
  • bindings/objc/objc_class.mm: (ObjcClass::methodsNamed):
  • bindings/objc/objc_runtime.h: (KJS::Bindings::ObjcArray::getObjcArray):
  • bindings/objc/objc_runtime.mm: (ObjcField::valueFromInstance): (ObjcField::setValueToInstance): (ObjcArray::ObjcArray): (ObjcArray::~ObjcArray): (ObjcArray::operator=): (ObjcArray::setValueAt): (ObjcArray::valueAt): (ObjcArray::getLength):
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue):
  • bindings/runtime.cpp: (Instance::getValueOfField):
  • bindings/runtime.h:
  • bindings/runtime_array.cpp: (RuntimeArrayImp::get):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::get):

Feb 17, 2004:

5:56 PM Changeset in webkit [6096] by rjw
  • 4 edits in trunk/JavaScriptCore

Added String <-> NSString conversion.
Added tests of String <-> NSString conversion to test program.

Reviewed by Chris.

  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue):
  • bindings/test.js:
  • bindings/testbindings.mm: (-[MyFirstInterface getString]):
4:45 PM Changeset in webkit [6095] by mjs
  • 6 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3537397>: REGRESSION (100-114): Return doesn't work in Japanese input method for some HomePage fields

  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView keyDown:]): Don't send events through DOM when there is marked text. (-[KWQTextAreaTextView keyUp:]): Ditto.
  • kwq/KWQTextField.mm: (-[KWQTextField textView:shouldHandleEvent:]): Ditto. (-[KWQSecureTextField textView:shouldHandleEvent:]): Ditto.
  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::defaultEventHandler): No need to check for marked text on "return" any more, because we won't send key events through the DOM at all when there is marked text.
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: Removed haveMarkedText method, no longer used by anything.

Feb 16, 2004:

11:18 AM Changeset in webkit [6094] by cblu
  • 9 edits in trunk/WebCore

WebCore side of pasting image data.

Reviewed by kocienda.

  • khtml/editing/htmlediting.cpp: (PasteImageCommand::PasteImageCommand): new (PasteImageCommand::~PasteImageCommand): new (PasteImageCommand::impl): new
  • khtml/editing/htmlediting.h: (khtml::):
  • khtml/editing/htmlediting_impl.cpp: (EditCommandImpl::name): added support for PasteImageCommandID (CompositeEditCommandImpl::insertNodeAt): new, factored out from PasteHTMLCommandImpl::apply (PasteHTMLCommandImpl::apply): call insertNodeAt (PasteImageCommandImpl::PasteImageCommandImpl): new (PasteImageCommandImpl::~PasteImageCommandImpl): new (PasteImageCommandImpl::apply): new
  • khtml/editing/htmlediting_impl.h:
  • khtml/khtml_part.cpp: (KHTMLPart::pasteHTMLString): unchanged (KHTMLPart::pasteImage): new
  • khtml/khtml_part.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge pasteImageWithURL:]): new
10:18 AM Changeset in webkit [6093] by darin
  • 2 edits in trunk/WebCore

Reviewed by Ken.

  • Fixed some dynamic casts that Dirk complained about to use virtual functions instead. Since the virtual functions were already there, this is faster and better in most ways anyway.
  • khtml/dom/dom2_events.cpp: (UIEvent::keyCode): Use virtual function instead of dynamic_cast. (UIEvent::charCode): Ditto. (UIEvent::pageX): Ditto. (UIEvent::pageY): Ditto. (UIEvent::layerX): Ditto. (UIEvent::layerY): Ditto. (UIEvent::which): Ditto.
8:19 AM Changeset in webkit [6092] by darin
  • 4 edits
    2 deletes in trunk/WebKit

Reviewed by John and Don.

  • discovered that jaguar.com doesn't need spoofing any more, so removed the spoofing machinery entirely; if we ever have to bring it back we can, but I doubt we will
  • WebView.subproj/WebView.m: Removed include of WebUserAgentSpoofTable.c. (-[WebViewPrivate dealloc]): Release the new single userAgent rather than the array and userAgentOverride we used to. (-[WebView _preferencesChangedNotification:]): Release the single user agent, rather than the entire cache. Also only do it when the user agent is not overridden. (-[WebView setApplicationNameForUserAgent:]): Ditto. (-[WebView setCustomUserAgent:]): Set the new userAgentOverridden boolean, and also set userAgent itself. (-[WebView customUserAgent]): Return userAgent, but only if userAgentOverridden is true. (-[WebView userAgentForURL:]): Simplify, now that there's no automatic spoofing to do. Made even simpler by the fact that custom and computed user agents both share the same field now.
  • WebView.subproj/WebViewPrivate.h: Got rid of UserAgentStringType, turned the userAgent field into a single item instead of an array, and replaced the userAgentOverride field with a boolean userAgentOverridden field.
  • Makefile.am: Removed the rule to build WebUserAgentSpoofTable.c.
  • WebView.subproj/WebUserAgentSpoofTable.c: Removed.
  • WebView.subproj/WebUserAgentSpoofTable.gperf: Removed.
Note: See TracTimeline for information about the timeline view.