⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 23, 2004:

3:33 PM Changeset in webkit [6110] by hyatt
  • 5 edits in trunk/WebCore

Fix for 3549772, hangs on border collapsing.

Reviewed by darin

  • khtml/rendering/render_object.cpp: (RenderObject::collectBorders):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_table.cpp: (RenderTable::paint): (compareBorders): (RenderTableCell::paint): (addBorderStyle): (RenderTableCell::collectBorders):
  • khtml/rendering/render_table.h:
1:39 PM Changeset in webkit [6109] by hyatt
  • 2 adds in trunk/LayoutTests/fast/block/margin-collapse

Adding test for 3560033 fix.

1:31 PM Changeset in webkit [6108] by hyatt
  • 4 edits in trunk/LayoutTests/fast

Updating layout tests to reflect br fixes.

1:26 PM Changeset in webkit [6107] by hyatt
  • 27 edits in trunk/WebCore

Fix for 3558717, make sure that form elements that are removed from a document also remove themselves
from the form.

Reviewed by darin.

  • khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::removedFromDocument):
  • khtml/html/html_formimpl.h:
  • khtml/xml/dom_nodeimpl.cpp:
  • khtml/xml/dom_nodeimpl.h:

Implement smarter line layout for faster typing and repainting when individual lines change.

Reviewed by kocienda.

  • khtml/khtmlview.cpp: (KHTMLViewPrivate::KHTMLViewPrivate): (KHTMLViewPrivate::~KHTMLViewPrivate): (KHTMLViewPrivate::reset): (KHTMLView::addRepaintInfo): (KHTMLView::layout):
  • khtml/khtmlview.h:
  • khtml/rendering/bidi.cpp: (khtml::Bidinext): (khtml::appendRun): (khtml::embed): (khtml::RenderBlock::constructLine): (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::computeVerticalPositionsForLine): (khtml::RenderBlock::bidiReorderLine): (khtml::buildCompactRuns): (khtml::RenderBlock::layoutInlineChildren): (khtml::RenderBlock::determineStartPosition): (khtml::RenderBlock::determineEndPosition): (khtml::RenderBlock::matchedEndLine): (khtml::RenderBlock::findNextLineBreak):
  • khtml/rendering/render_block.cpp: (khtml:::RenderFlow): (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::positionNewFloats): (khtml::RenderBlock::lowestPosition): (khtml::RenderBlock::rightmostPosition): (khtml::RenderBlock::leftmostPosition):
  • khtml/rendering/render_block.h: (khtml::RenderBlock::firstRootBox): (khtml::RenderBlock::lastRootBox): (khtml::RenderBlock::setLinesAppended): (khtml::RenderBlock::linesAppended):
  • khtml/rendering/render_box.cpp: (RenderBox::dirtyLineBoxes): (RenderBox::deleteLineBoxWrapper): (RenderBox::setInlineBoxWrapper):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_br.cpp: (RenderBR::createInlineBox): (RenderBR::position):
  • khtml/rendering/render_br.h:
  • khtml/rendering/render_container.cpp: (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::placeChild):
  • khtml/rendering/render_flow.cpp: (RenderFlow::extractLineBox): (RenderFlow::attachLineBox): (RenderFlow::removeLineBox): (RenderFlow::dirtyLinesFromChangedChild): (RenderFlow::dirtyLineBoxes): (RenderFlow::createInlineBox):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_line.cpp: (InlineBox::dirtyLineBoxes): (InlineBox::deleteLine): (InlineBox::extractLine): (InlineBox::attachLine): (InlineBox::adjustVerticalPosition): (InlineBox::root): (InlineBox::nextOnLineExists): (InlineBox::prevOnLineExists): (InlineFlowBox::removeChild): (InlineFlowBox::deleteLine): (InlineFlowBox::extractLine): (InlineFlowBox::attachLine): (InlineFlowBox::adjustVerticalPosition): (InlineFlowBox::verticallyAlignBoxes): (InlineFlowBox::adjustMaxAscentAndDescent): (RootInlineBox::adjustVerticalPosition): (RootInlineBox::childRemoved):
  • khtml/rendering/render_line.h: (khtml::InlineBox::m_extracted): (khtml::InlineBox::setExtracted): (khtml::InlineBox::object): (khtml::InlineBox::parent): (khtml::InlineBox::isDirty): (khtml::InlineBox::markDirty): (khtml::InlineFlowBox::prevFlowBox): (khtml::InlineFlowBox::nextFlowBox): (khtml::RootInlineBox::RootInlineBox): (khtml::RootInlineBox::nextRootBox): (khtml::RootInlineBox::prevRootBox): (khtml::RootInlineBox::setLineBreakInfo): (khtml::RootInlineBox::setLineBreakPos): (khtml::RootInlineBox::setBlockHeight): (khtml::RootInlineBox::setEndsWithBreak): (khtml::RootInlineBox::blockHeight): (khtml::RootInlineBox::endsWithBreak): (khtml::RootInlineBox::lineBreakObj): (khtml::RootInlineBox::lineBreakPos):
  • khtml/rendering/render_object.cpp: (RenderObject::repaintAfterLayoutIfNeeded): (RenderObject::repaintObjectsBeforeLayout): (RenderObject::dirtyLinesFromChangedChild): (RenderObject::createInlineBox): (RenderObject::dirtyLineBoxes): (RenderObject::setInlineBoxWrapper): (RenderObject::deleteLineBoxWrapper):
  • khtml/rendering/render_object.h: (khtml::RenderObject::RepaintInfo::m_repaintRect):
  • khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows):
  • khtml/rendering/render_text.cpp: (InlineTextBox::deleteLine): (InlineTextBox::extractLine): (InlineTextBox::attachLine): (RenderText::RenderText): (RenderText::detach): (RenderText::extractTextBox): (RenderText::attachTextBox): (RenderText::removeTextBox): (RenderText::setTextWithOffset): (RenderText::setText): (RenderText::dirtyLineBoxes): (RenderText::createInlineBox):
  • khtml/rendering/render_text.h: (khtml::InlineTextBox::start): (khtml::InlineTextBox::end): (khtml::InlineTextBox::offsetRun):
  • khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::setData): (CharacterDataImpl::appendData): (CharacterDataImpl::insertData): (CharacterDataImpl::deleteData): (CharacterDataImpl::replaceData): (TextImpl::splitText):
  • kwq/KWQRenderTreeDebug.cpp: (write):

RenderBlock contains two other fixes. The first is a fix to rightmost/lowestPosition to properly add in
margins to floats.

Reviewed by mjs

The second fix is to repair a bug in block-level replaced elements with margins. If the floats they moved to
dodge can fit in their margins, then they don't technically have to move at all.

Reviewed by john

Feb 20, 2004:

5:06 PM Changeset in webkit [6106] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3552346>: REGRESSION 100-125: nil-dereference in KHTMLPart::isPointInsideSelection (progz.ru, many other sites)

  • khtml/rendering/render_layer.cpp: (RenderLayer::nodeAtPointForLayer): To cover the case of positioned generated content, make sure to find an element if we don't have one yet when we get to the layer level.
4:51 PM Changeset in webkit [6105] by vicki
  • 3 edits in trunk

set version from '129' to '130u'. the tree is open!

4:46 PM Changeset in webkit [6104]
  • 3 copies in tags/Safari-129

This commit was manufactured by cvs2svn to create tag 'Safari-129'.

4:46 PM Changeset in webkit [6103] by vicki
  • 6 edits in trunk

Safari-129 stamp

3:53 PM Changeset in webkit [6102] by vicki
  • 2 edits in trunk/WebKit

Reviewed by mjs.

  • fix build breakage caused by removal of kWindowNoBufferingAttribute.
  • Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): always used a retained backing store type
10:57 AM Changeset in webkit [6101] by cblu
  • 27 edits in trunk

Tests:

Reviewed by dave.

  • Blot/BlotDocument.m: (-[BlotDocument dataRepresentationOfType:]): call renamed HTMLString on WebHTMLRepresentation

WebCore:

Fixed: <rdar://problem/3563402>: when copying HTML, relative URLs should be made absolute

  • Added isSubresourceURLAttribute to ElementImpl which is overridden by subclasses determine if an attribute refers to a subresource.
  • Added isURLAttribute to ElementImpl which is overridden by subclasses determine if an attribute refers to any kind of URL.

Reviewed by Dave.

  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::isSubresourceURLAttribute): (HTMLFrameElementImpl::isSubresourceURLAttribute): (HTMLIFrameElementImpl::openURL): (HTMLIFrameElementImpl::isSubresourceURLAttribute):
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::isURLAttribute):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::isSubresourceURLAttribute): (HTMLScriptElementImpl::id): (HTMLScriptElementImpl::isSubresourceURLAttribute):
  • khtml/html/html_headimpl.h:
  • khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::isSubresourceURLAttribute): (HTMLAreaElementImpl::getRegion): (HTMLAreaElementImpl::isSubresourceURLAttribute):
  • khtml/html/html_imageimpl.h:
  • khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isURLAttribute):
  • khtml/html/html_inlineimpl.h:
  • khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::isSubresourceURLAttribute): (HTMLObjectElementImpl::isSubresourceURLAttribute): (HTMLParamElementImpl::parseHTMLAttribute): (HTMLParamElementImpl::isSubresourceURLAttribute):
  • khtml/html/html_objectimpl.h:
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::isSubresourceURLAttribute): (HTMLTableCellElementImpl::attach): (HTMLTableCellElementImpl::isSubresourceURLAttribute):
  • khtml/html/html_tableimpl.h:
  • khtml/xml/dom2_rangeimpl.cpp: (RangeImpl::toHTMLWithOptions): take completeURLs and subresourceURLs arguments (RangeImpl::toHTML): call toHTMLWithOptions with default options
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::isURLAttribute): (ElementImpl::isSubresourceURLAttribute):
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::recursive_toHTMLWithOptions): take completeURLs and subresourceURLs arguments (NodeImpl::recursive_toHTML): call recursive_toHTML with default options
  • khtml/xml/dom_nodeimpl.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge selectedHTML:]): renamed to return subresource URL strings

WebKit:

Fixed: <rdar://problem/3563402>: when copying HTML, relative URLs should be made absolute

Reviewed by dave.

  • WebView.subproj/WebHTMLRepresentation.h:
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation HTMLString]): renamed from reconstructed source to be more analogous with other data get methods
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _writeSelectionToPasteboard:]): call renamed selectedHTML on the bridge

Feb 19, 2004:

3:14 PM Changeset in webkit [6100] by sullivan
  • 2 edits in trunk/WebKit

WebKit:

  • WebKit part of fix for <rdar://problem/3292380>: Cycle Tabs keyboard shortcut (cmd-shift-arrows) conflicts with text editing

Reviewed by Chris.

  • WebView.subproj/WebFrameView.m: (-[WebFrameView keyDown:]): If shift key is down along with an arrow key, call super rather than eating event since we don't handle any shifted events here.

WebBrowser:

  • fixed <rdar://problem/3292380>: Cycle Tabs keyboard shortcut (cmd-shift-arrows) conflicts with text editing

Reviewed by Chris.

  • BrowserNSEventExtras.h:
  • BrowserNSEventExtras.m: (-[NSEvent isCommandLeftArrowKeyDown]): (-[NSEvent isCommandRightArrowKeyDown]): New methods
  • BrowserWindow.m: (-[BrowserWindow keyDown:]): Still honor old shortcuts of command-shift-arrows, but only if no other view has intercepted them already.
  • English.lproj/MainMenu.nib: Changed keyboard shortcuts for Select Next Tab and Select Previous Tab menu items to option-command-] and [
  • Debug/Shortcuts.html: Updated for these changes
Note: See TracTimeline for information about the timeline view.