Timeline



Feb 25, 2004:

8:51 AM Changeset in webkit [6116] by sullivan
  • 8 edits in trunk

WebCore:

WebCore part of fix for <rdar://problem/3546370>: add a way to tab to menus,
checkmarks, and buttons without turning on Full Keyboard Acceess

Reviewed by Ken.

  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::tabsToAllControls): now checks for option-tab like tabsToLinks (KWQKHTMLPart::partForWidget): new method, extracted from bridgeForWidget (KWQKHTMLPart::bridgeForWidget): now calls extracted method
  • kwq/KWQButton.mm: (-[KWQButton canBecomeKeyView]): overridden to handle our rules about full keyboard access, different than NSView's rules
  • kwq/KWQComboBox.mm: (-[KWQPopUpButton canBecomeKeyView]): ditto
  • kwq/KWQListBox.mm: (-[KWQTableView canBecomeKeyView]): ditto

WebKit:

WebKit part of fix for <rdar://problem/3546370>: add a way to tab to menus,
checkmarks, and buttons without turning on Full Keyboard Acceess

Reviewed by Ken.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]): turn on WebCoreKeyboardAccessFull bit whenever we turn on WebCoreKeyboardAccessTabsToLinks bit

WebBrowser:

  • WebBrowser part of fix for <rdar://problem/3546370>: add a way to tab to menus, checkmarks, and buttons without turning on Full Keyboard Acceess
  • fixed <rdar://problem/3566996>: "Highlight each item" choice in Preferences should use a checkbox and have different wording

Reviewed by Ken.

  • Preferences.subproj/AdvancedPreferences.h:
  • Preferences.subproj/AdvancedPreferences.m: (systemIsInFullKeyboardAccessMode): new function, reads the state of the Full Keyboard Access setting (-[AdvancedPreferences updateTabToAllViews]): set checkbox instead of matrix; new wording for fine print; renamed method (-[AdvancedPreferences keyboardUIModeDidChange:]): notification callback; call updateTabToAllViews (-[AdvancedPreferences toggleTabToAll:]): new method, replaces takeTabToLinksSettingFrom: (-[AdvancedPreferences initializeFromDefaults]): call renamed method (-[AdvancedPreferences moduleWillBeRemoved]): stop observing notification for Full Keyboard Access mode change (-[AdvancedPreferences moduleWasInstalled]): start observing notification for Full Keyboard Access mode change
  • Preferences.subproj/English.lproj/AdvancedPreferences.nib: replace radio buttons with checkbox; rejigger positions
  • English.lproj/Localizable.strings:
  • English.lproj/StringsNotToBeLocalized.txt: Updated for these changes

Feb 24, 2004:

7:21 PM Changeset in webkit [6115] by cblu
  • 1 edit
    3 adds in trunk/WebKit

I forgot to add these files in my last check-in.

  • WebView.subproj/WebResource.h: Added.
  • WebView.subproj/WebResource.m: Added. (-[WebResourcePrivate dealloc]): (-[WebResource initWithData:URL:MIMEType:textEncodingName:]): (-[WebResource dealloc]): (-[WebResource data]): (-[WebResource URL]): (-[WebResource MIMEType]): (-[WebResource textEncodingName]): (+[WebResource _resourcesFromPropertyLists:]): (+[WebResource _propertyListsFromResources:]): (-[WebResource _initWithPropertyList:]): (-[WebResource _initWithCachedResponse:originalURL:]): (-[WebResource _propertyListRepresentation]): (-[WebResource _cachedResponseRepresentation]):
  • WebView.subproj/WebResourcePrivate.h: Added.
5:30 PM Changeset in webkit [6114] by cblu
  • 16 edits in trunk/WebKit

Tests:

Added support for WebHTMLPboardType.

Reviewed by rjw.

  • PasteboardViewer/PasteboardViewer.xcode/project.pbxproj:
  • PasteboardViewer/WindowController.m: (-[WindowController pasteboardTypes]): (-[WindowController reflectSelection]):

WebKit:

Fixed: <rdar://problem/3565476>: design/implement new pasteboard type for HTML that includes subresources

Reviewed by rjw.

  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate initWithStream:view:]): don't manage buffer, WebBaseResourceHandleDelegate does this now (-[WebNetscapePluginConnectionDelegate releaseResources]): ditto (-[WebNetscapePluginConnectionDelegate connection:didReceiveData:lengthReceived:]): ditto (-[WebNetscapePluginConnectionDelegate connectionDidFinishLoading:]): ditto
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate releaseResources]): release resourceData and resource (-[WebBaseResourceHandleDelegate loadWithRequest:]): check the dataSource for a resource, load that if we have one (-[WebBaseResourceHandleDelegate addData:]): new, adds data to resourceData (-[WebBaseResourceHandleDelegate saveResource]): new, saves data as a resource on the dataSource (-[WebBaseResourceHandleDelegate saveResourceWithCachedResponse:]): new, replaces the resource on the dataSource to save memory (-[WebBaseResourceHandleDelegate resourceData]): new (-[WebBaseResourceHandleDelegate connection:didReceiveData:lengthReceived:]): call addData: (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): call saveResource (-[WebBaseResourceHandleDelegate connection:willCacheResponse:]): new, calls saveResourceWithCachedResponse:
  • WebView.subproj/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): release subresources (-[WebDataSource subresources]): new, returns the subresources of the data source (-[WebDataSource subresourceForURL:]): new, returns a resource for a URL (-[WebDataSource addSubresource:]): new (-[WebDataSource addSubresources:]): new (-[WebDataSource _receivedData:]): added an assert (-[WebDataSource _setData:]): replaces the data of the data source (-[WebDataSource initWithRequest:]): create subresources
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame loadHTMLPropertyList:]): new, loads a frame from an HTML plist (-[WebFrame _webDataRequestForData:MIMEType:textEncodingName:baseURL:]): new, factored out from loadData:MIMEType:textEncodingName:baseURL: (-[WebFrame _loadRequest:subresources:]): new, factored out from loadRequest:, handles subresources (-[WebFrame loadRequest:]): now just calls _loadRequest:subresources:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _dataSource]): new internal convenience (+[WebHTMLView _selectionPasteboardTypes]): renamed from _pasteboardTypes to be more precise (-[WebHTMLView _selectedHTMLPropertyList:]): new, constructs an HTML plist from the selection (-[WebHTMLView _writeSelectionToPasteboard:]): calls _selectedHTMLPropertyList to support WebHTMLPboardType (-[WebHTMLView _pasteHTMLFromPasteboard:]): added support for pasting WebHTMLPboardType (+[WebHTMLView initialize]): call renamed _selectionPasteboardTypes (-[WebHTMLView initWithFrame:]): allow WebHTMLPboardType to be dragged in (-[WebHTMLView validRequestorForSendType:returnType:]): call renamed _selectionPasteboardTypes
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient addData:]): override since the main resource does it's own buffering (-[WebMainResourceClient saveResource]): override to do nothing since the main resource is not saved as a subresource (-[WebMainResourceClient saveResourceWithCachedResponse:]): override, calls _setData on the data source to (-[WebMainResourceClient connection:didReceiveData:lengthReceived:]):
  • WebView.subproj/WebResource.h: Added.
  • WebView.subproj/WebResource.m: Added. New class the represents the data, URL, MIME type and textEncodingName of a resource. (-[WebResourcePrivate dealloc]): (-[WebResource initWithData:URL:MIMEType:textEncodingName:]): (-[WebResource dealloc]): (-[WebResource data]): (-[WebResource URL]): (-[WebResource MIMEType]): (-[WebResource textEncodingName]): (-[WebResource description]): (+[WebResource _resourcesFromPropertyLists:]): (+[WebResource _propertyListsFromResources:]): (-[WebResource _initWithPropertyList:]): (-[WebResource _propertyListRepresentation]): (-[WebResource _initWithCachedResponse:originalURL:]): (-[WebResource _cachedResponseRepresentation]):
  • WebView.subproj/WebResourcePrivate.h: Added.
  • WebView.subproj/WebView.m:
2:53 PM Changeset in webkit [6113]
  • 9 copies
    2 deletes in tags/WebKit-85~8

This commit was manufactured by cvs2svn to create tag 'WebKit-85~8'.

2:53 PM Changeset in webkit [6112] by vicki
  • 4 edits in branches/Safari-1-0-branch/WebKit
  • roll this change onto the Safari-1-0-branch

2003-08-12 Ed Voas <​voas@apple.com>

Reviewed by Richard.

Make sure to override the standard behavior for ordering windows to do nothing for Carbon stuff.

  • Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
11:36 AM Changeset in webkit [6111] by darin
  • 4 edits in trunk/WebCore

Tests:

Reviewed by Ken.

  • qt/qstring-test.cpp: (main): Added an endsWith test.
  • qt/qstring-test.chk: Added the expected result.

WebCore:

Reviewed by Ken.

  • kwq/KWQString.mm: (QString::endsWith): Fixed broken end of string test, to get rid of false positives.
  • WebCore-tests.exp: Added endsWith so it can be tested.
  • WebCore-combined.exp: Regenerated.

Feb 23, 2004:

3:33 PM Changeset in webkit [6110] by hyatt
  • 5 edits in trunk/WebCore

Fix for 3549772, hangs on border collapsing.

Reviewed by darin

  • khtml/rendering/render_object.cpp: (RenderObject::collectBorders):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_table.cpp: (RenderTable::paint): (compareBorders): (RenderTableCell::paint): (addBorderStyle): (RenderTableCell::collectBorders):
  • khtml/rendering/render_table.h:
1:39 PM Changeset in webkit [6109] by hyatt
  • 2 adds in trunk/LayoutTests/fast/block/margin-collapse

Adding test for 3560033 fix.

1:31 PM Changeset in webkit [6108] by hyatt
  • 4 edits in trunk/LayoutTests/fast

Updating layout tests to reflect br fixes.

1:26 PM Changeset in webkit [6107] by hyatt
  • 27 edits in trunk/WebCore

Fix for 3558717, make sure that form elements that are removed from a document also remove themselves
from the form.

Reviewed by darin.

  • khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::removedFromDocument):
  • khtml/html/html_formimpl.h:
  • khtml/xml/dom_nodeimpl.cpp:
  • khtml/xml/dom_nodeimpl.h:

Implement smarter line layout for faster typing and repainting when individual lines change.

Reviewed by kocienda.

  • khtml/khtmlview.cpp: (KHTMLViewPrivate::KHTMLViewPrivate): (KHTMLViewPrivate::~KHTMLViewPrivate): (KHTMLViewPrivate::reset): (KHTMLView::addRepaintInfo): (KHTMLView::layout):
  • khtml/khtmlview.h:
  • khtml/rendering/bidi.cpp: (khtml::Bidinext): (khtml::appendRun): (khtml::embed): (khtml::RenderBlock::constructLine): (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::computeVerticalPositionsForLine): (khtml::RenderBlock::bidiReorderLine): (khtml::buildCompactRuns): (khtml::RenderBlock::layoutInlineChildren): (khtml::RenderBlock::determineStartPosition): (khtml::RenderBlock::determineEndPosition): (khtml::RenderBlock::matchedEndLine): (khtml::RenderBlock::findNextLineBreak):
  • khtml/rendering/render_block.cpp: (khtml:::RenderFlow): (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::positionNewFloats): (khtml::RenderBlock::lowestPosition): (khtml::RenderBlock::rightmostPosition): (khtml::RenderBlock::leftmostPosition):
  • khtml/rendering/render_block.h: (khtml::RenderBlock::firstRootBox): (khtml::RenderBlock::lastRootBox): (khtml::RenderBlock::setLinesAppended): (khtml::RenderBlock::linesAppended):
  • khtml/rendering/render_box.cpp: (RenderBox::dirtyLineBoxes): (RenderBox::deleteLineBoxWrapper): (RenderBox::setInlineBoxWrapper):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_br.cpp: (RenderBR::createInlineBox): (RenderBR::position):
  • khtml/rendering/render_br.h:
  • khtml/rendering/render_container.cpp: (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::placeChild):
  • khtml/rendering/render_flow.cpp: (RenderFlow::extractLineBox): (RenderFlow::attachLineBox): (RenderFlow::removeLineBox): (RenderFlow::dirtyLinesFromChangedChild): (RenderFlow::dirtyLineBoxes): (RenderFlow::createInlineBox):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_line.cpp: (InlineBox::dirtyLineBoxes): (InlineBox::deleteLine): (InlineBox::extractLine): (InlineBox::attachLine): (InlineBox::adjustVerticalPosition): (InlineBox::root): (InlineBox::nextOnLineExists): (InlineBox::prevOnLineExists): (InlineFlowBox::removeChild): (InlineFlowBox::deleteLine): (InlineFlowBox::extractLine): (InlineFlowBox::attachLine): (InlineFlowBox::adjustVerticalPosition): (InlineFlowBox::verticallyAlignBoxes): (InlineFlowBox::adjustMaxAscentAndDescent): (RootInlineBox::adjustVerticalPosition): (RootInlineBox::childRemoved):
  • khtml/rendering/render_line.h: (khtml::InlineBox::m_extracted): (khtml::InlineBox::setExtracted): (khtml::InlineBox::object): (khtml::InlineBox::parent): (khtml::InlineBox::isDirty): (khtml::InlineBox::markDirty): (khtml::InlineFlowBox::prevFlowBox): (khtml::InlineFlowBox::nextFlowBox): (khtml::RootInlineBox::RootInlineBox): (khtml::RootInlineBox::nextRootBox): (khtml::RootInlineBox::prevRootBox): (khtml::RootInlineBox::setLineBreakInfo): (khtml::RootInlineBox::setLineBreakPos): (khtml::RootInlineBox::setBlockHeight): (khtml::RootInlineBox::setEndsWithBreak): (khtml::RootInlineBox::blockHeight): (khtml::RootInlineBox::endsWithBreak): (khtml::RootInlineBox::lineBreakObj): (khtml::RootInlineBox::lineBreakPos):
  • khtml/rendering/render_object.cpp: (RenderObject::repaintAfterLayoutIfNeeded): (RenderObject::repaintObjectsBeforeLayout): (RenderObject::dirtyLinesFromChangedChild): (RenderObject::createInlineBox): (RenderObject::dirtyLineBoxes): (RenderObject::setInlineBoxWrapper): (RenderObject::deleteLineBoxWrapper):
  • khtml/rendering/render_object.h: (khtml::RenderObject::RepaintInfo::m_repaintRect):
  • khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows):
  • khtml/rendering/render_text.cpp: (InlineTextBox::deleteLine): (InlineTextBox::extractLine): (InlineTextBox::attachLine): (RenderText::RenderText): (RenderText::detach): (RenderText::extractTextBox): (RenderText::attachTextBox): (RenderText::removeTextBox): (RenderText::setTextWithOffset): (RenderText::setText): (RenderText::dirtyLineBoxes): (RenderText::createInlineBox):
  • khtml/rendering/render_text.h: (khtml::InlineTextBox::start): (khtml::InlineTextBox::end): (khtml::InlineTextBox::offsetRun):
  • khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::setData): (CharacterDataImpl::appendData): (CharacterDataImpl::insertData): (CharacterDataImpl::deleteData): (CharacterDataImpl::replaceData): (TextImpl::splitText):
  • kwq/KWQRenderTreeDebug.cpp: (write):

RenderBlock contains two other fixes. The first is a fix to rightmost/lowestPosition to properly add in
margins to floats.

Reviewed by mjs

The second fix is to repair a bug in block-level replaced elements with margins. If the floats they moved to
dodge can fit in their margins, then they don't technically have to move at all.

Reviewed by john

Note: See TracTimeline for information about the timeline view.