Context Navigation

← Previous Period
Next Period →

Timeline

Feb 27, 2004:

4:23 PM Changeset in webkit [6134]

4 copies
3 deletes in tags/JavaScriptCore-125~2

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-125~2'.

4:23 PM Changeset in webkit [6133] by vicki

2 edits in branches/Safari-1-2-branch/JavaScriptCore

update version number for Feldspar changes (JavaScriptCore 125.2)

4:09 PM Changeset in webkit [6132] by vicki

2 edits in branches/Safari-1-2-branch/JavaScriptCore

roll this change onto the Safari-1-2-branch, for SUPanFeldspar

2004-02-02 Darin Adler <Darin Adler>

Reviewed by Maciej.

fixed <rdar://problem/3546613>: array of negative size leads to crash (test page at oscar.the-rileys.net)

kjs/array_object.cpp: (ArrayInstanceImp::ArrayInstanceImp): If the length is greater than 10,000, don't allocate an array until we start putting values in. This prevents new Array(2147483647) from causing trouble. (ArrayObjectImp::construct): Check number as described in specification, and raise a range error if the number is out of range. This prevents new Array(-1) from causing trouble.

3:01 PM Changeset in webkit [6131]

5 copies
2 deletes in tags/JavaScriptCore-85~6

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-85~6'.

3:01 PM Changeset in webkit [6130] by vicki

2 edits in branches/Safari-1-0-branch/JavaScriptCore

bump the JavaScriptCore version number from 85.5 to 85.6

2:55 PM Changeset in webkit [6129] by mjs

2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3514733>: nil-deref in createHTMLEventListener at skiset.com
<rdar://problem/3510676>: nil-deref of view in DocumentImpl::createHTMLEventListener at kirotv.com

khtml/xml/dom_docimpl.cpp: (DocumentImpl::createHTMLEventListener): Don't create the listener if there is no part. Also, get the part when going through the view. This prevents problems when handlers are set or removed from the onUnload handler.

2:50 PM Changeset in webkit [6128] by sullivan

3 edits in trunk/WebKit

WebKit:

WebKit changes to allow performance improvements to bookmarks

Reviewed by Darin.

History.subproj/WebHistoryItemPrivate.h: added notificationsSuppressed/setNotificationsSuppressed, and setURLString
History.subproj/WebHistoryItem.m: (-[WebHistoryItem setNotificationsSuppressed:]): setter for new flag. When this flag is set, making changes to the WebHistoryItem will not cause WebHistoryChanged notifications to be sent. This is a big speedup for reading bookmarks from disk, since currently each WebBookmarkLeaf object keeps around a WebHistoryItem object that isn't really part of history and thus doesn't need to send notifications about history changing. (-[WebHistoryItem notificationsSuppressed]): getter for new flag (-[WebHistoryItem setURLString:]): new method, extracted from guts of setURL:; this allows callers (though currently only callers at Apple) that have a URL string in hand to set it directly on the WebHistoryItem rather than converting to a URL and back, both relatively slow operations. Also, doesn't sent a notification if notifications are suppressed. (-[WebHistoryItem setURL:]): now calls extracted method (-[WebHistoryItem setAlternateTitle:]): doesn't send notification if notifications are suppressed (-[WebHistoryItem setOriginalURLString:]): ditto (-[WebHistoryItem setTitle:]): ditto (-[WebHistoryItem _setLastVisitedTimeInterval:]): ditto

WebBrowser:

A number of performance improvements to importing bookmarks. Some but not all of them also apply to reading our native bookmarks from disk. When I started this, importing bookmarks from Netscape's HTML format was actually slower than importing bookmarks from our property list format, hard though that might be to imagine. Now importing the HTML format takes about half the time it used to, and now it's about 40% faster than importing the property list format, at least with my 33,000 bookmark sample file (and importing our property list format also sped up).

Reviewed by Darin.

BookmarksController.m: (-[BookmarksController mergeBuiltInBookmarksIfNecessary]): added count to timing log message (-[BookmarksController exportBookmarks:]): added timing log message (-[BookmarksController importFavoritesFrom:intoBookmarksFolder:settingPrefKey:]): added count to timing log message, and commented-out calls to start & stop sampling for the next time someone works on this. Also, in the case where we're importing from a user-chosen file instead of automatically, bypass the merging code because the merging code is unnecessarily complicated for the "just shlurp this pile o' bookmarks into a new folder" case.

BookmarksViewController.m: (-[BookmarksViewController changeAddressForBookmark:to:]): Use bestURLStringForUserTypedString here (when user manually edits a URL in the outline view) so that we don't have to use it in the general case of setting a bookmark's URL string, since it's slow. When programmatically setting a bookmark's URL string we can often just use an existing string as-is.

FormCompletionController.m: (+[FormCompletionController _saveCompletionDB:]): Fix the way an #ifdef was declared so it compiles in a deployment build that has LOG_DISABLED set to 0.

WebBookmarkGroupPrivate.h:
WebBookmarkGroup.m: (-[WebBookmarkGroup _bookmarkChild:wasAddedToParent:]): added this private-ish helper method to avoid creating an array in the case where we aren't even going to use it because notifications are suppressed (-[WebBookmarkGroup _bookmarkChild:wasRemovedFromParent:]): ditto

WebBookmarkImporter.m: (-[WebBookmarkImporter unescapeHTML:]): bail out early if there's no ampersand at all in the string (the normal case), to avoid creating a mutable string

WebBookmarkLeaf.m: (-[WebBookmarkLeaf init]): suppress notifications on our private WebHistoryItem (-[WebBookmarkLeaf setURLString:]): call the new setURLString: method on our private WebHistoryItem instead of converting to a URL and then calling setURL: (which then converts back to a string)

WebBookmarkList.m: (-[WebBookmarkList removeChild:]): call new -[WebBookmarkGroup _bookmarkChild:wasRemovedFromParent:] so we don't have to create an NSArray here (-[WebBookmarkList insertChild:atIndex:]): call new -[WebBookmarkGroup _bookmarkChild:wasAddedToParent:] so we don't have to create an NSArray here

2:48 PM Changeset in webkit [6127] by vicki

2 edits in branches/Safari-1-0-branch/JavaScriptCore

roll this change onto the Safari-1-0-branch, for Safari 1.0.3

2004-02-02 Darin Adler <Darin Adler>

Reviewed by Maciej.

fixed <rdar://problem/3546613>: array of negative size leads to crash (test page at oscar.the-rileys.net)

kjs/array_object.cpp: (ArrayInstanceImp::ArrayInstanceImp): If the length is greater than 10,000, don't allocate an array until we start putting values in. This prevents new Array(2147483647) from causing trouble. (ArrayObjectImp::construct): Check number as described in specification, and raise a range error if the number is out of range. This prevents new Array(-1) from causing trouble.

1:25 AM Changeset in webkit [6126] by mjs

2 edits in trunk/WebCore

Reviewed by Dave.

fixed <rdar://problem/3571356>: REGRESSION: Crash in isPointInsideSelection clicking on link in Apple web directory frame

khtml/khtml_part.cpp: (KHTMLPart::isPointInsideSelection): Don't crash if innerNode is NULL, as this can happen mousing over a frame that's in the process of loading and currently empty. Since such a frame obviously can't be inside the selection, this seems like a good enough fix.

Feb 26, 2004:

8:38 PM Changeset in webkit [6125] by cblu

11 edits in trunk/WebKit

Tests:

Made Blot support the 'nmsg' event that Safari sends for the "Mail Page" and "Mail Page Address" feature.

Reviewed by NOBODY (OOPS!).

Blot/BlotApp.m: (-[BlotApp awakeFromNib]): (-[BlotApp handleURLEvent:withReplyEvent:]): (-[BlotApp handleNewMessageEvent:withReplyEvent:]):
Blot/BlotDocument.h:
Blot/BlotDocument.m: (-[BlotDocument setSubject:]): (-[BlotDocument webView:didFinishLoadForFrame:]): (-[BlotDocument loadPropertyList:]):
Blot/English.lproj/BlotDocument.nib:
Blot/Info.plist:

WebKit:

WebKit side of:
<rdar://problem/3056566>: mail a link to this page
<rdar://problem/2961206>: implement ability to e-mail entire page

Reviewed by john.

English.lproj/StringsNotToBeLocalized.txt:
Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]): tweaks (-[WebIconDatabase _loadIconDictionaries]): fixed an assertion failure I found in Blot. Keep the original list of icon URLs as a separate list when doing the initial clean-up so we don't over release any icons. (-[WebIconDatabase _updateFileDatabase]): tweaks (-[WebIconDatabase _setIcon:forIconURL:]): tweaks (-[WebIconDatabase _releaseIconForIconURLString:]): tweaks (-[WebIconDatabase _retainOriginalIconsOnDisk]): use the original list of icons on disk instead of the current list (-[WebIconDatabase _releaseOriginalIconsOnDisk]): use the original list of icons on disk instead of the current list
Misc.subproj/WebIconDatabasePrivate.h:
WebKit.exp:
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebDataSource.m: (-[WebDataSource _propertyListWithData:subresourceURLStrings:]): new, code moved from [WebHTMLView _selectedPropertyList:], creates property list rep of data and subresources (-[WebDataSource propertyList]): does the above with all the data source data, this is what "Mail Page" uses
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebFrame.m: (-[WebFrame loadPropertyList:]): renamed from loadHTMLPropertyList because the property list may contain non-HTML data
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _selectedPropertyList:]): renamed, code moved to [WebDataSource _propertyListWithData:subresourceURLStrings:] (-[WebHTMLView _writeSelectionToPasteboard:]): call renamed _selectedPropertyList

WebBrowser:

Fixed:
<rdar://problem/3056566>: mail a link to this page
<rdar://problem/2961206>: implement ability to e-mail entire page

The above work with Blot if you have that installed and will work with Mail once Mail supports it.

Reviewed by john.

BrowserDocument.m: (-[BrowserDocument validateUserInterfaceItem:]): handle mailPage and mailPageAddress (-[BrowserDocument _mailPropertyList:]): new, takes a WebKit property list and sends it to your Mail app if it supports it (-[BrowserDocument mailPage:]): calls _mailPropertyList with [WebDataSource propertyList] (-[BrowserDocument mailPageAddress:]): calls _mailPropertyList with boiler plate HTML
BrowserNSWorkspaceExtras.h:
BrowserNSWorkspaceExtras.m: (-[NSWorkspace launchApplicationAtPath:processSerialNumber:makeFrontmost:alreadyOpen:event:]): rearranged the arguments a little for aesthetic reasons
English.lproj/Localizable.strings:
English.lproj/MainMenu.nib: added "Mail Page" and "Mail Page Address" to the File menu
English.lproj/StringsNotToBeLocalized.txt:
Preferences.subproj/AdvancedPreferences.m: (-[AdvancedPreferences openProxyPreferences:]): call renamed launchApplicationAtPath:::::
WebBrowser.pbproj/project.pbxproj:

6:23 PM Changeset in webkit [6124]

5 copies
2 deletes in tags/WebCore-125~2

This commit was manufactured by cvs2svn to create tag
'WebCore-125~2'.

6:23 PM Changeset in webkit [6123]

5 copies
3 deletes in tags/WebCore-125~1

This commit was manufactured by cvs2svn to create tag
'WebCore-125~1'.

6:23 PM Changeset in webkit [6122] by mjs

2 edits in branches/Safari-1-2-branch/WebCore

WebCore-125.1

5:37 PM Changeset in webkit [6121] by hyatt

3 edits in trunk/WebCore

Fix for 3528839, wide table cut off because of shorts being used instead of ints.

Reviewed by darin

khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows): (RenderTableCell::setWidth):
khtml/rendering/table_layout.cpp: (FixedTableLayout::calcWidthArray): (FixedTableLayout::calcMinMaxWidth): (AutoTableLayout::calcMinMaxWidth):

4:44 PM Changeset in webkit [6120] by cblu

8 edits in trunk/WebCore

Fixed a few problems I found with reconstructed source while on my way to implementing "Mail Page".

Reviewed by hyatt.

khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::isSubresourceURLAttribute): only true for stylesheet and icon
khtml/html/html_imageimpl.cpp: (HTMLAreaElementImpl::isURLAttribute): implement isURLAttribute not isSubresourceURLAttribute
khtml/html/html_imageimpl.h:
khtml/rendering/render_box.cpp: (RenderBox::dirtyLineBoxes): crasher fix that I found using libgmalloc
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::recursive_toHTMLWithOptions): don't escape SCRIPT and TEXTAREA text, write close tags for tags that need them instead of relying on the children check
kwq/WebCoreBridge.mm: (-[WebCoreBridge HTMLString:]): call recursive_toHTMLWithOptions on the first child of the document so <#document /> isn't part of the source

3:10 PM Changeset in webkit [6119] by hyatt

27 edits in trunk/WebCore

Convert render object widths from short to int. There was a bug on this, but I can't find it in Radar.

Reviewed by john

khtml/rendering/render_applet.cpp: (RenderApplet::intrinsicWidth): (RenderEmptyApplet::intrinsicWidth):
khtml/rendering/render_applet.h:
khtml/rendering/render_block.cpp: (khtml::RenderBlock::calcMinMaxWidth): (khtml::RenderBlock::calcInlineMinMaxWidth):
khtml/rendering/render_block.h:
khtml/rendering/render_box.cpp: (RenderBox::contentWidth): (RenderBox::width): (RenderBox::containingBlockWidth): (RenderBox::calcReplacedWidth): (RenderBox::setStaticX):
khtml/rendering/render_box.h: (khtml::RenderBox::minWidth): (khtml::RenderBox::maxWidth):
khtml/rendering/render_br.h: (khtml::RenderBR::minWidth): (khtml::RenderBR::maxWidth):
khtml/rendering/render_canvas.cpp: (RenderCanvas::layout):
khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::calcMinMaxWidth):
khtml/rendering/render_frames.cpp: (RenderPart::intrinsicWidth): (RenderPartObject::layout):
khtml/rendering/render_frames.h:
khtml/rendering/render_image.cpp: (RenderImage::layout): (RenderImage::calcReplacedWidth):
khtml/rendering/render_image.h:
khtml/rendering/render_inline.cpp: (RenderInline::width):
khtml/rendering/render_inline.h:
khtml/rendering/render_layer.cpp: (RenderLayer::scrollWidth):
khtml/rendering/render_layer.h: (khtml::RenderLayer::width): (khtml::RenderLayer::setWidth): (khtml::RenderLayer::scrollXOffset):
khtml/rendering/render_line.h: (khtml::InlineBox::setWidth): (khtml::InlineBox::width): (khtml::InlineBox::setXPos): (khtml::InlineBox::xPos):
khtml/rendering/render_object.cpp: (RenderObject::containingBlockWidth):
khtml/rendering/render_object.h: (khtml::RenderObject::setStaticX): (khtml::RenderObject::contentWidth): (khtml::RenderObject::intrinsicWidth): (khtml::RenderObject::width): (khtml::RenderObject::offsetWidth): (khtml::RenderObject::minWidth): (khtml::RenderObject::maxWidth):
khtml/rendering/render_replaced.h: (khtml::RenderReplaced::intrinsicWidth):
khtml/rendering/render_table.cpp: (RenderTable::calcWidth):
khtml/rendering/render_table.h:
khtml/rendering/render_text.cpp: (RenderText::trimmedMinMaxWidth): (RenderText::width):
khtml/rendering/render_text.h: (khtml::RenderText::minWidth): (khtml::RenderText::maxWidth):
khtml/rendering/table_layout.cpp:

3:00 PM Changeset in webkit [6118] by trey

6 edits in trunk/WebCore

3566668 - REGRESSION (125-128): autofill of popup lists is broken
3571271 - autofill parsing of field names should treat _ as a word separator

Reviewed by Chris, Darin

kwq/KWQComboBox.h:
kwq/KWQComboBox.mm: (QComboBox::populate): New virtual method to force any lazy field population to happen.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::matchLabelsAgainstElement): Change _ to ' ', to make it a word separator.
kwq/KWQWidget.h: (QWidget::populate): Implement populate to fill out the menu's data.
kwq/WebCoreBridge.mm: (viewForElement): Make sure widget is populated before handing it out.

11:16 AM Changeset in webkit [6117] by kocienda

22 edits
10 adds
9 deletes in trunk

WebCore:

Reviewed by Chris

WebCore.pbproj/project.pbxproj:
khtml/xml/dom2_rangeimpl.h: Now includes createInstance glue function as do the other khtml DOM objects that we reflect into ObjC.
kwq/DOM-compat.h: Added. Compatibility declarations for DOM SPI. Note that this file is copied into WebKit by the build system as needed.
kwq/DOM.h: Added. New home for DOM SPI. Note that this file is copied into WebKit by the build system as needed.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::recordFormValue): Updated usage to new DOM SPI.
kwq/WebCoreBridge.h: Updated usage to new DOM SPI.
kwq/WebCoreBridge.mm: Updated usage to new DOM SPI. Needed to add DOM range impl include since includes jiggered around and this needed header was no longer included indirectly. (-[WebCoreBridge elementForView:]): Ditto. (inputElementFromDOMElement): Ditto. (formElementFromDOMElement): Ditto. (-[WebCoreBridge elementWithName:inForm:]): Ditto. (-[WebCoreBridge elementDoesAutoComplete:]): Ditto. (-[WebCoreBridge elementIsPassword:]): Ditto. (-[WebCoreBridge currentForm]): Ditto. (-[WebCoreBridge controlsInForm:]): Ditto. (-[WebCoreBridge searchForLabels:beforeElement:]): Ditto. (-[WebCoreBridge matchLabels:againstElement:]): Ditto. (-[WebCoreBridge elementAtPoint:]): Ditto. (-[WebCoreBridge DOMDocument]): Ditto. (-[WebCoreBridge setSelectionFrom:startOffset:to:endOffset:]): Ditto. (-[WebCoreBridge attributedStringFrom:startOffset:to:endOffset:]): Ditto. (-[WebCoreBridge selectionStart]): Ditto. (-[WebCoreBridge selectionEnd]): Ditto.
kwq/WebCoreDOM.h: New home for all private declarations needed for reflecting DOM into ObjC.
kwq/WebCoreDOM.mm: Added. New home for all implementations needed for reflecting DOM into ObjC.
kwq/WebCoreDOMDocument.mm: Removed. All ObjC DOM implementation now in WebCoreDOM.mm.
kwq/WebCoreDOMNode.mm: Removed. All ObjC DOM implementation now in WebCoreDOM.mm.
kwq/WebCoreDOMPrivate.h: Removed.
kwq/WebDOMDocument.h: Removed.
kwq/WebDOMElement.h: Removed.
kwq/WebDOMNode.h: Removed.

WebKit:

Reviewed by Chris

Updated usage of DOM SPI to use new names and conventions.

Unless indicated otherwise, the changes were to update protocol names for, which
changed from using a "WebDOM" prefix to a "DOM" prefix, and changing now need
only include the DOM.h header from WebKit to get everything.

DOM.subproj/DOM-compat.h: Added. This header contains some compatibility declarations to work with older clients of our DOM SPI. Though this file is checked into WebKit, it really lives and should be updated in WebCore. It is copied into WebKit by the build system as needed.
DOM.subproj/DOM.h: Added. This file includes the new "guts" of the DOM SPI. As above, this file is checked into WebKit, it really lives and should be updated in WebCore. It is copied into WebKit by the build system as needed.
DOM.subproj/WebDOMDocument.h: Removed declarations. Now just includes DOM.h and DOM-compat.h
DOM.subproj/WebDOMDocument.m: Removed.
DOM.subproj/WebDOMElement.h: Removed declarations. Now just includes DOM.h and DOM-compat.h
DOM.subproj/WebDOMElement.m: Removed.
DOM.subproj/WebDOMNode.h: Removed declarations. Now just includes DOM.h and DOM-compat.h
DOM.subproj/WebDOMNode.m: Removed.
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:reload:onLoadEvent:target:triggeringEvent:form:formValues:]) (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:])
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebDefaultContextMenuDelegate.m:
WebView.subproj/WebFormDelegate.h:
WebView.subproj/WebFormDelegate.m: (-[WebFormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:])
WebView.subproj/WebFrame.h: Unrelated change. Removed -undoManager accessor from public header. Moved to private header.
WebView.subproj/WebFrame.m: (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]) (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]) (-[WebFrame undoManager]): Moved -undoManager accessor to private category implementation. (-[WebFormState initWithForm:values:sourceFrame:]) (-[WebFormState form]) (-[WebFrame childFrames])
WebView.subproj/WebFramePrivate.h: Moved in -undoManager accessor.
WebView.subproj/WebHTMLRepresentation.h:
WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation DOMDocument]) (-[WebHTMLRepresentation setSelectionFrom:startOffset:to:endOffset:]) (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]) (-[WebHTMLRepresentation elementWithName:inForm:]) (-[WebHTMLRepresentation elementForView:]) (-[WebHTMLRepresentation elementDoesAutoComplete:]) (-[WebHTMLRepresentation elementIsPassword:]) (-[WebHTMLRepresentation formForElement:]) (-[WebHTMLRepresentation controlsInForm:]) (-[WebHTMLRepresentation searchForLabels:beforeElement:]) (-[WebHTMLRepresentation matchLabels:againstElement:])
WebView.subproj/WebHTMLView.m:
copy-webcore-files-to-webkit: Added. Copies DOM.h and DOM-compat.h from WebCore when they have been updated there.

WebBrowser:

Reviewed by Chris

Updated usage of DOM SPI to use new names and conventions.

In each case, protocol names for DOM objects were changed from using a
"WebDOM" prefix to a "DOM" prefix, and clients now need only include the
DOM.h header from WebKit to get everything.

BrowserWebController.m: (-[FormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:])
Debug/SnippetController.m: (lastNode) (-[SnippetController loadComplete])
FormCompletionController.h:
FormCompletionController.m: (+[FormCompletionController loginInfoForForm:inFrame:]) (+[FormCompletionController _frame:sourceFrame:willSubmitLoginForm:withValues:formInfo:submissionListener:]) (+[FormCompletionController _frame:sourceFrame:willSubmitRegularForm:withValues:]) (+[FormCompletionController frame:sourceFrame:willSubmitForm:withValues:submissionListener:]) (+[FormCompletionController currentFormInFrame:]) (+[FormCompletionController currentFrameAndForm:inWebView:]) (+[FormCompletionController autoFillInWebView:]) (+[FormCompletionController autoFillPasswordInFrame:]) (-[FormCompletionController initWithSourceField:frame:]) (-[FormCompletionController maxStringLength]) (+[AutoFillController autoFillerForFrame:form:create:]) (+[AutoFillController abMatchInFrame:form:fieldName:]) (+[AutoFillController recordABMatch:inFrame:form:fieldName:]) (+[AutoFillController clearAutoFilledView:inFrame:form:]) (-[AutoFillController _fieldNameForAutoFillOfView:rep:]) (-[FormToABBinder abPointerForFieldName:view:rep:foundByPageScan:])

Feb 25, 2004:

8:51 AM Changeset in webkit [6116] by sullivan

8 edits in trunk

WebCore:

WebCore part of fix for <rdar://problem/3546370>: add a way to tab to menus,
checkmarks, and buttons without turning on Full Keyboard Acceess

Reviewed by Ken.

kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::tabsToAllControls): now checks for option-tab like tabsToLinks (KWQKHTMLPart::partForWidget): new method, extracted from bridgeForWidget (KWQKHTMLPart::bridgeForWidget): now calls extracted method

kwq/KWQButton.mm: (-[KWQButton canBecomeKeyView]): overridden to handle our rules about full keyboard access, different than NSView's rules
kwq/KWQComboBox.mm: (-[KWQPopUpButton canBecomeKeyView]): ditto
kwq/KWQListBox.mm: (-[KWQTableView canBecomeKeyView]): ditto

WebKit:

WebKit part of fix for <rdar://problem/3546370>: add a way to tab to menus,
checkmarks, and buttons without turning on Full Keyboard Acceess

Reviewed by Ken.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]): turn on WebCoreKeyboardAccessFull bit whenever we turn on WebCoreKeyboardAccessTabsToLinks bit

WebBrowser:

WebBrowser part of fix for <rdar://problem/3546370>: add a way to tab to menus, checkmarks, and buttons without turning on Full Keyboard Acceess
fixed <rdar://problem/3566996>: "Highlight each item" choice in Preferences should use a checkbox and have different wording

Reviewed by Ken.

Preferences.subproj/AdvancedPreferences.h:
Preferences.subproj/AdvancedPreferences.m: (systemIsInFullKeyboardAccessMode): new function, reads the state of the Full Keyboard Access setting (-[AdvancedPreferences updateTabToAllViews]): set checkbox instead of matrix; new wording for fine print; renamed method (-[AdvancedPreferences keyboardUIModeDidChange:]): notification callback; call updateTabToAllViews (-[AdvancedPreferences toggleTabToAll:]): new method, replaces takeTabToLinksSettingFrom: (-[AdvancedPreferences initializeFromDefaults]): call renamed method (-[AdvancedPreferences moduleWillBeRemoved]): stop observing notification for Full Keyboard Access mode change (-[AdvancedPreferences moduleWasInstalled]): start observing notification for Full Keyboard Access mode change

Preferences.subproj/English.lproj/AdvancedPreferences.nib: replace radio buttons with checkbox; rejigger positions

English.lproj/Localizable.strings:
English.lproj/StringsNotToBeLocalized.txt: Updated for these changes

Feb 24, 2004:

7:21 PM Changeset in webkit [6115] by cblu

1 edit
3 adds in trunk/WebKit

I forgot to add these files in my last check-in.

WebView.subproj/WebResource.h: Added.
WebView.subproj/WebResource.m: Added. (-[WebResourcePrivate dealloc]): (-[WebResource initWithData:URL:MIMEType:textEncodingName:]): (-[WebResource dealloc]): (-[WebResource data]): (-[WebResource URL]): (-[WebResource MIMEType]): (-[WebResource textEncodingName]): (+[WebResource _resourcesFromPropertyLists:]): (+[WebResource _propertyListsFromResources:]): (-[WebResource _initWithPropertyList:]): (-[WebResource _initWithCachedResponse:originalURL:]): (-[WebResource _propertyListRepresentation]): (-[WebResource _cachedResponseRepresentation]):
WebView.subproj/WebResourcePrivate.h: Added.

5:30 PM Changeset in webkit [6114] by cblu

16 edits in trunk/WebKit

Tests:

Added support for WebHTMLPboardType.

Reviewed by rjw.

PasteboardViewer/PasteboardViewer.xcode/project.pbxproj:
PasteboardViewer/WindowController.m: (-[WindowController pasteboardTypes]): (-[WindowController reflectSelection]):

WebKit:

Fixed: <rdar://problem/3565476>: design/implement new pasteboard type for HTML that includes subresources

Reviewed by rjw.

Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate initWithStream:view:]): don't manage buffer, WebBaseResourceHandleDelegate does this now (-[WebNetscapePluginConnectionDelegate releaseResources]): ditto (-[WebNetscapePluginConnectionDelegate connection:didReceiveData:lengthReceived:]): ditto (-[WebNetscapePluginConnectionDelegate connectionDidFinishLoading:]): ditto
WebKit.exp:
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebBaseResourceHandleDelegate.h:
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate releaseResources]): release resourceData and resource (-[WebBaseResourceHandleDelegate loadWithRequest:]): check the dataSource for a resource, load that if we have one (-[WebBaseResourceHandleDelegate addData:]): new, adds data to resourceData (-[WebBaseResourceHandleDelegate saveResource]): new, saves data as a resource on the dataSource (-[WebBaseResourceHandleDelegate saveResourceWithCachedResponse:]): new, replaces the resource on the dataSource to save memory (-[WebBaseResourceHandleDelegate resourceData]): new (-[WebBaseResourceHandleDelegate connection:didReceiveData:lengthReceived:]): call addData: (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): call saveResource (-[WebBaseResourceHandleDelegate connection:willCacheResponse:]): new, calls saveResourceWithCachedResponse:
WebView.subproj/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): release subresources (-[WebDataSource subresources]): new, returns the subresources of the data source (-[WebDataSource subresourceForURL:]): new, returns a resource for a URL (-[WebDataSource addSubresource:]): new (-[WebDataSource addSubresources:]): new (-[WebDataSource _receivedData:]): added an assert (-[WebDataSource _setData:]): replaces the data of the data source (-[WebDataSource initWithRequest:]): create subresources
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebFrame.m: (-[WebFrame loadHTMLPropertyList:]): new, loads a frame from an HTML plist (-[WebFrame _webDataRequestForData:MIMEType:textEncodingName:baseURL:]): new, factored out from loadData:MIMEType:textEncodingName:baseURL: (-[WebFrame _loadRequest:subresources:]): new, factored out from loadRequest:, handles subresources (-[WebFrame loadRequest:]): now just calls _loadRequest:subresources:
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _dataSource]): new internal convenience (+[WebHTMLView _selectionPasteboardTypes]): renamed from _pasteboardTypes to be more precise (-[WebHTMLView _selectedHTMLPropertyList:]): new, constructs an HTML plist from the selection (-[WebHTMLView _writeSelectionToPasteboard:]): calls _selectedHTMLPropertyList to support WebHTMLPboardType (-[WebHTMLView _pasteHTMLFromPasteboard:]): added support for pasting WebHTMLPboardType (+[WebHTMLView initialize]): call renamed _selectionPasteboardTypes (-[WebHTMLView initWithFrame:]): allow WebHTMLPboardType to be dragged in (-[WebHTMLView validRequestorForSendType:returnType:]): call renamed _selectionPasteboardTypes
WebView.subproj/WebHTMLViewPrivate.h:
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient addData:]): override since the main resource does it's own buffering (-[WebMainResourceClient saveResource]): override to do nothing since the main resource is not saved as a subresource (-[WebMainResourceClient saveResourceWithCachedResponse:]): override, calls _setData on the data source to (-[WebMainResourceClient connection:didReceiveData:lengthReceived:]):
WebView.subproj/WebResource.h: Added.
WebView.subproj/WebResource.m: Added. New class the represents the data, URL, MIME type and textEncodingName of a resource. (-[WebResourcePrivate dealloc]): (-[WebResource initWithData:URL:MIMEType:textEncodingName:]): (-[WebResource dealloc]): (-[WebResource data]): (-[WebResource URL]): (-[WebResource MIMEType]): (-[WebResource textEncodingName]): (-[WebResource description]): (+[WebResource _resourcesFromPropertyLists:]): (+[WebResource _propertyListsFromResources:]): (-[WebResource _initWithPropertyList:]): (-[WebResource _propertyListRepresentation]): (-[WebResource _initWithCachedResponse:originalURL:]): (-[WebResource _cachedResponseRepresentation]):
WebView.subproj/WebResourcePrivate.h: Added.
WebView.subproj/WebView.m:

2:53 PM Changeset in webkit [6113]