Context Navigation

WebCore.pbproj/project.pbxproj:
khtml/css/css_computedstyle.cpp: Added. (DOM::valueForLength): Helper to turn a khtml::Length into a computed value string. (DOM::stringForBorderStyle): Helper to turn an EBorderStyle into a computed value string. (DOM::stringForTextAlign): Helper to turn an ETextAlign into a computed value string. (DOM::CSSComputedStyleDeclarationImpl::CSSComputedStyleDeclarationImpl): New function. (DOM::CSSComputedStyleDeclarationImpl::~CSSComputedStyleDeclarationImpl): Ditto. (DOM::CSSComputedStyleDeclarationImpl::cssText): Ditto. (DOM::CSSComputedStyleDeclarationImpl::setCssText): Ditto. (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Ditto. (DOM::CSSComputedStyleDeclarationImpl::getPropertyValue): Ditto. (DOM::CSSComputedStyleDeclarationImpl::getPropertyPriority): Ditto. (DOM::CSSComputedStyleDeclarationImpl::removeProperty): Ditto. (DOM::CSSComputedStyleDeclarationImpl::setProperty): Ditto. (DOM::CSSComputedStyleDeclarationImpl::setLengthProperty): Ditto. (DOM::CSSComputedStyleDeclarationImpl::item): Ditto. (DOM::CSSComputedStyleDeclarationImpl::property): Ditto.
khtml/css/css_computedstyle.h: Added.
khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::cssText): Fixed some formatting of Rect. Added suppoprt for rgba colors.
khtml/css/css_valueimpl.h: (DOM::CSSStyleDeclarationImpl::node):
khtml/ecma/kjs_css.cpp: (KJS::getDOMCSSStyleDeclaration):
khtml/ecma/kjs_dom.cpp: (DOMDocument::getValueProperty): defaultView is a property, used to be a function, which was wrong. Fixed. (DOMDocumentProtoFunc::tryCall): Ditto.
khtml/ecma/kjs_dom.lut.h: (KJS::): Regenerated file.
khtml/misc/khtmllayout.h: (khtml::Length::length): Added an accessor to the value, to promote better coding style, rather than peeking and poking the value directly.
khtml/rendering/render_style.h: (khtml::RenderStyle::borderLeftWidth): BHIDDEN also should be treated like BNONE when it comes to returning a zero value. Now it is. (khtml::RenderStyle::borderRightWidth): Ditto. (khtml::RenderStyle::borderTopWidth): Ditto. (khtml::RenderStyle::borderBottomWidth): Ditto. (khtml::RenderStyle::outlineWidth): Ditto. (khtml::RenderStyle::outlineOffset): Ditto.
khtml/xml/dom2_viewsimpl.cpp: (AbstractViewImpl::getComputedStyle): Added an implementation for this formerly stubbed out function.

1:27 PM Changeset in webkit [6177] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3560132>: REGRESSION: Safari crashed in -[NSPasteboard setData:forType:] dragging a map out of Mapquest.com

Reviewed by john.

Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:URL:title:fileWrapper:HTMLString:]): declare the pboard types by calling _web_writeURL:::: before calling setData::

11:02 AM Changeset in webkit [6176] by sullivan

9 edits in trunk/WebKit

WebKit:

First cut at WebKit support for showing error pages for unreachable URLs.
This doesn't work quite right with the back/forward list yet, but is
good enough for demos.

Reviewed by Darin.

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate didReceiveResponse:]): use new _webDataRequextExternalURL to share code

WebView.subproj/WebDataProtocol.h: Three new methods (all internal to WebKit): -[NSURLRequest _webDataRequestUnreachableURL], -[NSURLRequest _webDataRequestExternalURL], -[NSURLRequest _webDataRequestSetUnreachableURL]
WebView.subproj/WebDataProtocol.m: new unreachableURL field of WebDataRequestParameters (-[WebDataRequestParameters copyWithZone:]): copy new field (-[WebDataRequestParameters dealloc]): release new field (-[NSURLRequest _webDataRequestUnreachableURL]): read new field (-[NSURLRequest _webDataRequestExternalURL]): new method, returns baseURL or "about:blank" for webdata protocol requests. This was done in multiple places previously. (-[NSURLRequest _webDataRequestExternalRequest]): now calls _webDataRequestExternalURL to share code (-[NSMutableURLRequest _webDataRequestSetUnreachableURL:]): write new field

WebView.subproj/WebDataSource.m: (-[WebDataSource unreachableURL]): new method, might become API; returns the unreachable URL, if any, for which this datasource holds placeholder content (-[WebDataSource _URLForHistory]): new method, returns the URL to be stored in History for this dataSource. This returns nil for run-of-the-mill WebDataProtocol URLs (replacing code elsewhere that checked for this case) but returns the unreachableURL for the case where this datasource holds placeholder content. (-[WebDataSource _setTitle:]): now calls _URLForHistory

WebView.subproj/WebDataSourcePrivate.h: added unreachableURL in the should-become-API section, and _URLForHistory elsewhere

WebView.subproj/WebFrame.m: (-[WebFrame loadPlaceholderHTMLString:baseURL:unreachableURL:]): new should-become-API method for displaying an error page for an unreachable URL (-[WebFrame loadPropertyList:]): updated to pass nil for unreachableURL (-[WebFrame _webDataRequestForData:MIMEType:textEncodingName:baseURL:unreachableURL:]): added unreachableURL parameter, which gets set on the data request (-[WebFrame _addBackForwardItemClippedAtTarget:]): use _URLForHistory instead of just checking for WebDataProtocol (-[WebFrame _createItem:]): use unreachableURL if there is one (-[WebFrame _transitionToCommitted:]): use _URLForHistory instead of just checking for WebDataProtocol (-[WebFrame _isLoadComplete]): check whether a new load has started in the delegate callback and if so, don't reset the loading state here (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): added unreachableURL parameter, which gets passed through (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): send nil unreachableURL parameter (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): new bottleneck method for loadHTMLString:baseURL: and loadPlaceholderHTMLString:baseURL:unreachableURL:; this is the guts of loadHTMLString:baseURL: with the new unreachableURL parameter passed through (-[WebFrame loadHTMLString:baseURL:]): now calls new bottleneck method

WebView.subproj/WebFramePrivate.h: added loadPlaceholderString:baseURL:unreachableURL: to should-be-API section; added unreachableURL parameter to _webDataRequestForData:MIMEType:textEncodingName:baseURL:

WebBrowser:

First cut at WebBrowser support for showing error pages for unreachable URLs.
This doesn't work quite right with the back/forward list yet, but is
good enough for demos. The old sheet-using code remains intact, and there's
a menu item in the Debug menu to try the new way (old way is still default
for now).

Reviewed by Darin.

PreferenceKeys.h: added DebugDisplayErrorsAsPagesPreferenceKey; also deleted a couple of unused old preference keys.

BrowserWebController.h: added showErrorPageForURL:withTitle:message:

BrowserWebController.m: (-[BrowserWebView webView:unableToImplementPolicyWithError:frame:]): use showErrorPageForURL:... if the preference is set that way (-[BrowserWebView errorPageHTMLWithTitle:message:]): new method, returns an HTML string for the error page. This will eventually be done reading resources from disk no doubt, but for now we just display a simple page that has the same text as the sheet. (-[BrowserWebView showErrorPageForURL:withTitle:message:]): new method, uses new loadPlaceholderHTMLString:baseURL:unreachableURL: to put up an error page in the webview (-[BrowserWebView expectedOrCurrentURL]): use unreachableURL if there is one

Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): add menu item "Show Page Load Errors Inline" (-[NSApplication validate_toggleDisplayLoadErrorsAsPages:]): new method, sets the checkmark on the new menu item appropriately (-[NSApplication toggleDisplayLoadErrorsAsPages:]): new method, toggles the state of the preference

LoadProgressMonitor.m: (-[LoadProgressMonitor _createProgressEntryWithRequest:dataSource:]): use unreachableURL if there is one (-[LoadProgressMonitor webView:resource:didReceiveResponse:fromDataSource:]): ditto

LocationChangeError.m: (-[LocationChangeHandler displayOrRememberLocationChangeError:forDataSource:]): use showErrorPage:... if the preference is set that way

LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]): use previously-fetched local variable "frame" rather than getting it from the dataSource again. This is not only trivially faster in the normal case, but also avoids a bug when the code earlier in this method triggers another page load (as in the showErrorPage:... case).

English.lproj/Localizable.strings: updated for these changes

10:20 AM Changeset in webkit [6175] by kocienda

2 edits in trunk/WebCore

Change by Darin. Reviewed by me.

kwq/DOM.mm: Fixed the following functions to deal with casting objects derived from NodeImpl back and forth to NodeImpl given that the derived classes use multiple inheritance. (-[DOMDocument _documentImpl]): (-[DOMCharacterData _characterDataImpl]): (-[DOMAttr _attrImpl]): (-[DOMElement _elementImpl]): (-[DOMText _textImpl]): (-[DOMDocumentType _documentTypeImpl]): (-[DOMNotation _notationImpl]): (-[DOMEntity _entityImpl]): (-[DOMProcessingInstruction _processingInstructionImpl]):

Mar 4, 2004:

5:52 PM Changeset in webkit [6174]

11 copies
2 deletes in tags/WebCore-125~3

This commit was manufactured by cvs2svn to create tag
'WebCore-125~3'.

5:52 PM Changeset in webkit [6173] by mjs

1 edit in branches/Safari-1-2-branch/WebCore/ChangeLog-2005-08-23

WebCore-125.3

5:48 PM Changeset in webkit [6172] by mjs

8 edits in branches/Safari-1-2-branch/WebCore

Bump versions.

English.lproj/InfoPlist.strings:

kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityIsIgnored]): Fix to build on branch.

Merge the following fix for Epiphany:

2004-03-03 David Hyatt <hyatt@apple.com>

Speed up access to the children arrays of accessibility objects by caching mutable arrays of children
and nulling them out only when the children change.

Reviewed by john

khtml/rendering/render_container.cpp: (RenderContainer::removeChildNode): (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
kwq/KWQAccObject.h:
kwq/KWQAccObject.mm: (-[KWQAccObject detach]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject childrenChanged]): (-[KWQAccObject clearChildren]):
kwq/KWQAccObjectCache.h:
kwq/KWQAccObjectCache.mm: (KWQAccObjectCache::childrenChanged):

5:34 PM Changeset in webkit [6171] by rjw

5 edits
1 add in trunk/JavaScriptCore

Implementation of NP_JavaScriptObject. This is the 'C' class
that wraps a JavaScript object. Still have more stubs to
implement before this is complete.

Reviewed by Chris.

JavaScriptCore.pbproj/project.pbxproj:
bindings/NP_jsobject.cpp: Added. (coerceValueToNPValueType): (convertValueToNPValueType): (convertNPValueTypeToValue): (listFromNPArray): (jsAllocate): (jsDeallocate): (identiferFromNPIdentifier): (NP_Call): (NP_Evaluate): (NP_GetProperty): (NP_SetProperty): (NP_RemoveProperty): (NP_ToString): (NP_GetPropertyAtIndex): (NP_SetPropertyAtIndex):
bindings/NP_runtime.cpp: (NP_ObjectAtIndex):
bindings/NP_runtime.h:
bindings/runtime_object.h:

3:34 PM Changeset in webkit [6170] by cblu

10 edits in trunk/WebKit

WebKit:

Made image dragging and copying always work without needing to re-download by using the data source's WebResource of the image instead of relying on the Foundation cache.
Fixed a "drag to self" problem I introduced in my last check-in. You could drag a URL from a WebHTMLView and drop it on its own WebView which we shouldn't allow.

Reviewed by rjw.

ChangeLog:
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge fileWrapperForURL:]): call _fileWrapperForURL on WebDataSource
WebView.subproj/WebDataSource.m: (-[WebDataSource _fileWrapperForURL:]): moved from WebView, creates a wrapper from a WebResource
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate copyImageToClipboard:]): call [WebDataSource _fileWrapperForURL:]
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _handleMouseDragged:]): call [WebDataSource _fileWrapperForURL:] (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): call [WebDataSource _fileWrapperForURL:] (-[WebHTMLView _dragOperationForDraggingInfo:]): new, factored out from draggingUpdated: (-[WebHTMLView draggingEntered:]): call _dragOperationForDraggingInfo:, if NSDragOperationNone, forward to WebView to it can handle the drag (-[WebHTMLView draggingUpdated:]): ditto (-[WebHTMLView concludeDragOperation:]): ditto
WebView.subproj/WebResource.m: (-[WebResource _fileWrapperRepresentation]): new
WebView.subproj/WebResourcePrivate.h:
WebView.subproj/WebView.m: (-[WebViewPrivate dealloc]): release draggedTypes, a new ivar that keeps track of drag types that we're currently registered for (-[WebView _setDraggedTypes:]): new (-[WebView unregisterDraggedTypes]): new, calls _setDraggedTypes then super (-[WebView registerForDraggedTypes:]): ditto (-[WebView _dragOperationForDraggingInfo:]): new, compares the types on the pasteboard against the types we are currently registered for. Normally the AppKit handles this for us, but since these messages can be forwarded from WebHTMLView, we need to do this comparison ourselves. (-[WebView draggingEntered:]): calls _dragOperationForDraggingInfo: (-[WebView draggingUpdated:]): ditto (-[WebView concludeDragOperation:]): ditto
WebView.subproj/WebViewPrivate.h: define new draggedTypes ivar

WebBrowser:

Removed "Download Image" context menus because images no longer need to be re-downloaded.

Reviewed by rjw.

ContextMenuHandler.m: (-[WebDataSource isDataLocalForURL:]): new category, moved from the WebView category (-[BrowserWebView webView:contextMenuItemsForElement:defaultMenuItems:]): call isDataLocalForURL on WebDataSource (-[BrowserWebView saveFileWrapperForURLKey:menuItem:]): call _fileWrapperForURL on WebDataSource, use the resource to get the MIME type if possible (-[BrowserWebView saveFileWrapperToDownloadsFolderForURLKey:menuItem:]): call _fileWrapperForURL on WebDataSource

3:24 PM Changeset in webkit [6169] by rjw

3 edits in trunk/JavaScriptCore

Added NP_Array implementation.

Changed NP_Boolean to just depend on two static instances, no
space is required for values.

Reviewed by Chris.

bindings/NP_runtime.cpp: (NP_CreateBoolean): (NP_BoolFromBoolean): (arrayAllocate): (arrayDeallocate): (NP_CreateArray): (NP_CreateArrayV): (NP_ObjectAtIndex):
bindings/NP_runtime.h:

Mar 3, 2004:

6:59 PM Changeset in webkit [6168] by mjs

2 edits in branches/Safari-1-2-branch/WebCore

Actually merge the two changes below, they didn't actually get in
last time.

kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject accessibilityIsIgnored]):

4:39 PM Changeset in webkit [6167] by cblu

2 edits in trunk/WebKit

Fixed a typo.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView concludeDragOperation:]):

4:29 PM Changeset in webkit [6166] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3576070>: REGRESSION: web view won't accept drag of webloc file

Reviewed by rjw.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView draggingUpdated:]): if we're not handling the drag, forward this message to the WebView since it may want to handle it (-[WebHTMLView concludeDragOperation:]): if we're not handling the drag, forward this message to the WebView since it may want to handle it

2:56 PM Changeset in webkit [6165] by darin

6 edits
3 deletes in trunk

JavaScriptCore:

Reviewed by Vicki.

English.lproj/InfoPlist.strings: Removed. No need to localize the version and copyright string, and that's all that was in here.
JavaScriptCore.pbproj/project.pbxproj: Removed InfoPlist.strings from build.

WebCore:

Reviewed by Vicki.

English.lproj/InfoPlist.strings: Removed. No need to localize the version and copyright string, and that's all that was in here.
WebCore.pbproj/project.pbxproj: Removed InfoPlist.strings from build.

WebKit:

Reviewed by Vicki.

English.lproj/InfoPlist.strings: Removed. No need to localize the version and copyright string, and that's all that was in here.
WebKit.pbproj/project.pbxproj: Removed InfoPlist.strings from build.

WebBrowser:

Reviewed by Vicki.

English.lproj/InfoPlist.strings: Removed version, copyright message, and CFBundleName. We won't localize any of these (it's named "Safari" worldwide).

2:50 PM Changeset in webkit [6164] by rjw

3 edits in trunk/JavaScriptCore

More 'C' binding implementation. Fleshed out all the
'primitive' data types.

Reviewed by Chris.

bindings/NP_runtime.cpp: (NP_ReleaseObject): (numberAllocate): (stringAllocate): (stringDeallocate): (NP_CreateStringWithUTF8): (NP_CreateStringWithUTF16): (NP_UTF8FromString): (NP_UTF16FromString): (NP_StringLength): (booleanAllocate): (booleanDeallocate): (NP_CreateBoolean): (NP_BoolFromBoolean): (nullAllocate): (nullDeallocate): (NP_GetNull): (undefinedAllocate): (undefinedDeallocate): (NP_GetUndefined):
bindings/NP_runtime.h:

12:04 PM Changeset in webkit [6163] by rjw

3 edits in trunk/JavaScriptCore

More 'C' binding implementation.

Reviewed by Chris.

bindings/NP_runtime.cpp: (identifierEqual): (identifierHash): (getIdentifierDictionary): (NP_IdentifierFromUTF8): (NP_UTF8FromIdentifier): (NP_CreateObject): (NP_ReleaseObject): (NP_IsKindOfClass): (numberCreate): (NP_CreateNumberWithInt): (NP_CreateNumberWithFloat): (NP_CreateNumberWithDouble): (NP_IntFromNumber): (NP_FloatFromNumber): (NP_DoubleFromNumber):
bindings/NP_runtime.h:

10:49 AM Changeset in webkit [6162]

4 copies in tags/Safari-130

This commit was manufactured by cvs2svn to create tag 'Safari-130'.

10:49 AM Changeset in webkit [6161] by kocienda

2 edits in trunk/WebKit

Reviewed by Chris

copy-webcore-files-to-webkit: Fixed up this script so that it does not fail if it is running "non-locally", like for B&I. The idiom is to check these files into WebKit after copying them from WebCore, hence this script is merely a convenience to keep the files in sync.

10:45 AM Changeset in webkit [6160] by hyatt

6 edits in trunk/WebCore

Speed up access to the children arrays of accessibility objects by caching mutable arrays of children
and nulling them out only when the children change.

Reviewed by john

khtml/rendering/render_container.cpp: (RenderContainer::removeChildNode): (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
kwq/KWQAccObject.h:
kwq/KWQAccObject.mm: (-[KWQAccObject detach]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject childrenChanged]): (-[KWQAccObject clearChildren]):
kwq/KWQAccObjectCache.h:
kwq/KWQAccObjectCache.mm: (KWQAccObjectCache::childrenChanged):

Mar 2, 2004:

4:42 PM Changeset in webkit [6159] by kocienda

10 edits in trunk

Tests:

Reviewed by me

Blot/BlotDocument.m: (-[BlotDocument webView:didFinishLoadForFrame:]): Remove error out parameter from DOM call.

WebCore:

Reviewed by Darin and me. Coding by Darin and me.

1) Fix some places that were calling [self class], in at
least one case calling a method not defined on the class
(not gonna work).
2) Add underscore prefix for all non-API method names.
3) Make DOMObject refuse to init, which might prevent
problems where people get confused and think they can
subclass or instantiate it or its subclasses.
4) Use some C++ mojo to replace NSStringToDOMString and
DOMStringToNSString with type conversions built into the
DOMString class.
5) Removed NSError out parameters from the API. Methods
now throw NSExceptions.
6) Exception code local variables now initialized before
passing to khtml DOM impl calls.
7) Various other cleanups and tweaks.

khtml/dom/dom_string.h
khtml/xml/dom_atomicstring.h
kwq/DOM.h
kwq/DOM.mm
kwq/DOMInternal.h
kwq/KWQKHTMLPart.mm
kwq/WebCoreBridge.mm

WebKit:

Reviewed by NOBODY (OOPS!).

DOM.subproj/DOM.h: Checked in header copied over from WebCore.

4:20 PM Changeset in webkit [6158] by rjw

3 edits in trunk/JavaScriptCore

Removed retain/release from NP_Class. Classes will not be allowed to implement their
own customer retain/release scheme.

Reviewed by Chris.

bindings/NP_runtime.cpp: (NP_RetainObject): (NP_ReleaseObject):

4:17 PM Changeset in webkit [6157] by rjw

14 edits
6 adds in trunk

WebKit:

Added WebJavaScriptObject API. The location of this file may
change.

Reviewed by Chris.

Plugins.subproj/NP_objc.h: Added.
WebKit.pbproj/project.pbxproj:

WebCore:

Added NP_SAP API. This API includes the new entry points
used to bind native interfaces to JavaScript. It's final location
may change.

Made changes to KWQKHTMLPart.mm to reflect changes in names
on RootObject.

Reviewed by Chris.

WebCore.pbproj/project.pbxproj:
khtml/ecma/NP_SAP.h: Added.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::cleanupPluginRootObjects):
kwq/WebCoreBridge.mm:

JavaScriptCore:

C binding API. Partial implementation.

Completed ObjectiveC bindings (not based on the C API). These will re-implemented over the C binding API, but I wanted to get this code in the tree.

Factored root object reference counting scheme. It is now useful independent
of LiveConnect.

Reviewed by Chris.

JavaScriptCore.pbproj/project.pbxproj:
bindings/NP_runtime.cpp: Added. (NP_IdentifierFromUTF8): (NP_GetIdentifiers): (NP_UTF8FromIdentifier): (NP_CreateObject): (NP_RetainObject): (NP_ReleaseObject): (NP_IsKindOfClass): (NP_SetException): (NP_Call): (NP_Evaluate): (NP_GetProperty): (NP_SetProperty): (NP_RemoveProperty): (NP_ToString): (NP_GetPropertyAtIndex): (NP_SetPropertyAtIndex): (NP_CreateNumberWithInt): (NP_CreateNumberWithFloat): (NP_CreateNumberWithDouble): (NP_IntFromNumber): (NP_FloatFromNumber): (NP_DoubleFromNumber): (NP_CreateStringWithUTF8): (NP_CreateStringWithUTF16): (NP_UTF8FromString): (NP_UTF16FromString): (NP_CreateBoolean): (NP_BoolFromBoolean): (NP_GetNull): (NP_GetUndefined): (NP_CreateArray): (NP_CreateArrayV): (NP_ObjectAtIndex):
bindings/NP_runtime.h: Added.
bindings/jni/jni_jsobject.cpp: (JSObject::invoke): (JSObject::finalize): (JSObject::createNative): (JSObject::convertValueToJObject):
bindings/jni/jni_jsobject.h:
bindings/objc/objc_jsobject.h:
bindings/objc/objc_jsobject.mm: (rootForView): (windowJavaScriptObject): (-[JavaScriptObject initWithObjectImp:KJS::root:Bindings::]): (-[JavaScriptObject dealloc]): (-[JavaScriptObject _convertValueToObjcValue:KJS::]): (-[JavaScriptObject call:arguments:]): (-[JavaScriptObject evaluate:]): (-[JavaScriptObject getMember:]): (-[JavaScriptObject setMember:value:]): (-[JavaScriptObject removeMember:]): (-[JavaScriptObject toString]): (-[JavaScriptObject getSlot:]): (-[JavaScriptObject setSlot:value:]):
bindings/objc/objc_utility.h:
bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue):
bindings/runtime_root.cpp: Added. (getReferencesByRootDictionary): (getReferencesDictionary): (KJS::Bindings::findReferenceDictionary): (KJS::Bindings::rootForImp): (KJS::Bindings::addNativeReference): (KJS::Bindings::removeNativeReference): (completedJavaScriptAccess): (initializeJavaScriptAccessLock): (lockJavaScriptAccess): (unlockJavaScriptAccess): (RootObject::dispatchToJavaScriptThread): (performJavaScriptAccess): (RootObject::setFindRootObjectForNativeHandleFunction): (RootObject::removeAllNativeReferences):
bindings/runtime_root.h: Added. (KJS::Bindings::RootObject::RootObject): (KJS::Bindings::RootObject::~RootObject): (KJS::Bindings::RootObject::setRootObjectImp): (KJS::Bindings::RootObject::rootObjectImp): (KJS::Bindings::RootObject::setInterpreter): (KJS::Bindings::RootObject::interpreter): (KJS::Bindings::RootObject::findRootObjectForNativeHandleFunction): (KJS::Bindings::RootObject::runLoop): (KJS::Bindings::RootObject::performJavaScriptSource):

1:15 PM Changeset in webkit [6156] by mjs

3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3549201>: repro crash in KHTMLPart::begin inside JavaScript code (gmpartsdirect.com)

Added some null checks. I am not sure why this page attaches a
document that has no view, but these changes make it work
perfectly.

khtml/khtml_part.cpp: (KHTMLPart::begin): Add check for null view before use. * khtml/xml/dom_docimpl.cpp: (DocumentImpl::close): ditto (DocumentImpl::recalcStyle): Add check for null paint device.

12:00 PM Changeset in webkit [6155] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3575598>: REGRESSION: Safari crashes at IS&T website

Reviewed by darin.

WebView.subproj/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): don't stop the icon loader here because that can cause an infinite loop (-[WebDataSource _stopLoadingInternal]): always stop the icon loader here instead of just when the data source is loading as well.

10:07 AM Changeset in webkit [6154] by vicki

3 edits in trunk

Change version number from '130' to '131u'. The tree is open.

9:27 AM Changeset in webkit [6153] by vicki

6 edits in trunk

Safari-130 stamp

9:03 AM Changeset in webkit [6152] by kocienda

8 edits in trunk

WebCore:

Reviewed by me

Rollout last night's checkin. The tree was closed.

kwq/DOM.h
kwq/DOM.mm
kwq/DOMInternal.h
kwq/KWQKHTMLPart.mm
kwq/WebCoreBridge.mm

WebKit:

Reviewed by me

DOM.subproj/DOM.h: Rollout last night's checkin. The tree was closed.

Mar 1, 2004:

6:59 PM Changeset in webkit [6151] by cblu

5 edits in trunk/WebKit

Fixed: <rdar://problem/3574979>: REGRESSION (129-TOT): crash loading macromedia.com

deliverResource was being called after it had already been called in setDefersCallbacks:.

Reviewed by rjw.

WebView.subproj/WebBaseResourceHandleDelegate.h:
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate deliverResource]): set deliveredResource to YES (-[WebBaseResourceHandleDelegate deliverResourceAfterDelay]): new, calls deliverResource after a delay (-[WebBaseResourceHandleDelegate loadWithRequest:]): call deliverResourceAfterDelay (-[WebBaseResourceHandleDelegate setDefersCallbacks:]): call deliverResourceAfterDelay

6:52 PM Changeset in webkit [6150] by kocienda

8 edits in trunk

WebCore:

Reviewed by me, changes by Darin.

Yet another pass at the DOM API, this one by
Darin to simplify the internal structure of the
implementation. Little has changed in the API;
much has changed in the implementation, particularly
with regard to object creation and data storage and
the class hierarchy.

kwq/DOM.h
kwq/DOM.mm
kwq/DOMInternal.h
kwq/KWQKHTMLPart.mm
kwq/WebCoreBridge.mm

WebKit:

Reviewed by me

DOM.subproj/DOM.h: Checked in header copied over from WebCore.

4:39 PM Changeset in webkit [6149] by kocienda

2 edits in trunk/WebKit

Reviewed by me

DOM.subproj/DOM.h: Oh, it's like the Keystone Cops this afternoon... Backed out an unintended change to thsi file.

4:37 PM Changeset in webkit [6148] by kocienda

3 edits in trunk/WebKit

Reviewed by me

copy-webcore-files-to-webkit: Dumb typing error on my part in making my previous quick fix. This quick fix works.

4:27 PM Changeset in webkit [6147] by cblu

2 edits in trunk/WebKit

Updated the WebKit project file to 1.1 because a previous check-in reverted to 1.01.

WebKit.pbproj/project.pbxproj:

4:21 PM Changeset in webkit [6146] by kocienda

2 edits in trunk/WebKit

Reviewed by me

copy-webcore-files-to-webkit: Made this file buildit-compliant

4:04 PM Changeset in webkit [6145] by cblu

3 edits in trunk/WebKit

Found a bug in my last check-in. If a load that originates from a WebResource is cancelled before the data from the WebResource is delivered, callbacks are sent anyway.

Reviewed by rjw.

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate cancelWithError:]): cancel the perform request for deliverResource

3:55 PM Changeset in webkit [6144] by vicki

3 edits in trunk/WebKit

Reviewed by darin.

Misc.subproj/WebIconLoader.m: (-[WebIconLoader didFinishLoading]): rejigger handle code to avoid Deployment failure
WebKit.pbproj/project.pbxproj:

2:39 PM Changeset in webkit [6143]

5 copies
3 deletes in tags/JavaScriptCore-125~3

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-125~3'.

2:39 PM Changeset in webkit [6142] by vicki

2 edits in branches/SUPanFeldspar-branch/JavaScriptCore

versioning change for JavaScriptCore-125.3

2:37 PM Changeset in webkit [6141] by vicki

2 edits in branches/SUPanFeldspar-branch/JavaScriptCore

roll this change onto the SUPanFeldspar branch

2004-02-02 Darin Adler <Darin Adler>

Reviewed by Maciej.

fixed <rdar://problem/3546613>: array of negative size leads to crash (test page at oscar.the-rileys.net)

kjs/array_object.cpp: (ArrayInstanceImp::ArrayInstanceImp): If the length is greater than 10,000, don't allocate an array until we start putting values in. This prevents new Array(2147483647) from causing trouble. (ArrayObjectImp::construct): Check number as described in specification, and raise a range error if the number is out of range. This prevents new Array(-1) from causing trouble.

2:23 PM Changeset in webkit [6140] by mjs

2 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

fixed <rdar://problem/3567047>: REGRESSION: repro crash inside KJS (dispatchToBoolean) at www.thedonnas.com
fixed <rdar://problem/3550461>: REGRESSION: repro crash in JavaScript at www.alaska.com

khtml/ecma/kjs_window.cpp: (Window::getListener): Return Null() when the listener object is null, indicating the code failed to parse. Otherwise we return a bad value which can later crash the JS interpreter.

2:22 PM Changeset in webkit [6139] by cblu

16 edits in trunk/WebKit

Made WebResource loading not use Foundation at all. This allows "Mail Page" and paste to more directly load subresources without any indirection involving NSURLConnection and the Foundation cache.
Made WebIconLoader a subclass of WebBaseResourceHandleDelegate. This makes favicons appear in the activity window among other things.

Reviewed by kocienda.

Misc.subproj/WebIconLoader.h:
Misc.subproj/WebIconLoader.m: removed connection and data ivars since WebBaseResourceHandleDelegate holds these (-[WebIconLoaderPrivate dealloc]): removed calls to deleted ivars (-[WebIconLoader URL]): call renamed request ivar (-[WebIconLoader startLoading]): call loadWithRequest (-[WebIconLoader stopLoading]): call cancel (-[WebIconLoader didFinishLoading]):
Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate didReceiveResponse:]): renamed to be connection-less since callbacks may came from a WebResource and not an NSURLConnection (-[WebNetscapePluginConnectionDelegate didReceiveData:lengthReceived:]): ditto (-[WebNetscapePluginConnectionDelegate didFinishLoading]): ditto (-[WebNetscapePluginConnectionDelegate didFailWithError:]): ditto
WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient didReceiveResponse:]): ditto (-[WebSubresourceClient didReceiveData:lengthReceived:]): ditto (-[WebSubresourceClient didFinishLoading]): ditto (-[WebSubresourceClient didFailWithError:]): ditto
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebBaseResourceHandleDelegate.h:
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate loadWithRequest:]): instead of storing the resource in the Foundation cache in order to later load it from the cache, deliver the callbacks ourselves after a delay (-[WebBaseResourceHandleDelegate setDefersCallbacks:]): call deliverResource if callbacks are turned back on (-[WebBaseResourceHandleDelegate deliverResource]): new, calls didReceiveResponse:, didReceiveData:lengthReceived:, and didFinishLoading (-[WebBaseResourceHandleDelegate willSendRequest:redirectResponse:]): renamed to be connection-less since callbacks may came from a WebResource and not an NSURLConnection (-[WebBaseResourceHandleDelegate didReceiveAuthenticationChallenge:]): ditto (-[WebBaseResourceHandleDelegate didCancelAuthenticationChallenge:]): ditto (-[WebBaseResourceHandleDelegate didReceiveResponse:]): ditto (-[WebBaseResourceHandleDelegate didReceiveData:lengthReceived:]): ditto (-[WebBaseResourceHandleDelegate didFinishLoading]): ditto (-[WebBaseResourceHandleDelegate didFailWithError:]): ditto (-[WebBaseResourceHandleDelegate willCacheResponse:]): ditto (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): calls connection-less version of this method (-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]): ditto (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]): ditto (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]): ditto (-[WebBaseResourceHandleDelegate connection:didReceiveData:lengthReceived:]): ditto (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): ditto (-[WebBaseResourceHandleDelegate connection:didFailWithError:]): ditto (-[WebBaseResourceHandleDelegate connection:willCacheResponse:]): ditto (-[WebBaseResourceHandleDelegate cancelWithError:]): call renamed _completeProgressForConnectionDelegate on WebView (-[WebBaseResourceHandleDelegate cancelledError]): tweak
WebView.subproj/WebDataSource.m: (-[WebDataSource _loadIcon]): set the data source on the icon loader so it can callback
WebView.subproj/WebResource.m: (-[WebResource _response]): new, factored out from _cachedResponseRepresentation (-[WebResource _cachedResponseRepresentation]): call _response
WebView.subproj/WebResourcePrivate.h:
WebView.subproj/WebView.m: (-[WebView _incrementProgressForConnectionDelegate:response:]): renamed to be connection-less (-[WebView _incrementProgressForConnectionDelegate:data:]): ditto (-[WebView _completeProgressForConnectionDelegate:]): ditto
WebView.subproj/WebViewPrivate.h:

12:03 PM Changeset in webkit [6138] by vicki

2 edits in trunk/WebCore

Reviewed by Vicki.

fixed Tiger build

kwq/KWQXmlSimpleReader.mm: (QXmlSimpleReader::parse): Changed SAX structure initialization code so it compiles with both the newer and older libxml. Not sure this will work right with namespaces with the new libxml; we'll have to test.

9:30 AM Changeset in webkit [6137] by kocienda

5 edits in trunk/WebCore

Reviewed by me, as suggested by Darin

khtml/misc/htmlattrs.c: (getAttrName): Generated code no longer has extraneous semicolon.
khtml/misc/htmltags.c: Generated code no longer has extraneous semicolon. (getTagName):
khtml/misc/makeattrs: Removed extraneous semicolon from end of file.
khtml/misc/maketags: Ditto.

9:24 AM Changeset in webkit [6136] by kocienda

2 edits in trunk/WebCore

Reviewed by me

kwq/DOMInternal.h: Replaced tabs with spaces.

9:04 AM Changeset in webkit [6135] by kocienda

29 edits
1 add
2 deletes in trunk

Tests:

Reviewed by Darin

Changed all Objective-C DOM classes from protocols to classes

Blot/BlotDocument.m: (-[BlotDocument webView:didFinishLoadForFrame:]):

WebCore:

Reviewed by Darin

Changed all Objective-C DOM classes from protocols to classes, using
a class cluster-like approach.

WebCore.pbproj/project.pbxproj:
khtml/dom/html_object.cpp: Put code in DOM namespace.
khtml/html/html_headimpl.cpp: Pull in entire DOM namespace in using directive to make up for the removal of it from htmlattrs.
khtml/html/htmltokenizer.cpp: Add using directives for the DOM classes used.
khtml/misc/htmlattrs.c: (getAttrName):
khtml/misc/htmlattrs.h:
khtml/misc/htmltags.c: (getTagName):
khtml/misc/makeattrs: Some changes here to avoid pulling in the entire DOM namespace. Explicitly use DOM namespace scoping for DOMString.
khtml/misc/maketags: Explicitly use DOM namespace scoping for DOMString.
khtml/rendering/render_form.cpp: Pull in entire DOM namespace in using directive to make up for the removal of it from htmlattrs.
kwq/DOM-compat.h:
kwq/DOM.h:
kwq/DOM.mm: Added.
kwq/WebCoreDOM.h: Removed.
kwq/WebCoreDOM.mm: Removed.

WebKit:

Reviewed by Darin

Changed all Objective-C DOM classes from protocols to classes.

DOM.subproj/DOM-compat.h:
DOM.subproj/DOM.h:
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:reload:onLoadEvent:target:triggeringEvent:form:formValues:]): (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
WebView.subproj/WebFormDelegate.h:
WebView.subproj/WebFormDelegate.m: (-[WebFormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:]):
WebView.subproj/WebFrame.m: (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFormState initWithForm:values:sourceFrame:]): (-[WebFormState form]):
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebHTMLRepresentation.h:
WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation DOMDocument]): (-[WebHTMLRepresentation setSelectionFrom:startOffset:to:endOffset:]): (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]): (-[WebHTMLRepresentation elementWithName:inForm:]): (-[WebHTMLRepresentation elementForView:]): (-[WebHTMLRepresentation elementDoesAutoComplete:]): (-[WebHTMLRepresentation elementIsPassword:]): (-[WebHTMLRepresentation formForElement:]): (-[WebHTMLRepresentation controlsInForm:]): (-[WebHTMLRepresentation searchForLabels:beforeElement:]): (-[WebHTMLRepresentation matchLabels:againstElement:]):

WebBrowser:

Reviewed by Darin

Changed all Objective-C DOM classes from protocols to classes.

BrowserWebController.m: (-[FormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:]):
Debug/SnippetController.m: (lastNode): (-[SnippetController loadComplete]):
FormCompletionController.h:
FormCompletionController.m: (+[FormCompletionController loginInfoForForm:inFrame:]): (+[FormCompletionController _frame:sourceFrame:willSubmitLoginForm:withValues:formInfo:submissionListener:]): (+[FormCompletionController _frame:sourceFrame:willSubmitRegularForm:withValues:]): (+[FormCompletionController frame:sourceFrame:willSubmitForm:withValues:submissionListener:]): (+[FormCompletionController currentFormInFrame:]): (+[FormCompletionController currentFrameAndForm:inWebView:]): (+[FormCompletionController autoFillInWebView:]): (+[FormCompletionController autoFillPasswordInFrame:]): (-[FormCompletionController initWithSourceField:frame:]): (-[FormCompletionController maxStringLength]): (+[AutoFillController autoFillerForFrame:form:create:]): (+[AutoFillController abMatchInFrame:form:fieldName:]): (+[AutoFillController isContinuationField:inFrame:form:]): (+[AutoFillController recordABMatch:inFrame:form:fieldName:]): (+[AutoFillController clearAutoFilledView:inFrame:form:]): (-[AutoFillController _fieldNameForAutoFillOfView:rep:]): (fieldLooksLikeContinuation): (-[AutoFillController _reflectMultiFieldMatch:inViews:currIndex:fieldName:]): (-[FormToABBinder abPointerForView:rep:useFieldName:foundByPageScan:]):
Test/AutoFillTest.m: (+[AutoFillTest _dumpFormState:]):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed