Context Navigation

WebCore.pbproj/project.pbxproj:
khtml/css/css_computedstyle.cpp: Added. (DOM::valueForLength): Helper to turn a khtml::Length into a computed value string. (DOM::stringForBorderStyle): Helper to turn an EBorderStyle into a computed value string. (DOM::stringForTextAlign): Helper to turn an ETextAlign into a computed value string. (DOM::CSSComputedStyleDeclarationImpl::CSSComputedStyleDeclarationImpl): New function. (DOM::CSSComputedStyleDeclarationImpl::~CSSComputedStyleDeclarationImpl): Ditto. (DOM::CSSComputedStyleDeclarationImpl::cssText): Ditto. (DOM::CSSComputedStyleDeclarationImpl::setCssText): Ditto. (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Ditto. (DOM::CSSComputedStyleDeclarationImpl::getPropertyValue): Ditto. (DOM::CSSComputedStyleDeclarationImpl::getPropertyPriority): Ditto. (DOM::CSSComputedStyleDeclarationImpl::removeProperty): Ditto. (DOM::CSSComputedStyleDeclarationImpl::setProperty): Ditto. (DOM::CSSComputedStyleDeclarationImpl::setLengthProperty): Ditto. (DOM::CSSComputedStyleDeclarationImpl::item): Ditto. (DOM::CSSComputedStyleDeclarationImpl::property): Ditto.
khtml/css/css_computedstyle.h: Added.
khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::cssText): Fixed some formatting of Rect. Added suppoprt for rgba colors.
khtml/css/css_valueimpl.h: (DOM::CSSStyleDeclarationImpl::node):
khtml/ecma/kjs_css.cpp: (KJS::getDOMCSSStyleDeclaration):
khtml/ecma/kjs_dom.cpp: (DOMDocument::getValueProperty): defaultView is a property, used to be a function, which was wrong. Fixed. (DOMDocumentProtoFunc::tryCall): Ditto.
khtml/ecma/kjs_dom.lut.h: (KJS::): Regenerated file.
khtml/misc/khtmllayout.h: (khtml::Length::length): Added an accessor to the value, to promote better coding style, rather than peeking and poking the value directly.
khtml/rendering/render_style.h: (khtml::RenderStyle::borderLeftWidth): BHIDDEN also should be treated like BNONE when it comes to returning a zero value. Now it is. (khtml::RenderStyle::borderRightWidth): Ditto. (khtml::RenderStyle::borderTopWidth): Ditto. (khtml::RenderStyle::borderBottomWidth): Ditto. (khtml::RenderStyle::outlineWidth): Ditto. (khtml::RenderStyle::outlineOffset): Ditto.
khtml/xml/dom2_viewsimpl.cpp: (AbstractViewImpl::getComputedStyle): Added an implementation for this formerly stubbed out function.

1:27 PM Changeset in webkit [6177] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3560132>: REGRESSION: Safari crashed in -[NSPasteboard setData:forType:] dragging a map out of Mapquest.com

Reviewed by john.

Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:URL:title:fileWrapper:HTMLString:]): declare the pboard types by calling _web_writeURL:::: before calling setData::

11:02 AM Changeset in webkit [6176] by sullivan

9 edits in trunk/WebKit

WebKit:

First cut at WebKit support for showing error pages for unreachable URLs.
This doesn't work quite right with the back/forward list yet, but is
good enough for demos.

Reviewed by Darin.

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate didReceiveResponse:]): use new _webDataRequextExternalURL to share code

WebView.subproj/WebDataProtocol.h: Three new methods (all internal to WebKit): -[NSURLRequest _webDataRequestUnreachableURL], -[NSURLRequest _webDataRequestExternalURL], -[NSURLRequest _webDataRequestSetUnreachableURL]
WebView.subproj/WebDataProtocol.m: new unreachableURL field of WebDataRequestParameters (-[WebDataRequestParameters copyWithZone:]): copy new field (-[WebDataRequestParameters dealloc]): release new field (-[NSURLRequest _webDataRequestUnreachableURL]): read new field (-[NSURLRequest _webDataRequestExternalURL]): new method, returns baseURL or "about:blank" for webdata protocol requests. This was done in multiple places previously. (-[NSURLRequest _webDataRequestExternalRequest]): now calls _webDataRequestExternalURL to share code (-[NSMutableURLRequest _webDataRequestSetUnreachableURL:]): write new field

WebView.subproj/WebDataSource.m: (-[WebDataSource unreachableURL]): new method, might become API; returns the unreachable URL, if any, for which this datasource holds placeholder content (-[WebDataSource _URLForHistory]): new method, returns the URL to be stored in History for this dataSource. This returns nil for run-of-the-mill WebDataProtocol URLs (replacing code elsewhere that checked for this case) but returns the unreachableURL for the case where this datasource holds placeholder content. (-[WebDataSource _setTitle:]): now calls _URLForHistory

WebView.subproj/WebDataSourcePrivate.h: added unreachableURL in the should-become-API section, and _URLForHistory elsewhere

WebView.subproj/WebFrame.m: (-[WebFrame loadPlaceholderHTMLString:baseURL:unreachableURL:]): new should-become-API method for displaying an error page for an unreachable URL (-[WebFrame loadPropertyList:]): updated to pass nil for unreachableURL (-[WebFrame _webDataRequestForData:MIMEType:textEncodingName:baseURL:unreachableURL:]): added unreachableURL parameter, which gets set on the data request (-[WebFrame _addBackForwardItemClippedAtTarget:]): use _URLForHistory instead of just checking for WebDataProtocol (-[WebFrame _createItem:]): use unreachableURL if there is one (-[WebFrame _transitionToCommitted:]): use _URLForHistory instead of just checking for WebDataProtocol (-[WebFrame _isLoadComplete]): check whether a new load has started in the delegate callback and if so, don't reset the loading state here (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): added unreachableURL parameter, which gets passed through (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): send nil unreachableURL parameter (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): new bottleneck method for loadHTMLString:baseURL: and loadPlaceholderHTMLString:baseURL:unreachableURL:; this is the guts of loadHTMLString:baseURL: with the new unreachableURL parameter passed through (-[WebFrame loadHTMLString:baseURL:]): now calls new bottleneck method

WebView.subproj/WebFramePrivate.h: added loadPlaceholderString:baseURL:unreachableURL: to should-be-API section; added unreachableURL parameter to _webDataRequestForData:MIMEType:textEncodingName:baseURL:

WebBrowser:

First cut at WebBrowser support for showing error pages for unreachable URLs.
This doesn't work quite right with the back/forward list yet, but is
good enough for demos. The old sheet-using code remains intact, and there's
a menu item in the Debug menu to try the new way (old way is still default
for now).

Reviewed by Darin.

PreferenceKeys.h: added DebugDisplayErrorsAsPagesPreferenceKey; also deleted a couple of unused old preference keys.

BrowserWebController.h: added showErrorPageForURL:withTitle:message:

BrowserWebController.m: (-[BrowserWebView webView:unableToImplementPolicyWithError:frame:]): use showErrorPageForURL:... if the preference is set that way (-[BrowserWebView errorPageHTMLWithTitle:message:]): new method, returns an HTML string for the error page. This will eventually be done reading resources from disk no doubt, but for now we just display a simple page that has the same text as the sheet. (-[BrowserWebView showErrorPageForURL:withTitle:message:]): new method, uses new loadPlaceholderHTMLString:baseURL:unreachableURL: to put up an error page in the webview (-[BrowserWebView expectedOrCurrentURL]): use unreachableURL if there is one

Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): add menu item "Show Page Load Errors Inline" (-[NSApplication validate_toggleDisplayLoadErrorsAsPages:]): new method, sets the checkmark on the new menu item appropriately (-[NSApplication toggleDisplayLoadErrorsAsPages:]): new method, toggles the state of the preference

LoadProgressMonitor.m: (-[LoadProgressMonitor _createProgressEntryWithRequest:dataSource:]): use unreachableURL if there is one (-[LoadProgressMonitor webView:resource:didReceiveResponse:fromDataSource:]): ditto

LocationChangeError.m: (-[LocationChangeHandler displayOrRememberLocationChangeError:forDataSource:]): use showErrorPage:... if the preference is set that way

LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]): use previously-fetched local variable "frame" rather than getting it from the dataSource again. This is not only trivially faster in the normal case, but also avoids a bug when the code earlier in this method triggers another page load (as in the showErrorPage:... case).

English.lproj/Localizable.strings: updated for these changes

10:20 AM Changeset in webkit [6175] by kocienda

2 edits in trunk/WebCore

Change by Darin. Reviewed by me.

kwq/DOM.mm: Fixed the following functions to deal with casting objects derived from NodeImpl back and forth to NodeImpl given that the derived classes use multiple inheritance. (-[DOMDocument _documentImpl]): (-[DOMCharacterData _characterDataImpl]): (-[DOMAttr _attrImpl]): (-[DOMElement _elementImpl]): (-[DOMText _textImpl]): (-[DOMDocumentType _documentTypeImpl]): (-[DOMNotation _notationImpl]): (-[DOMEntity _entityImpl]): (-[DOMProcessingInstruction _processingInstructionImpl]):

Mar 4, 2004:

5:52 PM Changeset in webkit [6174]

11 copies
2 deletes in tags/WebCore-125~3

This commit was manufactured by cvs2svn to create tag
'WebCore-125~3'.

5:52 PM Changeset in webkit [6173] by mjs

1 edit in branches/Safari-1-2-branch/WebCore/ChangeLog-2005-08-23

WebCore-125.3

5:48 PM Changeset in webkit [6172] by mjs

8 edits in branches/Safari-1-2-branch/WebCore

Bump versions.

English.lproj/InfoPlist.strings:

kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityIsIgnored]): Fix to build on branch.

Merge the following fix for Epiphany:

2004-03-03 David Hyatt <hyatt@apple.com>

Speed up access to the children arrays of accessibility objects by caching mutable arrays of children
and nulling them out only when the children change.

Reviewed by john

khtml/rendering/render_container.cpp: (RenderContainer::removeChildNode): (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
kwq/KWQAccObject.h:
kwq/KWQAccObject.mm: (-[KWQAccObject detach]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject childrenChanged]): (-[KWQAccObject clearChildren]):
kwq/KWQAccObjectCache.h:
kwq/KWQAccObjectCache.mm: (KWQAccObjectCache::childrenChanged):

5:34 PM Changeset in webkit [6171] by rjw

5 edits
1 add in trunk/JavaScriptCore

Implementation of NP_JavaScriptObject. This is the 'C' class
that wraps a JavaScript object. Still have more stubs to
implement before this is complete.

Reviewed by Chris.

JavaScriptCore.pbproj/project.pbxproj:
bindings/NP_jsobject.cpp: Added. (coerceValueToNPValueType): (convertValueToNPValueType): (convertNPValueTypeToValue): (listFromNPArray): (jsAllocate): (jsDeallocate): (identiferFromNPIdentifier): (NP_Call): (NP_Evaluate): (NP_GetProperty): (NP_SetProperty): (NP_RemoveProperty): (NP_ToString): (NP_GetPropertyAtIndex): (NP_SetPropertyAtIndex):
bindings/NP_runtime.cpp: (NP_ObjectAtIndex):
bindings/NP_runtime.h:
bindings/runtime_object.h:

3:34 PM Changeset in webkit [6170] by cblu

10 edits in trunk/WebKit

WebKit:

Made image dragging and copying always work without needing to re-download by using the data source's WebResource of the image instead of relying on the Foundation cache.
Fixed a "drag to self" problem I introduced in my last check-in. You could drag a URL from a WebHTMLView and drop it on its own WebView which we shouldn't allow.

Reviewed by rjw.

ChangeLog:
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge fileWrapperForURL:]): call _fileWrapperForURL on WebDataSource
WebView.subproj/WebDataSource.m: (-[WebDataSource _fileWrapperForURL:]): moved from WebView, creates a wrapper from a WebResource
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate copyImageToClipboard:]): call [WebDataSource _fileWrapperForURL:]
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _handleMouseDragged:]): call [WebDataSource _fileWrapperForURL:] (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): call [WebDataSource _fileWrapperForURL:] (-[WebHTMLView _dragOperationForDraggingInfo:]): new, factored out from draggingUpdated: (-[WebHTMLView draggingEntered:]): call _dragOperationForDraggingInfo:, if NSDragOperationNone, forward to WebView to it can handle the drag (-[WebHTMLView draggingUpdated:]): ditto (-[WebHTMLView concludeDragOperation:]): ditto
WebView.subproj/WebResource.m: (-[WebResource _fileWrapperRepresentation]): new
WebView.subproj/WebResourcePrivate.h:
WebView.subproj/WebView.m: (-[WebViewPrivate dealloc]): release draggedTypes, a new ivar that keeps track of drag types that we're currently registered for (-[WebView _setDraggedTypes:]): new (-[WebView unregisterDraggedTypes]): new, calls _setDraggedTypes then super (-[WebView registerForDraggedTypes:]): ditto (-[WebView _dragOperationForDraggingInfo:]): new, compares the types on the pasteboard against the types we are currently registered for. Normally the AppKit handles this for us, but since these messages can be forwarded from WebHTMLView, we need to do this comparison ourselves. (-[WebView draggingEntered:]): calls _dragOperationForDraggingInfo: (-[WebView draggingUpdated:]): ditto (-[WebView concludeDragOperation:]): ditto
WebView.subproj/WebViewPrivate.h: define new draggedTypes ivar

WebBrowser:

Removed "Download Image" context menus because images no longer need to be re-downloaded.

Reviewed by rjw.

ContextMenuHandler.m: (-[WebDataSource isDataLocalForURL:]): new category, moved from the WebView category (-[BrowserWebView webView:contextMenuItemsForElement:defaultMenuItems:]): call isDataLocalForURL on WebDataSource (-[BrowserWebView saveFileWrapperForURLKey:menuItem:]): call _fileWrapperForURL on WebDataSource, use the resource to get the MIME type if possible (-[BrowserWebView saveFileWrapperToDownloadsFolderForURLKey:menuItem:]): call _fileWrapperForURL on WebDataSource

3:24 PM Changeset in webkit [6169] by rjw

3 edits in trunk/JavaScriptCore

Added NP_Array implementation.

Changed NP_Boolean to just depend on two static instances, no
space is required for values.

Reviewed by Chris.

bindings/NP_runtime.cpp: (NP_CreateBoolean): (NP_BoolFromBoolean): (arrayAllocate): (arrayDeallocate): (NP_CreateArray): (NP_CreateArrayV): (NP_ObjectAtIndex):
bindings/NP_runtime.h:

Mar 3, 2004:

6:59 PM Changeset in webkit [6168] by mjs

2 edits in branches/Safari-1-2-branch/WebCore

Actually merge the two changes below, they didn't actually get in
last time.

kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject accessibilityIsIgnored]):

4:39 PM Changeset in webkit [6167] by cblu

2 edits in trunk/WebKit

Fixed a typo.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView concludeDragOperation:]):

4:29 PM Changeset in webkit [6166] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3576070>: REGRESSION: web view won't accept drag of webloc file

Reviewed by rjw.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView draggingUpdated:]): if we're not handling the drag, forward this message to the WebView since it may want to handle it (-[WebHTMLView concludeDragOperation:]): if we're not handling the drag, forward this message to the WebView since it may want to handle it

2:56 PM Changeset in webkit [6165] by darin

6 edits
3 deletes in trunk

JavaScriptCore:

Reviewed by Vicki.

English.lproj/InfoPlist.strings: Removed. No need to localize the version and copyright string, and that's all that was in here.
JavaScriptCore.pbproj/project.pbxproj: Removed InfoPlist.strings from build.

WebCore:

Reviewed by Vicki.

English.lproj/InfoPlist.strings: Removed. No need to localize the version and copyright string, and that's all that was in here.
WebCore.pbproj/project.pbxproj: Removed InfoPlist.strings from build.

WebKit:

Reviewed by Vicki.

English.lproj/InfoPlist.strings: Removed. No need to localize the version and copyright string, and that's all that was in here.
WebKit.pbproj/project.pbxproj: Removed InfoPlist.strings from build.

WebBrowser:

Reviewed by Vicki.

English.lproj/InfoPlist.strings: Removed version, copyright message, and CFBundleName. We won't localize any of these (it's named "Safari" worldwide).

2:50 PM Changeset in webkit [6164] by rjw

3 edits in trunk/JavaScriptCore

More 'C' binding implementation. Fleshed out all the
'primitive' data types.

Reviewed by Chris.

bindings/NP_runtime.cpp: (NP_ReleaseObject): (numberAllocate): (stringAllocate): (stringDeallocate): (NP_CreateStringWithUTF8): (NP_CreateStringWithUTF16): (NP_UTF8FromString): (NP_UTF16FromString): (NP_StringLength): (booleanAllocate): (booleanDeallocate): (NP_CreateBoolean): (NP_BoolFromBoolean): (nullAllocate): (nullDeallocate): (NP_GetNull): (undefinedAllocate): (undefinedDeallocate): (NP_GetUndefined):
bindings/NP_runtime.h:

12:04 PM Changeset in webkit [6163] by rjw

3 edits in trunk/JavaScriptCore

More 'C' binding implementation.

Reviewed by Chris.

bindings/NP_runtime.cpp: (identifierEqual): (identifierHash): (getIdentifierDictionary): (NP_IdentifierFromUTF8): (NP_UTF8FromIdentifier): (NP_CreateObject): (NP_ReleaseObject): (NP_IsKindOfClass): (numberCreate): (NP_CreateNumberWithInt): (NP_CreateNumberWithFloat): (NP_CreateNumberWithDouble): (NP_IntFromNumber): (NP_FloatFromNumber): (NP_DoubleFromNumber):
bindings/NP_runtime.h:

10:49 AM Changeset in webkit [6162]

4 copies in tags/Safari-130

This commit was manufactured by cvs2svn to create tag 'Safari-130'.

10:49 AM Changeset in webkit [6161] by kocienda

2 edits in trunk/WebKit

Reviewed by Chris

copy-webcore-files-to-webkit: Fixed up this script so that it does not fail if it is running "non-locally", like for B&I. The idiom is to check these files into WebKit after copying them from WebCore, hence this script is merely a convenience to keep the files in sync.

10:45 AM Changeset in webkit [6160] by hyatt

6 edits in trunk/WebCore

Speed up access to the children arrays of accessibility objects by caching mutable arrays of children
and nulling them out only when the children change.

Reviewed by john

khtml/rendering/render_container.cpp: (RenderContainer::removeChildNode): (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
kwq/KWQAccObject.h:
kwq/KWQAccObject.mm: (-[KWQAccObject detach]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject childrenChanged]): (-[KWQAccObject clearChildren]):
kwq/KWQAccObjectCache.h:
kwq/KWQAccObjectCache.mm: (KWQAccObjectCache::childrenChanged):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed