Timeline



Mar 9, 2004:

5:33 PM Changeset in webkit [6193] by cblu
  • 2 edits in trunk/WebKit

WebKit:

Made web archives use NSPropertyListBinaryFormat_v1_0 instead of NSPropertyListXMLFormat_v1_0 because NSPropertyListBinaryFormat_v1_0 is 3-5 times faster to serialize and parse.

Reviewed by rjw.

  • WebView.subproj/WebResource.m: (+[WebResource _parseWebArchive:mainResource:subresources:]): add timing code (+[WebResource _webArchiveWithMainResource:subresources:]): add timing code, use NSPropertyListBinaryFormat_v1_0

WebBrowser:

Reviewed by rjw.

  • BrowserDocument.m: (-[BrowserDocument mailPageAddress:]): call [WebResource _webArchiveWithMainResource:subresources:] and let it handle the property list serialization
5:26 PM Changeset in webkit [6192] by mjs
  • 3 edits in branches/Safari-1-2-branch/WebCore

Merged the following changes from HEAD for Epiphany:

2004-03-09 David Hyatt <hyatt@apple.com>

Make the AXLinkUIElements attribute always return an array (never
return nil).

  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityAttributeValue:]):

2004-03-09 David Hyatt <hyatt@apple.com>

(1) Change root element in a document to have a role of AXWebArea.
(2) Add support for AXURL to links and children of links.
(3) Add support for AXLinkUIElements to the AXWebArea

Reviewed by john

  • khtml/dom/html_misc.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject roleDescription]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]):
3:46 PM Changeset in webkit [6191] by cblu
  • 31 edits in trunk

Tests:

Updated blot to use new SPI's.

  • Blot/BlotApp.m: (-[BlotApp handleNewMessageEvent:withReplyEvent:]):
  • Blot/BlotDocument.h:
  • Blot/BlotDocument.m: (-[BlotDocument dataRepresentationOfType:]): (-[BlotDocument loadWebArchive:]):
  • TestPlugin/TestPlugin.pbproj/project.pbxproj:

WebCore:

Implemented WebCore side of: <rdar://problem/3577508>: API: web archive related API's

Reviewed by rjw.

  • WebCore-combined.exp:
  • WebCore.exp:
  • kwq/DOM.mm: (+[DOMRange _rangeWithImpl:]): made internally accessible (-[DOMRange _rangeImpl]): ditto
  • kwq/DOMInternal.h:
  • kwq/KWQStringList.h:
  • kwq/KWQStringList.mm: (QStringList::getNSArray): new
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge pasteMarkupString:]): renamed from pasteHTMLString since XML pasting may be possible (-[WebCoreBridge selectedRange]): new (-[WebCoreBridge _documentTypeString]): new (-[WebCoreBridge _stringWithDocumentTypeStringAndMarkupString:]): new (-[WebCoreBridge markupStringFromNode:subresourceURLStrings:]): new, needed for WebKit API's (-[WebCoreBridge markupStringFromRange:subresourceURLStrings:]): new, needed for WebKit API's

WebKit:

Fixed: <rdar://problem/3577508>: API: web archive related API's
Implemented WebKit side of: <rdar://problem/3144033>: ability to save web sites (images and all)

Reviewed by rjw.

  • WebCoreSupport.subproj/WebBridge.h:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge receivedData:textEncodingName:]): renamed to take a textEncodingName instead of data source. The data source argument is only needed for the textEncodingName.
  • WebKit.exp:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _subresourcesDictionary]): new (+[WebDataSource _repTypesAllowImageTypeOmission:]): include "application/x-webarchive"
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDocumentInternal.h:
  • WebView.subproj/WebDocumentPrivate.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame loadWebArchive:]): renamed, code factored out to [WebResource _parseWebArchive:mainResource:subresources:]
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFrameView.m: (+[WebFrameView _viewTypesAllowImageTypeOmission:]): include "application/x-webarchive"
  • WebView.subproj/WebHTMLRepresentation.h:
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentationPrivate dealloc]): (-[WebHTMLRepresentation _isDisplayingWebArchive]): new (-[WebHTMLRepresentation receivedData:withDataSource:]): don't feed data to WebCore if we're displaying a web archive since web archive can't be progressively loaded (-[WebHTMLRepresentation loadWebArchive]): new, feeds web archive data to WebCore (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): call loadWebArchive if necessary (-[WebHTMLRepresentation documentSource]): if displaying a web archive, return the HTML source from within the archive (-[WebHTMLRepresentation _webArchiveWithMarkupString:subresourceURLStrings:]): new (-[WebHTMLRepresentation markupStringFromNode:]): implementation of new API (-[WebHTMLRepresentation markupStringFromRange:]): ditto (-[WebHTMLRepresentation webArchiveFromNode:]): ditto (-[WebHTMLRepresentation webArchiveFromRange:]): ditto
  • WebView.subproj/WebHTMLRepresentationPrivate.h:
  • WebView.subproj/WebHTMLView.m: (+[WebHTMLView _selectionPasteboardTypes]): use renamed WebArchivePboardType (-[WebHTMLView _selectedWebArchive:]): renamed, call renamed methods (-[WebHTMLView _writeSelectionToPasteboard:]): call renamed methods (-[WebHTMLView _haveSelection]): indentation tweak (-[WebHTMLView _canDelete]): ditto (-[WebHTMLView _canPaste]): ditto (-[WebHTMLView _pasteMarkupFromPasteboard:]): renamed, call [WebResource _webArchiveWithMainResource:subresources:] (-[WebHTMLView initWithFrame:]): use renamed WebArchivePboardType (-[WebHTMLView paste:]): call renamed _pasteMarkupFromPasteboard (-[WebHTMLView concludeDragOperation:]): call renamed _pasteMarkupFromPasteboard
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:didReceiveResponse:]): modify the MIME type for web archives since Foundation is not yet web archive aware. This is ifdef'd pre-Tiger code.
  • WebView.subproj/WebResource.h:
  • WebView.subproj/WebResource.m: (+[WebResource _parseWebArchive:mainResource:subresources:]): new (+[WebResource _webArchiveWithMainResource:subresources:]): new
  • WebView.subproj/WebResourcePrivate.h:

WebBrowser:

Fixed: <rdar://problem/3144033>: ability to save web sites (images and all)

Reviewed by john.

  • BrowserDocument.h: added _dataSourceToSave, _fileFormatAccessoryView, _ fileFormatPopUpButton and _isSavingWithSavePanel ivars
  • BrowserDocument.m: (-[BrowserDocument dealloc]): added ASSERTs (-[BrowserDocument dataSourceToSave]): new (-[BrowserDocument canSaveAsWebArchive]): new (-[BrowserDocument isSavingWebArchive]): new (-[BrowserDocument MIMETypeForSaving]): take web archives into account (-[BrowserDocument filenameForSaving]): new (-[BrowserDocument isSavingPlainText]): moved (-[BrowserDocument setDataSourceToSave:]): instead of this being a wrapper method around setFileWrapperToSave:MIMEType:, have this set _dataSourceToSave since we need the data source for web archives to work (-[BrowserDocument saveDocumentTo:]): don't call setFileWrapperToSave:MIMEType: if there is no file wrapper since this case is handled in the above methods (-[BrowserDocument document:didSave:contextInfo:]): added more post-save clean-up (-[BrowserDocument allowedFileTypes]): new (-[BrowserDocument fileFormatPopUpButtonUpdated:]): new (-[BrowserDocument prepareSavePanel:]): attach an accessory view to the save panel if necessary (-[BrowserDocument dataRepresentationOfType:]): handle all cases of saving data (-[BrowserDocument displayName]): rely on the _isSavingWithSavePanel instead of _fileWrapperToSave for choosing a filename (-[BrowserDocument _isDisplayingCompletePage]): new, factored out from validateUserInterfaceItem: (-[BrowserDocument validateUserInterfaceItem:]): for mailPage:, makes sure the representation supports web archives (-[BrowserDocument _mailWebArchive:withApplicationAtPath:]): mail a web archive instead of a property list
(-[BrowserDocument mailPage:]): handle the case where the current page …
(-[BrowserDocument mailPageAddress:]): call renamed _mailWebArchive
  • PreferenceKeys.h: added keys for the pref of saving a web archive or raw source
  • WebBrowser.pbproj/project.pbxproj:
2:12 PM Changeset in webkit [6190] by hyatt
  • 2 edits in trunk/WebCore

Make the AXLinkUIElements attribute always return an array (never return nil).

  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityAttributeValue:]):
1:03 PM Changeset in webkit [6189] by sullivan
  • 6 edits in trunk/WebKit

WebKit:

  • fixed the following bugs: <rdar://problem/3579715>: Going to an error page in back/forward list doesn't work correctly in some cases <rdar://problem/3581031>: REGRESSION (130+): World Leak of WebFrame after trying to load page with unknown scheme

Reviewed by Darin.

  • WebView.subproj/WebDataSourcePrivate.h: renamed setRequest -> adoptRequest
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _URLForHistory]): updated comment (-[WebDataSource __adoptRequest:]): Renamed from setRequest; now takes an NSMutableURLRequest and uses it as-is. (-[WebDataSource _setRequest:]): now saves a mutable copy, instead of relying on the caller to do so. The (only) caller wasn't doing so in all cases, leading to trouble in River City. Also, special-case unreachable URL handling to allow alternate content to replace a URL in a redirect-like way without sending a redirect callback.
  • WebView.subproj/WebFrame.m: (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): renamed after discussion with Richard (was loadPlaceholderHTMLString:baseURL:unreachableURL:) (-[WebFrame _shouldReloadToHandleUnreachableURLFromRequest:]): new helper method, returns YES only if we receive a load request for alternate content from a delegate for an unreachable URL while we are going back or forward. That's a lot of prepositions! (-[WebFrame _loadRequest:subresources:]): if _shouldReloadToHandleUnreachableURLFromRequest: returns YES, change load type to WebFrameLoadTypeReload so b/f list is preserved appropriately. (-[WebFrame _transitionToCommitted:]): Update currentItem in the unreachableURL case. (-[WebFrame _isLoadComplete]): Don't reset b/f list before calling provisionalLoadDidFail delegate; instead, determine where to reset b/f list beforehand, and then actually reset list afterwards only if we didn't start an alternate content load in the delegate. Also, set new boolean ivar so we know when we're processing a provisionalLoadDidFail delegate callback. (-[WebFrame _loadItem:withLoadType:]): don't make extra copy before calling adoptRequest; just pass it the one we made here. (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): If we're loading alternate content for an unreachableURL, don't ask the decision listener, just do it. (This avoids problem with nested calls to checking the navigation policy that led to a WebFrame leak, and is conceptually the right thing to do also.) Also added some asserts that helped me track down the WebFrame leak. Set new boolean ivar so we know when we're processing a navigation policy delegate decision. (-[WebFrame _currentBackForwardListItemToResetTo]): new method, replaces _resetBackForwardListToCurrent. Does the same test as the latter but returns a boolean rather than actually resetting. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): save dataSource in a local var before calling stopLoading, and use it for _setProvisionalDataSource, because otherwise stopLoading was clobbering the dataSource for an unreachable URL handling case.
  • WebView.subproj/WebFramePrivate.h: two new boolean ivars
  • WebView.subproj/WebView.m: (+[WebView _canHandleRequest:]): return YES when we're loading alternate content for an unreachable URL

WebBrowser:

Reviewed by Darin.

  • BrowserWebController.m: (-[BrowserWebView showErrorPageForURL:withTitle:message:]): update call to renamed method
10:50 AM Changeset in webkit [6188] by hyatt
  • 3 edits in trunk/WebCore

(1) Change root element in a document to have a role of AXWebArea.
(2) Add support for AXURL to links and children of links.
(3) Add support for AXLinkUIElements to the AXWebArea

Reviewed by john

  • khtml/dom/html_misc.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject roleDescription]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]):
6:24 AM Changeset in webkit [6187] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by nobody.

  • kwq/KWQKURL.mm: (KURL::KURL): Fixed broken build by removing wayward "break" statement.

Mar 8, 2004:

4:14 PM Changeset in webkit [6186] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3554876>: REGRESSION (100-125): cannot upload file if path contains non-ASCII characters
  • kwq/KWQKURL.mm: Remove Colon constant so we can fit in 8 bits again. (KURL::KURL): Rewrite so we don't need isSchemeCharOrColon.
3:46 PM Changeset in webkit [6185]
  • 3 copies in tags/Safari-131

This commit was manufactured by cvs2svn to create tag 'Safari-131'.

3:46 PM Changeset in webkit [6184] by kocienda
  • 4 edits in trunk

Submitting Safari-131

3:46 PM Changeset in webkit [6183] by kocienda
  • 2 edits in trunk/WebKit

2004-03-08 Ken Kocienda <kocienda@apple.com>

Reviewed by Darin

  • WebKit.pbproj/project.pbxproj: Added CFBundleName to Info.plist
3:45 PM Changeset in webkit [6182] by kocienda
  • 2 edits in trunk/WebCore

2004-03-08 Ken Kocienda <kocienda@apple.com>

Reviewed by Darin

  • WebCore.pbproj/project.pbxproj: Added CFBundleName to Info.plist.

Mar 5, 2004:

5:21 PM Changeset in webkit [6181] by hyatt
  • 2 adds in trunk/LayoutTests/fast/css-generated-content

Add layout test for first-letter bug.

5:19 PM Changeset in webkit [6180] by hyatt
  • 2 edits in trunk/WebCore

Fix for first-line inheritance problem caused by incorrectly inheriting first-line into floating
blocks.

Reviewed by kocienda

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::firstLineBlock):
3:34 PM Changeset in webkit [6179] by kocienda
  • 1 edit
    1 add in trunk/WebCore

Reviewed by me.

Forgot to add this when I checked in last time.

  • ForwardingHeaders/css/css_computedstyle.h: Added.
3:01 PM Changeset in webkit [6178] by kocienda
  • 10 edits
    2 adds in trunk/WebCore

Reviewed by Dave.

Added initial support for retrieving the computed
style of document elements.

  • WebCore.pbproj/project.pbxproj:
  • khtml/css/css_computedstyle.cpp: Added. (DOM::valueForLength): Helper to turn a khtml::Length into a computed value string. (DOM::stringForBorderStyle): Helper to turn an EBorderStyle into a computed value string. (DOM::stringForTextAlign): Helper to turn an ETextAlign into a computed value string. (DOM::CSSComputedStyleDeclarationImpl::CSSComputedStyleDeclarationImpl): New function. (DOM::CSSComputedStyleDeclarationImpl::~CSSComputedStyleDeclarationImpl): Ditto. (DOM::CSSComputedStyleDeclarationImpl::cssText): Ditto. (DOM::CSSComputedStyleDeclarationImpl::setCssText): Ditto. (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Ditto. (DOM::CSSComputedStyleDeclarationImpl::getPropertyValue): Ditto. (DOM::CSSComputedStyleDeclarationImpl::getPropertyPriority): Ditto. (DOM::CSSComputedStyleDeclarationImpl::removeProperty): Ditto. (DOM::CSSComputedStyleDeclarationImpl::setProperty): Ditto. (DOM::CSSComputedStyleDeclarationImpl::setLengthProperty): Ditto. (DOM::CSSComputedStyleDeclarationImpl::item): Ditto. (DOM::CSSComputedStyleDeclarationImpl::property): Ditto.
  • khtml/css/css_computedstyle.h: Added.
  • khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::cssText): Fixed some formatting of Rect. Added suppoprt for rgba colors.
  • khtml/css/css_valueimpl.h: (DOM::CSSStyleDeclarationImpl::node):
  • khtml/ecma/kjs_css.cpp: (KJS::getDOMCSSStyleDeclaration):
  • khtml/ecma/kjs_dom.cpp: (DOMDocument::getValueProperty): defaultView is a property, used to be a function, which was wrong. Fixed. (DOMDocumentProtoFunc::tryCall): Ditto.
  • khtml/ecma/kjs_dom.lut.h: (KJS::): Regenerated file.
  • khtml/misc/khtmllayout.h: (khtml::Length::length): Added an accessor to the value, to promote better coding style, rather than peeking and poking the value directly.
  • khtml/rendering/render_style.h: (khtml::RenderStyle::borderLeftWidth): BHIDDEN also should be treated like BNONE when it comes to returning a zero value. Now it is. (khtml::RenderStyle::borderRightWidth): Ditto. (khtml::RenderStyle::borderTopWidth): Ditto. (khtml::RenderStyle::borderBottomWidth): Ditto. (khtml::RenderStyle::outlineWidth): Ditto. (khtml::RenderStyle::outlineOffset): Ditto.
  • khtml/xml/dom2_viewsimpl.cpp: (AbstractViewImpl::getComputedStyle): Added an implementation for this formerly stubbed out function.
1:27 PM Changeset in webkit [6177] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3560132>: REGRESSION: Safari crashed in -[NSPasteboard setData:forType:] dragging a map out of Mapquest.com

Reviewed by john.

  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:URL:title:fileWrapper:HTMLString:]): declare the pboard types by calling _web_writeURL:::: before calling setData::
11:02 AM Changeset in webkit [6176] by sullivan
  • 9 edits in trunk/WebKit

WebKit:

First cut at WebKit support for showing error pages for unreachable URLs.
This doesn't work quite right with the back/forward list yet, but is
good enough for demos.

Reviewed by Darin.

  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate didReceiveResponse:]): use new _webDataRequextExternalURL to share code
  • WebView.subproj/WebDataProtocol.h: Three new methods (all internal to WebKit): -[NSURLRequest _webDataRequestUnreachableURL], -[NSURLRequest _webDataRequestExternalURL], -[NSURLRequest _webDataRequestSetUnreachableURL]
  • WebView.subproj/WebDataProtocol.m: new unreachableURL field of WebDataRequestParameters (-[WebDataRequestParameters copyWithZone:]): copy new field (-[WebDataRequestParameters dealloc]): release new field (-[NSURLRequest _webDataRequestUnreachableURL]): read new field (-[NSURLRequest _webDataRequestExternalURL]): new method, returns baseURL or "about:blank" for webdata protocol requests. This was done in multiple places previously. (-[NSURLRequest _webDataRequestExternalRequest]): now calls _webDataRequestExternalURL to share code (-[NSMutableURLRequest _webDataRequestSetUnreachableURL:]): write new field
  • WebView.subproj/WebDataSource.m: (-[WebDataSource unreachableURL]): new method, might become API; returns the unreachable URL, if any, for which this datasource holds placeholder content (-[WebDataSource _URLForHistory]): new method, returns the URL to be stored in History for this dataSource. This returns nil for run-of-the-mill WebDataProtocol URLs (replacing code elsewhere that checked for this case) but returns the unreachableURL for the case where this datasource holds placeholder content. (-[WebDataSource _setTitle:]): now calls _URLForHistory
  • WebView.subproj/WebDataSourcePrivate.h: added unreachableURL in the should-become-API section, and _URLForHistory elsewhere
  • WebView.subproj/WebFrame.m: (-[WebFrame loadPlaceholderHTMLString:baseURL:unreachableURL:]): new should-become-API method for displaying an error page for an unreachable URL (-[WebFrame loadPropertyList:]): updated to pass nil for unreachableURL (-[WebFrame _webDataRequestForData:MIMEType:textEncodingName:baseURL:unreachableURL:]): added unreachableURL parameter, which gets set on the data request (-[WebFrame _addBackForwardItemClippedAtTarget:]): use _URLForHistory instead of just checking for WebDataProtocol (-[WebFrame _createItem:]): use unreachableURL if there is one (-[WebFrame _transitionToCommitted:]): use _URLForHistory instead of just checking for WebDataProtocol (-[WebFrame _isLoadComplete]): check whether a new load has started in the delegate callback and if so, don't reset the loading state here (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): added unreachableURL parameter, which gets passed through (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): send nil unreachableURL parameter (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): new bottleneck method for loadHTMLString:baseURL: and loadPlaceholderHTMLString:baseURL:unreachableURL:; this is the guts of loadHTMLString:baseURL: with the new unreachableURL parameter passed through (-[WebFrame loadHTMLString:baseURL:]): now calls new bottleneck method
  • WebView.subproj/WebFramePrivate.h: added loadPlaceholderString:baseURL:unreachableURL: to should-be-API section; added unreachableURL parameter to _webDataRequestForData:MIMEType:textEncodingName:baseURL:

WebBrowser:

First cut at WebBrowser support for showing error pages for unreachable URLs.
This doesn't work quite right with the back/forward list yet, but is
good enough for demos. The old sheet-using code remains intact, and there's
a menu item in the Debug menu to try the new way (old way is still default
for now).

Reviewed by Darin.

  • PreferenceKeys.h: added DebugDisplayErrorsAsPagesPreferenceKey; also deleted a couple of unused old preference keys.
  • BrowserWebController.h: added showErrorPageForURL:withTitle:message:
  • BrowserWebController.m: (-[BrowserWebView webView:unableToImplementPolicyWithError:frame:]): use showErrorPageForURL:... if the preference is set that way (-[BrowserWebView errorPageHTMLWithTitle:message:]): new method, returns an HTML string for the error page. This will eventually be done reading resources from disk no doubt, but for now we just display a simple page that has the same text as the sheet. (-[BrowserWebView showErrorPageForURL:withTitle:message:]): new method, uses new loadPlaceholderHTMLString:baseURL:unreachableURL: to put up an error page in the webview (-[BrowserWebView expectedOrCurrentURL]): use unreachableURL if there is one
  • Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): add menu item "Show Page Load Errors Inline" (-[NSApplication validate_toggleDisplayLoadErrorsAsPages:]): new method, sets the checkmark on the new menu item appropriately (-[NSApplication toggleDisplayLoadErrorsAsPages:]): new method, toggles the state of the preference
  • LoadProgressMonitor.m: (-[LoadProgressMonitor _createProgressEntryWithRequest:dataSource:]): use unreachableURL if there is one (-[LoadProgressMonitor webView:resource:didReceiveResponse:fromDataSource:]): ditto
  • LocationChangeError.m: (-[LocationChangeHandler displayOrRememberLocationChangeError:forDataSource:]): use showErrorPage:... if the preference is set that way
  • LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]): use previously-fetched local variable "frame" rather than getting it from the dataSource again. This is not only trivially faster in the normal case, but also avoids a bug when the code earlier in this method triggers another page load (as in the showErrorPage:... case).
  • English.lproj/Localizable.strings: updated for these changes
10:20 AM Changeset in webkit [6175] by kocienda
  • 2 edits in trunk/WebCore

Change by Darin. Reviewed by me.

  • kwq/DOM.mm: Fixed the following functions to deal with casting objects derived from NodeImpl back and forth to NodeImpl given that the derived classes use multiple inheritance. (-[DOMDocument _documentImpl]): (-[DOMCharacterData _characterDataImpl]): (-[DOMAttr _attrImpl]): (-[DOMElement _elementImpl]): (-[DOMText _textImpl]): (-[DOMDocumentType _documentTypeImpl]): (-[DOMNotation _notationImpl]): (-[DOMEntity _entityImpl]): (-[DOMProcessingInstruction _processingInstructionImpl]):
Note: See TracTimeline for information about the timeline view.