Context Navigation

← Previous Period
Next Period →

Timeline

Mar 10, 2004:

6:07 PM Changeset in webkit [6202] by hyatt

3 edits in trunk/WebCore

Fix for 3584646, AxWebArea should encompass all children (its AxSize should).

Reviewed by mjs

khtml/rendering/render_canvas.cpp: (RenderCanvas::absoluteRects):
khtml/rendering/render_canvas.h:

2:58 PM Changeset in webkit [6201] by rjw

1 edit in trunk/JavaScriptCore/bindings/runtime.cpp

Fixed broken build.

2:25 PM Changeset in webkit [6200] by rjw

5 edits in trunk/JavaScriptCore

Made changes to support new asychronous approach to calls from
plugin to JavaScript

Reviewed by Chris.

bindings/NP_jsobject.cpp: (NP_Call): (NP_Evaluate): (NP_GetProperty): (NP_ToString): (NP_GetPropertyAtIndex):
bindings/NP_runtime.h:
bindings/make_testbindings:
bindings/runtime.cpp: (Instance::createBindingForLanguageInstance):

1:51 PM Changeset in webkit [6199] by cblu

3 edits in trunk/WebCore

Fixed: INPUT images are not part of web archives.

Reviewed by rjw.

khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::isSubresourceURLAttribute):
khtml/html/html_formimpl.h:

1:50 PM Changeset in webkit [6198] by cblu

5 edits in trunk/WebKit

Made dragging of web archives work.

Reviewed by rjw.

English.lproj/StringsNotToBeLocalized.txt: updated
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:didReceiveResponse:]): added a FIXME about working around old Foundations that don't know about web archive files
WebView.subproj/WebView.m: (+[WebView canShowFile:]): tweak (+[WebView suggestedFileExtensionForMIMEType:]): tweak (+[WebView _MIMETypeForFile:]): handle web archive files since Foundation may be too old to know about them

1:50 PM Changeset in webkit [6197] by rjw

2 edits in trunk/JavaScriptCore

Updated header to include proposed changes from
plugin-futures list. Calls from plugin to JavaScript
are now asynchronous.

Reviewed by Chris.

bindings/NP_runtime.h:

4:08 AM Changeset in webkit [6196]

13 copies
2 deletes in tags/WebCore-125~4

This commit was manufactured by cvs2svn to create tag
'WebCore-125~4'.

4:08 AM Changeset in webkit [6195] by mjs

2 edits in branches/Safari-1-2-branch/WebCore

WebCore-125.4

3:55 AM Changeset in webkit [6194] by mjs

2 edits in branches/Safari-1-2-branch/WebCore

Fix branch so it builds.

khtml/ecma/kjs_html.h:

Mar 9, 2004:

5:33 PM Changeset in webkit [6193] by cblu

2 edits in trunk/WebKit

WebKit:

Made web archives use NSPropertyListBinaryFormat_v1_0 instead of NSPropertyListXMLFormat_v1_0 because NSPropertyListBinaryFormat_v1_0 is 3-5 times faster to serialize and parse.

Reviewed by rjw.

WebView.subproj/WebResource.m: (+[WebResource _parseWebArchive:mainResource:subresources:]): add timing code (+[WebResource _webArchiveWithMainResource:subresources:]): add timing code, use NSPropertyListBinaryFormat_v1_0

WebBrowser:

Reviewed by rjw.

BrowserDocument.m: (-[BrowserDocument mailPageAddress:]): call [WebResource _webArchiveWithMainResource:subresources:] and let it handle the property list serialization

5:26 PM Changeset in webkit [6192] by mjs

3 edits in branches/Safari-1-2-branch/WebCore

Merged the following changes from HEAD for Epiphany:

2004-03-09 David Hyatt <hyatt@apple.com>

Make the AXLinkUIElements attribute always return an array (never
return nil).

kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityAttributeValue:]):

2004-03-09 David Hyatt <hyatt@apple.com>

(1) Change root element in a document to have a role of AXWebArea.
(2) Add support for AXURL to links and children of links.
(3) Add support for AXLinkUIElements to the AXWebArea

Reviewed by john

khtml/dom/html_misc.h:
kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject roleDescription]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]):

3:46 PM Changeset in webkit [6191] by cblu

31 edits in trunk

Tests:

Updated blot to use new SPI's.

Blot/BlotApp.m: (-[BlotApp handleNewMessageEvent:withReplyEvent:]):
Blot/BlotDocument.h:
Blot/BlotDocument.m: (-[BlotDocument dataRepresentationOfType:]): (-[BlotDocument loadWebArchive:]):
TestPlugin/TestPlugin.pbproj/project.pbxproj:

WebCore:

Implemented WebCore side of: <rdar://problem/3577508>: API: web archive related API's

Reviewed by rjw.

WebCore-combined.exp:
WebCore.exp:
kwq/DOM.mm: (+[DOMRange _rangeWithImpl:]): made internally accessible (-[DOMRange _rangeImpl]): ditto
kwq/DOMInternal.h:
kwq/KWQStringList.h:
kwq/KWQStringList.mm: (QStringList::getNSArray): new
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge pasteMarkupString:]): renamed from pasteHTMLString since XML pasting may be possible (-[WebCoreBridge selectedRange]): new (-[WebCoreBridge _documentTypeString]): new (-[WebCoreBridge _stringWithDocumentTypeStringAndMarkupString:]): new (-[WebCoreBridge markupStringFromNode:subresourceURLStrings:]): new, needed for WebKit API's (-[WebCoreBridge markupStringFromRange:subresourceURLStrings:]): new, needed for WebKit API's

WebKit:

Fixed: <rdar://problem/3577508>: API: web archive related API's
Implemented WebKit side of: <rdar://problem/3144033>: ability to save web sites (images and all)

Reviewed by rjw.

WebCoreSupport.subproj/WebBridge.h:
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge receivedData:textEncodingName:]): renamed to take a textEncodingName instead of data source. The data source argument is only needed for the textEncodingName.
WebKit.exp:
WebView.subproj/WebDataSource.m: (-[WebDataSource _subresourcesDictionary]): new (+[WebDataSource _repTypesAllowImageTypeOmission:]): include "application/x-webarchive"
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDocumentInternal.h:
WebView.subproj/WebDocumentPrivate.h:
WebView.subproj/WebFrame.m: (-[WebFrame loadWebArchive:]): renamed, code factored out to [WebResource _parseWebArchive:mainResource:subresources:]
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebFrameView.m: (+[WebFrameView _viewTypesAllowImageTypeOmission:]): include "application/x-webarchive"
WebView.subproj/WebHTMLRepresentation.h:
WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentationPrivate dealloc]): (-[WebHTMLRepresentation _isDisplayingWebArchive]): new (-[WebHTMLRepresentation receivedData:withDataSource:]): don't feed data to WebCore if we're displaying a web archive since web archive can't be progressively loaded (-[WebHTMLRepresentation loadWebArchive]): new, feeds web archive data to WebCore (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): call loadWebArchive if necessary (-[WebHTMLRepresentation documentSource]): if displaying a web archive, return the HTML source from within the archive (-[WebHTMLRepresentation _webArchiveWithMarkupString:subresourceURLStrings:]): new (-[WebHTMLRepresentation markupStringFromNode:]): implementation of new API (-[WebHTMLRepresentation markupStringFromRange:]): ditto (-[WebHTMLRepresentation webArchiveFromNode:]): ditto (-[WebHTMLRepresentation webArchiveFromRange:]): ditto
WebView.subproj/WebHTMLRepresentationPrivate.h:
WebView.subproj/WebHTMLView.m: (+[WebHTMLView _selectionPasteboardTypes]): use renamed WebArchivePboardType (-[WebHTMLView _selectedWebArchive:]): renamed, call renamed methods (-[WebHTMLView _writeSelectionToPasteboard:]): call renamed methods (-[WebHTMLView _haveSelection]): indentation tweak (-[WebHTMLView _canDelete]): ditto (-[WebHTMLView _canPaste]): ditto (-[WebHTMLView _pasteMarkupFromPasteboard:]): renamed, call [WebResource _webArchiveWithMainResource:subresources:] (-[WebHTMLView initWithFrame:]): use renamed WebArchivePboardType (-[WebHTMLView paste:]): call renamed _pasteMarkupFromPasteboard (-[WebHTMLView concludeDragOperation:]): call renamed _pasteMarkupFromPasteboard
WebView.subproj/WebHTMLViewPrivate.h:
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:didReceiveResponse:]): modify the MIME type for web archives since Foundation is not yet web archive aware. This is ifdef'd pre-Tiger code.
WebView.subproj/WebResource.h:
WebView.subproj/WebResource.m: (+[WebResource _parseWebArchive:mainResource:subresources:]): new (+[WebResource _webArchiveWithMainResource:subresources:]): new
WebView.subproj/WebResourcePrivate.h:

WebBrowser:

Fixed: <rdar://problem/3144033>: ability to save web sites (images and all)

Reviewed by john.

BrowserDocument.h: added _dataSourceToSave, _fileFormatAccessoryView, _ fileFormatPopUpButton and _isSavingWithSavePanel ivars
BrowserDocument.m: (-[BrowserDocument dealloc]): added ASSERTs (-[BrowserDocument dataSourceToSave]): new (-[BrowserDocument canSaveAsWebArchive]): new (-[BrowserDocument isSavingWebArchive]): new (-[BrowserDocument MIMETypeForSaving]): take web archives into account (-[BrowserDocument filenameForSaving]): new (-[BrowserDocument isSavingPlainText]): moved (-[BrowserDocument setDataSourceToSave:]): instead of this being a wrapper method around setFileWrapperToSave:MIMEType:, have this set _dataSourceToSave since we need the data source for web archives to work (-[BrowserDocument saveDocumentTo:]): don't call setFileWrapperToSave:MIMEType: if there is no file wrapper since this case is handled in the above methods (-[BrowserDocument document:didSave:contextInfo:]): added more post-save clean-up (-[BrowserDocument allowedFileTypes]): new (-[BrowserDocument fileFormatPopUpButtonUpdated:]): new (-[BrowserDocument prepareSavePanel:]): attach an accessory view to the save panel if necessary (-[BrowserDocument dataRepresentationOfType:]): handle all cases of saving data (-[BrowserDocument displayName]): rely on the _isSavingWithSavePanel instead of _fileWrapperToSave for choosing a filename (-[BrowserDocument _isDisplayingCompletePage]): new, factored out from validateUserInterfaceItem: (-[BrowserDocument validateUserInterfaceItem:]): for mailPage:, makes sure the representation supports web archives (-[BrowserDocument _mailWebArchive:withApplicationAtPath:]): mail a web archive instead of a property list

(-[BrowserDocument mailPage:]): handle the case where the current page …

(-[BrowserDocument mailPageAddress:]): call renamed _mailWebArchive

PreferenceKeys.h: added keys for the pref of saving a web archive or raw source
WebBrowser.pbproj/project.pbxproj:

2:12 PM Changeset in webkit [6190] by hyatt

2 edits in trunk/WebCore

Make the AXLinkUIElements attribute always return an array (never return nil).

kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityAttributeValue:]):

1:03 PM Changeset in webkit [6189] by sullivan

6 edits in trunk/WebKit

WebKit:

fixed the following bugs: <rdar://problem/3579715>: Going to an error page in back/forward list doesn't work correctly in some cases <rdar://problem/3581031>: REGRESSION (130+): World Leak of WebFrame after trying to load page with unknown scheme

Reviewed by Darin.

WebView.subproj/WebDataSourcePrivate.h: renamed setRequest -> adoptRequest
WebView.subproj/WebDataSource.m: (-[WebDataSource _URLForHistory]): updated comment (-[WebDataSource __adoptRequest:]): Renamed from setRequest; now takes an NSMutableURLRequest and uses it as-is. (-[WebDataSource _setRequest:]): now saves a mutable copy, instead of relying on the caller to do so. The (only) caller wasn't doing so in all cases, leading to trouble in River City. Also, special-case unreachable URL handling to allow alternate content to replace a URL in a redirect-like way without sending a redirect callback.

WebView.subproj/WebFrame.m: (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): renamed after discussion with Richard (was loadPlaceholderHTMLString:baseURL:unreachableURL:) (-[WebFrame _shouldReloadToHandleUnreachableURLFromRequest:]): new helper method, returns YES only if we receive a load request for alternate content from a delegate for an unreachable URL while we are going back or forward. That's a lot of prepositions! (-[WebFrame _loadRequest:subresources:]): if _shouldReloadToHandleUnreachableURLFromRequest: returns YES, change load type to WebFrameLoadTypeReload so b/f list is preserved appropriately. (-[WebFrame _transitionToCommitted:]): Update currentItem in the unreachableURL case. (-[WebFrame _isLoadComplete]): Don't reset b/f list before calling provisionalLoadDidFail delegate; instead, determine where to reset b/f list beforehand, and then actually reset list afterwards only if we didn't start an alternate content load in the delegate. Also, set new boolean ivar so we know when we're processing a provisionalLoadDidFail delegate callback. (-[WebFrame _loadItem:withLoadType:]): don't make extra copy before calling adoptRequest; just pass it the one we made here. (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): If we're loading alternate content for an unreachableURL, don't ask the decision listener, just do it. (This avoids problem with nested calls to checking the navigation policy that led to a WebFrame leak, and is conceptually the right thing to do also.) Also added some asserts that helped me track down the WebFrame leak. Set new boolean ivar so we know when we're processing a navigation policy delegate decision. (-[WebFrame _currentBackForwardListItemToResetTo]): new method, replaces _resetBackForwardListToCurrent. Does the same test as the latter but returns a boolean rather than actually resetting. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): save dataSource in a local var before calling stopLoading, and use it for _setProvisionalDataSource, because otherwise stopLoading was clobbering the dataSource for an unreachable URL handling case.

WebView.subproj/WebFramePrivate.h: two new boolean ivars

WebView.subproj/WebView.m: (+[WebView _canHandleRequest:]): return YES when we're loading alternate content for an unreachable URL

WebBrowser:

Reviewed by Darin.

BrowserWebController.m: (-[BrowserWebView showErrorPageForURL:withTitle:message:]): update call to renamed method

10:50 AM Changeset in webkit [6188] by hyatt

3 edits in trunk/WebCore

(1) Change root element in a document to have a role of AXWebArea.
(2) Add support for AXURL to links and children of links.
(3) Add support for AXLinkUIElements to the AXWebArea

Reviewed by john

khtml/dom/html_misc.h:
kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject roleDescription]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]):

6:24 AM Changeset in webkit [6187] by sullivan