Timeline



Mar 12, 2004:

5:04 PM Changeset in webkit [6222] by darin
  • 2 edits in trunk/WebKit

Reviewed by Ken.

  • fixed <rdar://problem/3433887>: copied &nbsp; characters remain non-breaking spaces; other browsers give normal spaces
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _writeSelectionToPasteboard:]): Convert non-breaking spaces to the normal kind in the plain text part of the pasteboard.
1:59 PM Changeset in webkit [6221] by cblu
  • 5 edits in trunk/WebCore

Implemented ~25% of the HTML DOM API.

Reviewed by kocienda.

(DOM::HTMLElement::HTMLElement):

  • kwq/DOM.mm:
  • kwq/DOMInternal.h:
  • kwq/HTMLDOM.h:
  • kwq/HTMLDOM.mm: (-[HTMLCollection _initWithCollectionImpl:]): (+[HTMLCollection _collectionWithImpl:]): (-[HTMLCollection _collectionImpl]): (-[HTMLCollection length]): (-[HTMLCollection item:]): (-[HTMLCollection namedItem:]): (-[HTMLElement _initWithElementImpl:]): (+[HTMLElement _elementWithImpl:]): (-[HTMLElement _HTMLElementImpl]): (-[HTMLElement idName]): (-[HTMLElement setIdName:]): (-[HTMLElement title]): (-[HTMLElement setTitle:]): (-[HTMLElement lang]): (-[HTMLElement setLang:]): (-[HTMLElement dir]): (-[HTMLElement setDir:]): (-[HTMLElement className]): (-[HTMLElement setClassName:]): (-[HTMLDocument _HTMLDocumentImpl]): (-[HTMLDocument title]): (-[HTMLDocument setTitle:]): (-[HTMLDocument referrer]): (-[HTMLDocument domain]): (-[HTMLDocument URL]): (-[HTMLDocument body]): (-[HTMLDocument images]): (-[HTMLDocument applets]): (-[HTMLDocument links]): (-[HTMLDocument forms]): (-[HTMLDocument anchors]): (-[HTMLDocument setBody:]): (-[HTMLDocument cookie]): (-[HTMLDocument setCookie:]): (-[HTMLDocument open]): (-[HTMLDocument close]): (-[HTMLDocument write:]): (-[HTMLDocument writeln:]): (-[HTMLDocument getElementById:]): (-[HTMLDocument getElementsByName:]): (-[HTMLHtmlElement _HTMLHtmlElementImpl]): (-[HTMLHtmlElement version]): (-[HTMLHtmlElement setVersion:]): (-[HTMLHeadElement _headElementImpl]): (-[HTMLHeadElement profile]): (-[HTMLHeadElement setProfile:]): (-[HTMLLinkElement _linkElementImpl]): (-[HTMLLinkElement disabled]): (-[HTMLLinkElement setDisabled:]): (-[HTMLLinkElement charset]): (-[HTMLLinkElement setCharset:]): (-[HTMLLinkElement href]): (-[HTMLLinkElement setHref:]): (-[HTMLLinkElement hreflang]): (-[HTMLLinkElement setHreflang:]): (-[HTMLLinkElement media]): (-[HTMLLinkElement setMedia:]): (-[HTMLLinkElement rel]): (-[HTMLLinkElement setRel:]): (-[HTMLLinkElement rev]): (-[HTMLLinkElement setRev:]): (-[HTMLLinkElement target]): (-[HTMLLinkElement setTarget:]): (-[HTMLLinkElement type]): (-[HTMLLinkElement setType:]): (-[HTMLTitleElement _titleElementImpl]): (-[HTMLTitleElement text]): (-[HTMLTitleElement setText:]): (-[HTMLMetaElement _metaElementImpl]): (-[HTMLMetaElement content]): (-[HTMLMetaElement setContent:]): (-[HTMLMetaElement httpEquiv]): (-[HTMLMetaElement setHttpEquiv:]): (-[HTMLMetaElement name]): (-[HTMLMetaElement setName:]): (-[HTMLMetaElement scheme]): (-[HTMLMetaElement setScheme:]): (-[HTMLBaseElement _baseElementImpl]): (-[HTMLBaseElement href]): (-[HTMLBaseElement setHref:]): (-[HTMLBaseElement target]): (-[HTMLBaseElement setTarget:]): (-[HTMLStyleElement _styleElementImpl]): (-[HTMLStyleElement disabled]): (-[HTMLStyleElement setDisabled:]): (-[HTMLStyleElement media]): (-[HTMLStyleElement setMedia:]): (-[HTMLStyleElement type]): (-[HTMLStyleElement setType:]): (-[HTMLBodyElement _bodyElementImpl]): (-[HTMLBodyElement aLink]): (-[HTMLBodyElement setALink:]): (-[HTMLBodyElement background]): (-[HTMLBodyElement setBackground:]): (-[HTMLBodyElement bgColor]): (-[HTMLBodyElement setBgColor:]): (-[HTMLBodyElement link]): (-[HTMLBodyElement setLink:]): (-[HTMLBodyElement text]): (-[HTMLBodyElement setText:]): (-[HTMLBodyElement vLink]): (-[HTMLBodyElement setVLink:]):
1:21 PM Changeset in webkit [6220] by hyatt
  • 2 edits in trunk/WebCore

Fix for problem when undoing the deletion of a word in edit mode.

Reviewed by kocienda

  • khtml/rendering/render_text.cpp: (RenderText::setTextWithOffset):
11:27 AM Changeset in webkit [6219] by kocienda
  • 14 edits in trunk

WebCore:

Reviewed by Chris

  • khtml/khtml_part.cpp: (KHTMLPart::handleMouseMoveEventSelection): Clear the selection's "modify bias" since the user clicked, and is therefore no longer extending the selection with arrow keys.
  • khtml/khtml_selection.cpp: (KHTMLSelection::KHTMLSelection): Add new m_modifyBiasSet flag. (KHTMLSelection::init): Set the flag to false by default. (KHTMLSelection::operator=): Copy over the value of the new m_modifyBiasSet flag. (KHTMLSelection::modify): Set the flag if extending the selection and set the base and extent nodes based on the movement direction requested.
  • khtml/khtml_selection.h:
  • kwq/WebCoreBridge.h: See below.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge rangeByAlteringCurrentSelection:direction:granularity:]): This method is used by the WebKit side in response to requests to change the selection using the arrow keys. It used to be called rangeByModifyingRange:alteration:direction:granularity: but I changed it to this new format since I explicitly want to use the current selection, and not some arbitrarily passed in selection. This helps to maintain the "modify bias" correctly. (-[WebCoreBridge alterCurrentSelection:direction:granularity:]): New method. A command to alter the current selection as given. Again, applying the command to the current selection, rather than just setting the selection to a new one, helps to maintain the "modify bias" correctly.

WebKit:

Reviewed by Chris

  • WebView.subproj/WebView.m: (-[WebView _alterCurrentSelection:direction:granularity:]): Changed name from _alterSelection:direction:granularity: to give a little extra clarity. Also, the body calls through to renamed rangeByAlteringCurrentSelection:direction:granularity: in WebCore. (-[WebView moveRight:]): Now calls renamed _alterCurrentSelection:direction:granularity:. (-[WebView moveRightAndModifySelection:]): Ditto. (-[WebView moveLeft:]): Ditto. (-[WebView moveLeftAndModifySelection:]): Ditto.
11:20 AM Changeset in webkit [6218] by sullivan
  • 1 edit in trunk/WebKit/DOM.subproj/DOM.h
  • fixed the following bugs: <rdar://problem/3584028>: Consider disallowing "View Source" for inline error pages <rdar://problem/3584029>: "View Source" for inline error pages shows URL of "about:blank" <rdar://problem/3584272>: Location field should be focused after a page-load error page is displayed <rdar://problem/3586611>: REGRESSION (128): After option-pressing b/f button, selecting a menu item downloads it
  • simplified some code

Reviewed by Chris.

  • BrowserDocument.h:
  • BrowserDocument.m: removed goBack: and goForward:; all callers now use these methods on BrowserWindowController instead. (-[BrowserDocument goToItemInBackOrForwardMenu:]): renamed from goToItem: for clarity, now ignores the Option key to avoid downloading when the user pressed Option to see URLs in the menu (-[BrowserDocument _addItem:toMenu:]): updated for name change (-[BrowserDocument canViewSource]): new method, extracted from validateUserInterfaceItem. Now also returns NO if the current page is an error page. (-[BrowserDocument validateUserInterfaceItem:]): now calls extracted method (-[BrowserDocument viewSource:]): now bails out early if canViewSource returns NO
  • BrowserWindowController.m: (-[BrowserWindowController webFrameLoadCommitted:]): if we're showing an error page now, move focus to location field (rather than webview as in the normal case)
  • Test/PageLoadTestRunner.m: (-[PageLoadTestRunner goBack]): call through browserWindowController; this was the only remaining caller of -[BrowserDocument goBack:] or -[BrowserDocument goForward:]

Mar 11, 2004:

6:26 PM Changeset in webkit [6217]
  • 15 copies
    2 deletes in tags/WebCore-125~5

This commit was manufactured by cvs2svn to create tag
'WebCore-125~5'.

6:26 PM Changeset in webkit [6216] by mjs
  • 2 edits in branches/Safari-1-2-branch/WebCore

WebCore-125.5

5:58 PM Changeset in webkit [6215] by rjw
  • 3 edits in trunk/WebKit

Workaround for 3585644. Force the window number of the
mouse moved event to be correct.

Reviewed by Chris.

  • Carbon.subproj/CarbonWindowFrame.m:
  • Carbon.subproj/HIWebView.m: (MouseMoved): (MouseDragged):
5:56 PM Changeset in webkit [6214] by cblu
  • 2 edits
    2 adds in trunk/WebCore

Added stubs for the HTML DOM API.

Reviewed by rjw.

  • WebCore.pbproj/project.pbxproj:
  • kwq/HTMLDOM.h: Added.
  • kwq/HTMLDOM.mm: Added. (-[HTMLCollection length]): (-[HTMLCollection item:]): (-[HTMLCollection namedItem:]): (-[HTMLElement idName]): (-[HTMLElement setIdName:]): (-[HTMLElement title]): (-[HTMLElement setTitle:]): (-[HTMLElement lang]): (-[HTMLElement setLang:]): (-[HTMLElement dir]): (-[HTMLElement setDir:]): (-[HTMLElement className]): (-[HTMLElement setClassName:]): (-[HTMLDocument title]): (-[HTMLDocument setTitle:]): (-[HTMLDocument referrer]): (-[HTMLDocument domain]): (-[HTMLDocument URL]): (-[HTMLDocument body]): (-[HTMLDocument images]): (-[HTMLDocument applets]): (-[HTMLDocument links]): (-[HTMLDocument forms]): (-[HTMLDocument anchors]): (-[HTMLDocument setBody:]): (-[HTMLDocument cookie]): (-[HTMLDocument setCookie:]): (-[HTMLDocument open]): (-[HTMLDocument close]): (-[HTMLDocument write:]): (-[HTMLDocument writeln:]): (-[HTMLDocument getElementById:]): (-[HTMLDocument getElementsByName:]): (-[HTMLHtmlElement version]): (-[HTMLHtmlElement setVersion:]): (-[HTMLHeadElement profile]): (-[HTMLHeadElement setProfile:]): (-[HTMLLinkElement disabled]): (-[HTMLLinkElement setDisabled:]): (-[HTMLLinkElement charset]): (-[HTMLLinkElement setCharset:]): (-[HTMLLinkElement href]): (-[HTMLLinkElement setHref:]): (-[HTMLLinkElement hreflang]): (-[HTMLLinkElement setHreflang:]): (-[HTMLLinkElement media]): (-[HTMLLinkElement setMedia:]): (-[HTMLLinkElement rel]): (-[HTMLLinkElement setRrevel:]): (-[HTMLLinkElement rev]): (-[HTMLLinkElement setRev:]): (-[HTMLLinkElement target]): (-[HTMLLinkElement setTarget:]): (-[HTMLLinkElement type]): (-[HTMLLinkElement setType:]): (-[HTMLTitleElement text]): (-[HTMLTitleElement setText:]): (-[HTMLMetaElement content]): (-[HTMLMetaElement setContent:]): (-[HTMLMetaElement httpEquiv]): (-[HTMLMetaElement setHttpEquiv:]): (-[HTMLMetaElement name]): (-[HTMLMetaElement setName:]): (-[HTMLMetaElement scheme]): (-[HTMLMetaElement setScheme:]): (-[HTMLBaseElement href]): (-[HTMLBaseElement setHref:]): (-[HTMLBaseElement target]): (-[HTMLBaseElement setTarget:]): (-[HTMLStyleElement disabled]): (-[HTMLStyleElement setDisabled:]): (-[HTMLStyleElement media]): (-[HTMLStyleElement setMedia:]): (-[HTMLStyleElement type]): (-[HTMLStyleElement setType:]): (-[HTMLBodyElement aLink]): (-[HTMLBodyElement setALink:]): (-[HTMLBodyElement background]): (-[HTMLBodyElement setBackground:]): (-[HTMLBodyElement bgColor]): (-[HTMLBodyElement setBgColor:]): (-[HTMLBodyElement link]): (-[HTMLBodyElement setLink:]): (-[HTMLBodyElement text]): (-[HTMLBodyElement setText:]): (-[HTMLBodyElement vLink]): (-[HTMLBodyElement setVLink:]): (-[HTMLFormElement elements]): (-[HTMLFormElement length]): (-[HTMLFormElement name]): (-[HTMLFormElement setName:]): (-[HTMLFormElement acceptCharset]): (-[HTMLFormElement setAcceptCharset:]): (-[HTMLFormElement action]): (-[HTMLFormElement setAction:]): (-[HTMLFormElement enctype]): (-[HTMLFormElement setEnctype:]): (-[HTMLFormElement method]): (-[HTMLFormElement setMethod:]): (-[HTMLFormElement target]): (-[HTMLFormElement setTarget:]): (-[HTMLFormElement submit]): (-[HTMLFormElement reset]): (-[HTMLIsIndexElement form]): (-[HTMLIsIndexElement prompt]): (-[HTMLIsIndexElement setPrompt:]): (-[HTMLSelectElement type]): (-[HTMLSelectElement selectedIndex]): (-[HTMLSelectElement setSelectedIndex:]): (-[HTMLSelectElement value]): (-[HTMLSelectElement setValue:]): (-[HTMLSelectElement length]): (-[HTMLSelectElement form]): (-[HTMLSelectElement options]): (-[HTMLSelectElement disabled]): (-[HTMLSelectElement multiple]): (-[HTMLSelectElement name]): (-[HTMLSelectElement setName:]): (-[HTMLSelectElement size]): (-[HTMLSelectElement tabIndex]): (-[HTMLSelectElement add::]): (-[HTMLSelectElement remove:]): (-[HTMLSelectElement blur]): (-[HTMLSelectElement focus]): (-[HTMLOptGroupElement disabled]): (-[HTMLOptGroupElement setDisabled:]): (-[HTMLOptGroupElement label]): (-[HTMLOptGroupElement setLabel:]): (-[HTMLOptionElement form]): (-[HTMLOptionElement defaultSelected]): (-[HTMLOptionElement setDefaultSelected:]): (-[HTMLOptionElement text]): (-[HTMLOptionElement index]): (-[HTMLOptionElement setIndex:]): (-[HTMLOptionElement disabled]): (-[HTMLOptionElement setDisabled:]): (-[HTMLOptionElement label]): (-[HTMLOptionElement setLabel:]): (-[HTMLOptionElement selected]): (-[HTMLOptionElement value]): (-[HTMLOptionElement setValue:]): (-[HTMLInputElement defaultValue]): (-[HTMLInputElement setDefaultValue:]): (-[HTMLInputElement defaultChecked]): (-[HTMLInputElement setDefaultChecked:]): (-[HTMLInputElement form]): (-[HTMLInputElement accept]): (-[HTMLInputElement setAccept:]): (-[HTMLInputElement accessKey]): (-[HTMLInputElement setAccessKey:]): (-[HTMLInputElement align]): (-[HTMLInputElement setAlign:]): (-[HTMLInputElement alt]): (-[HTMLInputElement setAlt:]): (-[HTMLInputElement checked]): (-[HTMLInputElement setChecked:]): (-[HTMLInputElement disabled]): (-[HTMLInputElement setDisabled:]): (-[HTMLInputElement maxLength]): (-[HTMLInputElement setMaxLength:]): (-[HTMLInputElement name]): (-[HTMLInputElement setName:]): (-[HTMLInputElement readOnly]): (-[HTMLInputElement setReadOnly:]): (-[HTMLInputElement size]): (-[HTMLInputElement setSize:]): (-[HTMLInputElement src]): (-[HTMLInputElement setSrc:]): (-[HTMLInputElement tabIndex]): (-[HTMLInputElement setTabIndex:]): (-[HTMLInputElement type]): (-[HTMLInputElement useMap]): (-[HTMLInputElement setUseMap:]): (-[HTMLInputElement value]): (-[HTMLInputElement setValue:]): (-[HTMLInputElement blur]): (-[HTMLInputElement focus]): (-[HTMLInputElement select]): (-[HTMLInputElement click]): (-[HTMLTextAreaElement defaultValue]): (-[HTMLTextAreaElement setDefaultValue:]): (-[HTMLTextAreaElement form]): (-[HTMLTextAreaElement accessKey]): (-[HTMLTextAreaElement setAccessKey:]): (-[HTMLTextAreaElement cols]): (-[HTMLTextAreaElement setCols:]): (-[HTMLTextAreaElement disabled]): (-[HTMLTextAreaElement setDisabled:]): (-[HTMLTextAreaElement name]): (-[HTMLTextAreaElement setName:]): (-[HTMLTextAreaElement readOnly]): (-[HTMLTextAreaElement setReadOnly:]): (-[HTMLTextAreaElement rows]): (-[HTMLTextAreaElement setRows:]): (-[HTMLTextAreaElement tabIndex]): (-[HTMLTextAreaElement setTabIndex:]): (-[HTMLTextAreaElement type]): (-[HTMLTextAreaElement value]): (-[HTMLTextAreaElement setValue:]): (-[HTMLTextAreaElement blur]): (-[HTMLTextAreaElement focus]): (-[HTMLTextAreaElement select]): (-[HTMLButtonElement form]): (-[HTMLButtonElement accessKey]): (-[HTMLButtonElement setAccessKey:]): (-[HTMLButtonElement disabled]): (-[HTMLButtonElement setDisabled:]): (-[HTMLButtonElement name]): (-[HTMLButtonElement setName:]): (-[HTMLButtonElement tabIndex]): (-[HTMLButtonElement setTabIndex:]): (-[HTMLButtonElement type]): (-[HTMLButtonElement value]): (-[HTMLButtonElement setValue:]): (-[HTMLLabelElement form]): (-[HTMLLabelElement accessKey]): (-[HTMLLabelElement setAccessKey:]): (-[HTMLLabelElement htmlFor]): (-[HTMLLabelElement setHtmlFor:]): (-[HTMLFieldSetElement form]): (-[HTMLLegendElement form]): (-[HTMLLegendElement accessKey]): (-[HTMLLegendElement setAccessKey:]): (-[HTMLLegendElement align]): (-[HTMLLegendElement setAlign:]): (-[HTMLUListElement compact]): (-[HTMLUListElement setCompact:]): (-[HTMLUListElement type]): (-[HTMLUListElement setType:]): (-[HTMLOListElement compact]): (-[HTMLOListElement setCompact:]): (-[HTMLOListElement start]): (-[HTMLOListElement setStart:]): (-[HTMLOListElement type]): (-[HTMLOListElement setType:]): (-[HTMLDListElement compact]): (-[HTMLDListElement setCompact:]): (-[HTMLDirectoryElement compact]): (-[HTMLDirectoryElement setCompact:]): (-[HTMLMenuElement compact]): (-[HTMLMenuElement setCompact:]): (-[HTMLLIElement type]): (-[HTMLLIElement setType:]): (-[HTMLLIElement value]): (-[HTMLLIElement setValue:]): (-[HTMLBlockquoteElement cite]): (-[HTMLBlockquoteElement setCite:]): (-[HTMLDivElement align]): (-[HTMLDivElement setAlign:]): (-[HTMLParagraphElement align]): (-[HTMLParagraphElement setAlign:]): (-[HTMLHeadingElement align]): (-[HTMLHeadingElement setAlign:]): (-[HTMLQuoteElement cite]): (-[HTMLQuoteElement setCite:]): (-[HTMLPreElement width]): (-[HTMLPreElement setWidth:]): (-[HTMLBRElement clear]): (-[HTMLBRElement setClear:]): (-[HTMLBaseFontElement color]): (-[HTMLBaseFontElement setColor:]): (-[HTMLBaseFontElement face]): (-[HTMLBaseFontElement setFace:]): (-[HTMLBaseFontElement size]): (-[HTMLBaseFontElement setSize:]): (-[HTMLFontElement color]): (-[HTMLFontElement setColor:]): (-[HTMLFontElement face]): (-[HTMLFontElement setFace:]): (-[HTMLFontElement size]): (-[HTMLFontElement setSize:]): (-[HTMLHRElement align]): (-[HTMLHRElement setAlign:]): (-[HTMLHRElement noShade]): (-[HTMLHRElement setNoShade:]): (-[HTMLHRElement size]): (-[HTMLHRElement setSize:]): (-[HTMLHRElement width]): (-[HTMLHRElement setWidth:]): (-[HTMLModElement cite]): (-[HTMLModElement setCite:]): (-[HTMLModElement dateTime]): (-[HTMLModElement setDateTime:]): (-[HTMLAnchorElement accessKey]): (-[HTMLAnchorElement setAccessKey:]): (-[HTMLAnchorElement charset]): (-[HTMLAnchorElement setCharset:]): (-[HTMLAnchorElement coords]): (-[HTMLAnchorElement setCoords:]): (-[HTMLAnchorElement href]): (-[HTMLAnchorElement setHref:]): (-[HTMLAnchorElement hreflang]): (-[HTMLAnchorElement setHreflang:]): (-[HTMLAnchorElement name]): (-[HTMLAnchorElement setName:]): (-[HTMLAnchorElement rel]): (-[HTMLAnchorElement setRel:]): (-[HTMLAnchorElement rev]): (-[HTMLAnchorElement setRev:]): (-[HTMLAnchorElement shape]): (-[HTMLAnchorElement setShape:]): (-[HTMLAnchorElement tabIndex]): (-[HTMLAnchorElement setTabIndex:]): (-[HTMLAnchorElement target]): (-[HTMLAnchorElement setTarget:]): (-[HTMLAnchorElement type]): (-[HTMLAnchorElement setType:]): (-[HTMLAnchorElement blur]): (-[HTMLAnchorElement focus]): (-[HTMLImageElement lowSrc]): (-[HTMLImageElement setLowSrc:]): (-[HTMLImageElement name]): (-[HTMLImageElement setName:]): (-[HTMLImageElement align]): (-[HTMLImageElement setAlign:]): (-[HTMLImageElement alt]): (-[HTMLImageElement setAlt:]): (-[HTMLImageElement border]): (-[HTMLImageElement setBorder:]): (-[HTMLImageElement height]): (-[HTMLImageElement setHeight:]): (-[HTMLImageElement hspace]): (-[HTMLImageElement setHspace:]): (-[HTMLImageElement isMap]): (-[HTMLImageElement setIsMap:]): (-[HTMLImageElement longDesc]): (-[HTMLImageElement setLongDesc:]): (-[HTMLImageElement src]): (-[HTMLImageElement setSrc:]): (-[HTMLImageElement useMap]): (-[HTMLImageElement setUseMap:]): (-[HTMLImageElement vspace]): (-[HTMLImageElement setVspace:]): (-[HTMLImageElement width]): (-[HTMLImageElement setWidth:]): (-[HTMLObjectElement form]): (-[HTMLObjectElement code]): (-[HTMLObjectElement setCode:]): (-[HTMLObjectElement align]): (-[HTMLObjectElement setAlign:]): (-[HTMLObjectElement archive]): (-[HTMLObjectElement setArchive:]): (-[HTMLObjectElement border]): (-[HTMLObjectElement setBorder:]): (-[HTMLObjectElement codeBase]): (-[HTMLObjectElement setCodeBase:]): (-[HTMLObjectElement codeType]): (-[HTMLObjectElement setCodeType:]): (-[HTMLObjectElement data]): (-[HTMLObjectElement setData:]): (-[HTMLObjectElement declare]): (-[HTMLObjectElement setDeclare:]): (-[HTMLObjectElement height]): (-[HTMLObjectElement setHeight:]): (-[HTMLObjectElement hspace]): (-[HTMLObjectElement setHspace:]): (-[HTMLObjectElement name]): (-[HTMLObjectElement setName:]): (-[HTMLObjectElement standby]): (-[HTMLObjectElement setStandby:]): (-[HTMLObjectElement tabIndex]): (-[HTMLObjectElement setTabIndex:]): (-[HTMLObjectElement type]): (-[HTMLObjectElement setType:]): (-[HTMLObjectElement useMap]): (-[HTMLObjectElement setUseMap:]): (-[HTMLObjectElement vspace]): (-[HTMLObjectElement setVspace:]): (-[HTMLObjectElement width]): (-[HTMLObjectElement setWidth:]): (-[HTMLParamElement name]): (-[HTMLParamElement setName:]): (-[HTMLParamElement type]): (-[HTMLParamElement setType:]): (-[HTMLParamElement value]): (-[HTMLParamElement setValue:]): (-[HTMLParamElement valueType]): (-[HTMLParamElement setValueType:]): (-[HTMLAppletElement align]): (-[HTMLAppletElement setAlign:]): (-[HTMLAppletElement alt]): (-[HTMLAppletElement setAlt:]): (-[HTMLAppletElement archive]): (-[HTMLAppletElement setArchive:]): (-[HTMLAppletElement code]): (-[HTMLAppletElement setCode:]): (-[HTMLAppletElement codeBase]): (-[HTMLAppletElement setCodeBase:]): (-[HTMLAppletElement codeType]): (-[HTMLAppletElement setCodeType:]): (-[HTMLAppletElement height]): (-[HTMLAppletElement setHeight:]): (-[HTMLAppletElement hspace]): (-[HTMLAppletElement setHspace:]): (-[HTMLAppletElement name]): (-[HTMLAppletElement setName:]): (-[HTMLAppletElement object]): (-[HTMLAppletElement setObject:]): (-[HTMLAppletElement vspace]): (-[HTMLAppletElement setVspace:]): (-[HTMLAppletElement width]): (-[HTMLAppletElement setWidth:]): (-[HTMLMapElement areas]): (-[HTMLMapElement name]): (-[HTMLMapElement setName:]): (-[HTMLAreaElement accessKey]): (-[HTMLAreaElement setAccessKey:]): (-[HTMLAreaElement alt]): (-[HTMLAreaElement setAlt:]): (-[HTMLAreaElement coords]): (-[HTMLAreaElement setCoords:]): (-[HTMLAreaElement href]): (-[HTMLAreaElement setHref:]): (-[HTMLAreaElement noHref]): (-[HTMLAreaElement setNoHref:]): (-[HTMLAreaElement shape]): (-[HTMLAreaElement setShape:]): (-[HTMLAreaElement tabIndex]): (-[HTMLAreaElement setTabIndex:]): (-[HTMLAreaElement target]): (-[HTMLAreaElement setTarget:]): (-[HTMLScriptElement text]): (-[HTMLScriptElement setText:]): (-[HTMLScriptElement htmlFor]): (-[HTMLScriptElement setHtmlFor:]): (-[HTMLScriptElement event]): (-[HTMLScriptElement setEvent:]): (-[HTMLScriptElement charset]): (-[HTMLScriptElement setCharset:]): (-[HTMLScriptElement defer]): (-[HTMLScriptElement setDefer:]): (-[HTMLScriptElement src]): (-[HTMLScriptElement setSrc:]): (-[HTMLScriptElement type]): (-[HTMLScriptElement setType:]): (-[HTMLTableCaptionElement align]): (-[HTMLTableCaptionElement setAlign:]): (-[HTMLTableSectionElement align]): (-[HTMLTableSectionElement setAlign:]): (-[HTMLTableSectionElement ch]): (-[HTMLTableSectionElement setCh:]): (-[HTMLTableSectionElement chOff]): (-[HTMLTableSectionElement setChOff:]): (-[HTMLTableSectionElement vAlign]): (-[HTMLTableSectionElement setVAlign:]): (-[HTMLTableSectionElement rows]): (-[HTMLTableSectionElement insertRow:]): (-[HTMLTableSectionElement deleteRow:]): (-[HTMLTableElement caption]): (-[HTMLTableElement tHead]): (-[HTMLTableElement tFoot]): (-[HTMLTableElement rows]): (-[HTMLTableElement tBodies]): (-[HTMLTableElement align]): (-[HTMLTableElement setAlign:]): (-[HTMLTableElement bgColor]): (-[HTMLTableElement setBgColor:]): (-[HTMLTableElement border]): (-[HTMLTableElement setBorder:]): (-[HTMLTableElement cellPadding]): (-[HTMLTableElement setCellPadding:]): (-[HTMLTableElement cellSpacing]): (-[HTMLTableElement setCellSpacing:]): (-[HTMLTableElement frame]): (-[HTMLTableElement setFrame:]): (-[HTMLTableElement rules]): (-[HTMLTableElement setRules:]): (-[HTMLTableElement summary]): (-[HTMLTableElement setSummary:]): (-[HTMLTableElement width]): (-[HTMLTableElement setWidth:]): (-[HTMLTableElement createTHead]): (-[HTMLTableElement deleteTHead]): (-[HTMLTableElement createTFoot]): (-[HTMLTableElement deleteTFoot]): (-[HTMLTableElement createCaption]): (-[HTMLTableElement deleteCaption]): (-[HTMLTableElement deleteRow:]): (-[HTMLTableColElement align]): (-[HTMLTableColElement setAlign:]): (-[HTMLTableColElement ch]): (-[HTMLTableColElement setCh:]): (-[HTMLTableColElement chOff]): (-[HTMLTableColElement setChOff:]): (-[HTMLTableColElement span]): (-[HTMLTableColElement setSpan:]): (-[HTMLTableColElement vAlign]): (-[HTMLTableColElement setVAlign:]): (-[HTMLTableColElement width]): (-[HTMLTableColElement setWidth:]): (-[HTMLTableRowElement rowIndex]): (-[HTMLTableRowElement setRowIndex:]): (-[HTMLTableRowElement sectionRowIndex]): (-[HTMLTableRowElement setSectionRowIndex:]): (-[HTMLTableRowElement cells]): (-[HTMLTableRowElement setCells:]): (-[HTMLTableRowElement align]): (-[HTMLTableRowElement setAlign:]): (-[HTMLTableRowElement bgColor]): (-[HTMLTableRowElement setBgColor:]): (-[HTMLTableRowElement ch]): (-[HTMLTableRowElement setCh:]): (-[HTMLTableRowElement chOff]): (-[HTMLTableRowElement setChOff:]): (-[HTMLTableRowElement vAlign]): (-[HTMLTableRowElement setVAlign:]): (-[HTMLTableRowElement insertCell:]): (-[HTMLTableRowElement deleteCell:]): (-[HTMLTableCellElement cellIndex]): (-[HTMLTableCellElement setCellIndex:]): (-[HTMLTableCellElement abbr]): (-[HTMLTableCellElement setAbbr:]): (-[HTMLTableCellElement align]): (-[HTMLTableCellElement setAlign:]): (-[HTMLTableCellElement axis]): (-[HTMLTableCellElement setAxis:]): (-[HTMLTableCellElement bgColor]): (-[HTMLTableCellElement setBgColor:]): (-[HTMLTableCellElement ch]): (-[HTMLTableCellElement setCh:]): (-[HTMLTableCellElement chOff]): (-[HTMLTableCellElement setChOff:]): (-[HTMLTableCellElement colSpan]): (-[HTMLTableCellElement setColSpan:]): (-[HTMLTableCellElement headers]): (-[HTMLTableCellElement setHeaders:]): (-[HTMLTableCellElement height]): (-[HTMLTableCellElement setHeight:]): (-[HTMLTableCellElement noWrap]): (-[HTMLTableCellElement setNoWrap:]): (-[HTMLTableCellElement rowSpan]): (-[HTMLTableCellElement setRowSpan:]): (-[HTMLTableCellElement scope]): (-[HTMLTableCellElement setScope:]): (-[HTMLTableCellElement vAlign]): (-[HTMLTableCellElement setVAlign:]): (-[HTMLTableCellElement width]): (-[HTMLTableCellElement setWidth:]): (-[HTMLFrameSetElement cols]): (-[HTMLFrameSetElement setCols:]): (-[HTMLFrameSetElement rows]): (-[HTMLFrameSetElement setRows:]): (-[HTMLFrameElement frameBorder]): (-[HTMLFrameElement setFrameBorder:]): (-[HTMLFrameElement longDesc]): (-[HTMLFrameElement setLongDesc:]): (-[HTMLFrameElement marginHeight]): (-[HTMLFrameElement setMarginHeight:]): (-[HTMLFrameElement marginWidth]): (-[HTMLFrameElement setMarginWidth:]): (-[HTMLFrameElement name]): (-[HTMLFrameElement setName:]): (-[HTMLFrameElement noResize]): (-[HTMLFrameElement setNoResize:]): (-[HTMLFrameElement scrolling]): (-[HTMLFrameElement setScrolling:]): (-[HTMLFrameElement src]): (-[HTMLFrameElement setSrc:]): (-[HTMLIFrameElement align]): (-[HTMLIFrameElement setAlign:]): (-[HTMLIFrameElement frameBorder]): (-[HTMLIFrameElement setFrameBorder:]): (-[HTMLIFrameElement height]): (-[HTMLIFrameElement setHeight:]): (-[HTMLIFrameElement longDesc]): (-[HTMLIFrameElement setLongDesc:]): (-[HTMLIFrameElement marginHeight]): (-[HTMLIFrameElement setMarginHeight:]): (-[HTMLIFrameElement marginWidth]): (-[HTMLIFrameElement setMarginWidth:]): (-[HTMLIFrameElement name]): (-[HTMLIFrameElement setName:]): (-[HTMLIFrameElement scrolling]): (-[HTMLIFrameElement setScrolling:]): (-[HTMLIFrameElement src]): (-[HTMLIFrameElement setSrc:]): (-[HTMLIFrameElement width]): (-[HTMLIFrameElement setWidth:]):
4:47 PM Changeset in webkit [6213] by darin
  • 2 edits in branches/Safari-1-2-branch/WebCore/khtml/rendering

Merge yet another fix for Epiphany.

2004-03-10 David Hyatt <hyatt@apple.com>

Fix for 3584646, AxWebArea should encompass all children (its AxSize should).

Reviewed by mjs

  • khtml/rendering/render_canvas.cpp: (RenderCanvas::absoluteRects):
  • khtml/rendering/render_canvas.h:
4:23 PM Changeset in webkit [6212] by rjw
  • 9 edits
    10 adds in trunk/JavaScriptCore

Stitched together the NP stuff to our language independent
JavaScript binding stuff. Very close to being done.

Added program to test C bindings (and NP stuff). Just tests
properties. Will add methods and JavaScript access, etc.

Updated Makefile.am to account for new bindings/c directory.

Change NP_UTF8 from "const char *" to "char" to allow for
declarations like "const NP_UTF8 *" and "NP_UTF8 *". Ditto
for NP_UTF16.

Added NP_IsValidIdentifier().

Reviewed by Chris.

  • JavaScriptCore.pbproj/project.pbxproj:
  • Makefile.am:
  • bindings/NP_jsobject.cpp: (identiferFromNPIdentifier): (NP_Evaluate):
  • bindings/NP_runtime.cpp: (NP_IdentifierFromUTF8): (NP_IsValidIdentifier): (NP_GetIdentifiers): (NP_UTF8FromIdentifier): (NP_SetExceptionWithUTF8): (NP_SetException): (NP_CreateStringWithUTF8): (NP_CreateStringWithUTF16): (NP_UTF8FromString): (NP_UTF16FromString):
  • bindings/NP_runtime.h:
  • bindings/c/c_class.cpp: Added. (CClass::_commonDelete): (CClass::_commonCopy): (CClass::_commonInit): (_createClassesByIsAIfNecessary): (CClass::classForIsA): (CClass::CClass): (CClass::name): (CClass::methodsNamed): (CClass::fieldNamed):
  • bindings/c/c_class.h: Added. (KJS::Bindings::CClass::~CClass): (KJS::Bindings::CClass::CClass): (KJS::Bindings::CClass::operator=): (KJS::Bindings::CClass::constructorAt): (KJS::Bindings::CClass::numConstructors):
  • bindings/c/c_instance.cpp: Added. (CInstance::CInstance): (CInstance::~CInstance): (CInstance::operator=): (CInstance::getClass): (CInstance::begin): (CInstance::end): (CInstance::invokeMethod): (CInstance::defaultValue): (CInstance::stringValue): (CInstance::numberValue): (CInstance::booleanValue): (CInstance::valueOf):
  • bindings/c/c_instance.h: Added. (KJS::Bindings::CInstance::getObject):
  • bindings/c/c_runtime.cpp: Added. (CField::valueFromInstance): (CField::setValueToInstance):
  • bindings/c/c_runtime.h: Added. (KJS::Bindings::CField::CField): (KJS::Bindings::CField::name): (KJS::Bindings::CField::type): (KJS::Bindings::CMethod::CMethod): (KJS::Bindings::CMethod::name): (KJS::Bindings::CMethod::numParameters):
  • bindings/c/c_utility.cpp: Added. (coerceValueToNPValueType): (convertValueToNPValueType): (convertNPValueTypeToValue):
  • bindings/c/c_utility.h: Added.
  • bindings/make_testbindings:
  • bindings/runtime.cpp: (Instance::createBindingForLanguageInstance):
  • bindings/runtime.h: (KJS::Bindings::Instance::):
  • bindings/testbindings.cpp: Added. (initializeIdentifiers): (myInterfaceHasProperty): (myInterfaceHasMethod): (myInterfaceGetProperty): (myInterfaceSetProperty): (myInterfaceInvoke): (myInterfaceAllocate): (myInterfaceInvalidate): (myInterfaceDeallocate): (GlobalImp::className): (readJavaScriptFromFile): (main):
4:07 PM Changeset in webkit [6211] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by Dave

I have clarified the concept (at least in my head)
that each edit command has an obligation to put the
selection in the right place after it is applied,
unapplied, or reapplied. Right now, each edit command
calls setStartingSelection and setEndingSelection to do
this, I made these function move the selection on
setting.

  • khtml/editing/htmlediting_impl.cpp: (EditCommandImpl::setStartingSelection) (EditCommandImpl::setEndingSelection) (InputTextCommandImpl::coalesce) (InputTextCommandImpl::deleteCharacter) (InputTextCommandImpl::execute)
  • khtml/editing/htmlediting_impl.h:
3:37 PM Changeset in webkit [6210] by kocienda
  • 34 edits
    7 adds in trunk

WebCore:

Reviewed by Dave

Various changes to move us forward on editing.

  1. I reorganized the concrete EditCommand interface and implementation classes alphabetically in their respective files, to make it easier to find things.
  1. I added a TypingCommand composite class to gang up all keystrokes and make it possible to pass a single command over to the Cocoa undo system in all cases.
  1. I now send all keystrokes back over to WebKit to be interpreted by the text input system. In concert with the many new NSResponder method implementations I added to WebView, we now respond to keystrokes in a much more Cocoa-like way that sets us down the path to integrating with the Cocoa text input system some day.
  1. I fixed up our integration with the Cocoa undo system. I also removed much of the undo support code from the KHTMPart class. As a replacement, I implemented reporting of undoable commands to KHTMLPart so that a KDE hookup is quite feasible. As a result, undo should "just work" in Blot (Chris has reported that it has been busted).
  1. I added the DOM CSS bindings for Objective-C. This required some rearranging of the existing DOM bindings code, and while I was there, I did various cleanups in the existing DOM bindings.
  • About 400 lines of changed files and functions elided.

WebKit:

Reviewed by Dave

Various changes to begin implementing the draft API proposal.

  • DOM.subproj/DOM.h: Checking in generated file.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge registerCommandForUndo:]): Now takes an id, a wrapped WebCore EditCommand implementation object. (-[WebBridge registerCommandForRedo:]): Ditto. (-[WebBridge clearUndoRedoOperations]): Use the web view's undo manager. (-[WebBridge keyDown:]): Pass keyDown events through to the web view.
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDefaultEditingDelegate.h: Added.
  • WebView.subproj/WebDefaultEditingDelegate.m: Added. Stubbed in default implementations declared in the draft editing API.
  • WebView.subproj/WebFrame.m: (-[WebFramePrivate dealloc]): WebFrame no longer has an undo manager.
  • WebView.subproj/WebFramePrivate.h: Ditto.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _selectedWebArchive:]): selectedRange method is now selectedDOMRange.
  • WebView.subproj/WebView.m: (-[WebViewPrivate dealloc]): Dealloc new editingDelegateForwarder. (-[WebView _editingDelegateForwarder]): Added. (-[WebView keyDown:]): Added. (-[WebView _bridgeForCurrentSelection]): Added. (-[WebView setSelectedDOMRange:]): Added. (-[WebView selectedDOMRange]): Added. (-[WebView insertText:]): Added. (-[WebView _alterSelection:direction:granularity:]): Added. (-[WebView selectWord:]): Added. (-[WebView moveRight:]): Added. (-[WebView moveRightAndModifySelection:]): Added. (-[WebView moveLeft:]): Added. (-[WebView moveLeftAndModifySelection:]): Added. (-[WebView deleteBackward:]): Added. (-[WebView insertNewline:]): Added. (-[WebView insertParagraphSeparator:]): Added. (-[WebView setEditingDelegate:]): Added. (-[WebView editingDelegate]): Added. (-[WebView undoManager]): Added. (-[WebView insertText:replacingDOMRange:]): Added.
  • WebView.subproj/WebViewPrivate.h: Added a collection of editing API declarations that will be public some day, but are still under review.

WebBrowser:

Reviewed by Dave

Browser document no longer creates its own undo manager.
Safari will use a different method to work with undo
managers once we settle on a WebKit API. For now, I am
just going to delete this early attempt.

  • BrowserDocument.h
  • BrowserDocument.m
2:15 PM Changeset in webkit [6209] by cblu
  • 4 edits in trunk/WebCore

Fixed some spacing issues in reconstructed source and web archives that were caused by a malformed doc type string that we were constructing.

Reviewed by darin.

  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::determineParseMode): set the public ID and system ID on the doc type
  • khtml/xml/dom_docimpl.cpp: (DocumentTypeImpl::toString): put a space between DOCTYPE and the name
  • khtml/xml/dom_docimpl.h: (DOM::DocumentTypeImpl::setPublicId): new (DOM::DocumentTypeImpl::setSystemId): new
2:08 PM Changeset in webkit [6208] by vicki
  • 2 edits in branches/Safari-1-2-branch/JavaScriptCore
  • bump the JavaScriptCore version number to 125.3 on the Safari-1-2-branch, to match the JSC version number that is in Feldspar
1:35 PM Changeset in webkit [6207] by vicki
  • 1 edit in branches/Safari-1-2-branch/JavaScriptCore/ChangeLog
  • fix my ChangeLog comment
1:26 PM Changeset in webkit [6206] by vicki
  • 2 edits in branches/Safari-1-2-branch/JavaScriptCore
  • roll this change from the SUPanFeldspar branch to the Safari-1-2-branch, so that all our Feldspar changes are also in Epiphany

2004-01-30 Richard Williamson <rjw@apple.com>

Fixed 3542044. Create KJS::String using UString constructor instead
of passing UTF8 string to char* constructor.

Reviewed by Darin.

  • bindings/jni/jni_instance.cpp: (JavaInstance::stringValue):
12:12 PM Changeset in webkit [6205] by sullivan
  • 4 edits in trunk/WebKit

WebKit:

  • fixed <rdar://problem/3585056>: Assertion failure if error page is loaded from webView:unableToImplementPolicyWithError:
  • also added HeaderDoc comments to could-be-API-soon methods and fixed a conceptual problem with said methods

Reviewed by Darin.

  • WebView.subproj/WebDataSourcePrivate.h: added HeaderDoc comment for -unreachableURL
  • WebView.subproj/WebFramePrivate.h: added HeaderDoc comment for -loadAlternateHTMLString:baseURL:forUnreachableURL:; also added boolean delegateIsHandlingUnimplementablePolicy ivar to WebFramePrivate
  • WebView.subproj/WebFrame.m: (-[WebFrame _shouldReloadToHandleUnreachableURLFromRequest:]): treat delegateIsHandlingUnimplementablePolicy like delegateIsDecidingNavigationPolicy. Safari serves up error pages during the latter but clients are equally or more likely to do so during the former. (-[WebFrame _handleUnimplementablePolicyWithErrorCode:forURL:]): set delegateIsHandlingUnimplementablePolicy during delegate callback (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): tweaked assertion so it doesn't erroneously fire for clients that call loadAlternateHTML:baseURL:forUnreachableURL: while processing webView:unableToImplementPolicyWithError:

WebBrowser:

Removed obsolete comment I happened to notice.

Reviewed by Darin..

  • BrowserWebController.m: (-[BrowserWebView webView:unableToImplementPolicyWithError:frame:]):
11:32 AM Changeset in webkit [6204] by cblu
  • 11 edits in trunk/WebKit

Tests:

Now that WebArchive is a class, refer to it as such.

Reviewed by kocienda.

  • Blot/BlotApp.m: (-[BlotApp handleNewMessageEvent:withReplyEvent:]):
  • Blot/BlotDocument.h:
  • Blot/BlotDocument.m: (-[BlotDocument loadWebArchive:]):

WebKit:

Made WebArchive a class instead of a data object. This allows clients to easily get the main resource and subresources from a WebArchive.

Reviewed by kocienda.

  • WebKit.exp:
  • WebView.subproj/WebDocumentPrivate.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame loadWebArchive:]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation loadWebArchive]): (-[WebHTMLRepresentation _webArchiveWithMarkupString:subresourceURLStrings:]): (-[WebHTMLRepresentation webArchiveFromNode:]): (-[WebHTMLRepresentation webArchiveFromRange:]):
  • WebView.subproj/WebHTMLRepresentationPrivate.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _selectedWebArchive:]): (-[WebHTMLView _writeSelectionToPasteboard:]): (-[WebHTMLView _pasteMarkupFromPasteboard:]):
  • WebView.subproj/WebResource.h:
  • WebView.subproj/WebResource.m: (-[WebArchivePrivate dealloc]): (-[WebResource _response]): (-[WebArchive init]): (-[WebArchive initWithMainResource:subresources:]): (-[WebArchive initWithData:]): (-[WebArchive dealloc]): (-[WebArchive mainResource]): (-[WebArchive subresources]): (-[WebArchive dataRepresentation]):
  • WebView.subproj/WebResourcePrivate.h:

WebBrowser:

Now that WebArchive is a class, refer to it as such.

Reviewed by kocienda.

  • BrowserDocument.m: (-[BrowserDocument dataRepresentationOfType:]): (-[BrowserDocument _mailWebArchiveData:withApplicationAtPath:]): (-[BrowserDocument mailPage:]): (-[BrowserDocument mailPageAddress:]):
  • English.lproj/InfoPlist.strings:
2:25 AM Changeset in webkit [6203] by mjs
  • 1 edit in branches/Safari-1-2-branch/WebCore/ChangeLog-2005-08-23

Merge yet another fix for Epiphany.

2004-03-10 David Hyatt <hyatt@apple.com>

Fix for 3584646, AxWebArea should encompass all children (its AxSize should).

Reviewed by mjs

  • khtml/rendering/render_canvas.cpp: (RenderCanvas::absoluteRects):
  • khtml/rendering/render_canvas.h:

Mar 10, 2004:

6:07 PM Changeset in webkit [6202] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3584646, AxWebArea should encompass all children (its AxSize should).

Reviewed by mjs

  • khtml/rendering/render_canvas.cpp: (RenderCanvas::absoluteRects):
  • khtml/rendering/render_canvas.h:
2:58 PM Changeset in webkit [6201] by rjw
  • 1 edit in trunk/JavaScriptCore/bindings/runtime.cpp

Fixed broken build.

2:25 PM Changeset in webkit [6200] by rjw
  • 5 edits in trunk/JavaScriptCore

Made changes to support new asychronous approach to calls from
plugin to JavaScript

Reviewed by Chris.

  • bindings/NP_jsobject.cpp: (NP_Call): (NP_Evaluate): (NP_GetProperty): (NP_ToString): (NP_GetPropertyAtIndex):
  • bindings/NP_runtime.h:
  • bindings/make_testbindings:
  • bindings/runtime.cpp: (Instance::createBindingForLanguageInstance):
1:51 PM Changeset in webkit [6199] by cblu
  • 3 edits in trunk/WebCore

Fixed: INPUT images are not part of web archives.

Reviewed by rjw.

  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::isSubresourceURLAttribute):
  • khtml/html/html_formimpl.h:
1:50 PM Changeset in webkit [6198] by cblu
  • 5 edits in trunk/WebKit

Made dragging of web archives work.

Reviewed by rjw.

  • English.lproj/StringsNotToBeLocalized.txt: updated
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:didReceiveResponse:]): added a FIXME about working around old Foundations that don't know about web archive files
  • WebView.subproj/WebView.m: (+[WebView canShowFile:]): tweak (+[WebView suggestedFileExtensionForMIMEType:]): tweak (+[WebView _MIMETypeForFile:]): handle web archive files since Foundation may be too old to know about them
1:50 PM Changeset in webkit [6197] by rjw
  • 2 edits in trunk/JavaScriptCore

Updated header to include proposed changes from
plugin-futures list. Calls from plugin to JavaScript
are now asynchronous.

Reviewed by Chris.

  • bindings/NP_runtime.h:
4:08 AM Changeset in webkit [6196]
  • 13 copies
    2 deletes in tags/WebCore-125~4

This commit was manufactured by cvs2svn to create tag
'WebCore-125~4'.

4:08 AM Changeset in webkit [6195] by mjs
  • 2 edits in branches/Safari-1-2-branch/WebCore

WebCore-125.4

3:55 AM Changeset in webkit [6194] by mjs
  • 2 edits in branches/Safari-1-2-branch/WebCore

Fix branch so it builds.

  • khtml/ecma/kjs_html.h:

Mar 9, 2004:

5:33 PM Changeset in webkit [6193] by cblu
  • 2 edits in trunk/WebKit

WebKit:

Made web archives use NSPropertyListBinaryFormat_v1_0 instead of NSPropertyListXMLFormat_v1_0 because NSPropertyListBinaryFormat_v1_0 is 3-5 times faster to serialize and parse.

Reviewed by rjw.

  • WebView.subproj/WebResource.m: (+[WebResource _parseWebArchive:mainResource:subresources:]): add timing code (+[WebResource _webArchiveWithMainResource:subresources:]): add timing code, use NSPropertyListBinaryFormat_v1_0

WebBrowser:

Reviewed by rjw.

  • BrowserDocument.m: (-[BrowserDocument mailPageAddress:]): call [WebResource _webArchiveWithMainResource:subresources:] and let it handle the property list serialization
5:26 PM Changeset in webkit [6192] by mjs
  • 3 edits in branches/Safari-1-2-branch/WebCore

Merged the following changes from HEAD for Epiphany:

2004-03-09 David Hyatt <hyatt@apple.com>

Make the AXLinkUIElements attribute always return an array (never
return nil).

  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityAttributeValue:]):

2004-03-09 David Hyatt <hyatt@apple.com>

(1) Change root element in a document to have a role of AXWebArea.
(2) Add support for AXURL to links and children of links.
(3) Add support for AXLinkUIElements to the AXWebArea

Reviewed by john

  • khtml/dom/html_misc.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject roleDescription]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]):
3:46 PM Changeset in webkit [6191] by cblu
  • 31 edits in trunk

Tests:

Updated blot to use new SPI's.

  • Blot/BlotApp.m: (-[BlotApp handleNewMessageEvent:withReplyEvent:]):
  • Blot/BlotDocument.h:
  • Blot/BlotDocument.m: (-[BlotDocument dataRepresentationOfType:]): (-[BlotDocument loadWebArchive:]):
  • TestPlugin/TestPlugin.pbproj/project.pbxproj:

WebCore:

Implemented WebCore side of: <rdar://problem/3577508>: API: web archive related API's

Reviewed by rjw.

  • WebCore-combined.exp:
  • WebCore.exp:
  • kwq/DOM.mm: (+[DOMRange _rangeWithImpl:]): made internally accessible (-[DOMRange _rangeImpl]): ditto
  • kwq/DOMInternal.h:
  • kwq/KWQStringList.h:
  • kwq/KWQStringList.mm: (QStringList::getNSArray): new
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge pasteMarkupString:]): renamed from pasteHTMLString since XML pasting may be possible (-[WebCoreBridge selectedRange]): new (-[WebCoreBridge _documentTypeString]): new (-[WebCoreBridge _stringWithDocumentTypeStringAndMarkupString:]): new (-[WebCoreBridge markupStringFromNode:subresourceURLStrings:]): new, needed for WebKit API's (-[WebCoreBridge markupStringFromRange:subresourceURLStrings:]): new, needed for WebKit API's

WebKit:

Fixed: <rdar://problem/3577508>: API: web archive related API's
Implemented WebKit side of: <rdar://problem/3144033>: ability to save web sites (images and all)

Reviewed by rjw.

  • WebCoreSupport.subproj/WebBridge.h:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge receivedData:textEncodingName:]): renamed to take a textEncodingName instead of data source. The data source argument is only needed for the textEncodingName.
  • WebKit.exp:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _subresourcesDictionary]): new (+[WebDataSource _repTypesAllowImageTypeOmission:]): include "application/x-webarchive"
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDocumentInternal.h:
  • WebView.subproj/WebDocumentPrivate.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame loadWebArchive:]): renamed, code factored out to [WebResource _parseWebArchive:mainResource:subresources:]
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFrameView.m: (+[WebFrameView _viewTypesAllowImageTypeOmission:]): include "application/x-webarchive"
  • WebView.subproj/WebHTMLRepresentation.h:
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentationPrivate dealloc]): (-[WebHTMLRepresentation _isDisplayingWebArchive]): new (-[WebHTMLRepresentation receivedData:withDataSource:]): don't feed data to WebCore if we're displaying a web archive since web archive can't be progressively loaded (-[WebHTMLRepresentation loadWebArchive]): new, feeds web archive data to WebCore (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): call loadWebArchive if necessary (-[WebHTMLRepresentation documentSource]): if displaying a web archive, return the HTML source from within the archive (-[WebHTMLRepresentation _webArchiveWithMarkupString:subresourceURLStrings:]): new (-[WebHTMLRepresentation markupStringFromNode:]): implementation of new API (-[WebHTMLRepresentation markupStringFromRange:]): ditto (-[WebHTMLRepresentation webArchiveFromNode:]): ditto (-[WebHTMLRepresentation webArchiveFromRange:]): ditto
  • WebView.subproj/WebHTMLRepresentationPrivate.h:
  • WebView.subproj/WebHTMLView.m: (+[WebHTMLView _selectionPasteboardTypes]): use renamed WebArchivePboardType (-[WebHTMLView _selectedWebArchive:]): renamed, call renamed methods (-[WebHTMLView _writeSelectionToPasteboard:]): call renamed methods (-[WebHTMLView _haveSelection]): indentation tweak (-[WebHTMLView _canDelete]): ditto (-[WebHTMLView _canPaste]): ditto (-[WebHTMLView _pasteMarkupFromPasteboard:]): renamed, call [WebResource _webArchiveWithMainResource:subresources:] (-[WebHTMLView initWithFrame:]): use renamed WebArchivePboardType (-[WebHTMLView paste:]): call renamed _pasteMarkupFromPasteboard (-[WebHTMLView concludeDragOperation:]): call renamed _pasteMarkupFromPasteboard
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:didReceiveResponse:]): modify the MIME type for web archives since Foundation is not yet web archive aware. This is ifdef'd pre-Tiger code.
  • WebView.subproj/WebResource.h:
  • WebView.subproj/WebResource.m: (+[WebResource _parseWebArchive:mainResource:subresources:]): new (+[WebResource _webArchiveWithMainResource:subresources:]): new
  • WebView.subproj/WebResourcePrivate.h:

WebBrowser:

Fixed: <rdar://problem/3144033>: ability to save web sites (images and all)

Reviewed by john.

  • BrowserDocument.h: added _dataSourceToSave, _fileFormatAccessoryView, _ fileFormatPopUpButton and _isSavingWithSavePanel ivars
  • BrowserDocument.m: (-[BrowserDocument dealloc]): added ASSERTs (-[BrowserDocument dataSourceToSave]): new (-[BrowserDocument canSaveAsWebArchive]): new (-[BrowserDocument isSavingWebArchive]): new (-[BrowserDocument MIMETypeForSaving]): take web archives into account (-[BrowserDocument filenameForSaving]): new (-[BrowserDocument isSavingPlainText]): moved (-[BrowserDocument setDataSourceToSave:]): instead of this being a wrapper method around setFileWrapperToSave:MIMEType:, have this set _dataSourceToSave since we need the data source for web archives to work (-[BrowserDocument saveDocumentTo:]): don't call setFileWrapperToSave:MIMEType: if there is no file wrapper since this case is handled in the above methods (-[BrowserDocument document:didSave:contextInfo:]): added more post-save clean-up (-[BrowserDocument allowedFileTypes]): new (-[BrowserDocument fileFormatPopUpButtonUpdated:]): new (-[BrowserDocument prepareSavePanel:]): attach an accessory view to the save panel if necessary (-[BrowserDocument dataRepresentationOfType:]): handle all cases of saving data (-[BrowserDocument displayName]): rely on the _isSavingWithSavePanel instead of _fileWrapperToSave for choosing a filename (-[BrowserDocument _isDisplayingCompletePage]): new, factored out from validateUserInterfaceItem: (-[BrowserDocument validateUserInterfaceItem:]): for mailPage:, makes sure the representation supports web archives (-[BrowserDocument _mailWebArchive:withApplicationAtPath:]): mail a web archive instead of a property list
(-[BrowserDocument mailPage:]): handle the case where the current page …
(-[BrowserDocument mailPageAddress:]): call renamed _mailWebArchive
  • PreferenceKeys.h: added keys for the pref of saving a web archive or raw source
  • WebBrowser.pbproj/project.pbxproj:
2:12 PM Changeset in webkit [6190] by hyatt
  • 2 edits in trunk/WebCore

Make the AXLinkUIElements attribute always return an array (never return nil).

  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityAttributeValue:]):
1:03 PM Changeset in webkit [6189] by sullivan
  • 6 edits in trunk/WebKit

WebKit:

  • fixed the following bugs: <rdar://problem/3579715>: Going to an error page in back/forward list doesn't work correctly in some cases <rdar://problem/3581031>: REGRESSION (130+): World Leak of WebFrame after trying to load page with unknown scheme

Reviewed by Darin.

  • WebView.subproj/WebDataSourcePrivate.h: renamed setRequest -> adoptRequest
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _URLForHistory]): updated comment (-[WebDataSource __adoptRequest:]): Renamed from setRequest; now takes an NSMutableURLRequest and uses it as-is. (-[WebDataSource _setRequest:]): now saves a mutable copy, instead of relying on the caller to do so. The (only) caller wasn't doing so in all cases, leading to trouble in River City. Also, special-case unreachable URL handling to allow alternate content to replace a URL in a redirect-like way without sending a redirect callback.
  • WebView.subproj/WebFrame.m: (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): renamed after discussion with Richard (was loadPlaceholderHTMLString:baseURL:unreachableURL:) (-[WebFrame _shouldReloadToHandleUnreachableURLFromRequest:]): new helper method, returns YES only if we receive a load request for alternate content from a delegate for an unreachable URL while we are going back or forward. That's a lot of prepositions! (-[WebFrame _loadRequest:subresources:]): if _shouldReloadToHandleUnreachableURLFromRequest: returns YES, change load type to WebFrameLoadTypeReload so b/f list is preserved appropriately. (-[WebFrame _transitionToCommitted:]): Update currentItem in the unreachableURL case. (-[WebFrame _isLoadComplete]): Don't reset b/f list before calling provisionalLoadDidFail delegate; instead, determine where to reset b/f list beforehand, and then actually reset list afterwards only if we didn't start an alternate content load in the delegate. Also, set new boolean ivar so we know when we're processing a provisionalLoadDidFail delegate callback. (-[WebFrame _loadItem:withLoadType:]): don't make extra copy before calling adoptRequest; just pass it the one we made here. (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): If we're loading alternate content for an unreachableURL, don't ask the decision listener, just do it. (This avoids problem with nested calls to checking the navigation policy that led to a WebFrame leak, and is conceptually the right thing to do also.) Also added some asserts that helped me track down the WebFrame leak. Set new boolean ivar so we know when we're processing a navigation policy delegate decision. (-[WebFrame _currentBackForwardListItemToResetTo]): new method, replaces _resetBackForwardListToCurrent. Does the same test as the latter but returns a boolean rather than actually resetting. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): save dataSource in a local var before calling stopLoading, and use it for _setProvisionalDataSource, because otherwise stopLoading was clobbering the dataSource for an unreachable URL handling case.
  • WebView.subproj/WebFramePrivate.h: two new boolean ivars
  • WebView.subproj/WebView.m: (+[WebView _canHandleRequest:]): return YES when we're loading alternate content for an unreachable URL

WebBrowser:

Reviewed by Darin.

  • BrowserWebController.m: (-[BrowserWebView showErrorPageForURL:withTitle:message:]): update call to renamed method
10:50 AM Changeset in webkit [6188] by hyatt
  • 3 edits in trunk/WebCore

(1) Change root element in a document to have a role of AXWebArea.
(2) Add support for AXURL to links and children of links.
(3) Add support for AXLinkUIElements to the AXWebArea

Reviewed by john

  • khtml/dom/html_misc.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject roleDescription]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]):
6:24 AM Changeset in webkit [6187] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by nobody.

  • kwq/KWQKURL.mm: (KURL::KURL): Fixed broken build by removing wayward "break" statement.

Mar 8, 2004:

4:14 PM Changeset in webkit [6186] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3554876>: REGRESSION (100-125): cannot upload file if path contains non-ASCII characters
  • kwq/KWQKURL.mm: Remove Colon constant so we can fit in 8 bits again. (KURL::KURL): Rewrite so we don't need isSchemeCharOrColon.
3:46 PM Changeset in webkit [6185]
  • 3 copies in tags/Safari-131

This commit was manufactured by cvs2svn to create tag 'Safari-131'.

3:46 PM Changeset in webkit [6184] by kocienda
  • 4 edits in trunk

Submitting Safari-131

3:46 PM Changeset in webkit [6183] by kocienda
  • 2 edits in trunk/WebKit

2004-03-08 Ken Kocienda <kocienda@apple.com>

Reviewed by Darin

  • WebKit.pbproj/project.pbxproj: Added CFBundleName to Info.plist
3:45 PM Changeset in webkit [6182] by kocienda
  • 2 edits in trunk/WebCore

2004-03-08 Ken Kocienda <kocienda@apple.com>

Reviewed by Darin

  • WebCore.pbproj/project.pbxproj: Added CFBundleName to Info.plist.
Note: See TracTimeline for information about the timeline view.