Timeline



Mar 16, 2004:

11:55 AM Changeset in webkit [6232] by darin
  • 11 edits in trunk

WebCore:

Reviewed by Ken.

  • a little more DOM cleanup
  • kwq/DOM-CSS.mm: Added DOMCSSUnknownRule.
  • kwq/DOM.mm: Split category implementations out to match category interfaces.
  • kwq/DOMHTML.h: Removed lowSrc, not in DOM Level 2. Added a category for some extensions we'll want on DOMElement.
  • kwq/DOMInternal.h: Moved _documentImpl method here so it can be used from separate categories.
  • kwq/DOMRange.h: Changed DOMDocumentRange to a category from a protocol.
  • kwq/HTMLDOM.mm: Removed unneeded methods.
  • WebCore.pbproj/project.pbxproj: Sort DOM header files alphabetically.

WebKit:

  • DOM.subproj/DOMHTML.h: Updated from WebCore.
  • DOM.subproj/DOMRange.h: Ditto.
11:40 AM Changeset in webkit [6231] by rjw
  • 2 edits in trunk/JavaScriptCore

Fixed 3590169. Regression (crash) caused by the switch to MethodLists. Crash when attempting to invoke a method from JavaScript to Java that is not implemented.

Reviewed by John.

  • bindings/jni/jni_class.cpp: (JavaClass::methodsNamed):
10:35 AM Changeset in webkit [6230] by darin
  • 13 edits
    16 adds
    2 deletes in trunk

WebCore:

Reviewed by Ken.

  • update for new DOM namespacing and header organization
  • WebCore.pbproj/project.pbxproj:
  • kwq/DOM-CSS.h: Removed.
  • kwq/DOM-CSS.mm: Update for name changes.
  • kwq/DOM.h: Changed to include the other DOM headers.
  • kwq/DOM.mm: Update for name changes.
  • kwq/DOMCSS.h: Added.
  • kwq/DOMCore.h: Added.
  • kwq/DOMEvents.h: Added.
  • kwq/DOMHTML.h: Added.
  • kwq/DOMInternal.h: Update for name changes.
  • kwq/DOMRange.h: Added.
  • kwq/DOMStylesheets.h: Added.
  • kwq/DOMTraversal.h: Added.
  • kwq/DOMViews.h: Added.
  • kwq/HTMLDOM.h: Removed.
  • kwq/HTMLDOM.mm: Update for name changes; add some missing setters.

WebKit:

Reviewed by Ken.

  • update for new DOM namespacing and header organization
  • DOM.subproj/DOM.h: Changed to include the other DOM headers.
  • DOM.subproj/DOMCSS.h: Added.
  • DOM.subproj/DOMCore.h: Added.
  • DOM.subproj/DOMEvents.h: Added.
  • DOM.subproj/DOMHTML.h: Added.
  • DOM.subproj/DOMRange.h: Added.
  • DOM.subproj/DOMStylesheets.h: Added.
  • DOM.subproj/DOMTraversal.h: Added.
  • DOM.subproj/DOMViews.h: Added.
  • WebKit.pbproj/project.pbxproj: Added new files.
  • WebView.subproj/WebDefaultEditingDelegate.m: (-[WebDefaultEditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]): (-[WebDefaultEditingDelegate webView:shouldChangeTypingStyle:toStyle:]): Change class names from CSS to DOMCSS.
  • WebView.subproj/WebViewPrivate.h: Ditto.
  • copy-webcore-files-to-webkit: Add new files.

Mar 15, 2004:

9:08 PM Changeset in webkit [6229] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • max out our iBench cheat. Don't even paint or lay out a quarter of the pages.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::close):
2:10 PM Changeset in webkit [6228] by rjw
  • 2 edits in trunk/JavaScriptCore

Fixed 3570854. Don't attempt to convert Null to strings. We
were incorrectly converting to "Null".

Actually fixed by Scott Kovatch.

Reviewed by Richard.

  • bindings/jni/jni_utility.cpp: (KJS::Bindings::convertValueToJValue):
2:09 PM Changeset in webkit [6227] by kocienda
  • 7 edits in trunk

WebCore:

Reviewed by John

Fix for this bug:

<rdar://problem/3588717>: REGRESSION (125-131u): Tabbing to links and tabbing in bookmarks view no longer works

Change some support methods which feed editing key events to
WebKit. The real fix is on the WebKit side.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::editingKeyEvent): Call new -editingKeyDown: on WebCoreBridge, as described below.
  • kwq/WebCoreBridge.h: Changed -keyDown: to -editingKeyDown: since we want to tell WebView about editing key events in a way that does not interfere with other key down events the WebView processes. This is not necessary in the strictest sense, but it seems reasonable to keep the terminology clear.

WebKit:

Reviewed by John

Fix for this bug:

<rdar://problem/3588717>: REGRESSION (125-131u): Tabbing to links and tabbing in bookmarks view no longer works

WebView can't lay claim to -keyDown: just for editing events, as
this gets in the way of tab processing. The solution is to give
WebView a private method for processing editing key events fed to
it from over the bridge, and leave -keyDown: unimplemented.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge editingKeyDown:]): Changed from -keyDown: to keep terminology consistent with renamed WebView -editingKeyDown: method.
  • WebView.subproj/WebView.m: (-[WebView editingKeyDown:]): Give WebView a method to handle editing key events in a way that does not interfere with other key down events it processes.
  • WebView.subproj/WebViewPrivate.h: Declare -editingKeyDown: method.
2:04 PM Changeset in webkit [6226] by vicki
  • 3 edits in trunk

change version number from '132' to '133u'. the tree is open for business.

2:00 PM Changeset in webkit [6225]
  • 3 copies in tags/Safari-132

This commit was manufactured by cvs2svn to create tag 'Safari-132'.

2:00 PM Changeset in webkit [6224] by vicki
  • 6 edits in trunk

Safari-132 stamp

10:37 AM Changeset in webkit [6223] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

Mar 12, 2004:

5:04 PM Changeset in webkit [6222] by darin
  • 2 edits in trunk/WebKit

Reviewed by Ken.

  • fixed <rdar://problem/3433887>: copied &nbsp; characters remain non-breaking spaces; other browsers give normal spaces
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _writeSelectionToPasteboard:]): Convert non-breaking spaces to the normal kind in the plain text part of the pasteboard.
1:59 PM Changeset in webkit [6221] by cblu
  • 5 edits in trunk/WebCore

Implemented ~25% of the HTML DOM API.

Reviewed by kocienda.

(DOM::HTMLElement::HTMLElement):

  • kwq/DOM.mm:
  • kwq/DOMInternal.h:
  • kwq/HTMLDOM.h:
  • kwq/HTMLDOM.mm: (-[HTMLCollection _initWithCollectionImpl:]): (+[HTMLCollection _collectionWithImpl:]): (-[HTMLCollection _collectionImpl]): (-[HTMLCollection length]): (-[HTMLCollection item:]): (-[HTMLCollection namedItem:]): (-[HTMLElement _initWithElementImpl:]): (+[HTMLElement _elementWithImpl:]): (-[HTMLElement _HTMLElementImpl]): (-[HTMLElement idName]): (-[HTMLElement setIdName:]): (-[HTMLElement title]): (-[HTMLElement setTitle:]): (-[HTMLElement lang]): (-[HTMLElement setLang:]): (-[HTMLElement dir]): (-[HTMLElement setDir:]): (-[HTMLElement className]): (-[HTMLElement setClassName:]): (-[HTMLDocument _HTMLDocumentImpl]): (-[HTMLDocument title]): (-[HTMLDocument setTitle:]): (-[HTMLDocument referrer]): (-[HTMLDocument domain]): (-[HTMLDocument URL]): (-[HTMLDocument body]): (-[HTMLDocument images]): (-[HTMLDocument applets]): (-[HTMLDocument links]): (-[HTMLDocument forms]): (-[HTMLDocument anchors]): (-[HTMLDocument setBody:]): (-[HTMLDocument cookie]): (-[HTMLDocument setCookie:]): (-[HTMLDocument open]): (-[HTMLDocument close]): (-[HTMLDocument write:]): (-[HTMLDocument writeln:]): (-[HTMLDocument getElementById:]): (-[HTMLDocument getElementsByName:]): (-[HTMLHtmlElement _HTMLHtmlElementImpl]): (-[HTMLHtmlElement version]): (-[HTMLHtmlElement setVersion:]): (-[HTMLHeadElement _headElementImpl]): (-[HTMLHeadElement profile]): (-[HTMLHeadElement setProfile:]): (-[HTMLLinkElement _linkElementImpl]): (-[HTMLLinkElement disabled]): (-[HTMLLinkElement setDisabled:]): (-[HTMLLinkElement charset]): (-[HTMLLinkElement setCharset:]): (-[HTMLLinkElement href]): (-[HTMLLinkElement setHref:]): (-[HTMLLinkElement hreflang]): (-[HTMLLinkElement setHreflang:]): (-[HTMLLinkElement media]): (-[HTMLLinkElement setMedia:]): (-[HTMLLinkElement rel]): (-[HTMLLinkElement setRel:]): (-[HTMLLinkElement rev]): (-[HTMLLinkElement setRev:]): (-[HTMLLinkElement target]): (-[HTMLLinkElement setTarget:]): (-[HTMLLinkElement type]): (-[HTMLLinkElement setType:]): (-[HTMLTitleElement _titleElementImpl]): (-[HTMLTitleElement text]): (-[HTMLTitleElement setText:]): (-[HTMLMetaElement _metaElementImpl]): (-[HTMLMetaElement content]): (-[HTMLMetaElement setContent:]): (-[HTMLMetaElement httpEquiv]): (-[HTMLMetaElement setHttpEquiv:]): (-[HTMLMetaElement name]): (-[HTMLMetaElement setName:]): (-[HTMLMetaElement scheme]): (-[HTMLMetaElement setScheme:]): (-[HTMLBaseElement _baseElementImpl]): (-[HTMLBaseElement href]): (-[HTMLBaseElement setHref:]): (-[HTMLBaseElement target]): (-[HTMLBaseElement setTarget:]): (-[HTMLStyleElement _styleElementImpl]): (-[HTMLStyleElement disabled]): (-[HTMLStyleElement setDisabled:]): (-[HTMLStyleElement media]): (-[HTMLStyleElement setMedia:]): (-[HTMLStyleElement type]): (-[HTMLStyleElement setType:]): (-[HTMLBodyElement _bodyElementImpl]): (-[HTMLBodyElement aLink]): (-[HTMLBodyElement setALink:]): (-[HTMLBodyElement background]): (-[HTMLBodyElement setBackground:]): (-[HTMLBodyElement bgColor]): (-[HTMLBodyElement setBgColor:]): (-[HTMLBodyElement link]): (-[HTMLBodyElement setLink:]): (-[HTMLBodyElement text]): (-[HTMLBodyElement setText:]): (-[HTMLBodyElement vLink]): (-[HTMLBodyElement setVLink:]):
1:21 PM Changeset in webkit [6220] by hyatt
  • 2 edits in trunk/WebCore

Fix for problem when undoing the deletion of a word in edit mode.

Reviewed by kocienda

  • khtml/rendering/render_text.cpp: (RenderText::setTextWithOffset):
11:27 AM Changeset in webkit [6219] by kocienda
  • 14 edits in trunk

WebCore:

Reviewed by Chris

  • khtml/khtml_part.cpp: (KHTMLPart::handleMouseMoveEventSelection): Clear the selection's "modify bias" since the user clicked, and is therefore no longer extending the selection with arrow keys.
  • khtml/khtml_selection.cpp: (KHTMLSelection::KHTMLSelection): Add new m_modifyBiasSet flag. (KHTMLSelection::init): Set the flag to false by default. (KHTMLSelection::operator=): Copy over the value of the new m_modifyBiasSet flag. (KHTMLSelection::modify): Set the flag if extending the selection and set the base and extent nodes based on the movement direction requested.
  • khtml/khtml_selection.h:
  • kwq/WebCoreBridge.h: See below.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge rangeByAlteringCurrentSelection:direction:granularity:]): This method is used by the WebKit side in response to requests to change the selection using the arrow keys. It used to be called rangeByModifyingRange:alteration:direction:granularity: but I changed it to this new format since I explicitly want to use the current selection, and not some arbitrarily passed in selection. This helps to maintain the "modify bias" correctly. (-[WebCoreBridge alterCurrentSelection:direction:granularity:]): New method. A command to alter the current selection as given. Again, applying the command to the current selection, rather than just setting the selection to a new one, helps to maintain the "modify bias" correctly.

WebKit:

Reviewed by Chris

  • WebView.subproj/WebView.m: (-[WebView _alterCurrentSelection:direction:granularity:]): Changed name from _alterSelection:direction:granularity: to give a little extra clarity. Also, the body calls through to renamed rangeByAlteringCurrentSelection:direction:granularity: in WebCore. (-[WebView moveRight:]): Now calls renamed _alterCurrentSelection:direction:granularity:. (-[WebView moveRightAndModifySelection:]): Ditto. (-[WebView moveLeft:]): Ditto. (-[WebView moveLeftAndModifySelection:]): Ditto.
11:20 AM Changeset in webkit [6218] by sullivan
  • 1 edit in trunk/WebKit/DOM.subproj/DOM.h
  • fixed the following bugs: <rdar://problem/3584028>: Consider disallowing "View Source" for inline error pages <rdar://problem/3584029>: "View Source" for inline error pages shows URL of "about:blank" <rdar://problem/3584272>: Location field should be focused after a page-load error page is displayed <rdar://problem/3586611>: REGRESSION (128): After option-pressing b/f button, selecting a menu item downloads it
  • simplified some code

Reviewed by Chris.

  • BrowserDocument.h:
  • BrowserDocument.m: removed goBack: and goForward:; all callers now use these methods on BrowserWindowController instead. (-[BrowserDocument goToItemInBackOrForwardMenu:]): renamed from goToItem: for clarity, now ignores the Option key to avoid downloading when the user pressed Option to see URLs in the menu (-[BrowserDocument _addItem:toMenu:]): updated for name change (-[BrowserDocument canViewSource]): new method, extracted from validateUserInterfaceItem. Now also returns NO if the current page is an error page. (-[BrowserDocument validateUserInterfaceItem:]): now calls extracted method (-[BrowserDocument viewSource:]): now bails out early if canViewSource returns NO
  • BrowserWindowController.m: (-[BrowserWindowController webFrameLoadCommitted:]): if we're showing an error page now, move focus to location field (rather than webview as in the normal case)
  • Test/PageLoadTestRunner.m: (-[PageLoadTestRunner goBack]): call through browserWindowController; this was the only remaining caller of -[BrowserDocument goBack:] or -[BrowserDocument goForward:]
Note: See TracTimeline for information about the timeline view.