Timeline

Mar 22, 2004:

6:40 PM Changeset in webkit [6244] by hyatt

• 20 edits in trunk/WebCore

Wire up NSSearchField to WebCore. Add support for placeholder strings, autosaving of recent items, the ability to show/hide
the magnifying glass search button, the ability to specify the maximum number of results, the ability to specify an incremental
search or not, etc. Added a DOM event that fires when the search field indicates that search results should be updated.

Reviewed by darin

• khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): (DOMNode::putValue):
• khtml/ecma/kjs_dom.h: (KJS::DOMNode::):
• khtml/ecma/kjs_dom.lut.h: (KJS::):
• khtml/ecma/kjs_window.cpp: (Window::get): (Window::put):
• khtml/ecma/kjs_window.h: (KJS::Window::):
• khtml/ecma/kjs_window.lut.h: (KJS::):
• khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::parseHTMLAttribute):
• khtml/html/html_formimpl.h: (DOM::HTMLInputElementImpl::maxResults):
• khtml/misc/htmlattrs.c: (hash_attr): (findAttr):
• khtml/misc/htmlattrs.h:
• khtml/misc/htmlattrs.in:
• khtml/rendering/render_form.cpp: (RenderLineEdit::RenderLineEdit): (RenderLineEdit::slotPerformSearch): (RenderLineEdit::updateFromElement):
• khtml/rendering/render_form.h:
• khtml/xml/dom2_eventsimpl.cpp: (EventImpl::typeToId): (EventImpl::idToType):
• khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::):
• kwq/KWQLineEdit.h: (QLineEdit::performSearch): (QLineEdit::type):
• kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit): (QLineEdit::setLiveSearch): (QLineEdit::setAutoSaveName): (QLineEdit::setMaxResults): (QLineEdit::setPlaceholderString):
• kwq/KWQSlot.mm: (KWQSlot::KWQSlot): (KWQSlot::call):
• kwq/KWQTextField.mm: (-[KWQTextFieldController initWithTextField:QLineEdit:]): (-[KWQTextFieldController invalidate]): (-[KWQTextFieldController action:]): (-[KWQTextFieldController controlTextDidBeginEditing:]): (-[KWQTextFieldController controlTextDidEndEditing:]): (-[KWQTextFieldController controlTextDidChange:]): (-[KWQTextFieldController control:textShouldBeginEditing:]): (-[KWQTextFieldController control:textShouldEndEditing:]): (-[KWQTextFieldController control:didFailToFormatString:errorDescription:]): (-[KWQTextFieldController control:didFailToValidatePartialString:errorDescription:]): (-[KWQTextFieldController control:isValidObject:]): (-[KWQTextFieldController control:textView:doCommandBySelector:]): (-[KWQTextFieldController textChanged]):

4:17 PM Changeset in webkit [6243] by hyatt

• 9 edits in trunk/WebCore

Factoring of form control code to enable sharing between three types of text fields: normal, password, and
the new search field. Also made search field creatable using <input type="search">. There are still many
bugs with the field, but you can at least type in it and submit it with a form.

Reviewed by darin

• khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::setType): (HTMLInputElementImpl::type): (HTMLInputElementImpl::click): (HTMLInputElementImpl::accessKeyAction): (HTMLInputElementImpl::rendererIsNeeded): (HTMLInputElementImpl::createRenderer): (HTMLInputElementImpl::encoding): (HTMLInputElementImpl::defaultEventHandler): (HTMLInputElementImpl::isEditable):
• khtml/html/html_formimpl.h: (DOM::HTMLInputElementImpl::):
• khtml/rendering/render_form.cpp: (RenderLineEdit::RenderLineEdit):
• kwq/KWQKLineEdit.h: (KLineEdit::KLineEdit):
• kwq/KWQLineEdit.h: (QLineEdit::):
• kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit): (QLineEdit::~QLineEdit): (QLineEdit::setFont): (QLineEdit::setText): (QLineEdit::text): (QLineEdit::setMaxLength): (QLineEdit::isReadOnly): (QLineEdit::setReadOnly): (QLineEdit::maxLength): (QLineEdit::selectAll): (QLineEdit::edited): (QLineEdit::setEdited): (QLineEdit::sizeForCharacterWidth): (QLineEdit::baselinePosition): (QLineEdit::setAlignment): (QLineEdit::setWritingDirection): (KWQNSTextAlignmentForAlignmentFlags): (QLineEdit::setLiveSearch):
• kwq/KWQTextField.h:
• kwq/KWQTextField.mm: (-[KWQTextFieldController initWithTextField:QLineEdit:]): (-[KWQTextFieldController action:]): (-[KWQTextFieldController dealloc]): (-[KWQTextFieldController widget]): (-[KWQTextFieldController setMaximumLength:]): (-[KWQTextFieldController controlTextDidBeginEditing:]): (-[KWQTextFieldController controlTextDidEndEditing:]): (-[KWQTextFieldController controlTextDidChange:]): (-[KWQTextFieldController control:textShouldBeginEditing:]): (-[KWQTextFieldController control:textShouldEndEditing:]): (-[KWQTextFieldController control:didFailToFormatString:errorDescription:]): (-[KWQTextFieldController control:didFailToValidatePartialString:errorDescription:]): (-[KWQTextFieldController control:isValidObject:]): (-[KWQTextFieldController control:textView:doCommandBySelector:]): (-[KWQTextFieldController textChanged]): (-[KWQTextFieldController setInDrawingMachinery:]): (-[KWQTextFieldController textView:shouldDrawInsertionPointInRect:color:turnedOn:]): (-[KWQTextFieldController textView:shouldHandleEvent:]): (-[KWQTextFieldController textView:didHandleEvent:]): (-[KWQTextFieldController setBaseWritingDirection:]): (-[KWQTextFieldController baseWritingDirection]): (-[KWQTextFieldController selectedRange]): (-[KWQTextFieldController setSelectedRange:]): (-[KWQTextFieldController setHasFocus:]): (-[KWQTextFieldController updateTextAttributes:]): (+[KWQTextField cellClass]): (-[KWQTextField initWithQLineEdit:]): (-[KWQTextField dealloc]): (-[KWQTextField controller]): (-[KWQTextField widget]): (-[KWQTextField selectText:]): (-[KWQTextField setStringValue:]): (-[KWQTextField nextKeyView]): (-[KWQTextField previousKeyView]): (-[KWQTextField nextValidKeyView]): (-[KWQTextField previousValidKeyView]): (-[KWQTextField acceptsFirstResponder]): (-[KWQTextField display]): (-[KWQTextField displayRectIgnoringOpacity:]): (-[KWQTextField textView:shouldDrawInsertionPointInRect:color:turnedOn:]): (-[KWQTextField textView:shouldHandleEvent:]): (-[KWQTextField textView:didHandleEvent:]): (-[KWQTextFieldCell editWithFrame:inView:editor:delegate:event:]): (-[KWQTextFieldCell selectWithFrame:inView:editor:delegate:start:length:]): (-[KWQTextFieldCell _textAttributes]): (-[KWQSecureTextField initWithQLineEdit:]): (-[KWQSecureTextField dealloc]): (-[KWQSecureTextField controller]): (-[KWQSecureTextField widget]): (-[KWQSecureTextField setStringValue:]): (-[KWQSecureTextField nextKeyView]): (-[KWQSecureTextField previousKeyView]): (-[KWQSecureTextField acceptsFirstResponder]): (-[KWQSecureTextField display]): (-[KWQSecureTextField displayRectIgnoringOpacity:]): (-[KWQSecureTextField textView:shouldDrawInsertionPointInRect:color:turnedOn:]): (-[KWQSecureTextField textView:shouldHandleEvent:]): (-[KWQSecureTextField textView:didHandleEvent:]): (-[KWQSecureTextField selectText:]): (-[KWQSecureTextFieldCell editWithFrame:inView:editor:delegate:event:]): (-[KWQSecureTextFieldCell selectWithFrame:inView:editor:delegate:start:length:]): (-[KWQSecureTextFieldCell _textAttributes]): (+[KWQSearchField cellClass]): (-[KWQSearchField initWithQLineEdit:]): (-[KWQSearchField dealloc]): (-[KWQSearchField controller]): (-[KWQSearchField widget]): (-[KWQSearchField selectText:]): (-[KWQSearchField setStringValue:]): (-[KWQSearchField nextKeyView]): (-[KWQSearchField previousKeyView]): (-[KWQSearchField nextValidKeyView]): (-[KWQSearchField previousValidKeyView]): (-[KWQSearchField acceptsFirstResponder]): (-[KWQSearchField display]): (-[KWQSearchField displayRectIgnoringOpacity:]): (-[KWQSearchField textView:shouldDrawInsertionPointInRect:color:turnedOn:]): (-[KWQSearchField textView:shouldHandleEvent:]): (-[KWQSearchField textView:didHandleEvent:]): (-[KWQSearchFieldCell editWithFrame:inView:editor:delegate:event:]): (-[KWQSearchFieldCell selectWithFrame:inView:editor:delegate:start:length:]): (-[KWQSearchFieldCell _textAttributes]): (-[KWQTextFieldFormatter init]): (-[KWQTextFieldFormatter setMaximumLength:]): (-[KWQTextFieldFormatter maximumLength]): (-[KWQTextFieldFormatter stringForObjectValue:]): (-[KWQTextFieldFormatter getObjectValue:forString:errorDescription:]): (-[KWQTextFieldFormatter isPartialStringValid:newEditingString:errorDescription:]): (-[KWQTextFieldFormatter attributedStringForObjectValue:withDefaultAttributes:]): (-[NSString _KWQ_truncateToNumComposedCharacterSequences:]): (-[NSTextField _KWQ_currentEditor]):

Mar 19, 2004:

3:31 PM Changeset in webkit [6242] by vicki

• 3 edits in trunk

changed version number from '133' to '134u'. The tree is open!

3:27 PM Changeset in webkit [6241]

• 3 copies in tags/Safari-133

This commit was manufactured by cvs2svn to create tag 'Safari-133'.

3:27 PM Changeset in webkit [6240] by vicki

• 6 edits in trunk

• Safari-133 stamp

8:40 AM Changeset in webkit [6239] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by Ken.

• fixed problem with methods like setUTCHour

• kjs/date_object.cpp: (DateProtoFuncImp::call): Fix conversion back to time_t to use the appropriate GMT vs. local time function based on the utc flag.

8:40 AM Changeset in webkit [6238] by darin

• 2 edits in trunk/WebCore

Reviewed by Ken.

• fixed <rdar://problem/3583945>: crash when choosing a file to upload

• kwq/KWQFileButton.mm: (-[KWQFileButtonAdapter dealloc]): Removed unneeded method. (-[KWQFileButtonAdapter filenameChanged:]): Check for nil. (-[KWQFileButtonAdapter focusChanged:]): Ditto. (-[KWQFileButtonAdapter clicked]): Ditto.