Timeline



Mar 24, 2004:

11:37 AM Changeset in webkit [6255] by darin
  • 4 edits in trunk

WebCore:

Reviewed by John.

  • fixed <rdar://problem/3566805>: REGRESSION: When the subject of mailto is 2 byte Safari failed to send mail address and subject to Mail.app
  • kwq/KWQKURL.mm: (KURL::findHostnamesInMailToURL): Update to handle hostnames that end just before a '?' since a '?' ends the entire part of the URL that can contain hostnames. Also change the logic so that the '?' will successfully end the search.

WebKit:

Reviewed by John.

  • fixed <rdar://problem/3566805>: REGRESSION: When the subject of mailto is 2 byte Safari failed to send mail address and subject to Mail.app
  • Misc.subproj/WebNSURLExtras.m: (applyHostNameFunctionToMailToURLString): Update to handle hostnames that end just before a '?' since a '?' ends the entire part of the URL that can contain hostnames. Also change the logic so that the '?' will successfully end the search.
11:21 AM Changeset in webkit [6254] by darin
  • 2 edits in trunk/WebCore

Tests:

  • TestURLs.h: Update comment to reflect change in behavior.
  • kde/kurl-relative-test.chk: Update results to reflect "compatibility" result.
  • kde/kurl-test.chk: Update results to reflect "compatibility" result.

WebCore:

Reviewed by John.

  • fixed <rdar://problem/3599650>: main image missing due to incorrect relative URL resolution at www.brother.com
  • kwq/KWQKURL.mm: (KURL::KURL): Implement compatibility rule from the URI RFC. If a URL has a scheme, but does not start with the "/" character, and the scheme matches the base URL, then treat it as a relative URL.
11:16 AM Changeset in webkit [6253] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by me

  • DOM.subproj/DOMHTML.h: Checking in copied over version of modified file.
10:31 AM Changeset in webkit [6252] by kocienda
  • 4 edits in trunk/WebCore

Reviewed by me.

I neglected to check in these required changes when I landed previously.
This is what I get for trying to commit when I had other changes in
my tree.

  • khtml/dom/html_form.cpp: (HTMLSelectElement::add): Uses new-style call.
  • khtml/html/html_formimpl.cpp: (HTMLSelectElementImpl::add): Change the interface for this call to use impl objects instead of API objects. This works around the fact that the API object's constructor that takes an impl is protected.
  • khtml/html/html_formimpl.h: Uses new-style call.
8:23 AM Changeset in webkit [6251] by kocienda
  • 3 edits in trunk/WebCore

Implemented the remainder of the HTML DOM API.

Reviewed by Chris.

  • kwq/DOMHTML.h
  • kwq/HTMLDOM.mm

Mar 23, 2004:

4:56 PM Changeset in webkit [6250] by hyatt
  • 13 edits in trunk/WebCore

Fix for 3487207, implement onscroll DOM event for elements with overflow:auto/scroll/hidden. This does
not handle firing onscroll on the window when the document scrolls, nor does it handle firing onscroll
on textareas. These are two separate bugs.

This patch finishes stubbing out the onscroll event and adds support for it to the DOM. It also supports
the firing of the event when overflow blocks scroll.

Reviewed by darin

  • khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): (DOMNode::putValue):
  • khtml/ecma/kjs_dom.h: (KJS::DOMNode::):
  • khtml/ecma/kjs_dom.lut.h: (KJS::):
  • khtml/ecma/kjs_window.cpp: (Window::get): (Window::put):
  • khtml/ecma/kjs_window.h: (KJS::Window::):
  • khtml/ecma/kjs_window.lut.h: (KJS::):
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseHTMLAttribute):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseHTMLAttribute):
  • khtml/misc/htmlattrs.c: (hash_attr): (findAttr):
  • khtml/misc/htmlattrs.h:
  • khtml/misc/htmlattrs.in:
  • khtml/rendering/render_layer.cpp: (RenderLayer::scrollToOffset):
3:21 PM Changeset in webkit [6249] by rjw
  • 10 edits
    2 adds in trunk/JavaScriptCore

Added implementation of KJS::Value <-> NP_Object conversion functions.
Augmented test program for 'C' bindings.
Added asserts and parameter checking to all public API.

Reviewed by Ken.

  • JavaScriptCore.pbproj/project.pbxproj:
  • bindings/NP_jsobject.cpp: (NP_ToString):
  • bindings/NP_jsobject.h: Added.
  • bindings/NP_runtime.cpp: (NP_IdentifierFromUTF8): (NP_IsValidIdentifier): (NP_GetIdentifiers): (NP_CreateObject): (NP_RetainObject): (NP_ReleaseObject): (NP_IsKindOfClass): (NP_SetExceptionWithUTF8): (NP_SetException): (NP_IntFromNumber): (NP_FloatFromNumber): (NP_DoubleFromNumber): (NP_CreateStringWithUTF8): (NP_CreateStringWithUTF16): (NP_DeallocateUTF8): (NP_UTF8FromString): (NP_UTF16FromString): (NP_StringLength): (NP_BoolFromBoolean):
  • bindings/NP_runtime.h:
  • bindings/c/c_instance.cpp: (CInstance::invokeMethod):
  • bindings/c/c_utility.cpp: (coerceValueToNPString): (convertValueToNPValueType): (convertNPValueTypeToValue):
  • bindings/c/c_utility.h:
  • bindings/test.js:
  • bindings/testC.js: Added.
  • bindings/testbindings.cpp: (logMessage): (setDoubleValue): (setIntValue): (setStringValue): (setBooleanValue): (getDoubleValue): (getIntValue): (getStringValue): (getBooleanValue): (myInterfaceInvoke): (myInterfaceAllocate):
2:56 PM Changeset in webkit [6248] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3513627, HTML mail prints upside down occasionally. Change printing so that it never resizes the
WebHTMLView when formatting for printing. When computing page rects, instead of using the view's bounds,
use the root layer's width instead.

Reviewed by darin

  • khtml/khtmlview.cpp: (KHTMLView::layout):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]):
2:55 PM Changeset in webkit [6247] by hyatt
  • 2 edits in trunk/WebKit

Fix for 3513627, HTML mail prints upside down occasionally. Change printing so that it never resizes the
WebHTMLView when formatting for printing. When computing page rects, instead of using the view's bounds,
use the root layer's width instead.

Reviewed by darin

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView knowsPageRange:]):
1:05 PM Changeset in webkit [6246] by hyatt
  • 2 edits in trunk/WebCore

Fix for crasher 3598204, previousKeyView was calling nextKeyView instead.

Reviewed by darin

  • kwq/KWQTextField.mm: (-[KWQTextField previousKeyView]): (-[KWQSecureTextField previousKeyView]): (-[KWQSearchField previousKeyView]):
11:04 AM Changeset in webkit [6245] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Vicki.

  • fixed deployment build
  • kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit): Move view initializer inside block with exceptions blocked.

Mar 22, 2004:

6:40 PM Changeset in webkit [6244] by hyatt
  • 20 edits in trunk/WebCore

Wire up NSSearchField to WebCore. Add support for placeholder strings, autosaving of recent items, the ability to show/hide
the magnifying glass search button, the ability to specify the maximum number of results, the ability to specify an incremental
search or not, etc. Added a DOM event that fires when the search field indicates that search results should be updated.

Reviewed by darin

  • khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): (DOMNode::putValue):
  • khtml/ecma/kjs_dom.h: (KJS::DOMNode::):
  • khtml/ecma/kjs_dom.lut.h: (KJS::):
  • khtml/ecma/kjs_window.cpp: (Window::get): (Window::put):
  • khtml/ecma/kjs_window.h: (KJS::Window::):
  • khtml/ecma/kjs_window.lut.h: (KJS::):
  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::parseHTMLAttribute):
  • khtml/html/html_formimpl.h: (DOM::HTMLInputElementImpl::maxResults):
  • khtml/misc/htmlattrs.c: (hash_attr): (findAttr):
  • khtml/misc/htmlattrs.h:
  • khtml/misc/htmlattrs.in:
  • khtml/rendering/render_form.cpp: (RenderLineEdit::RenderLineEdit): (RenderLineEdit::slotPerformSearch): (RenderLineEdit::updateFromElement):
  • khtml/rendering/render_form.h:
  • khtml/xml/dom2_eventsimpl.cpp: (EventImpl::typeToId): (EventImpl::idToType):
  • khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::):
  • kwq/KWQLineEdit.h: (QLineEdit::performSearch): (QLineEdit::type):
  • kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit): (QLineEdit::setLiveSearch): (QLineEdit::setAutoSaveName): (QLineEdit::setMaxResults): (QLineEdit::setPlaceholderString):
  • kwq/KWQSlot.mm: (KWQSlot::KWQSlot): (KWQSlot::call):
  • kwq/KWQTextField.mm: (-[KWQTextFieldController initWithTextField:QLineEdit:]): (-[KWQTextFieldController invalidate]): (-[KWQTextFieldController action:]): (-[KWQTextFieldController controlTextDidBeginEditing:]): (-[KWQTextFieldController controlTextDidEndEditing:]): (-[KWQTextFieldController controlTextDidChange:]): (-[KWQTextFieldController control:textShouldBeginEditing:]): (-[KWQTextFieldController control:textShouldEndEditing:]): (-[KWQTextFieldController control:didFailToFormatString:errorDescription:]): (-[KWQTextFieldController control:didFailToValidatePartialString:errorDescription:]): (-[KWQTextFieldController control:isValidObject:]): (-[KWQTextFieldController control:textView:doCommandBySelector:]): (-[KWQTextFieldController textChanged]):
4:17 PM Changeset in webkit [6243] by hyatt
  • 9 edits in trunk/WebCore

Factoring of form control code to enable sharing between three types of text fields: normal, password, and
the new search field. Also made search field creatable using <input type="search">. There are still many
bugs with the field, but you can at least type in it and submit it with a form.

Reviewed by darin

  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::setType): (HTMLInputElementImpl::type): (HTMLInputElementImpl::click): (HTMLInputElementImpl::accessKeyAction): (HTMLInputElementImpl::rendererIsNeeded): (HTMLInputElementImpl::createRenderer): (HTMLInputElementImpl::encoding): (HTMLInputElementImpl::defaultEventHandler): (HTMLInputElementImpl::isEditable):
  • khtml/html/html_formimpl.h: (DOM::HTMLInputElementImpl::):
  • khtml/rendering/render_form.cpp: (RenderLineEdit::RenderLineEdit):
  • kwq/KWQKLineEdit.h: (KLineEdit::KLineEdit):
  • kwq/KWQLineEdit.h: (QLineEdit::):
  • kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit): (QLineEdit::~QLineEdit): (QLineEdit::setFont): (QLineEdit::setText): (QLineEdit::text): (QLineEdit::setMaxLength): (QLineEdit::isReadOnly): (QLineEdit::setReadOnly): (QLineEdit::maxLength): (QLineEdit::selectAll): (QLineEdit::edited): (QLineEdit::setEdited): (QLineEdit::sizeForCharacterWidth): (QLineEdit::baselinePosition): (QLineEdit::setAlignment): (QLineEdit::setWritingDirection): (KWQNSTextAlignmentForAlignmentFlags): (QLineEdit::setLiveSearch):
  • kwq/KWQTextField.h:
  • kwq/KWQTextField.mm: (-[KWQTextFieldController initWithTextField:QLineEdit:]): (-[KWQTextFieldController action:]): (-[KWQTextFieldController dealloc]): (-[KWQTextFieldController widget]): (-[KWQTextFieldController setMaximumLength:]): (-[KWQTextFieldController controlTextDidBeginEditing:]): (-[KWQTextFieldController controlTextDidEndEditing:]): (-[KWQTextFieldController controlTextDidChange:]): (-[KWQTextFieldController control:textShouldBeginEditing:]): (-[KWQTextFieldController control:textShouldEndEditing:]): (-[KWQTextFieldController control:didFailToFormatString:errorDescription:]): (-[KWQTextFieldController control:didFailToValidatePartialString:errorDescription:]): (-[KWQTextFieldController control:isValidObject:]): (-[KWQTextFieldController control:textView:doCommandBySelector:]): (-[KWQTextFieldController textChanged]): (-[KWQTextFieldController setInDrawingMachinery:]): (-[KWQTextFieldController textView:shouldDrawInsertionPointInRect:color:turnedOn:]): (-[KWQTextFieldController textView:shouldHandleEvent:]): (-[KWQTextFieldController textView:didHandleEvent:]): (-[KWQTextFieldController setBaseWritingDirection:]): (-[KWQTextFieldController baseWritingDirection]): (-[KWQTextFieldController selectedRange]): (-[KWQTextFieldController setSelectedRange:]): (-[KWQTextFieldController setHasFocus:]): (-[KWQTextFieldController updateTextAttributes:]): (+[KWQTextField cellClass]): (-[KWQTextField initWithQLineEdit:]): (-[KWQTextField dealloc]): (-[KWQTextField controller]): (-[KWQTextField widget]): (-[KWQTextField selectText:]): (-[KWQTextField setStringValue:]): (-[KWQTextField nextKeyView]): (-[KWQTextField previousKeyView]): (-[KWQTextField nextValidKeyView]): (-[KWQTextField previousValidKeyView]): (-[KWQTextField acceptsFirstResponder]): (-[KWQTextField display]): (-[KWQTextField displayRectIgnoringOpacity:]): (-[KWQTextField textView:shouldDrawInsertionPointInRect:color:turnedOn:]): (-[KWQTextField textView:shouldHandleEvent:]): (-[KWQTextField textView:didHandleEvent:]): (-[KWQTextFieldCell editWithFrame:inView:editor:delegate:event:]): (-[KWQTextFieldCell selectWithFrame:inView:editor:delegate:start:length:]): (-[KWQTextFieldCell _textAttributes]): (-[KWQSecureTextField initWithQLineEdit:]): (-[KWQSecureTextField dealloc]): (-[KWQSecureTextField controller]): (-[KWQSecureTextField widget]): (-[KWQSecureTextField setStringValue:]): (-[KWQSecureTextField nextKeyView]): (-[KWQSecureTextField previousKeyView]): (-[KWQSecureTextField acceptsFirstResponder]): (-[KWQSecureTextField display]): (-[KWQSecureTextField displayRectIgnoringOpacity:]): (-[KWQSecureTextField textView:shouldDrawInsertionPointInRect:color:turnedOn:]): (-[KWQSecureTextField textView:shouldHandleEvent:]): (-[KWQSecureTextField textView:didHandleEvent:]): (-[KWQSecureTextField selectText:]): (-[KWQSecureTextFieldCell editWithFrame:inView:editor:delegate:event:]): (-[KWQSecureTextFieldCell selectWithFrame:inView:editor:delegate:start:length:]): (-[KWQSecureTextFieldCell _textAttributes]): (+[KWQSearchField cellClass]): (-[KWQSearchField initWithQLineEdit:]): (-[KWQSearchField dealloc]): (-[KWQSearchField controller]): (-[KWQSearchField widget]): (-[KWQSearchField selectText:]): (-[KWQSearchField setStringValue:]): (-[KWQSearchField nextKeyView]): (-[KWQSearchField previousKeyView]): (-[KWQSearchField nextValidKeyView]): (-[KWQSearchField previousValidKeyView]): (-[KWQSearchField acceptsFirstResponder]): (-[KWQSearchField display]): (-[KWQSearchField displayRectIgnoringOpacity:]): (-[KWQSearchField textView:shouldDrawInsertionPointInRect:color:turnedOn:]): (-[KWQSearchField textView:shouldHandleEvent:]): (-[KWQSearchField textView:didHandleEvent:]): (-[KWQSearchFieldCell editWithFrame:inView:editor:delegate:event:]): (-[KWQSearchFieldCell selectWithFrame:inView:editor:delegate:start:length:]): (-[KWQSearchFieldCell _textAttributes]): (-[KWQTextFieldFormatter init]): (-[KWQTextFieldFormatter setMaximumLength:]): (-[KWQTextFieldFormatter maximumLength]): (-[KWQTextFieldFormatter stringForObjectValue:]): (-[KWQTextFieldFormatter getObjectValue:forString:errorDescription:]): (-[KWQTextFieldFormatter isPartialStringValid:newEditingString:errorDescription:]): (-[KWQTextFieldFormatter attributedStringForObjectValue:withDefaultAttributes:]): (-[NSString _KWQ_truncateToNumComposedCharacterSequences:]): (-[NSTextField _KWQ_currentEditor]):
Note: See TracTimeline for information about the timeline view.