Timeline



Mar 26, 2004:

5:56 PM Changeset in webkit [6266] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3600642, letter magnet demo doesn't update until mouse move. This patch also fixes problems
with the animated text Gecko DOM demos on developer.netscape.com. Make sure that timer callbacks via
setTimeout always updateRendering after executing the JS code.

Reviewed by darin

  • khtml/ecma/kjs_window.cpp: (ScheduledAction::execute):
1:49 PM Changeset in webkit [6265] by sullivan
  • 3 edits in trunk/WebKit

WebKit:

  • fixed <rdar://problem/3576334>: Printing "empty" page gives print error, leaves browser window UI broken

Reviewed by Dave.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView knowsPageRange:]): AppKit printing mechanism can't handle the case where you tell it there is nothing at all to print, so when we hit that case we give it a degenerate 1-pixel rect to print. This prints a blank page (with correctly-placed header & footer if so configured), which matches other browsers' behavior for this page.
  • Plugins.subproj/npruntime.h: cvs keeps thinking I've removed a blank line from this auto-copied file. Richard said to just check it in to see if it stops doing this.

WebBrowser:

fixed <rdar://problem/3603092>: "new folder" menu item is enabled but
does nothing when current collection is history

Reviewed by Dave.

  • BookmarksViewController.m: (-[BookmarksViewController newBookmarkFolder:]): If displayed contents can't accept new items, make a new collection even if outline view is focused.
9:46 AM Changeset in webkit [6264] by vicki
  • 3 edits in trunk
  • change version number from 134 to 135u. the tree is open!
9:42 AM Changeset in webkit [6263]
  • 3 copies in tags/Safari-134

This commit was manufactured by cvs2svn to create tag 'Safari-134'.

9:42 AM Changeset in webkit [6262] by vicki
  • 6 edits in trunk
  • Safari-134 stamp
6:22 AM Changeset in webkit [6261] by sullivan
  • 3 edits in trunk/WebKit
  • fixed the following bugs:

<rdar://problem/3601630>: command-modified keypresses that would activate links are ignored by WebKit
<rdar://problem/3601604>: WebActionModifierFlagsKey not set correctly for modified keypresses that activate links
<rdar://problem/3544946>: cmd-return should open a link in a new tab

Reviewed by Darin.

  • WebView.subproj/WebFrame.m: (-[WebFrame _actionInformationForNavigationType:event:originalURL:]): Pass modifier flags always, not just for mouse events. This fixes 3601604.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView performKeyEquivalent:]): Give the bridge a chance to intercept command-modified keypresses. This fixes 3601630.

Together these two changes fix 3544946.

Mar 25, 2004:

5:34 PM Changeset in webkit [6260] by hyatt
  • 17 edits in trunk

WebCore:

Implement the rest of the search field. Make it work with form submission. Implement onscroll at
the document level.

Reviewed by darin

  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::submit):
  • khtml/rendering/render_form.cpp: (RenderLineEdit::addSearchResult):
  • khtml/rendering/render_form.h:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendScrollEvent):
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: (QLineEdit::setMaxResults): (QLineEdit::setPlaceholderString): (QLineEdit::addSearchResult):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge sendScrollEvent]):
  • kwq/WebCoreViewFactory.h:

WebKit:

Implement the rest of the search field.

Implement onscroll at the document level.

Reviewed by darin

  • English.lproj/Localizable.strings:
  • WebCoreSupport.subproj/WebBridge.m:
  • WebCoreSupport.subproj/WebViewFactory.m: (-[NSMenu addItemWithTitle:action:tag:]): (-[WebViewFactory submitButtonDefaultLabel]): (-[WebViewFactory cellMenuForSearchField]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _frameOrBoundsChanged]): (-[WebHTMLView viewDidMoveToWindow]):
  • WebView.subproj/WebHTMLViewPrivate.h:
5:32 PM Changeset in webkit [6259] by rjw
  • 1 add in trunk/WebKit/Plugins.subproj/npfunctions.h

Oops, forget to commit this file.

2:58 PM Changeset in webkit [6258] by rjw
  • 9 edits
    1 add in trunk/WebKit

Netscape plugin API header cleanup.

Replaced our hacked up version of npapi.h with the
"official SDK" npapi.h. Moved our changes to the new
npfunctions.h. npfunctions.h really replaces what was defined in
the Netscape npupp.h header. However, rather than use the "official SDK"
npupp.h I think the cleaner npfunctions.h is better. npupp.h actually
has a bunch of Mac classic specific stuff that is no longer needed.

Copied npruntime.h to WebKit using Ken's copy-o-matic mechanism.

Made npapi.h, npruntime.h, and npfunctions.h SPI. With a bit
more consideration they will become API. They will also eventually be made
available for other platforms/vendors are mozilla.org.

Reviewed by Ken.

  • Plugins.subproj/WebBaseNetscapePluginStream.h:
  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]):
  • Plugins.subproj/WebBaseNetscapePluginView.h:
  • Plugins.subproj/WebNetscapePluginPackage.h:
  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
  • Plugins.subproj/npapi.h:
  • Plugins.subproj/npruntime.h: Added.
  • WebKit.pbproj/project.pbxproj:
  • copy-webcore-files-to-webkit:
10:53 AM Changeset in webkit [6257] by hyatt
  • 5 edits in trunk/WebCore

Fix for 3570700, crash in inlineBox::isDirty. Make sure line boxes null out parent pointers when those
parents get deleted. r=john

Fix for .value not being settable on selects. r=darin

  • khtml/html/html_formimpl.cpp: (HTMLSelectElementImpl::setValue):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::removeChildrenFromLineBoxes): (khtml::RenderBlock::removeChild):
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_line.cpp: (InlineFlowBox::removeChild):
9:52 AM Changeset in webkit [6256] by darin
  • 2 edits in trunk/WebCore

Fix by Kristin Webster, reviewed by me.

  • fixed <rdar://problem/3582431>: HiDPI - Form elements not working when scaling factor != 1.0
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Pass nil for fromView rather than passing the top level view.

Mar 24, 2004:

11:37 AM Changeset in webkit [6255] by darin
  • 4 edits in trunk

WebCore:

Reviewed by John.

  • fixed <rdar://problem/3566805>: REGRESSION: When the subject of mailto is 2 byte Safari failed to send mail address and subject to Mail.app
  • kwq/KWQKURL.mm: (KURL::findHostnamesInMailToURL): Update to handle hostnames that end just before a '?' since a '?' ends the entire part of the URL that can contain hostnames. Also change the logic so that the '?' will successfully end the search.

WebKit:

Reviewed by John.

  • fixed <rdar://problem/3566805>: REGRESSION: When the subject of mailto is 2 byte Safari failed to send mail address and subject to Mail.app
  • Misc.subproj/WebNSURLExtras.m: (applyHostNameFunctionToMailToURLString): Update to handle hostnames that end just before a '?' since a '?' ends the entire part of the URL that can contain hostnames. Also change the logic so that the '?' will successfully end the search.
11:21 AM Changeset in webkit [6254] by darin
  • 2 edits in trunk/WebCore

Tests:

  • TestURLs.h: Update comment to reflect change in behavior.
  • kde/kurl-relative-test.chk: Update results to reflect "compatibility" result.
  • kde/kurl-test.chk: Update results to reflect "compatibility" result.

WebCore:

Reviewed by John.

  • fixed <rdar://problem/3599650>: main image missing due to incorrect relative URL resolution at www.brother.com
  • kwq/KWQKURL.mm: (KURL::KURL): Implement compatibility rule from the URI RFC. If a URL has a scheme, but does not start with the "/" character, and the scheme matches the base URL, then treat it as a relative URL.
11:16 AM Changeset in webkit [6253] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by me

  • DOM.subproj/DOMHTML.h: Checking in copied over version of modified file.
10:31 AM Changeset in webkit [6252] by kocienda
  • 4 edits in trunk/WebCore

Reviewed by me.

I neglected to check in these required changes when I landed previously.
This is what I get for trying to commit when I had other changes in
my tree.

  • khtml/dom/html_form.cpp: (HTMLSelectElement::add): Uses new-style call.
  • khtml/html/html_formimpl.cpp: (HTMLSelectElementImpl::add): Change the interface for this call to use impl objects instead of API objects. This works around the fact that the API object's constructor that takes an impl is protected.
  • khtml/html/html_formimpl.h: Uses new-style call.
8:23 AM Changeset in webkit [6251] by kocienda
  • 3 edits in trunk/WebCore

Implemented the remainder of the HTML DOM API.

Reviewed by Chris.

  • kwq/DOMHTML.h
  • kwq/HTMLDOM.mm

Mar 23, 2004:

4:56 PM Changeset in webkit [6250] by hyatt
  • 13 edits in trunk/WebCore

Fix for 3487207, implement onscroll DOM event for elements with overflow:auto/scroll/hidden. This does
not handle firing onscroll on the window when the document scrolls, nor does it handle firing onscroll
on textareas. These are two separate bugs.

This patch finishes stubbing out the onscroll event and adds support for it to the DOM. It also supports
the firing of the event when overflow blocks scroll.

Reviewed by darin

  • khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): (DOMNode::putValue):
  • khtml/ecma/kjs_dom.h: (KJS::DOMNode::):
  • khtml/ecma/kjs_dom.lut.h: (KJS::):
  • khtml/ecma/kjs_window.cpp: (Window::get): (Window::put):
  • khtml/ecma/kjs_window.h: (KJS::Window::):
  • khtml/ecma/kjs_window.lut.h: (KJS::):
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseHTMLAttribute):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseHTMLAttribute):
  • khtml/misc/htmlattrs.c: (hash_attr): (findAttr):
  • khtml/misc/htmlattrs.h:
  • khtml/misc/htmlattrs.in:
  • khtml/rendering/render_layer.cpp: (RenderLayer::scrollToOffset):
3:21 PM Changeset in webkit [6249] by rjw
  • 10 edits
    2 adds in trunk/JavaScriptCore

Added implementation of KJS::Value <-> NP_Object conversion functions.
Augmented test program for 'C' bindings.
Added asserts and parameter checking to all public API.

Reviewed by Ken.

  • JavaScriptCore.pbproj/project.pbxproj:
  • bindings/NP_jsobject.cpp: (NP_ToString):
  • bindings/NP_jsobject.h: Added.
  • bindings/NP_runtime.cpp: (NP_IdentifierFromUTF8): (NP_IsValidIdentifier): (NP_GetIdentifiers): (NP_CreateObject): (NP_RetainObject): (NP_ReleaseObject): (NP_IsKindOfClass): (NP_SetExceptionWithUTF8): (NP_SetException): (NP_IntFromNumber): (NP_FloatFromNumber): (NP_DoubleFromNumber): (NP_CreateStringWithUTF8): (NP_CreateStringWithUTF16): (NP_DeallocateUTF8): (NP_UTF8FromString): (NP_UTF16FromString): (NP_StringLength): (NP_BoolFromBoolean):
  • bindings/NP_runtime.h:
  • bindings/c/c_instance.cpp: (CInstance::invokeMethod):
  • bindings/c/c_utility.cpp: (coerceValueToNPString): (convertValueToNPValueType): (convertNPValueTypeToValue):
  • bindings/c/c_utility.h:
  • bindings/test.js:
  • bindings/testC.js: Added.
  • bindings/testbindings.cpp: (logMessage): (setDoubleValue): (setIntValue): (setStringValue): (setBooleanValue): (getDoubleValue): (getIntValue): (getStringValue): (getBooleanValue): (myInterfaceInvoke): (myInterfaceAllocate):
2:56 PM Changeset in webkit [6248] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3513627, HTML mail prints upside down occasionally. Change printing so that it never resizes the
WebHTMLView when formatting for printing. When computing page rects, instead of using the view's bounds,
use the root layer's width instead.

Reviewed by darin

  • khtml/khtmlview.cpp: (KHTMLView::layout):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]):
2:55 PM Changeset in webkit [6247] by hyatt
  • 2 edits in trunk/WebKit

Fix for 3513627, HTML mail prints upside down occasionally. Change printing so that it never resizes the
WebHTMLView when formatting for printing. When computing page rects, instead of using the view's bounds,
use the root layer's width instead.

Reviewed by darin

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView knowsPageRange:]):
1:05 PM Changeset in webkit [6246] by hyatt
  • 2 edits in trunk/WebCore

Fix for crasher 3598204, previousKeyView was calling nextKeyView instead.

Reviewed by darin

  • kwq/KWQTextField.mm: (-[KWQTextField previousKeyView]): (-[KWQSecureTextField previousKeyView]): (-[KWQSearchField previousKeyView]):
11:04 AM Changeset in webkit [6245] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Vicki.

  • fixed deployment build
  • kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit): Move view initializer inside block with exceptions blocked.
Note: See TracTimeline for information about the timeline view.