Timeline
Mar 29, 2004:
- 2:34 PM Changeset in webkit [6275] by
-
- 2 edits2 adds in trunk
Make sure "auto" is allowed as a valid value when parsing rect shapes (e.g., for the clip property).
Reviewed by rjw
- khtml/css/cssparser.cpp: (CSSParser::parseShape):
- 2:16 PM Changeset in webkit [6274] by
-
- 4 edits in trunk/WebKit
WebKit:
- some support for "Stealth Browsing"; add a preference that controls whether a history item is added when a page is visited. This is called "historyIsFrozen" for now, but I wouldn't be surprised to see this name change.
Reviewed by Dave.
- WebView.subproj/WebPreferencesPrivate.h: new historyIsFrozen, setHistoryIsFrozen: methods
- WebView.subproj/WebPreferences.m: new WebKitHistoryIsFrozenPreferenceKey (+[WebPreferences initialize]): set initial value of WebKitHistoryIsFrozenPreferenceKey (-[WebPreferences setHistoryIsFrozen:]): set value of WebKitHistoryIsFrozenPreferenceKey (-[WebPreferences historyIsFrozen]): read value of WebKitHistoryIsFrozenPreferenceKey
- WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): don't add item to history if history is frozen
WebBrowser:
A little progress on "Stealth Mode"
Reviewed by Dave.
- AppController.m: (-[AppController toggleStealthMode:]): replace use of StealthModePreferenceKey with new WebPreferences SPI call (-[AppController validateUserInterfaceItem:]): ditto
- PreferenceKeys.h: remove StealthModePreferenceKey
- 1:36 PM Changeset in webkit [6273] by
-
- 1 edit in trunk/LayoutTests/fast/text/basic/014-expected.txt
Fix soft hyphen test.
- 1:36 PM Changeset in webkit [6272] by
-
- 2 edits in trunk/WebCore
Followup fix. Handle the case where a hard line break occurs right after a soft hyphen. In this
case we were losing a letter of the word in addition to not rendering the soft hyphen.
Reviewed by kocienda
- khtml/rendering/bidi.cpp: (khtml::checkMidpoints):
- 12:09 PM Changeset in webkit [6271] by
-
- 2 adds in trunk/LayoutTests/fast/text/basic
Adding soft hyphen layout test.
- 12:07 PM Changeset in webkit [6270] by
-
- 4 edits in trunk/WebCore
Fix for 3604154, support soft hyphens when rendering. This patch implements soft hyphen support that
matches IE6 on Windows and Opera 7. Soft hyphens that don't break lines end up getting collapsed away.
Only if the hyphen breaks a line does it render.
Reviewed by kocienda
- khtml/rendering/bidi.cpp: (khtml::chopMidpointsAt): (khtml::appendRunsForObject): (khtml::RenderBlock::findNextLineBreak):
- khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth):
- 8:38 AM Changeset in webkit [6269] by
-
- 2 edits in trunk/WebCore
Made menu shortcuts work again when editing HTML
Reviewed by Darin.
- khtml/xml/dom_elementimpl.cpp: (ElementImpl::defaultEventHandler): Don't treat key events with command key down as editing events.
- 8:17 AM Changeset in webkit [6268] by
-
- 3 edits in trunk/WebKit
Reviewed by John.
- fixed <rdar://problem/3559178>: navigator.language always returns "en"
- WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory defaultLanguageCode]): Call +[NSUserDefaults _web_preferredLanguageCode] rather than returning "en".
- English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
- 8:13 AM Changeset in webkit [6267] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
- fixed <rdar://problem/3602202>: "feed:uuid:...." links in Emerson content are being changed into "feed:uuuid:...."
- kwq/KWQKURL.mm: (copyPathRemovingDots): Add special case for empty path. The old code had an assertion that explicitly allowed this case, but it copied a character from the src buffer, which was incorrect.
Mar 26, 2004:
- 5:56 PM Changeset in webkit [6266] by
-
- 2 edits in trunk/WebCore
Fix for 3600642, letter magnet demo doesn't update until mouse move. This patch also fixes problems
with the animated text Gecko DOM demos on developer.netscape.com. Make sure that timer callbacks via
setTimeout always updateRendering after executing the JS code.
Reviewed by darin
- khtml/ecma/kjs_window.cpp: (ScheduledAction::execute):
- 1:49 PM Changeset in webkit [6265] by
-
- 3 edits in trunk/WebKit
WebKit:
- fixed <rdar://problem/3576334>: Printing "empty" page gives print error, leaves browser window UI broken
Reviewed by Dave.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView knowsPageRange:]): AppKit printing mechanism can't handle the case where you tell it there is nothing at all to print, so when we hit that case we give it a degenerate 1-pixel rect to print. This prints a blank page (with correctly-placed header & footer if so configured), which matches other browsers' behavior for this page.
- Plugins.subproj/npruntime.h: cvs keeps thinking I've removed a blank line from this auto-copied file. Richard said to just check it in to see if it stops doing this.
WebBrowser:
fixed <rdar://problem/3603092>: "new folder" menu item is enabled but
does nothing when current collection is history
Reviewed by Dave.
- BookmarksViewController.m: (-[BookmarksViewController newBookmarkFolder:]): If displayed contents can't accept new items, make a new collection even if outline view is focused.
- 9:46 AM Changeset in webkit [6264] by
-
- 3 edits in trunk
- change version number from 134 to 135u. the tree is open!
- 9:42 AM Changeset in webkit [6263]
-
- 3 copies in tags/Safari-134
This commit was manufactured by cvs2svn to create tag 'Safari-134'.
- 9:42 AM Changeset in webkit [6262] by
-
- 6 edits in trunk
- Safari-134 stamp
- 6:22 AM Changeset in webkit [6261] by
-
- 3 edits in trunk/WebKit
- fixed the following bugs:
<rdar://problem/3601630>: command-modified keypresses that would activate links are ignored by WebKit
<rdar://problem/3601604>: WebActionModifierFlagsKey not set correctly for modified keypresses that activate links
<rdar://problem/3544946>: cmd-return should open a link in a new tab
Reviewed by Darin.
- WebView.subproj/WebFrame.m: (-[WebFrame _actionInformationForNavigationType:event:originalURL:]): Pass modifier flags always, not just for mouse events. This fixes 3601604.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView performKeyEquivalent:]): Give the bridge a chance to intercept command-modified keypresses. This fixes 3601630.
Together these two changes fix 3544946.
Mar 25, 2004:
- 5:34 PM Changeset in webkit [6260] by
-
- 17 edits in trunk
WebCore:
Implement the rest of the search field. Make it work with form submission. Implement onscroll at
the document level.
Reviewed by darin
- khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::submit):
- khtml/rendering/render_form.cpp: (RenderLineEdit::addSearchResult):
- khtml/rendering/render_form.h:
- kwq/KWQKHTMLPart.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendScrollEvent):
- kwq/KWQLineEdit.h:
- kwq/KWQLineEdit.mm: (QLineEdit::setMaxResults): (QLineEdit::setPlaceholderString): (QLineEdit::addSearchResult):
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge sendScrollEvent]):
- kwq/WebCoreViewFactory.h:
WebKit:
Implement the rest of the search field.
Implement onscroll at the document level.
Reviewed by darin
- English.lproj/Localizable.strings:
- WebCoreSupport.subproj/WebBridge.m:
- WebCoreSupport.subproj/WebViewFactory.m: (-[NSMenu addItemWithTitle:action:tag:]): (-[WebViewFactory submitButtonDefaultLabel]): (-[WebViewFactory cellMenuForSearchField]):
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _frameOrBoundsChanged]): (-[WebHTMLView viewDidMoveToWindow]):
- WebView.subproj/WebHTMLViewPrivate.h:
- 5:32 PM Changeset in webkit [6259] by
-
- 1 add in trunk/WebKit/Plugins.subproj/npfunctions.h
Oops, forget to commit this file.
- 2:58 PM Changeset in webkit [6258] by
-
- 9 edits1 add in trunk/WebKit
Netscape plugin API header cleanup.
Replaced our hacked up version of npapi.h with the
"official SDK" npapi.h. Moved our changes to the new
npfunctions.h. npfunctions.h really replaces what was defined in
the Netscape npupp.h header. However, rather than use the "official SDK"
npupp.h I think the cleaner npfunctions.h is better. npupp.h actually
has a bunch of Mac classic specific stuff that is no longer needed.
Copied npruntime.h to WebKit using Ken's copy-o-matic mechanism.
Made npapi.h, npruntime.h, and npfunctions.h SPI. With a bit
more consideration they will become API. They will also eventually be made
available for other platforms/vendors are mozilla.org.
Reviewed by Ken.
- Plugins.subproj/WebBaseNetscapePluginStream.h:
- Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]):
- Plugins.subproj/WebBaseNetscapePluginView.h:
- Plugins.subproj/WebNetscapePluginPackage.h:
- Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
- Plugins.subproj/npapi.h:
- Plugins.subproj/npruntime.h: Added.
- WebKit.pbproj/project.pbxproj:
- copy-webcore-files-to-webkit:
- 10:53 AM Changeset in webkit [6257] by
-
- 5 edits in trunk/WebCore
Fix for 3570700, crash in inlineBox::isDirty. Make sure line boxes null out parent pointers when those
parents get deleted. r=john
Fix for .value not being settable on selects. r=darin
- khtml/html/html_formimpl.cpp: (HTMLSelectElementImpl::setValue):
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::removeChildrenFromLineBoxes): (khtml::RenderBlock::removeChild):
- khtml/rendering/render_block.h:
- khtml/rendering/render_line.cpp: (InlineFlowBox::removeChild):
- 9:52 AM Changeset in webkit [6256] by
-
- 2 edits in trunk/WebCore
Fix by Kristin Webster, reviewed by me.
- fixed <rdar://problem/3582431>: HiDPI - Form elements not working when scaling factor != 1.0
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Pass nil for fromView rather than passing the top level view.