Timeline
Mar 30, 2004:
- 5:51 PM Changeset in webkit [6280] by
-
- 13 edits in trunk
Reviewed by Dave.
- fixed <rdar://problem/3570877>: REGRESSION: onfocus handler not working at weather.com
- khtml/ecma/kjs_binding.cpp: (UString::string): Turn a null UString into a null DOMString, but a non-null empty UString into a non-null empty DOMString. (UString::qstring): Ditto, for QString. (Identifier::string): Ditto, for Identifier. (Identifier::qstring): Ditto.
- kwq/KWQLineEdit.h: Override focusPolicy.
- kwq/KWQLineEdit.mm: (QLineEdit::focusPolicy): Return StrongFocus instead of TabFocus, since we allow clicking to focus on these widgets.
- kwq/KWQTextEdit.h: More of the same.
- kwq/KWQTextEdit.mm: (QTextEdit::focusPolicy): And still more.
- fixed <rdar://problem/3605919>: text fields in web pages are too tall
- kwq/KWQTextField.mm: (-[KWQTextFieldCell _typesetterBehavior]): Ignore the per-application typesetter setting and instead always use the latest behavior for text fields in web pages. (-[KWQSecureTextFieldCell _typesetterBehavior]): Ditto. (-[KWQSearchFieldCell _typesetterBehavior]): Ditto.
- additional cleanup
- khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::isKeyboardFocusable): Check tab focus bit instead of different modes. (HTMLGenericFormElementImpl::isMouseFocusable): Check click focus bit instead of different modes.
- 3:38 PM Changeset in webkit [6279] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3604391>: Plug-in context menus (Flash) don't work in Carbon WebKit applications (e.g., CarbonWeb)
Reviewed by rjw.
- Carbon.subproj/HIWebView.m: (ContextMenuClick): instead of calling menuForEvent (which is not implemented on our plug-in view) call rightMouseDown and let AppKit handle the rest
- 2:09 PM Changeset in webkit [6278] by
-
- 40 edits2 adds in trunk
Fix for 3603326, spurious line breaks in encyclopedia articles. Make sure makeChildrenNonInline knows to
skip over floating/positioned elements so that they remain part of contiguous inline runs for static positioning
purposes.
Reviewed by darin
- khtml/rendering/render_block.cpp: (khtml::getInlineRun):
- 10:33 AM Changeset in webkit [6277] by
-
- 3 edits in trunk/WebCore
Reviewed by Ken.
- fixed garbage characters seen while I was rigging up the Mozilla JavaScript tests
- kwq/KWQString.h: Add a "move constructor" for KWQStringData that extracts the data from an existing KWQStringData.
- kwq/KWQString.mm: (KWQStringData::KWQStringData): Implement the move constructor. (QString::detachInternal): Use the move constructor rather than making a copy of the data. Should be both more efficient and preserves both the Unicode and the ASCII. The bug here is that TokenizerSubstring relies on the Unicode staying around. We still have a problem in the case where the Unicode is inside the KWQStringData. To deal with that we'll have to add a new QString call that TokenizerSubstring can use. The new call will force QString to keep the Unicode outside the internal KWQStringData.
- 9:41 AM Changeset in webkit [6276] by
-
- 2 edits in trunk/WebCore
Reviewed by Ken.
- fixed <rdar://problem/3606146>: repro nil-deref in QWidget::move (www.stoltoffshore.com)
- khtml/khtml_part.cpp: (KHTMLPart::requestObject): Add check for NULL widget. (KHTMLPart::processObjectRequest): Add check for NULL widget.
Mar 29, 2004:
- 2:34 PM Changeset in webkit [6275] by
-
- 2 edits2 adds in trunk
Make sure "auto" is allowed as a valid value when parsing rect shapes (e.g., for the clip property).
Reviewed by rjw
- khtml/css/cssparser.cpp: (CSSParser::parseShape):
- 2:16 PM Changeset in webkit [6274] by
-
- 4 edits in trunk/WebKit
WebKit:
- some support for "Stealth Browsing"; add a preference that controls whether a history item is added when a page is visited. This is called "historyIsFrozen" for now, but I wouldn't be surprised to see this name change.
Reviewed by Dave.
- WebView.subproj/WebPreferencesPrivate.h: new historyIsFrozen, setHistoryIsFrozen: methods
- WebView.subproj/WebPreferences.m: new WebKitHistoryIsFrozenPreferenceKey (+[WebPreferences initialize]): set initial value of WebKitHistoryIsFrozenPreferenceKey (-[WebPreferences setHistoryIsFrozen:]): set value of WebKitHistoryIsFrozenPreferenceKey (-[WebPreferences historyIsFrozen]): read value of WebKitHistoryIsFrozenPreferenceKey
- WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): don't add item to history if history is frozen
WebBrowser:
A little progress on "Stealth Mode"
Reviewed by Dave.
- AppController.m: (-[AppController toggleStealthMode:]): replace use of StealthModePreferenceKey with new WebPreferences SPI call (-[AppController validateUserInterfaceItem:]): ditto
- PreferenceKeys.h: remove StealthModePreferenceKey
- 1:36 PM Changeset in webkit [6273] by
-
- 1 edit in trunk/LayoutTests/fast/text/basic/014-expected.txt
Fix soft hyphen test.
- 1:36 PM Changeset in webkit [6272] by
-
- 2 edits in trunk/WebCore
Followup fix. Handle the case where a hard line break occurs right after a soft hyphen. In this
case we were losing a letter of the word in addition to not rendering the soft hyphen.
Reviewed by kocienda
- khtml/rendering/bidi.cpp: (khtml::checkMidpoints):
- 12:09 PM Changeset in webkit [6271] by
-
- 2 adds in trunk/LayoutTests/fast/text/basic
Adding soft hyphen layout test.
- 12:07 PM Changeset in webkit [6270] by
-
- 4 edits in trunk/WebCore
Fix for 3604154, support soft hyphens when rendering. This patch implements soft hyphen support that
matches IE6 on Windows and Opera 7. Soft hyphens that don't break lines end up getting collapsed away.
Only if the hyphen breaks a line does it render.
Reviewed by kocienda
- khtml/rendering/bidi.cpp: (khtml::chopMidpointsAt): (khtml::appendRunsForObject): (khtml::RenderBlock::findNextLineBreak):
- khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth):
- 8:38 AM Changeset in webkit [6269] by
-
- 2 edits in trunk/WebCore
Made menu shortcuts work again when editing HTML
Reviewed by Darin.
- khtml/xml/dom_elementimpl.cpp: (ElementImpl::defaultEventHandler): Don't treat key events with command key down as editing events.
- 8:17 AM Changeset in webkit [6268] by
-
- 3 edits in trunk/WebKit
Reviewed by John.
- fixed <rdar://problem/3559178>: navigator.language always returns "en"
- WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory defaultLanguageCode]): Call +[NSUserDefaults _web_preferredLanguageCode] rather than returning "en".
- English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
- 8:13 AM Changeset in webkit [6267] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
- fixed <rdar://problem/3602202>: "feed:uuid:...." links in Emerson content are being changed into "feed:uuuid:...."
- kwq/KWQKURL.mm: (copyPathRemovingDots): Add special case for empty path. The old code had an assertion that explicitly allowed this case, but it copied a character from the src buffer, which was incorrect.
Mar 26, 2004:
- 5:56 PM Changeset in webkit [6266] by
-
- 2 edits in trunk/WebCore
Fix for 3600642, letter magnet demo doesn't update until mouse move. This patch also fixes problems
with the animated text Gecko DOM demos on developer.netscape.com. Make sure that timer callbacks via
setTimeout always updateRendering after executing the JS code.
Reviewed by darin
- khtml/ecma/kjs_window.cpp: (ScheduledAction::execute):
- 1:49 PM Changeset in webkit [6265] by
-
- 3 edits in trunk/WebKit
WebKit:
- fixed <rdar://problem/3576334>: Printing "empty" page gives print error, leaves browser window UI broken
Reviewed by Dave.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView knowsPageRange:]): AppKit printing mechanism can't handle the case where you tell it there is nothing at all to print, so when we hit that case we give it a degenerate 1-pixel rect to print. This prints a blank page (with correctly-placed header & footer if so configured), which matches other browsers' behavior for this page.
- Plugins.subproj/npruntime.h: cvs keeps thinking I've removed a blank line from this auto-copied file. Richard said to just check it in to see if it stops doing this.
WebBrowser:
fixed <rdar://problem/3603092>: "new folder" menu item is enabled but
does nothing when current collection is history
Reviewed by Dave.
- BookmarksViewController.m: (-[BookmarksViewController newBookmarkFolder:]): If displayed contents can't accept new items, make a new collection even if outline view is focused.
- 9:46 AM Changeset in webkit [6264] by
-
- 3 edits in trunk
- change version number from 134 to 135u. the tree is open!
- 9:42 AM Changeset in webkit [6263]
-
- 3 copies in tags/Safari-134
This commit was manufactured by cvs2svn to create tag 'Safari-134'.
- 9:42 AM Changeset in webkit [6262] by
-
- 6 edits in trunk
- Safari-134 stamp
- 6:22 AM Changeset in webkit [6261] by
-
- 3 edits in trunk/WebKit
- fixed the following bugs:
<rdar://problem/3601630>: command-modified keypresses that would activate links are ignored by WebKit
<rdar://problem/3601604>: WebActionModifierFlagsKey not set correctly for modified keypresses that activate links
<rdar://problem/3544946>: cmd-return should open a link in a new tab
Reviewed by Darin.
- WebView.subproj/WebFrame.m: (-[WebFrame _actionInformationForNavigationType:event:originalURL:]): Pass modifier flags always, not just for mouse events. This fixes 3601604.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView performKeyEquivalent:]): Give the bridge a chance to intercept command-modified keypresses. This fixes 3601630.
Together these two changes fix 3544946.
