Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Apr 1, 2004:

1:55 PM Changeset in webkit [6300] by darin

• 2 edits in trunk/WebCore

Based on a fix by Eric Albert.

• fixed <rdar://problem/3594247>: Safari crashes when a background image has a height or width of 0

• khtml/rendering/render_box.cpp: (RenderBox::paintBackgroundExtended): Change code path so we don't mod with 0.

1:47 PM Changeset in webkit [6299] by rjw

• 3 edits in trunk/WebKit

Fixed 3609493. Don't remove the plugin's view until after
sending pluginDestroy. This change was requested by Greg
and is needed in the Lavender update.

Reviewed by Greg Bolsinga.

• Plugins.subproj/WebPluginController.m: (-[WebPluginController destroyAllPlugins]):
• Plugins.subproj/npruntime.h: Nothing changed, just need to checkin copy from WebCore.

12:08 PM Changeset in webkit [6298] by darin

• 2 edits in trunk/WebCore

Reviewed by Dave.

• fixed <rdar://problem/3608305>: DEMO: menu in search field has one disabled item: localized string not found

• khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::HTMLInputElementImpl): Initialize m_maxResults to 0.

10:06 AM Changeset in webkit [6297] by darin

• 8 edits in trunk/WebCore

Reviewed by John.

• cleaned up image map code and made it work with XML documents

• khtml/html/html_documentimpl.h: Removed getMap and mapMap.
• khtml/html/html_documentimpl.cpp: Removed getMap; moved to base class.

• khtml/html/html_imageimpl.cpp: (HTMLMapElementImpl::~HTMLMapElementImpl): Call new removeImageMap function instead of manipulating the mapMap field directly. (HTMLMapElementImpl::parseHTMLAttribute): Rewrite name changing code for simplicity and to avoid running off the end of the bufffer. Also remove image map before changing name so it doesn't end up in the map twice under both the old and new names.
• khtml/html/html_imageimpl.h: Use a DOMString instead of QString for the name, since the public API already uses a DOMString.

• khtml/rendering/render_image.cpp: (RenderImage::nodeAtPoint): Call the new getImageMap instead of the old getMap.

• khtml/xml/dom_docimpl.h: Added addImageMap, removeImageMap, getImageMap, and m_imageMapsByName.
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::addImageMap): Added. Stores the image map under its name, unless there's already another map of the same. (DocumentImpl::removeImageMap): Added. Removes the image map if it's already filed by name. Avoid pitfall of removing another image map that has the same name. (DocumentImpl::getImageMap): Added. Simplified version of logic from getMap in HTMLDocumentImpl.

9:23 AM Changeset in webkit [6296] by darin

• 2 edits in trunk/WebCore

Reviewed by Ken.

• fixed <rdar://problem/3608978>: dual <map> means you can't select the enter site button at jurassicpark.com (same problem in MacIE, works in Netscape)

• khtml/html/html_imageimpl.cpp: (HTMLMapElementImpl::parseHTMLAttribute): Make the first <map> seen win, as in other browsers. The old code made the last <map> seen win.

6:08 AM Changeset in webkit [6295] by kocienda

• 1 edit
  1 add in trunk/WebCore

Reviewed by me

Missing file broke build after my last checkin

• ForwardingHeaders/rendering/render_line.h: Added.

Mar 31, 2004:

6:10 PM Changeset in webkit [6294] by rjw

• 3 edits in trunk

More header shuffling.

6:10 PM Changeset in webkit [6293] by rjw

• 1 delete in trunk/WebCore/khtml/ecma/NP_SAP.h

Rearranged header.

6:08 PM Changeset in webkit [6292] by rjw

• 1 edit
  1 add in trunk/JavaScriptCore/bindings

Rearranging headers. Updated comments.

5:07 PM Changeset in webkit [6291] by rjw

• 1 edit in trunk/WebKit/Plugins.subproj/npruntime.h

Committing copied version of npruntime.h.

4:43 PM Changeset in webkit [6290] by rjw

• 15 edits in trunk/JavaScriptCore

Tedious renames based on feedback from plugin-futures list.
NP_ functions are renamed with NPN_ prefix.
Types prefix renamed from NP_ to NP.
NPN_CreateStringWithUTF8 and NPN_SetExceptionWithUTF8 now take a length, optionally -1 if string is null terminated.

No review because this was just a renaming patch.

• bindings/NP_jsobject.cpp: (listFromNPArray): (jsAllocate): (identiferFromNPIdentifier): (NPN_Call): (NPN_Evaluate): (NPN_GetProperty): (NPN_SetProperty): (NPN_RemoveProperty): (NPN_ToString): (NPN_GetPropertyAtIndex): (NPN_SetPropertyAtIndex):
• bindings/NP_jsobject.h:
• bindings/c/c_class.cpp: (CClass::_commonInit): (CClass::classForIsA): (CClass::CClass): (CClass::methodsNamed): (CClass::fieldNamed):
• bindings/c/c_class.h:
• bindings/c/c_instance.cpp: (CInstance::CInstance): (CInstance::~CInstance): (CInstance::operator=): (CInstance::invokeMethod): (CInstance::defaultValue):
• bindings/c/c_instance.h: (KJS::Bindings::CInstance::getObject):
• bindings/c/c_runtime.cpp: (CField::valueFromInstance): (CField::setValueToInstance):
• bindings/c/c_runtime.h: (KJS::Bindings::CField::CField): (KJS::Bindings::CField::name): (KJS::Bindings::CMethod::CMethod): (KJS::Bindings::CMethod::name):
• bindings/c/c_utility.cpp: (coerceValueToNPString): (convertValueToNPValueType): (convertNPValueTypeToValue):
• bindings/c/c_utility.h:
• bindings/npruntime.cpp: (NPN_IdentifierFromUTF8): (NPN_IsValidIdentifier): (NPN_GetIdentifiers): (NPN_UTF8FromIdentifier): (NPN_CreateObject): (NPN_RetainObject): (NPN_ReleaseObject): (NPN_IsKindOfClass): (NPN_SetExceptionWithUTF8): (NPN_SetException): (numberAllocate): (NPN_CreateNumberWithInt): (NPN_CreateNumberWithFloat): (NPN_CreateNumberWithDouble): (NPN_IntFromNumber): (NPN_FloatFromNumber): (NPN_DoubleFromNumber): (stringAllocate): (NPN_CreateStringWithUTF8): (NPN_CreateStringWithUTF16): (NPN_DeallocateUTF8): (NPN_UTF8FromString): (NPN_UTF16FromString): (NPN_StringLength): (booleanAllocate): (NPN_CreateBoolean): (NPN_BoolFromBoolean): (nullAllocate): (NPN_GetNull): (undefinedAllocate): (NPN_GetUndefined): (arrayAllocate): (arrayDeallocate): (NPN_CreateArray): (NPN_CreateArrayV): (NPN_ObjectAtIndex):
• bindings/npruntime.h:
• bindings/runtime.cpp: (Instance::createBindingForLanguageInstance):
• bindings/testbindings.cpp: (initializeIdentifiers): (myHasProperty): (myHasMethod): (myGetProperty): (mySetProperty): (logMessage): (setDoubleValue): (setIntValue): (setStringValue): (setBooleanValue): (getDoubleValue): (getIntValue): (getStringValue): (getBooleanValue): (myInvoke): (myAllocate): (myInvalidate): (myDeallocate): (main):

4:34 PM Changeset in webkit [6289] by kocienda

• 36 edits
  7 adds
  2 deletes in trunk/WebCore

Reviewed by Dave.

Many, many editing improvements, with a concentration on getting
caret navigation and deleting selections working correctly.

• WebCore.pbproj/project.pbxproj:
• khtml/dom/dom_position.cpp: Removed.
• khtml/dom/dom_position.h: Removed.
• khtml/editing/htmlediting.cpp: (EditCommand::isNull): Inlined. (EditCommand::notNull): New function. (EditCommand::parent): Commands now have parents. Allows for walking the tree of composite commands. (EditCommand::setParent): Ditto. (EditCommand::emptyCommand): Returns a static empty command. (AppendNodeCommand::AppendNodeCommand): (AppendNodeCommand::parentNode): Member variable name change only. parent -> parentNode. (DeleteCollapsibleWhitespaceCommand::DeleteCollapsibleWhitespaceCommand): New command. (InputTextCommand::InputTextCommand): (InputTextCommand::input): (InputTextCommand::charactersAdded): (JoinTextNodesCommand::JoinTextNodesCommand): Now derives directly from EditCommand. (RemoveNodeAndPruneCommand::RemoveNodeAndPruneCommand): New command. (SplitTextNodeCommand::SplitTextNodeCommand): Now derives directly from EditCommand.
• khtml/editing/htmlediting.h:
• khtml/editing/htmlediting_impl.cpp: (isNBSP): New helper. (isWS): New helper. (shouldPruneNode): New helper. (leadingWhitespacePosition): New helper. (trailingWhitespacePosition): New helper. (textNodesAreJoinable): New helper. (nonBreakingSpaceString): Returns a static DOMString containing a non-breaking space. (EditCommandImpl::EditCommandImpl): (EditCommandImpl::setStartingSelection): Now recursively sets starting selection on parents. (EditCommandImpl::setEndingSelection): As above, for ending selection. (EditCommandImpl::parent): New accessor. (EditCommandImpl::setParent): New accessor. (CompositeEditCommandImpl::doUnapply): Removed some logging. (CompositeEditCommandImpl::doReapply): Removed some logging. (CompositeEditCommandImpl::applyCommandToComposite): Sets parent. (CompositeEditCommandImpl::removeNodeAndPrune): New comvenience. (CompositeEditCommandImpl::replaceText): New comvenience. (CompositeEditCommandImpl::deleteSelection): New comvenience. (CompositeEditCommandImpl::deleteCollapsibleWhitespace): New comvenience. (AppendNodeCommandImpl::AppendNodeCommandImpl): Member variable name change only. parent -> parentNode. (AppendNodeCommandImpl::~AppendNodeCommandImpl): Ditto. (AppendNodeCommandImpl::doApply): Ditto. (AppendNodeCommandImpl::doUnapply): Ditto. (DeleteCollapsibleWhitespaceCommandImpl::DeleteCollapsibleWhitespaceCommandImpl): New command (debugPosition): New debugging aid. (DeleteSelectionCommandImpl::doApply): Major reworking to handle more cases correctly. (InputNewlineCommandImpl::doApply): Position and selection tweaks. (InputTextCommandImpl::InputTextCommandImpl): Handles more cases now, like typing after an image. (JoinTextNodesCommandImpl::JoinTextNodesCommandImpl): Now derives directly from EditCommand. Implements the guts of the command itself now, rather than replying on its former base class. (RemoveNodeAndPruneCommandImpl::RemoveNodeAndPruneCommandImpl): New command. (SplitTextNodeCommandImpl::SplitTextNodeCommandImpl): Now derives directly from EditCommand. Implements the guts of the command itself now, rather than replying on its former base class. (TypingCommandImpl::TypingCommandImpl): Major rework to handle more cases correctly.
• khtml/editing/htmlediting_impl.h:
• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::isContentEditable): More efficient use of the style system to answer the question.
• khtml/khtml_part.cpp: (KHTMLPart::setSelection): Fixes an issue where the caret would not repaint after being moved when undoing. (KHTMLPart::takeSelectionFrom): Ditto. (KHTMLPart::clearSelection): Ditto. (KHTMLPart::invalidateSelection): Ditto. (KHTMLPart::setSelectionVisible): Ditto. (KHTMLPart::slotClearSelection): Ditto. (KHTMLPart::clearCaretRectIfNeeded): Ditto. (KHTMLPart::notifySelectionChanged): Ditto. (KHTMLPart::unappliedEditing): Now uses EditCommand::emptyCommand(). (KHTMLPart::reappliedEditing): Ditto.
• khtml/khtml_part.h:
• khtml/khtml_selection.cpp: (KHTMLSelection::KHTMLSelection): (KHTMLSelection::modify): Updated to work with new DOMPosition API. (KHTMLSelection::paintCaret): Ditto. (KHTMLSelection::moveToRenderedContent): Ditto. (KHTMLSelection::basePosition): New convenience. (KHTMLSelection::extentPosition): New convenience. (KHTMLSelection::startPosition): New convenience. (KHTMLSelection::endPosition): New convenience. (KHTMLSelection::debugPosition): Modified debug output.
• khtml/khtml_selection.h: (KHTMLSelection::isEmpty): (KHTMLSelection::notEmpty):
• khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren): Fixed a crasher that happened when deleting content at the start of a line.
• khtml/rendering/render_br.cpp: (RenderBR::caretMaxRenderedOffset): New function. (RenderBR::caretPos): Now draws the caret in the right place when a block is empty.
• khtml/rendering/render_br.h:
• khtml/rendering/render_flow.cpp: (RenderFlow::caretPos): Now draws the caret in the right place when a flow is empty.
• khtml/rendering/render_line.cpp: (InlineBox::caretMaxRenderedOffset): New function.
• khtml/rendering/render_line.h:
• khtml/rendering/render_object.cpp: (RenderObject::isEditable): (RenderObject::caretMaxRenderedOffset): New function.
• khtml/rendering/render_object.h:
• khtml/rendering/render_replaced.cpp: (RenderReplaced::caretMaxRenderedOffset): New function.
• khtml/rendering/render_replaced.h:
• khtml/rendering/render_text.cpp: (InlineTextBox::caretMaxRenderedOffset): New function. (RenderText::detach): (RenderText::caretMaxOffset): (RenderText::caretMaxRenderedOffset): New function.
• khtml/rendering/render_text.h: (khtml::InlineTextBox::len):
• khtml/xml/dom_edititerator.cpp: Added.
• khtml/xml/dom_edititerator.h: Added.
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::previousEditable): Improved the correctness of this function. (NodeImpl::nextEditable): Ditto.
• khtml/xml/dom_nodeimpl.h:
• khtml/xml/dom_position.cpp: Added. (DOMPosition::renderedOffset): New function. (DOMPosition::previousCharacterPosition): New function. (DOMPosition::nextCharacterPosition): New function. (DOMPosition::equivalentUpstreamPosition): New function. (DOMPosition::equivalentDownstreamPosition): New function. (DOMPosition::validUpstreamDownstreamPosition): New function. (DOMPosition::inRenderedContent): New function. (inlineBoxForRenderer): New function. (renderersOnDifferentLine): New function. (nextRenderedEditable): New function. (previousRenderedEditable): New function. (DOMPosition::inRenderedText): New function. (DOMPosition::rendersOnSameLine): New function. (DOMPosition::rendersInDifferentPosition): New function. (DOMPosition::isFirstRenderedPositionOnLine): New function. (DOMPosition::isLastRenderedPositionOnLine): New function. (DOMPosition::isLastRenderedPositionInEditableBlock): New function. (DOMPosition::inFirstEditableInRootEditableBlock): New function. (DOMPosition::inLastEditableInRootEditableBlock): New function. (DOMPosition::inFirstEditableInContainingEditableBlock): New function. (DOMPosition::inLastEditableInContainingEditableBlock): New function.
• khtml/xml/dom_position.h: Added. (DOM::DOMPosition::notEmpty): New function.
• khtml/xml/dom_stringimpl.cpp: (DOM::DOMStringImpl::containsOnlyWhitespace): Added a version which takes an offset and length.
• khtml/xml/dom_stringimpl.h:
• khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::containsOnlyWhitespace): As above (CharacterDataImpl::maxOffset): New function. (CharacterDataImpl::caretMaxRenderedOffset): New function. (TextImpl::TextImpl): (TextImpl::rendererIsNeeded): A new bit. When set, makes a text renderer unconditionally.
• khtml/xml/dom_textimpl.h: (DOM::TextImpl::setRendererIsNeeded): Sets the bit.
• kwq/KWQAssertions.m: (KWQLog): Change to decrease the amount of output for the Editing log level. (my preference)

4:00 PM Changeset in webkit [6288] by hyatt

• 2 edits
  2 adds in trunk

Fix for 3601834, make sure that textareas do a layout when their rows/cols/wrap attributes are dynamically
changed.

Reviewed by darin.

• khtml/html/html_formimpl.cpp: (HTMLTextAreaElementImpl::parseHTMLAttribute):

3:39 PM Changeset in webkit [6287] by sullivan

• 7 edits in trunk/WebKit

WebKit:

• fixed <rdar://problem/3577917>: API: mechanism for displaying error page for failed page load

This was not commented on for a week in macosx-api-reviewers, so it
has the silent rubber stamp of approval.

Note that it isn't guarded by "Tiger only" availability macros because
we (probably) want to use it in Panther for Safari. Maybe what we should
do is guard the API with "Tiger only" macros but add an SPI version
that Safari uses?

Reviewed by Dave.

• WebView.subproj/WebDataSource.h: moved unreachableURL to here
• WebView.subproj/WebDataSource.m: (-[WebDataSource unreachableURL]): moved this from private category to main section

• WebView.subproj/WebDataSourcePrivate.h: removed unreachableURL from here

• WebView.subproj/WebFrame.h: moved loadAlternateHTMLString... to here
• WebView.subproj/WebFrame.m: (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): moved this from private category to main section

• WebView.subproj/WebFramePrivate.h: removed unreachableURL from here

WebBrowser:

Reviewed by Dave.

• BrowserDocument.m: removed #import of WebDataSourcePrivate now that error-page stuff is API
• BrowserWebController.m: ditto
• BrowserWindowController.m: ditto
• LoadProgressMonitor.m: ditto

1:37 PM Changeset in webkit [6286] by rjw

• 2 edits in trunk/WebKit

Fix build problem.

12:56 PM Changeset in webkit [6285] by rjw

• 8 edits in trunk/JavaScriptCore

Changed references to NP_runtime.h to npruntime.h

• JavaScriptCore.pbproj/project.pbxproj:
• bindings/NP_jsobject.h:
• bindings/c/c_class.h:
• bindings/c/c_instance.h:
• bindings/c/c_runtime.h:
• bindings/c/c_utility.h:
• bindings/npruntime.cpp:

11:59 AM Changeset in webkit [6284] by sullivan

• 2 edits in trunk/WebKit

WebKit:

Reviewed by Darin.

• WebView.subproj/WebPreferences.m: (-[WebPreferences historyIsFrozen]): always return NO on Panther and older, so you can't get into a state where the WebKit pref is invisibly set and affecting Safari.

WebBrowser:

More stealth mode. Don't save standard form data or names/passwords when
in stealth mode.

Reviewed by Darin.

• FormCompletionController.m: (+[FormCompletionController shouldSaveFormData]): new method, checks both the misc form data preference and the stealth mode preference. (+[FormCompletionController shouldSaveUsernamesAndPasswords]): ditto but for usernames/passwords instead of misc form data (+[FormCompletionController _frame:sourceFrame:willSubmitLoginForm:withValues:formInfo:submissionListener:]): use shouldSaveUsernamesAndPasswords (+[FormCompletionController _frame:sourceFrame:willSubmitRegularForm:withValues:]): use shouldSaveFormData

11:01 AM Changeset in webkit [6283] by hyatt

• 2 adds in trunk/LayoutTests/fast/text/whitespace

Adding layout test for whitespace bug.

10:43 AM Changeset in webkit [6282] by hyatt

• 7 edits in trunk

Fix for 3604241, simple space collapsing results in a doubled character. Simplify the ignoring of
whitespace and make sure it works across absolutely positioned spans.

Reviewed by darin

• khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak):

10:35 AM Changeset in webkit [6281] by darin

• 2 edits in trunk/WebKit

• WebView.subproj/WebHTMLView.m: Whitespace tweaks.

Mar 30, 2004:

5:51 PM Changeset in webkit [6280] by darin

• 13 edits in trunk

Reviewed by Dave.

• fixed <rdar://problem/3570877>: REGRESSION: onfocus handler not working at weather.com

• khtml/ecma/kjs_binding.cpp: (UString::string): Turn a null UString into a null DOMString, but a non-null empty UString into a non-null empty DOMString. (UString::qstring): Ditto, for QString. (Identifier::string): Ditto, for Identifier. (Identifier::qstring): Ditto.

• kwq/KWQLineEdit.h: Override focusPolicy.
• kwq/KWQLineEdit.mm: (QLineEdit::focusPolicy): Return StrongFocus instead of TabFocus, since we allow clicking to focus on these widgets.
• kwq/KWQTextEdit.h: More of the same.
• kwq/KWQTextEdit.mm: (QTextEdit::focusPolicy): And still more.

• fixed <rdar://problem/3605919>: text fields in web pages are too tall

• kwq/KWQTextField.mm: (-[KWQTextFieldCell _typesetterBehavior]): Ignore the per-application typesetter setting and instead always use the latest behavior for text fields in web pages. (-[KWQSecureTextFieldCell _typesetterBehavior]): Ditto. (-[KWQSearchFieldCell _typesetterBehavior]): Ditto.

• additional cleanup

• khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::isKeyboardFocusable): Check tab focus bit instead of different modes. (HTMLGenericFormElementImpl::isMouseFocusable): Check click focus bit instead of different modes.

3:38 PM Changeset in webkit [6279] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3604391>: Plug-in context menus (Flash) don't work in Carbon WebKit applications (e.g., CarbonWeb)

Reviewed by rjw.

• Carbon.subproj/HIWebView.m: (ContextMenuClick): instead of calling menuForEvent (which is not implemented on our plug-in view) call rightMouseDown and let AppKit handle the rest

2:09 PM Changeset in webkit [6278] by hyatt

• 40 edits
  2 adds in trunk

Fix for 3603326, spurious line breaks in encyclopedia articles. Make sure makeChildrenNonInline knows to
skip over floating/positioned elements so that they remain part of contiguous inline runs for static positioning
purposes.

Reviewed by darin

• khtml/rendering/render_block.cpp: (khtml::getInlineRun):

10:33 AM Changeset in webkit [6277] by darin

• 3 edits in trunk/WebCore

Reviewed by Ken.

• fixed garbage characters seen while I was rigging up the Mozilla JavaScript tests

• kwq/KWQString.h: Add a "move constructor" for KWQStringData that extracts the data from an existing KWQStringData.
• kwq/KWQString.mm: (KWQStringData::KWQStringData): Implement the move constructor. (QString::detachInternal): Use the move constructor rather than making a copy of the data. Should be both more efficient and preserves both the Unicode and the ASCII. The bug here is that TokenizerSubstring relies on the Unicode staying around. We still have a problem in the case where the Unicode is inside the KWQStringData. To deal with that we'll have to add a new QString call that TokenizerSubstring can use. The new call will force QString to keep the Unicode outside the internal KWQStringData.

9:41 AM Changeset in webkit [6276] by darin

• 2 edits in trunk/WebCore

Reviewed by Ken.

• fixed <rdar://problem/3606146>: repro nil-deref in QWidget::move (www.stoltoffshore.com)

• khtml/khtml_part.cpp: (KHTMLPart::requestObject): Add check for NULL widget. (KHTMLPart::processObjectRequest): Add check for NULL widget.

Mar 29, 2004:

2:34 PM Changeset in webkit [6275] by hyatt

• 2 edits
  2 adds in trunk

Make sure "auto" is allowed as a valid value when parsing rect shapes (e.g., for the clip property).

Reviewed by rjw

• khtml/css/cssparser.cpp: (CSSParser::parseShape):

2:16 PM Changeset in webkit [6274] by sullivan

• 4 edits in trunk/WebKit

WebKit:

• some support for "Stealth Browsing"; add a preference that controls whether a history item is added when a page is visited. This is called "historyIsFrozen" for now, but I wouldn't be surprised to see this name change.

Reviewed by Dave.

• WebView.subproj/WebPreferencesPrivate.h: new historyIsFrozen, setHistoryIsFrozen: methods

• WebView.subproj/WebPreferences.m: new WebKitHistoryIsFrozenPreferenceKey (+[WebPreferences initialize]): set initial value of WebKitHistoryIsFrozenPreferenceKey (-[WebPreferences setHistoryIsFrozen:]): set value of WebKitHistoryIsFrozenPreferenceKey (-[WebPreferences historyIsFrozen]): read value of WebKitHistoryIsFrozenPreferenceKey

• WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): don't add item to history if history is frozen

WebBrowser:

A little progress on "Stealth Mode"

Reviewed by Dave.

• AppController.m: (-[AppController toggleStealthMode:]): replace use of StealthModePreferenceKey with new WebPreferences SPI call (-[AppController validateUserInterfaceItem:]): ditto

• PreferenceKeys.h: remove StealthModePreferenceKey

1:36 PM Changeset in webkit [6273] by hyatt

• 1 edit in trunk/LayoutTests/fast/text/basic/014-expected.txt

Fix soft hyphen test.

1:36 PM Changeset in webkit [6272] by hyatt

• 2 edits in trunk/WebCore

Followup fix. Handle the case where a hard line break occurs right after a soft hyphen. In this
case we were losing a letter of the word in addition to not rendering the soft hyphen.

Reviewed by kocienda

• khtml/rendering/bidi.cpp: (khtml::checkMidpoints):

12:09 PM Changeset in webkit [6271] by hyatt

• 2 adds in trunk/LayoutTests/fast/text/basic

Adding soft hyphen layout test.

12:07 PM Changeset in webkit [6270] by hyatt

• 4 edits in trunk/WebCore

Fix for 3604154, support soft hyphens when rendering. This patch implements soft hyphen support that
matches IE6 on Windows and Opera 7. Soft hyphens that don't break lines end up getting collapsed away.
Only if the hyphen breaks a line does it render.

Reviewed by kocienda

• khtml/rendering/bidi.cpp: (khtml::chopMidpointsAt): (khtml::appendRunsForObject): (khtml::RenderBlock::findNextLineBreak):
• khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth):

8:38 AM Changeset in webkit [6269] by sullivan

• 2 edits in trunk/WebCore

Made menu shortcuts work again when editing HTML

Reviewed by Darin.

• khtml/xml/dom_elementimpl.cpp: (ElementImpl::defaultEventHandler): Don't treat key events with command key down as editing events.

8:17 AM Changeset in webkit [6268] by darin

• 3 edits in trunk/WebKit

Reviewed by John.

• fixed <rdar://problem/3559178>: navigator.language always returns "en"

• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory defaultLanguageCode]): Call +[NSUserDefaults _web_preferredLanguageCode] rather than returning "en".

• English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

8:13 AM Changeset in webkit [6267] by darin

• 2 edits in trunk/WebCore

Reviewed by John.

• fixed <rdar://problem/3602202>: "feed:uuid:...." links in Emerson content are being changed into "feed:uuuid:...."

• kwq/KWQKURL.mm: (copyPathRemovingDots): Add special case for empty path. The old code had an assertion that explicitly allowed this case, but it copied a character from the src buffer, which was incorrect.