Timeline



Apr 5, 2004:

7:10 PM Changeset in webkit [6313] by darin
  • 3 edits in trunk/WebCore
  • khtml/html/kentities.gperf: Added © and ®, both supported by Gecko (and presumably by WinIE). Also re-sorted the list.
  • khtml/html/kentities.c: Regenerated.
6:09 PM Changeset in webkit [6312] by darin
  • 2 edits in trunk/WebCore

Reviewed by Dave.

  • rolled over fix from KHTML tree; anchor inside another anchor
  • khtml/rendering/render_layer.cpp: (RenderLayer::nodeAtPoint): Make sure the URL element is the innermost one, by not setting it once it's already set.
2:35 PM Changeset in webkit [6311] by hyatt
  • 26 edits
    2 adds in trunk/WebCore

Implement overflow: overlay so that a scrollbar can show/hide without causing a layout.

Reviewed by darin

  • ChangeLog:
  • khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
  • khtml/css/cssvalues.c: (hash_val): (findValue):
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::rightOffset):
  • khtml/rendering/render_box.cpp: (RenderBox::contentWidth): (RenderBox::contentHeight):
  • khtml/rendering/render_layer.cpp: (RenderLayer::updateScrollInfoAfterLayout):
  • khtml/rendering/render_object.cpp: (RenderObject::clientWidth): (RenderObject::clientHeight):
  • khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::hasAutoScrollbars): (khtml::RenderStyle::scrollsOverflow): (khtml::RenderStyle::includeScrollbarSize):
1:46 PM Changeset in webkit [6310] by cblu
  • 13 edits in trunk

Tests:

Made PDFBundle compilable and made it test the new selection SPI.

  • PDFBundle/Apple.pdf: Added.
  • PDFBundle/PDFBundle.pbproj/project.pbxproj:
  • PDFBundle/PDFView.h:
  • PDFBundle/PDFView.m: (-[PDFResourceDelegate connection:didReceiveData:]): (-[PDFResourceDelegate connectionDidFinishLoading:]): (-[PDFResourceDelegate connection:didFailLoadingWithError:]): (-[PDFView initWithFrame:pageURL:resourceURL:container:]): (-[PDFView dealloc]): (-[PDFView setIsSelected:]): (-[PDFView isSelected]): (-[PDFView drawRect:]): (-[PDFView layout]): (-[PDFRepresentation receivedError:withDataSource:]): (-[PDFRepresentation title]): (+[PDFPluginViewFactory pluginViewWithArguments:]):
  • PDFBundle/pdf.html: Added.

WebCore:

Fixed: <rdar://problem/3612580>: SPI: WebPlugin selection

Reviewed by kocienda.

  • WebCore.pbproj/project.pbxproj:
  • khtml/rendering/render_replaced.cpp: (RenderWidget::setSelectionState): new override, calls QWidget::setIsSelected
  • khtml/rendering/render_replaced.h: (khtml::RenderWidget::selectionState): new override
  • kwq/KWQWidget.h:
  • kwq/KWQWidget.mm: (QWidget::setIsSelected): new, calls [WebCoreBridge setIsSelected:forView:] (QWidget::isSelected): new, calls [WebCoreBridge isViewSelected:]
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge selectionColor]): new

WebKit:

Fixed: <rdar://problem/3612580>: SPI: WebPlugin selection

Reviewed by kocienda.

  • Plugins.subproj/WebPlugin.h: extended SPI for selection
  • Plugins.subproj/WebPluginContainer.h: ditto
  • Plugins.subproj/WebPluginController.m: (-[WebPluginController selectionColor]): new, calls [WebCoreBridge selectionColor]
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setIsSelected:forView:]): new, calls [WebPlugin setIsSelected:] (-[WebBridge isViewSelected:]): new, calls [WebPlugin isSelected]

Apr 3, 2004:

12:17 PM Changeset in webkit [6309] by hyatt
  • 2 adds in trunk/LayoutTests/fast/parser

* empty log message *

12:15 PM Changeset in webkit [6308] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3601728, text overlaps borders at ejai.org. Remove all the code in addForbidden for
dir, menu, nobr, and pre that made them too restrictive regarding what child tags they could
contain.

Reviewed by kocienda

  • khtml/html/dtd.cpp: (DOM::addForbidden): (DOM::removeForbidden):

Apr 2, 2004:

11:55 AM Changeset in webkit [6307] by cblu
  • 1 edit
    1 add in trunk/WebKit

Forgot to add the WebKit copy of DOMExtensions.h.

  • DOM.subproj/DOMExtensions.h: Added.
11:48 AM Changeset in webkit [6306] by sullivan
  • 3 edits in trunk/WebKit

WebKit:

Reviewed by Dave.

  • WebView.subproj/WebPreferences.m: (-[WebPreferences historyIsFrozen]): take out OMIT_TIGER_FEATURES ifdeffing, since if we turn this into API then we'll probably want it to work in Panther also. To protect Safari users, Safari now explicitly sets historyIsFrozen to NO when starting up in Panther.
  • English.lproj/StringsNotToBeLocalized.txt: updated for recent changes

WebBrowser:

  • made enough improvements to "Stealth Browsing" to consider this bug fixed: <rdar://problem/3184383>: Would like ability to do "stealth browsing" without leaving any tracks behind (history, etc.)

Reviewed by Dave.

  • AppController.m: (-[AppController applicationDidFinishLaunching:]): call [WebPreferences historyIsFrozen:NO] on Panther so command-line settings of this preference won't persist (-[AppController confirmEnableStealthMode]): new method, puts up a confirmation dialog explaining what stealth mode is, and turns stealth mode on if confirmed. I sent mail to Steve Lemay and Ron Brannan to discuss the wording of the dialog, among other things. (-[AppController toggleStealthMode:]): now calls confirmEnableStealthMode when stealth mode is being turned on
  • DownloadProgressEntry.m: (-[DownloadProgressEntry setDownloadStage:]): always remove successful downloads when they finish when in stealth mode
  • English.lproj/Localizable.strings:
  • English.lproj/StringsNotToBeLocalized.txt: udpated for these changes
11:43 AM Changeset in webkit [6305] by cblu
  • 9 edits
    2 adds in trunk

WebCore:

Moved the DOM extensions to their own headers

Reviewed by kocienda.

  • WebCore.pbproj/project.pbxproj:
  • kwq/DOM.h: include DOMExtensions.h
  • kwq/DOMExtensions.h: Added.
  • kwq/DOMHTML.h: moved extensions to DOMExtensions.h
  • kwq/DOMHTML.mm: Renamed to match header

WebKit:

Moved the DOM extensions to their own headers

Reviewed by kocienda.

  • DOM.subproj/DOM.h: changed from WebCore
  • DOM.subproj/DOMHTML.h: ditto
  • WebKit.pbproj/project.pbxproj: added DOMExtensions.h
  • copy-webcore-files-to-webkit: copy DOMExtensions.h
11:30 AM Changeset in webkit [6304] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3610662, rendering sometimes doesn't update in response to mouse events that change style.
The document changed list was getting messed up.

Reviewed by darin

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateDocumentsRendering):
  • khtml/xml/dom_docimpl.h:
10:52 AM Changeset in webkit [6303] by vicki
  • 3 edits in trunk

change version number from 135 to 136u.

The tree is open!

10:47 AM Changeset in webkit [6302]
  • 3 copies in tags/Safari-135

This commit was manufactured by cvs2svn to create tag 'Safari-135'.

10:47 AM Changeset in webkit [6301] by vicki
  • 6 edits in trunk

Safari-135 stamp

Apr 1, 2004:

1:55 PM Changeset in webkit [6300] by darin
  • 2 edits in trunk/WebCore

Based on a fix by Eric Albert.

  • fixed <rdar://problem/3594247>: Safari crashes when a background image has a height or width of 0
  • khtml/rendering/render_box.cpp: (RenderBox::paintBackgroundExtended): Change code path so we don't mod with 0.
1:47 PM Changeset in webkit [6299] by rjw
  • 3 edits in trunk/WebKit

Fixed 3609493. Don't remove the plugin's view until after
sending pluginDestroy. This change was requested by Greg
and is needed in the Lavender update.

Reviewed by Greg Bolsinga.

  • Plugins.subproj/WebPluginController.m: (-[WebPluginController destroyAllPlugins]):
  • Plugins.subproj/npruntime.h: Nothing changed, just need to checkin copy from WebCore.
12:08 PM Changeset in webkit [6298] by darin
  • 2 edits in trunk/WebCore

Reviewed by Dave.

  • fixed <rdar://problem/3608305>: DEMO: menu in search field has one disabled item: localized string not found
  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::HTMLInputElementImpl): Initialize m_maxResults to 0.
10:06 AM Changeset in webkit [6297] by darin
  • 8 edits in trunk/WebCore

Reviewed by John.

  • cleaned up image map code and made it work with XML documents
  • khtml/html/html_documentimpl.h: Removed getMap and mapMap.
  • khtml/html/html_documentimpl.cpp: Removed getMap; moved to base class.
  • khtml/html/html_imageimpl.cpp: (HTMLMapElementImpl::~HTMLMapElementImpl): Call new removeImageMap function instead of manipulating the mapMap field directly. (HTMLMapElementImpl::parseHTMLAttribute): Rewrite name changing code for simplicity and to avoid running off the end of the bufffer. Also remove image map before changing name so it doesn't end up in the map twice under both the old and new names.
  • khtml/html/html_imageimpl.h: Use a DOMString instead of QString for the name, since the public API already uses a DOMString.
  • khtml/rendering/render_image.cpp: (RenderImage::nodeAtPoint): Call the new getImageMap instead of the old getMap.
  • khtml/xml/dom_docimpl.h: Added addImageMap, removeImageMap, getImageMap, and m_imageMapsByName.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::addImageMap): Added. Stores the image map under its name, unless there's already another map of the same. (DocumentImpl::removeImageMap): Added. Removes the image map if it's already filed by name. Avoid pitfall of removing another image map that has the same name. (DocumentImpl::getImageMap): Added. Simplified version of logic from getMap in HTMLDocumentImpl.
9:23 AM Changeset in webkit [6296] by darin
  • 2 edits in trunk/WebCore

Reviewed by Ken.

  • fixed <rdar://problem/3608978>: dual <map> means you can't select the enter site button at jurassicpark.com (same problem in MacIE, works in Netscape)
  • khtml/html/html_imageimpl.cpp: (HTMLMapElementImpl::parseHTMLAttribute): Make the first <map> seen win, as in other browsers. The old code made the last <map> seen win.
6:08 AM Changeset in webkit [6295] by kocienda
  • 1 edit
    1 add in trunk/WebCore

Reviewed by me

Missing file broke build after my last checkin

  • ForwardingHeaders/rendering/render_line.h: Added.
Note: See TracTimeline for information about the timeline view.