Context Navigation

← Previous Period
Next Period →

Timeline

Apr 6, 2004:

5:24 PM Changeset in webkit [6322] by rjw

2 edits in trunk/WebKit

Fixed 3510805. Only release pool in timer if the current nesting level of the
pool matches the nesting level when the pool was created.

Reviewed by Chris.

Carbon.subproj/CarbonUtils.m: (getNumPools): (WebInitForCarbon): (PoolCleaner):

4:08 PM Changeset in webkit [6321] by kocienda

5 edits in trunk/WebCore

Tests:

Reviewed by Richard

Default document is now blank, since blinking a caret in
an empty document is now supported.

Added some code to move the caret to the start of the
body element after loading it.

Improved the code which makes the whole document
contenteditable (by checking for and setting contenteditable,
if needed).

Blot/BlotDocument.m: (-[BlotDocument webView:didFinishLoadForFrame:]):
Blot/Resources/default.html:

WebCore:

Reviewed by Richard

khtml/khtml_part.cpp: (KHTMLPart::setSelection): Now calls setFocusNodeIfNeeded. (KHTMLPart::takeSelectionFrom): Now calls setFocusNodeIfNeeded. (KHTMLPart::clearSelection): Now calls setFocusNodeIfNeeded. (KHTMLPart::invalidateSelection): Now calls setFocusNodeIfNeeded. (KHTMLPart::setSelectionVisible): Now calls setFocusNodeIfNeeded. (KHTMLPart::setFocusNodeIfNeeded): New function focuses first element of a selection that is contenteditable, if any of the nodes are. The "first" determination is made by doing a document-order search.
khtml/khtml_part.h:
khtml/xml/dom_nodeimpl.cpp: Remove debug spam.
kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectedDOMRange:]): Now updates document layout before setting the selection. This was needed for Blot, so that setting the contenteditable attribute on the body is "seen" when the attempt is made to set the selection right immediately after.

2:03 PM Changeset in webkit [6320] by hyatt

2 edits in trunk/WebCore

After columns have been expanded to their preferred sizes, if space is left over in the table, then
fixed columns should expand to fill space before percentage width columns do. The old code had it
backwards.

Reviewed by john

khtml/rendering/table_layout.cpp: (AutoTableLayout::layout):

2:00 PM Changeset in webkit [6319] by cblu

3 edits in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3613974>: remove "to Clipboard" from context menus because it is redundant

Reviewed by john.

English.lproj/Localizable.strings:
WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate menuItemWithTag:]):

WebBrowser:

Fixed: <rdar://problem/3316489>: ER: Safari� image context menu should have "Copy Image Address"

Reviewed by john.

ContextMenuHandler.m: (-[BrowserWebView webView:contextMenuItemsForElement:defaultMenuItems:]): added "Copy Image Address" for Tiger only, moved "Add Link to Bookmarks" above "Copy Link" to keep all copy-related menu items at the bottom (-[BrowserWebView copyImageAddress:]): new
English.lproj/Localizable.strings:
English.lproj/StringsNotToBeLocalized.txt:

9:01 AM Changeset in webkit [6318] by kocienda

4 edits in trunk/WebCore

Reviewed by Dave

khtml/dom/dom_node.cpp: (Node::isContentEditable): Added. Calls through to impl function of same name.
khtml/dom/dom_node.h: Added isContentEditable declaration.
khtml/khtmlview.cpp: (KHTMLView::viewportMouseMoveEvent): Now, the cursor will change to an i-beam whenever it is over a node that is contenteditable, and nothing, like a link, takes precedence.

8:50 AM Changeset in webkit [6317] by kocienda

2 edits in trunk/WebCore

Reviewed by Dave

khtml/css/html4.css: Refine focus rules so that HTML and BODY elements do not draw a focus ring around themselves when focused. This prevents a silly-looking focus ring from drawing around a document's entire contents when a body element is contenteditable.

8:25 AM Changeset in webkit [6316] by kocienda

3 edits in trunk/WebCore

Reviewed by Dave

Caret height is now the height of the tallest element on the line,
mimicking NSText behavior.

khtml/rendering/render_box.cpp: (RenderBox::caretPos): Use root line box topOverflow and bottomOverflow for the calculation of caret height.
khtml/rendering/render_text.cpp: (RenderText::caretPos): Ditto.

8:21 AM Changeset in webkit [6315] by kocienda

1 edit
73 adds in trunk

Reviewed by me

Added a new suite of layout tests for editing, all added
in the new layout-tests/editing subtree.

layout-tests/editing/abe.jpg: Added.
layout-tests/editing/deleting/delete-block-contents-001-expected.txt: Added.
layout-tests/editing/deleting/delete-block-contents-001.html: Added.
layout-tests/editing/deleting/delete-block-contents-002-expected.txt: Added.
layout-tests/editing/deleting/delete-block-contents-002.html: Added.
layout-tests/editing/deleting/delete-block-contents-003-expected.txt: Added.
layout-tests/editing/deleting/delete-block-contents-003.html: Added.
layout-tests/editing/deleting/delete-br-001-expected.txt: Added.
layout-tests/editing/deleting/delete-br-001.html: Added.
layout-tests/editing/deleting/delete-br-002-expected.txt: Added.
layout-tests/editing/deleting/delete-br-002.html: Added.
layout-tests/editing/deleting/delete-br-003-expected.txt: Added.
layout-tests/editing/deleting/delete-br-003.html: Added.
layout-tests/editing/deleting/delete-br-004-expected.txt: Added.
layout-tests/editing/deleting/delete-br-004.html: Added.
layout-tests/editing/deleting/delete-br-005-expected.txt: Added.
layout-tests/editing/deleting/delete-br-005.html: Added.
layout-tests/editing/deleting/delete-br-006-expected.txt: Added.
layout-tests/editing/deleting/delete-br-006.html: Added.
layout-tests/editing/deleting/delete-character-001-expected.txt: Added.
layout-tests/editing/deleting/delete-character-001.html: Added.
layout-tests/editing/deleting/delete-contiguous-ws-001-expected.txt: Added.
layout-tests/editing/deleting/delete-contiguous-ws-001.html: Added.
layout-tests/editing/deleting/delete-image-001-expected.txt: Added.
layout-tests/editing/deleting/delete-image-001.html: Added.
layout-tests/editing/deleting/delete-image-002-expected.txt: Added.
layout-tests/editing/deleting/delete-image-002.html: Added.
layout-tests/editing/deleting/delete-image-003-expected.txt: Added.
layout-tests/editing/deleting/delete-image-003.html: Added.
layout-tests/editing/deleting/delete-leading-ws-001-expected.txt: Added.
layout-tests/editing/deleting/delete-leading-ws-001.html: Added.
layout-tests/editing/deleting/delete-selection-001-expected.txt: Added.
layout-tests/editing/deleting/delete-selection-001.html: Added.
layout-tests/editing/deleting/delete-trailing-ws-001-expected.txt: Added.
layout-tests/editing/deleting/delete-trailing-ws-001.html: Added.
layout-tests/editing/editing.js: Added.
layout-tests/editing/inserting/typing-001-expected.txt: Added.
layout-tests/editing/inserting/typing-001.html: Added.
layout-tests/editing/inserting/typing-002-expected.txt: Added.
layout-tests/editing/inserting/typing-002.html: Added.
layout-tests/editing/inserting/typing-around-br-001-expected.txt: Added.
layout-tests/editing/inserting/typing-around-br-001.html: Added.
layout-tests/editing/inserting/typing-around-image-001-expected.txt: Added.
layout-tests/editing/inserting/typing-around-image-001.html: Added.
layout-tests/editing/selection/extend-by-character-001-expected.txt: Added.
layout-tests/editing/selection/extend-by-character-001.html: Added.
layout-tests/editing/selection/extend-by-character-002-expected.txt: Added.
layout-tests/editing/selection/extend-by-character-002.html: Added.
layout-tests/editing/selection/extend-by-character-003-expected.txt: Added.
layout-tests/editing/selection/extend-by-character-003.html: Added.
layout-tests/editing/selection/extend-by-character-004-expected.txt: Added.
layout-tests/editing/selection/extend-by-character-004.html: Added.
layout-tests/editing/selection/extend-by-character-005-expected.txt: Added.
layout-tests/editing/selection/extend-by-character-005.html: Added.
layout-tests/editing/selection/move-by-character-001-expected.txt: Added.
layout-tests/editing/selection/move-by-character-001.html: Added.
layout-tests/editing/selection/move-by-character-002-expected.txt: Added.
layout-tests/editing/selection/move-by-character-002.html: Added.
layout-tests/editing/selection/move-by-character-003-expected.txt: Added.
layout-tests/editing/selection/move-by-character-003.html: Added.
layout-tests/editing/selection/move-by-character-004-expected.txt: Added.
layout-tests/editing/selection/move-by-character-004.html: Added.
layout-tests/editing/selection/move-by-character-005-expected.txt: Added.
layout-tests/editing/selection/move-by-character-005.html: Added.
layout-tests/editing/undo/redo-typing-001-expected.txt: Added.
layout-tests/editing/undo/redo-typing-001.html: Added.
layout-tests/editing/undo/undo-typing-001-expected.txt: Added.
layout-tests/editing/undo/undo-typing-001.html: Added.

8:14 AM Changeset in webkit [6314] by kocienda

27 edits
1 add in trunk

WebCore:

Reviewed by Dave

Added execCommand feature.
Added Javascript selection object.
This lays the groundwork for layout tests for editing.

khtml/dom/dom_doc.cpp: (DOM::Document::execCommand): Added. Calls through to impl's execCommand.
khtml/dom/dom_doc.h: Added execCommand declaration.
khtml/ecma/kjs_dom.cpp: (DOMDocumentProtoFunc::tryCall): Switch on new ExecCommand constant and call through to the document.
khtml/ecma/kjs_dom.h: Added ExecCommand constant. (KJS::DOMDocument::):
khtml/ecma/kjs_dom.lut.h: Generated file.
khtml/ecma/kjs_window.cpp: (Window::Window): Initialize selection object. (Window::selection): Return window's selection object. (Window::mark): Mark selection object. (WindowFunc::tryCall): Return selection object on GetSelection. (LocationFunc::tryCall): Added. (Selection::Selection): Added. (Selection::~Selection): Added. (Selection::get): Added. (Selection::put): Added. (Selection::toPrimitive): Added. (Selection::toString): Added. (SelectionFunc::tryCall): Added.
khtml/ecma/kjs_window.h: (KJS::Selection::): Added. (KJS::Selection::part): Added. (KJS::Selection::classInfo): Added.
khtml/ecma/kjs_window.lut.h: Generated file.
khtml/editing/htmlediting_impl.cpp: (debugPosition): Debugging aid. (DeleteCollapsibleWhitespaceCommandImpl::deleteWhitespace): Move the ending position if you are about to delete it. Fixes a crasher I discovered while writing tests. (DeleteSelectionCommandImpl::doApply): Move to containing editable block position 0 instead of 1 in a block in delete case 1. (InputTextCommandImpl::prepareForTextInsertion): (TypingCommandImpl::issueCommandForDeleteKey):
khtml/khtml_part.h:
khtml/khtml_selection.cpp: (KHTMLSelection::validate): Now adjusts the selection down to leaf nodes if needed. (KHTMLSelection::debugPosition): Debugging aid.
khtml/xml/dom_docimpl.cpp: (DocumentImpl::execCommand): Added. Supports five different commands.
khtml/xml/dom_docimpl.h:
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::previousEditable): Use false instead of 0 for equality check. (NodeImpl::nextEditable): Ditto.
khtml/xml/dom_position.cpp: (DOMPosition::equivalentLeafPosition): New function (DOMPosition::previousRenderedEditablePosition): New function (DOMPosition::nextRenderedEditablePosition): New function (DOMPosition::equivalentUpstreamPosition): Refined behavior to handle more cases correctly. (DOMPosition::equivalentDownstreamPosition): Ditto. (DOMPosition::atStartOfContainingEditableBlock):New function (DOMPosition::atStartOfRootEditableBlock):New function
khtml/xml/dom_position.h:
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::issueUndoCommand): New function for calling undo programatically. (KWQKHTMLPart::issueRedoCommand): Ditto, but for redo.
kwq/KWQRenderTreeDebug.cpp: (nodePositionRelativeToRoot): New function to generate log information for the selection. (writeSelection): Writes the selection if there is one. (externalRepresentation): Calls writeSelection
kwq/WebCoreBridge.h: New declarations for issueUndoCommand and issueRedoCommand.

WebKit:

Reviewed by Dave

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge issueUndoCommand]): New method. Forwards call to the undo manager. Added to support undo called via Javascript execCommand. (-[WebBridge issueRedoCommand]): Ditto.

Apr 5, 2004:

7:10 PM Changeset in webkit [6313] by darin

3 edits in trunk/WebCore

khtml/html/kentities.gperf: Added &COPY; and &REG;, both supported by Gecko (and presumably by WinIE). Also re-sorted the list.
khtml/html/kentities.c: Regenerated.

6:09 PM Changeset in webkit [6312] by darin

2 edits in trunk/WebCore

Reviewed by Dave.

rolled over fix from KHTML tree; anchor inside another anchor

khtml/rendering/render_layer.cpp: (RenderLayer::nodeAtPoint): Make sure the URL element is the innermost one, by not setting it once it's already set.

2:35 PM Changeset in webkit [6311] by hyatt

26 edits
2 adds in trunk/WebCore

Implement overflow: overlay so that a scrollbar can show/hide without causing a layout.

Reviewed by darin

ChangeLog:
khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
khtml/css/cssvalues.c: (hash_val): (findValue):
khtml/css/cssvalues.h:
khtml/css/cssvalues.in:
khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::rightOffset):
khtml/rendering/render_box.cpp: (RenderBox::contentWidth): (RenderBox::contentHeight):
khtml/rendering/render_layer.cpp: (RenderLayer::updateScrollInfoAfterLayout):
khtml/rendering/render_object.cpp: (RenderObject::clientWidth): (RenderObject::clientHeight):
khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::hasAutoScrollbars): (khtml::RenderStyle::scrollsOverflow): (khtml::RenderStyle::includeScrollbarSize):

1:46 PM Changeset in webkit [6310] by cblu

13 edits in trunk

Tests:

Made PDFBundle compilable and made it test the new selection SPI.

PDFBundle/Apple.pdf: Added.
PDFBundle/PDFBundle.pbproj/project.pbxproj:
PDFBundle/PDFView.h:
PDFBundle/PDFView.m: (-[PDFResourceDelegate connection:didReceiveData:]): (-[PDFResourceDelegate connectionDidFinishLoading:]): (-[PDFResourceDelegate connection:didFailLoadingWithError:]): (-[PDFView initWithFrame:pageURL:resourceURL:container:]): (-[PDFView dealloc]): (-[PDFView setIsSelected:]): (-[PDFView isSelected]): (-[PDFView drawRect:]): (-[PDFView layout]): (-[PDFRepresentation receivedError:withDataSource:]): (-[PDFRepresentation title]): (+[PDFPluginViewFactory pluginViewWithArguments:]):
PDFBundle/pdf.html: Added.

WebCore:

Fixed: <rdar://problem/3612580>: SPI: WebPlugin selection

Reviewed by kocienda.

WebCore.pbproj/project.pbxproj:
khtml/rendering/render_replaced.cpp: (RenderWidget::setSelectionState): new override, calls QWidget::setIsSelected
khtml/rendering/render_replaced.h: (khtml::RenderWidget::selectionState): new override
kwq/KWQWidget.h:
kwq/KWQWidget.mm: (QWidget::setIsSelected): new, calls [WebCoreBridge setIsSelected:forView:] (QWidget::isSelected): new, calls [WebCoreBridge isViewSelected:]
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge selectionColor]): new

WebKit:

Fixed: <rdar://problem/3612580>: SPI: WebPlugin selection

Reviewed by kocienda.

Plugins.subproj/WebPlugin.h: extended SPI for selection
Plugins.subproj/WebPluginContainer.h: ditto
Plugins.subproj/WebPluginController.m: (-[WebPluginController selectionColor]): new, calls [WebCoreBridge selectionColor]
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setIsSelected:forView:]): new, calls [WebPlugin setIsSelected:] (-[WebBridge isViewSelected:]): new, calls [WebPlugin isSelected]

Apr 3, 2004:

12:17 PM Changeset in webkit [6309] by hyatt

2 adds in trunk/LayoutTests/fast/parser

* empty log message *

12:15 PM Changeset in webkit [6308] by hyatt

2 edits in trunk/WebCore

Fix for 3601728, text overlaps borders at ejai.org. Remove all the code in addForbidden for
dir, menu, nobr, and pre that made them too restrictive regarding what child tags they could
contain.

Reviewed by kocienda

khtml/html/dtd.cpp: (DOM::addForbidden): (DOM::removeForbidden):

Apr 2, 2004:

11:55 AM Changeset in webkit [6307] by cblu

1 edit
1 add in trunk/WebKit

Forgot to add the WebKit copy of DOMExtensions.h.

DOM.subproj/DOMExtensions.h: Added.

11:48 AM Changeset in webkit [6306] by sullivan

3 edits in trunk/WebKit

WebKit:

Reviewed by Dave.

WebView.subproj/WebPreferences.m: (-[WebPreferences historyIsFrozen]): take out OMIT_TIGER_FEATURES ifdeffing, since if we turn this into API then we'll probably want it to work in Panther also. To protect Safari users, Safari now explicitly sets historyIsFrozen to NO when starting up in Panther.

English.lproj/StringsNotToBeLocalized.txt: updated for recent changes

WebBrowser:

made enough improvements to "Stealth Browsing" to consider this bug fixed: <rdar://problem/3184383>: Would like ability to do "stealth browsing" without leaving any tracks behind (history, etc.)

Reviewed by Dave.

AppController.m: (-[AppController applicationDidFinishLaunching:]): call [WebPreferences historyIsFrozen:NO] on Panther so command-line settings of this preference won't persist (-[AppController confirmEnableStealthMode]): new method, puts up a confirmation dialog explaining what stealth mode is, and turns stealth mode on if confirmed. I sent mail to Steve Lemay and Ron Brannan to discuss the wording of the dialog, among other things. (-[AppController toggleStealthMode:]): now calls confirmEnableStealthMode when stealth mode is being turned on