Context Navigation

khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Added implementations for these four properties: CSS_PROP_WHITE_SPACE, CSS_PROP_DISPLAY, CSS_PROP_FLOAT, and CSS_PROP_COLOR.

5:03 PM Changeset in webkit [6417] by vicki

2 edits in branches/Safari-1-2-branch/WebCore

roll out the change to WebCoreViewFactory.h. This isn't a part of the onscroll follow-up for 3612968

kwq/WebCoreViewFactory.h:

4:59 PM Changeset in webkit [6416] by cblu

3 edits in trunk/WebCore

Subresources weren't being archived for LINK tags.

Reviewed by kocienda.

khtml/xml/dom_nodeimpl.cpp: (NodeImpl::recursive_toHTMLWithOptions): indent tweak
kwq/DOMHTML.mm: (-[DOMHTMLLinkElement _linkElementImpl]): C++ casting voodoo to make methods like rel and href work correctly

4:29 PM Changeset in webkit [6415] by kocienda

2 edits in trunk/WebCore

Reviewed by Hyatt

khtml/html/html_elementimpl.cpp: (HTMLElementImpl::isContentEditable): Call getDocument()->updateRendering() to make sure outstanding changes for this attribute are applied. (HTMLElementImpl::contentEditable): Call getDocument()->updateRendering() to make sure outstanding changes for this attribute are applied. (HTMLElementImpl::setContentEditable): Call enabled.isEmpty() before strcasecmp(enabled, "true"). It's cheaper.

4:18 PM Changeset in webkit [6414] by kocienda

3 edits
4 adds in trunk

Reviewed by Hyatt

khtml/editing/htmlediting_impl.cpp: New helper. (DeleteSelectionCommandImpl::containsOnlyWhitespace): Fix deleting collapsed whitespace at the end of a line where text has flowed to the next line and the caret is at the beginning of the next line. (DeleteSelectionCommandImpl::doApply): Updated for new helper.
khtml/editing/htmlediting_impl.h:
layout-tests/editing/deleting/delete-line-end-ws-001-expected.txt: Added.
layout-tests/editing/deleting/delete-line-end-ws-001.html: Added.
layout-tests/editing/deleting/delete-line-end-ws-002-expected.txt: Added.
layout-tests/editing/deleting/delete-line-end-ws-002.html: Added.

4:03 PM Changeset in webkit [6413] by vicki

3 edits in trunk

set version to '138u'. the tree is open!

3:59 PM Changeset in webkit [6412]

3 copies in tags/Safari-137

This commit was manufactured by cvs2svn to create tag 'Safari-137'.

3:59 PM Changeset in webkit [6411] by vicki

6 edits in trunk

Safari-137 stamp

3:25 PM Changeset in webkit [6410] by kocienda

1 edit in trunk/WebCore/khtml/html/html_elementimpl.cpp

Ahh! I checked in changes in my tree when I rolled out. Rolling those changes out.

3:24 PM Changeset in webkit [6409] by kocienda

4 edits
4 deletes in trunk

Rolling out last change. Tree was closed.

3:13 PM Changeset in webkit [6408] by kocienda

3 edits
4 adds in trunk

Reviewed by Hyatt

khtml/editing/htmlediting_impl.cpp: (DeleteSelectionCommandImpl::containsOnlyWhitespace): New helper. (DeleteSelectionCommandImpl::doApply): Fix deleting collapsed whitespace at the end of a line where text has flowed to the next line and the caret is at the beginning of the next line.
khtml/editing/htmlediting_impl.h: Updated for new helper.
layout-tests/editing/deleting/delete-line-end-ws-001-expected.txt: Added.
layout-tests/editing/deleting/delete-line-end-ws-001.html: Added.
layout-tests/editing/deleting/delete-line-end-ws-002-expected.txt: Added.
layout-tests/editing/deleting/delete-line-end-ws-002.html: Added.

2:41 PM Changeset in webkit [6407] by vicki

2 edits
1 delete in branches/Safari-1-2-branch/WebKit

Reviewed by kocienda.

Make this change on the branch for SUPanLavender, at Amy Rapport's request

2004-03-03 Darin Adler <Darin Adler>

Reviewed by Vicki.

English.lproj/InfoPlist.strings: Removed. No need to localize the version and copyright string, and that's all that was in here.
WebKit.pbproj/project.pbxproj: Removed InfoPlist.strings from build.

2:38 PM Changeset in webkit [6406]

49 copies
3 deletes in tags/WebCore-125~6~1

This commit was manufactured by cvs2svn to create tag
'WebCore-125~6~1'.

2:38 PM Changeset in webkit [6405] by vicki

2 edits
1 delete in branches/Safari-1-2-branch/WebCore

Reviewed by kocienda.

Make this change on the branch for SUPanLavender, at Amy Rapport's request

2004-03-03 Darin Adler <Darin Adler>

Reviewed by Vicki.

English.lproj/InfoPlist.strings: Removed. No need to localize the version and copyright string, and that's all that was in here.
WebCore.pbproj/project.pbxproj: Removed InfoPlist.strings from build.

2:35 PM Changeset in webkit [6404]

6 copies
4 deletes in tags/JavaScriptCore-125~4~2

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-125~4~2'.

2:35 PM Changeset in webkit [6403] by vicki

2 edits
1 delete in branches/Safari-1-2-branch/JavaScriptCore

Reviewed by kocienda.

Make this change on the branch for SUPanLavender, per Amy Rapport's request.

2004-03-03 Darin Adler <Darin Adler>

Reviewed by Vicki.

English.lproj/InfoPlist.strings: Removed. No need to localize the version and copyright string, and that's all that was in here.
JavaScriptCore.pbproj/project.pbxproj: Removed InfoPlist.strings from build.

2:09 PM Changeset in webkit [6402] by rjw

10 edits in trunk

WebKit:

Added an SPI to allow ObjC instances to be easily bound to
JS. This is needed by the dashboard guys for their prototyping.
Eventually they will use new API.

Reviewed by Chris.

WebView.subproj/WebView.m: (-[WebView _bindObject:withName:toFrame:]):
WebView.subproj/WebViewPrivate.h:

WebCore:

Added an SPI to allow ObjC instances to be easily bound to
JS. This is needed by the dashboard guys for their prototyping.
Eventually they will use new API.

Reviewed by Chris.

kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::bindObject):
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge bindObject:withName:]):

JavaScriptCore:

Added interpreter lock protection around object creation.

Reviewed by Chris.

bindings/runtime.cpp: (Instance::createRuntimeObject):

1:54 PM Changeset in webkit [6401] by vicki

1 edit in branches/Safari-1-2-branch/WebCore/ChangeLog-2005-08-23

Move the release marker for WebCore-125.6. (I moved the tags so that my last commit is now a part of WebCore-125.6, since this version number is getting kind of high)

12:51 PM Changeset in webkit [6400] by cblu

47 edits
1 add in trunk

WebCore:

Added DOMHTMLEmbedElement as a DOM extension since EMBED is represented in our DOM even though its not part of the spec.
Added all DOMCore and DOMHTML symbols to WebCore's symbols file.
Removed isSubresourceURLAttribute from dom node. This was only used for the WebArchive feature and all that work is now done in WebKit.

Reviewed by kocienda.

WebCore-combined.exp:
WebCore.exp:
khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::isURLAttribute): renamed from isSubresourceURLAttribute. As a convenience to subclasses, dom_elementimpl would call isSubresourceURLAttribute in isURLAttribute, but this is no longer done (HTMLFrameElementImpl::isURLAttribute): ditto (HTMLIFrameElementImpl::isURLAttribute): ditto
khtml/html/html_baseimpl.h:
khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::isURLAttribute): ditto
khtml/html/html_formimpl.h:
khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::isURLAttribute): ditto
khtml/html/html_headimpl.h:
khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::isURLAttribute): ditto
khtml/html/html_imageimpl.h:
khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::isURLAttribute): ditto (HTMLObjectElementImpl::isURLAttribute): ditto (HTMLParamElementImpl::isURLAttribute): ditto
khtml/html/html_objectimpl.h:
khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::isURLAttribute): ditto (HTMLTableCellElementImpl::isURLAttribute): ditto
khtml/html/html_tableimpl.h:
khtml/xml/dom2_rangeimpl.cpp: (RangeImpl::toHTMLWithOptions): take a node list (see below)
khtml/xml/dom2_rangeimpl.h:
khtml/xml/dom_elementimpl.cpp: (ElementImpl::isURLAttribute):
khtml/xml/dom_elementimpl.h:
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::recursive_toHTMLWithOptions): append copied nodes to a list of nodes so that WebKit can operate on them
khtml/xml/dom_nodeimpl.h:
kwq/DOM.mm: (+[DOMNode _nodeWithImpl:]): added support for HTML types
kwq/DOMExtensions.h:
kwq/DOMHTML.mm: (-[DOMHTMLPreElement setWidth:]): (-[DOMHTMLEmbedElement _embedElementImpl]): (-[DOMHTMLEmbedElement align]): (-[DOMHTMLEmbedElement setAlign:]): (-[DOMHTMLEmbedElement height]): (-[DOMHTMLEmbedElement setHeight:]): (-[DOMHTMLEmbedElement name]): (-[DOMHTMLEmbedElement setName:]): (-[DOMHTMLEmbedElement src]): (-[DOMHTMLEmbedElement setSrc:]): (-[DOMHTMLEmbedElement type]): (-[DOMHTMLEmbedElement setType:]): (-[DOMHTMLEmbedElement width]): (-[DOMHTMLEmbedElement setWidth:]): (-[DOMHTMLTableElement background]): (-[DOMHTMLTableElement setBackground:]): (-[DOMHTMLTableCellElement background]): new extension (-[DOMHTMLTableCellElement setBackground:]): ditto
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge nodesFromList:]): new (-[WebCoreBridge markupStringFromNode:nodes:]): return a list of nodes instead of subresource URLs so WebKit can operate on the nodes (-[WebCoreBridge markupStringFromRange:nodes:]): ditto

WebKit:

Fixed: <rdar://problem/3587599>: Mail Page, Web Archives don't preserve subframes
Moved code that assembled subresource URLs from DOM nodes from WebCore to WebKit.

Reviewed by rjw.

DOM.subproj/DOMExtensions.h: copied from WebCore
DOM.subproj/WebDOMOperations.h:
DOM.subproj/WebDOMOperations.m: (-[DOMNode webArchive]): call renamed methods (-[DOMNode markupString]): ditto (-[DOMNode _URLsFromSelectors:]): new, returns array of URLs given selectors (-[DOMNode _subresourceURLs]): new, base class does nothing, subclasses call _URLsFromSelectors with URL selectors (-[DOMDocument webFrame]): new (-[DOMRange webArchive]): call renamed methods (-[DOMRange markupString]): ditto (-[DOMHTMLBodyElement _subresourceURLs]): new (-[DOMHTMLInputElement _subresourceURLs]): new (-[DOMHTMLLinkElement _subresourceURLs]): new (-[DOMHTMLScriptElement _subresourceURLs]): new (-[DOMHTMLImageElement _subresourceURLs]): new (-[DOMHTMLEmbedElement _subresourceURLs]): new (-[DOMHTMLObjectElement _subresourceURLs]): new (-[DOMHTMLParamElement _subresourceURLs]): new (-[DOMHTMLTableElement _subresourceURLs]): new (-[DOMHTMLTableCellElement _subresourceURLs]): new
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebArchive.h:
WebView.subproj/WebArchive.m: (-[WebArchivePrivate dealloc]): release new subframeArchives ivar (-[WebArchive initWithMainResource:subresources:subframeArchives:]): take subframeArchives (-[WebArchive _initWithPropertyList:]): new, recursively creates WebArchives (-[WebArchive initWithData:]): call _initWithPropertyList (-[WebArchive subframeArchives]): new (-[WebArchive _propertyListRepresentation]): new, recursively creates property lists of WebArchives (-[WebArchive data]): call _propertyListRepresentation
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate saveResource]): call renamed methods
WebView.subproj/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): release new pendingSubframeArchives ivar (-[WebDataSource _archiveWithMarkupString:nodes:]): renamed and reimplemented, handles subframes (-[WebDataSource _archive]): new (-[WebDataSource _setPendingSubframeArchives:]): new (-[WebDataSource _archiveForFrameName:]): new
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebFrame.m: (-[WebFrame loadArchive:]): handle subframes (-[WebFrame _loadRequest:subresources:subframeArchives:]): ditto (-[WebFrame _loadURL:intoChild:]): use the subframe archive if we have it (-[WebFrame loadRequest:]): call renamed methods
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation loadWebArchive]): call renamed methods and handle subframes
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _selectedArchive:]): call renamed methods (-[WebHTMLView _pasteFromPasteboard:]): call renamed methods
WebView.subproj/WebHTMLViewPrivate.h:
WebView.subproj/WebImageRepresentation.h:
WebView.subproj/WebImageRepresentation.m: instead of storing some items from the data source, just store the data source (-[WebImageRepresentation dealloc]): removed use of deleted ivars (-[WebImageRepresentation URL]): use dataSource instead of ivar (-[WebImageRepresentation doneLoading]): use new boolean ivar (-[WebImageRepresentation setDataSource:]): store the data source (-[WebImageRepresentation receivedData:withDataSource:]): use dataSource instead of ivar (-[WebImageRepresentation receivedError:withDataSource:]): ditto (-[WebImageRepresentation finishedLoadingWithDataSource:]): ditto (-[WebImageRepresentation title]): ditto (-[WebImageRepresentation data]): ditto (-[WebImageRepresentation filename]): ditto (-[WebImageRepresentation archive]): ditto
WebView.subproj/WebResource.h:
WebView.subproj/WebResource.m: (-[WebResourcePrivate dealloc]): release new frame name ivar (-[WebResource initWithData:URL:MIMEType:textEncodingName:frameName:]): take a frame name (-[WebResource frameName]): new (-[WebResource _initWithPropertyList:]): handle frame name (-[WebResource _initWithCachedResponse:originalURL:]): call renamed methods (-[WebResource _propertyListRepresentation]):
WebView.subproj/WebResourcePrivate.h: handle frame name

WebBrowser:

Reviewed by rjw.

BrowserDocument.m: (-[BrowserDocument mailPageAddress:]): call renamed methods

12:35 PM Changeset in webkit [6399] by vicki

1 edit in branches/Safari-1-2-branch/WebKit/WebKit.pbproj/project.pbxproj

correct version number (WebKit-125.2)

12:34 PM Changeset in webkit [6398]

50 copies
2 deletes in tags/WebCore-125~6

This commit was manufactured by cvs2svn to create tag
'WebCore-125~6'.

12:34 PM Changeset in webkit [6397] by vicki

10 edits in branches/Safari-1-2-branch

WebCore:

follow-up fix for 3612968 (clone of 3487207). Implement onscroll at the document level.

2004-03-25 David Hyatt <hyatt@apple.com>

Implement the rest of the search field. Make it work with form
submission. Implement onscroll at the document level.

Reviewed by darin

kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendScrollEvent):
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge sendScrollEvent]):
kwq/WebCoreViewFactory.h:

WebKit:

follow-up fix for 3612968 (clone of 3487207). Implement onscroll at the document level.

2004-03-25 David Hyatt <hyatt@apple.com>

Implement the rest of the search field.

Implement onscroll at the document level.

Reviewed by darin

WebKit.pbproj/project.pbxproj:
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _frameOrBoundsChanged]): (-[WebHTMLView viewDidMoveToWindow]):
WebView.subproj/WebHTMLViewPrivate.h:

11:54 AM Changeset in webkit [6396] by mjs

3 edits in trunk/JavaScriptCore

Reviewed by Ken.

Another JavaScript speed improvement: use the mechanism from
string append optimization to make taking a substring fast, again
sharing the buffer.

A further 22% improvement on the 24fun string speed test.

kjs/ustring.cpp: (KJS::): (KJS::UString::Rep::create): (KJS::UString::UString): (KJS::UString::append): (KJS::UString::operator=): (KJS::UString::substr):
kjs/ustring.h: (KJS::UString::Rep::data):

Apr 15, 2004:

6:07 PM Changeset in webkit [6395] by hyatt

4 edits in trunk/WebCore

Fix for 3624335, bugs with overflow and positioned objects. The scrollbar didn't properly update
as you changed the sizes of positioned objects inside an overflow block.

Reviewed by rjw

khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock):
khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutBlock):
khtml/rendering/render_layer.cpp: (RenderLayer::updateScrollInfoAfterLayout):

5:31 PM Changeset in webkit [6394] by vicki

1 edit in branches/Safari-1-2-branch/WebCore/ChangeLog-2005-08-23

fix the release marker in the ChangeLog

4:52 PM Changeset in webkit [6393] by vicki

2 edits in branches/Safari-1-2-branch/WebCore

merge the rest of the fix for the zeldman bug (3609695) from HEAD

khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::lowestPosition): (khtml::RenderBlock::rightmostPosition): (khtml::RenderBlock::leftmostPosition):

4:23 PM Changeset in webkit [6392] by kocienda

22 edits in trunk/WebCore

Reviewed by Dave

Improved selection behavior. As part of this work, I removed
almost all of the checkSelectionPoint() functions, leaving
only those associated with fonts, and all of the
checkSelectionPointIgnoringContinuations() functions. Each
of these has been replaced by a new function called
positionForCoordinates(), which returns a DOMPosition.

WebCore.pbproj/project.pbxproj:
khtml/khtml_events.cpp: (khtml::MouseEvent::offset): Converted to use positionForCoordinates.
khtml/khtml_part.cpp: Ditto. (KHTMLPart::isPointInsideSelection): (KHTMLPart::handleMousePressEventDoubleClick): Ditto. (KHTMLPart::handleMousePressEventTripleClick): Ditto. (KHTMLPart::handleMousePressEventSingleClick): Ditto. (KHTMLPart::handleMouseMoveEventSelection): Ditto. (KHTMLPart::khtmlMouseReleaseEvent): Ditto.
khtml/khtml_part.h:
khtml/rendering/render_block.cpp: (khtml::RenderBlock::positionForBox): New helper. (khtml::RenderBlock::positionForRenderer): New helper. (khtml::RenderBlock::positionForCoordinates): New selection-node-offset-finder method.
khtml/rendering/render_block.h:
khtml/rendering/render_br.cpp: Removed checkSelectionPointIgnoringContinuations. No special behavior is needed for this class anymore.
khtml/rendering/render_br.h: Ditoo.
khtml/rendering/render_container.cpp: (RenderContainer::positionForCoordinates): New selection-node-offset-finder method.
khtml/rendering/render_container.h:
khtml/rendering/render_line.cpp: (InlineBox::firstLeafChild): New helper. (InlineBox::lastLeafChild): New helper. (InlineFlowBox::firstLeafChild): New helper. (InlineFlowBox::lastLeafChild): New helper.
khtml/rendering/render_line.h:
khtml/rendering/render_object.cpp: (RenderObject::firstLeafChild): New helper. (RenderObject::lastLeafChild): New helper. (RenderObject::positionForCoordinates):
khtml/rendering/render_object.h:
khtml/rendering/render_replaced.cpp: (RenderReplaced::positionForCoordinates): New selection-node-offset-finder method.
khtml/rendering/render_replaced.h:
khtml/rendering/render_text.cpp: (InlineTextBox::offsetForPosition): New helper, replaces checkSelectionPoint() (RenderText::positionForCoordinates): New selection-node-offset-finder method.
khtml/rendering/render_text.h:
khtml/xml/dom_nodeimpl.cpp: Added positionForCoordinates() convenience here. This checks to see if the node has a renderer before doing the position check.
khtml/xml/dom_nodeimpl.h: Ditto.
kwq/DOM.mm: (-[DOMNode isContentEditable]): Added this unrelated method, since without it, I crash when dragging an image.
kwq/WebCoreBridge.mm: (-[WebCoreBridge moveCaretToPoint:]): Converted to use positionForCoordinates.

4:15 PM Changeset in webkit [6391] by hyatt

12 edits in trunk/WebCore

Fix for 3603455, block truncation support.

Reviewed by kocienda

khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssproperties.c: (hash_prop): (findProp):
khtml/css/cssproperties.h:
khtml/css/cssproperties.in:
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
khtml/ecma/kjs_css.cpp: (cssPropertyName):
khtml/rendering/render_block.cpp: (khtml::RenderBlock::lineCount): (khtml::RenderBlock::heightForLineCount):
khtml/rendering/render_block.h:
khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutHorizontalBox): (khtml::RenderFlexibleBox::layoutVerticalBox):
khtml/rendering/render_style.cpp: (marquee): (StyleCSS3NonInheritedData::operator==): (RenderStyle::diff):
khtml/rendering/render_style.h: (khtml::RenderStyle::lineClamp): (khtml::RenderStyle::setLineClamp): (khtml::RenderStyle::initialLineClamp):

3:28 PM Changeset in webkit [6390] by hyatt

3 edits in trunk/WebKit

Make sure isOpaque returns NO when the WebHTMLVIew doesn't draw its background.

Reviewed by darin

WebView.subproj/WebFrameView.m: (-[WebFrameView isOpaque]):
WebView.subproj/WebHTMLView.m: (-[WebHTMLView isOpaque]):

11:32 AM Changeset in webkit [6389]

10 copies
3 deletes in tags/WebKit-125~1~1

This commit was manufactured by cvs2svn to create tag
'WebKit-125~1~1'.

11:32 AM Changeset in webkit [6388]

7 copies
3 deletes in tags/JavaScriptCore-125~4~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-125~4~1'.

11:32 AM Changeset in webkit [6387] by vicki

6 edits in branches/Safari-1-2-branch

Fix mismatched_CFBundleShortVersionStrings verification failure

English.lproj/InfoPlist.strings:

10:51 AM Changeset in webkit [6386] by vicki

1 edit in branches/Safari-1-2-branch/JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj

change marketing number from 1.2 to 1.2.2

10:50 AM Changeset in webkit [6385] by sullivan

2 edits in trunk/WebKit

WebView.subproj/WebPreferencesPrivate.h: added comments

Apr 14, 2004:

6:35 PM Changeset in webkit [6384]

9 copies
3 deletes in tags/WebKit-125~1

This commit was manufactured by cvs2svn to create tag 'WebKit-125~1'.

6:35 PM Changeset in webkit [6383] by vicki

2 edits in branches/Safari-1-2-branch/WebKit

versioning for SUPanLavender, WebKit-125.1

6:29 PM Changeset in webkit [6382] by vicki

2 edits in branches/Safari-1-2-branch/WebCore

versioning for SUPanLavender, WebCore-125.6

6:20 PM Changeset in webkit [6381] by vicki

2 edits in branches/Safari-1-2-branch/WebKit

Merge fix for 3612933 from HEAD. There are two changes for this fix.

2004-03-11 Richard Williamson <rjw@apple.com>

Workaround for 3585644. Force the window number of the
mouse moved event to be correct.

Reviewed by Chris.

Carbon.subproj/CarbonWindowFrame.m:

2004-04-14 Richard Williamson <rjw@apple.com>

Updated fix for 3576315. Don't hardcode 22 as the titlebar
height. (Note, other places in CarbonWindowFrame DO hardcode
window geometry information, yuck!).

Reviewed by Hyatt.

Carbon.subproj/CarbonWindowFrame.m:

6:07 PM Changeset in webkit [6380] by vicki

8 edits in branches/Safari-1-2-branch/WebCore

fix build errors, update a few more files for 3612968

khtml/rendering/render_table.cpp: remove a stray curly bracket (from merging) that was breaking the build
kwq/KWQKURL.mm: (KURL::KURL): remove a wayward break statement that was breaking the build

khtml/misc/htmlattrs.c: (hash_attr): (findAttr):
khtml/misc/htmlattrs.h:
kwq/KWQValueList.h: (QValueList::insert): (QValueList::fromLast):
kwq/KWQValueListImpl.h:
kwq/KWQValueListImpl.mm: (KWQValueListImpl::clear): (KWQValueListImpl::insert): (KWQValueListImpl::fromLast):

5:51 PM Changeset in webkit [6379] by rjw

2 edits in trunk/WebKit

Updated fix for 3576315. Don't hardcode 22 as the titlebar
height. (Note, other places in CarbonWindowFrame DO hardcode
window geometry information, yuck!).

Reviewed by Hyatt.

Carbon.subproj/CarbonWindowFrame.m:

4:49 PM Changeset in webkit [6378] by vicki

9 edits in branches/Safari-1-2-branch/WebCore

merge fix for 3612968 from HEAD

2004-03-23 David Hyatt <hyatt@apple.com>

Fix for 3487207, implement onscroll DOM event for elements with overflow:auto/scroll/hidden. This does
not handle firing onscroll on the window when the document scrolls, nor does it handle firing onscroll
on textareas. These are two separate bugs.

This patch finishes stubbing out the onscroll event and adds support for it to the DOM. It also supports
the firing of the event when overflow blocks scroll.

Reviewed by darin

khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): (DOMNode::putValue):
khtml/ecma/kjs_dom.h: (KJS::DOMNode::):
khtml/ecma/kjs_window.cpp: (Window::get): (Window::put):
khtml/ecma/kjs_window.h: (KJS::Window::):
khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute):
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute):
khtml/misc/htmlattrs.in:
khtml/rendering/render_layer.cpp: (RenderLayer::scrollToOffset):

4:17 PM Changeset in webkit [6377] by vicki

6 edits in branches/Safari-1-2-branch/WebCore

merge fix for 3609690 from HEAD

2004-02-11 David Hyatt <hyatt@apple.com>

Fix for 3556037, regression where display:block generated content didn't work.

Reviewed by kocienda

khtml/rendering/render_block.cpp: (khtml::RenderBlock::setStyle): (khtml::RenderBlock::addChildToFlow): (khtml::RenderBlock::removeChild): (khtml::RenderBlock::renderName):
khtml/rendering/render_container.cpp: (RenderContainer::insertChildNode): (RenderContainer::removeLeftoverAnonymousBoxes):
khtml/rendering/render_inline.cpp: (RenderInline::splitFlow): (RenderInline::renderName):
khtml/rendering/render_list.cpp: (RenderListItem::updateMarkerLocation):
khtml/rendering/render_object.h: (khtml::RenderObject::isAnonymousBlock):

4:11 PM Changeset in webkit [6376] by vicki

5 edits in branches/Safari-1-2-branch/WebCore

merge fix for 3609686 from HEAD

2004-02-23 David Hyatt <hyatt@apple.com>

Fix for 3549772, hangs on border collapsing.

Reviewed by darin

khtml/rendering/render_object.cpp: (RenderObject::collectBorders):
khtml/rendering/render_object.h:
khtml/rendering/render_table.cpp: (RenderTable::paint): (compareBorders): (RenderTableCell::paint): (addBorderStyle): (RenderTableCell::collectBorders):
khtml/rendering/render_table.h:

4:05 PM Changeset in webkit [6375] by hyatt

1 edit in trunk/WebCore/khtml/rendering/render_table.h

Remove garbage from the render table header.

1:39 PM Changeset in webkit [6374] by sullivan

5 edits in trunk/WebKit

WebKit:

changed stealth mode preference name from "historyIsFrozen" to "privateBrowsingEnabled"

Reviewed by Darin.

WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): updated for method name change

WebView.subproj/WebPreferences.m: changed preference key name (+[WebPreferences initialize]): updated for preference key name change (-[WebPreferences setPrivateBrowsingEnabled:]): changed name from setHistoryIsFrozen: (-[WebPreferences privateBrowsingEnabled]): changed name from historyIsFrozen:

WebView.subproj/WebPreferencesPrivate.h: changed declared method names

English.lproj/StringsNotToBeLocalized.txt: updated for this and other recent changes

WebBrowser:

fixed these bugs:
<rdar://problem/3622190>: stealth mode menu item should be "Start Private Browsing�Stop Private Browsing"
<rdar://problem/3622479>: Reword Private Browsing confirmation to use Ron's edited wording
<rdar://problem/3622496>: stealth mode should automatically turn off between sessions

Also, updated for WebKit stealth mode preference name change

Reviewed by Darin.

AppController.m: (-[AppController applicationDidFinishLaunching:]): always turn off stealth mode on launch (previously did this only on Panther) (-[AppController confirmEnableStealthMode]): reworded confirmation title and message; also updated for preference name change (-[AppController toggleStealthMode:]): updated for preference name change (-[AppController validateUserInterfaceItem:]): use "Start/Stop" instead of checkmark to distinguish states; also updated for preference name change

BrowserWindowController.m: (-[BrowserWindowController searchField:shouldRememberSearchString:]): updated for preference name change

DownloadProgressEntry.m: (-[DownloadProgressEntry setDownloadStage:]): updated for preference name change

English.lproj/Localizable.strings:
English.lproj/StringsNotToBeLocalized.txt: updated for these changes

English.lproj/MainMenu.nib: changed menu item in the nib to "Start Private Browsing�, though this doesn't really matter since the toggling menu item title comes from the code now.

FormCompletionController.m: (+[FormCompletionController shouldSaveFormData]): updated for preference name change (+[FormCompletionController shouldSaveUsernamesAndPasswords]): ditto

10:47 AM Changeset in webkit [6373]

6 copies
3 deletes in tags/JavaScriptCore-125~4

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-125~4'.

10:47 AM Changeset in webkit [6372] by vicki

2 edits in branches/Safari-1-2-branch/JavaScriptCore

set JavaScriptCore version to 125.4 for SUPanLavender, and add a release marker to the ChangeLog

Apr 13, 2004:

11:10 PM Changeset in webkit [6371] by vicki

2 edits in branches/Safari-1-2-branch/WebKit

merge fix for 3613071 from HEAD

2004-04-06 Richard Williamson <rjw@apple.com>

Fixed 3510805. Only release pool in timer if the current nesting level of the
pool matches the nesting level when the pool was created.

Reviewed by Chris.

Carbon.subproj/CarbonUtils.m: (getNumPools): (WebInitForCarbon): (PoolCleaner):

10:57 PM Changeset in webkit [6370] by vicki

6 edits in branches/Safari-1-2-branch

WebCore:

merged WebCore part of the fix for 3609723 from HEAD

2004-03-23 David Hyatt <hyatt@apple.com>

Fix for 3513627, HTML mail prints upside down occasionally. Change printing
so that it never resizes the WebHTMLView when formatting for printing.
When computing page rects, instead of using the view's bounds, use the root
layer's width instead.

Reviewed by darin

khtml/khtmlview.cpp: (KHTMLView::layout):
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]):

WebKit:

merge the WebKit part of the fix for 3609723 from HEAD

2004-03-23 David Hyatt <hyatt@apple.com>

Fix for 3513627, HTML mail prints upside down occasionally. Change printing so that it never resizes the
WebHTMLView when formatting for printing. When computing page rects, instead of using the view's bounds,
use the root layer's width instead.

Reviewed by darin

WebView.subproj/WebHTMLView.m: (-[WebHTMLView knowsPageRange:]):

10:42 PM Changeset in webkit [6369] by vicki

2 edits in branches/Safari-1-2-branch/WebKit

merge fix for 3609714 from HEAD

2004-04-01 Richard Williamson <rjw@apple.com>

Fixed 3609493. Don't remove the plugin's view until after
sending pluginDestroy. This change was requested by Greg
and is needed in the Lavender update.

Reviewed by Greg Bolsinga.

Plugins.subproj/WebPluginController.m: (-[WebPluginController destroyAllPlugins]):

10:34 PM Changeset in webkit [6368] by vicki

2 edits in branches/Safari-1-2-branch/WebKit

merge fix for 3609700 from HEAD

2004-03-17 Richard Williamson <rjw@apple.com>

Fixed 3591667. Plugin view is added to view hierarchy before calling init.

Reviewed by Ken.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView addSubview:]):

10:27 PM Changeset in webkit [6367] by vicki

2 edits in branches/Safari-1-2-branch/WebCore

merge fix for 3609695 from HEAD

2004-02-11 David Hyatt <hyatt@apple.com>

Fix for 3556702, margin collapsing gets disabled when images spill out of the containing block.

Reviewed by kocienda

khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlockChildren):

9:20 PM Changeset in webkit [6366] by vicki

3 edits in branches/Safari-1-2-branch/WebCore

merged fix for 3609640 from HEAD. To fix this properly, we need code changes from both 3552346 and 3571356.

2004-02-27 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dave.

fixed <rdar://problem/3571356>: REGRESSION: Crash in isPointInsideSelection clicking on link in Apple web directory frame

khtml/khtml_part.cpp: (KHTMLPart::isPointInsideSelection): Don't crash if innerNode is NULL, as this can happen mousing over a frame that's in the process of loading and currently empty. Since such a frame obviously can't be inside the selection, this seems like a good enough fix.

2004-02-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin.

<rdar://problem/3552346>: REGRESSION 100-125: nil-dereference in
KHTMLPart::isPointInsideSelection (progz.ru, many other sites)

khtml/rendering/render_layer.cpp: (RenderLayer::nodeAtPointForLayer): To cover the case of positioned generated content, make sure to find an element if we don't have one yet when we get to the layer level.

9:10 PM Changeset in webkit [6365] by vicki

6 edits in branches/Safari-1-2-branch/WebCore

merge fix for 3609604 from HEAD

2004-02-17 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin.

<rdar://problem/3537397>: REGRESSION (100-114): Return doesn't work in Japanese
input method for some HomePage fields

kwq/KWQTextArea.mm: (-[KWQTextAreaTextView keyDown:]): Don't send events through DOM when there is marked text. (-[KWQTextAreaTextView keyUp:]): Ditto.
kwq/KWQTextField.mm: (-[KWQTextField textView:shouldHandleEvent:]): Ditto. (-[KWQSecureTextField textView:shouldHandleEvent:]): Ditto.
khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::defaultEventHandler): No need to check for marked text on "return" any more, because we won't send key events through the DOM at all when there is marked text.
kwq/KWQLineEdit.h:
kwq/KWQLineEdit.mm: Removed haveMarkedText method, no longer used by anything.

8:58 PM Changeset in webkit [6364] by vicki

2 edits in branches/Safari-1-2-branch/WebCore

merge fix for 3612956 from HEAD

2004-03-30 Darin Adler <Darin Adler>

Reviewed by Dave.

fixed <rdar://problem/3570877>: REGRESSION: onfocus handler not working at weather.com

khtml/ecma/kjs_binding.cpp: (UString::string): Turn a null UString into a null DOMString, but a non-null empty UString into a non-null empty DOMString. (UString::qstring): Ditto, for QString. (Identifier::string): Ditto, for Identifier. (Identifier::qstring): Ditto.

8:49 PM Changeset in webkit [6363] by vicki

4 edits in branches/Safari-1-2-branch

WebCore:

merge WebCore part of fix for 3612925 from HEAD

2004-03-24 Darin Adler <Darin Adler>

Reviewed by John.

fixed <rdar://problem/3566805>: REGRESSION: When the subject of mailto is 2 byte Safari failed to send mail address and subject to Mail.app

kwq/KWQKURL.mm: (KURL::findHostnamesInMailToURL): Update to handle hostnames that end just before a '?' since a '?' ends the entire part of the URL that can contain hostnames. Also change the logic so that the '?' will successfully end the search.

WebKit:

merge WebKit part of fix for 3612925 from HEAD

2004-03-24 Darin Adler <Darin Adler>

Reviewed by John.

fixed <rdar://problem/3566805>: REGRESSION: When the subject of mailto is 2 byte Safari failed to send mail address and subject to Mail.app

Misc.subproj/WebNSURLExtras.m: (applyHostNameFunctionToMailToURLString): Update to handle hostnames that end just before a '?' since a '?' ends the entire part of the URL that can contain hostnames. Also change the logic so that the '?' will successfully end the search.

8:35 PM Changeset in webkit [6362] by vicki

2 edits in branches/Safari-1-2-branch/WebCore

merge fix for 3609635 from HEAD

2004-02-15 Darin Adler <Darin Adler>

Reviewed by Dave.

fixed 3548533: crash in XMLHttpRequest::slotData using Orkut's rating system

khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::~XMLHttpRequest): Delete the QObject side, which has a side effect of disconnecting the signals which seem to be firing after the request is gone. There may be another way of addressing the crash by correcting some other problem with killing the job, but this demonstrably works and fixes a storage leak.

8:27 PM Changeset in webkit [6361] by vicki

2 edits in branches/Safari-1-2-branch/WebCore

merge fix for 3600904 from HEAD

2004-03-08 Darin Adler <Darin Adler>

Reviewed by Maciej.

fixed <rdar://problem/3554876>: REGRESSION (100-125): cannot upload file if path contains non-ASCII characters

kwq/KWQKURL.mm: Remove Colon constant so we can fit in 8 bits again. (KURL::KURL): Rewrite so we don't need isSchemeCharOrColon.

7:33 PM Changeset in webkit [6360] by mjs

5 edits in trunk/JavaScriptCore

Reviewed by Darin.

fixed <rdar://problem/3600695>: String manipulation in JavaScript 24fun test is very slow (slow)
fixed <rdar://problem/3600691>: Table generation test is really slow
fixed <rdar://problem/3600661>: 24fun date test is really slow

80% speedup on the string test, lesser speedups on the other two.

Two different optimizations here:

1) Avoid large overhead of scanning strings to see if they are all
ASCII before numeric conversion.

kjs/nodes.cpp: (AssignNode::evaluate): Don't convert to integer until we know for sure the operation will need it. Attempting to convert strings to numbers is a waste when they are being appended with +=.

2) Avoid huge cost of appending strings.

This is done by allowing multiple strings to share a buffer but
actually use different ranges of it. The first time a string is
appended to, we start leaving at least 10% extra space in the
buffer, so doing N appends to the same string takes O(log N)
mallocs instead of O(N).

kjs/identifier.cpp: (KJS::Identifier::equal): (KJS::Identifier::add):
kjs/ustring.cpp: (KJS::): (KJS::UCharReference::operator=): (KJS::UCharReference::ref): (KJS::UString::Rep::create): (KJS::UString::Rep::destroy): (KJS::UString::expandedSize): (KJS::UString::usedCapacity): (KJS::UString::expandCapacity): (KJS::UString::UString): (KJS::UString::null): (KJS::UString::append): (KJS::UString::operator=): (KJS::UString::toStrictUInt32): (KJS::UString::detach): (KJS::KJS::operator==):
kjs/ustring.h: (KJS::UString::Rep::data): (KJS::UString::Rep::hash):

6:00 PM Changeset in webkit [6359] by cblu

13 edits in trunk

WebCore:

Removed WebCoreElementIsEditableKey. This functionality is available via [DOMNode isContentEditable].

Reviewed by rjw.

WebCore-combined.exp:
WebCore.exp:
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): removed use of WebCoreElementIsEditableKey (-[WebCoreBridge URLWithRelativeString:]): new method for WebKit API

WebKit:

Added WebElementDOMNodeKey as a potential API so that clients can get the node from an element dictionary.
Removed WebElementIsEditableKey. This functionality is available via [DOMNode isContentEditable].

Reviewed by rjw.

DOM.subproj/WebDOMOperations.h:
DOM.subproj/WebDOMOperations.m: (-[DOMDocument URLWithRelativeString:]): new potential API
WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): indenting tweak (-[WebDefaultUIDelegate copyImageToClipboard:]): use WebElementDOMNodeKey
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _handleMouseDragged:]): use WebElementDOMNodeKey (-[WebHTMLView _dragOperationForDraggingInfo:]): use isContentEditable
WebView.subproj/WebView.h:
WebView.subproj/WebView.m:
WebView.subproj/WebViewPrivate.h:

4:02 PM Changeset in webkit [6358] by hyatt

2 adds in trunk/LayoutTests/fast/overflow

Add overflow test for overflow:scroll body quirk bug.

3:57 PM Changeset in webkit [6357] by hyatt

14 edits in trunk/WebCore

Fix for 3559764, make sure overflow is applied consistently using a separate bit on render objects, so that
the body scroll quirk can easily disable overflow even when it is present on the style.

Reviewed by kocienda

khtml/ecma/kjs_dom.cpp: (DOMNode::putValue):
khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
khtml/rendering/render_block.cpp: (khtml::RenderBlock::setStyle): (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::paintObject): (khtml::RenderBlock::rightOffset): (khtml::RenderBlock::lowestPosition): (khtml::RenderBlock::rightmostPosition): (khtml::RenderBlock::leftmostPosition): (khtml::RenderBlock::isPointInScrollbar): (khtml::RenderBlock::nodeAtPoint): (khtml::RenderBlock::inRootBlockContext):
khtml/rendering/render_block.h: (khtml::RenderBlock::overflowHeight): (khtml::RenderBlock::overflowWidth):
khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::contentWidth): (RenderBox::contentHeight): (RenderBox::absolutePosition): (RenderBox::computeAbsoluteRepaintRect): (RenderBox::calcAbsoluteVertical):
khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutBlock):
khtml/rendering/render_flow.cpp: (RenderFlow::lowestPosition): (RenderFlow::rightmostPosition): (RenderFlow::leftmostPosition):
khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPosition): (RenderLayer::updateScrollInfoAfterLayout): (RenderLayer::intersectsDamageRect): (RenderLayer::containsPoint):
khtml/rendering/render_object.cpp: (RenderObject::RenderObject): (RenderObject::requiresLayer): (RenderObject::clientWidth): (RenderObject::clientHeight): (RenderObject::scrollWidth): (RenderObject::scrollHeight): (RenderObject::setStyle): (RenderObject::absolutePosition): (RenderObject::nodeAtPoint): (RenderObject::avoidsFloats):
khtml/rendering/render_object.h: (khtml::RenderObject::hasOverflowClip): (khtml::RenderObject::hasAutoScrollbars): (khtml::RenderObject::scrollsOverflow): (khtml::RenderObject::includeScrollbarSize): (khtml::RenderObject::setHasOverflowClip):
khtml/rendering/render_style.h: (khtml::RenderStyle::overflow): (khtml::RenderStyle::isDisplayReplacedType): (khtml::RenderStyle::isDisplayInlineType):
khtml/rendering/render_table.cpp: (RenderTable::setStyle): (RenderTableCell::setStyle): (RenderTableCell::requiresLayer):
khtml/rendering/render_table.h:

10:57 AM Changeset in webkit [6356] by cblu

2 edits in trunk/WebKit

Fixed deployment build failure.

Reviewed by john.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _handleMouseDragged:]): removed use of fileWrapper variable

Apr 12, 2004:

3:19 PM Changeset in webkit [6355] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by John.

fix deployment build by avoiding deployment-only warning.

kjs/scope_chain.cpp: (KJS::ScopeChain::bottom):

2:13 PM Changeset in webkit [6354] by hyatt

4 edits in trunk/WebCore

Fix for 3556036, make sure that when the position changes via style that all render layer
descendants simply immediately repaint.

Reviewed by kocienda

khtml/rendering/render_layer.cpp: (RenderLayer::repaintIncludingDescendants):
khtml/rendering/render_layer.h:
khtml/rendering/render_object.cpp: (RenderObject::setStyle):

1:46 PM Changeset in webkit [6353] by cblu

16 edits in trunk

WebCore:

Fixed build failure by removing references to WebArchive in WebCore.
For HTML copy/paste, relative URLs are now made absolute at paste time instead of at copy time. This allows relative URLs to be kept relative if the destination page has the same base URL as the source page.

Reviewed by kocienda.

khtml/editing/htmlediting.cpp: (PasteMarkupCommand::PasteMarkupCommand): take the base URL of the clipping
khtml/editing/htmlediting.h:
khtml/editing/htmlediting_impl.cpp: (PasteMarkupCommandImpl::PasteMarkupCommandImpl): take the base URL of the clipping (PasteMarkupCommandImpl::doApply): if we have a base URL and it is different than the base URL of the document, fix the URLs in the new DOM tree
khtml/editing/htmlediting_impl.h:
khtml/xml/dom2_rangeimpl.cpp: (RangeImpl::toHTMLWithOptions): removed completeURLs param
khtml/xml/dom2_rangeimpl.h:
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::recursive_toHTMLWithOptions): removed completeURLs param (NodeImpl::recursive_toHTML): ditto (NodeImpl::recursive_completeURLs): new
khtml/xml/dom_nodeimpl.h:
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge markupStringFromNode:subresourceURLStrings:]): call recursive_toHTML with less params (-[WebCoreBridge markupStringFromRange:subresourceURLStrings:]): ditto (-[WebCoreBridge replaceSelectionWithMarkupString:baseURLString:]): take a base URL

WebKit:

Factored out WebArchive to DOM code so that it could be used by both [WebHTMLView _pasteFromPasteboard:] and [WebView insertWebArchive:replacingDOMRange:].

Reviewed by kocienda.

WebView.subproj/WebDataSource.m: (-[WebDataSource _replaceSelectionWithMarkupString:baseURL:]): moved from WebHTMLView (-[WebDataSource _replaceSelectionWithImageResource:]): ditto (-[WebDataSource _replaceSelectionWithWebArchive:]): ditto
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _replaceSelectionWithMarkupString:]): renamed (-[WebHTMLView _pasteFromPasteboard:]): call renamed methods
WebView.subproj/WebView.m: (-[WebView insertMarkupString:replacingDOMRange:]): call renamed methods (-[WebView insertWebArchive:replacingDOMRange:]): have data source handle the archive instead of the bridge

11:41 AM Changeset in webkit [6352] by kocienda

12 edits
7 adds in trunk

WebCore:

Reviewed by Dave

Added execCommand support for cut/copy/paste.

khtml/xml/dom_docimpl.cpp: (DocumentImpl::execCommand): Added cut/copy/paste atoms and added else if cases for the commands.
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::issueCutCommand): Glue for calling from WebCore to do a cut in Cocoa. (KWQKHTMLPart::issueCopyCommand): Same as above, but for copy. (KWQKHTMLPart::issuePasteCommand): Same as above, but for paste.
kwq/WebCoreBridge.h: Declared issueCutCommand, issueCopyCommand, and issuePasteCommand to be implemented on the WebKit side of the bridge.
layout-tests/editing/editing.js: Added cut/copy/paste support to js library to support making layout tests.
layout-tests/editing/pasteboard/copy-paste-text-001-expected.txt: Added.
layout-tests/editing/pasteboard/copy-paste-text-001.html: Added.
layout-tests/editing/pasteboard/cut-paste-text-002-expected.txt: Added.
layout-tests/editing/pasteboard/cut-paste-text-002.html: Added.
layout-tests/editing/pasteboard/cut-text-001-expected.txt: Added.
layout-tests/editing/pasteboard/cut-text-001.html: Added.

WebKit:

Reviewed by Dave

Added execCommand support for cut/copy/paste.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge issueCutCommand]): Glue for calling from WebCore to do a cut in Cocoa. (-[WebBridge issueCopyCommand]): Same as above, but for copy. (-[WebBridge issuePasteCommand]): Same as above, but for paste.
WebView.subproj/WebHTMLView.m: (-[WebHTMLView copy:]): Move this to private implementation category so the bridge can see it. (-[WebHTMLView cut:]): Ditto. (-[WebHTMLView paste:]): Ditto.
WebView.subproj/WebHTMLViewPrivate.h: Move copy;, cut:, and paste: to private implementation category so the bridge can see it.
WebView.subproj/WebView.m: (-[WebView copy:]): Implemented by calling WebHTMLView to do the work. (-[WebView cut:]): Ditto. (-[WebView paste:]): Ditto.
WebView.subproj/WebViewPrivate.h: Added all the NSReponder methods we plan to implement as part of the WebKit editing API.

10:16 AM Changeset in webkit [6351] by kocienda

5 edits in trunk

Reviewed by John

Some delete and insert cleanups.

khtml/editing/htmlediting_impl.cpp: (DeleteSelectionCommandImpl::doApply): For ending position case 1, the caret should be placed before the first child of the containing block, not before the containing block itself. Also, add some code to handle converting nbsp's back to regular spaces. This will need to be improved some day to convert only nbsp's added by the editor to make rendering come out right. (InputTextCommandImpl::execute): (TypingCommandImpl::issueCommandForDeleteKey): Make deleting collapsible whitespace part of the work of deleting a selection, rather than something that needs to be done by a user of DeleteSelectionCommandImpl. This makes it impossible to leave out this essential step. (TypingCommandImpl::deleteKeyPressed): We can't use a possible optimization here until the code to do deletions properly has been factored better. Big FIXME added.
layout-tests/editing/deleting/delete-block-contents-001-expected.txt: Updated for ending position case 1 behavior change.
layout-tests/editing/deleting/delete-block-contents-002-expected.txt: Ditto.
layout-tests/editing/deleting/delete-block-contents-003-expected.txt: Ditto.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed