Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Apr 20, 2004:

4:36 PM Changeset in webkit [6434] by hyatt

• 3 edits in trunk/LayoutTests/fast

Fix frames layout tests now that regression has been fixed.

3:59 PM Changeset in webkit [6433] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3605209>: "HITLIST: REGRESSION (131-132): iframes/frames no longer dump on layout tests"

Reviewed by hyatt.

• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): the encoding was not being set in the about:blank case. Call receivedData:textEncodingName: as we did in the past to set it.

3:17 PM Changeset in webkit [6432] by kocienda

• 45 edits
  1 add
  2 deletes in trunk/WebCore

Reviewed by Hyatt

Renamed DOMPosition class to Position.
Renamed KHTMLSelection to Selection and moved to DOM namespace.

• ForwardingHeaders/xml/dom_selection.h: Added.
• WebCore.pbproj/project.pbxproj: Go Xcode!
• khtml/khtml_selection.cpp: Removed.
• khtml/khtml_selection.h: Removed.
• khtml/xml/dom_position.cpp: Renamed DOMPosition to Position
• khtml/xml/dom_position.h: Ditto.
• khtml/xml/dom_selection.cpp: New home for renamed Selection object.
• khtml/xml/dom_selection.h: Ditto.

2:20 PM Changeset in webkit [6431] by kocienda

• 22 edits
  2 adds in trunk

WebCore:

Reviewed by Hyatt

• WebCore.pbproj/project.pbxproj:
• khtml/khtml_part.cpp: (KHTMLPart::handleMousePressEventDoubleClick): Improved name of expandToElement. Now is expandUsingGranularity. (KHTMLPart::handleMousePressEventTripleClick): Ditto. (KHTMLPart::handleMouseMoveEventSelection): Ditto.
• khtml/khtml_selection.cpp: (KHTMLSelection::modify): Added support for modifying and extending selection right and left by word. Also added support for extending selection up and down. (KHTMLSelection::expandUsingGranularity): New name for expandToElement. (KHTMLSelection::xPosForVerticalArrowNavigation): Made this function handle cases where we know we want to use a particular position for calculating the right x position. We need this to handle extending selection up and down, and for setting the caret to the right place when moving up and down when a range is already selected. (KHTMLSelection::validate): Name tweak. expandTo variable now granularity.
• khtml/khtml_selection.h: Make declaration changes for changes to cpp file.
• khtml/misc/helper.cpp: (khtml::findWordBoundary): Added this hook for KDE to do their version of KWQFindWordBoundary
• khtml/misc/helper.h:
• khtml/rendering/render_block.cpp: (khtml::RenderBlock::positionForCoordinates): Factor out closest box finder code to its own function
• khtml/rendering/render_line.cpp: (InlineFlowBox::closestChildForXPos): New function. This is the factored code that was taken out of render_block.cpp. (InlineBox::closestLeafChildForXPos): Ditto.
• khtml/rendering/render_line.h: Ditto.
• khtml/rendering/render_replaced.cpp: (RenderReplaced::positionForCoordinates): I think I am starting to get how the coordinate transforms work. Made some fixups based on this greater sense of enlightenment.
• khtml/rendering/render_text.cpp: (RenderText::positionForCoordinates): Ditto. Fix lastTextBox/firstTextBox code mistake.
• khtml/xml/dom_position.cpp: (DOMPosition::previousWordPosition): Added. (DOMPosition::nextWordPosition): Added. (DOMPosition::previousLinePosition): No longer use nodeAtPoint. Use new closestLeafChildForXPos instead. (DOMPosition::nextLinePosition): Ditto. (DOMPosition::inLastEditableInContainingEditableBlock):
• khtml/xml/dom_position.h:
• kwq/KWQTextUtilities.cpp: Added. (KWQFindWordBoundary): Factored out code that was in a static function in khtml_selection.cpp so that DOMPosition can use it too.
• kwq/KWQTextUtilities.h: Added.

WebKit:

Reviewed by Hyatt

Added implementations for these methods.

• WebView.subproj/WebView.m: (-[WebView moveUpAndModifySelection:]): (-[WebView moveWordLeft:]): (-[WebView moveWordLeftAndModifySelection:]): (-[WebView moveWordRight:]): (-[WebView moveWordRightAndModifySelection:]):

1:36 PM Changeset in webkit [6430]

• 51 copies
  2 deletes in tags/WebCore-125~6~3

This commit was manufactured by cvs2svn to create tag
'WebCore-125~6~3'.

1:36 PM Changeset in webkit [6429] by vicki

• 2 edits in branches/Safari-1-2-branch/WebCore

WebCore versioning, WebCore-125.6.3

1:05 PM Changeset in webkit [6428] by vicki

• 4 edits in branches/Safari-1-2-branch/WebCore

• fixed <rdar://problem/3626076>: (REGRESSION (10.3.3-7H40): some tables rendering incorrectly) by merging more of the zeldman change (3609695) and fixing HRs

• khtml/css/html4.css: margins on HRs should be smaller, to match other browsers
• khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlockChildren):
• khtml/rendering/render_table.cpp: (RenderTableCell::paint):

11:28 AM Changeset in webkit [6427] by sullivan

• 3 edits in trunk/WebKit

WebKit:

• fixed <rdar://problem/3622393>: When in stealth mode, visited webpage contents should not be cached to disk

Reviewed by Ken.

• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate willCacheResponse:]): if will cache to disk and in stealth mode, replace cache response with an identical one that won't cache to disk.

WebBrowser:

• fixed the following bugs: <rdar://problem/3529727>: click and hold on an auto-tab folder in the bookmarks bar should show the items in a menu <rdar://problem/3546013>: bookmark button is left in the wrong state when closing a tab with bookmarks in it <rdar://problem/3612787>: When printed page has no HTML title, put URL in header instead of footer <rdar://problem/3628119>: Would like "Reveal in Collections" context menu item in bookmarks filter search results <rdar://problem/3628143>: Would like "Reveal in Collections" context menu item in Bookmarks bar

Reviewed by Chris.

• BookmarksViewController.m: (-[BookmarksViewController revealBookmark:expand:]): generalized this to work with content items that aren't bookmarks (e.g. history items) (-[BookmarksViewController outlineView:menuForEvent:inRow:tableColumn:]): add a "Reveal in Collections" item just before Delete (-[BookmarksViewController revealSelectedFilterSearchItem]): new method, sets the collection appropriately and then reveals the item

• BrowserWebBookmarkExtras.m: (-[WebBookmark revealFavorite]): new method, calls through to BrowserWindowController

• BrowserWebViewPrinting.m: (-[BrowserWebView webView:drawFooterInRect:]): don't draw URL in footer if it's already being drawn in the header

• BrowserWindowController.h:
• BrowserWindowController.m: (-[BrowserWindowController revealFavorite:]): new method, calls through to BookmarksViewController (-[BrowserWindowController closeTab:]): update the show/hide bookmarks button here also (we were already updating it when showing a tab)

• English.lproj/Localizable.strings: updated for these changes

• FavoriteButton.m: (-[FavoriteButton menu]): add "Reveal in Collections" item (-[FavoriteButton shouldShowContentsMenuFromEvent:waitedForDragDelay:]): added waitedForDragDelay parameter, use it to decide whether to show the menu even for the auto-tab case (-[FavoriteButton performClick:]): pass NO for waitedForDragDelay (-[FavoriteButton mouseDown:]): pass appropriate value for waitedForDragDelay

Apr 19, 2004:

3:54 PM Changeset in webkit [6426] by kocienda

• 23 edits in trunk

WebCore:

Reviewed by Hyatt

• khtml/khtml_part.cpp: (KHTMLPart::notifySelectionChanged): Clear the value used for maintaining x position when doing vertical arrow navigation. WebCoreBridge restores this value when needed. (KHTMLPart::setXPosForVerticalArrowNavigation): New accessor. (KHTMLPart::xPosForVerticalArrowNavigation): New accessor.
• khtml/khtml_part.h: (KHTMLPart::): Add NoXPosForVerticalArrowNavigation constant.
• khtml/khtml_selection.cpp: (KHTMLSelection::modify): Add cases for UP and DOWN navigation (KHTMLSelection::xPosForVerticalArrowNavigation): New helper.
• khtml/khtml_selection.h: Add UP and DOWN constants to EDirection enum. (KHTMLSelection::):
• khtml/khtmlpart_p.h: Declare storage for m_xPosForVerticalArrowNavigation, the value used for maintaining x position when doing vertical arrow navigation.
• khtml/rendering/render_block.cpp: (khtml::RenderBlock::positionForCoordinates): Improved this function to handle deficiencies exposed when trying to implement new behavior.
• khtml/rendering/render_br.cpp: (RenderBR::positionForCoordinates): Added implementation of this virtual function.
• khtml/rendering/render_br.h: Declare implementation for positionForCoordinates virtual function.
• khtml/rendering/render_replaced.cpp: (RenderReplaced::positionForCoordinates): Improved this function to handle deficiencies exposed when trying to implement new behavior.
• khtml/rendering/render_text.cpp: (InlineTextBox::offsetForPosition): Remove left/right "bounds" check here. (RenderText::positionForCoordinates): Improved this function to handle deficiencies exposed when trying to implement new behavior.
• khtml/xml/dom_position.cpp: (inlineBoxForRenderer): Moved to top of file so all code in the file can see this static function. (renderersOnDifferentLine): Ditto. (nextRenderedEditable): Ditto. (previousRenderedEditable): Ditto. (DOMPosition::previousLinePosition): New function. Implements the guts of up/down navigation. (DOMPosition::nextLinePosition): Ditto.
• khtml/xml/dom_position.h: Added declarations for nextLinePosition and previousLinePosition.
• kwq/WebCoreBridge.h: Add WebSelectUp and WebSelectDown constants.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge alterCurrentSelection:direction:granularity:]): Handles saving and restoring the x position used for doing vertical arrow navigation.

WebKit:

Reviewed by Hyatt

• WebView.subproj/WebView.m: (-[WebView moveDown:]): Added implementation. (-[WebView moveUp:]): Added implementation.

2:26 PM Changeset in webkit [6425] by mjs

• 3 edits in trunk/JavaScriptCore

Reviewed by Dave.

Optimize prepend using the shared substring optimization. Also,
limit the applicability of shared append and shared prepend. If
you overdo it, it does more harm than good, because you create a
bunch of strings that are disqualified from future shared
append/prepend, for not much immediate savings in allocate/copy
expense.

• kjs/ustring.cpp: (KJS::): (KJS::UString::Rep::create): (KJS::UString::expandedSize): (KJS::UString::usedPreCapacity): (KJS::UString::expandCapacity): (KJS::UString::expandPreCapacity): (KJS::UString::UString): (KJS::UString::append): (KJS::UString::operator=):
• kjs/ustring.h: (KJS::UString::Rep::data):

9:55 AM Changeset in webkit [6424] by cblu

• 5 edits in trunk/WebKit

Added support for pasting frames via WebArchives.

Reviewed by kocienda.

• WebView.subproj/WebDataSource.m: (-[WebDataSource _addSubframeArchives:]): renamed, now allows subframe archives to be added at anytime (-[WebDataSource _popSubframeArchiveWithName:]): renamed, now deletes the returned subframe to consume less memory (-[WebDataSource _replaceSelectionWithWebArchive:]): added support for subframes
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebFrame.m: (-[WebFrame _loadRequest:subresources:subframeArchives:]): call renamed methods (-[WebFrame _loadURL:intoChild:]): ditto
• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation loadArchive]): ditto

Apr 18, 2004:

5:17 PM Changeset in webkit [6423] by mjs

• 3 edits in trunk/JavaScriptCore

Reviewed by Richard.

No more need for Completion or Reference to privately inherit from
Value, none of the superclass functionality is used.

• kjs/completion.h:
• kjs/reference.h:

Apr 16, 2004:

8:30 PM Changeset in webkit [6422]

• 11 copies
  3 deletes in tags/WebKit-125~2

This commit was manufactured by cvs2svn to create tag 'WebKit-125~2'.

8:30 PM Changeset in webkit [6421] by vicki

• 2 edits
  1 add in branches/Safari-1-2-branch/WebKit

• buildit complained about missing CFBundleName. Add InfoPlist.strings back to the build, with only a CFBundleName (no version or copyright string)

• English.lproj/InfoPlist.strings: Added.
• WebKit.pbproj/project.pbxproj:

8:20 PM Changeset in webkit [6420]

• 50 copies
  2 deletes in tags/WebCore-125~6~2

This commit was manufactured by cvs2svn to create tag
'WebCore-125~6~2'.

8:20 PM Changeset in webkit [6419] by vicki

• 2 edits
  2 adds in branches/Safari-1-2-branch/WebCore

• buildit complained about missing CFBundleName. Add InfoPlist.strings back to the build, with only a CFBundleName (no version or copyright string)

• English.lproj/InfoPlist.strings: Added.
• WebCore.pbproj/project.pbxproj:

5:06 PM Changeset in webkit [6418] by kocienda

• 2 edits in trunk/WebCore

Reviewed by Hyatt

• khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Added implementations for these four properties: CSS_PROP_WHITE_SPACE, CSS_PROP_DISPLAY, CSS_PROP_FLOAT, and CSS_PROP_COLOR.

5:03 PM Changeset in webkit [6417] by vicki

• 2 edits in branches/Safari-1-2-branch/WebCore

• roll out the change to WebCoreViewFactory.h. This isn't a part of the onscroll follow-up for 3612968

• kwq/WebCoreViewFactory.h:

4:59 PM Changeset in webkit [6416] by cblu

• 3 edits in trunk/WebCore

Subresources weren't being archived for LINK tags.

Reviewed by kocienda.

• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::recursive_toHTMLWithOptions): indent tweak
• kwq/DOMHTML.mm: (-[DOMHTMLLinkElement _linkElementImpl]): C++ casting voodoo to make methods like rel and href work correctly

4:29 PM Changeset in webkit [6415] by kocienda

• 2 edits in trunk/WebCore

Reviewed by Hyatt

• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::isContentEditable): Call getDocument()->updateRendering() to make sure outstanding changes for this attribute are applied. (HTMLElementImpl::contentEditable): Call getDocument()->updateRendering() to make sure outstanding changes for this attribute are applied. (HTMLElementImpl::setContentEditable): Call enabled.isEmpty() before strcasecmp(enabled, "true"). It's cheaper.

4:18 PM Changeset in webkit [6414] by kocienda

• 3 edits
  4 adds in trunk

Reviewed by Hyatt

• khtml/editing/htmlediting_impl.cpp: New helper. (DeleteSelectionCommandImpl::containsOnlyWhitespace): Fix deleting collapsed whitespace at the end of a line where text has flowed to the next line and the caret is at the beginning of the next line. (DeleteSelectionCommandImpl::doApply): Updated for new helper.
• khtml/editing/htmlediting_impl.h:
• layout-tests/editing/deleting/delete-line-end-ws-001-expected.txt: Added.
• layout-tests/editing/deleting/delete-line-end-ws-001.html: Added.
• layout-tests/editing/deleting/delete-line-end-ws-002-expected.txt: Added.
• layout-tests/editing/deleting/delete-line-end-ws-002.html: Added.

4:03 PM Changeset in webkit [6413] by vicki

• 3 edits in trunk

set version to '138u'. the tree is open!

3:59 PM Changeset in webkit [6412]

• 3 copies in tags/Safari-137

This commit was manufactured by cvs2svn to create tag 'Safari-137'.

3:59 PM Changeset in webkit [6411] by vicki

• 6 edits in trunk

Safari-137 stamp

3:25 PM Changeset in webkit [6410] by kocienda

• 1 edit in trunk/WebCore/khtml/html/html_elementimpl.cpp

Ahh! I checked in changes in my tree when I rolled out. Rolling those changes out.

3:24 PM Changeset in webkit [6409] by kocienda

• 4 edits
  4 deletes in trunk

Rolling out last change. Tree was closed.

3:13 PM Changeset in webkit [6408] by kocienda

• 3 edits
  4 adds in trunk

Reviewed by Hyatt

• khtml/editing/htmlediting_impl.cpp: (DeleteSelectionCommandImpl::containsOnlyWhitespace): New helper. (DeleteSelectionCommandImpl::doApply): Fix deleting collapsed whitespace at the end of a line where text has flowed to the next line and the caret is at the beginning of the next line.
• khtml/editing/htmlediting_impl.h: Updated for new helper.
• layout-tests/editing/deleting/delete-line-end-ws-001-expected.txt: Added.
• layout-tests/editing/deleting/delete-line-end-ws-001.html: Added.
• layout-tests/editing/deleting/delete-line-end-ws-002-expected.txt: Added.
• layout-tests/editing/deleting/delete-line-end-ws-002.html: Added.

2:41 PM Changeset in webkit [6407] by vicki

• 2 edits
  1 delete in branches/Safari-1-2-branch/WebKit

Reviewed by kocienda.

Make this change on the branch for SUPanLavender, at Amy Rapport's request

2004-03-03 Darin Adler <Darin Adler>

Reviewed by Vicki.

• English.lproj/InfoPlist.strings: Removed. No need to localize the version and copyright string, and that's all that was in here.
• WebKit.pbproj/project.pbxproj: Removed InfoPlist.strings from build.

2:38 PM Changeset in webkit [6406]

• 49 copies
  3 deletes in tags/WebCore-125~6~1

This commit was manufactured by cvs2svn to create tag
'WebCore-125~6~1'.

2:38 PM Changeset in webkit [6405] by vicki

• 2 edits
  1 delete in branches/Safari-1-2-branch/WebCore

Reviewed by kocienda.

Make this change on the branch for SUPanLavender, at Amy Rapport's request

2004-03-03 Darin Adler <Darin Adler>

Reviewed by Vicki.

• English.lproj/InfoPlist.strings: Removed. No need to localize the version and copyright string, and that's all that was in here.
• WebCore.pbproj/project.pbxproj: Removed InfoPlist.strings from build.

2:35 PM Changeset in webkit [6404]

• 6 copies
  4 deletes in tags/JavaScriptCore-125~4~2

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-125~4~2'.

2:35 PM Changeset in webkit [6403] by vicki

• 2 edits
  1 delete in branches/Safari-1-2-branch/JavaScriptCore

Reviewed by kocienda.

Make this change on the branch for SUPanLavender, per Amy Rapport's request.

2004-03-03 Darin Adler <Darin Adler>

Reviewed by Vicki.

• English.lproj/InfoPlist.strings: Removed. No need to localize the version and copyright string, and that's all that was in here.
• JavaScriptCore.pbproj/project.pbxproj: Removed InfoPlist.strings from build.

2:09 PM Changeset in webkit [6402] by rjw

• 10 edits in trunk

WebKit:

Added an SPI to allow ObjC instances to be easily bound to
JS. This is needed by the dashboard guys for their prototyping.
Eventually they will use new API.

Reviewed by Chris.

• WebView.subproj/WebView.m: (-[WebView _bindObject:withName:toFrame:]):
• WebView.subproj/WebViewPrivate.h:

WebCore:

Added an SPI to allow ObjC instances to be easily bound to
JS. This is needed by the dashboard guys for their prototyping.
Eventually they will use new API.

Reviewed by Chris.

• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::bindObject):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge bindObject:withName:]):

JavaScriptCore:

Added interpreter lock protection around object creation.

Reviewed by Chris.

• bindings/runtime.cpp: (Instance::createRuntimeObject):

1:54 PM Changeset in webkit [6401] by vicki

• 1 edit in branches/Safari-1-2-branch/WebCore/ChangeLog-2005-08-23

• Move the release marker for WebCore-125.6. (I moved the tags so that my last commit is now a part of WebCore-125.6, since this version number is getting kind of high)

12:51 PM Changeset in webkit [6400] by cblu

• 47 edits
  1 add in trunk

WebCore:

Added DOMHTMLEmbedElement as a DOM extension since EMBED is represented in our DOM even though its not part of the spec.
Added all DOMCore and DOMHTML symbols to WebCore's symbols file.
Removed isSubresourceURLAttribute from dom node. This was only used for the WebArchive feature and all that work is now done in WebKit.

Reviewed by kocienda.

• WebCore-combined.exp:
• WebCore.exp:
• khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::isURLAttribute): renamed from isSubresourceURLAttribute. As a convenience to subclasses, dom_elementimpl would call isSubresourceURLAttribute in isURLAttribute, but this is no longer done (HTMLFrameElementImpl::isURLAttribute): ditto (HTMLIFrameElementImpl::isURLAttribute): ditto
• khtml/html/html_baseimpl.h:
• khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::isURLAttribute): ditto
• khtml/html/html_formimpl.h:
• khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::isURLAttribute): ditto
• khtml/html/html_headimpl.h:
• khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::isURLAttribute): ditto
• khtml/html/html_imageimpl.h:
• khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::isURLAttribute): ditto (HTMLObjectElementImpl::isURLAttribute): ditto (HTMLParamElementImpl::isURLAttribute): ditto
• khtml/html/html_objectimpl.h:
• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::isURLAttribute): ditto (HTMLTableCellElementImpl::isURLAttribute): ditto
• khtml/html/html_tableimpl.h:
• khtml/xml/dom2_rangeimpl.cpp: (RangeImpl::toHTMLWithOptions): take a node list (see below)
• khtml/xml/dom2_rangeimpl.h:
• khtml/xml/dom_elementimpl.cpp: (ElementImpl::isURLAttribute):
• khtml/xml/dom_elementimpl.h:
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::recursive_toHTMLWithOptions): append copied nodes to a list of nodes so that WebKit can operate on them
• khtml/xml/dom_nodeimpl.h:
• kwq/DOM.mm: (+[DOMNode _nodeWithImpl:]): added support for HTML types
• kwq/DOMExtensions.h:
• kwq/DOMHTML.mm: (-[DOMHTMLPreElement setWidth:]): (-[DOMHTMLEmbedElement _embedElementImpl]): (-[DOMHTMLEmbedElement align]): (-[DOMHTMLEmbedElement setAlign:]): (-[DOMHTMLEmbedElement height]): (-[DOMHTMLEmbedElement setHeight:]): (-[DOMHTMLEmbedElement name]): (-[DOMHTMLEmbedElement setName:]): (-[DOMHTMLEmbedElement src]): (-[DOMHTMLEmbedElement setSrc:]): (-[DOMHTMLEmbedElement type]): (-[DOMHTMLEmbedElement setType:]): (-[DOMHTMLEmbedElement width]): (-[DOMHTMLEmbedElement setWidth:]): (-[DOMHTMLTableElement background]): (-[DOMHTMLTableElement setBackground:]): (-[DOMHTMLTableCellElement background]): new extension (-[DOMHTMLTableCellElement setBackground:]): ditto
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge nodesFromList:]): new (-[WebCoreBridge markupStringFromNode:nodes:]): return a list of nodes instead of subresource URLs so WebKit can operate on the nodes (-[WebCoreBridge markupStringFromRange:nodes:]): ditto

WebKit:

Fixed: <rdar://problem/3587599>: Mail Page, Web Archives don't preserve subframes
Moved code that assembled subresource URLs from DOM nodes from WebCore to WebKit.

Reviewed by rjw.

• DOM.subproj/DOMExtensions.h: copied from WebCore
• DOM.subproj/WebDOMOperations.h:
• DOM.subproj/WebDOMOperations.m: (-[DOMNode webArchive]): call renamed methods (-[DOMNode markupString]): ditto (-[DOMNode _URLsFromSelectors:]): new, returns array of URLs given selectors (-[DOMNode _subresourceURLs]): new, base class does nothing, subclasses call _URLsFromSelectors with URL selectors (-[DOMDocument webFrame]): new (-[DOMRange webArchive]): call renamed methods (-[DOMRange markupString]): ditto (-[DOMHTMLBodyElement _subresourceURLs]): new (-[DOMHTMLInputElement _subresourceURLs]): new (-[DOMHTMLLinkElement _subresourceURLs]): new (-[DOMHTMLScriptElement _subresourceURLs]): new (-[DOMHTMLImageElement _subresourceURLs]): new (-[DOMHTMLEmbedElement _subresourceURLs]): new (-[DOMHTMLObjectElement _subresourceURLs]): new (-[DOMHTMLParamElement _subresourceURLs]): new (-[DOMHTMLTableElement _subresourceURLs]): new (-[DOMHTMLTableCellElement _subresourceURLs]): new
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebArchive.h:
• WebView.subproj/WebArchive.m: (-[WebArchivePrivate dealloc]): release new subframeArchives ivar (-[WebArchive initWithMainResource:subresources:subframeArchives:]): take subframeArchives (-[WebArchive _initWithPropertyList:]): new, recursively creates WebArchives (-[WebArchive initWithData:]): call _initWithPropertyList (-[WebArchive subframeArchives]): new (-[WebArchive _propertyListRepresentation]): new, recursively creates property lists of WebArchives (-[WebArchive data]): call _propertyListRepresentation
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate saveResource]): call renamed methods
• WebView.subproj/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): release new pendingSubframeArchives ivar (-[WebDataSource _archiveWithMarkupString:nodes:]): renamed and reimplemented, handles subframes (-[WebDataSource _archive]): new (-[WebDataSource _setPendingSubframeArchives:]): new (-[WebDataSource _archiveForFrameName:]): new
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebFrame.m: (-[WebFrame loadArchive:]): handle subframes (-[WebFrame _loadRequest:subresources:subframeArchives:]): ditto (-[WebFrame _loadURL:intoChild:]): use the subframe archive if we have it (-[WebFrame loadRequest:]): call renamed methods
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation loadWebArchive]): call renamed methods and handle subframes
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _selectedArchive:]): call renamed methods (-[WebHTMLView _pasteFromPasteboard:]): call renamed methods
• WebView.subproj/WebHTMLViewPrivate.h:
• WebView.subproj/WebImageRepresentation.h:
• WebView.subproj/WebImageRepresentation.m: instead of storing some items from the data source, just store the data source (-[WebImageRepresentation dealloc]): removed use of deleted ivars (-[WebImageRepresentation URL]): use dataSource instead of ivar (-[WebImageRepresentation doneLoading]): use new boolean ivar (-[WebImageRepresentation setDataSource:]): store the data source (-[WebImageRepresentation receivedData:withDataSource:]): use dataSource instead of ivar (-[WebImageRepresentation receivedError:withDataSource:]): ditto (-[WebImageRepresentation finishedLoadingWithDataSource:]): ditto (-[WebImageRepresentation title]): ditto (-[WebImageRepresentation data]): ditto (-[WebImageRepresentation filename]): ditto (-[WebImageRepresentation archive]): ditto
• WebView.subproj/WebResource.h:
• WebView.subproj/WebResource.m: (-[WebResourcePrivate dealloc]): release new frame name ivar (-[WebResource initWithData:URL:MIMEType:textEncodingName:frameName:]): take a frame name (-[WebResource frameName]): new (-[WebResource _initWithPropertyList:]): handle frame name (-[WebResource _initWithCachedResponse:originalURL:]): call renamed methods (-[WebResource _propertyListRepresentation]):
• WebView.subproj/WebResourcePrivate.h: handle frame name

WebBrowser:

Reviewed by rjw.

• BrowserDocument.m: (-[BrowserDocument mailPageAddress:]): call renamed methods

12:35 PM Changeset in webkit [6399] by vicki

• 1 edit in branches/Safari-1-2-branch/WebKit/WebKit.pbproj/project.pbxproj

• correct version number (WebKit-125.2)

12:34 PM Changeset in webkit [6398]

• 50 copies
  2 deletes in tags/WebCore-125~6

This commit was manufactured by cvs2svn to create tag
'WebCore-125~6'.

12:34 PM Changeset in webkit [6397] by vicki

• 10 edits in branches/Safari-1-2-branch

WebCore:

• follow-up fix for 3612968 (clone of 3487207). Implement onscroll at the document level.

2004-03-25 David Hyatt <​hyatt@apple.com>

Implement the rest of the search field. Make it work with form
submission. Implement onscroll at the document level.

Reviewed by darin

• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendScrollEvent):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge sendScrollEvent]):
• kwq/WebCoreViewFactory.h:

WebKit:

• follow-up fix for 3612968 (clone of 3487207). Implement onscroll at the document level.

2004-03-25 David Hyatt <​hyatt@apple.com>

Implement the rest of the search field.

Implement onscroll at the document level.

Reviewed by darin

• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _frameOrBoundsChanged]): (-[WebHTMLView viewDidMoveToWindow]):
• WebView.subproj/WebHTMLViewPrivate.h:

11:54 AM Changeset in webkit [6396] by mjs

• 3 edits in trunk/JavaScriptCore

Reviewed by Ken.

Another JavaScript speed improvement: use the mechanism from
string append optimization to make taking a substring fast, again
sharing the buffer.

A further 22% improvement on the 24fun string speed test.

• kjs/ustring.cpp: (KJS::): (KJS::UString::Rep::create): (KJS::UString::UString): (KJS::UString::append): (KJS::UString::operator=): (KJS::UString::substr):
• kjs/ustring.h: (KJS::UString::Rep::data):