Timeline



Apr 21, 2004:

9:41 PM Changeset in webkit [6448] by hyatt
  • 1 edit in trunk/LayoutTests/fast/table/rowspan-paint-order-expected.txt

Fix multiple rowspan test.

9:39 PM Changeset in webkit [6447] by hyatt
  • 2 adds in trunk/LayoutTests/fast/table

Add layout test with multiple rows expanding in percentage heights.

9:37 PM Changeset in webkit [6446] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3245627, nested tables don't expand vertically. I actually fixed the basic problem in the
previous checkin, but this exposed another basic math error where |numVariable| was not being
decremented properly. This meant space was mis-allocated when multiple variable height rows both needed
to expand.

  • khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows):
7:26 PM Changeset in webkit [6445] by hyatt
  • 2 adds in trunk/LayoutTests/fast/table

Add layout test for weird rowspan case.

7:24 PM Changeset in webkit [6444] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3020449, ensure that the paint order of cells with rowspans matches other browsers.

Reviewed by darin

  • khtml/rendering/render_table.cpp: (RenderTableSection::paint):
2:49 PM Changeset in webkit [6443] by hyatt
  • 2 adds in trunk/LayoutTests/fast/table

Add test case for nested percent height tables.

2:48 PM Changeset in webkit [6442] by hyatt
  • 2 edits in trunk/WebCore

Remove the (incorrect) restriction on table flexing that required the cell to have a fixed width. In
reality, the style on the cell is completely irrelevant.

Reviewed by kocienda

  • khtml/rendering/render_table.cpp: (RenderTable::layout):
2:25 PM Changeset in webkit [6441] by hyatt
  • 2 adds in trunk/LayoutTests/fast/table

Add layout test to cover percentage height cells case.

2:24 PM Changeset in webkit [6440] by hyatt
  • 2 edits in trunk/WebCore

Make sure cells that get flexed vertically in tables don't check text children when looking for
percentage height children.

Reviewed by kocienda

  • khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows):
1:56 PM Changeset in webkit [6439] by hyatt
  • 2 adds in trunk/LayoutTests/fast/block/positioning

Add test for the hiermenu image positioning bug.

1:49 PM Changeset in webkit [6438] by hyatt
  • 2 edits in trunk/WebCore

Fix for hiermenus bug. Absolutely positioned images should not contribute to their containing block's
max width. Make sure to disregard positioned elements when computing min/max width.

Reviewed by kocienda

  • khtml/rendering/render_block.cpp: (khtml::InlineMinMaxIterator::next):
1:43 PM Changeset in webkit [6437] by kocienda
  • 8 edits
    2 adds in trunk

Reviewed by Hyatt

A small collection of fixups.

  • khtml/editing/htmlediting_impl.cpp: (DeleteSelectionCommandImpl::doApply): Do not shift ending selection downstream when at position zero of a BR. That's just wrong. Simplify code that does "onlyWhitespace" delete. No need to handle multiple characters here; we can only ever have one thanks to the delete-collapsible-whitespace code. (TypingCommandImpl::issueCommandForDeleteKey): Don't do anything if at the start of a root editable block. This is a no-op....not an opportunity to crash.
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::positionForRenderer): Return this renderer's element position if the passed-in renderer is nil. This helps to make clicking in empty blocks work.
  • khtml/rendering/render_container.cpp: (RenderContainer::positionForCoordinates): Fixed typo in comment.
  • khtml/xml/dom_position.cpp: (DOM::Position::equivalentLeafPosition): Do not attempt to find a leaf if the position's node does not have a renderer, if the renderer has no kids.
  • layout-tests/editing/deleting/delete-br-001-expected.txt: Update expected results for BR fix.
  • layout-tests/editing/deleting/delete-br-003-expected.txt: Ditto.
  • layout-tests/editing/deleting/delete-br-006-expected.txt: Ditto.
  • layout-tests/editing/deleting/delete-br-007.html: Added. New BR test.
  • layout-tests/editing/deleting/delete-br-007-expected.txt: Added.
9:47 AM Changeset in webkit [6436] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by Hyatt

  • khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Added implementations for these properties: CSS_PROP_TEXT_DECORATION, CSS_PROP_VERTICAL_ALIGN, CSS_PROP_TEXT_INDENT, CSS_PROP_LETTER_SPACING, CSS_PROP_WORD_SPACING, CSS_PROP_LINE_HEIGHT
9:42 AM Changeset in webkit [6435] by kocienda
  • 17 edits in trunk/WebCore

Reviewed by John

The Selection class now uses the Position class throughout its public and
private interface. This replaces the inconsistent use of the Position
class here and node/offset pairs there. There are no functional changes, only
updates to the new Selection class API.

  • khtml/ecma/kjs_window.cpp: (Selection::get): (SelectionFunc::tryCall):
  • khtml/editing/htmlediting_impl.cpp: (DeleteCollapsibleWhitespaceCommandImpl::doApply): (DeleteSelectionCommandImpl::joinTextNodesWithSameStyle): (DeleteSelectionCommandImpl::doApply): (InputNewlineCommandImpl::doApply): (InputTextCommandImpl::deleteCharacter): (InputTextCommandImpl::prepareForTextInsertion): (InputTextCommandImpl::execute): (PasteMarkupCommandImpl::doApply): (TypingCommandImpl::issueCommandForDeleteKey):
  • khtml/khtml_part.cpp: (KHTMLPart::findTextNext): (KHTMLPart::setFocusNodeIfNeeded): (KHTMLPart::notifySelectionChanged): (KHTMLPart::isPointInsideSelection): (KHTMLPart::handleMouseMoveEventSelection): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::selectAll):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateSelection):
  • khtml/xml/dom_nodeimpl.cpp:
  • khtml/xml/dom_selection.cpp: (DOM::emptyPosition): (DOM::Selection::Selection): (DOM::Selection::init): (DOM::Selection::operator=): (DOM::Selection::moveTo): (DOM::Selection::modify): (DOM::Selection::xPosForVerticalArrowNavigation): (DOM::Selection::clear): (DOM::Selection::setBase): (DOM::Selection::setExtent): (DOM::Selection::setBaseAndExtent): (DOM::Selection::setStart): (DOM::Selection::setEnd): (DOM::Selection::setStartAndEnd): (DOM::Selection::toRange): (DOM::Selection::layoutCaret): (DOM::Selection::needsCaretRepaint): (DOM::Selection::paintCaret): (DOM::Selection::validate): (DOM::Selection::moveToRenderedContent): (DOM::Selection::nodeIsBeforeNode): (DOM::startAndEndLineNodesIncludingNode): (DOM::Selection::debugRenderer): (DOM::Selection::debugPosition):
  • khtml/xml/dom_selection.h: (DOM::Selection::~Selection): (DOM::Selection::base): (DOM::Selection::extent): (DOM::Selection::start): (DOM::Selection::end): (DOM::Selection::assignBase): (DOM::Selection::assignExtent): (DOM::Selection::assignBaseAndExtent): (DOM::Selection::assignStart): (DOM::Selection::assignEnd): (DOM::Selection::assignStartAndEnd): (DOM::operator==):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::jumpToSelection): (KWQKHTMLPart::selectionStartOffset): (KWQKHTMLPart::selectionEndOffset): (KWQKHTMLPart::selectionStart): (KWQKHTMLPart::selectionEnd):
  • kwq/KWQRenderTreeDebug.cpp: (writeSelection):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge isSelectionEditable]): (-[WebCoreBridge setSelectionFrom:startOffset:to:endOffset:]): (-[WebCoreBridge setSelectedDOMRange:]):

Apr 20, 2004:

4:36 PM Changeset in webkit [6434] by hyatt
  • 3 edits in trunk/LayoutTests/fast

Fix frames layout tests now that regression has been fixed.

3:59 PM Changeset in webkit [6433] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3605209>: "HITLIST: REGRESSION (131-132): iframes/frames no longer dump on layout tests"

Reviewed by hyatt.

  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): the encoding was not being set in the about:blank case. Call receivedData:textEncodingName: as we did in the past to set it.
3:17 PM Changeset in webkit [6432] by kocienda
  • 45 edits
    1 add
    2 deletes in trunk/WebCore

Reviewed by Hyatt

Renamed DOMPosition class to Position.
Renamed KHTMLSelection to Selection and moved to DOM namespace.

  • ForwardingHeaders/xml/dom_selection.h: Added.
  • WebCore.pbproj/project.pbxproj: Go Xcode!
  • khtml/khtml_selection.cpp: Removed.
  • khtml/khtml_selection.h: Removed.
  • khtml/xml/dom_position.cpp: Renamed DOMPosition to Position
  • khtml/xml/dom_position.h: Ditto.
  • khtml/xml/dom_selection.cpp: New home for renamed Selection object.
  • khtml/xml/dom_selection.h: Ditto.
2:20 PM Changeset in webkit [6431] by kocienda
  • 22 edits
    2 adds in trunk

WebCore:

Reviewed by Hyatt

  • WebCore.pbproj/project.pbxproj:
  • khtml/khtml_part.cpp: (KHTMLPart::handleMousePressEventDoubleClick): Improved name of expandToElement. Now is expandUsingGranularity. (KHTMLPart::handleMousePressEventTripleClick): Ditto. (KHTMLPart::handleMouseMoveEventSelection): Ditto.
  • khtml/khtml_selection.cpp: (KHTMLSelection::modify): Added support for modifying and extending selection right and left by word. Also added support for extending selection up and down. (KHTMLSelection::expandUsingGranularity): New name for expandToElement. (KHTMLSelection::xPosForVerticalArrowNavigation): Made this function handle cases where we know we want to use a particular position for calculating the right x position. We need this to handle extending selection up and down, and for setting the caret to the right place when moving up and down when a range is already selected. (KHTMLSelection::validate): Name tweak. expandTo variable now granularity.
  • khtml/khtml_selection.h: Make declaration changes for changes to cpp file.
  • khtml/misc/helper.cpp: (khtml::findWordBoundary): Added this hook for KDE to do their version of KWQFindWordBoundary
  • khtml/misc/helper.h:
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::positionForCoordinates): Factor out closest box finder code to its own function
  • khtml/rendering/render_line.cpp: (InlineFlowBox::closestChildForXPos): New function. This is the factored code that was taken out of render_block.cpp. (InlineBox::closestLeafChildForXPos): Ditto.
  • khtml/rendering/render_line.h: Ditto.
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::positionForCoordinates): I think I am starting to get how the coordinate transforms work. Made some fixups based on this greater sense of enlightenment.
  • khtml/rendering/render_text.cpp: (RenderText::positionForCoordinates): Ditto. Fix lastTextBox/firstTextBox code mistake.
  • khtml/xml/dom_position.cpp: (DOMPosition::previousWordPosition): Added. (DOMPosition::nextWordPosition): Added. (DOMPosition::previousLinePosition): No longer use nodeAtPoint. Use new closestLeafChildForXPos instead. (DOMPosition::nextLinePosition): Ditto. (DOMPosition::inLastEditableInContainingEditableBlock):
  • khtml/xml/dom_position.h:
  • kwq/KWQTextUtilities.cpp: Added. (KWQFindWordBoundary): Factored out code that was in a static function in khtml_selection.cpp so that DOMPosition can use it too.
  • kwq/KWQTextUtilities.h: Added.

WebKit:

Reviewed by Hyatt

Added implementations for these methods.

  • WebView.subproj/WebView.m: (-[WebView moveUpAndModifySelection:]): (-[WebView moveWordLeft:]): (-[WebView moveWordLeftAndModifySelection:]): (-[WebView moveWordRight:]): (-[WebView moveWordRightAndModifySelection:]):
1:36 PM Changeset in webkit [6430]
  • 51 copies
    2 deletes in tags/WebCore-125~6~3

This commit was manufactured by cvs2svn to create tag
'WebCore-125~6~3'.

1:36 PM Changeset in webkit [6429] by vicki
  • 2 edits in branches/Safari-1-2-branch/WebCore

WebCore versioning, WebCore-125.6.3

1:05 PM Changeset in webkit [6428] by vicki
  • 4 edits in branches/Safari-1-2-branch/WebCore
  • fixed <rdar://problem/3626076>: (REGRESSION (10.3.3-7H40): some tables rendering incorrectly) by merging more of the zeldman change (3609695) and fixing HRs
  • khtml/css/html4.css: margins on HRs should be smaller, to match other browsers
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlockChildren):
  • khtml/rendering/render_table.cpp: (RenderTableCell::paint):
11:28 AM Changeset in webkit [6427] by sullivan
  • 3 edits in trunk/WebKit

WebKit:

  • fixed <rdar://problem/3622393>: When in stealth mode, visited webpage contents should not be cached to disk

Reviewed by Ken.

  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate willCacheResponse:]): if will cache to disk and in stealth mode, replace cache response with an identical one that won't cache to disk.

WebBrowser:

  • fixed the following bugs: <rdar://problem/3529727>: click and hold on an auto-tab folder in the bookmarks bar should show the items in a menu <rdar://problem/3546013>: bookmark button is left in the wrong state when closing a tab with bookmarks in it <rdar://problem/3612787>: When printed page has no HTML title, put URL in header instead of footer <rdar://problem/3628119>: Would like "Reveal in Collections" context menu item in bookmarks filter search results <rdar://problem/3628143>: Would like "Reveal in Collections" context menu item in Bookmarks bar

Reviewed by Chris.

  • BookmarksViewController.m: (-[BookmarksViewController revealBookmark:expand:]): generalized this to work with content items that aren't bookmarks (e.g. history items) (-[BookmarksViewController outlineView:menuForEvent:inRow:tableColumn:]): add a "Reveal in Collections" item just before Delete (-[BookmarksViewController revealSelectedFilterSearchItem]): new method, sets the collection appropriately and then reveals the item
  • BrowserWebBookmarkExtras.m: (-[WebBookmark revealFavorite]): new method, calls through to BrowserWindowController
  • BrowserWebViewPrinting.m: (-[BrowserWebView webView:drawFooterInRect:]): don't draw URL in footer if it's already being drawn in the header
  • BrowserWindowController.h:
  • BrowserWindowController.m: (-[BrowserWindowController revealFavorite:]): new method, calls through to BookmarksViewController (-[BrowserWindowController closeTab:]): update the show/hide bookmarks button here also (we were already updating it when showing a tab)
  • English.lproj/Localizable.strings: updated for these changes
  • FavoriteButton.m: (-[FavoriteButton menu]): add "Reveal in Collections" item (-[FavoriteButton shouldShowContentsMenuFromEvent:waitedForDragDelay:]): added waitedForDragDelay parameter, use it to decide whether to show the menu even for the auto-tab case (-[FavoriteButton performClick:]): pass NO for waitedForDragDelay (-[FavoriteButton mouseDown:]): pass appropriate value for waitedForDragDelay

Apr 19, 2004:

3:54 PM Changeset in webkit [6426] by kocienda
  • 23 edits in trunk

WebCore:

Reviewed by Hyatt

  • khtml/khtml_part.cpp: (KHTMLPart::notifySelectionChanged): Clear the value used for maintaining x position when doing vertical arrow navigation. WebCoreBridge restores this value when needed. (KHTMLPart::setXPosForVerticalArrowNavigation): New accessor. (KHTMLPart::xPosForVerticalArrowNavigation): New accessor.
  • khtml/khtml_part.h: (KHTMLPart::): Add NoXPosForVerticalArrowNavigation constant.
  • khtml/khtml_selection.cpp: (KHTMLSelection::modify): Add cases for UP and DOWN navigation (KHTMLSelection::xPosForVerticalArrowNavigation): New helper.
  • khtml/khtml_selection.h: Add UP and DOWN constants to EDirection enum. (KHTMLSelection::):
  • khtml/khtmlpart_p.h: Declare storage for m_xPosForVerticalArrowNavigation, the value used for maintaining x position when doing vertical arrow navigation.
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::positionForCoordinates): Improved this function to handle deficiencies exposed when trying to implement new behavior.
  • khtml/rendering/render_br.cpp: (RenderBR::positionForCoordinates): Added implementation of this virtual function.
  • khtml/rendering/render_br.h: Declare implementation for positionForCoordinates virtual function.
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::positionForCoordinates): Improved this function to handle deficiencies exposed when trying to implement new behavior.
  • khtml/rendering/render_text.cpp: (InlineTextBox::offsetForPosition): Remove left/right "bounds" check here. (RenderText::positionForCoordinates): Improved this function to handle deficiencies exposed when trying to implement new behavior.
  • khtml/xml/dom_position.cpp: (inlineBoxForRenderer): Moved to top of file so all code in the file can see this static function. (renderersOnDifferentLine): Ditto. (nextRenderedEditable): Ditto. (previousRenderedEditable): Ditto. (DOMPosition::previousLinePosition): New function. Implements the guts of up/down navigation. (DOMPosition::nextLinePosition): Ditto.
  • khtml/xml/dom_position.h: Added declarations for nextLinePosition and previousLinePosition.
  • kwq/WebCoreBridge.h: Add WebSelectUp and WebSelectDown constants.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge alterCurrentSelection:direction:granularity:]): Handles saving and restoring the x position used for doing vertical arrow navigation.

WebKit:

Reviewed by Hyatt

  • WebView.subproj/WebView.m: (-[WebView moveDown:]): Added implementation. (-[WebView moveUp:]): Added implementation.
2:26 PM Changeset in webkit [6425] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Dave.

Optimize prepend using the shared substring optimization. Also,
limit the applicability of shared append and shared prepend. If
you overdo it, it does more harm than good, because you create a
bunch of strings that are disqualified from future shared
append/prepend, for not much immediate savings in allocate/copy
expense.

  • kjs/ustring.cpp: (KJS::): (KJS::UString::Rep::create): (KJS::UString::expandedSize): (KJS::UString::usedPreCapacity): (KJS::UString::expandCapacity): (KJS::UString::expandPreCapacity): (KJS::UString::UString): (KJS::UString::append): (KJS::UString::operator=):
  • kjs/ustring.h: (KJS::UString::Rep::data):
9:55 AM Changeset in webkit [6424] by cblu
  • 5 edits in trunk/WebKit

Added support for pasting frames via WebArchives.

Reviewed by kocienda.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _addSubframeArchives:]): renamed, now allows subframe archives to be added at anytime (-[WebDataSource _popSubframeArchiveWithName:]): renamed, now deletes the returned subframe to consume less memory (-[WebDataSource _replaceSelectionWithWebArchive:]): added support for subframes
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame _loadRequest:subresources:subframeArchives:]): call renamed methods (-[WebFrame _loadURL:intoChild:]): ditto
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation loadArchive]): ditto

Apr 18, 2004:

5:17 PM Changeset in webkit [6423] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Richard.

No more need for Completion or Reference to privately inherit from
Value, none of the superclass functionality is used.

  • kjs/completion.h:
  • kjs/reference.h:
Note: See TracTimeline for information about the timeline view.