Timeline



Apr 26, 2004:

9:20 PM Changeset in webkit [6493] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • follow-on to fix for <rdar://problem/3488892>: "anchor names with non-ASCII characters in them do not work" This part fixes anchor names with non-ASCII characters in local files.
  • kwq/KWQKURL.mm: (KURL::KURL): For file and help URLs, force UTF-8 only for the path part of the URL. Use the document encoding for the rest of the URL.
  • kwq/KWQTextCodec.h: (operator!=): Added.
6:24 PM Changeset in webkit [6492] by hyatt
  • 4 edits in trunk/WebCore

Fix for Emerson truncation problem using apple-line-clamp. Always dirty positioned objects so that they
will move when the height changes.

Reviewed by darin

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::markPositionedObjectsForLayout):
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutVerticalBox):
4:10 PM Changeset in webkit [6491] by rjw
  • 13 edits in trunk

WebCore:

Added support for specifying composite operation on an
image element. Attribute name is "composite", possible values
are:

clear,
copy
source-over
source-in
source-out
source-atop
destination-over
destination-in
destination-out
destination-atop
xor
darker
highlight
lighter

<img composite="source-over" src="triangle.png">
<img style="position:relative; left:-200px;" composite="destination-in" src="circle.png">

Reviewed by Ken.

  • khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::parseHTMLAttribute):
  • khtml/html/html_imageimpl.h: (DOM::HTMLImageElementImpl::compositeOperator):
  • khtml/misc/htmlattrs.c: (findAttr):
  • khtml/misc/htmlattrs.h:
  • khtml/misc/htmlattrs.in:
  • khtml/rendering/render_image.cpp: (RenderImage::paint):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (compositeOperatorFromString): (QPainter::drawPixmap):
  • kwq/WebCoreImageRenderer.h:

WebKit:

Added support for specifying composite operation on an
image element, i.e.:

<img composite="source-over" src="triangle.png">
<img style="position:relative; left:-200px;" composite="destination-in" src="circle.png">

This feature was requested by the dashboard guys. They can use it to apply
transparency masks to widgies.

Reviewed by Ken.

  • WebCoreSupport.subproj/WebImageRenderer.h:
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithMIMEType:]): (-[WebImageRenderer initWithData:MIMEType:]): (-[WebImageRenderer initWithContentsOfFile:]): (-[WebImageRenderer copyWithZone:]): (-[WebImageRenderer drawClippedToValidInRect:fromRect:]): (-[WebImageRenderer drawImageInRect:fromRect:]): (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:]):

WebBrowser:

Added debug menu to make browser window transparent. Useful
for testing widgies.

  • Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): (-[BrowserDocument toggleBackForwardEnabled:]): (-[BrowserDocument toggleTransparentWindow:]):
3:19 PM Changeset in webkit [6490] by cblu
  • 3 edits in trunk/WebKit

More header doc changes after John's review.

  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebResource.h:
3:03 PM Changeset in webkit [6489] by darin
  • 1 edit in trunk/WebCore/kwq/KWQKURL.mm

Fix semicolon.

3:01 PM Changeset in webkit [6488] by darin
  • 2 edits in trunk/WebCore
  • fixed <rdar://problem/3634145>: "REGRESSION: nil-deref in QTextCodec::toUnicode every time loading page at wiki.wordpress.org"
  • kwq/KWQKURL.mm: (KURL::KURL): Simplify check for nil that defaults to UTF-8. (KURL::decode_string): Add a similar test here.
2:19 PM Changeset in webkit [6487] by hyatt
  • 297 edits in trunk/LayoutTests

Update layout tests to reflect WinIE body-height quirk.

2:16 PM Changeset in webkit [6486] by hyatt
  • 2 edits in trunk/WebCore

Implement the quirk that makes the <body> and <html> size to fill the viewport in quirks mode. This
matches WinIE.

Reviewed by john

  • khtml/rendering/render_box.cpp: (RenderBox::calcHeight):
11:52 AM Changeset in webkit [6485] by cblu
  • 3 edits in trunk/WebKit
  • WebView.subproj/WebDataSourcePrivate.h: added some header doc comments
  • WebView.subproj/WebFramePrivate.h: fixed header doc typo
11:34 AM Changeset in webkit [6484] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3633458>: "REGRESSION (125-137): Can't drag a selection unless it starts at beginning of line"

  • khtml/khtml_part.cpp: (KHTMLPart::isPointInsideSelection): I flubbed when I converted this code to use my new positionForCoordinates helper. I failed to add in the passed in values for x and y to the absolute coordinates for the clicked node. So, the "unless it starts at beginning of line" behavior is exactly as one would expect.
1:58 AM Changeset in webkit [6483] by hyatt
  • 8 edits in trunk/WebCore

Eliminate overhangingContents. This concept was redundant with the overflowHeight mechanism that I
implemented some time ago, and in fact, it causes us to grovel through much more of the render tree
than we should when painting. It turns out that none of the places that used this boolean needed
to any longer, and so the entire implementation can now be removed from the tree.

Reviewed by mjs, darin

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::addChildToFlow): (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::paint): (khtml::RenderBlock::insertPositionedObject):
  • khtml/rendering/render_box.cpp: (RenderBox::calcHeight):
  • khtml/rendering/render_image.cpp: (RenderImage::setStyle):
  • khtml/rendering/render_inline.cpp: (RenderInline::addChildToFlow):
  • khtml/rendering/render_object.cpp: (RenderObject::RenderObject): (RenderObject::containingBlock): (RenderObject::information): (RenderObject::dump): (RenderObject::nodeAtPoint):
  • khtml/rendering/render_object.h: (khtml::RenderObject::minMaxKnown):
  • khtml/rendering/render_table.cpp: (RenderTable::layout): (RenderTable::paint): (RenderTableCell::paint):

Apr 25, 2004:

11:38 PM Changeset in webkit [6482] by hyatt
  • 4 edits
    2 adds in trunk

Fix for 3258403, implement support for min-height and max-height on normal flow elements. With this patch the
only min-height/max-height work that remains to be done is for table cells and positioned elements.

Reviewed by darin

  • khtml/rendering/render_box.cpp: (RenderBox::calcHeight): (RenderBox::calcHeightUsing): (RenderBox::calcPercentageHeight):
  • khtml/rendering/render_box.h:
  • layout-tests/fast/block/basic/minheight-expected.txt: Added.
  • layout-tests/fast/block/basic/minheight.html: Added.
7:33 PM Changeset in webkit [6481] by darin
  • 4 edits in trunk/WebCore

Reviewed by Dave.

  • fixed <rdar://problem/3633091>: "add overrideMimeType function to XMLHttpRequest"
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): Add logic to override MIME type if OverrideMIMEType was called. (KJS::XMLHttpRequestProtoFunc::tryCall): Store the MIME type when overrideMimeType is called.
  • khtml/ecma/xmlhttprequest.h: Add OverrideMIMEType to the XMLHttpRequest property enum, and also add a MIMETypeOverride data member to the class.
  • khtml/ecma/xmlhttprequest.lut.h: Regenerated.
5:08 PM Changeset in webkit [6480] by mjs
  • 3 edits
    5 adds in trunk

Reviewed by Darin.

<rdar://problem/3628309>: Fedex tracking page so slow it seems like a hang (site change?)
<rdar://problem/3608061>: "ATI Developer site so slow it seems like a hang"
<rdar://problem/3612130>: "Reproducible hang in JavaScript at www.tfl.gov.uk"
<rdar://problem/3626022>: "Safari was consuming > 100% CPU on dual-G5 Mac, sample shows JavaScript"
<rdar://problem/3632348>: "www.whatis.com search for "pivot table" leads to JavaScript hang"

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getValueProperty): The "text" property for anchors should be innerText, not innerHTML.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::innerText): Make sure not to include all the text after an element if it has no children.
  • layout-tests/fast/dom/anchor-text-expected.txt: Added.
  • layout-tests/fast/dom/anchor-text.html: Added.
  • layout-tests/fast/dom/inner-text-expected.txt: Added.
  • layout-tests/fast/dom/inner-text.html: Added.
8:10 AM Changeset in webkit [6479] by darin
  • 10 edits in trunk/WebCore

Reviewed by Dave.

  • fixed <rdar://problem/3488892>: "anchor names with non-ASCII characters in them do not work"
  • khtml/khtml_part.h: Add new gotoAnchor helper function, private.
  • khtml/khtml_part.cpp: (KHTMLPart::openURL): Call new gotoAnchor helper, since the code is now complex enough that I don't want to copy and paste. (KHTMLPart::gotoAnchor): Use the pages own encoding when decoding the string for an anchor reference when going to an anchor. This matches the behavior of other browsers. (KHTMLPart::slotFinishedParsing): Call new gotoAnchor helper.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scrollToAnchor): Call new gotoAnchor helper.
  • kwq/KWQKURL.h: Removed htmlRef function, and made encodedHtmlRef an inline. Removed unused encoding hint parameter from setQuery (it's not a "hint" at all, but we don't use it). Added a codec parameter to decode_string.
  • kwq/KWQKURL.mm: (hexDigitValue): Added. Helper function. (KURL::setQuery): Removed unused parameter. (KURL::decode_string): Implemented this function. It needs to use an encoding specified by the web page. Also, we wanted to make a version that did not use the CFURLCreateStringByReplacingPercentEscapes function anyway.
  • kwq/KWQString.h: Added parameters to copyLatin1. Now you can copy an arbitrary substring.
  • kwq/KWQString.mm: (QString::copyLatin1): Updated implementation to handle the two new parameters.
  • WebCore-tests.exp: Updated for change in signature of setQuery and decode_string.
  • WebCore-combined.exp: Regenerated.
8:10 AM Changeset in webkit [6478] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Dave.

  • kjs/ustring.cpp: (KJS::UString::append): Fix one case that was allocating a buffer that is 2x too big.
8:10 AM Changeset in webkit [6477] by darin
  • 2 edits in trunk/WebKit

Reviewed by Dave.

  • Misc.subproj/WebNSURLExtras.m: (hexDigit): Use capitalized hex, not lowercase, for consistency with similar functions in WebCore and what other web browsers do.

Apr 24, 2004:

7:46 PM Changeset in webkit [6476] by darin
  • 2 edits in trunk/WebCore

WebCore:

  • fixed <rdar://problem/3570953>: "Update "Acknowledgements" to remove expat and possibly include libxml"
  • WebCore.pbproj/project.pbxproj: Removed the part of the copyright notice that was for expat contributors.

WebBrowser:

  • fixed <rdar://problem/3570953>: "Update "Acknowledgements" to remove expat and possibly include libxml"
  • Help/Acknowledgments.rtf: New version of the file from legal, removing expat-related section.

Apr 23, 2004:

7:50 PM Changeset in webkit [6475] by darin
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

  • fixed <rdar://problem/3627362>: "bad access with libgmalloc in -[_WebCoreHistoryProvider containsItemForURLUnicode:length:]"
  • History.subproj/WebHistory.m: (-[_WebCoreHistoryProvider containsItemForURLUnicode:length:]): Add range checks so we don't overrun the buffer while looking for slashes.
4:57 PM Changeset in webkit [6474] by hyatt
  • 2 edits in trunk/WebCore

Fix the apple-line-clamp values to more closely match what is needed, an even split of the max lines between the possible
values.

  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutVerticalBox):
4:43 PM Changeset in webkit [6473] by hyatt
  • 3 edits in trunk/WebCore

Fix to make the containing block percentage height calculation actually work according to the CSS2 spec.
Percentages other than 100% are now supported, and flexing percentage height blocks inside table cells
are now supported.

Reviewed by kocienda

  • khtml/rendering/render_box.cpp: (RenderBox::calcHeight): (RenderBox::calcPercentageHeight):
  • khtml/rendering/render_box.h:
3:40 PM Changeset in webkit [6472] by mjs
  • 7 edits
    2 adds in trunk/JavaScriptCore

Reviewed by Darin.

Implementation of conservative GC, based partly on code from
Darin. It's turned off for now, so it shouldn't have any effect on
the normal build.

  • JavaScriptCore.pbproj/project.pbxproj:
  • kjs/collector.cpp: (KJS::Collector::markStackObjectsConservatively): (KJS::Collector::markProtectedObjects): (KJS::Collector::collect):
  • kjs/collector.h:
  • kjs/protect.h: (KJS::gcProtect): (KJS::gcUnprotect):
  • kjs/protected_values.cpp: Added. (KJS::ProtectedValues::getProtectCount): (KJS::ProtectedValues::increaseProtectCount): (KJS::ProtectedValues::insert): (KJS::ProtectedValues::decreaseProtectCount): (KJS::ProtectedValues::expand): (KJS::ProtectedValues::shrink): (KJS::ProtectedValues::rehash): (KJS::ProtectedValues::computeHash):
  • kjs/protected_values.h: Added.
  • kjs/value.cpp: (ValueImp::useConservativeMark): (ValueImp::mark): (ValueImp::marked):
  • kjs/value.h: (KJS::ValueImp::):
2:20 PM Changeset in webkit [6471] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:
<rdar://problem/3632163>: "REGRESSSION: crash on css home page"

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::positionForRenderer): Add null check.
2:17 PM Changeset in webkit [6470] by cblu
  • 4 edits in trunk/WebKit

Reviewed by John

Added header doc comments to proposed API's.

  • WebView.subproj/WebArchive.h:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebResource.h:
12:01 PM Changeset in webkit [6469] by hyatt
  • 3 edits in trunk/WebCore

Fix hiermenu opacity bug. Make sure to save/restore the graphics state before pushing and popping
transparency layers, so that alterations to alpha don't accidentally persist.

Reviewed by kocienda

  • kwq/KWQPainter.mm: (QPainter::beginTransparencyLayer): (QPainter::endTransparencyLayer):
10:18 AM Changeset in webkit [6468] by kocienda
  • 8 edits in trunk/WebCore

Reviewed by Darin

Changed inlineBoxForRenderer(RenderObject *, int) helper that was static
in dom_position.cpp into a virtual method on RenderObjects. Function is
now called inlineBox(int). Functionality unchanged.

  • khtml/rendering/render_br.cpp: (RenderBR::inlineBox)
  • khtml/rendering/render_br.h:
  • khtml/rendering/render_object.cpp: (RenderObject::caretMaxRenderedOffset) (RenderObject::inlineBox)
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_text.cpp: (RenderText::inlineBox)
  • khtml/rendering/render_text.h:
  • khtml/xml/dom_position.cpp: (DOM::renderersOnDifferentLine): (DOM::nextRenderedEditable) (DOM::previousRenderedEditable) (DOM::Position::previousLinePosition) (DOM::Position::nextLinePosition) (DOM::Position::rendersInDifferentPosition)
10:02 AM Changeset in webkit [6467] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Darin

  • khtml/editing/htmlediting_impl.cpp: (DeleteSelectionCommandImpl::doApply): Fix editing test regression with deleting whitespace at the end of the line. I just made this "improvement" yesterday, and the concept of the change is a good one, but instead of short-circuiting if the selection after deleting collapsible whitespace is a range (which can be confused by "significant" collapsed whitespace at the end of a line), short-circuit if the upstream start position equals the downstream end position.
9:41 AM Changeset in webkit [6466] by vicki
  • 3 edits in trunk

Change version number to '139u'. The tree is open!

9:33 AM Changeset in webkit [6465]
  • 3 copies in tags/Safari-138

This commit was manufactured by cvs2svn to create tag 'Safari-138'.

9:33 AM Changeset in webkit [6464] by vicki
  • 6 edits in trunk

Safari-138 stamp

8:13 AM Changeset in webkit [6463] by kocienda
  • 11 edits in trunk

WebCore:

Reviewed by John

Added some plumbing for applying styles.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createCSSStyleDeclaration): New factory method.
  • khtml/xml/dom_docimpl.h: Declare the above.
  • kwq/DOM-CSS.mm: (-[DOMCSSStyleDeclaration _styleDeclarationImpl]): Expose this in the WebCoreInternal category, "promoting" it from being private to the DOM-CSS.mm file.
  • kwq/DOM.mm: Add -(DOMCSSStyleDeclaration *)createCSSStyleDeclaration extension.
  • kwq/DOMExtensions.h: Delcare the above.
  • kwq/DOMInternal.h: Add _styleDeclarationImpl to WebCoreInternal category.

WebKit:

Reviewed by John

Added some plumbing for applying styles.

  • DOM.subproj/DOMExtensions.h: Copied from WebCore.
  • WebView.subproj/WebView.m: (-[WebView DOMDocument]): Added new helper. (-[WebView styleDeclarationWithText:]): Added new helper.
  • WebView.subproj/WebViewPrivate.h: Declare above methods.
3:40 AM Changeset in webkit [6462] by sullivan
  • 2 edits in trunk/WebCore
  • fixed <rdar://problem/3631541>: "repro crash in KHTMLPart::setFocusNodeIfNeeded"

Reviewed by Maciej.

  • khtml/khtml_part.cpp: (KHTMLPart::setFocusNodeIfNeeded): added nil check
1:43 AM Changeset in webkit [6461] by mjs
  • 2 edits in trunk/WebCore

Back out one of the previous changes, it causes a crash. Whoops!

  • kwq/KWQScrollView.mm: (QScrollView::addChild):

Apr 22, 2004:

2:55 PM Changeset in webkit [6460] by rjw
  • 2 edits in trunk/JavaScriptCore

Fixed build snafu (re-declaration of NPBool in npruntime.h and
npapi.h).

  • bindings/npruntime.h:
2:54 PM Changeset in webkit [6459] by rjw
  • 5 edits
    2 adds in trunk/WebKit

Updates to plugin binding APIs.
Updates to Java plugin APIs.
Transparency fix for Dashboard.

Reviewed by John and Greg Bolsinga.

  • Plugins.subproj/WebPluginJava.h: Added. New API for Java plugin.
  • Plugins.subproj/npfunctions.h:
  • Plugins.subproj/npruntime.h: (_NPString::): (_NPString::_NPVariant::):
  • Plugins.subproj/npsap.h: Added. New API for plugin bindings.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Update for Dashboard. View must fill with transparency when not drawing background.
  • copy-webcore-files-to-webkit:
2:49 PM Changeset in webkit [6458] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Hyatt

  • khtml/editing/htmlediting_impl.cpp: (DeleteSelectionCommandImpl::doApply): Short-circuit return if the selection is not a range after collapsing whitespace.
2:38 PM Changeset in webkit [6457] by rjw
  • 11 edits in trunk/JavaScriptCore

Updated plugin binding API to reflect latest revision from
working group.

Biggest change is the introduction of NPVariant used to represent
value types. NPVariant replaces the use of NPObject for the
exchange of values between scripting environment and native code.

Reviewed by John.

  • JavaScriptCore.pbproj/project.pbxproj:
  • bindings/NP_jsobject.cpp: (identiferFromNPIdentifier): (NPN_Call): (NPN_Evaluate): (NPN_GetProperty): (NPN_SetProperty): (NPN_ToString): (NPN_GetPropertyAtIndex): (NPN_SetPropertyAtIndex):
  • bindings/c/c_class.cpp: (CClass::methodsNamed): (CClass::fieldNamed):
  • bindings/c/c_instance.cpp: (CInstance::invokeMethod): (CInstance::defaultValue):
  • bindings/c/c_runtime.cpp: (CField::valueFromInstance): (CField::setValueToInstance):
  • bindings/c/c_utility.cpp: (convertNPStringToUTF16): (convertUTF8ToUTF16): (coerceValueToNPVariantStringType): (convertValueToNPVariant): (convertNPVariantToValue):
  • bindings/c/c_utility.h:
  • bindings/npruntime.cpp: (NPN_GetIdentifier): (NPN_GetIdentifiers): (NPN_UTF8FromIdentifier): (NPN_VariantIsVoid): (NPN_VariantIsNull): (NPN_VariantIsUndefined): (NPN_VariantIsBool): (NPN_VariantIsInt32): (NPN_VariantIsDouble): (NPN_VariantIsString): (NPN_VariantIsObject): (NPN_VariantToBool): (NPN_VariantToString): (NPN_VariantToInt32): (NPN_VariantToDouble): (NPN_VariantToObject): (NPN_InitializeVariantAsVoid): (NPN_InitializeVariantAsNull): (NPN_InitializeVariantAsUndefined): (NPN_InitializeVariantWithBool): (NPN_InitializeVariantWithInt32): (NPN_InitializeVariantWithDouble): (NPN_InitializeVariantWithString): (NPN_InitializeVariantWithStringCopy): (NPN_InitializeVariantWithObject): (NPN_InitializeVariantWithVariant): (NPN_ReleaseVariantValue): (NPN_CreateObject): (NPN_RetainObject): (NPN_ReleaseObject): (NPN_IsKindOfClass): (NPN_SetExceptionWithUTF8): (NPN_SetException):
  • bindings/npruntime.h: (_NPString::): (_NPString::_NPVariant::):
  • bindings/testbindings.cpp: (logMessage): (setDoubleValue): (setIntValue): (setStringValue): (setBooleanValue): (getDoubleValue): (getIntValue): (getStringValue): (getBooleanValue): (myGetProperty): (mySetProperty): (myInvoke): (myAllocate):
1:06 PM Changeset in webkit [6456] by kocienda
  • 13 edits in trunk

WebCore:

Reviewed by Hyatt

More work to bring code up to date with the latest API proposal.

  • khtml/xml/dom_selection.h: Fix typo in comment.
  • kwq/WebCoreBridge.h: -applyStyle:toElementsInDOMRange: is now applyStyle:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge applyStyle:]): Ditto.

WebKit:

Reviewed by Hyatt

More work to bring code up to date with the latest API proposal. Note that
all of the replaceXXX methods below now operate on the current selection, so
the method implementations have been simplifed accordingly.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _replaceSelectionWithArchive:]): New name for _replaceSelectionWithWebArchive.
  • WebView.subproj/WebDataSourcePrivate.h: Ditto.
  • WebView.subproj/WebDefaultEditingDelegate.m: (-[WebDefaultEditingDelegate webViewShouldBeginEditing:inDOMRange:]): Added inDOMRange: parameter. (-[WebDefaultEditingDelegate webViewShouldEndEditing:inDOMRange:]): Ditto. (-[WebDefaultEditingDelegate webView shouldChangeSelectedDOMRange:toDOMRange:proposedRange affinity:stillSelecting:]): Missed adding affinity in last patch.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _pasteFromPasteboard:]): Call old method with new name: _replaceSelectionWithArchive
  • WebView.subproj/WebView.m: (-[WebView replaceSelectionWithNode:]): New version of insertNode:replacingDOMRange: (-[WebView replaceSelectionWithText:]): New version of insertText:replacingDOMRange: (-[WebView replaceSelectionWithMarkupString:]): New version of insertMarkupString:replacingDOMRange: (-[WebView replaceSelectionWithArchive:]): New version of insertWebArchive:replacingDOMRange: (-[WebView deleteSelection]): New version of deleteDOMRange: (-[WebView applyStyle:]): New version of applyStyle:toElementsInDOMRange:
  • WebView.subproj/WebViewPrivate.h:
10:54 AM Changeset in webkit [6455] by kocienda
  • 12 edits in trunk

Tests:

Reviewed by John

  • Blot/BlotDocument.m: (-[BlotDocument webView:didFinishLoadForFrame:]): Send along selection affinity in call to set selection.

WebCore:

Reviewed by John

Adds the notion of selection affinity to the editing API, bringing it up to
date with the latest proposal.

  • khtml/xml/dom_selection.cpp: (DOM::Selection::Selection): Adds support for selection affinity member variable. (DOM::Selection::init): Ditto. (DOM::Selection::operator=): Ditto. (DOM::Selection::setAffinity): New function. (DOM::Selection::layoutCaret): Added comment to indicate that we need to enhance this function to handle selection affinity.
  • khtml/xml/dom_selection.h: Added EAffinity enum and m_affinity member variable. (DOM::Selection::): Moved the enums above the constructors. No code change. (DOM::Selection::affinity): New accessor.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: Add selection affinity to API declarations as needed. (-[WebCoreBridge setSelectedDOMRange:affinity:]): Ditto. (-[WebCoreBridge selectedDOMRange]): Ditto. (-[WebCoreBridge selectionAffinity]): Ditto.

WebKit:

Reviewed by John

Adds the notion of selection affinity to the editing API, bringing it up to
date with the latest proposal.

  • WebView.subproj/WebView.m: (-[WebView _alterCurrentSelection:direction:granularity:]): Pass selection affinity to the delegate. We can just pass the current one since this does not change with arrow keys. (-[WebView setSelectedDOMRange:affinity:]): Set the affinity on the selection. (-[WebView selectionAffinity]): New accessor. (-[WebView insertNode:replacingDOMRange:]): Change to pass selection affinity to call to set selection. This is just to get the code to compile for now, since this method will soon be removed in place of a similar one from the latest proposal that always works on the current selection. (-[WebView insertText:replacingDOMRange:]): Ditto. (-[WebView insertMarkupString:replacingDOMRange:]): Ditto. (-[WebView insertWebArchive:replacingDOMRange:]): Ditto. (-[WebView deleteDOMRange:]): Ditto. (-[WebView applyStyle:toElementsInDOMRange:]): Ditto.
  • WebView.subproj/WebViewPrivate.h: Add selection affinity to API declarations as needed.
10:10 AM Changeset in webkit [6454] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • fixed <rdar://problem/3627473>: "REGRESSION (125-137): memory trasher in UString::append, causing many different crashes"
  • kjs/ustring.cpp: (KJS::UString::expandCapacity): Fix sizeof(UChar *) that should be sizeof(UChar). Was resulting in a buffer 2x the needed size. (KJS::UString::expandPreCapacity): Ditto. (KJS::UString::append): Fix malloc that is missing a sizeof(UChar).
10:07 AM Changeset in webkit [6453] by mjs
  • 1 add in trunk/JavaScriptCore/kjs/protect.h

* empty log message *

9:53 AM Changeset in webkit [6452] by mjs
  • 14 edits
    1 add in trunk

JavaScriptCore:

Reviewed by Darin.

Preliminary change for conservative GC. Create "protected"
subclasses to GC-protect objects when on heap, since we will soon
remove the built-in refcounting of the normal wrapper classes. Use
them where needed.

  • JavaScriptCore.pbproj/project.pbxproj:
  • kjs/context.h:
  • kjs/internal.h: (KJS::InterpreterImp::globalObject):
  • kjs/interpreter.h:
  • kjs/property_map.cpp:
  • kjs/reference.h:
  • kjs/reference_list.cpp:

WebCore:

Reviewed by Darin.

Preliminary change for conservative GC. Use new "protected"
subclasses to GC-protect objects when on heap, since we will soon
remove the built-in refcounting of the normal wrapper classes.

  • ForwardingHeaders/kjs/protect.h: Added.
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_events.h:
  • khtml/ecma/kjs_traversal.h:
  • khtml/ecma/kjs_window.h:
9:16 AM Changeset in webkit [6451] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by Darin

Work around this bug:
<rdar://problem/3630640>: "Calling interpretKeyEvents: in a custom text view can fail to process keys right after app startup"

  • WebView.subproj/WebView.m: (-[WebView _editingKeyDown:]): The issue is with a message to nil in AppKit key binding manager code. Add call to [NSKeyBindingManager sharedKeyBindingManager] to make sure the not-supposed-to-be-nil object is created before calling interpretKeyEvents:.
8:39 AM Changeset in webkit [6450] by darin
  • 2 edits in trunk/WebCore
  • khtml/ecma/kjs_window.cpp: (Window::get): Removed code that gets properties from the parent. This was a mistake we inherited from KHTML, and they have long since fixed it.
6:24 AM Changeset in webkit [6449] by kocienda
  • 11 edits in trunk

WebCore:

Reviewed by Hyatt

Ensures caret visibility after making an editing action.

  • khtml/xml/dom_selection.cpp: (DOM::Selection::getRepaintRect): Expose this as public.
  • khtml/xml/dom_selection.h: Ditto.
  • kwq/WebCoreBridge.h: Add ensureCaretVisible method.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge replaceSelectionWithMarkupString:baseURLString:]): Unrelated crash fix. Null-check baseURLString. (-[WebCoreBridge ensureCaretVisible]): Added.

WebKit:

Reviewed by Hyatt

Added calls to ensure caret visibility after the editing action is done.

  • WebView.subproj/WebView.m: (-[WebView _alterCurrentSelection:direction:granularity:]): (-[WebView insertNewline:]): (-[WebView deleteBackward:]): (-[WebView insertText:]):
Note: See TracTimeline for information about the timeline view.