Timeline



Apr 30, 2004:

4:19 PM Changeset in webkit [6529] by rjw
  • 2 edits in trunk/JavaScriptCore

Asking an NSInvocation for it's return value when return type
is void throws an exception. Added check for void return types
to avoid this exception.

Reviewed by Ken.

  • bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod):
4:16 PM Changeset in webkit [6528] by cblu
  • 2 edits in trunk/WebCore

Fixed: <rdar://problem/3543662>: HITLIST-137: REGRESSION: reproducible hang copying all text at Dave's blog, and other pages

Reviewed by dave.

  • khtml/xml/dom2_rangeimpl.cpp: (RangeImpl::toHTMLWithOptions): when looping with containingBlock, check the value to see if it is the same
12:19 PM Changeset in webkit [6527] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3639530, regression on generated content pages. They crash because I forgot to null-check the style
object.

Reviewed by kocienda

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector):
10:59 AM Changeset in webkit [6526] by sullivan
  • 2 edits in trunk/WebKit
  • WebView.subproj/WebView.m: fixed deployment build breakage
10:30 AM Changeset in webkit [6525] by sullivan
  • 5 edits in trunk

WebCore:

  • added bridge method to get the NSFont used to render a node, to help with supporting the font panel

Reviewed by Ken.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge renderedFontForNode:]): return nil if no renderer, otherwise return NSFont

WebKit:

  • more work on getting the font panel to work with editable HTML. The font panel in Blot now correctly reflects the first selected font when the selection is at least one character long.

Reviewed by Ken.

  • WebView.subproj/WebView.m: removed unfinished plumbing to support reflecting selected attributes (e.g. text color, underline) in font panel, since this doesn't work in Mail or TextEdit either. (_fontFromStyle): removed assertion for now (-[WebView _updateFontPanel]): now uses new bridge method to get the NSFont from the node, instead of trying to create an NSFont from a DOMCSSStyleDeclaration

Apr 29, 2004:

6:44 PM Changeset in webkit [6524] by rjw
  • 9 edits in trunk/JavaScriptCore

Fixed several bad problems with the ObjC bindings. In particular, conversion
to/from JavaScriptObject (soon to be WebScriptObject) was completely broken.

Reviewed by Chris.

  • bindings/objc/objc_jsobject.h:
  • bindings/objc/objc_jsobject.mm: (-[JavaScriptObject initWithObjectImp:KJS::root:Bindings::]): (-[JavaScriptObject KJS::]): (+[JavaScriptObject _convertValueToObjcValue:KJS::root:Bindings::]): (-[JavaScriptObject call:arguments:]): (-[JavaScriptObject evaluate:]): (-[JavaScriptObject getMember:]): (-[JavaScriptObject getSlot:]):
  • bindings/objc/objc_runtime.mm: (ObjcField::valueFromInstance): (ObjcField::setValueToInstance):
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue):
  • bindings/runtime.h:
  • bindings/runtime_root.cpp: (KJS::Bindings::rootForInterpreter): (KJS::Bindings::addNativeReference): (KJS::Bindings::removeNativeReference):
  • bindings/runtime_root.h:
  • bindings/testbindings.mm: (-[MyFirstInterface logMessage:]): (-[MyFirstInterface setJSObject:]): (-[MyFirstInterface callJSObject::]):
4:26 PM Changeset in webkit [6523] by hyatt
  • 2 edits in trunk/WebCore

Expose summary on tables.

Reviewed by darin

  • kwq/KWQAccObject.mm: (-[KWQAccObject helpText]):
4:08 PM Changeset in webkit [6522] by hyatt
  • 8 edits in trunk/WebCore

Implement image maps for accessibility.

Reviewed by darin

  • khtml/html/html_imageimpl.cpp: (HTMLAreaElementImpl::getRect):
  • khtml/html/html_imageimpl.h:
  • khtml/rendering/render_image.cpp: (RenderImage::imageMap): (RenderImage::nodeAtPoint):
  • khtml/rendering/render_image.h:
  • kwq/KWQAccObject.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject initWithRenderer:]): (-[KWQAccObject anchorElement]): (-[KWQAccObject parentObject]): (-[KWQAccObject parentObjectUnignored]): (-[KWQAccObject addChildrenToArray:]): (-[KWQAccObject role]): (-[KWQAccObject helpText]): (-[KWQAccObject value]): (-[KWQAccObject title]): (-[KWQAccObject position]): (-[KWQAccObject size]): (-[KWQAccObject accessibilityIsIgnored]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]):
  • kwq/KWQRegion.mm: (QRegion::boundingRect):
2:30 PM Changeset in webkit [6521] by cblu
  • 4 edits in trunk/WebCore

Fixed:
<rdar://problem/3631431>: web archive of .Mac welcome page renders has gaps in layout
<rdar://problem/3631470>: news.google.com web archive has a different font than the live site

Reviewed by kocienda.

  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::determineParseMode): don't set a name on the doc type when there is no doc type in the source
  • khtml/xml/dom_docimpl.cpp: (DocumentTypeImpl::toString): don't return "<!DOCTYPE>" when there is no doc type in the source
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::recursive_toHTMLWithOptions): don't escape STYLE text, don't include the end tags for document nodes just as we don't for start tags
1:49 PM Changeset in webkit [6520] by darin
  • 3 edits in trunk/WebCore

Reviewed by Dave.

  • some tweaks on image
  • khtml/html/html_imageimpl.h: Remove unused noref bit and unneeded override of isURLAttribute.
  • khtml/html/html_imageimpl.cpp: (HTMLAreaElementImpl::HTMLAreaElementImpl): Remove unused noref bit. (HTMLAreaElementImpl::parseHTMLAttribute): Remove parsing of noref; no need to store the bit since it has no meaning.
1:33 PM Changeset in webkit [6519] by sullivan
  • 2 edits in trunk/WebKit
  • more work on getting the font panel to work with editable HTML

Reviewed by Ken.

  • WebView.subproj/WebView.m: (-[WebView computedStyleForElement:pseudoElement:]): convert nil pseudoElement to empty string because lower level chokes on nil (_fontFromStyle): I tried to implement this, but was thwarted by missing API, so I added a bunch of FIXMEs instead (_stylesRepresentSameFont): new function, not yet implementable (_stylesRepresentSameAttributes): new function, not yet implementable (-[WebView _updateFontPanel]): added code to get first and last element in selection, and to use NodeIterator to walk through the entire selection to see if more than one font or set of attributes is in use. However, createNodeIterator is declared in DOMTraversal.h but not actually defined anywhere, so I had to prevent this code from actually being called.
11:52 AM Changeset in webkit [6518] by hyatt
  • 3 edits in trunk/WebCore
  1. Change the role of links from AXButton to AXLink.
  2. Add support for list markers using a new role, AXListMarker.

Reviewed by kocienda

  • khtml/rendering/render_list.h: (khtml::RenderListMarker::text):
  • kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject roleDescription]): (-[KWQAccObject value]): (-[KWQAccObject accessibilityIsIgnored]):
9:20 AM Changeset in webkit [6517] by darin
  • 2 edits in trunk/WebCore

Reviewed by Ken.

  • fixed <rdar://problem/3636566>: "space bar on a form button hits default button instead (autorestore.apple.com)"
  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::defaultEventHandler): Remove special handling for space, falling back to default AppKit behavior. Change enter handling to click the form element itself in the case of elements other than text input ones.
8:24 AM Changeset in webkit [6516] by darin
  • 2 edits in trunk/WebCore

Reviewed by Ken.

  • fixed <rdar://problem/3636673>: "unrepro nil-deref crash in KHTMLPart::frameDetached() (espn.com)"
  • kwq/KWQKHTMLPart.mm: (KHTMLPart::frameDetached): Check for nil.

Apr 28, 2004:

7:05 PM Changeset in webkit [6515] by cblu
  • 8 edits
    1 add in trunk/WebCore
  • Implemented DOMHTMLElementExtensions.
  • Added stubs for the rest of the DOM API.

Reviewed by dave.

  • WebCore.pbproj/project.pbxproj:
  • khtml/dom/html_element.cpp: (HTMLElement::setContentEditable): moved implementation from here to HTMLElementImpl
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setContentEditable): new, moved from HTMLElement
  • khtml/html/html_elementimpl.h:
  • kwq/DOM-CSS.mm: (-[DOMObject sheet]): (-[DOMDocument getComputedStyle::]):
  • kwq/DOM.mm: (-[DOMAbstractView document]): (-[DOMDocumentView defaultView]): (-[DOMDocument createNodeIterator::::]): (-[DOMDocument createTreeWalker::::]): (-[DOMNodeFilter acceptNode:]): (-[DOMNodeIterator root]): (-[DOMNodeIterator whatToShow]): (-[DOMNodeIterator filter]): (-[DOMNodeIterator expandEntityReferences]): (-[DOMNodeIterator nextNode]): (-[DOMNodeIterator previousNode]): (-[DOMNodeIterator detach]): (-[DOMTreeWalker root]): (-[DOMTreeWalker whatToShow]): (-[DOMTreeWalker filter]): (-[DOMTreeWalker expandEntityReferences]): (-[DOMTreeWalker currentNode]): (-[DOMTreeWalker setCurrentNode:]): (-[DOMTreeWalker parentNode]): (-[DOMTreeWalker firstChild]): (-[DOMTreeWalker lastChild]): (-[DOMTreeWalker previousSibling]): (-[DOMTreeWalker nextSibling]): (-[DOMTreeWalker previousNode]): (-[DOMTreeWalker nextNode]):
  • kwq/DOMEvents.mm: Added. (-[DOMEvent type]): (-[DOMEvent target]): (-[DOMEvent currentTarget]): (-[DOMEvent eventPhase]): (-[DOMEvent bubbles]): (-[DOMEvent cancelable]): (-[DOMEvent timeStamp]): (-[DOMEvent stopPropagation]): (-[DOMEvent preventDefault]): (-[DOMEvent initEvent:::]): (-[DOMEventTarget addEventListener:::]): (-[DOMEventTarget removeEventListener:::]): (-[DOMEventTarget dispatchEvent:]): (-[DOMMouseEvent screenX]): (-[DOMMouseEvent screenY]): (-[DOMMouseEvent clientX]): (-[DOMMouseEvent clientY]): (-[DOMMouseEvent ctrlKey]): (-[DOMMouseEvent shiftKey]): (-[DOMMouseEvent altKey]): (-[DOMMouseEvent metaKey]): (-[DOMMouseEvent button]): (-[DOMMouseEvent relatedTarget]): (-[DOMMouseEvent initMouseEvent:::::::::::::::]): (-[DOMMutationEvent relatedNode]): (-[DOMMutationEvent prevValue]): (-[DOMMutationEvent newValue]): (-[DOMMutationEvent attrName]): (-[DOMMutationEvent attrChange]): (-[DOMMutationEvent initMutationEvent::::::::]): (-[DOMUIEvent view]): (-[DOMUIEvent detail]): (-[DOMUIEvent initUIEvent:::::]): (-[DOMDocument createEvent:]):
  • kwq/DOMHTML.mm: (-[DOMHTMLElement innerHTML]): implemented (-[DOMHTMLElement setInnerHTML:]): implemented (-[DOMHTMLElement innerText]): implemented (-[DOMHTMLElement setInnerText:]): implemented (-[DOMHTMLElement children]): implemented (-[DOMHTMLElement contentEditable]): implemented (-[DOMHTMLElement setContentEditable:]): implemented (-[DOMHTMLElement isContentEditable]): implemented
6:19 PM Changeset in webkit [6514] by hyatt
  • 37 edits in trunk/WebCore

Implement sharing of similar style objects. Cuts the # of style objects allocated on the PLT by more
than half.

Reviewed by kocienda

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::initElementAndPseudoState): (khtml::CSSStyleSelector::initForStyleResolve): (khtml::cleanpath): (khtml::checkPseudoState): (khtml::CSSStyleSelector::locateSiblingList): (khtml::CSSStyleSelector::canShareStyleWithElement): (khtml::CSSStyleSelector::locateSharedStyle): (khtml::CSSStyleSelector::styleForElement): (khtml::CSSStyleSelector::pseudoStyleForElement): (khtml::CSSStyleSelector::checkOneSelector):
  • khtml/css/cssstyleselector.h:
  • khtml/css/html4.css:
  • khtml/css/parser.cpp:
  • khtml/css/parser.y:
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::mapToEntry): (HTMLIFrameElementImpl::mapToEntry):
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_blockimpl.cpp: (HTMLDivElementImpl::mapToEntry): (HTMLHRElementImpl::mapToEntry): (HTMLParagraphElementImpl::mapToEntry): (HTMLMarqueeElementImpl::mapToEntry):
  • khtml/html/html_blockimpl.h:
  • khtml/html/html_elementimpl.cpp: (HTMLNamedAttrMapImpl::declCount): (HTMLNamedAttrMapImpl::mapsEquivalent): (HTMLElementImpl::attributeChanged): (HTMLElementImpl::mapToEntry):
  • khtml/html/html_elementimpl.h: (DOM::HTMLElementImpl::isMappedAttribute):
  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::mapToEntry):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::mapToEntry):
  • khtml/html/html_imageimpl.h:
  • khtml/html/html_inlineimpl.cpp: (HTMLBRElementImpl::mapToEntry): (HTMLFontElementImpl::mapToEntry):
  • khtml/html/html_inlineimpl.h:
  • khtml/html/html_listimpl.cpp: (HTMLUListElementImpl::mapToEntry): (HTMLOListElementImpl::mapToEntry): (HTMLLIElementImpl::mapToEntry):
  • khtml/html/html_listimpl.h:
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::mapToEntry): (HTMLEmbedElementImpl::mapToEntry): (HTMLObjectElementImpl::mapToEntry):
  • khtml/html/html_objectimpl.h:
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::mapToEntry): (HTMLTablePartElementImpl::mapToEntry): (HTMLTableCellElementImpl::mapToEntry): (HTMLTableColElementImpl::mapToEntry): (HTMLTableCaptionElementImpl::mapToEntry):
  • khtml/html/html_tableimpl.h:
  • khtml/rendering/render_object.cpp: (RenderObject::setStyle):
  • khtml/rendering/render_style.cpp: (m_affectedByAttributeSelectors): (RenderStyle::RenderStyle):
  • khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::pseudoState): (khtml::RenderStyle::setPseudoState): (khtml::RenderStyle::affectedByAttributeSelectors): (khtml::RenderStyle::setAffectedByAttributeSelectors):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl):
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::usesSiblingRules): (DOM::DocumentImpl::setUsesSiblingRules):
5:56 PM Changeset in webkit [6513] by cblu
  • 6 edits in trunk/WebKit
  • Made WebArchive and WebResource conform to NSCoding and NSCopying.

Reviewed by rjw.

  • DOM.subproj/WebDOMOperations.h: added header doc comment for WebArchive methods
  • WebView.subproj/WebArchive.h:
  • WebView.subproj/WebArchive.m: (-[WebArchive initWithCoder:]): new (-[WebArchive encodeWithCoder:]): new (-[WebArchive copyWithZone:]): new
  • WebView.subproj/WebResource.h:
  • WebView.subproj/WebResource.m: (-[WebResource init]): new (-[WebResource initWithData:URL:MIMEType:textEncodingName:frameName:]): call [self init] (-[WebResource initWithCoder:]): new (-[WebResource encodeWithCoder:]): new (-[WebResource copyWithZone:]): new
3:49 PM Changeset in webkit [6512] by darin
  • 6 edits in trunk/WebCore

Reviewed by Chris.

  • another step of refinement on the reinterpret_cast stuff; now it's a compile-time error if you do it wrong
  • fixed a couple of storage leaks
  • kwq/DOMInternal.h: Added new DOM_cast template function. Like reinterpret_cast, but a compile-time error if you use it with the wrong parameters. Also added type-safe versions of the wrapper functions that do the DOM_cast automatically.
  • kwq/DOMInternal.mm: (getDOMWrapperImpl): Changed name and parameter type as part of above change. (addDOMWrapperImpl): Ditto. (removeDOMWrapper): Ditto.
  • kwq/DOM.mm: Use the new DOM_cast instead of reinterpret_cast, and the new DOM wrapper calls that do the cast automatically.
  • kwq/DOM-CSS.mm: More of the same. (-[DOMCSSStyleSheet dealloc]): Added override to deref, fixes leak.
  • kwq/DOMHTML.mm: More of the same. (-[DOMHTMLCollection dealloc]): Added override to deref, fixes leak. (-[DOMHTMLOptionsCollection dealloc]): Added override to deref, fixes theoretical leak.
3:40 PM Changeset in webkit [6511]
  • 52 copies
    2 deletes in tags/WebCore-125~6~4

This commit was manufactured by cvs2svn to create tag
'WebCore-125~6~4'.

3:40 PM Changeset in webkit [6510]
  • 62 copies
    1 delete in branches/SecurityUpdate-10~3~4-branch

This commit was manufactured by cvs2svn to create branch
'SecurityUpdate-10~3~4-branch'.

3:40 PM Changeset in webkit [6509]
  • 62 copies
    1 delete in tags/SecurityUpdate-10~3~4-anchor

This commit was manufactured by cvs2svn to create tag
'SecurityUpdate-10~3~4-anchor'.

3:40 PM Changeset in webkit [6508] by vicki
  • 2 edits in branches/Safari-1-2-branch/WebCore

bump WebCore version number to 125.6.4

2:44 PM Changeset in webkit [6507] by sullivan
  • 4 edits in trunk/WebKit

A little bit more progress in wiring up the font panel.

Reviewed by Ken.

  • WebView.subproj/WebViewInternal.h: put _updateFontPanel here. Also moved _isLoading here, since it was already in a category named WebInternal
  • WebView.subproj/WebView.m: (-[WebView _isLoading]): moved into WebInternal category implementation (_textAttributesFromStyle): changed from method to function (_fontFromStyle): added, guts not filled in yet (-[WebView _updateFontPanel]): now calls these two functions (but results are always nil) (-[WebView setSelectedDOMRange:affinity:]): remove call to _updateFontPanel here since it's now called in the proper bottleneck
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge postDidChangeNotification]): call -[WebView _updateFontPanel] in addition to sending notification (-[WebBridge postDidChangeSelectionNotification]): ditto
1:05 PM Changeset in webkit [6506] by sullivan
  • 4 edits in trunk/WebKit

WebKit:

  • fixed these bugs: <rdar://problem/3636570>: "API: [WebPreferences tabsToLinks] should be public API" <rdar://problem/3610597>: "API: could turn "stealth browsing" preference into API"

Reviewed by Darin.

I just moved the declarations and implementations from one place to another.
(No clients in WebKit needed their #imports updated.) This confused cvs diff quite a bit.

  • WebView.subproj/WebPreferences.h:
  • WebView.subproj/WebPreferences.m: (-[WebPreferences setTabsToLinks:]): (-[WebPreferences tabsToLinks]): (-[WebPreferences setPrivateBrowsingEnabled:]): (-[WebPreferences privateBrowsingEnabled]): (-[WebPreferences _pageCacheSize]): (-[WebPreferences _objectCacheSize]): (-[WebPreferences _backForwardCacheExpirationInterval]):
  • WebView.subproj/WebPreferencesPrivate.h:

WebBrowser:

  • fixed up #imports for WebPreferencesPrivate

Reviewed by Darin.

  • AppController.m: removed #import <WebKit/WebPreferencesPrivate.h>
  • BrowserWindowController.m: replaced #import <WebKit/WebPreferencesPrivate.h> with #import <WebKit/WebPreferences.h>
  • DownloadProgressEntry.m: ditto
  • FormCompletionController.m: ditto
  • Preferences.subproj/AdvancedPreferences.m: removed #import <WebKit/WebPreferencesPrivate.h>
12:52 PM Changeset in webkit [6505] by hyatt
  • 2 edits in trunk/WebKit

Cut the time spent on an operation inside widthForNextCharacter from 17% of the function time down to less than
5% merely by adding a check for non-zero letter-spacing (thus avoiding double precision math in the
common case where we just add 0 between letters).

Reviewed by rjw

  • WebCoreSupport.subproj/WebTextRenderer.m: (widthForNextCharacter):
11:45 AM Changeset in webkit [6504] by sullivan
  • 2 edits in trunk/WebKit

Initial plumbing to get the font panel to be updated from an editable
WebView.

Reviewed by Ken.

  • WebView.subproj/WebView.m: (-[WebView _textAttributesFromStyle:]): new dummy method, will need implementation (-[WebView _updateFontPanel]): new method, sets the font shown in the font panel from the current selection. Lots of placeholder stuff. (-[WebView setSelectedDOMRange:affinity:]): call _updateFontPanel here for now.
11:12 AM Changeset in webkit [6503] by darin
  • 3 edits
    1 delete in trunk/WebCore

Reviewed by Chris.

  • fixed reinterpret_cast mistakes and some style issues in DOM implementation
  • kwq/DOM-CSS.mm: (-[DOMCSSStyleRule _styleRuleImpl]): Fix broken reinterpret_cast; you must reinterpret_cast back to the class you reinterpret_casted from, not to a derived class. (-[DOMCSSMediaRule _mediaRuleImpl]): Ditto. (-[DOMCSSFontFaceRule _fontFaceRuleImpl]): Ditto. (-[DOMCSSPageRule _pageRuleImpl]): Ditto. (-[DOMCSSImportRule _importRuleImpl]): Ditto. (-[DOMCSSCharsetRule _importRuleImpl]): Ditto.
  • kwq/DOMHTML.mm: (-[DOMHTMLOptionsCollection length]): Put in an "unimplemented" version instead of leaving out the class implementation altogether. (-[DOMHTMLOptionsCollection setLength:]): Ditto. (-[DOMHTMLOptionsCollection item:]): Ditto. (-[DOMHTMLOptionsCollection namedItem:]): Ditto. (+[DOMHTMLElement _elementWithImpl:]): Corrected this implementation. The wrapper must use a standard node wrapper, since this is a subclass of DOMNode. Also moved into a separate category so it gets checked against the declarations above. (-[DOMHTMLElement _HTMLElementImpl]): Fix broken reinterpret_cast. (-[DOMHTMLHtmlElement _HTMLHtmlElementImpl]): Ditto. (-[DOMHTMLHeadElement _headElementImpl]): Ditto. (-[DOMHTMLLinkElement _linkElementImpl]): Ditto. (-[DOMHTMLTitleElement _titleElementImpl]): Ditto. (-[DOMHTMLMetaElement _metaElementImpl]): Ditto. (-[DOMHTMLBaseElement _baseElementImpl]): Ditto. (-[DOMHTMLStyleElement _styleElementImpl]): Ditto. (-[DOMHTMLBodyElement _bodyElementImpl]): Ditto. (-[DOMHTMLFormElement _formElementImpl]): Ditto. (+[DOMHTMLFormElement _formElementWithImpl:]): Another DOMNode subclass wrapper fix. (-[DOMHTMLIsIndexElement _isIndexElementImpl]): Fix broken reinterpret_cast. (-[DOMHTMLSelectElement _selectElementImpl]): Ditto. (-[DOMHTMLOptGroupElement _optGroupElementImpl]): Ditto. (-[DOMHTMLOptionElement _optionElementImpl]): Ditto. (-[DOMHTMLInputElement _inputElementImpl]): Ditto. (-[DOMHTMLTextAreaElement _textAreaElementImpl]): Ditto. (-[DOMHTMLButtonElement _buttonElementImpl]): Ditto. (-[DOMHTMLLabelElement _labelElementImpl]): Ditto. (-[DOMHTMLFieldSetElement _fieldSetElementImpl]): Ditto. (-[DOMHTMLLegendElement _legendElementImpl]): Ditto. (-[DOMHTMLUListElement _uListElementImpl]): Ditto. (-[DOMHTMLOListElement _oListElementImpl]): Ditto. (-[DOMHTMLDListElement _dListElementImpl]): Ditto. (-[DOMHTMLDirectoryElement _directoryListElementImpl]): Ditto. (-[DOMHTMLMenuElement _menuListElementImpl]): Ditto. (-[DOMHTMLLIElement _liElementImpl]): Ditto. (-[DOMHTMLQuoteElement _quoteElementImpl]): Ditto. (-[DOMHTMLDivElement _divElementImpl]): Ditto. (-[DOMHTMLParagraphElement _paragraphElementImpl]): Ditto. (-[DOMHTMLHeadingElement _headingElementImpl]): Ditto. (-[DOMHTMLPreElement _preElementImpl]): Ditto. (-[DOMHTMLBRElement _BRElementImpl]): Ditto. (-[DOMHTMLBaseFontElement _baseFontElementImpl]): Ditto. (-[DOMHTMLFontElement _fontElementImpl]): Ditto. (-[DOMHTMLHRElement _HRElementImpl]): Ditto. (-[DOMHTMLModElement _modElementImpl]): Ditto. (-[DOMHTMLAnchorElement _anchorElementImpl]): Ditto. (-[DOMHTMLImageElement _imageElementImpl]): Ditto. (-[DOMHTMLObjectElement _objectElementImpl]): Ditto. (-[DOMHTMLParamElement _paramElementImpl]): Ditto. (-[DOMHTMLAppletElement _appletElementImpl]): Ditto. (-[DOMHTMLMapElement _mapElementImpl]): Ditto. (-[DOMHTMLAreaElement _areaElementImpl]): Ditto. (-[DOMHTMLScriptElement _scriptElementImpl]): Ditto. (+[DOMHTMLTableCaptionElement _tableCaptionElementWithImpl:]): Another DOMNode subclass wrapper fix. (-[DOMHTMLTableCaptionElement _tableCaptionElementImpl]): Fix broken reinterpret_cast. (+[DOMHTMLTableSectionElement _tableSectionElementWithImpl:]): Another DOMNode subclass wrapper fix. (-[DOMHTMLTableSectionElement _tableSectionElementImpl]): Fix broken reinterpret_cast. (+[DOMHTMLTableElement _tableElementWithImpl:]): Another DOMNode subclass wrapper fix. (-[DOMHTMLTableElement _tableElementImpl]): Fix broken reinterpret_cast. (-[DOMHTMLTableColElement _tableColElementImpl]): Ditto. (-[DOMHTMLTableRowElement _tableRowElementImpl]): Ditto. (+[DOMHTMLTableCellElement _tableCellElementWithImpl:]): Another DOMNode subclass wrapper fix. (-[DOMHTMLTableCellElement _tableCellElementImpl]): Fix broken reinterpret_cast. (-[DOMHTMLFrameSetElement _frameSetElementImpl]): Ditto. (-[DOMHTMLFrameElement _frameElementImpl]): Ditto. (-[DOMHTMLIFrameElement _IFrameElementImpl]): Ditto. (-[DOMHTMLEmbedElement _embedElementImpl]): Ditto.
  • kwq/HTMLDOM.mm: Removed.
9:55 AM Changeset in webkit [6502] by kocienda
  • 11 edits in trunk

WebCore:

Reviewed by Darin

  • khtml/khtml_part.cpp: (KHTMLPart::notifySelectionChanged): Call new postDidChangeSelectionNotification function to send Cocoa notification when the selection changes. (KHTMLPart::appliedEditing): Call postDidChangeNotification to send Cocoa notification when the document changes due to editing. (KHTMLPart::unappliedEditing): Ditto. (KHTMLPart::reappliedEditing): Ditto.
  • kwq/DOMHTML.mm: (-[DOMHTMLDocument _HTMLDocumentImpl]): Fix cast to account for multiple inheritance used by the impl class.
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::postDidChangeSelectionNotification): New function. Call the bridge to post the notification. (KWQKHTMLPart::postDidChangeNotification): Ditto.
  • kwq/WebCoreBridge.h: Declare new -postDidChangeSelectionNotification and -postDidChangeNotification methods.

WebKit:

Reviewed by Darin

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge postDidChangeNotification]): Posts Cocoa notification when the document changes due to editing. (-[WebBridge postDidChangeSelectionNotification]): Posts Cocoa notification when the document selection changes.
  • WebKit.exp: Export editing notification string constants.
  • WebView.subproj/WebView.m: Define editing notification string constants. (-[WebView computedStyleForElement:pseudoElement:]): Add implementation. (-[WebView setEditingDelegate:]): Do work to set up delegate to receive notification callbacks. (-[WebView DOMDocument]): Simplify to just call the bridge DOMDocument. No need to jump through hoops here. (-[WebView insertNewline:]): Consult delegate before taking action. (-[WebView deleteBackward:]): Ditto. (-[WebView insertText:]): Ditto.
9:21 AM Changeset in webkit [6501] by darin
  • 2 edits in trunk/WebCore

Reviewed by Ken.

  • fixed <rdar://problem/3636261>: "nil-deref in selectedStylesheetSet iterating through properties in a non-view document"
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::selectedStylesheetSet): Add nil check. (DocumentImpl::setSelectedStylesheetSet): Ditto.

Apr 27, 2004:

11:42 PM Changeset in webkit [6500] by vicki
  • 3 edits in branches/Safari-1-2-branch/WebCore
  • merge fix for <rdar://problem/3634233>: innerText problem makes FedEx tracking page (and others) so slow it's effectively a hang (clone for SU) from HEAD

2004-04-25 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

<rdar://problem/3628309>: Fedex tracking page so slow it seems like a hang (site change?)
<rdar://problem/3608061>: "ATI Developer site so slow it seems like a hang"
<rdar://problem/3612130>: "Reproducible hang in JavaScript at www.tfl.gov.uk"
<rdar://problem/3626022>: "Safari was consuming > 100% CPU on dual-G5 Mac, sample shows JavaScript"
<rdar://problem/3632348>: "www.whatis.com search for "pivot table" leads to JavaScript hang"

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getValueProperty): The "text" property for anchors should be innerText, not innerHTML.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::innerText): Make sure not to include all the text after an element if it has no children.
6:32 PM Changeset in webkit [6499] by sullivan
  • 2 edits in trunk/WebKit

Fixed broken development build.

  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToLayoutAcceptable]): updated bad variable name used only in LOG statement to match recent change.
6:00 PM Changeset in webkit [6498] by rjw
  • 18 edits in trunk

WebCore:

<rdar://problem/3564519>: API: please add a way to set the media type for a WebView

Reviewed by Chris.

  • khtml/khtmlview.cpp: (KHTMLView::mediaType):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::overrideMediaType):
  • kwq/WebCoreBridge.h:

WebKit:

<rdar://problem/3279301>: API: WebKitErrorCannotFindPlugin and WebKitErrorCannotLoadPlugin should use PlugIn

<rdar://problem/3278513>: API: Need API to control the size of WebHistory

<rdar://problem/3564519>: API: please add a way to set the media type for a WebView
<rdar://problem/3565642>: API: allow a way to extend the MIME types that a WebView will display
<rdar://problem/3577693>: API: add ability to subclass WebView but still use it with Carbon

Reviewed by Chris.

  • Carbon.subproj/HIWebView.h:
  • Carbon.subproj/HIWebView.m: (HIWebViewCreate): (HIWebViewCreateWithClass): (HIWebViewConstructor):
  • History.subproj/WebHistory.h:
  • History.subproj/WebHistory.m: (-[WebHistoryPrivate setHistoryAgeInDaysLimit:]): (-[WebHistoryPrivate historyAgeInDaysLimit]): (-[WebHistoryPrivate setHistoryItemLimit:]): (-[WebHistoryPrivate historyItemLimit]): (-[WebHistoryPrivate _ageLimitDate]): (-[WebHistoryPrivate arrayRepresentation]): (-[WebHistory setHistoryItemLimit:]): (-[WebHistory historyItemLimit]): (-[WebHistory setHistoryAgeInDaysLimit:]): (-[WebHistory historyAgeInDaysLimit]):
  • History.subproj/WebHistoryPrivate.h:
  • Misc.subproj/WebKitErrors.h:
  • Misc.subproj/WebKitErrors.m: (registerErrors):
  • Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge isViewSelected:]): (-[WebBridge overrideMediaType]):
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m: (-[WebViewPrivate dealloc]): (+[WebView MIMETypesShownAsHTML]): (+[WebView setMIMETypesShownAsHTML:]): (-[WebView customUserAgent]): (-[WebView setMediaStyle:]): (-[WebView mediaStyle]):
  • WebView.subproj/WebViewPrivate.h:

WebBrowser:

<rdar://problem/3279301>: API: WebKitErrorCannotFindPlugin and WebKitErrorCannotLoadPlugin should use PlugIn

Reviewed by Chris.

  • LoadProgressMonitor.m: (-[LoadProgressMonitor webView:plugInFailedWithError:dataSource:]):
4:29 PM Changeset in webkit [6497] by hyatt
  • 5 edits in trunk/WebKit

Eliminate the preferences for timed/resource layouts. Accessing them is now taking 0.5% on the cvs-base
test, so we're just going to hardcode the values instead.

Reviewed by mjs

  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToLayoutAcceptable]): (-[WebFrame _isLoadComplete]):
  • WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): (-[WebPreferences _objectCacheSize]):
  • WebView.subproj/WebPreferencesPrivate.h:
  • WebView.subproj/WebView.m: (-[WebView _mainReceivedBytesSoFar:fromDataSource:complete:]):
3:57 PM Changeset in webkit [6496] by kocienda
  • 23 edits in trunk

WebCore:

Reviewed by Hyatt

Make selections draw in a more Cocoa-like way, where
fully-selected lines draw out to the ends of lines, and
spaces between lines are drawn with the selection color as well.

  • WebCore-combined.exp: Add _WebCoreInitializeEmptyTextGeometry symbol
  • WebCore.exp: Ditto.
  • khtml/khtml_part.cpp: (KHTMLPart::isPointInsideSelection): Marginally-related change. Fix up this function so that it works right, given my recent changes to positionForCoordinates. This fix "really" fixes the problem. Unlike my attempt to fix yesterday.
  • khtml/rendering/font.cpp: (Font::drawHighlightForText): New drawHighlightForText interface which includes extra information to draw the selection.
  • khtml/rendering/font.h: Ditto.
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::positionForCoordinates): Some minor improvements and cleanups to make this code work correctly in more cases.
  • khtml/rendering/render_block.h: Remove spurious semi-colon after namespace block.
  • khtml/rendering/render_container.cpp: (RenderContainer::positionForCoordinates): Fix typo in comment. Also, clean up one unnecessary call to absolutePosition.
  • khtml/rendering/render_image.cpp: (RenderImage::paint): Many changes to add the new selection drawing behavior.
  • khtml/rendering/render_inline.cpp: (RenderInline::positionForCoordinates): Added to help make selections work right with continuations.
  • khtml/rendering/render_inline.h: Ditto.
  • khtml/rendering/render_object.h: Give zero default argument to inlineBox() helper.
  • khtml/rendering/render_text.cpp: (InlineTextBox::paintSelection): Many changes to add the new selection drawing behavior.
  • kwq/KWQListBox.mm: (-[KWQTableView drawRow:clipRect:]): Use new WebCoreTextGeometry struct.
  • kwq/KWQPainter.h: New drawHighlightForText interface which includes extra information to draw the selection.
  • kwq/KWQPainter.mm: (QPainter::drawText): Use new WebCoreInitializeEmptyTextGeometry struct. (QPainter::drawHighlightForText): Use new WebCoreTextGeometry struct.
  • kwq/WebCoreTextRenderer.h: Declare new WebCoreTextGeometry struct.
  • kwq/WebCoreTextRendererFactory.m: (WebCoreInitializeEmptyTextGeometry): Initializer for WebCoreTextGeometry struct.

WebKit:

Reviewed by Hyatt

Make selections draw in a more Cocoa-like way, where
fully-selected lines draw out to the ends of lines, and
spaces between lines are drawn with the selection color as well.

  • Misc.subproj/WebKitNSStringExtras.m: Use new WebCoreTextGeometry struct. No change in functionality.
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawRun:style:geometry:]): Use new WebCoreTextGeometry struct. No change in functionality. (-[WebTextRenderer drawHighlightForRun:style:geometry:]): Ditto. (-[WebTextRenderer _CG_drawHighlightForRun:style:geometry:]): Many changes to add the new selection drawing behavior. (-[WebTextRenderer _CG_drawRun:style:geometry:]): Use new WebCoreTextGeometry struct. No change in functionality. (-[WebTextRenderer _ATSU_drawHighlightForRun:style:geometry:]): Many changes to add the new selection drawing behavior. (-[WebTextRenderer _ATSU_drawRun:style:geometry:]): Use new WebCoreTextGeometry struct. No change in functionality.
12:54 PM Changeset in webkit [6495] by rjw
  • 2 edits in trunk/WebCore

Don't do unnecessary string comparisons when no composite operator is
specified.

Reviewed by Hyatt.

  • kwq/KWQPainter.mm: (compositeOperatorFromString):
10:38 AM Changeset in webkit [6494] by darin
  • 5 edits in trunk/WebCore

Reviewed by Ken.

  • fixed <rdar://problem/3623694>: "top level <option> and <optgroup> labels look identical in pop-up menus; should not"
  • khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): Call appendGroupLabel instead of appendItem for group labels.
  • kwq/KWQComboBox.h: Added appendGroupLabel, private setControlSize, labelFont, setTitle, _labelFont, and make _items a QValueList<KWQListBoxItem> instead of QStringList.
  • kwq/KWQComboBox.mm: (QComboBox::QComboBox): Initializes _labelFont to nil. (QComboBox::~QComboBox): Release _labelFont. (QComboBox::setTitle): Added helper function. Uses an attributed string for group labels, and also sets the action to NULL so they are disabled. (QComboBox::appendItem): Added isLabel boolean parameter, make KWQListBoxItem, call setTitle. (QComboBox::sizeHint): Changed to handle group labels with a separate renderer to measure bolded text. (QComboBox::setCurrentItem): Changed to use setTitle helper. (QComboBox::setFont): Release _labelFont if control size changed. (QComboBox::labelFont): Compute label font lazily. (QComboBox::populateMenu): Changed to use setTitle helper.
  • kwq/KWQListBox.h: Removed excess includes, fixed comment.
Note: See TracTimeline for information about the timeline view.