Timeline
May 3, 2004:
- 3:54 PM Changeset in webkit [6533] by
-
- 2 edits in trunk/WebCore
Reviewed by Hyatt
Nifty hack to work around problem where BR's inserted at the end of a block do not
render. Since only the *last* BR has this quirk, insert two when at the end of a block.
Once done, you can't caret past the last one, so you never insert two again.
- khtml/editing/htmlediting_impl.cpp: (InputNewlineCommandImpl::doApply)
- 3:29 PM Changeset in webkit [6532] by
-
- 13 edits4 adds in trunk/WebCore
Reviewed by Ken
- fixed <rdar://problem/3091531>: "should format copied tables with tabs between cells, spreadsheet-style, for pasting to Excel"
- fixed <rdar://problem/3110002>: "Find doesn't match across formatting boundaries"
- fixed <rdar://problem/3640340>: "REGRESSION (136-137): nil-deref in KHTMLPart::setFocusNodeIfNeeded inside triple click code after repeatedly click/drag selecting text"
- fixed <rdar://problem/3640422>: "too many blank lines between paragraphs in copied text"
- khtml/dom/dom2_range.h: Added == and != operators to DOMRange.
- khtml/dom/dom2_range.cpp: (DOM::operator==): Added.
- khtml/khtml_part.cpp: (KHTMLPart::init): Don't call findTextBegin any more; it's now not used at all in WebCore. (KHTMLPart::clear): Don't call findTextBegin any more. Also don't set up the load statistics variables. (KHTMLPart::findTextNext): Roll out APPLE_CHANGES; this function is no longer used in WebCore any more and instead the entire thing is compiled out. (KHTMLPart::text): Reimplement this by calling one of the new text operations. All the interesting parts were moved into the TextIterator class. (KHTMLPart::setFocusNodeIfNeeded): Add a check for nil; this is the fix for 364030.
- khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): Put m_findPos, m_findNode, m_overURL, m_overURLTarget, m_scrollTimer, m_loadedObjects, m_totalObjectCount, and m_jobPercent inside !APPLE_CHANGES.
- khtml/xml/dom_selection.h: Replaced uses of 4-character tabs with spaces. (DOM::Selection::Selection): Added a constructor that takes a DOM range. (DOM::Selection::operator=): Overloaded operator= for DOM range and position. This is slightly more efficient than letting a second Selection object be constructed.
- khtml/xml/dom_selection.cpp: Replaced uses of 4-character tabs with spaces. (DOM::Selection::Selection): Added a constructor that takes a DOM range.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): Reimplement find so it uses the new text operations function for finding.
- khtml/misc/khtml_text_operations.h:
- khtml/misc/khtml_text_operations.cpp:
- WebCore.pbproj/project.pbxproj: Added new text iterator classes that do the heavy lifting.
- 10:53 AM Changeset in webkit [6531] by
-
- 2 edits in trunk/WebCore
Make sure that XML processing instructions set themselves as the parent node of the stylesheets they load,
so that they will get stylesheetLoaded() notifications when @imported stylesheets are contained inside the
sheet.
Reviewed by cblu
- khtml/xml/dom_xmlimpl.cpp: (ProcessingInstructionImpl::setStyleSheet):
May 2, 2004:
- 9:13 AM Changeset in webkit [6530] by
-
- 2 edits in trunk/WebKit
Reviewed by Ken.
- fixed <rdar://problem/3640419>: "_webkit_stringByReplacingValidPercentEscapes does not handle %00 properly"
- Misc.subproj/WebNSURLExtras.m: (-[NSString _webkit_stringByReplacingValidPercentEscapes]): Use the function in NSURL instead of implementing our own here.
Apr 30, 2004:
- 4:19 PM Changeset in webkit [6529] by
-
- 2 edits in trunk/JavaScriptCore
Asking an NSInvocation for it's return value when return type
is void throws an exception. Added check for void return types
to avoid this exception.
Reviewed by Ken.
- bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod):
- 4:16 PM Changeset in webkit [6528] by
-
- 2 edits in trunk/WebCore
Fixed: <rdar://problem/3543662>: HITLIST-137: REGRESSION: reproducible hang copying all text at Dave's blog, and other pages
Reviewed by dave.
- khtml/xml/dom2_rangeimpl.cpp: (RangeImpl::toHTMLWithOptions): when looping with containingBlock, check the value to see if it is the same
- 12:19 PM Changeset in webkit [6527] by
-
- 2 edits in trunk/WebCore
Fix for 3639530, regression on generated content pages. They crash because I forgot to null-check the style
object.
Reviewed by kocienda
- khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector):
- 10:59 AM Changeset in webkit [6526] by
-
- 2 edits in trunk/WebKit
- WebView.subproj/WebView.m: fixed deployment build breakage
- 10:30 AM Changeset in webkit [6525] by
-
- 5 edits in trunk
WebCore:
- added bridge method to get the NSFont used to render a node, to help with supporting the font panel
Reviewed by Ken.
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge renderedFontForNode:]): return nil if no renderer, otherwise return NSFont
WebKit:
- more work on getting the font panel to work with editable HTML. The font panel in Blot now correctly reflects the first selected font when the selection is at least one character long.
Reviewed by Ken.
- WebView.subproj/WebView.m: removed unfinished plumbing to support reflecting selected attributes (e.g. text color, underline) in font panel, since this doesn't work in Mail or TextEdit either. (_fontFromStyle): removed assertion for now (-[WebView _updateFontPanel]): now uses new bridge method to get the NSFont from the node, instead of trying to create an NSFont from a DOMCSSStyleDeclaration
Apr 29, 2004:
- 6:44 PM Changeset in webkit [6524] by
-
- 9 edits in trunk/JavaScriptCore
Fixed several bad problems with the ObjC bindings. In particular, conversion
to/from JavaScriptObject (soon to be WebScriptObject) was completely broken.
Reviewed by Chris.
- bindings/objc/objc_jsobject.h:
- bindings/objc/objc_jsobject.mm: (-[JavaScriptObject initWithObjectImp:KJS::root:Bindings::]): (-[JavaScriptObject KJS::]): (+[JavaScriptObject _convertValueToObjcValue:KJS::root:Bindings::]): (-[JavaScriptObject call:arguments:]): (-[JavaScriptObject evaluate:]): (-[JavaScriptObject getMember:]): (-[JavaScriptObject getSlot:]):
- bindings/objc/objc_runtime.mm: (ObjcField::valueFromInstance): (ObjcField::setValueToInstance):
- bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue):
- bindings/runtime.h:
- bindings/runtime_root.cpp: (KJS::Bindings::rootForInterpreter): (KJS::Bindings::addNativeReference): (KJS::Bindings::removeNativeReference):
- bindings/runtime_root.h:
- bindings/testbindings.mm: (-[MyFirstInterface logMessage:]): (-[MyFirstInterface setJSObject:]): (-[MyFirstInterface callJSObject::]):
- 4:26 PM Changeset in webkit [6523] by
-
- 2 edits in trunk/WebCore
Expose summary on tables.
Reviewed by darin
- kwq/KWQAccObject.mm: (-[KWQAccObject helpText]):
- 4:08 PM Changeset in webkit [6522] by
-
- 8 edits in trunk/WebCore
Implement image maps for accessibility.
Reviewed by darin
- khtml/html/html_imageimpl.cpp: (HTMLAreaElementImpl::getRect):
- khtml/html/html_imageimpl.h:
- khtml/rendering/render_image.cpp: (RenderImage::imageMap): (RenderImage::nodeAtPoint):
- khtml/rendering/render_image.h:
- kwq/KWQAccObject.h:
- kwq/KWQAccObject.mm: (-[KWQAccObject initWithRenderer:]): (-[KWQAccObject anchorElement]): (-[KWQAccObject parentObject]): (-[KWQAccObject parentObjectUnignored]): (-[KWQAccObject addChildrenToArray:]): (-[KWQAccObject role]): (-[KWQAccObject helpText]): (-[KWQAccObject value]): (-[KWQAccObject title]): (-[KWQAccObject position]): (-[KWQAccObject size]): (-[KWQAccObject accessibilityIsIgnored]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]):
- kwq/KWQRegion.mm: (QRegion::boundingRect):
- 2:30 PM Changeset in webkit [6521] by
-
- 4 edits in trunk/WebCore
Fixed:
<rdar://problem/3631431>: web archive of .Mac welcome page renders has gaps in layout
<rdar://problem/3631470>: news.google.com web archive has a different font than the live site
Reviewed by kocienda.
- khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::determineParseMode): don't set a name on the doc type when there is no doc type in the source
- khtml/xml/dom_docimpl.cpp: (DocumentTypeImpl::toString): don't return "<!DOCTYPE>" when there is no doc type in the source
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::recursive_toHTMLWithOptions): don't escape STYLE text, don't include the end tags for document nodes just as we don't for start tags
- 1:49 PM Changeset in webkit [6520] by
-
- 3 edits in trunk/WebCore
Reviewed by Dave.
- some tweaks on image
- khtml/html/html_imageimpl.h: Remove unused noref bit and unneeded override of isURLAttribute.
- khtml/html/html_imageimpl.cpp: (HTMLAreaElementImpl::HTMLAreaElementImpl): Remove unused noref bit. (HTMLAreaElementImpl::parseHTMLAttribute): Remove parsing of noref; no need to store the bit since it has no meaning.
- 1:33 PM Changeset in webkit [6519] by
-
- 2 edits in trunk/WebKit
- more work on getting the font panel to work with editable HTML
Reviewed by Ken.
- WebView.subproj/WebView.m: (-[WebView computedStyleForElement:pseudoElement:]): convert nil pseudoElement to empty string because lower level chokes on nil (_fontFromStyle): I tried to implement this, but was thwarted by missing API, so I added a bunch of FIXMEs instead (_stylesRepresentSameFont): new function, not yet implementable (_stylesRepresentSameAttributes): new function, not yet implementable (-[WebView _updateFontPanel]): added code to get first and last element in selection, and to use NodeIterator to walk through the entire selection to see if more than one font or set of attributes is in use. However, createNodeIterator is declared in DOMTraversal.h but not actually defined anywhere, so I had to prevent this code from actually being called.
- 11:52 AM Changeset in webkit [6518] by
-
- 3 edits in trunk/WebCore
- Change the role of links from AXButton to AXLink.
- Add support for list markers using a new role, AXListMarker.
Reviewed by kocienda
- khtml/rendering/render_list.h: (khtml::RenderListMarker::text):
- kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject roleDescription]): (-[KWQAccObject value]): (-[KWQAccObject accessibilityIsIgnored]):
- 9:20 AM Changeset in webkit [6517] by
-
- 2 edits in trunk/WebCore
Reviewed by Ken.
- fixed <rdar://problem/3636566>: "space bar on a form button hits default button instead (autorestore.apple.com)"
- khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::defaultEventHandler): Remove special handling for space, falling back to default AppKit behavior. Change enter handling to click the form element itself in the case of elements other than text input ones.
- 8:24 AM Changeset in webkit [6516] by
-
- 2 edits in trunk/WebCore
Reviewed by Ken.
- fixed <rdar://problem/3636673>: "unrepro nil-deref crash in KHTMLPart::frameDetached() (espn.com)"
- kwq/KWQKHTMLPart.mm: (KHTMLPart::frameDetached): Check for nil.
Note:
See TracTimeline
for information about the timeline view.
