⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 4, 2004:

5:16 PM Changeset in webkit [6540] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3641331, make sure <th> elements don't reset text-align to center if they inherit a specified
value.

Also remove the styles from <abbr> and <acronym>.

Reviewed by darin

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::adjustRenderStyle):
  • khtml/css/html4.css:
  • khtml/css/quirks.css:
4:43 PM Changeset in webkit [6539] by kocienda
  • 4 edits in trunk/WebCore

Reviewed by Hyatt

Fix for behavior which extends selection drawing to beginning and end of blocks.
I added this feature a few days ago, but my checks to see if the extension should
be done was naive: Is first or last item in root line box selected? Clearly this
needs to be "selection is *beyond* first or last item in root line box. Done.

  • khtml/rendering/render_image.cpp: (RenderImage::paint): Add selectionState() == SelectionInside check.
  • khtml/rendering/render_text.cpp: (InlineTextBox::paintSelection): Constrain passed-in offsets to be relative to box. Use passed-in offsets to check whether selection extends beyond this box. Also, now passes in flag to tell whether the whole RenderText has selectionState() == SelectionInside (in which case you always want to extend). (RenderText::paint): Remove box offset constraining from here. Now done in above function.
  • khtml/rendering/render_text.h: Modify paintSelection interface to add selectionState() == SelectionInside flag.
4:31 PM Changeset in webkit [6538] by kocienda
  • 1 edit
    24 adds in trunk

Reviewed by me

Added layout tests for DOM traversal objects.

  • layout-tests/traversal/node-iterator-001-expected.txt: Added.
  • layout-tests/traversal/node-iterator-001.html: Added.
  • layout-tests/traversal/node-iterator-002-expected.txt: Added.
  • layout-tests/traversal/node-iterator-002.html: Added.
  • layout-tests/traversal/node-iterator-003-expected.txt: Added.
  • layout-tests/traversal/node-iterator-003.html: Added.
  • layout-tests/traversal/node-iterator-004-expected.txt: Added.
  • layout-tests/traversal/node-iterator-004.html: Added.
  • layout-tests/traversal/node-iterator-005-expected.txt: Added.
  • layout-tests/traversal/node-iterator-005.html: Added.
  • layout-tests/traversal/node-iterator-006-expected.txt: Added.
  • layout-tests/traversal/node-iterator-006.html: Added.
  • layout-tests/traversal/node-iterator-007-expected.txt: Added.
  • layout-tests/traversal/node-iterator-007.html: Added.
  • layout-tests/traversal/traversal.js: Added.
  • layout-tests/traversal/tree-walker-001-expected.txt: Added.
  • layout-tests/traversal/tree-walker-001.html: Added.
  • layout-tests/traversal/tree-walker-002-expected.txt: Added.
  • layout-tests/traversal/tree-walker-002.html: Added.
  • layout-tests/traversal/tree-walker-003-expected.txt: Added.
  • layout-tests/traversal/tree-walker-003.html: Added.
  • layout-tests/traversal/tree-walker-004-expected.txt: Added.
  • layout-tests/traversal/tree-walker-004.html: Added.
4:30 PM Changeset in webkit [6537] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Hyatt

  • khtml/xml/dom2_traversalimpl.cpp: (DOM::NodeIteratorImpl::nextNode): Change to make NodeIterators behave like the spec in that reference node is null until you iterate the first time. (DOM::NodeIteratorImpl::previousNode): Ditto.
3:38 PM Changeset in webkit [6536] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by me

  • WebCore.pbproj/project.pbxproj: Backed out unintentional change.
3:38 PM Changeset in webkit [6535] by kocienda
  • 22 edits in trunk

WebCore:

Reviewed by Hyatt

Implemented DOM traversal objects, NodeIterator and TreeWalker.

  • WebCore-combined.exp: Regenerate
  • WebCore.exp: Export DOMNodeFilter protocol
  • khtml/dom/dom2_traversal.cpp: Completed half-done implementation pulled from KDE tree.
  • khtml/dom/dom2_traversal.h: Ditto.
  • khtml/dom/dom_doc.cpp: (DOM::Document::createNodeIterator): Ditto. (DOM::Document::createTreeWalker): Ditto.
  • khtml/dom/dom_doc.h: Ditto.
  • khtml/ecma/kjs_dom.cpp: (DOMDocumentProtoFunc::tryCall): Fix cases that create traversal objects.
  • khtml/ecma/kjs_traversal.cpp: (DOMNodeIterator::getValueProperty): Add referenceNode and pointerBeforeReferenceNode properties to node interator. (DOMTreeWalkerProtoFunc::tryCall): Fix typo where DOMTreeWalker::PreviousNode case called previousSibling function. (JSNodeFilterCondition::JSNodeFilterCondition): Implement JS glue class for node filter conditions. (JSNodeFilterCondition::acceptNode): Ditto.
  • khtml/ecma/kjs_traversal.h: (KJS::DOMNodeIterator::): Add ReferenceNode and PointerBeforeReferenceNode constants.
  • khtml/ecma/kjs_traversal.lut.h: (KJS::): Regenerated
  • khtml/xml/dom2_traversalimpl.cpp: Completed half-done implementation pulled from KDE tree.
  • khtml/xml/dom2_traversalimpl.h: Ditto.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createNodeIterator): Ditto. (DocumentImpl::createTreeWalker): Ditto.
  • khtml/xml/dom_docimpl.h: Ditto.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::checkAddChild): Patched due to change in isAncestor function. This was the one pre-existing caller. (NodeImpl::isAncestor): Changed so that it does not return true for itself: node->isAncestor(node) now returns false.
  • khtml/xml/dom_nodeimpl.h: Made isAncestor const.
  • kwq/DOM.mm: Implemented obj-c glue for traversal objects.
  • kwq/DOMInternal.h: Ditto.
  • kwq/DOMTraversal.h: Ditto.

WebKit:

Reviewed by Hyatt

  • DOM.subproj/DOMTraversal.h: File coppied from WebCore
9:29 AM Changeset in webkit [6534] by darin
  • 8 edits in trunk/WebCore

Reviewed by Ken.

  • fixed <rdar://problem/3642252>: "starting to drag a link and then releasing needs to activate the link if you are still over it"
  • khtml/khtmlview.cpp: (KHTMLView::viewportMouseMoveEvent): Put hysteresis check inside !APPLE_CHANGES because the Web Kit does our hysteresis checks. (KHTMLView::viewportMouseReleaseEvent): Ditto.
  • kwq/KWQApplication.h: Removed startDragDistance and globalStrut; unused.
  • kwq/KWQApplication.mm: Removed the implementations.
  • kwq/KWQPointArray.h: Removed manhattanLength; unused.
  • kwq/KWQPoint.mm: Removed the implementation.
  • WebCore-tests.exp: Removed manhattanLength.
  • WebCore-combined.exp: Regenerated.

May 3, 2004:

3:54 PM Changeset in webkit [6533] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Hyatt

Nifty hack to work around problem where BR's inserted at the end of a block do not
render. Since only the *last* BR has this quirk, insert two when at the end of a block.
Once done, you can't caret past the last one, so you never insert two again.

  • khtml/editing/htmlediting_impl.cpp: (InputNewlineCommandImpl::doApply)
3:29 PM Changeset in webkit [6532] by darin
  • 13 edits
    4 adds in trunk/WebCore

Reviewed by Ken

  • fixed <rdar://problem/3091531>: "should format copied tables with tabs between cells, spreadsheet-style, for pasting to Excel"
  • fixed <rdar://problem/3110002>: "Find doesn't match across formatting boundaries"
  • fixed <rdar://problem/3640340>: "REGRESSION (136-137): nil-deref in KHTMLPart::setFocusNodeIfNeeded inside triple click code after repeatedly click/drag selecting text"
  • fixed <rdar://problem/3640422>: "too many blank lines between paragraphs in copied text"
  • khtml/dom/dom2_range.h: Added == and != operators to DOMRange.
  • khtml/dom/dom2_range.cpp: (DOM::operator==): Added.
  • khtml/khtml_part.cpp: (KHTMLPart::init): Don't call findTextBegin any more; it's now not used at all in WebCore. (KHTMLPart::clear): Don't call findTextBegin any more. Also don't set up the load statistics variables. (KHTMLPart::findTextNext): Roll out APPLE_CHANGES; this function is no longer used in WebCore any more and instead the entire thing is compiled out. (KHTMLPart::text): Reimplement this by calling one of the new text operations. All the interesting parts were moved into the TextIterator class. (KHTMLPart::setFocusNodeIfNeeded): Add a check for nil; this is the fix for 364030.
  • khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): Put m_findPos, m_findNode, m_overURL, m_overURLTarget, m_scrollTimer, m_loadedObjects, m_totalObjectCount, and m_jobPercent inside !APPLE_CHANGES.
  • khtml/xml/dom_selection.h: Replaced uses of 4-character tabs with spaces. (DOM::Selection::Selection): Added a constructor that takes a DOM range. (DOM::Selection::operator=): Overloaded operator= for DOM range and position. This is slightly more efficient than letting a second Selection object be constructed.
  • khtml/xml/dom_selection.cpp: Replaced uses of 4-character tabs with spaces. (DOM::Selection::Selection): Added a constructor that takes a DOM range.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): Reimplement find so it uses the new text operations function for finding.
  • khtml/misc/khtml_text_operations.h:
  • khtml/misc/khtml_text_operations.cpp:
  • WebCore.pbproj/project.pbxproj: Added new text iterator classes that do the heavy lifting.
10:53 AM Changeset in webkit [6531] by hyatt
  • 2 edits in trunk/WebCore

Make sure that XML processing instructions set themselves as the parent node of the stylesheets they load,
so that they will get stylesheetLoaded() notifications when @imported stylesheets are contained inside the
sheet.

Reviewed by cblu

  • khtml/xml/dom_xmlimpl.cpp: (ProcessingInstructionImpl::setStyleSheet):

May 2, 2004:

9:13 AM Changeset in webkit [6530] by darin
  • 2 edits in trunk/WebKit

Reviewed by Ken.

  • fixed <rdar://problem/3640419>: "_webkit_stringByReplacingValidPercentEscapes does not handle %00 properly"
  • Misc.subproj/WebNSURLExtras.m: (-[NSString _webkit_stringByReplacingValidPercentEscapes]): Use the function in NSURL instead of implementing our own here.

Apr 30, 2004:

4:19 PM Changeset in webkit [6529] by rjw
  • 2 edits in trunk/JavaScriptCore

Asking an NSInvocation for it's return value when return type
is void throws an exception. Added check for void return types
to avoid this exception.

Reviewed by Ken.

  • bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod):
4:16 PM Changeset in webkit [6528] by cblu
  • 2 edits in trunk/WebCore

Fixed: <rdar://problem/3543662>: HITLIST-137: REGRESSION: reproducible hang copying all text at Dave's blog, and other pages

Reviewed by dave.

  • khtml/xml/dom2_rangeimpl.cpp: (RangeImpl::toHTMLWithOptions): when looping with containingBlock, check the value to see if it is the same
12:19 PM Changeset in webkit [6527] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3639530, regression on generated content pages. They crash because I forgot to null-check the style
object.

Reviewed by kocienda

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector):
10:59 AM Changeset in webkit [6526] by sullivan
  • 2 edits in trunk/WebKit
  • WebView.subproj/WebView.m: fixed deployment build breakage
10:30 AM Changeset in webkit [6525] by sullivan
  • 5 edits in trunk

WebCore:

  • added bridge method to get the NSFont used to render a node, to help with supporting the font panel

Reviewed by Ken.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge renderedFontForNode:]): return nil if no renderer, otherwise return NSFont

WebKit:

  • more work on getting the font panel to work with editable HTML. The font panel in Blot now correctly reflects the first selected font when the selection is at least one character long.

Reviewed by Ken.

  • WebView.subproj/WebView.m: removed unfinished plumbing to support reflecting selected attributes (e.g. text color, underline) in font panel, since this doesn't work in Mail or TextEdit either. (_fontFromStyle): removed assertion for now (-[WebView _updateFontPanel]): now uses new bridge method to get the NSFont from the node, instead of trying to create an NSFont from a DOMCSSStyleDeclaration
Note: See TracTimeline for information about the timeline view.