Timeline



May 8, 2004:

9:55 PM Changeset in webkit [6562] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Dave.

  • change things around so extremely hot TokenizerString::current() method doesn't have to do any work. It's cheaper to maintain the relevant state than to always compute it.
  • khtml/misc/stringit.h: (khtml::TokenizerString::TokenizerString): Initialize m_currentChar (khtml::TokenizerString::push): update m_currentChar (khtml::TokenizerString::advance): ditto (khtml::TokenizerString::current): return m_currentChar
  • khtml/misc/stringit.cpp: (khtml::TokenizerString::clear): update m_currentChar (khtml::TokenizerString::append): update m_currentChar (khtml::TokenizerString::prepend): update m_currentChar

May 7, 2004:

7:38 PM Changeset in webkit [6561] by gramps
  • 2 edits in trunk/WebCore

Reviewed by Dave.

Fixed minor, edge-case regression in KEYGEN RSA logic caused by Dave's
"atomic string" patch back in January.

  • khtml/html/html_formimpl.cpp: (HTMLKeygenElementImpl::encoding):
3:31 PM Changeset in webkit [6560]
  • 2 copies
    3 deletes in tags/JavaScriptCore-139~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-139~1'.

3:31 PM Changeset in webkit [6559] by vicki
  • 2 edits in trunk/JavaScriptCore

Reviewed by darin.

Turn off GC since it uses ppc only instructions (which breaks
the B&I build).

  • kjs/value.h: set USE_CONSERVATIVE_GC to 0
11:10 AM Changeset in webkit [6558] by vicki
  • 3 edits in trunk

set version number to 140u. the tree is open!

11:03 AM Changeset in webkit [6557]
  • 3 copies in tags/Safari-139

This commit was manufactured by cvs2svn to create tag 'Safari-139'.

11:03 AM Changeset in webkit [6556] by vicki
  • 6 edits in trunk

Safari-139 stamp

9:51 AM Changeset in webkit [6555] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Darin.

  • two trivial changes for a 1% speedup, thanks to Shark
  • khtml/dom/dom_string.cpp:
  • khtml/dom/dom_string.h: (DOM::DOMString::~DOMString): inline this method because it's hot and the function call overhead was very costly.
  • WebCore.pbproj/project.pbxproj: Add -falign-loops=16 optimization flag, as suggested by Shark.
9:50 AM Changeset in webkit [6554] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • add -funroll-loops=16 compiler option for approx .5% speedup on HTML iBench and .5-1% speedup on JS iBench.

May 6, 2004:

3:50 PM Changeset in webkit [6553] by cblu
  • 3 edits in trunk/WebCore

Added alpha to DOMRGBColor as an extension.

Reviewed by dave.

  • kwq/DOM-CSS.mm: (-[DOMRGBColor alpha]): new
  • kwq/DOMExtensions.h:
3:04 PM Changeset in webkit [6552] by hyatt
  • 2 adds in trunk/LayoutTests/fast/text/whitespace

Add layout test for pres and brs.

3:01 PM Changeset in webkit [6551] by hyatt
  • 2 edits in trunk/WebCore

Fix whitespace rendering for brs inside pres. The bug is 3640711.

Reviewed by kocienda

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren): (khtml::RenderBlock::findNextLineBreak):
2:41 PM Changeset in webkit [6550] by cblu
  • 2 edits in trunk/WebKit
  • DOM.subproj/WebDOMOperations.h: improved a header doc comment

May 5, 2004:

11:41 PM Changeset in webkit [6549] by mjs
  • 14 edits in trunk

JavaScriptCore:

Reviewed by Darin.

Enable full conservative GC mode in addition to test mode. When
conservative GC is enabled, we now get an 11% speed improvement on
the iBench. Also fix some spots I missed before.

Specific noteworth changes:

  • kjs/collector.cpp: (KJS::Collector::markStackObjectsConservatively): Check possible cell pointers for 8-byte aligment and verify they are not 0.
  • kjs/protected_values.cpp: (KJS::ProtectedValues::increaseProtectCount): Move null-tolerance from here... (KJS::ProtectedValues::decreaseProtectCount): ...and here...
  • kjs/protect.h: (KJS::gcProtectNullTolerant): ...to here... (KJS::gcUnprotectNullTolerant): ...and here, because not all callers need the null tolerance, and doing the check is expensive.
  • kjs/protected_values.cpp: (KJS::ProtectedValues::computeHash): Replace hash function with a much faster one that is still very good.
  • kjs/protect.h: (KJS::gcProtect): (KJS::gcUnprotect): (KJS::ProtectedValue::ProtectedValue): (KJS::ProtectedValue::~ProtectedValue): (KJS::ProtectedValue::operator=): (KJS::ProtectedObject::ProtectedObject): (KJS::ProtectedObject::~ProtectedObject): (KJS::ProtectedObject::operator=): (KJS::ProtectedReference::ProtectedReference): (KJS::ProtectedReference::~ProtectedReference): (KJS::ProtectedReference::operator=):
  • kjs/protected_values.cpp: (KJS::ProtectedValues::getProtectCount): (KJS::ProtectedValues::increaseProtectCount): (KJS::ProtectedValues::decreaseProtectCount): (KJS::ProtectedValues::computeHash):
  • bindings/runtime_root.cpp: (KJS::Bindings::addNativeReference): (KJS::Bindings::removeNativeReference): (RootObject::removeAllNativeReferences):
  • bindings/runtime_root.h: (KJS::Bindings::RootObject::~RootObject): (KJS::Bindings::RootObject::setRootObjectImp):
  • kjs/collector.cpp: (KJS::Collector::allocate): (KJS::Collector::collect):
  • kjs/collector.h:
  • kjs/internal.cpp: (NumberImp::create): (InterpreterImp::globalInit): (InterpreterImp::globalClear): (InterpreterImp::mark):
  • kjs/list.cpp: (KJS::List::derefValues): (KJS::List::refValues): (KJS::List::append):
  • kjs/object.cpp: (KJS::ObjectImp::setInternalValue): (KJS::ObjectImp::putDirect):
  • kjs/value.cpp: (ValueImp::mark): (ValueImp::marked):
  • kjs/value.h: (KJS::ValueImp::ValueImp): (KJS::ValueImp::~ValueImp): (KJS::ValueImp::): (KJS::Value::Value): (KJS::Value::~Value): (KJS::Value::operator=):

WebCore:

Reviewed by Darin.

  • khtml/ecma/kjs_events.cpp: (JSLazyEventListener::parseCode): Make sure to protect the permanent "event" string object.
6:28 PM Changeset in webkit [6548] by beard
  • 16 edits in branches/AutoZoneGC_Branch_20040430

Changes for GC stability/compatibility.

1:50 PM Changeset in webkit [6547]
  • 3 copies in branches/AutoZoneGC_Branch_20040430

This commit was manufactured by cvs2svn to create branch
'AutoZoneGC_Branch_20040430'.

1:50 PM Changeset in webkit [6546]
  • 3 copies in tags/AutoZoneGC_Base_20040430

This commit was manufactured by cvs2svn to create tag
'AutoZoneGC_Base_20040430'.

1:50 PM Changeset in webkit [6545] by hyatt
  • 2 edits in trunk/WebCore

Fixes for 3637924, 3643356, and 3558513, all crashes in recalcStyle. Make sure the tree is always in a
sane state when removing children while changing .innerHTML.

Reviewed by darin

  • khtml/xml/dom_nodeimpl.cpp:
1:24 PM Changeset in webkit [6544] by hyatt
  • 2 adds in trunk/LayoutTests/fast/block/basic

Add quirk body height test.

1:23 PM Changeset in webkit [6543] by hyatt
  • 4 edits
    2 adds in trunk/LayoutTests/fast/table

Fixed layout tests plus added a new test.

1:21 PM Changeset in webkit [6542] by hyatt
  • 4 edits in trunk/WebCore

A collection of fixes.

(1) Fix a regression from the style sharing landing that made visited and unvisited links accidentally share.
(2) Make sure 100% height divs fill the <body> in quirks mode, even if the body has no height specified.
(3) Make sure table cell percentage heights exclude border/padding.
(4) Make sure that before flexing auto height is used for the contents of the cells.

Reviewed by darin

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::canShareStyleWithElement): (khtml::CSSStyleSelector::locateSharedStyle):
  • khtml/rendering/render_box.cpp: (RenderBox::calcPercentageHeight):
  • khtml/rendering/render_table.cpp: (RenderTable::layout): (RenderTableSection::layoutRows):
11:37 AM Changeset in webkit [6541] by cblu
  • 10 edits in trunk

Tests:

Reviewed by kocienda.

  • Blot/BlotDocument.m: (-[BlotDocument dataRepresentationOfType:]): updated to use outerHTML

WebCore:

  • DOM Extensions API tweaks
  • Implemented outerHTML

Reviewed by kocienda.

  • WebCore-combined.exp:
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::outerHTML): new (HTMLElementImpl::setOuterHTML): mew
  • khtml/html/html_elementimpl.h:
  • kwq/DOMExtensions.h: removed background methods on table and table cell since these are unnecessary conveniences
  • kwq/DOMHTML.mm: (-[DOMHTMLElement outerHTML]): new (-[DOMHTMLElement setOuterHTML:]): mew

WebKit:

  • DOM Extensions API tweaks

Reviewed by kocienda.

  • DOM.subproj/DOMExtensions.h: copied from WebCore
  • DOM.subproj/WebDOMOperations.h: added header doc comments
  • DOM.subproj/WebDOMOperations.m: (-[DOMNode _URLsFromSelectors:]): use renamed URLWithAttributeString (-[DOMDocument URLWithAttributeString:]): renamed (-[DOMHTMLTableElement _web_background]): new private method (-[DOMHTMLTableElement _subresourceURLs]): use new private method (-[DOMHTMLTableCellElement _web_background]): new private method (-[DOMHTMLTableCellElement _subresourceURLs]): use new private method

May 4, 2004:

5:16 PM Changeset in webkit [6540] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3641331, make sure <th> elements don't reset text-align to center if they inherit a specified
value.

Also remove the styles from <abbr> and <acronym>.

Reviewed by darin

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::adjustRenderStyle):
  • khtml/css/html4.css:
  • khtml/css/quirks.css:
4:43 PM Changeset in webkit [6539] by kocienda
  • 4 edits in trunk/WebCore

Reviewed by Hyatt

Fix for behavior which extends selection drawing to beginning and end of blocks.
I added this feature a few days ago, but my checks to see if the extension should
be done was naive: Is first or last item in root line box selected? Clearly this
needs to be "selection is *beyond* first or last item in root line box. Done.

  • khtml/rendering/render_image.cpp: (RenderImage::paint): Add selectionState() == SelectionInside check.
  • khtml/rendering/render_text.cpp: (InlineTextBox::paintSelection): Constrain passed-in offsets to be relative to box. Use passed-in offsets to check whether selection extends beyond this box. Also, now passes in flag to tell whether the whole RenderText has selectionState() == SelectionInside (in which case you always want to extend). (RenderText::paint): Remove box offset constraining from here. Now done in above function.
  • khtml/rendering/render_text.h: Modify paintSelection interface to add selectionState() == SelectionInside flag.
4:31 PM Changeset in webkit [6538] by kocienda
  • 1 edit
    24 adds in trunk

Reviewed by me

Added layout tests for DOM traversal objects.

  • layout-tests/traversal/node-iterator-001-expected.txt: Added.
  • layout-tests/traversal/node-iterator-001.html: Added.
  • layout-tests/traversal/node-iterator-002-expected.txt: Added.
  • layout-tests/traversal/node-iterator-002.html: Added.
  • layout-tests/traversal/node-iterator-003-expected.txt: Added.
  • layout-tests/traversal/node-iterator-003.html: Added.
  • layout-tests/traversal/node-iterator-004-expected.txt: Added.
  • layout-tests/traversal/node-iterator-004.html: Added.
  • layout-tests/traversal/node-iterator-005-expected.txt: Added.
  • layout-tests/traversal/node-iterator-005.html: Added.
  • layout-tests/traversal/node-iterator-006-expected.txt: Added.
  • layout-tests/traversal/node-iterator-006.html: Added.
  • layout-tests/traversal/node-iterator-007-expected.txt: Added.
  • layout-tests/traversal/node-iterator-007.html: Added.
  • layout-tests/traversal/traversal.js: Added.
  • layout-tests/traversal/tree-walker-001-expected.txt: Added.
  • layout-tests/traversal/tree-walker-001.html: Added.
  • layout-tests/traversal/tree-walker-002-expected.txt: Added.
  • layout-tests/traversal/tree-walker-002.html: Added.
  • layout-tests/traversal/tree-walker-003-expected.txt: Added.
  • layout-tests/traversal/tree-walker-003.html: Added.
  • layout-tests/traversal/tree-walker-004-expected.txt: Added.
  • layout-tests/traversal/tree-walker-004.html: Added.
4:30 PM Changeset in webkit [6537] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Hyatt

  • khtml/xml/dom2_traversalimpl.cpp: (DOM::NodeIteratorImpl::nextNode): Change to make NodeIterators behave like the spec in that reference node is null until you iterate the first time. (DOM::NodeIteratorImpl::previousNode): Ditto.
3:38 PM Changeset in webkit [6536] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by me

  • WebCore.pbproj/project.pbxproj: Backed out unintentional change.
3:38 PM Changeset in webkit [6535] by kocienda
  • 22 edits in trunk

WebCore:

Reviewed by Hyatt

Implemented DOM traversal objects, NodeIterator and TreeWalker.

  • WebCore-combined.exp: Regenerate
  • WebCore.exp: Export DOMNodeFilter protocol
  • khtml/dom/dom2_traversal.cpp: Completed half-done implementation pulled from KDE tree.
  • khtml/dom/dom2_traversal.h: Ditto.
  • khtml/dom/dom_doc.cpp: (DOM::Document::createNodeIterator): Ditto. (DOM::Document::createTreeWalker): Ditto.
  • khtml/dom/dom_doc.h: Ditto.
  • khtml/ecma/kjs_dom.cpp: (DOMDocumentProtoFunc::tryCall): Fix cases that create traversal objects.
  • khtml/ecma/kjs_traversal.cpp: (DOMNodeIterator::getValueProperty): Add referenceNode and pointerBeforeReferenceNode properties to node interator. (DOMTreeWalkerProtoFunc::tryCall): Fix typo where DOMTreeWalker::PreviousNode case called previousSibling function. (JSNodeFilterCondition::JSNodeFilterCondition): Implement JS glue class for node filter conditions. (JSNodeFilterCondition::acceptNode): Ditto.
  • khtml/ecma/kjs_traversal.h: (KJS::DOMNodeIterator::): Add ReferenceNode and PointerBeforeReferenceNode constants.
  • khtml/ecma/kjs_traversal.lut.h: (KJS::): Regenerated
  • khtml/xml/dom2_traversalimpl.cpp: Completed half-done implementation pulled from KDE tree.
  • khtml/xml/dom2_traversalimpl.h: Ditto.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createNodeIterator): Ditto. (DocumentImpl::createTreeWalker): Ditto.
  • khtml/xml/dom_docimpl.h: Ditto.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::checkAddChild): Patched due to change in isAncestor function. This was the one pre-existing caller. (NodeImpl::isAncestor): Changed so that it does not return true for itself: node->isAncestor(node) now returns false.
  • khtml/xml/dom_nodeimpl.h: Made isAncestor const.
  • kwq/DOM.mm: Implemented obj-c glue for traversal objects.
  • kwq/DOMInternal.h: Ditto.
  • kwq/DOMTraversal.h: Ditto.

WebKit:

Reviewed by Hyatt

  • DOM.subproj/DOMTraversal.h: File coppied from WebCore
9:29 AM Changeset in webkit [6534] by darin
  • 8 edits in trunk/WebCore

Reviewed by Ken.

  • fixed <rdar://problem/3642252>: "starting to drag a link and then releasing needs to activate the link if you are still over it"
  • khtml/khtmlview.cpp: (KHTMLView::viewportMouseMoveEvent): Put hysteresis check inside !APPLE_CHANGES because the Web Kit does our hysteresis checks. (KHTMLView::viewportMouseReleaseEvent): Ditto.
  • kwq/KWQApplication.h: Removed startDragDistance and globalStrut; unused.
  • kwq/KWQApplication.mm: Removed the implementations.
  • kwq/KWQPointArray.h: Removed manhattanLength; unused.
  • kwq/KWQPoint.mm: Removed the implementation.
  • WebCore-tests.exp: Removed manhattanLength.
  • WebCore-combined.exp: Regenerated.
Note: See TracTimeline for information about the timeline view.