Timeline



May 12, 2004:

6:01 PM Changeset in webkit [6584] by hyatt
  • 6 edits in trunk/WebCore

Improve layout scheduling. Make sure no layouts can be scheduled until over a minimum delay threshold.

  • khtml/khtmlview.cpp: (KHTMLView::scheduleRelayout):
  • khtml/rendering/render_frames.cpp: (RenderPart::updateWidgetPositions):
  • khtml/rendering/render_text.cpp: (RenderText::paint):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::close): (DocumentImpl::setParsing): (DocumentImpl::shouldScheduleLayout): (DocumentImpl::minimumLayoutDelay):
  • khtml/xml/dom_docimpl.h:
5:50 PM Changeset in webkit [6583] by rjw
  • 1 edit in trunk/WebKit/WebView.subproj/WebHTMLView.m

Updated CarbonWeb example to include work-arounds for printing problems. The
work-around makes use of SPI, unfortunate, but necessary.

5:17 PM Changeset in webkit [6582] by cblu
  • 3 edits in trunk/WebKit

WebKit:

Fixed:
<rdar://problem/3633296>: (Japanese input is not working properly in Carbon Web Kit applications (including CarbonWeb))
<rdar://problem/3631390>: (can't toggle between Input Methods (IMEs) using cmd-space in Carbon Web Kit applications)

Reviewed by rjw.

  • Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter sendSuperEvent:]): call [NSInputContext processInputKeyBindings:inEvent] just as NSApp does
  • Carbon.subproj/HIWebView.m: (HIWebViewEventHandler): [NSApp setWindowsNeedUpdate:YES] must be called before events so that ActivateTSMDocument is called to set an active document. Without an active document, TSM will use a default document which uses a bottom-line input window which we don't want.

WebKitExamples:

Workaround for:
<rdar://problem/3633296>: (Japanese input is not working properly in Carbon Web Kit applications (including CarbonWeb))
<rdar://problem/3631390>: (can't toggle between Input Methods (IMEs) using cmd-space in Carbon Web Kit applications)

Reviewed by rjw.

  • CarbonWeb/CarbonWeb.pbproj/project.pbxproj: xcode project update
  • CarbonWeb/TWebWindow.cp:
    • [NSApp setWindowsNeedUpdate:YES] must be called before events so that ActivateTSMDocument is called to set an active document. Without an active document, TSM will use a default document which uses a bottom-line input window which we don't want.
    • use Larry's command-space workaround for cmd-space toggling
2:30 PM Changeset in webkit [6581] by rjw
  • 4 edits
    1 add in trunk

Changes to plugin scripting extensions.`

May 11, 2004:

7:05 PM Changeset in webkit [6580] by cblu
  • 20 edits in trunk

WebCore:

Support for: <rdar://problem/3616471>: (API: provide way to get from WebFrame to DOMDocument and vice versa)

Reviewed by rjw.

  • kwq/DOM.mm: (-[DOMDocument _ownerElement]): new
  • kwq/DOMInternal.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge frameElement]): new

WebKit:

Fixed:
<rdar://problem/3616537>: (API: Make WebResource, WebArchive and related API's public)
<rdar://problem/3616471>: (API: provide way to get from WebFrame to DOMDocument and vice versa)

Reviewed by rjw.

  • DOM.subproj/WebDOMOperations.h:
  • DOM.subproj/WebDOMOperations.m: (-[DOMHTMLFrameElement contentFrame]): new (-[DOMHTMLIFrameElement contentFrame]): new (-[DOMHTMLObjectElement contentFrame]): new
  • DOM.subproj/WebDOMOperationsPrivate.h:
  • Misc.subproj/WebNSImageExtras.m: (-[NSImage _web_saveAndOpen]): fixed leak
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _addSubresources:]): made private (-[WebDataSource _archiveWithMarkupString:nodes:]): handle object tags with frame content (-[WebDataSource _archiveWithCurrentState:]): renamed from _archive, now takes flag (-[WebDataSource _replaceSelectionWithArchive:]): call renamed _addSubresources (-[WebDataSource webArchive]): new (-[WebDataSource mainResource]): new (-[WebDataSource subresources]): made public (-[WebDataSource subresourceForURL:]): made public (-[WebDataSource addSubresource:]): made public
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDocumentPrivate.h:
  • WebView.subproj/WebFrame.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame _loadRequest:subresources:subframeArchives:]): call renamed _addSubresources (-[WebFrame DOMDocument]): new (-[WebFrame frameElement]): new (-[WebFrame loadArchive:]): made public
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation loadArchive]): call renamed _addSubresources
  • WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation archive]): call webArchive on WebDataSource
2:58 PM Changeset in webkit [6579] by hyatt
  • 4 adds in trunk/LayoutTests/fast/block/float

Add new layout tests for float bug fixes.

2:45 PM Changeset in webkit [6578] by hyatt
  • 10 edits in trunk/LayoutTests

Revised layout test with image and float changes.

1:29 PM Changeset in webkit [6577] by hyatt
  • 6 edits in trunk/WebCore

Fix makeChildrenNonInline so that it does not wrap floats unless an inline is actually found.

Fix block minmaxwidth to add together contiguous runs of floats.

Fix the content image loader to not destroy the image when removed from the document.

Reviewed by darin

  • ChangeLog:
  • khtml/html/html_imageimpl.cpp: (HTMLImageLoader::~HTMLImageLoader): (HTMLImageElementImpl::detach):
  • khtml/html/html_imageimpl.h: (DOM::):
  • khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::createRenderer):
  • khtml/html/html_objectimpl.h:
  • khtml/rendering/render_block.cpp: (khtml::getInlineRun): (khtml::RenderBlock::calcInlineMinMaxWidth): (khtml::RenderBlock::calcBlockMinMaxWidth):
10:30 AM Changeset in webkit [6576]
  • 6 copies
    2 deletes in tags/WebCore-139~2

This commit was manufactured by cvs2svn to create tag
'WebCore-139~2'.

10:30 AM Changeset in webkit [6575] by vicki
  • 2 edits in trunk/WebCore

fix B&I build failure caused by case sensitivity

May 10, 2004:

4:47 PM Changeset in webkit [6574] by mjs
  • 8 edits in trunk

WebCore:

Reviewed by Darin.

  • avoid redecoding animated images that are only used once for ~2.5% iBench speedup (WebCore part of fix)
  • khtml/rendering/render_image.cpp: (RenderImage::setPixmap): Maintain use count for pixmap. (RenderImage::~RenderImage): Likewise.
  • kwq/KWQPixmap.h:
  • kwq/KWQPixmap.mm: (QPixmap::increaseUseCount): Call WebCoreImageRenderer (QPixmap::decreaseUseCount): Call WebCoreImageRenderer
  • kwq/WebCoreImageRenderer.h: Prototype new protocol methods.

WebKit:

Reviewed by Darin.

  • avoid redecoding animated images that are only used once for ~2.5% iBench speedup (WebCore part of fix)
  • WebCoreSupport.subproj/WebImageRenderer.h:
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer increaseUseCount]): (-[WebImageRenderer decreaseUseCount]): (-[WebImageRenderer retainOrCopyIfNeeded]):
4:42 PM Changeset in webkit [6573] by hyatt
  • 1 edit in trunk/WebCore/khtml/xml/dom_docimpl.cpp

Back out the optimization since it will break the ibench cheat.

4:34 PM Changeset in webkit [6572] by mjs
  • 2 edits in trunk/WebKit

Fix build.

  • WebView.subproj/WebFrame.m:
4:28 PM Changeset in webkit [6571] by hyatt
  • 1 edit in trunk/WebCore/khtml/xml/dom_docimpl.cpp

Fix build failure

4:21 PM Changeset in webkit [6570] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Ken.

  • avoid messing with undo manager needlessly for ~1% HTML iBench speedup
  • WebCoreSupport.subproj/WebBridge.h:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge registerCommandForUndo:]): mark undo/redo item flag (-[WebBridge registerCommandForRedo:]): ditto (-[WebBridge clearUndoRedoOperations]): check flag before removing items, and clear it after removing them
4:20 PM Changeset in webkit [6569] by mjs
  • 5 edits in trunk/WebKit

Reviewed by Darin.

  • -[WebFrame childFrames] is so hot that a special internal version which avoids the copy and autorelease results in a .75% performance improvement on HTML iBench.
  • WebView.subproj/WebFramePrivate.h: Prototype new method.
  • WebView.subproj/WebFrame.m: (-[WebFrame _internalChildFrames]): New method, just returns internal value instead of copying.

(-[WebFrame _descendantFrameNamed:]): Use it
(-[WebFrame _textSizeMultiplierChanged]): likewise
(-[WebFrame _viewWillMoveToHostWindow:]): likewise
(-[WebFrame _viewDidMoveToHostWindow]): likewise
(-[WebFrame _saveDocumentAndScrollState]): likewise
(-[WebFrame _numPendingOrLoadingRequests:]): likewise
(-[WebFrame _checkLoadComplete]): Refactored this and it's two
helpers a little so we could get away with using
_internalChildFrames.
(-[WebFrame _checkLoadCompleteForThisFrame]): Renamed from
_isLoadComplete
(-[WebFrame _recursiveCheckLoadComplete]): renamed from (class
method) _recursiveCheckCompleteFromFrame:

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _defersCallbacksChanged]): Use it (-[WebDataSource isLoading]): likewise
  • WebView.subproj/WebView.m: (-[WebView _frameForDataSource:fromFrame:]): likewise (-[WebView _frameForView:fromFrame:]): likewise
4:19 PM Changeset in webkit [6568] by hyatt
  • 3 edits in trunk/WebCore

Make sure that when finished parsing if all the right conditions are met, we just go ahead and updateRendering and
layout.

Reviewed by rjw

  • khtml/khtmlview.cpp: (KHTMLView::scheduleRelayout):
2:47 PM Changeset in webkit [6567] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Dave.

  • some minor performance tweaks that together give .5% or so on the HTML iBench
  • khtml/css/css_valueimpl.h: don't use a bitfield for id and important, unpacking the bitfield is too expensive
  • kwq/KWQArrayImpl.h:
  • kwq/KWQArrayImpl.mm: (KWQArrayImpl::at): inline this method because it's so hot
  • kwq/KWQString.mm: (allocateHandle): inline this function because it's so hot (initializeHandleNodes): move this in the file so above can be inlined (allocateNode): ditto
2:29 PM Changeset in webkit [6566] by hyatt
  • 11 edits in trunk/WebCore

Move image loading to content.

Reviewed by kocienda

  • khtml/html/html_imageimpl.cpp: (m_imageComplete): (HTMLImageLoader::~HTMLImageLoader): (HTMLImageLoader::updateFromElement): (HTMLImageLoader::removedFromDocument): (HTMLImageLoader::dispatchLoadEvent): (HTMLImageLoader::notifyFinished): (HTMLImageElementImpl::HTMLImageElementImpl): (HTMLImageElementImpl::parseHTMLAttribute): (HTMLImageElementImpl::attach): (HTMLImageElementImpl::detach): (HTMLImageElementImpl::removedFromDocument): (HTMLImageElementImpl::currentImage):
  • khtml/html/html_imageimpl.h: (DOM::):
  • khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::HTMLObjectElementImpl): (HTMLObjectElementImpl::removedFromDocument): (HTMLObjectElementImpl::attach):
  • khtml/html/html_objectimpl.h:
  • khtml/misc/loader.cpp: (CachedImage::ref):
  • khtml/rendering/render_image.cpp: (RenderImage::RenderImage): (RenderImage::setImage): (RenderImage::updateAltText):
  • khtml/rendering/render_image.h: (khtml::RenderImage::getImage):
  • khtml/rendering/render_object.cpp: (RenderObject::canvas):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::dispatchImageLoadEventSoon): (DocumentImpl::removeImage): (DocumentImpl::dispatchImageLoadEventsNow):
  • khtml/xml/dom_docimpl.h:
11:05 AM Changeset in webkit [6565] by cblu
  • 2 edits in trunk/WebKit

Forgot to commit this copied header.

  • DOM.subproj/DOMExtensions.h:
9:47 AM Changeset in webkit [6564]
  • 4 copies
    2 deletes in tags/WebCore-139~1

This commit was manufactured by cvs2svn to create tag
'WebCore-139~1'.

9:47 AM Changeset in webkit [6563] by darin
  • 2 edits in trunk/WebCore

Reviewed by Vicki.

  • fixed build failure seen in B&I log (due to case sensitive file system?)
  • kwq/KWQLoader.h: Include "KWQCString.h" rather than "QCString.h". The latter was failing because the forwarding header is called "qcstring.h" and I guess B&I started building with a case sensitive file system. I could have changed this to "qcstring.h", but it seemed better to use the header's real name since we're inside KWQ here.

May 8, 2004:

9:55 PM Changeset in webkit [6562] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Dave.

  • change things around so extremely hot TokenizerString::current() method doesn't have to do any work. It's cheaper to maintain the relevant state than to always compute it.
  • khtml/misc/stringit.h: (khtml::TokenizerString::TokenizerString): Initialize m_currentChar (khtml::TokenizerString::push): update m_currentChar (khtml::TokenizerString::advance): ditto (khtml::TokenizerString::current): return m_currentChar
  • khtml/misc/stringit.cpp: (khtml::TokenizerString::clear): update m_currentChar (khtml::TokenizerString::append): update m_currentChar (khtml::TokenizerString::prepend): update m_currentChar
Note: See TracTimeline for information about the timeline view.