Context Navigation

Plugins.subproj/WebPlugin.h:
Plugins.subproj/WebPluginContainer.h:
Plugins.subproj/WebPluginController.h:
Plugins.subproj/WebPluginController.m: (-[WebPluginController startAllPlugins]): (-[WebPluginController stopAllPlugins]): (-[WebPluginController addPlugin:]): (-[WebPluginController destroyAllPlugins]): (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): (-[WebPluginController showURL:inFrame:]): (-[WebPluginController webPlugInContainerShowStatus:]): (-[WebPluginController showStatus:]): (-[WebPluginController webPlugInContainerSelectionColor]): (-[WebPluginController selectionColor]): (-[WebPluginController webFrame]):

4:58 PM Changeset in webkit [6590] by cblu

18 edits in trunk

Tests:

Updated Blot to use new API's.

Blot/BlotDocument.m: (-[BlotDocument dataRepresentationOfType:]): (-[BlotDocument webView:didFinishLoadForFrame:]):

WebCore:

Fixed: <rdar://problem/3616555>: (API: Make DOM extensions and WebKit DOM operations public)

Reviewed by rjw.

kwq/DOM.h: added DOMExtensions.h
kwq/DOMHTML.h: renamed frame on DOMHTMLTableElement to frameBorders to avoid NSView conflicts
kwq/DOMHTML.mm: (-[DOMHTMLTableElement frameBorders]): (-[DOMHTMLTableElement setFrameBorders:]):

WebKit:

Added stubs for WebView action and drag & drop customization API's
Fixed: <rdar://problem/3616555>: (API: Make DOM extensions and WebKit DOM operations public)

Reviewed by rjw.

DOM.subproj/WebDOMOperations.h: added remaining DOM operations
DOM.subproj/WebDOMOperationsPrivate.h:
Misc.subproj/WebKit.h: added new public headers
WebKit.pbproj/project.pbxproj:
WebKit.exp: added symbol for WebElementDOMNodeKey
WebView.subproj/WebUIDelegate.h: added new UI delegate methods
WebView.subproj/WebView.h: added new pasteboard related methods
WebView.subproj/WebView.m: (+[WebView URLFromPasteboard:]): new stub (+[WebView URLTitleFromPasteboard:]): new stub (-[WebView dragOperationForDraggingInfo:]): new stub (-[WebView pasteboardTypesForSelection]): new stub (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]): new stub (-[WebView pasteboardTypesForElement:]): new stub (-[WebView writeElement:withPasteboardTypes:toPasteboard:]): new stub
WebView.subproj/WebViewPrivate.h:

4:39 PM Changeset in webkit [6589] by rjw

1 add in trunk/WebKit/Plugins.subproj/WebJavaPlugIn.h

Added WebJavaPlugIn.h, fixed build problem.

4:24 PM Changeset in webkit [6588] by rjw

37 edits
2 adds in trunk

WebKit:

Changed imports of all DOM headers. DOM headers
should be imported using the normal #import <WebCore/foo.h>,
they import is modified when copied to WebKit.

Other approved API changes. Currently unimplemented.

Reviewed by Chris.

ChangeLog:
DOM.subproj/DOM.h:
DOM.subproj/DOMCSS.h:
DOM.subproj/DOMCore.h:
DOM.subproj/DOMEvents.h:
DOM.subproj/DOMExtensions.h:
DOM.subproj/DOMHTML.h:
DOM.subproj/DOMRange.h:
DOM.subproj/DOMStylesheets.h:
DOM.subproj/DOMTraversal.h:
DOM.subproj/DOMViews.h:
Plugins.subproj/WebPlugin.h:
Plugins.subproj/WebPluginContainer.h:
Plugins.subproj/WebPluginPackage.m:
Plugins.subproj/WebPluginViewFactory.h:
Plugins.subproj/WebScriptObject.h:
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebBridge pluginViewWithPackage:attributes:baseURL:]):
WebKit.exp:
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebFrameLoadDelegate.h:
WebView.subproj/WebView.h:
WebView.subproj/WebView.m: (-[WebView windowScriptObject]):
copy-webcore-files-to-webkit:

WebCore:

Changed imports of all DOM headers. DOM headers
should be imported using the normal #import <WebCore/foo.h>,
they import is modified when copied to WebKit.

Reviewed by Chris.

ChangeLog:
kwq/DOM.h:
kwq/DOMCSS.h:
kwq/DOMCore.h:
kwq/DOMEvents.h:
kwq/DOMExtensions.h:
kwq/DOMHTML.h:
kwq/DOMInternal.h:
kwq/DOMRange.h:
kwq/DOMStylesheets.h:
kwq/DOMTraversal.h:
kwq/DOMViews.h:

JavaScriptCore:

Approved API changes. Currently unimplemented.

Reviewed by Chris.

ChangeLog:
JavaScriptCore.pbproj/project.pbxproj:
bindings/objc/WebScriptObject.h: Added.
bindings/objc/WebScriptObject.mm: Added. (+[WebScriptObject throwException:]): (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject stringRepresentation]): (+[WebUndefined undefined]): (-[WebUndefined initWithCoder:]): (-[WebUndefined encodeWithCoder:]): (-[WebUndefined copyWithZone:]):

11:01 AM Changeset in webkit [6587] by kocienda

2 edits in trunk/WebCore

Reviewed by me

khtml/editing/htmlediting_impl.cpp: (khtml::ApplyStyleCommandImpl::applyStyleIfNeeded): Fix deployment build bustage. Uninitialized variable.

10:53 AM Changeset in webkit [6586] by kocienda

7 edits
1 add in trunk/WebKit

Reviewed by Kevin

Move WebKit editing APIs to public API files.

WebCoreSupport.subproj/WebBridge.m: Add WebEditingDelegate include.
WebKit.pbproj/project.pbxproj: Go Xcode!
WebView.subproj/WebDefaultEditingDelegate.m: Remove WebViewPrivate include; add WebEditingDelegate include.
WebView.subproj/WebEditingDelegate.h: Added. New file.
WebView.subproj/WebView.h: Move API-approved interfaces to this file.
WebView.subproj/WebView.m: Add WebEditingDelegate include.
WebView.subproj/WebViewPrivate.h: Move API-approved interfaces from this file.

9:41 AM Changeset in webkit [6585] by kocienda

14 edits in trunk/WebCore

WebCore:

Reviewed by Hyatt

Implemented first cut at text style change code.

khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::ApplyStyleCommand): (khtml::ApplyStyleCommand::~ApplyStyleCommand): (khtml::ApplyStyleCommand::impl): (khtml::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand): (khtml::RemoveCSSPropertyCommand::~RemoveCSSPropertyCommand): (khtml::RemoveCSSPropertyCommand::impl): (khtml::RemoveCSSPropertyCommand::styleDeclaration): (khtml::RemoveCSSPropertyCommand::property): (khtml::RemoveNodeAttributeCommand::RemoveNodeAttributeCommand): (khtml::RemoveNodeAttributeCommand::~RemoveNodeAttributeCommand): (khtml::RemoveNodeAttributeCommand::impl): (khtml::RemoveNodeAttributeCommand::element): (khtml::RemoveNodeAttributeCommand::attribute): (khtml::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand): (khtml::RemoveNodePreservingChildrenCommand::~RemoveNodePreservingChildrenCommand): (khtml::RemoveNodePreservingChildrenCommand::impl): (khtml::RemoveNodePreservingChildrenCommand::node): (khtml::SetNodeAttributeCommand::SetNodeAttributeCommand): (khtml::SetNodeAttributeCommand::~SetNodeAttributeCommand): (khtml::SetNodeAttributeCommand::impl): (khtml::SetNodeAttributeCommand::element): (khtml::SetNodeAttributeCommand::attribute): (khtml::SetNodeAttributeCommand::value):
khtml/editing/htmlediting.h: (khtml::): (khtml::ApplyStyleCommand::):

Removed a bunch of unnecessary DOM namespace qualifiers.
Fixed calls to parent(), which relied on the TreeShared interface to get a parent,
and changed to the parentNode() DOM Node call, which is more suitable given the
intention.

khtml/editing/htmlediting_impl.cpp: (khtml::CompositeEditCommandImpl::insertNodeBefore): (khtml::CompositeEditCommandImpl::insertNodeAfter): (khtml::CompositeEditCommandImpl::appendNode): (khtml::CompositeEditCommandImpl::removeNode): (khtml::CompositeEditCommandImpl::removeNodeAndPrune): (khtml::CompositeEditCommandImpl::removeNodePreservingChildren): (khtml::CompositeEditCommandImpl::splitTextNode): (khtml::CompositeEditCommandImpl::joinTextNodes): (khtml::CompositeEditCommandImpl::insertText): (khtml::CompositeEditCommandImpl::deleteText): (khtml::CompositeEditCommandImpl::replaceText): (khtml::CompositeEditCommandImpl::removeCSSProperty): (khtml::CompositeEditCommandImpl::removeNodeAttribute): (khtml::CompositeEditCommandImpl::setNodeAttribute):

Text style change command implementations.
There are a couple more parent() -> parentNode() changes in here as well.

(khtml::ApplyStyleCommandImpl::ApplyStyleCommandImpl):
(khtml::ApplyStyleCommandImpl::~ApplyStyleCommandImpl):
(khtml::ApplyStyleCommandImpl::commandID):
(khtml::ApplyStyleCommandImpl::doApply):
(khtml::ApplyStyleCommandImpl::isHTMLStyleNode):
(khtml::ApplyStyleCommandImpl::removeHTMLStyleNode):
(khtml::ApplyStyleCommandImpl::removeCSSStyle):
(khtml::ApplyStyleCommandImpl::removeCSSProperty):
(khtml::ApplyStyleCommandImpl::setNodeAttribute):
(khtml::ApplyStyleCommandImpl::removeNodeAttribute):
(khtml::ApplyStyleCommandImpl::removeNodePreservingChildren):
(khtml::ApplyStyleCommandImpl::mustExlicitlyApplyStyle):
(khtml::ApplyStyleCommandImpl::createExplicitApplyStyleNode):
(khtml::ApplyStyleCommandImpl::currentlyHasStyle):
(khtml::ApplyStyleCommandImpl::cssProperty):
(khtml::ApplyStyleCommandImpl::matchesTargetStyle):
(khtml::ApplyStyleCommandImpl::positionInsertionPoint):
(khtml::ApplyStyleCommandImpl::splitTextAtStartIfNeeded):
(khtml::ApplyStyleCommandImpl::splitTextAtEndIfNeeded):
(khtml::ApplyStyleCommandImpl::applyStyleIfNeeded):
(khtml::ApplyStyleCommandImpl::removeStyle):
(khtml::ApplyStyleCommandImpl::cloneSelection):
(khtml::ApplyStyleCommandImpl::insertFragment):
(khtml::ApplyStyleCommandImpl::applyInPlace):
(khtml::ApplyStyleCommandImpl::applyUsingFragment):
(khtml::DeleteSelectionCommandImpl::DeleteSelectionCommandImpl):
(khtml::InsertNodeBeforeCommandImpl::doApply):
(khtml::InsertNodeBeforeCommandImpl::doUnapply):
(khtml::JoinTextNodesCommandImpl::doApply):
(khtml::PasteMarkupCommandImpl::PasteMarkupCommandImpl):
(khtml::RemoveCSSPropertyCommandImpl::RemoveCSSPropertyCommandImpl):
(khtml::RemoveCSSPropertyCommandImpl::~RemoveCSSPropertyCommandImpl):
(khtml::RemoveCSSPropertyCommandImpl::commandID):
(khtml::RemoveCSSPropertyCommandImpl::doApply):
(khtml::RemoveCSSPropertyCommandImpl::doUnapply):
(khtml::RemoveNodeAttributeCommandImpl::RemoveNodeAttributeCommandImpl):
(khtml::RemoveNodeAttributeCommandImpl::~RemoveNodeAttributeCommandImpl):
(khtml::RemoveNodeAttributeCommandImpl::commandID):
(khtml::RemoveNodeAttributeCommandImpl::doApply):
(khtml::RemoveNodeAttributeCommandImpl::doUnapply):
(khtml::RemoveNodePreservingChildrenCommandImpl::RemoveNodePreservingChildrenCommandImpl):
(khtml::RemoveNodePreservingChildrenCommandImpl::~RemoveNodePreservingChildrenCommandImpl):
(khtml::RemoveNodePreservingChildrenCommandImpl::commandID):
(khtml::RemoveNodePreservingChildrenCommandImpl::doApply):
(khtml::SetNodeAttributeCommandImpl::SetNodeAttributeCommandImpl):
(khtml::SetNodeAttributeCommandImpl::~SetNodeAttributeCommandImpl):
(khtml::SetNodeAttributeCommandImpl::commandID):
(khtml::SetNodeAttributeCommandImpl::doApply):
(khtml::SetNodeAttributeCommandImpl::doUnapply):
(khtml::SplitTextNodeCommandImpl::doUnapply):
(khtml::TypingCommandImpl::insertText):

Text style change command implementations.

khtml/editing/htmlediting_impl.h: (khtml::ApplyStyleCommandImpl::): (khtml::ApplyStyleCommandImpl::removingStyle): (khtml::RemoveCSSPropertyCommandImpl::styleDeclaration): (khtml::RemoveCSSPropertyCommandImpl::property): (khtml::RemoveNodeAttributeCommandImpl::element): (khtml::RemoveNodeAttributeCommandImpl::attribute): (khtml::RemoveNodePreservingChildrenCommandImpl::node): (khtml::SetNodeAttributeCommandImpl::element): (khtml::SetNodeAttributeCommandImpl::attribute): (khtml::SetNodeAttributeCommandImpl::value):

Fixed a bug where the TreeWalker returned the current node instead
of null when an attempt was made to use the iterator to go to a
non-existent location.

khtml/xml/dom2_traversalimpl.cpp: (DOM::TreeWalkerImpl::parentNode): (DOM::TreeWalkerImpl::firstChild): (DOM::TreeWalkerImpl::lastChild): (DOM::TreeWalkerImpl::previousSibling): (DOM::TreeWalkerImpl::nextSibling): (DOM::TreeWalkerImpl::previousNode): (DOM::TreeWalkerImpl::nextNode):

A convenience.

khtml/xml/dom_elementimpl.cpp: (ElementImpl::hasAttributes):
khtml/xml/dom_elementimpl.h:

New helpers to begin moving us to using DOM Range-compliant positions in our code.

khtml/xml/dom_position.cpp: (DOM::Position::equivalentRangeCompliantPosition): (DOM::Position::equivalentShallowPosition): (DOM::Position::inLastEditableInContainingEditableBlock):

(DOM::Position::debugPosition): Debugging aid.

khtml/xml/dom_position.h:

kwq/WebCoreBridge.mm: (-[WebCoreBridge applyStyle:]): First bit of wiring up. Some hard-coded temporary code in here will need to be improved soon.

WebKit:

Fixed:
<rdar://problem/3633296>: (Japanese input is not working properly in Carbon Web Kit applications (including CarbonWeb))
<rdar://problem/3631390>: (can't toggle between Input Methods (IMEs) using cmd-space in Carbon Web Kit applications)

Reviewed by rjw.

Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter sendSuperEvent:]): call [NSInputContext processInputKeyBindings:inEvent] just as NSApp does
Carbon.subproj/HIWebView.m: (HIWebViewEventHandler): [NSApp setWindowsNeedUpdate:YES] must be called before events so that ActivateTSMDocument is called to set an active document. Without an active document, TSM will use a default document which uses a bottom-line input window which we don't want.

May 12, 2004:

6:01 PM Changeset in webkit [6584] by hyatt

6 edits in trunk/WebCore

Improve layout scheduling. Make sure no layouts can be scheduled until over a minimum delay threshold.

khtml/khtmlview.cpp: (KHTMLView::scheduleRelayout):
khtml/rendering/render_frames.cpp: (RenderPart::updateWidgetPositions):
khtml/rendering/render_text.cpp: (RenderText::paint):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::close): (DocumentImpl::setParsing): (DocumentImpl::shouldScheduleLayout): (DocumentImpl::minimumLayoutDelay):
khtml/xml/dom_docimpl.h:

5:50 PM Changeset in webkit [6583] by rjw

1 edit in trunk/WebKit/WebView.subproj/WebHTMLView.m

Updated CarbonWeb example to include work-arounds for printing problems. The
work-around makes use of SPI, unfortunate, but necessary.

5:17 PM Changeset in webkit [6582] by cblu

3 edits in trunk/WebKit

WebKit:

Fixed:
<rdar://problem/3633296>: (Japanese input is not working properly in Carbon Web Kit applications (including CarbonWeb))
<rdar://problem/3631390>: (can't toggle between Input Methods (IMEs) using cmd-space in Carbon Web Kit applications)

Reviewed by rjw.

Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter sendSuperEvent:]): call [NSInputContext processInputKeyBindings:inEvent] just as NSApp does
Carbon.subproj/HIWebView.m: (HIWebViewEventHandler): [NSApp setWindowsNeedUpdate:YES] must be called before events so that ActivateTSMDocument is called to set an active document. Without an active document, TSM will use a default document which uses a bottom-line input window which we don't want.

WebKitExamples:

Workaround for:
<rdar://problem/3633296>: (Japanese input is not working properly in Carbon Web Kit applications (including CarbonWeb))
<rdar://problem/3631390>: (can't toggle between Input Methods (IMEs) using cmd-space in Carbon Web Kit applications)

Reviewed by rjw.

CarbonWeb/CarbonWeb.pbproj/project.pbxproj: xcode project update
CarbonWeb/TWebWindow.cp:
- [NSApp setWindowsNeedUpdate:YES] must be called before events so that ActivateTSMDocument is called to set an active document. Without an active document, TSM will use a default document which uses a bottom-line input window which we don't want.
- use Larry's command-space workaround for cmd-space toggling

2:30 PM Changeset in webkit [6581] by rjw

4 edits
1 add in trunk

Changes to plugin scripting extensions.`

May 11, 2004:

7:05 PM Changeset in webkit [6580] by cblu

20 edits in trunk

WebCore:

Support for: <rdar://problem/3616471>: (API: provide way to get from WebFrame to DOMDocument and vice versa)

Reviewed by rjw.

kwq/DOM.mm: (-[DOMDocument _ownerElement]): new
kwq/DOMInternal.h:
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge frameElement]): new

WebKit:

Fixed:
<rdar://problem/3616537>: (API: Make WebResource, WebArchive and related API's public)
<rdar://problem/3616471>: (API: provide way to get from WebFrame to DOMDocument and vice versa)

Reviewed by rjw.

DOM.subproj/WebDOMOperations.h:
DOM.subproj/WebDOMOperations.m: (-[DOMHTMLFrameElement contentFrame]): new (-[DOMHTMLIFrameElement contentFrame]): new (-[DOMHTMLObjectElement contentFrame]): new
DOM.subproj/WebDOMOperationsPrivate.h:
Misc.subproj/WebNSImageExtras.m: (-[NSImage _web_saveAndOpen]): fixed leak
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebDataSource.h:
WebView.subproj/WebDataSource.m: (-[WebDataSource _addSubresources:]): made private (-[WebDataSource _archiveWithMarkupString:nodes:]): handle object tags with frame content (-[WebDataSource _archiveWithCurrentState:]): renamed from _archive, now takes flag (-[WebDataSource _replaceSelectionWithArchive:]): call renamed _addSubresources (-[WebDataSource webArchive]): new (-[WebDataSource mainResource]): new (-[WebDataSource subresources]): made public (-[WebDataSource subresourceForURL:]): made public (-[WebDataSource addSubresource:]): made public
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDocumentPrivate.h:
WebView.subproj/WebFrame.h:
WebView.subproj/WebFrame.m: (-[WebFrame _loadRequest:subresources:subframeArchives:]): call renamed _addSubresources (-[WebFrame DOMDocument]): new (-[WebFrame frameElement]): new (-[WebFrame loadArchive:]): made public
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation loadArchive]): call renamed _addSubresources
WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation archive]): call webArchive on WebDataSource

2:58 PM Changeset in webkit [6579] by hyatt

4 adds in trunk/LayoutTests/fast/block/float

Add new layout tests for float bug fixes.

2:45 PM Changeset in webkit [6578] by hyatt

10 edits in trunk/LayoutTests

Revised layout test with image and float changes.

1:29 PM Changeset in webkit [6577] by hyatt

6 edits in trunk/WebCore

Fix makeChildrenNonInline so that it does not wrap floats unless an inline is actually found.

Fix block minmaxwidth to add together contiguous runs of floats.

Fix the content image loader to not destroy the image when removed from the document.

Reviewed by darin

ChangeLog:
khtml/html/html_imageimpl.cpp: (HTMLImageLoader::~HTMLImageLoader): (HTMLImageElementImpl::detach):
khtml/html/html_imageimpl.h: (DOM::):
khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::createRenderer):
khtml/html/html_objectimpl.h:
khtml/rendering/render_block.cpp: (khtml::getInlineRun): (khtml::RenderBlock::calcInlineMinMaxWidth): (khtml::RenderBlock::calcBlockMinMaxWidth):

10:30 AM Changeset in webkit [6576]

6 copies
2 deletes in tags/WebCore-139~2

This commit was manufactured by cvs2svn to create tag
'WebCore-139~2'.

10:30 AM Changeset in webkit [6575] by vicki

2 edits in trunk/WebCore

fix B&I build failure caused by case sensitivity

May 10, 2004:

4:47 PM Changeset in webkit [6574] by mjs

8 edits in trunk

WebCore:

Reviewed by Darin.

avoid redecoding animated images that are only used once for ~2.5% iBench speedup (WebCore part of fix)

khtml/rendering/render_image.cpp: (RenderImage::setPixmap): Maintain use count for pixmap. (RenderImage::~RenderImage): Likewise.
kwq/KWQPixmap.h:
kwq/KWQPixmap.mm: (QPixmap::increaseUseCount): Call WebCoreImageRenderer (QPixmap::decreaseUseCount): Call WebCoreImageRenderer
kwq/WebCoreImageRenderer.h: Prototype new protocol methods.

WebKit:

Reviewed by Darin.

avoid redecoding animated images that are only used once for ~2.5% iBench speedup (WebCore part of fix)

WebCoreSupport.subproj/WebImageRenderer.h:
WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer increaseUseCount]): (-[WebImageRenderer decreaseUseCount]): (-[WebImageRenderer retainOrCopyIfNeeded]):

4:42 PM Changeset in webkit [6573] by hyatt

1 edit in trunk/WebCore/khtml/xml/dom_docimpl.cpp

Back out the optimization since it will break the ibench cheat.

4:34 PM Changeset in webkit [6572] by mjs

2 edits in trunk/WebKit

Fix build.

WebView.subproj/WebFrame.m:

4:28 PM Changeset in webkit [6571] by hyatt

1 edit in trunk/WebCore/khtml/xml/dom_docimpl.cpp

Fix build failure

4:21 PM Changeset in webkit [6570] by mjs

3 edits in trunk/WebKit

Reviewed by Ken.

avoid messing with undo manager needlessly for ~1% HTML iBench speedup

WebCoreSupport.subproj/WebBridge.h:
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge registerCommandForUndo:]): mark undo/redo item flag (-[WebBridge registerCommandForRedo:]): ditto (-[WebBridge clearUndoRedoOperations]): check flag before removing items, and clear it after removing them

4:20 PM Changeset in webkit [6569] by mjs

5 edits in trunk/WebKit

Reviewed by Darin.

-[WebFrame childFrames] is so hot that a special internal version which avoids the copy and autorelease results in a .75% performance improvement on HTML iBench.

WebView.subproj/WebFramePrivate.h: Prototype new method.
WebView.subproj/WebFrame.m: (-[WebFrame _internalChildFrames]): New method, just returns internal value instead of copying.

(-[WebFrame _descendantFrameNamed:]): Use it
(-[WebFrame _textSizeMultiplierChanged]): likewise
(-[WebFrame _viewWillMoveToHostWindow:]): likewise
(-[WebFrame _viewDidMoveToHostWindow]): likewise
(-[WebFrame _saveDocumentAndScrollState]): likewise
(-[WebFrame _numPendingOrLoadingRequests:]): likewise
(-[WebFrame _checkLoadComplete]): Refactored this and it's two
helpers a little so we could get away with using
_internalChildFrames.
(-[WebFrame _checkLoadCompleteForThisFrame]): Renamed from
_isLoadComplete
(-[WebFrame _recursiveCheckLoadComplete]): renamed from (class
method) _recursiveCheckCompleteFromFrame:

WebView.subproj/WebDataSource.m: (-[WebDataSource _defersCallbacksChanged]): Use it (-[WebDataSource isLoading]): likewise
WebView.subproj/WebView.m: (-[WebView _frameForDataSource:fromFrame:]): likewise (-[WebView _frameForView:fromFrame:]): likewise

4:19 PM Changeset in webkit [6568] by hyatt

3 edits in trunk/WebCore

Make sure that when finished parsing if all the right conditions are met, we just go ahead and updateRendering and
layout.

Reviewed by rjw

khtml/khtmlview.cpp: (KHTMLView::scheduleRelayout):

2:47 PM Changeset in webkit [6567] by mjs

5 edits in trunk/WebCore

Reviewed by Dave.

some minor performance tweaks that together give .5% or so on the HTML iBench

khtml/css/css_valueimpl.h: don't use a bitfield for id and important, unpacking the bitfield is too expensive
kwq/KWQArrayImpl.h:
kwq/KWQArrayImpl.mm: (KWQArrayImpl::at): inline this method because it's so hot
kwq/KWQString.mm: (allocateHandle): inline this function because it's so hot (initializeHandleNodes): move this in the file so above can be inlined (allocateNode): ditto

2:29 PM Changeset in webkit [6566] by hyatt

11 edits in trunk/WebCore

Move image loading to content.

Reviewed by kocienda

khtml/html/html_imageimpl.cpp: (m_imageComplete): (HTMLImageLoader::~HTMLImageLoader): (HTMLImageLoader::updateFromElement): (HTMLImageLoader::removedFromDocument): (HTMLImageLoader::dispatchLoadEvent): (HTMLImageLoader::notifyFinished): (HTMLImageElementImpl::HTMLImageElementImpl): (HTMLImageElementImpl::parseHTMLAttribute): (HTMLImageElementImpl::attach): (HTMLImageElementImpl::detach): (HTMLImageElementImpl::removedFromDocument): (HTMLImageElementImpl::currentImage):
khtml/html/html_imageimpl.h: (DOM::):
khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::HTMLObjectElementImpl): (HTMLObjectElementImpl::removedFromDocument): (HTMLObjectElementImpl::attach):
khtml/html/html_objectimpl.h:
khtml/misc/loader.cpp: (CachedImage::ref):
khtml/rendering/render_image.cpp: (RenderImage::RenderImage): (RenderImage::setImage): (RenderImage::updateAltText):
khtml/rendering/render_image.h: (khtml::RenderImage::getImage):
khtml/rendering/render_object.cpp: (RenderObject::canvas):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::dispatchImageLoadEventSoon): (DocumentImpl::removeImage): (DocumentImpl::dispatchImageLoadEventsNow):
khtml/xml/dom_docimpl.h:

11:05 AM Changeset in webkit [6565] by cblu

2 edits in trunk/WebKit

Forgot to commit this copied header.

DOM.subproj/DOMExtensions.h:

9:47 AM Changeset in webkit [6564]

4 copies
2 deletes in tags/WebCore-139~1

This commit was manufactured by cvs2svn to create tag
'WebCore-139~1'.

9:47 AM Changeset in webkit [6563] by darin

2 edits in trunk/WebCore

Reviewed by Vicki.

fixed build failure seen in B&I log (due to case sensitive file system?)

kwq/KWQLoader.h: Include "KWQCString.h" rather than "QCString.h". The latter was failing because the forwarding header is called "qcstring.h" and I guess B&I started building with a case sensitive file system. I could have changed this to "qcstring.h", but it seemed better to use the header's real name since we're inside KWQ here.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed