Timeline



May 17, 2004:

10:01 PM Changeset in webkit [6622] by hyatt
  • 2 edits in trunk/WebKit

Fix for performance "regression." This wasn't really a regression... I just forgot to update a variable that
I can only assume is used by the PLT.

  • WebView.subproj/WebFrame.m: (-[WebFrame _setState:]):
6:33 PM Changeset in webkit [6621] by cblu
  • 15 edits in trunk/WebKit

WebKit:

Implemented new WebView pasteboard methods. Made a lot of factoring changes related to pasteboard management.

Reviewed by john.

  • Misc.subproj/WebNSPasteboardExtras.h:
  • Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard _web_writableTypesForURL]): renamed to not include "drag" these types are also used for copying (+[NSPasteboard _web_writableTypesForImage]): new (-[NSPasteboard _web_bestURL]): tweak (-[NSPasteboard _web_writeURL:andTitle:types:]): take an array of types that this method should write, don't declare the types since this complicates things for the caller (-[NSPasteboard _web_writeImage:URL:title:archive:types:]): ditto
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:archive:rect:URL:title:event:]): call renamed methods
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate copyLinkToClipboard:]): call code factored out to WebView (-[WebDefaultUIDelegate copyImageToClipboard:]): ditto
  • WebView.subproj/WebDocumentPrivate.h:
  • WebView.subproj/WebHTMLView.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _selectedRTFData]): new factored out method (-[WebHTMLView _writeSelectionToPasteboard:]): factored code out to writeSelectionWithPasteboardTypes:toPasteboard: (-[WebHTMLView _dragImageForLinkElement:]): tweak (-[WebHTMLView _handleMouseDragged:]): call renamed methods (-[WebHTMLView pasteboardTypesForSelection]): new (-[WebTextView writeSelectionWithPasteboardTypes:toPasteboard:]): new, code moved from _writeSelectionToPasteboard:
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebImageView.h:
  • WebView.subproj/WebImageView.m: (-[WebImageView writeImageToPasteboard:types:]): call renamed methods (-[WebImageView copy:]): (-[WebImageView writeSelectionToPasteboard:types:]): call renamed methods
  • WebView.subproj/WebTextView.h:
  • WebView.subproj/WebTextView.m: (-[WebTextView pasteboardTypesForSelection]): new (-[WebTextView writeSelectionWithPasteboardTypes:toPasteboard:]): new
  • WebView.subproj/WebView.m: (-[WebView _writeImageElement:withPasteboardTypes:toPasteboard:]): new (-[WebView _writeLinkElement:withPasteboardTypes:toPasteboard:]): mew (-[WebView dragOperationForDraggingInfo:]): implemented API (-[WebView draggingEntered:]): call API (-[WebView draggingUpdated:]): ditto (-[WebView concludeDragOperation:]): ditto (-[WebView pasteboardTypesForSelection]): implemented API (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]): ditto (-[WebView pasteboardTypesForElement:]): ditto (-[WebView writeElement:withPasteboardTypes:toPasteboard:]): ditto
  • WebView.subproj/WebViewPrivate.h:

WebBrowser:

Change to support renamed WebKit methods

Reviewed by john.

  • BrowserNSPasteboardExtras.m: call renamed _web_writeURL
  • ContextMenuHandler.m: (-[BrowserWebView copyImageAddress:]): ditto
6:29 PM Changeset in webkit [6620] by rjw
  • 18 edits
    1 add in trunk

JavaScriptCore:

Implemented new API for WebScriptObject.

Fixed <rdar://problem/3657145>: (objc to javascript method calls do not cause updates.)
Fixed <rdar://problem/3654887>: (Update to JSC to refer to new JSObject LiveConnect object) (w/ help from Vicki)

Reviewed by Hyatt.

  • JavaScriptCore.pbproj/project.pbxproj:
  • bindings/c/c_instance.cpp: (CInstance::invokeMethod):
  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bindings/jni/jni_jsobject.cpp: (JSObject::convertValueToJObject):
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::getJNIField):
  • bindings/objc/WebScriptObject.mm: (_didExecute): (-[WebScriptObject _initWithObjectImp:KJS::root:Bindings::]): (-[WebScriptObject KJS::]): (-[WebScriptObject dealloc]): (+[WebScriptObject throwException:]): (listFromNSArray): (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject setValue:forKey:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject stringRepresentation]): (+[WebScriptObject _convertValueToObjcValue:KJS::root:Bindings::]): (+[WebUndefined undefined]): (-[WebUndefined initWithCoder:]): (-[WebUndefined encodeWithCoder:]): (-[WebUndefined copyWithZone:]): (-[WebUndefined retain]): (-[WebUndefined release]): (-[WebUndefined retainCount]): (-[WebUndefined autorelease]): (-[WebUndefined dealloc]): (-[WebUndefined copy]): (-[WebUndefined replacementObjectForPortCoder:]):
  • bindings/objc/WebScriptObjectPrivate.h: Added.
  • bindings/objc/objc_class.mm: (ObjcClass::methodsNamed): (ObjcClass::fieldNamed):
  • bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod):
  • bindings/objc/objc_jsobject.h:
  • bindings/objc/objc_jsobject.mm:
  • bindings/objc/objc_runtime.mm: (ObjcField::valueFromInstance):
  • bindings/objc/objc_utility.mm: (KJS::Bindings::JSMethodNameToObjCMethodName): (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue):
  • bindings/runtime.cpp: (Instance::setDidExecuteFunction): (Instance::didExecuteFunction): (Instance::setValueOfField):
  • bindings/runtime.h:
  • bindings/testbindings.mm: (+[MyFirstInterface webScriptNameForSelector:]): (-[MyFirstInterface callJSObject::]):

WebCore:

Implemented new API for WebScriptObject.
Fixed <rdar://problem/3657145>: (objc to javascript method calls do not cause updates.)

Reviewed by Hyatt.

  • kwq/WebCoreBridge.mm: (updateRenderingForBindings): (-[WebCoreBridge init]):
2:56 PM Changeset in webkit [6619] by kocienda
  • 3 edits in trunk/WebKit

Reviewed by John

Remove overrides in WebView for scrollPageDown and scrollPageUp.
NSView behavior gives us just what we want, and there is no
special behavior required for editing.

<rdar://problem/3655364>: "Editing:�scrollPageDown:�ethod�nimplemented�WebKit�diting�PI)"
<rdar://problem/3655365>: "Editing:�scrollPageUp:�ethod�nimplemented�WebKit�diting�PI)"

  • WebView.subproj/WebView.h: Comment methods out and add a note about why.
  • WebView.subproj/WebView.m: Remove stubbed out implementation.

May 16, 2004:

5:19 PM Changeset in webkit [6618]
  • 58 copies
    2 deletes in tags/WebCore-125~6~7

This commit was manufactured by cvs2svn to create tag
'WebCore-125~6~7'.

5:19 PM Changeset in webkit [6617] by mjs
  • 2 edits in branches/Safari-1-2-branch/WebCore

WebCore-125.6.7

5:18 PM Changeset in webkit [6616] by mjs
  • 2 edits in branches/Safari-1-2-branch/WebCore

More build breakage in last change, needed to merge this unrelated
change from HEAD.

  • khtml/rendering/render_list.h: (khtml::RenderListMarker::text):

May 14, 2004:

6:06 PM Changeset in webkit [6615] by vicki
  • 6 edits in trunk

Reviewed by mjs.

<rdar://problem/3642427>: framework marketing number should be 2.0 for DoubleBarrel release

  • JavaScriptCore.pbproj/project.pbxproj: change CFBundleShortVersionString to 2.0
  • WebCore.pbproj/project.pbxproj: change CFBundleShortVersionString to 2.0
  • WebKit.pbproj/project.pbxproj: change CFBundleShortVersionString to 2.0
5:49 PM Changeset in webkit [6614]
  • 57 copies
    2 deletes in tags/WebCore-125~6~6

This commit was manufactured by cvs2svn to create tag
'WebCore-125~6~6'.

5:49 PM Changeset in webkit [6613] by mjs
  • 2 edits in branches/Safari-1-2-branch/WebCore

WebCore-125.6.6

5:48 PM Changeset in webkit [6612] by mjs
  • 2 edits in branches/Safari-1-2-branch/WebCore

Fix build bustage in last change, merge did not work in older tree.

  • khtml/rendering/render_image.cpp: (RenderImage::imageMap):
4:51 PM Changeset in webkit [6611]
  • 57 copies
    2 deletes in tags/WebCore-125~6~5

This commit was manufactured by cvs2svn to create tag
'WebCore-125~6~5'.

4:51 PM Changeset in webkit [6610] by mjs
  • 2 edits in branches/Safari-1-2-branch/WebCore

WebCore-125.6.5

4:47 PM Changeset in webkit [6609] by mjs
  • 8 edits in branches/Safari-1-2-branch/WebCore

Merge Dave's changes for Epiphany.

2004-04-29 David Hyatt <​hyatt@apple.com>

Expose summary on tables.

Reviewed by darin

  • kwq/KWQAccObject.mm: (-[KWQAccObject helpText]):

2004-04-29 David Hyatt <​hyatt@apple.com>

Implement image maps for accessibility.

Reviewed by darin

  • khtml/html/html_imageimpl.cpp: (HTMLAreaElementImpl::getRect):
  • khtml/html/html_imageimpl.h:
  • khtml/rendering/render_image.cpp: (RenderImage::imageMap): (RenderImage::nodeAtPoint):
  • khtml/rendering/render_image.h:
  • kwq/KWQAccObject.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject initWithRenderer:]): (-[KWQAccObject anchorElement]): (-[KWQAccObject parentObject]): (-[KWQAccObject parentObjectUnignored]): (-[KWQAccObject addChildrenToArray:]): (-[KWQAccObject role]): (-[KWQAccObject helpText]): (-[KWQAccObject value]): (-[KWQAccObject title]): (-[KWQAccObject position]): (-[KWQAccObject size]): (-[KWQAccObject accessibilityIsIgnored]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]):
  • kwq/KWQRegion.mm: (QRegion::boundingRect):

2004-04-29 David Hyatt <​hyatt@apple.com>

  1. Change the role of links from AXButton to AXLink.
  2. Add support for list markers using a new role, AXListMarker.

Reviewed by kocienda

  • khtml/rendering/render_list.h: (khtml::RenderListMarker::text):
  • kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject roleDescription]): (-[KWQAccObject value]): (-[KWQAccObject accessibilityIsIgnored]):
4:02 PM Changeset in webkit [6608] by darin
  • 2 edits in trunk/WebCore

Reviewed by Darin, coded by Maciej.

  • fixed extra repaints when doing auto-fill checks on all pages that have pop-up buttons
  • kwq/KWQComboBox.mm: (QComboBox::populateMenu): Set the populating-menu flag and clear it when done. (-[KWQPopUpButton setPopulatingMenu:]): Added. Sets flag. (-[KWQPopUpButton setNeedsDisplayInRect:]): Do nothing if the flag is set.
3:56 PM Changeset in webkit [6607] by hyatt
  • 3 edits in trunk/WebKit

Eliminate timedLayout.

Reviewed by darin

  • WebView.subproj/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFrame _detachFromParent]): (-[WebFrame _transitionToLayoutAcceptable]): (-[WebFrame _setState:]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame stopLoading]):
  • WebView.subproj/WebFramePrivate.h:
3:51 PM Changeset in webkit [6606]
  • 7 copies in tags/Safari-140

This commit was manufactured by cvs2svn to create tag 'Safari-140'.

3:51 PM Changeset in webkit [6605] by vicki
  • 2 edits in trunk

move the Safari-140 release markers in the WebCore and WebKit ChangeLogs

3:44 PM Changeset in webkit [6604] by darin
  • 2 edits in trunk/WebCore

Reviewed by Dave.

  • fixed <rdar://problem/3650026>: "background property doesn't work right on webdevtips.com due to background:inherit"
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyDeclarations): Added CSS_PROP_BACKGROUND to the list of properties that must be applied in the first pass.
2:21 PM Changeset in webkit [6603] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3655495>: (exception loading applets)

Reviewed by kocienda.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge pluginViewWithPackage:attributes:baseURL:]): when calling old cocoa plug-ins, use old keys
1:59 PM Changeset in webkit [6602] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3655204>: (repro assertion failure and crash loading java applets)

Reviewed by kocienda.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge pluginViewWithPackage:attributes:baseURL:]): call pluginViewWithArguments: for old Cocoa plug-ins
12:28 PM Changeset in webkit [6601] by hyatt
  • 5 edits in trunk/WebCore

Fix image loading for <input type=image> and <object>. Make sure it works dynamically and make sure
the renderer is properly null-checked at attach time.

Reviewed by darin

  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::HTMLInputElementImpl): (HTMLInputElementImpl::~HTMLInputElementImpl): (HTMLInputElementImpl::parseHTMLAttribute): (HTMLInputElementImpl::attach):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::HTMLObjectElementImpl): (HTMLObjectElementImpl::~HTMLObjectElementImpl): (HTMLObjectElementImpl::parseHTMLAttribute): (HTMLObjectElementImpl::attach):
  • khtml/html/html_objectimpl.h:
12:09 PM Changeset in webkit [6600] by vicki
  • 3 edits in trunk

set version number to 141u

12:05 PM Changeset in webkit [6599] by vicki
  • 6 edits in trunk

Safari-140 stamp

10:29 AM Changeset in webkit [6598] by cblu
  • 3 edits in trunk/WebKit

Copied headers from WebCore.

  • DOM.subproj/DOMCore.h:
  • DOM.subproj/DOMEvents.h:
10:27 AM Changeset in webkit [6597] by cblu
  • 5 edits in trunk/WebCore
  • Made DOMEventTarget a formal protocol that is implemented by DOMNode
  • Made DOMEventListener a formal protocol that any object can implement

Reviewed by kocienda.

  • kwq/DOMCore.h:
  • kwq/DOMEvents.h:
7:23 AM Changeset in webkit [6596] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by me

  • Plugins.subproj/WebPluginController.m: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Fixed a compile error: undeclared identifier. Looked like a typo.

May 13, 2004:

6:23 PM Changeset in webkit [6595] by rjw
  • 4 edits in trunk

WebKit:

Backed out mistaken change that I didn't mean to checkin.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):

JavaScriptCore:

Fixed indentation.

Reviewed by Chris.

  • ChangeLog:
  • bindings/objc/WebScriptObject.h:
6:08 PM Changeset in webkit [6594] by rjw
  • 7 edits in trunk

WebKit:

Updated to reflect new API.

Reviewed by Chris.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setIsSelected:forView:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame _reloadForPluginChanges]):

WebCore:

Removed vestigial isSelected method.

Reviewed by Chris.

  • kwq/KWQWidget.h:
  • kwq/KWQWidget.mm: (QWidget::setIsSelected):
  • kwq/WebCoreBridge.h:
5:40 PM Changeset in webkit [6593] by cblu
  • 9 edits in trunk/WebKit

Fixed some indenting issues in public headers.

  • Plugins.subproj/WebJavaPlugIn.h:
  • Plugins.subproj/WebPlugin.h:
  • Plugins.subproj/WebScriptObject.h:
  • WebView.subproj/WebEditingDelegate.h:
  • WebView.subproj/WebFrameView.h:
  • WebView.subproj/WebPolicyDelegate.h:
  • WebView.subproj/WebResourceLoadDelegate.h:
  • WebView.subproj/WebView.h:
5:30 PM Changeset in webkit [6592] by kocienda
  • 3 edits in trunk/WebKit

Reviewed by Chris

Moved -DOMDocument convenience back to private header.
I mistakenly moved it to the public header earlier today.

  • WebView.subproj/WebView.h: Removed
  • WebView.subproj/WebViewPrivate.h: Re-added
5:24 PM Changeset in webkit [6591] by rjw
  • 5 edits in trunk/WebKit

Updated to implementation to reflect new API. Left old SPI
in place for compatibility. Can remove when the Java plug-in
updates.

Reviewed by Chris.

  • Plugins.subproj/WebPlugin.h:
  • Plugins.subproj/WebPluginContainer.h:
  • Plugins.subproj/WebPluginController.h:
  • Plugins.subproj/WebPluginController.m: (-[WebPluginController startAllPlugins]): (-[WebPluginController stopAllPlugins]): (-[WebPluginController addPlugin:]): (-[WebPluginController destroyAllPlugins]): (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): (-[WebPluginController showURL:inFrame:]): (-[WebPluginController webPlugInContainerShowStatus:]): (-[WebPluginController showStatus:]): (-[WebPluginController webPlugInContainerSelectionColor]): (-[WebPluginController selectionColor]): (-[WebPluginController webFrame]):
4:58 PM Changeset in webkit [6590] by cblu
  • 18 edits in trunk

Tests:

Updated Blot to use new API's.

  • Blot/BlotDocument.m: (-[BlotDocument dataRepresentationOfType:]): (-[BlotDocument webView:didFinishLoadForFrame:]):

WebCore:

Fixed: <rdar://problem/3616555>: (API: Make DOM extensions and WebKit DOM operations public)

Reviewed by rjw.

  • kwq/DOM.h: added DOMExtensions.h
  • kwq/DOMHTML.h: renamed frame on DOMHTMLTableElement to frameBorders to avoid NSView conflicts
  • kwq/DOMHTML.mm: (-[DOMHTMLTableElement frameBorders]): (-[DOMHTMLTableElement setFrameBorders:]):

WebKit:

  • Added stubs for WebView action and drag & drop customization API's
  • Fixed: <rdar://problem/3616555>: (API: Make DOM extensions and WebKit DOM operations public)

Reviewed by rjw.

  • DOM.subproj/WebDOMOperations.h: added remaining DOM operations
  • DOM.subproj/WebDOMOperationsPrivate.h:
  • Misc.subproj/WebKit.h: added new public headers
  • WebKit.pbproj/project.pbxproj:
  • WebKit.exp: added symbol for WebElementDOMNodeKey
  • WebView.subproj/WebUIDelegate.h: added new UI delegate methods
  • WebView.subproj/WebView.h: added new pasteboard related methods
  • WebView.subproj/WebView.m: (+[WebView URLFromPasteboard:]): new stub (+[WebView URLTitleFromPasteboard:]): new stub (-[WebView dragOperationForDraggingInfo:]): new stub (-[WebView pasteboardTypesForSelection]): new stub (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]): new stub (-[WebView pasteboardTypesForElement:]): new stub (-[WebView writeElement:withPasteboardTypes:toPasteboard:]): new stub
  • WebView.subproj/WebViewPrivate.h:
4:39 PM Changeset in webkit [6589] by rjw
  • 1 add in trunk/WebKit/Plugins.subproj/WebJavaPlugIn.h

Added WebJavaPlugIn.h, fixed build problem.

4:24 PM Changeset in webkit [6588] by rjw
  • 37 edits
    2 adds in trunk

WebKit:

Changed imports of all DOM headers. DOM headers
should be imported using the normal #import <WebCore/foo.h>,
they import is modified when copied to WebKit.

Other approved API changes. Currently unimplemented.

Reviewed by Chris.

  • ChangeLog:
  • DOM.subproj/DOM.h:
  • DOM.subproj/DOMCSS.h:
  • DOM.subproj/DOMCore.h:
  • DOM.subproj/DOMEvents.h:
  • DOM.subproj/DOMExtensions.h:
  • DOM.subproj/DOMHTML.h:
  • DOM.subproj/DOMRange.h:
  • DOM.subproj/DOMStylesheets.h:
  • DOM.subproj/DOMTraversal.h:
  • DOM.subproj/DOMViews.h:
  • Plugins.subproj/WebPlugin.h:
  • Plugins.subproj/WebPluginContainer.h:
  • Plugins.subproj/WebPluginPackage.m:
  • Plugins.subproj/WebPluginViewFactory.h:
  • Plugins.subproj/WebScriptObject.h:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebBridge pluginViewWithPackage:attributes:baseURL:]):
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebFrameLoadDelegate.h:
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m: (-[WebView windowScriptObject]):
  • copy-webcore-files-to-webkit:

WebCore:

Changed imports of all DOM headers. DOM headers
should be imported using the normal #import <WebCore/foo.h>,
they import is modified when copied to WebKit.

Reviewed by Chris.

  • ChangeLog:
  • kwq/DOM.h:
  • kwq/DOMCSS.h:
  • kwq/DOMCore.h:
  • kwq/DOMEvents.h:
  • kwq/DOMExtensions.h:
  • kwq/DOMHTML.h:
  • kwq/DOMInternal.h:
  • kwq/DOMRange.h:
  • kwq/DOMStylesheets.h:
  • kwq/DOMTraversal.h:
  • kwq/DOMViews.h:

JavaScriptCore:

Approved API changes. Currently unimplemented.

Reviewed by Chris.

  • ChangeLog:
  • JavaScriptCore.pbproj/project.pbxproj:
  • bindings/objc/WebScriptObject.h: Added.
  • bindings/objc/WebScriptObject.mm: Added. (+[WebScriptObject throwException:]): (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject stringRepresentation]): (+[WebUndefined undefined]): (-[WebUndefined initWithCoder:]): (-[WebUndefined encodeWithCoder:]): (-[WebUndefined copyWithZone:]):
11:01 AM Changeset in webkit [6587] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by me

  • khtml/editing/htmlediting_impl.cpp: (khtml::ApplyStyleCommandImpl::applyStyleIfNeeded): Fix deployment build bustage. Uninitialized variable.
10:53 AM Changeset in webkit [6586] by kocienda
  • 7 edits
    1 add in trunk/WebKit

Reviewed by Kevin

Move WebKit editing APIs to public API files.

  • WebCoreSupport.subproj/WebBridge.m: Add WebEditingDelegate include.
  • WebKit.pbproj/project.pbxproj: Go Xcode!
  • WebView.subproj/WebDefaultEditingDelegate.m: Remove WebViewPrivate include; add WebEditingDelegate include.
  • WebView.subproj/WebEditingDelegate.h: Added. New file.
  • WebView.subproj/WebView.h: Move API-approved interfaces to this file.
  • WebView.subproj/WebView.m: Add WebEditingDelegate include.
  • WebView.subproj/WebViewPrivate.h: Move API-approved interfaces from this file.
9:41 AM Changeset in webkit [6585] by kocienda
  • 14 edits in trunk/WebCore

WebCore:

Reviewed by Hyatt

Implemented first cut at text style change code.

  • khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::ApplyStyleCommand): (khtml::ApplyStyleCommand::~ApplyStyleCommand): (khtml::ApplyStyleCommand::impl): (khtml::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand): (khtml::RemoveCSSPropertyCommand::~RemoveCSSPropertyCommand): (khtml::RemoveCSSPropertyCommand::impl): (khtml::RemoveCSSPropertyCommand::styleDeclaration): (khtml::RemoveCSSPropertyCommand::property): (khtml::RemoveNodeAttributeCommand::RemoveNodeAttributeCommand): (khtml::RemoveNodeAttributeCommand::~RemoveNodeAttributeCommand): (khtml::RemoveNodeAttributeCommand::impl): (khtml::RemoveNodeAttributeCommand::element): (khtml::RemoveNodeAttributeCommand::attribute): (khtml::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand): (khtml::RemoveNodePreservingChildrenCommand::~RemoveNodePreservingChildrenCommand): (khtml::RemoveNodePreservingChildrenCommand::impl): (khtml::RemoveNodePreservingChildrenCommand::node): (khtml::SetNodeAttributeCommand::SetNodeAttributeCommand): (khtml::SetNodeAttributeCommand::~SetNodeAttributeCommand): (khtml::SetNodeAttributeCommand::impl): (khtml::SetNodeAttributeCommand::element): (khtml::SetNodeAttributeCommand::attribute): (khtml::SetNodeAttributeCommand::value):
  • khtml/editing/htmlediting.h: (khtml::): (khtml::ApplyStyleCommand::):

Removed a bunch of unnecessary DOM namespace qualifiers.
Fixed calls to parent(), which relied on the TreeShared interface to get a parent,
and changed to the parentNode() DOM Node call, which is more suitable given the
intention.

  • khtml/editing/htmlediting_impl.cpp: (khtml::CompositeEditCommandImpl::insertNodeBefore): (khtml::CompositeEditCommandImpl::insertNodeAfter): (khtml::CompositeEditCommandImpl::appendNode): (khtml::CompositeEditCommandImpl::removeNode): (khtml::CompositeEditCommandImpl::removeNodeAndPrune): (khtml::CompositeEditCommandImpl::removeNodePreservingChildren): (khtml::CompositeEditCommandImpl::splitTextNode): (khtml::CompositeEditCommandImpl::joinTextNodes): (khtml::CompositeEditCommandImpl::insertText): (khtml::CompositeEditCommandImpl::deleteText): (khtml::CompositeEditCommandImpl::replaceText): (khtml::CompositeEditCommandImpl::removeCSSProperty): (khtml::CompositeEditCommandImpl::removeNodeAttribute): (khtml::CompositeEditCommandImpl::setNodeAttribute):

Text style change command implementations.
There are a couple more parent() -> parentNode() changes in here as well.

(khtml::ApplyStyleCommandImpl::ApplyStyleCommandImpl):
(khtml::ApplyStyleCommandImpl::~ApplyStyleCommandImpl):
(khtml::ApplyStyleCommandImpl::commandID):
(khtml::ApplyStyleCommandImpl::doApply):
(khtml::ApplyStyleCommandImpl::isHTMLStyleNode):
(khtml::ApplyStyleCommandImpl::removeHTMLStyleNode):
(khtml::ApplyStyleCommandImpl::removeCSSStyle):
(khtml::ApplyStyleCommandImpl::removeCSSProperty):
(khtml::ApplyStyleCommandImpl::setNodeAttribute):
(khtml::ApplyStyleCommandImpl::removeNodeAttribute):
(khtml::ApplyStyleCommandImpl::removeNodePreservingChildren):
(khtml::ApplyStyleCommandImpl::mustExlicitlyApplyStyle):
(khtml::ApplyStyleCommandImpl::createExplicitApplyStyleNode):
(khtml::ApplyStyleCommandImpl::currentlyHasStyle):
(khtml::ApplyStyleCommandImpl::cssProperty):
(khtml::ApplyStyleCommandImpl::matchesTargetStyle):
(khtml::ApplyStyleCommandImpl::positionInsertionPoint):
(khtml::ApplyStyleCommandImpl::splitTextAtStartIfNeeded):
(khtml::ApplyStyleCommandImpl::splitTextAtEndIfNeeded):
(khtml::ApplyStyleCommandImpl::applyStyleIfNeeded):
(khtml::ApplyStyleCommandImpl::removeStyle):
(khtml::ApplyStyleCommandImpl::cloneSelection):
(khtml::ApplyStyleCommandImpl::insertFragment):
(khtml::ApplyStyleCommandImpl::applyInPlace):
(khtml::ApplyStyleCommandImpl::applyUsingFragment):
(khtml::DeleteSelectionCommandImpl::DeleteSelectionCommandImpl):
(khtml::InsertNodeBeforeCommandImpl::doApply):
(khtml::InsertNodeBeforeCommandImpl::doUnapply):
(khtml::JoinTextNodesCommandImpl::doApply):
(khtml::PasteMarkupCommandImpl::PasteMarkupCommandImpl):
(khtml::RemoveCSSPropertyCommandImpl::RemoveCSSPropertyCommandImpl):
(khtml::RemoveCSSPropertyCommandImpl::~RemoveCSSPropertyCommandImpl):
(khtml::RemoveCSSPropertyCommandImpl::commandID):
(khtml::RemoveCSSPropertyCommandImpl::doApply):
(khtml::RemoveCSSPropertyCommandImpl::doUnapply):
(khtml::RemoveNodeAttributeCommandImpl::RemoveNodeAttributeCommandImpl):
(khtml::RemoveNodeAttributeCommandImpl::~RemoveNodeAttributeCommandImpl):
(khtml::RemoveNodeAttributeCommandImpl::commandID):
(khtml::RemoveNodeAttributeCommandImpl::doApply):
(khtml::RemoveNodeAttributeCommandImpl::doUnapply):
(khtml::RemoveNodePreservingChildrenCommandImpl::RemoveNodePreservingChildrenCommandImpl):
(khtml::RemoveNodePreservingChildrenCommandImpl::~RemoveNodePreservingChildrenCommandImpl):
(khtml::RemoveNodePreservingChildrenCommandImpl::commandID):
(khtml::RemoveNodePreservingChildrenCommandImpl::doApply):
(khtml::SetNodeAttributeCommandImpl::SetNodeAttributeCommandImpl):
(khtml::SetNodeAttributeCommandImpl::~SetNodeAttributeCommandImpl):
(khtml::SetNodeAttributeCommandImpl::commandID):
(khtml::SetNodeAttributeCommandImpl::doApply):
(khtml::SetNodeAttributeCommandImpl::doUnapply):
(khtml::SplitTextNodeCommandImpl::doUnapply):
(khtml::TypingCommandImpl::insertText):

Text style change command implementations.

  • khtml/editing/htmlediting_impl.h: (khtml::ApplyStyleCommandImpl::): (khtml::ApplyStyleCommandImpl::removingStyle): (khtml::RemoveCSSPropertyCommandImpl::styleDeclaration): (khtml::RemoveCSSPropertyCommandImpl::property): (khtml::RemoveNodeAttributeCommandImpl::element): (khtml::RemoveNodeAttributeCommandImpl::attribute): (khtml::RemoveNodePreservingChildrenCommandImpl::node): (khtml::SetNodeAttributeCommandImpl::element): (khtml::SetNodeAttributeCommandImpl::attribute): (khtml::SetNodeAttributeCommandImpl::value):

Fixed a bug where the TreeWalker returned the current node instead
of null when an attempt was made to use the iterator to go to a
non-existent location.

  • khtml/xml/dom2_traversalimpl.cpp: (DOM::TreeWalkerImpl::parentNode): (DOM::TreeWalkerImpl::firstChild): (DOM::TreeWalkerImpl::lastChild): (DOM::TreeWalkerImpl::previousSibling): (DOM::TreeWalkerImpl::nextSibling): (DOM::TreeWalkerImpl::previousNode): (DOM::TreeWalkerImpl::nextNode):

A convenience.

  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::hasAttributes):
  • khtml/xml/dom_elementimpl.h:

New helpers to begin moving us to using DOM Range-compliant positions in our code.

  • khtml/xml/dom_position.cpp: (DOM::Position::equivalentRangeCompliantPosition): (DOM::Position::equivalentShallowPosition): (DOM::Position::inLastEditableInContainingEditableBlock):

(DOM::Position::debugPosition): Debugging aid.

  • khtml/xml/dom_position.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge applyStyle:]): First bit of wiring up. Some hard-coded temporary code in here will need to be improved soon.

WebKit:

Fixed:
<rdar://problem/3633296>: (Japanese input is not working properly in Carbon Web Kit applications (including CarbonWeb))
<rdar://problem/3631390>: (can't toggle between Input Methods (IMEs) using cmd-space in Carbon Web Kit applications)

Reviewed by rjw.

  • Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter sendSuperEvent:]): call [NSInputContext processInputKeyBindings:inEvent] just as NSApp does
  • Carbon.subproj/HIWebView.m: (HIWebViewEventHandler): [NSApp setWindowsNeedUpdate:YES] must be called before events so that ActivateTSMDocument is called to set an active document. Without an active document, TSM will use a default document which uses a bottom-line input window which we don't want.
Note: See TracTimeline for information about the timeline view.