⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 19, 2004:

7:25 PM Changeset in webkit [6646] by hyatt
  • 6 edits in trunk/WebCore

Implement support for notification posting to accessibility clients for layouts and loads.

  • khtml/khtmlview.cpp: (KHTMLView::layout):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::close):
  • kwq/KWQAccObjectCache.h: (KWQAccObjectCache::enableAccessibility): (KWQAccObjectCache::accessibilityEnabled):
  • kwq/KWQAccObjectCache.mm: (KWQAccObjectCache::accObject): (KWQAccObjectCache::setAccObject): (KWQAccObjectCache::removeAccObject): (KWQAccObjectCache::detach): (KWQAccObjectCache::childrenChanged): (KWQAccObjectCache::postNotification):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge accessibilityTree]):
5:48 PM Changeset in webkit [6645] by cblu
  • 19 edits in trunk

WebCore:

Tweaks for forthcoming dragging improvements.

Reviewed by john.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge moveDragCaretToPoint:]): renamed for future reasons, removed text only restrictions

WebKit:

Fixed: <rdar://problem/3462627>: (API: Need a way to disable/customize dragging)

Reviewed by john.

  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:URL:title:archive:types:]): fixed bug that caused exception
  • WebView.subproj/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:shouldBeginDragForElement:dragImage:mouseDownEvent:mouseDraggedEvent:]): new, returns YES (-[WebDefaultUIDelegate webView:dragOperationForDraggingInfo:overElement:]): new, returns [WebView dragOperationForDraggingInfo:] (-[WebDefaultUIDelegate webView:shouldProcessDragWithDraggingInfo:overElement:]): new, returns YES
  • WebView.subproj/WebDocumentInternal.h: added WebDocumentDragging and WebDocumentElement for document dragging
  • WebView.subproj/WebDocumentPrivate.h: moved WebDocumentSelection to WebDocumentInternal.h
  • WebView.subproj/WebFrame.m: (-[WebFrame _actionInformationForNavigationType:event:originalURL:]):
  • WebView.subproj/WebHTMLView.h:
  • WebView.subproj/WebHTMLView.m: (+[WebHTMLView _insertablePasteboardTypes]): new (-[WebHTMLView _handleMouseDragged:]): call shouldBeginDragForElement:::: delegate API (-[WebHTMLView _mayStartDragWithMouseDragged:]): call renamed elementAtPoint SPI (-[WebHTMLView initWithFrame:]): don't register for drag types since this is handled at the WebView (-[WebHTMLView menuForEvent:]): call renamed elementAtPoint SPI (-[WebHTMLView _isSelectionEvent:]): call renamed elementAtPoint SPI (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): rather than unregistering drag types on the WebView, just tell it that we're dragging (-[WebHTMLView draggedImage:endedAt:operation:]): ditto (-[WebHTMLView _canProcessDragWithDraggingInfo:]): new (-[WebHTMLView dragOperationForDraggingInfo:]): new WebDocumentDragging SPI (-[WebHTMLView draggingUpdatedWithDraggingInfo:]): ditto (-[WebHTMLView concludeDragForDraggingInfo:]): ditto (-[WebHTMLView elementAtPoint:]): renamed from _elementAtPoint since this is part of the WebDocumentElement SPI
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebImageView.h:
  • WebView.subproj/WebImageView.m: (-[WebImageView elementAtPoint:]): new (-[WebImageView menuForEvent:]): call elementAtPoint (-[WebImageView mouseDragged:]): rather than unregistering drag types on the WebView, just tell it that we're dragging (-[WebImageView draggedImage:endedAt:operation:]): ditto
  • WebView.subproj/WebTextView.h:
  • WebView.subproj/WebTextView.m: (-[WebTextView _elementAtWindowPoint:]): new (-[WebTextView elementAtPoint:]): new (-[WebTextView menuForEvent:]): call _elementAtWindowPoint
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m: (-[WebViewPrivate dealloc]): removed draggedTypes ivar (+[WebView URLFromPasteboard:]): implemented (+[WebView URLTitleFromPasteboard:]): implemented (-[WebView _registerDraggedTypes]): moved (-[WebView _frameViewAtWindowPoint:]): new (-[WebView _draggingDocumentViewAtWindowPoint:]): new (-[WebView _elementAtWindowPoint:]): new (-[WebView dragOperationForDraggingInfo:]): updated this API to handle subviews that may want to handle drags (-[WebView _dragOperationForDraggingInfo:]): new, handles UI delegate for drag control (-[WebView draggingEntered:]): call _dragOperationForDraggingInfo: (-[WebView draggingUpdated:]): ditto (-[WebView concludeDragOperation:]): work with the UI delegate and the subview to handle what happens
  • WebView.subproj/WebViewPrivate.h:
12:18 PM Changeset in webkit [6644] by rjw
  • 5 edits in trunk

WebKit:

Removed extraneous tabs that were added (by XCode?).

  • DOM.subproj/DOM-compat.h:
  • Plugins.subproj/WebScriptObject.h:

JavaScriptCore:

Removed extraneous tabs that were added (by XCode?).

  • bindings/objc/WebScriptObject.h:
12:14 PM Changeset in webkit [6643] by rjw
  • 2 edits in trunk/WebKit

Updated header copy script to only copy if modified headers
are different.

  • copy-webcore-files-to-webkit:
11:36 AM Changeset in webkit [6642] by kocienda
  • 9 edits in trunk

WebCore:

Reviewed by Hyatt and Darin

Fix for this bug:

<rdar://problem/3643230>: "can't tab out of contentEditable Elements"

  • khtml/xml/dom_elementimpl.cpp: Now checks if key event was intercepted by the editing key-handler before setting the event as defaultHandled. (ElementImpl::defaultEventHandler):
  • kwq/KWQKHTMLPart.h: Name change from editingKeyEvent. Also now returns a BOOL to report whether the event was handled or not.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::interceptEditingKeyEvent): Ditto.
  • kwq/WebCoreBridge.h: Renamed from _editingKeyDown.

WebKit:

Reviewed by Hyatt and Darin

Fix for this bug:

<rdar://problem/3643230>: "can't tab out of contentEditable Elements"

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge interceptEditingKeyEvent:]): Renamed from _editingKeyDown. Also now returns a BOOL to report whether the event was handled or not.
  • WebView.subproj/WebView.m: (-[WebView _interceptEditingKeyEvent:]): Also renamed from _editingKeyDown. Now includes a check if the web view is editable and whether the event is a tab key event. If the former is not true and the latter is, the key is not intercepted. This causes the tab to shift once the key is processed by other non-editing key-handling mechanisms.
  • WebView.subproj/WebViewPrivate.h: Changed declaration due to name change.
11:21 AM Changeset in webkit [6641] by kocienda
  • 9 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3655601>: "deleting characters is much slower than inserting them"

Cleaned up the way selections are set in edit commands, and how KHTMLPart is
notified of these changes. This clears up a number of inefficiencies, including unnecessary repaints
which were causing the performace problem.

  • khtml/editing/htmlediting.cpp: Removed moveToStartingSelection and moveToEndingSelection functions. This work is going to be done using another pre-existing communication facility shared by edit commands and the part.
  • khtml/editing/htmlediting.h: Ditto.
  • khtml/editing/htmlediting_impl.cpp: (khtml::EditCommandImpl::setStartingSelection): Fix coding mistake which caused double recursion while setting ancestor values. (khtml::EditCommandImpl::setEndingSelection): Ditto. (khtml::CompositeEditCommandImpl::doUnapply): No longer calls moveToStartingSelection. Work done in the part now. (khtml::CompositeEditCommandImpl::doReapply): No longer calls moveToEndingSelection. Work done in the part now. (khtml::TypingCommandImpl::typingAddedToOpenCommand): New function. Provides a hook for typing commands to tell the part about additional typing that has been done. (khtml::TypingCommandImpl::insertText): Now calls typingAddedToOpenCommand. (khtml::TypingCommandImpl::insertNewline): Ditto. (khtml::TypingCommandImpl::issueCommandForDeleteKey): Ditto. (khtml::TypingCommandImpl::deleteKeyPressed): Ditto.
  • khtml/editing/htmlediting_impl.h: Removed moveToStartingSelection and moveToEndingSelection functions.
  • khtml/khtml_part.cpp: (KHTMLPart::setSelection): Modified to take an argument which tells whether the set closes an active typing command. (KHTMLPart::notifySelectionChanged): Changed endTyping variable to be consistent with "close typing" terminology used elsewhere. (KHTMLPart::appliedEditing): Now sets the selection using the value of the passed-in command. Added an assert for typing cases. Fixed problem where didChangeNotification was not being posted for typing changes after the first one. (KHTMLPart::unappliedEditing): Now sets the selection using the value of the passed-in command. (KHTMLPart::reappliedEditing): Now sets the selection using the value of the passed-in command.
  • khtml/khtml_part.h:
  • khtml/rendering/render_canvas.cpp: (RenderCanvas::clearSelection): Do not call repaint when the selection is a caret.
9:42 AM Changeset in webkit [6640] by kocienda
  • 10 edits in trunk

Tests:

Reviewed by Hyatt

  • Blot/BlotDocument.m: (-[BlotDocument windowControllerDidLoadNib:]): Add call to setEditable:YES on web view. (-[BlotDocument webView:didFinishLoadForFrame:]): Remove hack to insert contenteditable attribute on body elements after loading a document.

WebCore:

Reviewed by Hyatt

  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::isContentEditable): Ask if the part is contenteditable. True value is treated as an "override" and will short-circuit, returning true.
  • khtml/khtml_part.cpp: (KHTMLPart::isContentEditable): Call over bridge. Has the effect of checking the isEditable method on the WebView which contains this part.
  • khtml/khtml_part.h: Declare isContentEditable.
  • kwq/KWQKHTMLPart.h: Declare isContentEditable.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::isContentEditable): Call over bridge, as described above.
  • kwq/WebCoreBridge.h: Declare isEditable.

WebKit:

Reviewed by Hyatt

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge isEditable]): Return the isEditable value for the WebView which contains this bridge's frame.
7:37 AM Changeset in webkit [6639] by darin
  • 12 edits in trunk/WebCore
  • fixed headers with licenses mangled by Xcode auto-indenting
  • kwq/DOMExtensions.h:
  • kwq/KWQAccObject.h:
  • kwq/KWQAccObject.mm:
  • kwq/KWQAccObjectCache.h:
  • kwq/KWQKSSLKeyGen.mm:
  • kwq/KWQScrollBar.mm:
  • kwq/KWQSlider.mm:
  • kwq/WebCoreGraphicsBridge.h:
  • kwq/WebCoreGraphicsBridge.m:
  • kwq/WebCoreKeyGenerator.h:
  • kwq/WebCoreKeyGenerator.m:
7:34 AM Changeset in webkit [6638] by darin
  • 4 edits in trunk/WebKit
  • fixed headers with licenses mangled by Xcode auto-indenting
  • DOM.subproj/DOMExtensions.h:
  • WebCoreSupport.subproj/WebGraphicsBridge.h:
  • WebCoreSupport.subproj/WebGraphicsBridge.m:
7:33 AM Changeset in webkit [6637] by darin
  • 6 edits in trunk/JavaScriptCore
  • fixed headers with licenses mangled by Xcode auto-indenting
  • bindings/jni/jni_jsobject.cpp:
  • bindings/jni/jni_jsobject.h:
  • bindings/runtime_array.h:
  • bindings/runtime_root.cpp:
  • bindings/runtime_root.h:
1:58 AM Changeset in webkit [6636] by mjs
  • 1 edit in branches/Safari-1-2-branch/WebCore/ChangeLog-2005-08-23

WebCore-125.6.8

1:56 AM Changeset in webkit [6635] by mjs
  • 4 edits in branches/Safari-1-2-branch/WebCore

Merged more Epiphany changes.

2004-05-18 David Hyatt <​hyatt@apple.com>

Add two new attributes for accessibility that can be polled by the screen reader. AXLayoutCount indicates
the number of layouts that have occurred, and AXLoaded indicates whether or not a page has finished loading.

  • khtml/khtmlview.cpp: (KHTMLViewPrivate::reset): (KHTMLView::layoutCount): (KHTMLView::layout):
  • khtml/khtmlview.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject roleDescription]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]):

2004-05-18 David Hyatt <​hyatt@apple.com>

Fix crash when retrieving the AXHelp text.

  • kwq/KWQAccObject.mm: (-[KWQAccObject helpText]):

May 18, 2004:

10:54 PM Changeset in webkit [6634] by hyatt
  • 3 edits in trunk/WebCore

Fix build bustage.

10:24 PM Changeset in webkit [6633] by hyatt
  • 4 edits in trunk/WebCore

Add two new attributes for accessibility that can be polled by the screen reader. AXLayoutCount indicates
the number of layouts that have occurred, and AXLoaded indicates whether or not a page has finished loading.

  • khtml/khtmlview.cpp: (KHTMLViewPrivate::reset): (KHTMLView::layoutCount): (KHTMLView::layout):
  • khtml/khtmlview.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject roleDescription]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]):
8:03 PM Changeset in webkit [6632] by hyatt
  • 2 edits in trunk/WebCore

Fix crash when retrieving the AXHelp text.

  • kwq/KWQAccObject.mm: (-[KWQAccObject helpText]):
7:54 PM Changeset in webkit [6631] by hyatt
  • 14 edits in trunk

WebCore:

Improve layout scheduling and add instrumentation for debugging layout scheduling

Reviewed by kocienda

  • khtml/khtml_part.cpp: (KHTMLPart::slotFinishedParsing): (KHTMLPart::checkCompleted):
  • khtml/khtmlview.cpp: (KHTMLViewPrivate::KHTMLViewPrivate): (KHTMLViewPrivate::reset): (KHTMLView::layout): (KHTMLView::scheduleRelayout): (KHTMLView::haveDelayedLayoutScheduled): (KHTMLView::unscheduleRelayout):
  • khtml/khtmlview.h:
  • khtml/rendering/render_object.cpp: (RenderObject::repaintAfterLayoutIfNeeded):
  • khtml/rendering/render_replaced.cpp: (RenderWidget::updateWidgetPositions):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::close): (DocumentImpl::setParsing): (DocumentImpl::shouldScheduleLayout): (DocumentImpl::minimumLayoutDelay): (DocumentImpl::elapsedTime): (DocumentImpl::finishParsing): (DocumentImpl::updateStyleSelector):
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::allDataReceived):
  • kwq/KWQDateTime.h:
  • kwq/KWQDateTime.mm: (QTime::elapsed):
  • kwq/KWQWidget.mm: (QWidget::setFrameGeometry):

WebKit:

Improve layout scheduling.

Reviewed by kocienda

  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToLayoutAcceptable]): (-[WebFrame _checkLoadCompleteForThisFrame]):
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
7:50 PM Changeset in webkit [6630] by rjw
  • 2 edits in trunk/JavaScriptCore

Added exception logging. Also check for exception and
set results as appropriate.

Reviewed by Maciej (partially reviewed).

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject setValue:forKey:]): (-[WebScriptObject valueForKey:]):
6:16 PM Changeset in webkit [6629] by rjw
  • 10 edits in trunk

WebKit:

Finished implementation of windowScriptObject.

Reviewed by Maciej.

  • WebView.subproj/WebView.m: (-[WebView windowScriptObject]):

WebCore:

Finished implementing support for windowScriptObject.

Reviewed by Maciej.

  • khtml/khtml_part.cpp: (KHTMLPart::begin):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): (KWQKHTMLPart::~KWQKHTMLPart): (KWQKHTMLPart::windowScriptObject):
  • kwq/WebCoreBridge.mm: (updateRenderingForBindings):

JavaScriptCore:

Finsished implementing support for windowScriptObject.
Had to make WebScriptObjectPrivate.h accessible from
WebCore.

Reviewed by Maciej.

  • JavaScriptCore.pbproj/project.pbxproj:
  • bindings/objc/WebScriptObjectPrivate.h:
5:57 PM Changeset in webkit [6628] by kdecker
  • 2 edits in trunk/WebCore
  • roll out previous change -- I (Vicki) accidentally committed this change!
5:50 PM Changeset in webkit [6627] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

  • khtml/xml/dom_stringimpl.cpp: (DOM::parseLength):
4:15 PM Changeset in webkit [6626] by rjw
  • 13 edits in trunk

WebKit:

Added WebKit portion of webView:windowScriptObjectAvailable:
implementation. Still need to implement creating the WebScriptObject
wrapper on the WebCore side.

Reviewed by Maciej.

Removed "_" from _setPageWidthForPrinting:. This method facilitates
a work-around for carbon printing. At some point we may make this
method public API.

Reviewed by Chris.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge overrideMediaType]): (-[WebBridge windowObjectCleared]):
  • WebView.subproj/WebDefaultFrameLoadDelegate.m: (-[WebDefaultFrameLoadDelegate webView:windowScriptObjectAvailable:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView setPageWidthForPrinting:]):

WebCore:

Added stubs to get the WebScriptObject for the window
JS object.

Made updateRenderingForBindings more robust when handed a
nil root object. This was causing a crash in DB. Still need to
address root cause of nil root object.

Reviewed by Maciej.

  • khtml/khtml_part.cpp: (KHTMLPart::begin):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::windowScriptObject): (KWQKHTMLPart::partClearedInBegin):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (updateRenderingForBindings): (-[WebCoreBridge init]): (-[WebCoreBridge stringByEvaluatingJavaScriptFromString:]): (-[WebCoreBridge windowScriptObject]):

JavaScriptCore:

Use KVC to set/get values instead of directly accessing
ivars.

Reviewed by Maciej.

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (+[WebScriptObject _convertValueToObjcValue:KJS::root:Bindings::]):
  • bindings/objc/objc_runtime.mm: (ObjcField::valueFromInstance): (convertValueToObjcObject): (ObjcField::setValueToInstance):

WebKitExamples:

Changed printing work-around to use a method that may be
made public at some point in the future.

Reviewed by Chris.

  • CarbonWeb/TWebWindow.cp:
3:18 PM Changeset in webkit [6625] by mjs
  • 6 edits in trunk/WebCore

Reviewed by Ken.

<rdar://problem/3656719>: Implement outerHTML and setOuterHTML DOM extensions

They were already implemented (by Chris), all that was required
was exporting them to JavaScript.

  • khtml/dom/html_element.cpp: (HTMLElement::outerHTML): Call impl. (HTMLElement::setOuterHTML): Ditto.
  • khtml/dom/html_element.h: Prototype new methods.
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getValueProperty): Add OuterHTML. (KJS::HTMLElement::putValue): Add OuterHTML.
  • khtml/ecma/kjs_html.h: Add new enum values.
  • khtml/ecma/kjs_html.lut.h: Regenerated.
1:20 PM Changeset in webkit [6624] by kocienda
  • 12 edits in trunk/WebCore

Reviewed by Hyatt

Removed support for designMode attribute, which we will not be supporting for Tiger.
Removed inEditMode from KHTMLPart. This cached designMode value.
Removed KHTMLPart::isEditingAtNode function. Asking a node if it is content-editable
is a suitable replacement.

  • khtml/dom/dom_misc.h: Remove TristateFlag enum that was used to track designMode values.
  • khtml/dom/html_document.cpp: Remove designMode and setDesignMode.
  • khtml/dom/html_document.h: Ditto.
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): Remove designMode. (KJS::HTMLDocument::putValue): Ditto.
  • khtml/ecma/kjs_html.lut.h: (KJS::): Ditto.
  • khtml/html/html_documentimpl.cpp: Remove designMode and setDesignMode.
  • khtml/html/html_documentimpl.h: Ditto.
  • khtml/khtml_part.cpp: Remove setEditMode, editMode, inEditMode, and isEditingAtNode.
  • khtml/khtml_part.h: Ditto.
  • khtml/khtmlpart_p.h: Remove m_inEditMode variable. (KHTMLPartPrivate::KHTMLPartPrivate):
  • khtml/khtmlview.cpp: (KHTMLView::focusNextPrevNode): Change over one use in tree of isEditingAtNode to use isContentEditable instead. isContentEditable will be modified in future patch to handle whether the per-part switch has been thrown to override whether something is editable or not.
9:55 AM Changeset in webkit [6623] by darin
  • 4 edits in trunk/WebKit

Reviewed by John.

  • fixed <rdar://problem/3520322>: "can't use <WebKit/HIWebView.h> or <WebKit/CarbonUtils.h> from non-Objective C"
  • Carbon.subproj/CarbonUtils.h: Added ifdefs so file compiles when included from non-Objective-C. Changed style to match other Carbon headers a bit more closely. Also remove unnecessary includes.
  • Carbon.subproj/HIWebView.h: Ditto.
  • fixed <rdar://problem/3648505>: "this text file scrolls to the second line instead of first when pressing home"
  • WebView.subproj/WebFrameView.m: (-[WebFrameView _scrollToTopLeft]): Scroll to origin.y instead of assuming that top is 0; can be non-0 for text view. (-[WebFrameView _scrollToBottomLeft]): Use NSMaxY instead of height for the same reason.

May 17, 2004:

10:01 PM Changeset in webkit [6622] by hyatt
  • 2 edits in trunk/WebKit

Fix for performance "regression." This wasn't really a regression... I just forgot to update a variable that
I can only assume is used by the PLT.

  • WebView.subproj/WebFrame.m: (-[WebFrame _setState:]):
6:33 PM Changeset in webkit [6621] by cblu
  • 15 edits in trunk/WebKit

WebKit:

Implemented new WebView pasteboard methods. Made a lot of factoring changes related to pasteboard management.

Reviewed by john.

  • Misc.subproj/WebNSPasteboardExtras.h:
  • Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard _web_writableTypesForURL]): renamed to not include "drag" these types are also used for copying (+[NSPasteboard _web_writableTypesForImage]): new (-[NSPasteboard _web_bestURL]): tweak (-[NSPasteboard _web_writeURL:andTitle:types:]): take an array of types that this method should write, don't declare the types since this complicates things for the caller (-[NSPasteboard _web_writeImage:URL:title:archive:types:]): ditto
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:archive:rect:URL:title:event:]): call renamed methods
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate copyLinkToClipboard:]): call code factored out to WebView (-[WebDefaultUIDelegate copyImageToClipboard:]): ditto
  • WebView.subproj/WebDocumentPrivate.h:
  • WebView.subproj/WebHTMLView.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _selectedRTFData]): new factored out method (-[WebHTMLView _writeSelectionToPasteboard:]): factored code out to writeSelectionWithPasteboardTypes:toPasteboard: (-[WebHTMLView _dragImageForLinkElement:]): tweak (-[WebHTMLView _handleMouseDragged:]): call renamed methods (-[WebHTMLView pasteboardTypesForSelection]): new (-[WebTextView writeSelectionWithPasteboardTypes:toPasteboard:]): new, code moved from _writeSelectionToPasteboard:
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebImageView.h:
  • WebView.subproj/WebImageView.m: (-[WebImageView writeImageToPasteboard:types:]): call renamed methods (-[WebImageView copy:]): (-[WebImageView writeSelectionToPasteboard:types:]): call renamed methods
  • WebView.subproj/WebTextView.h:
  • WebView.subproj/WebTextView.m: (-[WebTextView pasteboardTypesForSelection]): new (-[WebTextView writeSelectionWithPasteboardTypes:toPasteboard:]): new
  • WebView.subproj/WebView.m: (-[WebView _writeImageElement:withPasteboardTypes:toPasteboard:]): new (-[WebView _writeLinkElement:withPasteboardTypes:toPasteboard:]): mew (-[WebView dragOperationForDraggingInfo:]): implemented API (-[WebView draggingEntered:]): call API (-[WebView draggingUpdated:]): ditto (-[WebView concludeDragOperation:]): ditto (-[WebView pasteboardTypesForSelection]): implemented API (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]): ditto (-[WebView pasteboardTypesForElement:]): ditto (-[WebView writeElement:withPasteboardTypes:toPasteboard:]): ditto
  • WebView.subproj/WebViewPrivate.h:

WebBrowser:

Change to support renamed WebKit methods

Reviewed by john.

  • BrowserNSPasteboardExtras.m: call renamed _web_writeURL
  • ContextMenuHandler.m: (-[BrowserWebView copyImageAddress:]): ditto
6:29 PM Changeset in webkit [6620] by rjw
  • 18 edits
    1 add in trunk

JavaScriptCore:

Implemented new API for WebScriptObject.

Fixed <rdar://problem/3657145>: (objc to javascript method calls do not cause updates.)
Fixed <rdar://problem/3654887>: (Update to JSC to refer to new JSObject LiveConnect object) (w/ help from Vicki)

Reviewed by Hyatt.

  • JavaScriptCore.pbproj/project.pbxproj:
  • bindings/c/c_instance.cpp: (CInstance::invokeMethod):
  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bindings/jni/jni_jsobject.cpp: (JSObject::convertValueToJObject):
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::getJNIField):
  • bindings/objc/WebScriptObject.mm: (_didExecute): (-[WebScriptObject _initWithObjectImp:KJS::root:Bindings::]): (-[WebScriptObject KJS::]): (-[WebScriptObject dealloc]): (+[WebScriptObject throwException:]): (listFromNSArray): (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject setValue:forKey:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject stringRepresentation]): (+[WebScriptObject _convertValueToObjcValue:KJS::root:Bindings::]): (+[WebUndefined undefined]): (-[WebUndefined initWithCoder:]): (-[WebUndefined encodeWithCoder:]): (-[WebUndefined copyWithZone:]): (-[WebUndefined retain]): (-[WebUndefined release]): (-[WebUndefined retainCount]): (-[WebUndefined autorelease]): (-[WebUndefined dealloc]): (-[WebUndefined copy]): (-[WebUndefined replacementObjectForPortCoder:]):
  • bindings/objc/WebScriptObjectPrivate.h: Added.
  • bindings/objc/objc_class.mm: (ObjcClass::methodsNamed): (ObjcClass::fieldNamed):
  • bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod):
  • bindings/objc/objc_jsobject.h:
  • bindings/objc/objc_jsobject.mm:
  • bindings/objc/objc_runtime.mm: (ObjcField::valueFromInstance):
  • bindings/objc/objc_utility.mm: (KJS::Bindings::JSMethodNameToObjCMethodName): (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue):
  • bindings/runtime.cpp: (Instance::setDidExecuteFunction): (Instance::didExecuteFunction): (Instance::setValueOfField):
  • bindings/runtime.h:
  • bindings/testbindings.mm: (+[MyFirstInterface webScriptNameForSelector:]): (-[MyFirstInterface callJSObject::]):

WebCore:

Implemented new API for WebScriptObject.
Fixed <rdar://problem/3657145>: (objc to javascript method calls do not cause updates.)

Reviewed by Hyatt.

  • kwq/WebCoreBridge.mm: (updateRenderingForBindings): (-[WebCoreBridge init]):
2:56 PM Changeset in webkit [6619] by kocienda
  • 3 edits in trunk/WebKit

Reviewed by John

Remove overrides in WebView for scrollPageDown and scrollPageUp.
NSView behavior gives us just what we want, and there is no
special behavior required for editing.

<rdar://problem/3655364>: "Editing:�scrollPageDown:�ethod�nimplemented�WebKit�diting�PI)"
<rdar://problem/3655365>: "Editing:�scrollPageUp:�ethod�nimplemented�WebKit�diting�PI)"

  • WebView.subproj/WebView.h: Comment methods out and add a note about why.
  • WebView.subproj/WebView.m: Remove stubbed out implementation.

May 16, 2004:

5:19 PM Changeset in webkit [6618]
  • 58 copies
    2 deletes in tags/WebCore-125~6~7

This commit was manufactured by cvs2svn to create tag
'WebCore-125~6~7'.

5:19 PM Changeset in webkit [6617] by mjs
  • 2 edits in branches/Safari-1-2-branch/WebCore

WebCore-125.6.7

5:18 PM Changeset in webkit [6616] by mjs
  • 2 edits in branches/Safari-1-2-branch/WebCore

More build breakage in last change, needed to merge this unrelated
change from HEAD.

  • khtml/rendering/render_list.h: (khtml::RenderListMarker::text):
Note: See TracTimeline for information about the timeline view.