Timeline

May 28, 2004:

9:23 PM Changeset in webkit [6733] by ouch

• 4 edits in trunk/WebCore

Reviewed by gramps.

• removed setShadowWithColor and change setShadow to work with optional attributes

it follows the same rules as setFill/StrokeColor

• Fixed bug in setFillColor and setStrokeColor for CMYK colors (missing break in case).

• khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):
• khtml/ecma/kjs_html.h: (KJS::Context2D::):
• khtml/ecma/kjs_html.lut.h: (KJS::):

5:07 PM Changeset in webkit [6732] by darin

• 3 edits in trunk/WebKit

Reviewed by Maciej.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _fontManagerOperationAsStyle]): First cut at figuring out what operation the font manager is doing without digging into its private data structures.

4:26 PM Changeset in webkit [6731] by darin

• 16 edits in trunk

WebCore:

Reviewed by Ken.

• various editing-related improvements

• khtml/xml/dom_selection.h: Removed UP and DOWN directions, and added PARAGRAPH granularity.
• khtml/xml/dom_selection.cpp: (DOM::Selection::modify): Got rid of the UP and DOWN directions, and made movement between lines happen when granularity is LINE. Added a new unimplemented granularity: PARAGRAPH. (DOM::Selection::validate): Remove some unneeded APPLE_CHANGES. The code need not be ifdef'd. (DOM::Selection::debugPosition): Ditto.

• kwq/WebCoreBridge.h: Removed WebSelectUp and WebSelectDown, and added WebSelectByParagraph. Added stringForRange: and selectedDOMRangeWithGranularity:, and renamed replaceSelectionWithNewline to insertNewline because it has the insertText: semantic, not the replaceSelectionWithText: one.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge stringForRange:]): Added. (-[WebCoreBridge selectedDOMRangeWithGranularity:]): Added. (-[WebCoreBridge alterCurrentSelection:direction:granularity:]): Updated code to understand that vertical movement is based on granularity now, not direction. (-[WebCoreBridge replaceSelectionWithFragment:selectReplacement:]): Moved an ensureCaretVisible from the WebKit down here. I think perhaps this should go down even further in WebCore. (-[WebCoreBridge insertNewline]): Renamed, and moved ensureCaretVisible here. (-[WebCoreBridge insertText:]): Moved ensureCaretVisible here. (-[WebCoreBridge deleteKeyPressed]): Moved ensureCaretVisible here.

• khtml/xml/dom_position.cpp: Some ifdef tweaks.

• khtml/misc/helper.cpp: Namespace and formatting tweaks.
• khtml/misc/helper.h: Removed some unused stuff.

• khtml/dom/dom2_range.h: Make range constructor public so that anyone with a RangeImpl can easily make a Range.

WebKit:

Reviewed by Ken.

• various editing-related improvements
• fixed <rdar://problem/3655366>: (Editing: -selectParagraph: method unimplemented (WebKit editing API))
• fixed <rdar://problem/3655367>: (Editing: -selectLine: method unimplemented (WebKit editing API))
• fixed <rdar://problem/3655369>: (Editing: -selectWord: method unimplemented (WebKit editing API))
• fixed <rdar://problem/3655392>: (Editing: -uppercaseWord: method unimplemented (WebKit editing API))
• fixed <rdar://problem/3655393>: (Editing: -lowercaseWord: method unimplemented (WebKit editing API))
• fixed <rdar://problem/3655394>: (Editing: -capitalizeWord: method unimplemented (WebKit editing API))

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _alterCurrentSelection:direction:granularity:]): Removed the call to ensureCaretVisible. This is now handled on the other side of the bridge. (-[WebHTMLView moveDown:]): Changed to use WebSelectByLine granularity instead of WebSelectDown direction. (-[WebHTMLView moveDownAndModifySelection:]): Ditto. (-[WebHTMLView moveUp:]): Ditto. (-[WebHTMLView moveUpAndModifySelection:]): Ditto. (-[WebHTMLView _expandSelectionToGranularity:]): Added. (-[WebHTMLView selectParagraph:]): Implemented by calling _expandSelectionToGranularity. (-[WebHTMLView selectLine:]): Ditto. (-[WebHTMLView selectWord:]): Ditto. (-[WebHTMLView _fontManagerOperationAsStyle]): Added. Placeholder for the job of figuring out what style change to make based on NSFontManager. (-[WebHTMLView changeFont:]): Implemented, but not really tested because guts are still missing due to lack of above method. (-[WebHTMLView insertTab:]): Removed the call to ensureCaretVisible. (-[WebHTMLView insertNewline:]): Removed the call to ensureCaretVisible. (-[WebHTMLView insertParagraphSeparator:]): Made this insert a newline for now. (-[WebHTMLView _changeWordCaseWithSelector:]): Added. (-[WebHTMLView uppercaseWord:]): Implemented by calling _changeWordCaseWithSelector. (-[WebHTMLView lowercaseWord:]): Ditto. (-[WebHTMLView capitalizeWord:]): Ditto. (-[WebHTMLView deleteBackward:]): Removed the call to ensureCaretVisible. (-[WebHTMLView checkSpelling:]): Put a pile of AppKit code in here as a placeholder. (-[WebHTMLView startSpeaking:]): Use the new stringForRange: method instead of outerText. That way we can handle cases where the entire document is selected. (-[WebHTMLView insertText:]): Removed the call to ensureCaretVisible.

2:40 PM Changeset in webkit [6730] by rjw

• 4 edits in trunk/WebCore

setStrokeColor and setFillColor now support
old school web color string, oswcs+alpha, gray, gray+alpha,
rgba, and cmyka.

Reviewed by jay-lo.

• khtml/css/cssparser.cpp: (CSSParser::parseColor): (CSSParser::parseColorFromValue):
• khtml/css/cssparser.h: Made parseColor static public class method
• khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):

12:41 PM Changeset in webkit [6729] by cblu

• 3 edits in trunk/WebKit

Fixed: <rdar://problem/3672129>: (selection deselects when clicking editable WebView in background window)

Fixed this problem by using NSTextView's approach of only allowing dragging on first mouse down.

Reviewed by john.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView acceptsFirstMouse:]): store the first mouse down (-[WebHTMLView mouseDown:]): Don't tell WebCore about the first mouse down event since only dragging can occur on the first mouse down. (-[WebHTMLView mouseDragged:]): Don't tell WebCore about the drags that occur after the first mouse down since only dragging can occur after the first mouse down.
• WebView.subproj/WebHTMLViewInternal.h:

12:33 PM Changeset in webkit [6728] by hyatt

• 15 edits in trunk/WebCore

Implement -khtml-user-select and add support for the property -khtml-user-drag (although someone will still
need to wire it up).

Reviewed by rjw

• khtml/css/cssparser.cpp: (CSSParser::parseValue):
• khtml/css/cssproperties.c: (hash_prop): (findProp):
• khtml/css/cssproperties.h:
• khtml/css/cssproperties.in:
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
• khtml/css/cssvalues.c: (hash_val): (findValue):
• khtml/css/cssvalues.h:
• khtml/css/cssvalues.in:
• khtml/khtml_part.cpp: (KHTMLPart::handleMousePressEventDoubleClick): (KHTMLPart::handleMousePressEventTripleClick): (KHTMLPart::handleMousePressEventSingleClick): (KHTMLPart::handleMouseMoveEventSelection):
• khtml/rendering/render_canvas.cpp: (RenderCanvas::setSelection):
• khtml/rendering/render_object.cpp: (RenderObject::shouldSelect):
• khtml/rendering/render_object.h:
• khtml/rendering/render_style.cpp: (userSelect): (StyleCSS3NonInheritedData::operator==): (RenderStyle::diff):
• khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::userDrag): (khtml::RenderStyle::userSelect): (khtml::RenderStyle::setUserDrag): (khtml::RenderStyle::setUserSelect): (khtml::RenderStyle::initialUserDrag): (khtml::RenderStyle::initialUserSelect):

11:33 AM Changeset in webkit [6727] by ouch

• 4 edits in trunk/WebCore

added addArc and clip path routines.

Reviewed by sullivan.

• khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):
• khtml/ecma/kjs_html.h: (KJS::Context2D::):
• khtml/ecma/kjs_html.lut.h: (KJS::):

11:00 AM Changeset in webkit [6726] by kdecker

• 1 edit in trunk/WebKit/ChangeLog

• WebView.subproj/WebView.m: At Ken's suggestion, for better efficiency and safety, use _cmd rather than explicit selector names in the forwarding methods.

10:57 AM Changeset in webkit [6725] by kdecker

• 1 edit in trunk/WebKit/ChangeLog

• WebView.subproj/WebView.m: At Ken's suggestion, for better efficiency and safety, use _cmd rather than explicit selector names in the forwarding methods.

10:47 AM Changeset in webkit [6724] by kdecker

• 1 edit in trunk/JavaScriptCore/ChangeLog

Reviewed by Ken.

-revised generated error message content

• kjs/error_object.cpp: (ErrorProtoFuncImp::call):
• kjs/internal.cpp: (Parser::parse):
• kjs/object.cpp: (KJS::Error::create):

10:21 AM Changeset in webkit [6723] by darin

• 2 edits in trunk/WebKit

• WebView.subproj/WebView.m: At Ken's suggestion, for better efficiency and safety, use _cmd rather than explicit selector names in the forwarding methods.

10:21 AM Changeset in webkit [6722] by kdecker

• 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Added addArcToPoint and addRect path routines.

Reviewed by sullivan.

• khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):
• khtml/ecma/kjs_html.h: (KJS::Context2D::):
• khtml/ecma/kjs_html.lut.h: (KJS::):

10:14 AM Changeset in webkit [6721] by darin

• 9 edits
  1 add in trunk/WebKit

Reviewed by Ken.

• implemented a few more editing operations, moved code from WebView to WebHTMLView

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge respondToChangedContents]): Call _updateFontPanel on the WebHTMLView, not the WebView. (-[WebBridge respondToChangedSelection]): Ditto.

• WebView.subproj/WebHTMLView.m: Moved WebElementOrTextFilter class here from WebView and gave it a prefix so it won't conflict with developers' class names. (-[WebHTMLView _updateFontPanel]): Moved here from WebView.

• WebView.subproj/WebView.m: (-[WebView toggleSmartInsertDelete:]): Added. (-[WebView toggleContinuousSpellChecking:]): Added. (-[WebView isContinuousGrammarCheckingEnabled]): Added. (-[WebView setContinuousGrammarCheckingEnabled:]): Added. (-[WebView toggleContinuousGrammarChecking:]): Added. (-[WebView setSmartInsertDeleteEnabled:]): Implemented. We have the flag now, although we still don't actually have smart insert and delete implemented. (-[WebView smartInsertDeleteEnabled]): Ditto. (-[WebView setContinuousSpellCheckingEnabled:]): Implemented. (-[WebView isContinuousSpellCheckingEnabled]): Implemented. (-[WebView spellCheckerDocumentTag]): Implemented. (-[WebView _preflightSpellCheckerNow:]): Added. (-[WebView _preflightSpellChecker]): Added. (-[WebView _continuousCheckingAllowed]): Added.

• WebView.subproj/WebHTMLViewInternal.h: Added. We'll things here from WebHTMLViewPrivate so they are internal to the framework, rather than SPI.
• WebKit.pbproj/project.pbxproj: Added WebHTMLViewInternal.h.
• WebView.subproj/WebHTMLViewPrivate.h: Moved WebHTMLViewPrivate into the internal header. Despite its name, it's internal, not SPI.

• WebView.subproj/WebViewPrivate.h: Moved WebViewPrivate into the internal header. Despite its name, it's internal, not SPI. Added a number of new operations which should be public API. We'll have to figure out what to do about API review and the WWDC deadline.
• WebView.subproj/WebViewInternal.h: Removed _updateFontPanel method.

• English.lproj/StringsNotToBeLocalized.txt: Update.

8:54 AM Changeset in webkit [6720] by ouch

• 4 edits in trunk/WebCore

Added addArcToPoint and addRect path routines.

Reviewed by sullivan.

• khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):
• khtml/ecma/kjs_html.h: (KJS::Context2D::):
• khtml/ecma/kjs_html.lut.h: (KJS::):

7:19 AM Changeset in webkit [6719] by kocienda

• 6 edits in trunk

Tests:

Reviewed by Maciej.

• moved to new symlink technique for embedding frameworks

• Blot/Blot.xcode/project.pbxproj: Call the new create-framework-symlinks script instead of copy-frameworks-to-dstroot.sh.
• Blot/embed-frameworks.sh: Removed.

• PDFViewer/PDFViewer.pbproj/project.pbxproj: Call the new create-framework-symlinks script instead using a copy files phase.

WebCore:

Reviewed by John

• khtml/xml/dom_selection.cpp: (DOM::Selection::toRange): Add call to update document layout before returning a Range. This is done to ensure recently-done editing changes are reflected in the calculation of the Range. This change solves a specific problem with updating the font panel, where the wrong Range was used, resulting in an incorrect font. Also, defer converting positions to be range-compliant positions. The nodeIsBeforeNode function is not range-compliant-position-savvy.

WebKit:

Reviewed by John

The font panel now updates correctly, reflecting the current selection. There may
still be some bugs and corner cases to handle, but this will work for a general
implementation of the feature.

• WebView.subproj/WebView.m: (+[ElementOrTextFilter filter]): Added. This filter will accept DOM elements and text nodes and skip everything else. This filter is used when walking a selection to determine the fonts in use. (-[ElementOrTextFilter acceptNode:]): DOM node filter implementation method. (-[WebView _fontFromStyle]): Removed, in lieu of new fontForCurrentPosition call on the bridge. (-[WebView _updateFontPanel]): Reworked to use a TreeWalker instead of a NodeIterator. This was done since the iterator must be rooted at the document root, but start iterating at the start of the selection. TreeWalker's setCurrentNode allows this to be done.

May 27, 2004:

8:02 PM Changeset in webkit [6718] by kdecker

• 2 edits in trunk/WebKit

WebBrowser:

Reviewed by Ken.

-added the Error Console feature

• ChangeLog:
• Debug/ErrorConsoleController.h: Added.
• Debug/ErrorConsoleController.m: Added. (+[ErrorConsoleController sharedController]): (-[ErrorConsoleController init]): (-[ErrorConsoleController windowNibName]): (-[ErrorConsoleController awakeFromNib]): (-[ErrorConsoleController addMessage:]):
• Debug/ErrorConsoleModel.h: Added.
• Debug/ErrorConsoleModel.m: Added. (-[ErrorConsoleModel init]): (-[ErrorConsoleModel addErrorToModel:]): (-[ErrorConsoleModel setTable:]): (-[ErrorConsoleModel numberOfRowsInTableView:]): (-[ErrorConsoleModel tableView:objectValueForTableColumn:row:]): (-[ErrorConsoleModel tableView:willDisplayCell:forTableColumn:row:]):

7:06 PM Changeset in webkit [6717] by kdecker

• 16 edits in trunk

JavaScriptCore:

Reviewed by Ken.

-revised generated error message content

• kjs/error_object.cpp: (ErrorProtoFuncImp::call):
• kjs/internal.cpp: (Parser::parse):
• kjs/object.cpp: (KJS::Error::create):

WebCore:

Reviewed by Ken.

-wired up JavaScript error message handling to
the WebCoreBridge

• khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent):
• khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate):
• khtml/ecma/kjs_window.cpp: (Window::isSafeScript): (ScheduledAction::execute):
• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::addMessageToConsole):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm:

WebKit:

Reviewed by Ken.

-wired up JavaScript error message handling through
the WebCoreBridge

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge addMessageToConsole:]):
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebUIDelegatePrivate.h:

WebBrowser:

Reviewed by Ken.

-added the JavaScript Console feature

• BrowserWebController.m: (-[BrowserWebView setWindowFocusDisabled:]): (-[BrowserWebView webView:addMessageToConsole:]):
• Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): (-[BrowserDocument showJavaScriptConsole:]):
• WebBrowser.pbproj/project.pbxproj:

5:14 PM Changeset in webkit [6716] by trey

• 3 edits in trunk/WebCore

Two dragging tweaks: ondragleave events are sent before ondragenter events when
going across element boundaries, to match WinIE.
For compatibility with WinIE, we honor MIME types of "Text" and "URL".

Reviewed by rjw.

• khtml/khtmlview.cpp: (KHTMLView::updateDragAndDrop):
• kwq/KWQClipboard.mm: (cocoaTypeFromMIMEType):

4:28 PM Changeset in webkit [6715] by vicki

• 3 edits in trunk

• Change version number to '143u'. The tree is open!

4:22 PM Changeset in webkit [6714]

• 3 copies in tags/Safari-142

This commit was manufactured by cvs2svn to create tag 'Safari-142'.

4:22 PM Changeset in webkit [6713] by vicki

• 6 edits in trunk

Safari-142 stamp

4:05 PM Changeset in webkit [6712] by vicki

• 7 edits in trunk/WebCore

Reviewed by Darin.

• Fix Tiger build failure. Rename constant "S" to "WHITESPACE", and change all instances of S to WHITESPACE.

• khtml/css/cssparser.cpp: (DOM::CSSParser::lex): S to WHITESPACE
• khtml/css/parser.cpp: regenerated file
• khtml/css/parser.h: regenerated file
• khtml/css/parser.y: S to WHITESPACE
• khtml/css/tokenizer.cpp: regenerated file
• khtml/css/tokenizer.flex: S to WHITESPACE

3:46 PM Changeset in webkit [6711] by rjw

• 2 edits in trunk/JavaScriptCore

Renamed WebScriptMethods to WebScripting based on feedback
from Nancy.

Reviewed by Chris.

• bindings/objc/WebScriptObject.h:

11:28 AM Changeset in webkit [6710] by ouch

• 4 edits in trunk/WebCore

Added support for fillRect, strokeRect, and setAlpha.

reviewed by richard.

• khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):
• khtml/ecma/kjs_html.h: (KJS::Context2D::):
• khtml/ecma/kjs_html.lut.h: (KJS::):

10:11 AM Changeset in webkit [6709] by trey

• 23 edits
  2 adds in trunk

WebCore:

First cut at DHTML dragging, destination side. Dragging text, files

and URLs onto elements works. Type conversion from NSPasteboard to
MIME types is hardwired. No JS access yet to modifier keys, or
drag operations mask.

Per IE's dragging API, we have the new DOM events ondragenter,
ondragover, ondragleave and ondrop.
We also have an event.dataTransfer object providing access to the
NSPasteboard bearing the incoming data.

Reviewed by rjw.

• WebCore.pbproj/project.pbxproj: add 2 new files.
• khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): JS access to ondragenter and pals (DOMNode::putValue): Ditto
• khtml/ecma/kjs_dom.h: (KJS::DOMNode::): New attr enum values.
• khtml/ecma/kjs_dom.lut.h: (KJS::):
• khtml/ecma/kjs_events.cpp: (DOMMouseEvent::mark): Pass along mark to dataTransfer we hold. (DOMMouseEvent::getValueProperty): Create and return dataTransfer. (Clipboard::Clipboard): New class exposed in JS. (Clipboard::~Clipboard): (Clipboard::tryGet): Boilerplate. (Clipboard::getValueProperty): Return the clipboard's props. (Clipboard::tryPut): Boilerplate. (Clipboard::putValue): Set the clipboard's props. (ClipboardProtoFunc::tryCall): Implement clipboard's funcs.
• khtml/ecma/kjs_events.h: (KJS::DOMMouseEvent::DOMMouseEvent): Init clipboard ptr. (KJS::DOMMouseEvent::): (KJS::Clipboard::toBoolean): (KJS::Clipboard::classInfo): (KJS::Clipboard::):
• khtml/ecma/kjs_events.lut.h: (KJS::):
• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseHTMLAttribute): Enable setting ondragenter and friends as html attributes.
• khtml/khtmlview.cpp: (KHTMLView::dispatchDragEvent): Send a drag related event to the DOM. (KHTMLView::updateDragAndDrop): Handle a dragenter or dragupdate. (KHTMLView::cancelDragAndDrop): Handle a dragexit. (KHTMLView::performDragAndDrop): Handle an actual drop.
• khtml/khtmlview.h:
• khtml/misc/htmlattrs.c: Generated code.
• khtml/misc/htmlattrs.h: Generated code.
• khtml/misc/htmlattrs.in: Add ondragenter, etc
• khtml/xml/dom2_eventsimpl.cpp: (EventImpl::typeToId): Handle new event types for dragging. (EventImpl::idToType): Ditto. (MouseEventImpl::MouseEventImpl): Init new clipboard ptr. (MouseEventImpl::~MouseEventImpl): Deref clipboard. (ClipboardImpl::ClipboardImpl): (ClipboardImpl::~ClipboardImpl):
• khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::): New event enums. (DOM::MouseEventImpl::clipboard):
• kwq/KWQClipboard.h: Added.
• kwq/KWQClipboard.mm: Added. (KWQClipboard::KWQClipboard): (KWQClipboard::~KWQClipboard): (KWQClipboard::isForDragging): Trivial getter/setters. (KWQClipboard::dropEffect): (KWQClipboard::setDropEffect): (KWQClipboard::dropAllowed): (KWQClipboard::setDropAllowed): (cocoaTypeFromMIMEType): Convert MIME pboard type to Cocoa type. (KWQClipboard::clearData): OSX specific clipboard impl. of IE func (KWQClipboard::clearAllData): Ditto (KWQClipboard::getData): Ditto (KWQClipboard::setData): Ditto
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge dragOperationForDraggingInfo:]): Passthrough from WebKit to khtmlpart (-[WebCoreBridge dragExitedWithDraggingInfo:]): Ditto (-[WebCoreBridge concludeDragForDraggingInfo:]): Ditto

WebKit:

First cut at DHTML dragging, destination side. Dragging text, files and URLs onto
elements works. Type conversion from NSPasteboard to MIME types is hardwired.
No JS access yet to modifier keys, or operations mask.

Reviewed by Chris.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView draggingUpdatedWithDraggingInfo:]): Call DHTML dragging via bridge. (-[WebHTMLView draggingCancelledWithDraggingInfo:]): Ditto. (-[WebHTMLView concludeDragForDraggingInfo:]): Ditto.
• WebView.subproj/WebHTMLViewPrivate.h:
• WebView.subproj/WebView.m: (-[WebView _setWebKitDragRespondsToDragging:]): New SPI for finer grained control than the delegate currently has. (-[WebView _webKitDragRespondsToDragging]): Ditto. (-[WebView _commonInitializationWithFrameName:groupName:]): Init new flag. (-[WebView _dragOperationForDraggingInfo:]): Comment.
• WebView.subproj/WebViewPrivate.h:

9:26 AM Changeset in webkit [6708] by kocienda

• 5 edits in trunk/WebCore

Reviewed by Gramps

• kwq/KWQKHTMLPart.h: Declare new fontForCurrentPosition helper.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::fontForCurrentPosition): Determines the "current font" in the way that Cocoa does. Either the font of the character before the caret, when the selection is a caret, or the font of the first character selected, when the selection is a range.
• kwq/WebCoreBridge.h: Declare bridge method so this can be called from WebKit.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge fontForCurrentPosition]): Calls through to fontForCurrentPosition on KWQKHTMLPart.

9:22 AM Changeset in webkit [6707] by kocienda

• 4 edits in trunk/WebCore

Reviewed by Gramps

Adds a typing style member variable to khtml part.
This patch adds basic life-cycle management and
accessors. In addition, one essential piece of
behavior has been added: Clearing the typing style
whenever the selection changes.

Follow-on work will make this typing style a fully
functional part of applying styles to text while typing.

• khtml/khtml_part.cpp: (KHTMLPart::notifySelectionChanged): Clear typing style. (KHTMLPart::typingStyle): Getter. (KHTMLPart::setTypingStyle): Setter. (KHTMLPart::clearTypingStyle): Convenience. Sets to 0.
• khtml/khtml_part.h: Function declarations.
• khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): Initialize member variable. (KHTMLPartPrivate::~KHTMLPartPrivate): Deref if necessary.

9:18 AM Changeset in webkit [6706] by kocienda

• 3 edits in trunk/WebCore

Reviewed by Gramps

Add helper to get the DOM element for a Position.

• khtml/xml/dom_position.cpp: (DOM::Position::element): Returns the Position's node if it is an element, or the first ancestor of the node that is an element. Returns 0 if node is not an element and has no parent that is an element.
• khtml/xml/dom_position.h: Added declaration.

1:18 AM Changeset in webkit [6705] by darin

• 2 edits in trunk/WebKit

• WebView.subproj/WebFrameView.m: (-[WebFrameView _scrollVerticallyBy:]): Added comment.

1:14 AM Changeset in webkit [6704] by darin

• 7 edits in trunk/WebKit

Reviewed by Maciej.

• fixed <rdar://problem/3667948>: (REGRESSION: Page Down key goes down two pages when smooth scrolling is on)

• WebView.subproj/WebFrameView.m: (-[WebFrameView _scrollVerticallyBy:]): Added return value to indicate if any scrolling was done. This requires using secret AppKit methods; the public methods don't have a return value. (-[WebFrameView _pageVertically:]): Added return value to indicate if any scrolling was done. (-[WebFrameView scrollPageUp:]): Base call through to next responder on whether any scrolling was done, using return value, rather than looking at new scroll position. This was the cause of the bug, since with smooth scrolling no scrolling has happened yet when the function returns. (-[WebFrameView scrollPageDown:]): Ditto.

• removed temporary DOMDocument method from WebView

• WebView.subproj/WebView.m: (-[WebView computedStyleForElement:pseudoElement:]): Call getComputedStyle on the document that owns the element rather than on the document that currently contains the selection. (-[WebView _updateFontPanel]): Get the document from the DOM range rather than using the DOMDocument method. (-[WebView styleDeclarationWithText:]): Change this method to not use the DOMDocument method, but do the same job with inline code.

• WebView.subproj/WebViewPrivate.h: Moved a recently-added category that is not SPI out of here.
• WebView.subproj/WebViewInternal.h: Moved the category in here. And removed the DOMDocument method from it.

• other changes

• English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

• copy-webcore-files-to-webkit: Change tabs to spaces. Quiet the script down by making it no longer echo each command or print messages about what it's doing by default.

12:36 AM Changeset in webkit [6703] by darin

• 2 edits in trunk/WebKit

Reviewed by Maciej.

• moved to new symlink technique for embedding frameworks

• WebKit.pbproj/project.pbxproj: Get rid of embed-frameworks build step because we don't need it any more.

12:32 AM Changeset in webkit [6702] by darin

• 2 edits in trunk/WebCore

Reviewed by Maciej.

• moved to new symlink technique for embedding frameworks

• WebCore.pbproj/project.pbxproj: Get rid of embed-frameworks build step because we don't need it any more.

12:31 AM Changeset in webkit [6701] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

• moved to new symlink technique for embedding frameworks

• JavaScriptCore.pbproj/project.pbxproj: Get rid of embed-frameworks build step because we don't need it any more.

12:11 AM Changeset in webkit [6700] by darin

• 2 edits in trunk/WebKit

• fixed Deployment build

• WebView.subproj/WebView.m: (-[WebView concludeDragOperation:]): Got rid of ASSERT-only local variable.

12:10 AM Changeset in webkit [6699] by darin

• 2 edits in trunk/WebCore

• fixed bug where all pages with images would cause a crash
• fixed Deployment build

• kwq/KWQPainter.mm: (QPainter::drawPixmap): Put #if 0 around placeholder code for setting up the graphics context.