Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Jun 10, 2004:

5:08 PM Changeset in webkit [6813] by vicki

• 3 edits in trunk

set version number to 145u; the tree is open

5:00 PM Changeset in webkit [6812]

• 3 copies in tags/Safari-144

This commit was manufactured by cvs2svn to create tag 'Safari-144'.

5:00 PM Changeset in webkit [6811] by vicki

• 6 edits in trunk

Safari-144 stamp

2:19 PM Changeset in webkit [6810] by kdecker

• 6 edits in trunk

JavaScriptCore:

Reviewed by John.

• kjs/lexer.cpp: (Lexer::setCode):
  • fixed <rdar://problem/3682398>: (error console line numbers are offset by 1)
• kjs/lexer.h: (KJS::Lexer::lineNo):
  • fixed <rdar://problem/3682398>: (error console line numbers are offset by 1)

WebKit:

Reviewed by John.

• WebView.subproj/WebResource.m: (-[WebResource description]):

-added per request of cblu

(-[WebResource _response]):

-added this method to the header

(-[WebResource _stringValue]):

• gives the string value of the NSData representation

• WebView.subproj/WebResourcePrivate.h:

WebBrowser:

Reviewed by John.

• BrowserDocumentController.h:
• BrowserDocumentController.m: -added support to open an HTMLSourceDocument powered by a WebResource (-[BrowserDocumentController openHTMLSourceDocumentWithResource:]):
• Debug/DebugUtilities.m: (-[BrowserDocument showJavaScriptConsole:]):
• Debug/ErrorCell.m:
  • doesn't display "Line:" if a line number is not present
  • magic numbers are now #define'd

(-[ErrorCell drawInteriorWithFrame:inView:]):

• Debug/ErrorConsoleController.h:
• Debug/ErrorConsoleController.m: (-[ErrorConsoleController init]): (-[ErrorConsoleController awakeFromNib]):
  • properly set the model's table view here, instead of init

(-[ErrorConsoleController clear:]):

• removes errors from the model

(-[ErrorConsoleController findResourceInWebFrame:forURL:]):

• fixes <rdar://problem/3682337>: (safari error console does not open the correct source document when an error is double-clicked)

(-[ErrorConsoleController findResourceInDocument:forURL:]):

• fixes <rdar://problem/3682337>: (safari error console does not open the correct source document when an error is double-clicked)

(-[ErrorConsoleController findResourceInURL:]):

• fixes <rdar://problem/3682337>: (safari error console does not open the correct source document when an error is double-clicked)

(-[ErrorConsoleController showPageSourceWindow:]):

• fixes <rdar://problem/3682337>: (safari error console does not open the correct source document when an error is double-clicked)

• Debug/ErrorConsoleModel.h:
• Debug/ErrorConsoleModel.m: (-[ErrorConsoleModel setTable:]): (-[ErrorConsoleModel selectedURL]): (-[ErrorConsoleModel selectedLineNumber]):
• HTMLSourceController.h:
• HTMLSourceController.m: (-[HTMLSourceController selectLineAtIndex:]): (-[HTMLSourceController textView]): (-[HTMLSourceController rangeForLine:]):
  • fixes rdr://problem/3682360 (error console should highlight/select offending code when viewing error source)
• HTMLSourceDocument.h:
• HTMLSourceDocument.m: (-[HTMLSourceDocument initWithResource:]): (-[HTMLSourceDocument makeWindowControllers]): (-[HTMLSourceDocument displayName]):
  • now WebResource aware

(-[HTMLSourceDocument resource]):
(-[HTMLSourceDocument setResource:]):

• WebBrowser.pbproj/project.pbxproj:

2:07 PM Changeset in webkit [6809] by kocienda

• 3 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:

<rdar://problem/3654850>: "Style changes do not work across blocks"

Now, applying styles works across blocks. I did quite a bit
of internal redsign on the member functions of this class to
make this work. As a bonus, from an architectural standpoint,
all style changes are now done "in place". There is no more
copying of content in order to perform style changes.

• khtml/editing/htmlediting_impl.cpp: (khtml::ApplyStyleCommandImpl::doApply): (khtml::ApplyStyleCommandImpl::removeHTMLStyleNode): (khtml::ApplyStyleCommandImpl::removeCSSStyle): (khtml::ApplyStyleCommandImpl::removeStyle): (khtml::ApplyStyleCommandImpl::nodeFullySelected): (khtml::ApplyStyleCommandImpl::splitTextAtStartIfNeeded): (khtml::ApplyStyleCommandImpl::splitTextAtEndIfNeeded): (khtml::ApplyStyleCommandImpl::surroundNodeRangeWithElement): (khtml::ApplyStyleCommandImpl::applyStyleIfNeeded): (khtml::ApplyStyleCommandImpl::positionInsertionPoint):
• khtml/editing/htmlediting_impl.h:

1:36 PM Changeset in webkit [6808] by darin

• 15 edits in trunk

WebCore:

Reviewed by Ken.

• filled out execCommand a lot more
• fixed <rdar://problem/3685231>: (execCommand italic is not implemented)
• fixed <rdar://problem/3685232>: (execCommand bold is not implemented)
• fixed <rdar://problem/3675899>: (Make queryCommandIndeterm work as specified in the Javascript execCommand Compatibility Plan)
• fixed <rdar://problem/3675901>: (Make queryCommandState work as specified in the Javascript execCommand Compatibility Plan)
• fixed <rdar://problem/3675904>: (Make queryCommandValue work as specified in the Javascript execCommand Compatibility Plan)

• khtml/editing/jsediting.cpp: (DOM::JSEditor::queryCommandIndeterm): Changed to use KHTMLPart::TriState instead of CommandState. (DOM::JSEditor::queryCommandState): Ditto. (execStyleChange): Changed to use KHTMLPart::applyStyle. (stateStyle): Used KHTMLPart::selectionHasStyle for this. (selectionStartHasStyle): Use KHTMLPart::selectionStartHasStyle for this. (valueStyle): Used KHTMLPart::selectionStartStylePropertyValue for this. (execBold): Implemented toggling, using selectionStartHasStyle. (execItalic): Implemented toggling, using selectionStartHasStyle. (execPrint): Implemented. (enabledRedo): Implemented, using canRedo. (enabledUndo): Implemented, using canUndo. (stateNone): Renamed from stateNo. (valueBackColor): Implemented, using valueStyle. (valueFontName): Implemented, using valueStyle. (valueFontSize): Implemented, using valueStyle. (valueForeColor): Implemented, using valueStyle. (valueFontSize): Implemented, using valueStyle.

• khtml/khtml_part.h: Added editing operations.
• khtml/khtml_part.cpp: (KHTMLPart::copyToPasteboard): Added. (KHTMLPart::cutToPasteboard): Added. (KHTMLPart::redo): Added. (KHTMLPart::undo): Added. (KHTMLPart::applyStyle): Added. (updateState): Added. (KHTMLPart::selectionHasStyle): Added. (KHTMLPart::selectionStartHasStyle): Added. (KHTMLPart::selectionStartStylePropertyValue): Added. (KHTMLPart::selectionComputedStyle): Added. (KHTMLPart::print): Added.

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Call print() on plain old part, not KWQ(part).

• kwq/KWQKHTMLPart.h: Removed print(), added _haveUndoRedoOperations.
• kwq/KWQKHTMLPart.mm: (KHTMLPart::print): Moved from KWQKHTMLPart to KHTMLPart. (KWQKHTMLPart::registerCommandForUndo): Moved code here from bridge. (KWQKHTMLPart::registerCommandForRedo): Moved code here from bridge. (KWQKHTMLPart::clearUndoRedoOperations): Moved code here from bridge. (KWQKHTMLPart::issueUndoCommand): Moved code here from bridge. (KWQKHTMLPart::issueRedoCommand): Moved code here from bridge. (KWQKHTMLPart::issuePasteCommand): Moved code here from bridge. (KHTMLPart::canUndo): Added. (KHTMLPart::canRedo): Added.

• kwq/WebCoreBridge.h: Added undoManager, removed undo-related methods.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge applyStyle:]): Changed to call KHTMLPart::applyStyle.

• WebCore.pbproj/.cvsignore: Updated for new Xcode files.

WebKit:

Reviewed by Ken.

• WebCoreSupport.subproj/WebBridge.m: Removed undo-related methods. (-[WebBridge undoManager]): Added.

• WebKit.pbproj/.cvsignore: Updated for new Xcode files.

9:27 AM Changeset in webkit [6807] by kocienda

• 3 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/3672088>: "Editable WebViews should maintain a selection even when they're not firstResponder"

Add some code to determine whether a WebHTMLView should maintain an
inactive selection when the view is not first responder. Traditionally,
these views have not maintained such selections, clearing them when the
view was not first responder. However, for appls embedding this view as
an editing widget, it is desirable to act more like an NSTextView. For
now, however, the view only acts in this way when the web view is set to
be editable with -[WebView setEditable:YES]. This will maintain
traditional behavior for WebKit clients dating back to before this
change, and will likely be a decent switch for the long term, since
clients to ste the web view to be editable probably want it to act like
a "regular" Cocoa view in terms of its selection behavior.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView updateTextBackgroundColor]): Add code to tell whether the view is resigning first responder, and if it is, use the inactive text background color. (-[WebHTMLView maintainsInactiveSelection]): New helper which does checks to see if the new selection behavior should be used, or whether we should continue with traditional WebKit behavior. (-[WebHTMLView resignFirstResponder]): Call new maintainsInactiveSelection helper. If true, do not clear the selection.
• WebView.subproj/WebHTMLViewInternal.h: Add resigningFirstResponder flag.

Jun 9, 2004:

10:28 PM Changeset in webkit [6806] by mjs

• 4 edits in trunk/WebCore

Reviewed by Dave.

<rdar://problem/3671555>: Blot scrolls to the top every time you type

• khtml/xml/dom_selection.cpp: (DOM::Selection::getRepaintRect): If the caret position is invalid, recompute it.

8:25 PM Changeset in webkit [6805] by hyatt

• 9 edits in trunk/WebCore

Fix for 3607091, implement a style that prevents zoom and min font size from taking effect.
The name of the new style is "-apple-text-size-adjust" with values of "none" and "auto." The default
is "auto."

Reviewed by mjs

• khtml/css/cssparser.cpp: (CSSParser::parseValue):
• khtml/css/cssproperties.c: (hash_prop): (findProp):
• khtml/css/cssproperties.h:
• khtml/css/cssproperties.in:
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::styleForElement): (khtml::CSSStyleSelector::pseudoStyleForElement): (khtml::CSSStyleSelector::applyDeclarations): (khtml::CSSStyleSelector::applyProperty): (khtml::CSSStyleSelector::checkForTextSizeAdjust):
• khtml/css/cssstyleselector.h:
• khtml/rendering/render_style.cpp: (textSizeAdjust): (StyleCSS3InheritedData): (StyleCSS3InheritedData::operator==): (RenderStyle::diff):
• khtml/rendering/render_style.h: (khtml::RenderStyle::lineClamp): (khtml::RenderStyle::textSizeAdjust): (khtml::RenderStyle::setTextSizeAdjust): (khtml::RenderStyle::initialTextSizeAdjust):

4:50 PM Changeset in webkit [6804] by cblu

• 9 edits in trunk/WebKit

Implemented drag destination portion of the new drag & drop API.

Reviewed by trey.

• WebView.subproj/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForDraggingInfo:]): new delegate implementation (-[WebDefaultUIDelegate webView:willPerformDragDestinationAction:forDraggingInfo:]): ditto
• WebView.subproj/WebDocumentInternal.h:
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): handle the action mask (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): ditto
• WebView.subproj/WebUIDelegate.h:
• WebView.subproj/WebUIDelegatePrivate.h:
• WebView.subproj/WebView.m: (-[WebView _dragOperationForDraggingInfo:]): call new delegate methods (-[WebView performDragOperation:]): ditto
• WebView.subproj/WebViewInternal.h:
• WebView.subproj/WebViewPrivate.h:

3:58 PM Changeset in webkit [6803] by hyatt

• 11 edits in trunk/WebCore

Implement parsing and setting of the text-overflow CSS3 property.

Reviewed by kocienda

• khtml/css/cssparser.cpp: (CSSParser::parseValue):
• khtml/css/cssproperties.c: (hash_prop): (findProp):
• khtml/css/cssproperties.h:
• khtml/css/cssproperties.in:
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
• khtml/css/cssvalues.c: (hash_val): (findValue):
• khtml/css/cssvalues.h:
• khtml/css/cssvalues.in:
• khtml/rendering/render_style.cpp: (textOverflow): (StyleCSS3NonInheritedData::operator==): (RenderStyle::diff):
• khtml/rendering/render_style.h: (khtml::RenderStyle::textOverflow): (khtml::RenderStyle::setTextOverflow): (khtml::RenderStyle::initialTextOverflow):

1:19 PM Changeset in webkit [6802] by hyatt

• 22 edits in trunk/WebCore

Fix for 3678031, implement better flexing for Emerson headers. This involved adding support for max-width: intrinsic,
fixing the box layout algorithm to properly deal with max-widths, and implementing support for baseline alignment
so that boxes can be aligned vertically along their interior baselines.

Reviewed by kocienda

• khtml/css/cssparser.cpp: (CSSParser::parseValue): (CSSParser::parseShadow):
• khtml/css/cssparser.h:
• khtml/css/cssproperties.c: (hash_prop): (findProp):
• khtml/css/cssproperties.h:
• khtml/css/cssproperties.in:
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
• khtml/css/cssvalues.c: (hash_val): (findValue):
• khtml/css/cssvalues.h:
• khtml/css/cssvalues.in:
• khtml/misc/khtmllayout.h: (khtml::):
• khtml/rendering/render_block.cpp: (khtml::RenderBlock::baselinePosition): (khtml::RenderBlock::getBaselineOfFirstLineBox):
• khtml/rendering/render_block.h:
• khtml/rendering/render_box.cpp: (RenderBox::RenderBox): (RenderBox::overrideWidth): (RenderBox::overrideHeight): (RenderBox::calcWidth): (RenderBox::calcHeight):
• khtml/rendering/render_box.h: (khtml::RenderBox::overrideSize): (khtml::RenderBox::setOverrideSize):
• khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::calcMinMaxWidth): (khtml::RenderFlexibleBox::layoutBlock): (khtml::RenderFlexibleBox::layoutHorizontalBox): (khtml::RenderFlexibleBox::layoutVerticalBox): (khtml::RenderFlexibleBox::placeChild): (khtml::RenderFlexibleBox::allowedChildFlex):
• khtml/rendering/render_flexbox.h:
• khtml/rendering/render_image.cpp: (RenderImage::isWidthSpecified): (RenderImage::isHeightSpecified):
• khtml/rendering/render_object.h: (khtml::RenderObject::getBaselineOfFirstLineBox): (khtml::RenderObject::overrideSize): (khtml::RenderObject::overrideWidth): (khtml::RenderObject::overrideHeight): (khtml::RenderObject::setOverrideSize):
• khtml/rendering/render_style.cpp: (StyleFlexibleBoxData::StyleFlexibleBoxData): (StyleFlexibleBoxData::operator==): (ShadowData::operator==):
• khtml/rendering/render_style.h: (khtml::RenderStyle::boxPack): (khtml::RenderStyle::setBoxPack):
• khtml/rendering/table_layout.cpp: (AutoTableLayout::layout):

12:46 PM Changeset in webkit [6801] by rjw

• 8 edits in trunk

WebKit:

Implemented PDF rendering for the drawImage() function
in Context2D. This allows PDF files to be drawn in scaled
or rotated context without rasterization artifacts.

The PDF image is currently NOT cached. Caching can/will be added
as an optimization. The hooks are already in place to flush
the cache as necessary.

Reviewed by John.

• WebCoreSupport.subproj/WebImageRenderer.h:
• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer dealloc]): (-[WebImageRenderer _needsRasterFlush]): (-[WebImageRenderer drawClippedToValidInRect:fromRect:]): (-[WebImageRenderer _PDFDocumentRef]): (-[WebImageRenderer _PDFDraw]): (-[WebImageRenderer _PDFDrawFromRect:toRect:operation:alpha:flipped:]): (-[WebImageRenderer MIMEType]): (ReleasePDFDocumentData): (-[WebPDFDocument initWithData:]): (-[WebPDFDocument dealloc]): (-[WebPDFDocument documentRef]): (-[WebPDFDocument mediaBox]): (-[WebPDFDocument bounds]): (-[WebPDFDocument adjustCTM:]): (-[WebPDFDocument setCurrentPage:]): (-[WebPDFDocument currentPage]): (-[WebPDFDocument pageCount]):

Added back check for old plugin API.

• WebView.subproj/WebFrame.m: (-[WebFrame _reloadForPluginChanges]):
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView addSubview:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge frameRequiredForMIMEType:URL:]):

WebCore:

Added support for drawing un-rasterized transformed PDFs.

Reviewed by John.

• khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):

10:29 AM Changeset in webkit [6800] by darin

• 2 edits in trunk/WebCore

Reviewed by Ken.

• implemented still more execCommand commands

• khtml/editing/jsediting.cpp: Added a lot more commands, and reformatted a bit.

Jun 8, 2004:

11:31 PM Changeset in webkit [6799] by darin

• 3 edits in trunk/WebCore

Reviewed by Maciej.

• implemented a bunch more execCommand commands
• fixed <rdar://problem/3684792>: (JavaScript execCommand("paste") presents security issues)
• fixed <rdar://problem/3675898>: (Make queryCommandEnabled work as specified in the Javascript execCommand Compatibility Plan)
• fixed <rdar://problem/3675903>: (Make queryCommandSupported work as specified in the Javascript execCommand Compatibility Plan)
• about half of <rdar://problem/3685231>: (execCommand italic is not implemented)
• about half of <rdar://problem/3685232>: (execCommand bold is not implemented)

• khtml/editing/jsediting.h: Made constructor inline. Deleted a few unneeded member functions that are now just private functions inside jsediting.cpp.

• khtml/editing/jsediting.cpp: (commandImp): Changed this around, so the dictionary is a static local to this function, and initialized with C++ "first time initialization" rule. (DOM::JSEditor::execCommand): Got rid of special case for 0 for function pointer and added const. (DOM::JSEditor::queryCommandEnabled): Ditto. (DOM::JSEditor::queryCommandIndeterm): Got rid of special case for 0 for function pointer, added const, and use a common three-state state function rather than a separate "indeterm" function. (DOM::JSEditor::queryCommandState): Ditto. (DOM::JSEditor::queryCommandValue): More of the same. (execNotImplemented): Added. Used for unimplemented commands; there are only a few left. (execCopy): Renamed. (execCut): Renamed. (execDelete): Renamed. (execInsertText): Renamed. (execPaste): Renamed, and disabled. (execRedo): Renamed. (execSelectAll): Renamed. (execUndo): Renamed. (execStyleChange): Added. Helper function for commands that are style changes. (execBold): Added. (execItalic): Added. (execJustifyCenter): Added. (execJustifyFull): Added. (execJustifyLeft): Added. (execJustifyRight): Added. (execSubscript): Added. (execSuperscript): Added. (execUnselect): Added. (stateNotImplemented): Added. Used for unimplemented state queries; there are a few left. (noState): Added. (valueNotImplemented): Added. Used for unimplemented value queries; there are a few left. (nullStringValue): Added. (createCommandDictionary): Changed the initDict function into this function. Added implementations for many commands and condensed format so it's easier to work with.

5:55 PM Changeset in webkit [6798] by trey

• 2 edits in trunk/WebKit

In DHTML dragging there is no notion of registering for types, so we'd
like to just pass all types down to WebCore. It turns out that the per-type
registration doesn't matter as far as the underlying drag service is
concerned, so Cocoa is already getting called for any type. We just hack and
override a private method to ensure we accept any type.

Reviewed by Chris.

• WebView.subproj/WebView.m: (-[WebView _hitTest:dragTypes:]): We accept any drag type if it is within our view, without overriding a subview's decision.

5:37 PM Changeset in webkit [6797] by trey

• 1 edit in trunk/WebCore/kwq/KWQKHTMLPart.mm

Nit build fix for deployment build style.

5:03 PM Changeset in webkit [6796] by darin

• 6 edits in trunk/WebCore

Reviewed by Vicki.

• our part of fix to <rdar://problem/3629334>: (REGRESSION (Tiger): titles on pop-ups menus are truncated and show ellipses)

• kwq/KWQComboBox.mm: (QComboBox::QComboBox): Call setLineBreakMode:NSLineBreakByClipping. In the current version of Tiger I am using, this is not implemented yet.

• a couple of other unrelated changes

• khtml/rendering/render_form.cpp: (RenderTextArea::calcMinMaxWidth): Put a little more code inside the APPLE_CHANGES ifdef.
• kwq/KWQTextEdit.h: Remove unused setTabStopWidth function, and make empty setTextFormat function an inline for slightly smaller code size.
• kwq/KWQTextEdit.mm: Ditto.
• kwq/KWQTextField.mm: Update copyright date.

3:17 PM Changeset in webkit [6795] by trey

• 7 edits in trunk

WebCore:

A DHTML drag source can now change the dragging image during the drag. Currently
it may only be set to a static image.

Reviewed by John

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::dragSourceMovedTo): If the ondrag event handler set an image, pass it to WebKit.
• kwq/WebCoreBridge.h:

WebKit:

A DHTML drag source can now change the dragging image during the drag. Currently
it may only be set to a static image.

Reviewed by John

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setDraggingImage:at:]): Typical bridge glue.
• WebView.subproj/WebHTMLView.m: (FlipImageSpec): New utility, copied from AppKit. (-[WebHTMLView _setDraggingImage:at:]): Mostly copied from AppKit. Sets the drag image using CG API.
• WebView.subproj/WebHTMLViewPrivate.h:

2:53 PM Changeset in webkit [6794] by kocienda

• 4 edits in trunk

Reviewed by Hyatt

Changes to the selection state for these tests as a result of my previous
checkin. The changes are minor to a couple of offsets. I looked at the
changes and approve them.

• layout-tests/editing/deleting/delete-block-contents-001-expected.txt
• layout-tests/editing/deleting/delete-block-contents-002-expected.txt
• layout-tests/editing/deleting/delete-block-contents-003-expected.txt

2:50 PM Changeset in webkit [6793] by cblu

• 4 edits in trunk/WebKit

Fixed: <rdar://problem/3640423>: (REGRESSION: can't paste text copied from web page into Excel (due to HTML on the pasteboard?))

Reviewed by darin.

• WebView.subproj/WebHTMLView.m: (+[WebHTMLView _selectionPasteboardTypes]): don't include NSHTMLPboardType (-[WebHTMLView _selectedArchive]): removed markup string parameter (_selectionPasteboardTypes::if): don't put NSHTMLPboardType on the pasteboard
• WebView.subproj/WebHTMLViewPrivate.h:

2:49 PM Changeset in webkit [6792] by kocienda

• 5 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3654841>: "Hitting delete key with start of block selected
does not merge content with preceding block"

Selections that span blocks now work correctly for deleting the selection and inserting
over the selection. The largest part of the change is adding a new field to the
RemoveNodeAndPruneCommand and its impl version. This was done since the starting block
for a multi-block selection should always be preserved when deleting, and this was
a convenient way to express this using the code structure already in place.

• khtml/editing/htmlediting.cpp: (khtml::RemoveNodeAndPruneCommand::RemoveNodeAndPruneCommand): Modify this command to take two nodes: the node to remove and a node to stop at when pruning back up the tree. (khtml::RemoveNodeAndPruneCommand::pruneNode): New accessor, replaces old node() accessor. (khtml::RemoveNodeAndPruneCommand::stopNode): New accessor for additional feature described above.
• khtml/editing/htmlediting.h:
• khtml/editing/htmlediting_impl.cpp: (khtml::shouldPruneNode): blow flow renderers can now be deleted, but not if they are a rootEditableElement. (khtml::CompositeEditCommandImpl::removeNodeAndPrune): Pass new stopNode param and change the name of the existing node argument to pruneNode to distinguish it. (khtml::DeleteSelectionCommandImpl::doApply): Pass the block containing the start of the selection to removeNodeAndPrune in each case. Also, add one little loop to move all the content from the block containing the end of the selection if that block is different than the start block. (khtml::RemoveNodeAndPruneCommandImpl::RemoveNodeAndPruneCommandImpl): Implement the pruneNode/stopNode design already described. (khtml::RemoveNodeAndPruneCommandImpl::~RemoveNodeAndPruneCommandImpl): Manage the lifecycle of stopNode. (khtml::RemoveNodeAndPruneCommandImpl::doApply): Add a check to stop at the stop node while pruning.
• khtml/editing/htmlediting_impl.h: (khtml::RemoveNodeAndPruneCommandImpl::pruneNode): New accessor. (khtml::RemoveNodeAndPruneCommandImpl::stopNode): Ditto.

12:49 PM Changeset in webkit [6791] by trey

• 5 edits in trunk/WebCore

Clipboard access during DHTML dragging is made secure.

Reviewed by John.

• kwq/KWQClipboard.h: (KWQClipboard::):
• kwq/KWQClipboard.mm: (KWQClipboard::KWQClipboard): Init new policy and changeCount members. (KWQClipboard::becomeNumb): Set policy to numb. (KWQClipboard::clearData): Check policy. (KWQClipboard::clearAllData): Check policy. (KWQClipboard::getData): Check policy and changeCount. (KWQClipboard::setData): Check policy. (KWQClipboard::types): Check policy and ChangeCount. (KWQClipboard::setDragLocation): Check policy. (KWQClipboard::setDragImage): Check policy. (KWQClipboard::setDropEffect): Check policy. (KWQClipboard::setEffectAllowed): Check policy.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::dispatchDragSrcEvent): Set policy when creating clipboard, and numb-ify it when we're done.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge dragOperationForDraggingInfo:]): Set policy when creating clipboard, and numb-ify it when we're done. (-[WebCoreBridge dragExitedWithDraggingInfo:]): Ditto (-[WebCoreBridge concludeDragForDraggingInfo:]): Ditto

8:01 AM Changeset in webkit [6790] by kocienda

• 2 edits in trunk/WebCore

Reviewed by me

• khtml/editing/jsediting.cpp: (DOM::EditorCommand::): Stray capital letter in "selectAll" command static initializer prevented the command from ever working since the command strings are lower-cased when trying to find a match, but not when they are inserted into the dictionary. This is a one character change to make the string "selectall" in the initializer.

12:11 AM Changeset in webkit [6789] by trey

• 18 edits in trunk/WebCore

WebCore will now generate a default drag image when an element serves as a drag
source. The basic idea is the image contains the element and all its children.

As for the implementation, instead of adding a new paintAction I added a new
field to the paintInfo struct, "paintingRoot". If this field is set, painting will
only paint that root's descendants.

Some code also moved from the bridge to the part, to be available within WebCore.

Reviewed by hyatt.

• khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject): Pass along paintingRoot to kids. (khtml::RenderBlock::paintFloats): Pass along paintingRoot to kids.
• khtml/rendering/render_box.cpp: (RenderBox::paintBoxDecorations): Test paintingRoot before painting.
• khtml/rendering/render_canvasimage.cpp: (RenderCanvasImage::paint): Test paintingRoot before painting.
• khtml/rendering/render_flow.cpp: (RenderFlow::paintLineBoxBackgroundBorder): Test paintingRoot before painting. (RenderFlow::paintLineBoxDecorations): Test paintingRoot before painting.
• khtml/rendering/render_image.cpp: (RenderImage::paint): Test paintingRoot before painting.
• khtml/rendering/render_inline.cpp: (RenderInline::paint): Pass along paintingRoot to kids.
• khtml/rendering/render_layer.cpp: (RenderLayer::paint): Pass along paintingRoot to kids.

(RenderLayer

paintLayer): Pass along paintingRoot to kids. Test if we are within the paintingRoot to decide whether to pass the root to our renderer.

• khtml/rendering/render_layer.h:
• khtml/rendering/render_object.cpp: (RenderObject::hasAncestor): New utility. (RenderObject::absoluteBoundingBoxRect): Helper for paintingRootRect (RenderObject::addAbsoluteRectForLayer): Helper for paintingRootRect (RenderObject::paintingRootRect): Return rect that will be painted if we are the painting root. (RenderObject::draggableNode): Add test to avoid rare NULL ptr crash.
• khtml/rendering/render_object.h: (khtml::RenderObject::PaintInfo::PaintInfo): Add paintingRoot field. (khtml::RenderObject::paintingRootForChildren): New utility. Return the current paintingRoot, or nil if we are the root (so kids draw normally). (khtml::RenderObject::shouldPaintWithinRoot): New utility. We can paint if we are the paintingRoot, or no root is set.
• khtml/rendering/render_replaced.cpp: (RenderReplaced::shouldPaint): Pass along paintingRoot to kids.
• khtml/rendering/render_table.cpp: (RenderTable::paint): Pass along paintingRoot to kids.
• khtml/rendering/render_text.cpp: (RenderText::paint): Test paintingRoot before painting.
• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): Init new _elementToDraw member. (KWQKHTMLPart::paint): Generalized to handle cases of painting selection or a given element. (KWQKHTMLPart::khtmlMouseMoveEvent): Make a default image if dragSrc didn't provide one. (KWQKHTMLPart::selectionRect): Moved from bridge. (KWQKHTMLPart::visibleSelectionRect): Ditto. (KWQKHTMLPart::imageFromRect): Newly factored code, from bridge. (KWQKHTMLPart::selectionImage): Moved from bridge, wrapper around imageFromRect. (KWQKHTMLPart::elementImage): New method, wrapper around imageFromRect.
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]): Just call part to draw. (-[WebCoreBridge visibleSelectionRect]): Guts moved to part. (-[WebCoreBridge selectionImage]): Ditto.

Jun 7, 2004:

5:22 PM Changeset in webkit [6788] by darin

• 6 edits in trunk/WebCore

Reviewed by Chris.

• fixed <rdar://problem/3682821>: (setTimeout fails when additional parameters are used and timeout function is a string)

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Ignore excess arguments instead of rejecting the argument list for window.scrollBy, scroll, scrollTo, moveBy, moveTo, resizeBy, resizeTo, and setTimeout (when the timeout is a string rather than an object).

• did a refinement of JSEditor to be slightly more efficient, and not have to edit both the .cpp file and the .h when adding more implementation

• khtml/khtml_part.h: Hack so we can get to the docImpl and xmlDocImpl without being a friend.
• khtml/editing/jsediting.h: Simplified a bit.
• khtml/editing/jsediting.cpp: Redid to use a table, and simplified a bit.

5:14 PM Changeset in webkit [6787]

• 2 copies
  3 deletes in tags/JavaScriptCore-143~2

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-143~2'.

5:14 PM Changeset in webkit [6786] by vicki

• 1 edit in trunk/JavaScriptCore/ChangeLog

add a release marker for JavaScriptCore-143.2

5:10 PM Changeset in webkit [6785] by darin

• 2 edits in trunk/WebKit

Reviewed by Chris.

• fixed <rdar://problem/3676761>: (REGRESSION: Text Bigger/Smaller commands are always disabled in TOT)

• WebView.subproj/WebHTMLView.m: Add @interface declaration for WebTextSizing category on WebHTMLView. This must have gotten lost somewhere along the way.

3:09 PM Changeset in webkit [6784] by kocienda

• 4 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3682354>: "Typing style does not work yet"

Did the final hook-up of support that has landed in the tree in the
recent past as part of ongoing style-application work.

For the most part, this patch modifies the InputNewlineCommandImpl and
InputTextCommandImpl commands to insert a styling span when there is
a typing style active.

• khtml/editing/htmlediting_impl.cpp: (khtml::CompositeEditCommandImpl::createTypingStyleElement): Helper shared by the two commands modified. (khtml::InputNewlineCommandImpl::doApply): Create a styling span if the part has a typing style. Maintain a nodeToInsert local variable, which is either the break to insert or a styling span containing the break. Also, remove some utterly bogus derefs. They are just plain wrong. (khtml::InputTextCommandImpl::InputTextCommandImpl): Don't need to keep m_insertedTextNode. The composite commands this command uses will keep track of that object's lifetime. We do not need to do that here. (khtml::InputTextCommandImpl::~InputTextCommandImpl): No longer need to deref obsolete m_insertedTextNode. (khtml::InputTextCommandImpl::prepareForTextInsertion): Handle the case where a styling span needs to be added. (khtml::TypingCommandImpl::insertText): Create a new InputTextCommand when there is an active typping style.
• khtml/editing/htmlediting_impl.h: Declare createTypingStyleElement helper. Remove m_insertedTextNode from InputTextCommandImpl.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge applyStyle:]): Swicth on the state of the selection, calling setTypingStyle when a caret and ApplyStyleCommand when a range.

2:53 PM Changeset in webkit [6783] by darin

• 3 edits in trunk/JavaScriptCore

• fixed <rdar://problem/3682489>: (JavaScriptGlue no longer compiles because Interpreter::evaluate parameters changed)

• kjs/interpreter.h: Added an overload to make JavaScriptGlue compile.
• kjs/interpreter.cpp: (KJS::Interpreter::evaluate): Implemented the overload.

10:56 AM Changeset in webkit [6782] by darin

• 3 edits in trunk/WebCore

Reviewed by Ken.

• khtml/editing/jsediting.h: Elide some unnecessary namespace prefixes.
• khtml/editing/jsediting.cpp: Make typed constants instead of macros. (DOM::JSEditor::commandDict): Elide unnecessary namespace prefix. (DOM::JSEditor::execCommand): Remove xxxNotImplemented functions; just return false instead. (DOM::JSEditor::queryCommandEnabled): Ditto. (DOM::JSEditor::queryCommandIndeterm): Ditto. (DOM::JSEditor::queryCommandState): Ditto. (DOM::JSEditor::queryCommandSupported): Ditto. (DOM::JSEditor::queryCommandValue): Ditto.

10:56 AM Changeset in webkit [6781] by trey

• 2 edits in trunk/WebKit

WebKit no longer causes an endless stream of dragexit events to
occur at the DHTML level when hovering over an element that is
not accepting the drag.

Reviewed by Chris

• WebView.subproj/WebView.m: (-[WebView _dragOperationForDraggingInfo:]): If the potential target refuses the item, don't turn around and immediately tell it to cancel the drag, which is what leads to the exit event happening at the DOM level. If the target just refused the drag, it should not have anything it needs to cancel.