Context Navigation

Changed private headers to be pubic for npapi.h and npfunctions.h. That
API was approved but never marked as public in the project file. This change does
not make npruntime.h public, which contains the not yet approved changes
for script-ability of netscape plugins. Unfortunately, that API will not
be public for WWDC.

Reviewed by Chris.

WebKit.pbproj/project.pbxproj:

11:24 AM Changeset in webkit [6878] by rjw

2 edits in trunk/WebCore

Fixed <rdar://problem/3698867> setting the canvas or parent to display:none and updating the causes a nil-deref

Ensured that we have a renderer before rendering.

Reviewed by John.

khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):

11:09 AM Changeset in webkit [6877] by hyatt

9 edits in trunk/WebCore

Fix for 3674601, "Read More..." links should trail articles in Emerson.

Reviewed by darin

khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren): (khtml::RenderBlock::deleteEllipsisLineBoxes): (khtml::RenderBlock::checkLinesForTextOverflow):
khtml/rendering/render_block.cpp: (khtml:::RenderFlow): (khtml::RenderBlock::paintEllipsisBoxes): (khtml::RenderBlock::nodeAtPoint): (khtml::shouldCheckLines): (khtml::getLineAtIndex): (khtml::getHeightForLineCount): (khtml::RenderBlock::lineAtIndex): (khtml::RenderBlock::lineCount): (khtml::RenderBlock::heightForLineCount): (khtml::RenderBlock::clearTruncation):
khtml/rendering/render_block.h: (khtml::RenderBlock::setHasMarkupTruncation): (khtml::RenderBlock::hasMarkupTruncation):
khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutVerticalBox):
khtml/rendering/render_line.cpp: (khtml::EllipsisBox::m_str): (khtml::InlineBox::adjustPosition): (khtml::InlineFlowBox::adjustPosition): (khtml::InlineFlowBox::clearTruncation): (khtml::EllipsisBox::paint): (khtml::EllipsisBox::nodeAtPoint): (khtml::RootInlineBox::clearTruncation): (khtml::RootInlineBox::placeEllipsis): (khtml::RootInlineBox::paintEllipsisBox): (khtml::RootInlineBox::hitTestEllipsisBox): (khtml::RootInlineBox::adjustPosition): (khtml::RootInlineBox::childRemoved):
khtml/rendering/render_line.h: (khtml::InlineBox::clearTruncation):
khtml/rendering/render_text.cpp:
khtml/rendering/render_text.h: (khtml::InlineTextBox::clearTruncation):

1:30 AM Changeset in webkit [6876] by trey

9 edits in trunk

WebCore:

3698514 - coordinates in ondragstart and ondrag events are wrong

This part fixes the ondragstart coords. We salt away the window-based mouseDown
location, since we need that when we dispatch the ondragstart event. Previously
we were errantly using a mouseDown point that had already been converted to view
coords, and then the dispatch converted it again.

Reviewed by Maciej.

kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent): Use window based mouse event coords to dispatch event. (KWQKHTMLPart::mouseDown): Save window based mouse event coords .

WebKit:

3698514 - coordinates in ondragstart and ondrag events are wrong

This part fixes the ondrag coords. I thought Cocoa passed us the mouse location
in draggedImage:movedTo:, but no, it's the position of the dragged image.
WebCore needs the mouse location, so to calc that we must save away the
offset of the mouse relative to the image when we kick off the drag.

Reviewed by Maciej.

Misc.subproj/WebNSViewExtras.h:
Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:rect:event:pasteboard:source:offset:]): Add the ability to return the offset of the cursor wrt to the drag image, since this routine generates its own drag image and positions it.
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Calc the offset of the cursor wrt to the drag image in the myriad of ways that we kick off the drag. (-[WebHTMLView draggedImage:movedTo:]): Adjust the location by the offset we save when we kicked off the drag. (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
WebView.subproj/WebHTMLViewInternal.h:
WebView.subproj/WebImageView.m: (-[WebImageView mouseDragged:]): Pass nil for new arg, we don't care.

Jun 16, 2004:

9:52 PM Changeset in webkit [6875]

5 copies
2 deletes in tags/WebCore-145~1

This commit was manufactured by cvs2svn to create tag
'WebCore-145~1'.

9:52 PM Changeset in webkit [6874] by vicki

2 edits in trunk/WebCore

versioning and ChangeLog marker for WebCore-145.1 (WebCore-145 plus the selection fix)

6:38 PM Changeset in webkit [6873] by hyatt

15 edits in trunk

WebCore:

Fix for 3596620, implement a subset of CSS3 text truncation for Emerson.

Reviewed by mjs

khtml/rendering/bidi.cpp: (khtml::RenderBlock::checkLinesForTextOverflow):
khtml/rendering/font.cpp: (Font::checkSelectionPoint):
khtml/rendering/font.h:
khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject): (khtml::RenderBlock::paintFloats): (khtml::RenderBlock::paintEllipsisBoxes):
khtml/rendering/render_block.h:
khtml/rendering/render_line.cpp: (InlineBox::canAccommodateEllipsis): (InlineBox::placeEllipsisBox): (InlineFlowBox::paintDecorations): (InlineFlowBox::placeEllipsisBox): (EllipsisBox::paint): (RootInlineBox::placeEllipsis): (RootInlineBox::placeEllipsisBox):
khtml/rendering/render_line.h: (khtml::EllipsisBox::m_str): (khtml::RootInlineBox::ellipsisBox):
khtml/rendering/render_text.cpp: (InlineTextBox::placeEllipsisBox): (InlineTextBox::paintDecoration): (InlineTextBox::offsetForPosition): (RenderText::positionForCoordinates): (RenderText::paint):
khtml/rendering/render_text.h:
kwq/KWQFontMetrics.h:
kwq/KWQFontMetrics.mm: (QFontMetrics::checkSelectionPoint):
kwq/WebCoreTextRenderer.h:

WebKit:

In order to support truncation in Emerson, enhance pointToOffset so that it needn't include partial
character glyphs (the left half of a glyph).

Reviewed by mjs

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer pointToOffset:style:position:reversed:includePartialGlyphs:]): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]): (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:includePartialGlyphs:]):

6:19 PM Changeset in webkit [6872] by mjs

2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3697602> REGRESSION (144.2-TOT) Selection highlight does not draw

khtml/rendering/render_canvas.cpp: (RenderCanvas::setSelection):

5:54 PM Changeset in webkit [6871] by rjw

2 edits in trunk/JavaScriptCore

Fixed <rdar://problem/3696112>: nil from an Objective-C class seems to get wrapped as a JavaScript proxy that will not print.

This turned out to be a show stopper for Dashboard. We now
return Undefined() when nil is returned from a ObjC method
that returns an object type.

Reviewed by Maciej.

bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue):

4:46 PM Changeset in webkit [6870] by vicki

3 edits in trunk

change version number to 146u -- the tree is open

4:32 PM Changeset in webkit [6869]

3 copies in tags/Safari-145

This commit was manufactured by cvs2svn to create tag 'Safari-145'.

4:32 PM Changeset in webkit [6868] by vicki

6 edits in trunk

Safari-145 stamp

11:37 AM Changeset in webkit [6867] by sullivan

1 edit in trunk/WebKit/WebKit.pbproj/project.pbxproj

Reviewed by Darin.

fixed <rdar://problem/3685827> Add standard news feeds from marketing.

BookmarksController.m: (-[BookmarksController mergeBuiltInBookmarksIfNecessary]): Use a different file for Tiger than for Panther; only the Tiger one has the news feeds in it.

English.lproj/BuiltInBookmarks.plist: new file that contains news feeds from marketing

English.lproj/OldBuiltInBookmarks.plist: Added. New name for old file.

WebBookmark.m: (-[WebBookmark dictionaryRepresentation]): #ifdeffed hack to avoid writing out UUIDs; used for creating built-in bookmarks file

WebBookmarkLeaf.m: (-[WebBookmarkLeaf dictionaryRepresentation]): #ifdeffed hack to avoid writing out last visited time; used for creating built-in bookmarks file

WebBookmarkList.m: (-[WebBookmarkList dictionaryRepresentation]): #ifdeffed hack to avoid writing out proxy bookmarks; used for creating built-in bookmarks file

WebBrowser.pbproj/project.pbxproj: updated for new file

11:18 AM Changeset in webkit [6866] by darin

2 edits in trunk/WebKit

fixed <rdar://problem/3696081> REGRESSION: <WebKit/CarbonUtils.h> doesn't build any more

Reviewed by Trey.

Carbon.subproj/CarbonUtils.h: Fixed include. Need to include <ApplicationServices/ApplicationServices.h> to get CGImageRef; can't include an individual header.

11:09 AM Changeset in webkit [6865]

1 copy
39 deletes in branches/unlabeled-1.48.4/WebCore/khtml/html

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.48.4'.

11:09 AM Changeset in webkit [6864] by rjw

13 edits in trunk/WebCore

Fixed 3695730: Added support for document.embeds[], much like
document.applets[], to allow access to a plugin's exported interface.

Reviewed by Chris.

khtml/dom/html_document.cpp: (HTMLDocument::embeds):
khtml/dom/html_document.h:
khtml/ecma/kjs_dom.cpp: (KJS::getRuntimeObject):
khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): (KJS::HTMLElement::tryGet): (KJS::HTMLCollection::tryGet): (KJS::HTMLCollection::getNamedItems):
khtml/ecma/kjs_html.h: (KJS::HTMLDocument::):
khtml/ecma/kjs_html.lut.h: (KJS::):
khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::calcLength): (HTMLCollectionImpl::getItem): (HTMLCollectionImpl::getNamedItem):
khtml/html/html_miscimpl.h: (DOM::HTMLCollectionImpl::):
khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::getEmbedInstance):
khtml/html/html_objectimpl.h:
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::getEmbedInstanceForView):

Jun 15, 2004:

11:29 PM Changeset in webkit [6863] by mjs

5 edits in trunk/WebCore

Reviewed by Dave.

<rdar://problem/3695907>: (can't enable selection inside parent where it is disabled via CSS)

khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
khtml/rendering/render_object.cpp: (RenderObject::shouldSelect):
khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::userSelect): (khtml::RenderStyle::setUserSelect): (khtml::RenderStyle::initialUserSelect):

7:12 PM Changeset in webkit [6862] by rjw

4 edits in trunk

WebKit:

Fixed <rdar://problem/3695875>: Objective-C instances that are exported to JavaScript are too promiscuous

Flip the policy for exposing Objective-C methods and properties.

Reviewed by Trey.

Plugins.subproj/WebPluginPackage.m: (+[NSObject isSelectorExcludedFromWebScript:]): Just return YES. (+[NSObject isKeyExcludedFromWebScript:]): Just return YES.

JavaScriptCore:

Fixed <rdar://problem/3695875>: Objective-C instances that are exported to JavaScript are too promiscuous

No longer need to check respondsToSelector: for
isSelectorExcludedFromWebScript: and isKeyExcludedFromWebScript:
because these now have a default implementation on NSObject.

Reviewed by Trey.

bindings/objc/objc_class.mm: (ObjcClass::methodsNamed): (ObjcClass::fieldNamed):

6:59 PM Changeset in webkit [6861] by trey

4 edits in trunk/WebKit

3639321 - Harvard PIN authentication ends up sending PIN as clear text with POST action

When going back/forward to an item, if we went there originally via a POST,
we ask the user about rePOSTing, and if they say yes, we resend the POST.
This rePOST case is triggered by the form data that we saved on the b/f item.
In the case of this bug, the overall navigation was accomplished by a POST,
then a redirect, causing a GET. When a load of type redirect achieves the Committed
stage, we replace the current URL in the b/f item with the new URL (instead of
adding a new item to the b/f list).

The bug is that at the same time we should also update the form data in
the b/f item to match that of the new request. I think this will normally
mean nil'ing it out, unless there's some way for the result of the redirect
to be another POST.

The security leak occurred because we did not clear the form data on the item,
so when going back or forward to the page, we would go into the rePOSTing code,
even though we eventually reached that page via a GET (caused by the redirect).
So we would do a POST to the redirect URL containing the private data sent in
the original POST.

Reviewed by mjs and rjw.

History.subproj/WebHistoryItem.m: (-[WebHistoryItem _setFormInfoFromRequest:]): New method, just wraps 3 old set methods. (-[WebHistoryItem formData]): Diff being dumb, no change. (-[WebHistoryItem formContentType]): Ditto (-[WebHistoryItem formReferrer]): Ditto
History.subproj/WebHistoryItemPrivate.h:
WebView.subproj/WebFrame.m: (-[WebFrame _createItem:]): Call new WebHistoryItem method - no change in real behavior (-[WebFrame _transitionToCommitted:]): Clear out the form data at the key time, to fix the bug.

6:19 PM Changeset in webkit [6860] by hyatt

4 edits in trunk/WebCore

Initial impl of the EllipsisBox. This code just gets the box created and gets it placed vertically. The next
stage will be to position the box horizontally as well.

Reviewed by trey

khtml/rendering/bidi.cpp: (khtml::RenderBlock::checkLinesForTextOverflow):
khtml/rendering/render_line.cpp: (RootInlineBox::placeEllipsis):
khtml/rendering/render_line.h: (khtml::EllipsisBox::m_str):

5:41 PM Changeset in webkit [6859] by cblu

4 edits in trunk/WebKit

Fixed: <rdar://problem/3695724> WebKit plug-ins should only have to implement plugInViewWithArguments:

Reviewed by rjw.

ChangeLog:
Plugins.subproj/WebPluginViewFactory.h: mention that plugInViewWithArguments is required
WebView.subproj/WebFrame.m: (-[WebFrame _reloadForPluginChanges]): check for plugInViewWithArguments: not webPlugInInitialize
WebView.subproj/WebHTMLView.m: (-[WebHTMLView addSubview:]): ditto

5:00 PM Changeset in webkit [6858] by hyatt

4 edits in trunk/WebCore

Implement canAccommodateEllipsis. The basic idea is that everything on a line will allow an ellipsis to be
drawn on top of it unless it's a replaced element. Then, if the replaced element overlaps, the ellipsis won't
be allowed.

Reviewed by john

khtml/rendering/bidi.cpp: (khtml::RenderBlock::checkLinesForTextOverflow):
khtml/rendering/render_line.cpp: (InlineBox::closestLeafChildForXPos): (InlineBox::canAccommodateEllipsis): (InlineFlowBox::canAccommodateEllipsis): (RootInlineBox::canAccommodateEllipsis):
khtml/rendering/render_line.h:

3:48 PM Changeset in webkit [6857] by trey

2 edits in trunk/WebKit

3695240 - pasting plain text with newlines in it turns them into spaces

Easy fix, we just need to consume the incoming data as text instead of markup.

Reviewed by John and Darin.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]):

11:07 AM Changeset in webkit [6856] by vicki

1 edit
4 adds in trunk

added a few layout tests, rdar://3694510

layout-tests/editing/deleting/delete-image-004-expected.txt: Added.
layout-tests/editing/deleting/delete-image-004.html: Added.
layout-tests/editing/selection/extend-by-character-006-expected.txt: Added.
layout-tests/editing/selection/extend-by-character-006.html: Added.

9:15 AM Changeset in webkit [6855] by trey

2 edits in trunk/WebCore

Dragging tweak: We pass the mouse down coords instead of the
latest mouse drag coords to the ondragstart event. This makes it
easy for the client to figure the correct drag image offset,
whereas the mouse drag location is next to useless for that.

Reviewed by Louch

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent):

2:44 AM Changeset in webkit [6854] by mjs

11 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3685236>: (Safari does not support onselectstart event handler)

khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): (DOMNode::putValue):
khtml/ecma/kjs_dom.h: (KJS::DOMNode::):
khtml/ecma/kjs_dom.lut.h: (KJS::):
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseHTMLAttribute):
khtml/misc/htmlattrs.c: (hash_attr): (findAttr):
khtml/misc/htmlattrs.h:
khtml/misc/htmlattrs.in:
khtml/rendering/render_object.cpp: (RenderObject::shouldSelect):
khtml/xml/dom2_eventsimpl.cpp: (EventImpl::typeToId): (EventImpl::idToType):
khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::):

1:49 AM Changeset in webkit [6853] by mjs

2 edits in trunk/WebCore

Reviewed by Darin.

Fix crash with last checkin.

khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::domObjectsPerDocument): check the same property we want to initialize.

1:30 AM Changeset in webkit [6852] by darin

2 edits in trunk/WebKit

fixed crash introduced by my earlier change

WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageContext dealloc]): Set _cgsContext to 0 before calling super as before. (-[WebImageContext finalize]): Ditto.

1:12 AM Changeset in webkit [6851] by mjs

3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3685309>: (properties not shared for JS wrappers of same DOM object, accessed from different frames)

khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::domObjects): (ScriptInterpreter::domObjectsPerDocument): (ScriptInterpreter::ScriptInterpreter): (ScriptInterpreter::forgetDOMObject): (ScriptInterpreter::getDOMObjectForDocument): (ScriptInterpreter::putDOMObjectForDocument): (ScriptInterpreter::deleteDOMObjectsForDocument): (ScriptInterpreter::mark): (ScriptInterpreter::forgetDOMObjectsForDocument): (ScriptInterpreter::updateDOMObjectDocument):
khtml/ecma/kjs_binding.h: (KJS::ScriptInterpreter::getDOMObject): (KJS::ScriptInterpreter::putDOMObject): (KJS::ScriptInterpreter::deleteDOMObject):

1:07 AM Changeset in webkit [6850] by darin

2 edits in trunk/WebCore

rolled out Ken's fix for <rdar://problem/3672377> assertion failure in AppendNodeCommandImpl::doApply due to non-0 exception code trying to insert a DIV markup string (it was making most layout tests fail)

khtml/xml/dom_nodeimpl.cpp: (NodeImpl::checkAddChild): Rolled check back in.

1:01 AM Changeset in webkit [6849] by hyatt

3 edits in trunk/WebCore

Add a truncation variable to text run boxes that will eventually be used to know how to cut out some of the glyphs when
rendering.

Reviewed by darin

khtml/rendering/render_text.cpp: (RenderText::clearTextOverflowTruncation):
khtml/rendering/render_text.h: (khtml::InlineTextBox:::InlineRunBox): (khtml::InlineTextBox::clearTruncation):

12:53 AM Changeset in webkit [6848] by darin

7 edits in trunk/WebKit

Reviewed by Maciej.

fixed some things for GC that Patrick missed, or that happened after the branch

Carbon.subproj/HIWebView.m: (HIWebViewConstructor): Use CFRetain instead of retain. (HIWebViewDestructor): Use CFRelease instead of release.
Misc.subproj/WebFileDatabase.m: (-[WebFileDatabase initWithPath:]): Use release instead of dealloc.
WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageContext finalize]): Had [super dealloc] here by mistake; change to [super finalize].
WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer finalize]): Added.
WebView.subproj/WebDebugDOMNode.m: (-[WebDebugDOMNode initWithWebFrameView:]): Use release instead of dealloc.
WebView.subproj/WebRenderNode.m: (-[WebRenderNode initWithWebFrameView:]): Use release instead of dealloc.

12:46 AM Changeset in webkit [6847] by darin

11 edits in trunk/WebCore

Reviewed by Maciej.

fixed some things for GC that Patrick missed, or that happened after the branch

kwq/DOM-CSS.mm: (-[DOMStyleSheet finalize]): Added. (-[DOMStyleSheetList finalize]): Added. (-[DOMCSSStyleSheet finalize]): Added. (-[DOMMediaList finalize]): Added. (-[DOMCSSRuleList finalize]): Added. (-[DOMCSSRule finalize]): Added. (-[DOMCSSStyleDeclaration finalize]): Added. (-[DOMCSSValue finalize]): Added. (-[DOMRGBColor finalize]): Added. (-[DOMRect finalize]): Added. (-[DOMCounter finalize]): Added.
kwq/DOM.mm: (-[DOMObject finalize]): Added. (-[DOMNode finalize]): Added. (-[DOMNamedNodeMap finalize]): Added. (-[DOMNodeList finalize]): Added. (-[DOMImplementation finalize]): Added. (-[DOMRange finalize]): Added. (-[DOMNodeFilter finalize]): Added. (-[DOMNodeIterator finalize]): Added. (-[DOMTreeWalker dealloc]): Removed unneeded nil check. (-[DOMTreeWalker finalize]): Added.
kwq/DOMHTML.mm: (-[DOMHTMLCollection finalize]): Added. (-[DOMHTMLOptionsCollection finalize]): Added.
kwq/KWQClipboard.mm: (KWQClipboard::KWQClipboard): Use KWQRetain instead of retain. (KWQClipboard::~KWQClipboard): Use KWQRelease instead of release.
kwq/KWQEditCommand.mm: (-[KWQEditCommand finalize]): Added.
kwq/KWQFont.mm: (QFont::~QFont): Use KWQRelease instead of release.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent): Use KWQRetain instead of retain, and KWQRelease instead of release. (KWQKHTMLPart::mouseDown): Use KWQRetain instead of retain, and KWQRelease instead of release. (KWQKHTMLPart::mouseDragged): Use KWQRetain instead of retain, and KWQRelease instead of release. (KWQKHTMLPart::mouseUp): Use KWQRetain instead of retain, and KWQRelease instead of release. (KWQKHTMLPart::mouseMoved): Use KWQRetain instead of retain, and KWQRelease instead of release. (KWQKHTMLPart::sendContextMenuEvent): Use KWQRetain instead of retain, and KWQRelease instead of release.
kwq/KWQPageState.mm: (-[KWQPageState finalize]): Added. Filed <rdar://problem/3694163> about the fact that this is not right.
kwq/KWQTimer.mm: (-[KWQSingleShotTimerTarget finalize]): Added.
kwq/WebCoreBridge.mm: (-[WebCoreBridge finalize]): Added. Filed <rdar://problem/3694165> about the fact that this is not right.

12:38 AM Changeset in webkit [6846] by darin

3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fixed some things for GC that Patrick missed, or that happened after the branch

bindings/objc/WebScriptObject.mm: (-[WebScriptObject dealloc]): Moved removeNativeReference call here from private object. (-[WebScriptObject finalize]): Added.

added some missing nil checks

bindings/objc/objc_instance.mm: (ObjcInstance::ObjcInstance): Check for nil. (ObjcInstance::~ObjcInstance): Check for nil. (ObjcInstance::operator=): Check for nil.

12:24 AM Changeset in webkit [6845] by hyatt

1 edit in trunk/WebCore/khtml/rendering/bidi.cpp

Typo in src comment.

12:23 AM Changeset in webkit [6844] by trey

2 edits in trunk/WebKit

Fix ASSERT/crash we get sometimes when dragging link images. Turns
out there was an uninitialized variable for the image size,
so at random we would try to create huge images that could not
be focused.

Reviewed by Maciej and Darin.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _dragImageForLinkElement:]): Trivial fix to not use += with uninited variable.

12:21 AM Changeset in webkit [6843] by hyatt

7 edits in trunk/WebCore

Initial work on text truncation. Working top-down, I think I've made all the changes I will need to bidi.cpp
and to the block code itself. The rest of the code can be concentrated in the render_line and render_text files.

Reviewed by darin

khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren): (khtml::RenderBlock::findNextLineBreak): (khtml::RenderBlock::deleteEllipsisLineBoxes): (khtml::RenderBlock::checkLinesForTextOverflow):
khtml/rendering/render_block.h:
khtml/rendering/render_line.cpp: (RootInlineBox::detach): (RootInlineBox::detachEllipsisBox): (RootInlineBox::canAccommodateEllipsis): (RootInlineBox::placeEllipsis):
khtml/rendering/render_line.h: (khtml::RootInlineBox::RootInlineBox):
khtml/rendering/render_text.cpp: (RenderText::clearTextOverflowTruncation):
khtml/rendering/render_text.h:

12:01 AM Changeset in webkit [6842] by trey

2 edits in trunk/WebCore

3692690 - REGRESSION: canceling drag from WebView cause link to load
Just need to take extra care to cancel any click handling in
all cases once we're committed to doing the drag.

Reviewed by Darin.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent): Call invalidateClick once we're past the hysteresis point, and definitely going to try to start a drag and drop.

Jun 14, 2004:

11:48 PM Changeset in webkit [6841] by darin

2 edits in trunk/WebCore

fixed crash on boot

kwq/KWQFoundationExtras.h: (KWQRetainNSRelease): Fixed return value of this method; was uninitialized.

11:22 PM Changeset in webkit [6840] by trey

4 edits in trunk/WebCore

Dashboard wants access to pastboard data during the drag gesture.

We address this need be allowing docs that are local files to access the
pasteboard data during a drag, while other pages can only get at the types
list until the drop happens. This is deemed safe because local files already
have such broad super powers.

Reviewed by Maciej.

kwq/KWQKURL.h:
kwq/KWQKURL.mm: (KURL::isLocalFile): Implement this QT method to look for the file scheme.
kwq/WebCoreBridge.mm: (-[WebCoreBridge dragOperationForDraggingInfo:]): Use more relaxed clipboard security for local file pages. (-[WebCoreBridge dragExitedWithDraggingInfo:]): Ditto.

10:55 PM Changeset in webkit [6839] by darin

26 edits
1 add in trunk/WebKit

Reviewed by me, code changes by Patrick Beard.

fixed <rdar://problem/3671507>: (WebKit should adopt GC changes and compile with GC enabled)

WebKit.pbproj/project.pbxproj: Added WebNSObjectExtras.h.
Misc.subproj/WebNSObjectExtras.h: Added. Includes WebMakeCollectable, a cover for CFMakeCollectable that returns type id, for less casting, and works on Panther as well as Tiger. Also declares finalize in NSObject so we can call super without warnings on Panther.

Carbon.subproj/CarbonWindowAdapter.m: Fixed header and includes a bit. (-[CarbonWindowAdapter finalize]): Added.
History.subproj/WebBackForwardList.m: (-[WebBackForwardList dealloc]): Got count outside loop. (-[WebBackForwardList finalize]): Added.
History.subproj/WebHistoryItem.m: (-[WebHistoryItem finalize]): Added.
Misc.subproj/WebFileDatabase.m: (-[WebFileDatabase _createLRUList:]): Use release on Panther, drain on Tiger. (+[WebFileDatabase _syncLoop:]): Ditto. (-[WebFileDatabase dealloc]): Removed, since we never deallocate objects of this class, and the method was untested.
Misc.subproj/WebKitErrors.m: (registerErrors): Use release on Panther, drain on Tiger.
Misc.subproj/WebKitNSStringExtras.m: (+[NSString _web_encodingForResource:]): Use WebMakeCollectable. Also fixed indenting.
Misc.subproj/WebNSURLExtras.m: (+[NSURL _web_URLWithData:relativeToURL:]): Use WebMakeCollectable. (-[NSURL _web_URLWithLowercasedScheme]): Use WebMakeCollectable. (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Change code to use CFRelease to balance CFURLCreateStringByReplacingPercentEscapes CFString creation, not release.
Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream finalize]): Added.
Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView freeAttributeKeysAndValues]): Added. Shared code for dealloc and finalize. (-[WebBaseNetscapePluginView dealloc]): Call freeAttributeKeysAndValues. (-[WebBaseNetscapePluginView finalize]): Added. (-[WebBaseNetscapePluginView requestWithURLCString:]): Changed so that CFString objects are released with CFRelease, not release. (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): Fixed storage leak in error case. Made sure CFString object is released with CFRelease, not release. (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]): Another CFString that needed to a CFRelease, not a release. (-[WebBaseNetscapePluginView status:]): Ditto.
Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage pathByResolvingSymlinksAndAliasesInPath:]): Changed code to CFRelease a CFURLRef, instead of release. (-[WebBasePluginPackage finalize]): Added.
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge fini]): Added. Shared code for dealloc and finalize. (-[WebBridge dealloc]): Call fini. (-[WebBridge finalize]): Added.
WebCoreSupport.subproj/WebGlyphBuffer.m: (-[WebGlyphBuffer finalize]): Added.
WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageContext initWithBounds:context:]): Use CGContextRetain to avoid cast. (-[WebImageContext dealloc]): Tweaked. (-[WebImageContext finalize]): Added. (-[WebImageRenderer finalize]): Added. (-[WebPDFDocument finalize]): Added.
WebView.subproj/WebDataProtocol.m: (+[NSURL _web_uniqueWebDataURL]): Changed so that CFString object is released with CFRelease, not release.
WebView.subproj/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): Took non-release work out of here. (-[WebDataSource dealloc]): Moved it here. (-[WebDataSource finalize]): Added. (-[WebDataSource isLoading]): Use release on Panther, drain on Tiger.
WebView.subproj/WebFrame.m: (-[WebFramePrivate dealloc]): Took non-release work out of here. (-[WebFrame dealloc]): Moved it here. (-[WebFrame finalize]): Added.
WebView.subproj/WebFrameView.m: (-[WebFrameView finalize]): Added.
WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation finalize]): Added.
WebView.subproj/WebHTMLView.m: (-[WebHTMLViewPrivate dealloc]): Moved non-release work out of here. (-[WebHTMLView dealloc]): Moved it here. (-[WebHTMLView finalize]): Added.
WebView.subproj/WebImageView.m: (-[WebImageView finalize]): Added.
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient finalize]): Added.
WebView.subproj/WebTextView.m: (-[WebTextView finalize]): Added.
WebView.subproj/WebView.m: (-[WebView finalize]): Added.

10:33 PM Changeset in webkit [6838] by darin

17 edits
1 add in trunk/WebCore

Reviewed by me, code changes by Patrick Beard.

fixed <rdar://problem/3671507>: (WebKit should adopt GC changes and compile with GC enabled)

WebCore.pbproj/project.pbxproj: Added KWQFoundationExtras.h.
kwq/KWQFoundationExtras.h: Added. (KWQRetain): Cover for CFRetain that is tolerant of nil. (KWQRelease): Cover for CFRelease that is tolerant of nil. (KWQRetainNSRelease): Combination of a CFRetain and an -[NSObject release] that is tolerant of nil. Also includes a declaration of finalize so we can call [super finalize] without warnings on Panther.

kwq/DOM.mm: (ObjCNodeFilterCondition::ObjCNodeFilterCondition): Use CFRetain instead of retain. (ObjCNodeFilterCondition::~ObjCNodeFilterCondition): Use CFRelease instead of release.
kwq/KWQComboBox.mm: (QComboBox::~QComboBox): Use KWQRelease instead of release. (QComboBox::setFont): Use KWQRelease instead of release. (QComboBox::labelFont): Use KWQRetain instead of retain.
kwq/KWQCursor.mm: (QCursor::QCursor): Use KWQRetain instead of retain. (QCursor::~QCursor): Use KWQRelease instead of release. (QCursor::operator=): More of the same.
kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): Use KWQRetainNSRelease to retain a newly-allocated object. (KWQFileButton::~KWQFileButton): Use CFRelease instead of release.
kwq/KWQFont.mm: (QFont::QFont): Use KWQRetain instead of retain. (QFont::operator=): More of the same. (QFont::setFamily): Use KWQRelease instead of release. (QFont::setFirstFamily): Use KWQRelease instead of release. (QFont::setPixelSize): Use KWQRelease instead of release. (QFont::setWeight): Use KWQRelease instead of release. (QFont::setItalic): Use KWQRelease instead of release. (QFont::getNSFont): Use KWQRetain instead of retain.
kwq/KWQFontMetrics.mm: (QFontMetricsPrivate::~QFontMetricsPrivate): Use KWQRelease instead of release. (QFontMetricsPrivate::getRenderer): Use KWQRetain instead of retain. (QFontMetricsPrivate::setFont): Use KWQRelease instead of release.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::~KWQKHTMLPart): Use KWQRelease instead of release. (KWQKHTMLPart::clearRecordedFormValues): Use KWQRelease instead of release. (KWQKHTMLPart::recordFormValue): Use KWQRetainNSRelease and use KWQRetain instead of retain. (KWQKHTMLPart::windowScriptObject): Use KWQRetainNSRelease.
kwq/KWQKJobClasses.mm: (KIO::TransferJobPrivate::TransferJobPrivate): Use KWQRetainNSRelease. (KIO::TransferJobPrivate::~TransferJobPrivate): Use KWQRelease instead of release. (KIO::TransferJob::setLoader): More of the same.
kwq/KWQLoader.mm: (KWQRetainResponse): Use KWQRetain instead of retain. (KWQReleaseResponse): Use KWQRelease instead of release.
kwq/KWQPainter.mm: (QPainterPrivate::~QPainterPrivate): Use KWQRelease instead of release. (QPainter::_updateRenderer): More of the same. (QPainter::initFocusRing): Use KWQRetainNSRelease. (QPainter::clearFocusRing): Use KWQRelease instead of release.
kwq/KWQPixmap.mm: (QPixmap::QPixmap): Use KWQRetain instead of retain. (QPixmap::~QPixmap): Use KWQRelease instead of release. (QPixmap::receivedData): Use KWQRetain instead of retain. (QPixmap::resize): Use KWQRetainNSRelease and use KWQRelease instead of release. (QPixmap::operator=): More of the same.
kwq/KWQRegion.mm: (QRegion::QRegion): Use KWQRetain instead of retain. (QRegion::~QRegion): Use KWQRelease instead of release. (QRegion::operator=): More of the same.
kwq/KWQTimer.mm: (QTimer::start): Use KWQRetain instead of retain. (QTimer::stop): Use KWQRelease instead of release. (QTimer::fire): Use KWQRelease instead of release.
kwq/KWQWidget.mm: (QWidget::QWidget): Use KWQRetain instead of retain. (QWidget::~QWidget): Use KWQRelease instead of release. (QWidget::setView): More of the same.
kwq/WebCoreSettings.mm: (-[WebCoreSettings finalize]): Delete the storage here, as well as in dealloc.

10:17 PM Changeset in webkit [6837] by darin

4 edits in trunk/JavaScriptCore

Reviewed by me, code changes by Patrick Beard.

fixed <rdar://problem/3671507>: (WebKit should adopt GC changes and compile with GC enabled)

bindings/objc/objc_instance.mm: (ObjcInstance::ObjcInstance): Use CFRetain instead of retain. (ObjcInstance::~ObjcInstance): Use CFRelease instead of release. (ObjcInstance::operator=): More of the same. (ObjcInstance::end): Use [pool drain] if compiling on Tiger.

bindings/objc/objc_runtime.mm: (ObjcArray::ObjcArray): Use CFRetain instead of retain. (ObjcArray::~ObjcArray): Use CFRelease instead of release. (ObjcArray::operator=): More of the same.

bindings/testbindings.mm: Fixed incorrect license. (main): Use [pool drain] if compiling on Tiger.

6:21 PM Changeset in webkit [6836] by mjs

2 edits in trunk/WebCore

Reviewed by Trey.

<rdar://problem/3693818>: (Safari should use CG calls for circle drawing for better performance)

kwq/KWQPainter.mm: (QPainter::drawEllipse): Use CG calls instead of NS calls for faster circle drawing. (QPainter::drawArc): Ditto.

6:09 PM Changeset in webkit [6835] by trey

1 edit in trunk/WebKit/ChangeLog

Fix reviewer field of previous checkin

6:07 PM Changeset in webkit [6834] by trey

1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fill in reviewer field from previous checkin.

3:43 PM Changeset in webkit [6833] by kocienda

2 edits in trunk/WebCore

Reviewed by Vicki

Fix for this bug:

<rdar://problem/3690115> Crash deleting text out of iChat's profile (an editable Webview)

khtml/html/html_elementimpl.cpp: (HTMLElementImpl::isFocusable): Added null-check of parent node before deref'ing it.

2:43 PM Changeset in webkit [6832] by trey

3 edits in trunk/WebCore

Two tweaks to recently added "drag" pseudo-class, as suggested by
Dave. The class is renamed to "-khtml-drag", and we update layout
when using it, instead of only updating styles.

Reviewed by hyatt.

khtml/css/css_base.cpp: (CSSSelector::extractPseudoType):
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::snapshotDragImage):

2:33 PM Changeset in webkit [6831] by kocienda

2 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/3693202> WebView.h header unnecessarily lists NSResponder methods it overrides

WebView.subproj/WebView.h: NSResponder overrides now gathered in a comment section.

1:58 PM Changeset in webkit [6830] by trey

21 edits in trunk

WebCore:

Support for DHTML cut/copy/paste. We now support oncut, oncopy, onpaste. The events
are sent to the first node in the selection, or else the body. Current holes are
that we do not send events for operations in text fields or text areas (because it
is hard to get the right hooks into the AppKit).

We also send onbeforecut, onbeforecopy, onbeforepaste before the other events, which
isn't really WinIE compatible, but is close. WinIE uses these to enable cut/paste
menu items in its UI. DB doesn't need this for now.

Reviewed by NOBODY (OOPS!).

khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): Boilerplate for new events (DOMNode::putValue): Boilerplate for new events
khtml/ecma/kjs_dom.h: (KJS::DOMNode::): Boilerplate for new events
khtml/ecma/kjs_dom.lut.h:
khtml/ecma/kjs_events.cpp: (DOMEvent::DOMEvent): "dataTransfer" and "clipboardData" properties are conditionally defined on DOMEvent, depending on if the event is a dragging or clipboard event. (DOMMouseEvent::mark): Pass mark along to any clipboard object we have. (DOMEvent::getValueProperty): Return "dataTransfer" or "clipboardData". (DOMMouseEvent::getValueProperty): Returning "dataTransfer" now handled by the superclass.
khtml/ecma/kjs_events.h: (KJS::DOMEvent::): (KJS::DOMMouseEvent::DOMMouseEvent): (KJS::DOMMouseEvent::): (KJS::DOMMouseEvent::toMouseEvent):
khtml/ecma/kjs_events.lut.h:
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseHTMLAttribute): Boilerplate for new events
khtml/misc/htmlattrs.c:
khtml/misc/htmlattrs.h:
khtml/misc/htmlattrs.in: Boilerplate for new events
khtml/xml/dom2_eventsimpl.cpp: (EventImpl::typeToId): Boilerplate for new events (EventImpl::idToType): Boilerplate for new events (EventImpl::isDragEvent): New utility (EventImpl::isClipboardEvent): New utility (MouseEventImpl::isDragEvent): New utility (ClipboardEventImpl::ClipboardEventImpl): ref optional clipboard (ClipboardEventImpl::~ClipboardEventImpl): deref optional clipboard (ClipboardEventImpl::isClipboardEvent): New utility
khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::): Boilerplate for new events (DOM::ClipboardEventImpl::clipboard):
kwq/KWQClipboard.h: Monkey business so this file is includable in C++.
kwq/KWQClipboard.mm:
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::dispatchCPPEvent): Send one of the new events. (KWQKHTMLPart::tryCut): Declare pasteboard types, send cut events. (KWQKHTMLPart::tryCopy): Declare pasteboard types, send copy events. (KWQKHTMLPart::tryPaste): Send paste events.
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge tryDHTMLCut]): Pass through to part (-[WebCoreBridge tryDHTMLCopy]): Ditto (-[WebCoreBridge tryDHTMLPaste]): Ditto

WebKit:

Support for DHTML cut/copy/paste.

Reviewed by NOBODY (OOPS!).

WebView.subproj/WebHTMLView.m: (-[WebHTMLView copy:]): Give DHTML first crack at executing the command. (-[WebHTMLView cut:]): Ditto (-[WebHTMLView paste:]): Ditto

11:50 AM Changeset in webkit [6829] by cblu

8 edits in trunk/WebKit

Fixed: <rdar://problem/3674456> make new drag & drop API compatible with DHTML dragging

Reviewed by trey.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): tweak
WebView.subproj/WebUIDelegate.h: removed old, added new methods
WebView.subproj/WebUIDelegatePrivate.h: moved new methods to public header
WebView.subproj/WebView.h: removed old, added new methods
WebView.subproj/WebView.m: moved methods around (-[WebView moveDragCaretToPoint:]): moved (-[WebView removeDragCaret]): moved (-[WebView _bridgeAtPoint:]): moved (-[WebView editableDOMRangeForPoint:]): moved
WebView.subproj/WebViewInternal.h: add new internal method
WebView.subproj/WebViewPrivate.h: moved new methods to public header

11:47 AM Changeset in webkit [6828] by trey

2 edits in trunk/WebKit

Use a different hack, as recommended by Kristin, to force the drag
manager to exit a modal event wait it is in. The hack is required
to update the drag image on the fly. Instead of posting a CG
event we post at the AppKit level.

Reviewed by Louch

WebCoreSupport.subproj/WebGraphicsBridge.m: (-[WebGraphicsBridge setDraggingImage:at:]):

11:26 AM Changeset in webkit [6827] by trey

11 edits in trunk/WebCore

A new CSS pseudo-class ".drag" is added. Analogous to the "hover" class,
this class determines styles used while an element is generating a drag
image.

Reviewed by hyatt.

khtml/css/css_base.cpp: (CSSSelector::extractPseudoType): Boilerplate for adding new class.
khtml/css/css_base.h: Boilerplate for adding new class.
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector): Match new class against elements being dragged.
khtml/css/cssstyleselector.h: (khtml::StyleSelector::): Boilerplate for adding new class.
khtml/rendering/render_object.cpp: (RenderObject::RenderObject): Init new member. (RenderObject::isDragging): Return whether this object is being dragged. (RenderObject::updateDragState): Paint us an all children with a new dragged state.
khtml/rendering/render_object.h:
khtml/rendering/render_style.h: Boilerplate for adding new class. (khtml::RenderStyle::NonInheritedFlags::operator==): (khtml::RenderStyle::setBitDefaults): (khtml::RenderStyle::affectedByDragRules): (khtml::RenderStyle::setAffectedByDragRules):
kwq/KWQClipboard.mm: (KWQClipboard::dragNSImage): Method rename.
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::snapshotDragImage): Mark the element as being dragged before we snapshot it, so new style class will apply.

10:59 AM Changeset in webkit [6826] by kocienda

1 edit
12 adds in trunk

Reviewed by me

Added a few more editing-related layout tests.

layout-tests/editing/inserting/insert-3654864-fix-expected.txt: Added.
layout-tests/editing/inserting/insert-3654864-fix.html: Added.
layout-tests/editing/inserting/insert-3659587-fix-expected.txt: Added.
layout-tests/editing/inserting/insert-3659587-fix.html: Added.
layout-tests/editing/inserting/insert-after-delete-001-expected.txt: Added.
layout-tests/editing/inserting/insert-after-delete-001.html: Added.
layout-tests/editing/inserting/insert-br-case1-expected.txt: Added.
layout-tests/editing/inserting/insert-br-case1.html: Added.
layout-tests/editing/inserting/insert-br-case2-expected.txt: Added.
layout-tests/editing/inserting/insert-br-case2.html: Added.
layout-tests/editing/inserting/insert-br-case3-expected.txt: Added.
layout-tests/editing/inserting/insert-br-case3.html: Added.

10:58 AM Changeset in webkit [6825] by kocienda

1 edit
4 deletes in trunk

Reviewed by me

Regarding the bug below, removing some tests since we have removed the execCommand("paste")
feature, at least for now.

<rdar://problem/3684792>: (JavaScript execCommand("paste") presents security issues)

layout-tests/editing/pasteboard/copy-paste-text-001-expected.txt: Removed.
layout-tests/editing/pasteboard/copy-paste-text-001.html: Removed.
layout-tests/editing/pasteboard/cut-paste-text-002-expected.txt: Removed.
layout-tests/editing/pasteboard/cut-paste-text-002.html: Removed.

10:58 AM Changeset in webkit [6824] by cblu

2 edits in trunk/WebKit

Fixed:
<rdar://problem/3692668> REGRESSION: delay when images and links
<rdar://problem/3692675> links should drag when dragging images that are links when drag source action is WebDragSourceActionLink

Reviewed by trey.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _mayStartDragWithMouseDragged:]): cleaned up, only use selection delay for selections, allow links to be dragged when image dragging is disabled

10:50 AM Changeset in webkit [6823] by kocienda

2 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:

<rdar://problem/3672377> assertion failure in AppendNodeCommandImpl::doApply due to non-0 exception code trying to insert a DIV markup string

khtml/xml/dom_nodeimpl.cpp: (NodeImpl::checkAddChild): This function was being too strict in disallowing certain nodes to be added as other child nodes, applying rules we typically use for parsing. However, those parsing rules are primarily for dealing with "bad" HTML, and should not be applied to programmatic DOM operations. The fix involves removing calls to childAllowed().

10:00 AM Changeset in webkit [6822] by trey

18 edits in trunk

WebCore:

The drag image may be updated during a DHTML drag. This includes updating
from a Timer instead of a drag event handler. In addition, an arbitrary
element can be set as the one to snapshot for the drag image.

Reviewed by John

khtml/ecma/kjs_events.cpp: (ClipboardProtoFunc::tryCall): setDragImage accepts a node. Previously, it had to be an Image object.
khtml/rendering/render_object.cpp: (RenderObject::paintingRootRect): Also returns top element's rect.
khtml/rendering/render_object.h:
khtml/xml/dom2_eventsimpl.h:
kwq/KWQClipboard.h: New security mode where image is still writable, but pasteboard is not. (KWQClipboard::): (KWQClipboard::setDragHasStarted):
kwq/KWQClipboard.mm: (KWQClipboard::KWQClipboard): Part may be passed. Needed in the source case to generate an image from an element. (KWQClipboard::setAccessPolicy): New, replaces former becomeNumb method which wasn't flexible enough. (KWQClipboard::accessPolicy): New getter. (KWQClipboard::dragImage): No change, diff confusion. (KWQClipboard::setDragImage): Call new helper, below. (KWQClipboard::dragImageElement): New, return any element set. (KWQClipboard::setDragImageElement): New, call new helper. (KWQClipboard::setDragImage): New helper, set the image via either a pixmap or an element to snapshot, pushes the result to WebKit if we've already started the drag. (KWQClipboard::dragNSImage): Generate an NSImage and mouse offset, no matter how the drag image was set (Image or element).
kwq/KWQKHTMLPart.h: A single clipboard is kept over the life of a source drag instead of making one for each event.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): Init clipboard. (KWQKHTMLPart::~KWQKHTMLPart): Free clipboard. (KWQKHTMLPart::freeClipboard): New helper. (KWQKHTMLPart::dispatchDragSrcEvent): Most code moved to caller. (KWQKHTMLPart::khtmlMouseMoveEvent): Make clipboard for this drag session. Init clipboard to make an image from the dragSource element. Mark the drag as having started. (KWQKHTMLPart::dragSourceMovedTo): Clipboard will update WK with any new drag image, so we don't need to. (KWQKHTMLPart::dragSourceEndedAt): Ditto. (KWQKHTMLPart::elementImage): Also return element rect.
kwq/WebCoreBridge.h: Glue moved to WebCoreGraphicsBridge.
kwq/WebCoreBridge.mm: (-[WebCoreBridge dragOperationForDraggingInfo:]): Use new method. (-[WebCoreBridge dragExitedWithDraggingInfo:]): Ditto (-[WebCoreBridge concludeDragForDraggingInfo:]): Ditto
kwq/WebCoreGraphicsBridge.h:
kwq/WebCoreGraphicsBridge.m: (-[WebCoreGraphicsBridge setDraggingImage:at:]): Glue moved from WebBridge

WebKit:

Small rearrangement to support dynamic changing of the drag
image during DHTML dragging.

Reviewed by John

WebCoreSupport.subproj/WebBridge.m: Bridge glue moved to WebGraphicsBridge.
WebCoreSupport.subproj/WebGraphicsBridge.m: (FlipImageSpec): Code moved from WebHTMLView.m. (-[WebGraphicsBridge setDraggingImage:at:]): Ditto. Plus, we've added a gross event posting hack to force CG drag manager to update the display when we set the drag image.
WebView.subproj/WebHTMLView.m: Code moved to WebGraphicsBridge.
WebView.subproj/WebHTMLViewPrivate.h:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed