Timeline



Jun 18, 2004:

9:33 PM Changeset in webkit [6900]
  • 4 copies
    3 deletes in tags/JavaScriptCore-146~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-146~1'.

9:33 PM Changeset in webkit [6899] by vicki
  • 2 edits in branches/WWDC-2004-branch/JavaScriptCore
  • versioning for JSC-146~1
9:25 PM Changeset in webkit [6898] by vicki
  • 2 edits in branches/WWDC-2004-branch/JavaScriptCore
  • merge this fix from HEAD. Even if we can't submit this to Tiger for WWDC, we'll still need it for the Dashboard demo. No harm in merging this now.

2004-06-16 Richard Williamson <​rjw@apple.com>

Fixed <rdar://problem/3702287> Crash returning nil from bound ObjC

This turned out to be a show stopper for Dashboard. Accessing a nil
ObjC property from JS caused a crash. Similar to the problem
3696112 fixed below.

Reviewed by Trey.

  • bindings/objc/objc_runtime.mm: (KJS::Bindings::ObjcField::valueFromInstance):
8:49 PM Changeset in webkit [6897]
  • 1 copy
    23 deletes in branches/unlabeled-1.384.2.1.2

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.384.2.1.2'.

8:49 PM Changeset in webkit [6896]
  • 1 copy
    22 deletes in branches/unlabeled-1.2930.2.4.2

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.2930.2.4.2'.

8:49 PM Changeset in webkit [6895]
  • 7 copies
    2 deletes in tags/WebCore-146~1

This commit was manufactured by cvs2svn to create tag
'WebCore-146~1'.

8:49 PM Changeset in webkit [6894]
  • 7 copies
    1 delete in branches/WWDC-demo-branch

This commit was manufactured by cvs2svn to create branch
'WWDC-demo-branch'.

8:49 PM Changeset in webkit [6893] by vicki
  • 2 edits in branches/WWDC-2004-branch/WebCore
  • versioning for WebCore-146.1
6:41 PM Changeset in webkit [6892] by rjw
  • 2 edits in trunk/JavaScriptCore

Fixed <rdar://problem/3702287> Crash returning nil from bound ObjC

This turned out to be a show stopper for Dashboard. Accessing a nil
ObjC property from JS caused a crash. Similar to the problem
3696112 fixed below.

Reviewed by Trey.

  • bindings/objc/objc_runtime.mm: (KJS::Bindings::ObjcField::valueFromInstance):
6:16 PM Changeset in webkit [6891] by vicki
  • 2 edits in branches/WWDC-2004-branch/WebCore
  • merge this change from HEAD

2004-06-18 Trey Matteson <​trey@apple.com>

3702053 - DHTML dragging destination can't control the cursor (by setting the drop operation)

Fallout from security work, but an easy fix.

Reviewed by Darin

  • kwq/KWQClipboard.mm: (KWQClipboard::setDropEffect): Allow dest side to set dropEffect.
6:08 PM Changeset in webkit [6890] by vicki
  • 2 edits in branches/WWDC-2004-branch/WebCore
  • merge this change from HEAD

2004-06-18 Darin Adler <Darin Adler>

Reviewed by John.

  • re-fixed <rdar://problem/3701893> show expert preferences notes in xcode causes crash (in EllipsisBox code)
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintEllipsisBoxes): Check !isInlineFlow rather than checking hasMarkupTruncation. Otherwise, we break plain old non-markup truncation.
6:05 PM Changeset in webkit [6889] by vicki
  • 2 edits in branches/WWDC-2004-branch/WebCore
  • merge this change from HEAD

2004-06-18 Darin Adler <Darin Adler>

Reviewed by John.

  • fixed <rdar://problem/3701893> show expert preferences notes in xcode causes crash (in EllipsisBox code)
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintEllipsisBoxes): Only walk the ellipsis list if hasMarkupTruncation is true.
4:58 PM Changeset in webkit [6888] by trey
  • 2 edits in trunk/WebCore

3702053 - DHTML dragging destination can't control the cursor (by setting the drop operation)

Fallout from security work, but an easy fix.

Reviewed by Darin

  • kwq/KWQClipboard.mm: (KWQClipboard::setDropEffect): Allow dest side to set dropEffect.
4:50 PM Changeset in webkit [6887] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • re-fixed <rdar://problem/3701893> show expert preferences notes in xcode causes crash (in EllipsisBox code)
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintEllipsisBoxes): Check !isInlineFlow rather than checking hasMarkupTruncation. Otherwise, we break plain old non-markup truncation.
4:21 PM Changeset in webkit [6886] by darin
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/3701893> show expert preferences notes in xcode causes crash (in EllipsisBox code)
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintEllipsisBoxes): Only walk the ellipsis list if hasMarkupTruncation is true.
1:57 PM Changeset in webkit [6885] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Darin

  • fixed <rdar://problem/3534851> Pop up windows not showing up within SAP's BW Module (changing location.href on new window created by window.open)
  • khtml/khtml_part.cpp: (KHTMLPart::scheduleRedirection): allow new redirect to win if delay <= current delay, not just <

Jun 17, 2004:

3:46 PM Changeset in webkit [6884] by vicki
  • 3 edits in trunk

set version to 147u

3:39 PM Changeset in webkit [6883]
  • 3 copies in branches/WWDC-2004-branch

This commit was manufactured by cvs2svn to create branch
'WWDC-2004-branch'.

3:39 PM Changeset in webkit [6882]
  • 3 copies in tags/WWDC-2004-anchor

This commit was manufactured by cvs2svn to create tag
'WWDC-2004-anchor'.

3:39 PM Changeset in webkit [6881]
  • 3 copies in tags/Safari-146

This commit was manufactured by cvs2svn to create tag 'Safari-146'.

3:39 PM Changeset in webkit [6880] by vicki
  • 6 edits in trunk

Safari-146 stamp

1:18 PM Changeset in webkit [6879] by rjw
  • 2 edits in trunk/WebKit

Changed private headers to be pubic for npapi.h and npfunctions.h. That
API was approved but never marked as public in the project file. This change does
not make npruntime.h public, which contains the not yet approved changes
for script-ability of netscape plugins. Unfortunately, that API will not
be public for WWDC.

Reviewed by Chris.

  • WebKit.pbproj/project.pbxproj:
11:24 AM Changeset in webkit [6878] by rjw
  • 2 edits in trunk/WebCore

Fixed <rdar://problem/3698867> setting the canvas or parent to display:none and updating the causes a nil-deref

Ensured that we have a renderer before rendering.

Reviewed by John.

  • khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):
11:09 AM Changeset in webkit [6877] by hyatt
  • 9 edits in trunk/WebCore

Fix for 3674601, "Read More..." links should trail articles in Emerson.

Reviewed by darin

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren): (khtml::RenderBlock::deleteEllipsisLineBoxes): (khtml::RenderBlock::checkLinesForTextOverflow):
  • khtml/rendering/render_block.cpp: (khtml:::RenderFlow): (khtml::RenderBlock::paintEllipsisBoxes): (khtml::RenderBlock::nodeAtPoint): (khtml::shouldCheckLines): (khtml::getLineAtIndex): (khtml::getHeightForLineCount): (khtml::RenderBlock::lineAtIndex): (khtml::RenderBlock::lineCount): (khtml::RenderBlock::heightForLineCount): (khtml::RenderBlock::clearTruncation):
  • khtml/rendering/render_block.h: (khtml::RenderBlock::setHasMarkupTruncation): (khtml::RenderBlock::hasMarkupTruncation):
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutVerticalBox):
  • khtml/rendering/render_line.cpp: (khtml::EllipsisBox::m_str): (khtml::InlineBox::adjustPosition): (khtml::InlineFlowBox::adjustPosition): (khtml::InlineFlowBox::clearTruncation): (khtml::EllipsisBox::paint): (khtml::EllipsisBox::nodeAtPoint): (khtml::RootInlineBox::clearTruncation): (khtml::RootInlineBox::placeEllipsis): (khtml::RootInlineBox::paintEllipsisBox): (khtml::RootInlineBox::hitTestEllipsisBox): (khtml::RootInlineBox::adjustPosition): (khtml::RootInlineBox::childRemoved):
  • khtml/rendering/render_line.h: (khtml::InlineBox::clearTruncation):
  • khtml/rendering/render_text.cpp:
  • khtml/rendering/render_text.h: (khtml::InlineTextBox::clearTruncation):
1:30 AM Changeset in webkit [6876] by trey
  • 9 edits in trunk

WebCore:

3698514 - coordinates in ondragstart and ondrag events are wrong

This part fixes the ondragstart coords. We salt away the window-based mouseDown
location, since we need that when we dispatch the ondragstart event. Previously
we were errantly using a mouseDown point that had already been converted to view
coords, and then the dispatch converted it again.

Reviewed by Maciej.

  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent): Use window based mouse event coords to dispatch event. (KWQKHTMLPart::mouseDown): Save window based mouse event coords .

WebKit:

3698514 - coordinates in ondragstart and ondrag events are wrong

This part fixes the ondrag coords. I thought Cocoa passed us the mouse location
in draggedImage:movedTo:, but no, it's the position of the dragged image.
WebCore needs the mouse location, so to calc that we must save away the
offset of the mouse relative to the image when we kick off the drag.

Reviewed by Maciej.

  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:rect:event:pasteboard:source:offset:]): Add the ability to return the offset of the cursor wrt to the drag image, since this routine generates its own drag image and positions it.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Calc the offset of the cursor wrt to the drag image in the myriad of ways that we kick off the drag. (-[WebHTMLView draggedImage:movedTo:]): Adjust the location by the offset we save when we kicked off the drag. (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
  • WebView.subproj/WebHTMLViewInternal.h:
  • WebView.subproj/WebImageView.m: (-[WebImageView mouseDragged:]): Pass nil for new arg, we don't care.

Jun 16, 2004:

9:52 PM Changeset in webkit [6875]
  • 5 copies
    2 deletes in tags/WebCore-145~1

This commit was manufactured by cvs2svn to create tag
'WebCore-145~1'.

9:52 PM Changeset in webkit [6874] by vicki
  • 2 edits in trunk/WebCore
  • versioning and ChangeLog marker for WebCore-145.1 (WebCore-145 plus the selection fix)
6:38 PM Changeset in webkit [6873] by hyatt
  • 15 edits in trunk

WebCore:

Fix for 3596620, implement a subset of CSS3 text truncation for Emerson.

Reviewed by mjs

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::checkLinesForTextOverflow):
  • khtml/rendering/font.cpp: (Font::checkSelectionPoint):
  • khtml/rendering/font.h:
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject): (khtml::RenderBlock::paintFloats): (khtml::RenderBlock::paintEllipsisBoxes):
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_line.cpp: (InlineBox::canAccommodateEllipsis): (InlineBox::placeEllipsisBox): (InlineFlowBox::paintDecorations): (InlineFlowBox::placeEllipsisBox): (EllipsisBox::paint): (RootInlineBox::placeEllipsis): (RootInlineBox::placeEllipsisBox):
  • khtml/rendering/render_line.h: (khtml::EllipsisBox::m_str): (khtml::RootInlineBox::ellipsisBox):
  • khtml/rendering/render_text.cpp: (InlineTextBox::placeEllipsisBox): (InlineTextBox::paintDecoration): (InlineTextBox::offsetForPosition): (RenderText::positionForCoordinates): (RenderText::paint):
  • khtml/rendering/render_text.h:
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::checkSelectionPoint):
  • kwq/WebCoreTextRenderer.h:

WebKit:

In order to support truncation in Emerson, enhance pointToOffset so that it needn't include partial
character glyphs (the left half of a glyph).

Reviewed by mjs

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer pointToOffset:style:position:reversed:includePartialGlyphs:]): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]): (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:includePartialGlyphs:]):
6:19 PM Changeset in webkit [6872] by mjs
  • 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3697602> REGRESSION (144.2-TOT) Selection highlight does not draw

  • khtml/rendering/render_canvas.cpp: (RenderCanvas::setSelection):
5:54 PM Changeset in webkit [6871] by rjw
  • 2 edits in trunk/JavaScriptCore

Fixed <rdar://problem/3696112>: nil from an Objective-C class seems to get wrapped as a JavaScript proxy that will not print.

This turned out to be a show stopper for Dashboard. We now
return Undefined() when nil is returned from a ObjC method
that returns an object type.

Reviewed by Maciej.

  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue):
4:46 PM Changeset in webkit [6870] by vicki
  • 3 edits in trunk

change version number to 146u -- the tree is open

4:32 PM Changeset in webkit [6869]
  • 3 copies in tags/Safari-145

This commit was manufactured by cvs2svn to create tag 'Safari-145'.

4:32 PM Changeset in webkit [6868] by vicki
  • 6 edits in trunk

Safari-145 stamp

11:37 AM Changeset in webkit [6867] by sullivan
  • 1 edit in trunk/WebKit/WebKit.pbproj/project.pbxproj

Reviewed by Darin.

  • fixed <rdar://problem/3685827> Add standard news feeds from marketing.
  • BookmarksController.m: (-[BookmarksController mergeBuiltInBookmarksIfNecessary]): Use a different file for Tiger than for Panther; only the Tiger one has the news feeds in it.
  • English.lproj/BuiltInBookmarks.plist: new file that contains news feeds from marketing
  • English.lproj/OldBuiltInBookmarks.plist: Added. New name for old file.
  • WebBookmark.m: (-[WebBookmark dictionaryRepresentation]): #ifdeffed hack to avoid writing out UUIDs; used for creating built-in bookmarks file
  • WebBookmarkLeaf.m: (-[WebBookmarkLeaf dictionaryRepresentation]): #ifdeffed hack to avoid writing out last visited time; used for creating built-in bookmarks file
  • WebBookmarkList.m: (-[WebBookmarkList dictionaryRepresentation]): #ifdeffed hack to avoid writing out proxy bookmarks; used for creating built-in bookmarks file
  • WebBrowser.pbproj/project.pbxproj: updated for new file
11:18 AM Changeset in webkit [6866] by darin
  • 2 edits in trunk/WebKit
  • fixed <rdar://problem/3696081> REGRESSION: <WebKit/CarbonUtils.h> doesn't build any more

Reviewed by Trey.

  • Carbon.subproj/CarbonUtils.h: Fixed include. Need to include <ApplicationServices/ApplicationServices.h> to get CGImageRef; can't include an individual header.
11:09 AM Changeset in webkit [6865]
  • 1 copy
    39 deletes in branches/unlabeled-1.48.4/WebCore/khtml/html

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.48.4'.

11:09 AM Changeset in webkit [6864] by rjw
  • 13 edits in trunk/WebCore

Fixed 3695730: Added support for document.embeds[], much like
document.applets[], to allow access to a plugin's exported interface.

Reviewed by Chris.

  • khtml/dom/html_document.cpp: (HTMLDocument::embeds):
  • khtml/dom/html_document.h:
  • khtml/ecma/kjs_dom.cpp: (KJS::getRuntimeObject):
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): (KJS::HTMLElement::tryGet): (KJS::HTMLCollection::tryGet): (KJS::HTMLCollection::getNamedItems):
  • khtml/ecma/kjs_html.h: (KJS::HTMLDocument::):
  • khtml/ecma/kjs_html.lut.h: (KJS::):
  • khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::calcLength): (HTMLCollectionImpl::getItem): (HTMLCollectionImpl::getNamedItem):
  • khtml/html/html_miscimpl.h: (DOM::HTMLCollectionImpl::):
  • khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::getEmbedInstance):
  • khtml/html/html_objectimpl.h:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::getEmbedInstanceForView):

Jun 15, 2004:

11:29 PM Changeset in webkit [6863] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Dave.

<rdar://problem/3695907>: (can't enable selection inside parent where it is disabled via CSS)

  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
  • khtml/rendering/render_object.cpp: (RenderObject::shouldSelect):
  • khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::userSelect): (khtml::RenderStyle::setUserSelect): (khtml::RenderStyle::initialUserSelect):
7:12 PM Changeset in webkit [6862] by rjw
  • 4 edits in trunk

WebKit:

Fixed <rdar://problem/3695875>: Objective-C instances that are exported to JavaScript are too promiscuous

Flip the policy for exposing Objective-C methods and properties.

Reviewed by Trey.

  • Plugins.subproj/WebPluginPackage.m: (+[NSObject isSelectorExcludedFromWebScript:]): Just return YES. (+[NSObject isKeyExcludedFromWebScript:]): Just return YES.

JavaScriptCore:

Fixed <rdar://problem/3695875>: Objective-C instances that are exported to JavaScript are too promiscuous

No longer need to check respondsToSelector: for
isSelectorExcludedFromWebScript: and isKeyExcludedFromWebScript:
because these now have a default implementation on NSObject.

Reviewed by Trey.

  • bindings/objc/objc_class.mm: (ObjcClass::methodsNamed): (ObjcClass::fieldNamed):
6:59 PM Changeset in webkit [6861] by trey
  • 4 edits in trunk/WebKit

3639321 - Harvard PIN authentication ends up sending PIN as clear text with POST action

When going back/forward to an item, if we went there originally via a POST,
we ask the user about rePOSTing, and if they say yes, we resend the POST.
This rePOST case is triggered by the form data that we saved on the b/f item.
In the case of this bug, the overall navigation was accomplished by a POST,
then a redirect, causing a GET. When a load of type redirect achieves the Committed
stage, we replace the current URL in the b/f item with the new URL (instead of
adding a new item to the b/f list).

The bug is that at the same time we should also update the form data in
the b/f item to match that of the new request. I think this will normally
mean nil'ing it out, unless there's some way for the result of the redirect
to be another POST.

The security leak occurred because we did not clear the form data on the item,
so when going back or forward to the page, we would go into the rePOSTing code,
even though we eventually reached that page via a GET (caused by the redirect).
So we would do a POST to the redirect URL containing the private data sent in
the original POST.

Reviewed by mjs and rjw.

  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem _setFormInfoFromRequest:]): New method, just wraps 3 old set methods. (-[WebHistoryItem formData]): Diff being dumb, no change. (-[WebHistoryItem formContentType]): Ditto (-[WebHistoryItem formReferrer]): Ditto
  • History.subproj/WebHistoryItemPrivate.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame _createItem:]): Call new WebHistoryItem method - no change in real behavior (-[WebFrame _transitionToCommitted:]): Clear out the form data at the key time, to fix the bug.
6:19 PM Changeset in webkit [6860] by hyatt
  • 4 edits in trunk/WebCore

Initial impl of the EllipsisBox. This code just gets the box created and gets it placed vertically. The next
stage will be to position the box horizontally as well.

Reviewed by trey

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::checkLinesForTextOverflow):
  • khtml/rendering/render_line.cpp: (RootInlineBox::placeEllipsis):
  • khtml/rendering/render_line.h: (khtml::EllipsisBox::m_str):
5:41 PM Changeset in webkit [6859] by cblu
  • 4 edits in trunk/WebKit

Fixed: <rdar://problem/3695724> WebKit plug-ins should only have to implement plugInViewWithArguments:

Reviewed by rjw.

  • ChangeLog:
  • Plugins.subproj/WebPluginViewFactory.h: mention that plugInViewWithArguments is required
  • WebView.subproj/WebFrame.m: (-[WebFrame _reloadForPluginChanges]): check for plugInViewWithArguments: not webPlugInInitialize
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView addSubview:]): ditto
5:00 PM Changeset in webkit [6858] by hyatt
  • 4 edits in trunk/WebCore

Implement canAccommodateEllipsis. The basic idea is that everything on a line will allow an ellipsis to be
drawn on top of it unless it's a replaced element. Then, if the replaced element overlaps, the ellipsis won't
be allowed.

Reviewed by john

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::checkLinesForTextOverflow):
  • khtml/rendering/render_line.cpp: (InlineBox::closestLeafChildForXPos): (InlineBox::canAccommodateEllipsis): (InlineFlowBox::canAccommodateEllipsis): (RootInlineBox::canAccommodateEllipsis):
  • khtml/rendering/render_line.h:
3:48 PM Changeset in webkit [6857] by trey
  • 2 edits in trunk/WebKit

3695240 - pasting plain text with newlines in it turns them into spaces

Easy fix, we just need to consume the incoming data as text instead of markup.

Reviewed by John and Darin.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]):
11:07 AM Changeset in webkit [6856] by vicki
  • 1 edit
    4 adds in trunk
  • added a few layout tests, rdar://3694510
  • layout-tests/editing/deleting/delete-image-004-expected.txt: Added.
  • layout-tests/editing/deleting/delete-image-004.html: Added.
  • layout-tests/editing/selection/extend-by-character-006-expected.txt: Added.
  • layout-tests/editing/selection/extend-by-character-006.html: Added.
9:15 AM Changeset in webkit [6855] by trey
  • 2 edits in trunk/WebCore

Dragging tweak: We pass the mouse down coords instead of the
latest mouse drag coords to the ondragstart event. This makes it
easy for the client to figure the correct drag image offset,
whereas the mouse drag location is next to useless for that.

Reviewed by Louch

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent):
2:44 AM Changeset in webkit [6854] by mjs
  • 11 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3685236>: (Safari does not support onselectstart event handler)

  • khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): (DOMNode::putValue):
  • khtml/ecma/kjs_dom.h: (KJS::DOMNode::):
  • khtml/ecma/kjs_dom.lut.h: (KJS::):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseHTMLAttribute):
  • khtml/misc/htmlattrs.c: (hash_attr): (findAttr):
  • khtml/misc/htmlattrs.h:
  • khtml/misc/htmlattrs.in:
  • khtml/rendering/render_object.cpp: (RenderObject::shouldSelect):
  • khtml/xml/dom2_eventsimpl.cpp: (EventImpl::typeToId): (EventImpl::idToType):
  • khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::):
1:49 AM Changeset in webkit [6853] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix crash with last checkin.

  • khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::domObjectsPerDocument): check the same property we want to initialize.
1:30 AM Changeset in webkit [6852] by darin
  • 2 edits in trunk/WebKit
  • fixed crash introduced by my earlier change
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageContext dealloc]): Set _cgsContext to 0 before calling super as before. (-[WebImageContext finalize]): Ditto.
1:12 AM Changeset in webkit [6851] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3685309>: (properties not shared for JS wrappers of same DOM object, accessed from different frames)

  • khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::domObjects): (ScriptInterpreter::domObjectsPerDocument): (ScriptInterpreter::ScriptInterpreter): (ScriptInterpreter::forgetDOMObject): (ScriptInterpreter::getDOMObjectForDocument): (ScriptInterpreter::putDOMObjectForDocument): (ScriptInterpreter::deleteDOMObjectsForDocument): (ScriptInterpreter::mark): (ScriptInterpreter::forgetDOMObjectsForDocument): (ScriptInterpreter::updateDOMObjectDocument):
  • khtml/ecma/kjs_binding.h: (KJS::ScriptInterpreter::getDOMObject): (KJS::ScriptInterpreter::putDOMObject): (KJS::ScriptInterpreter::deleteDOMObject):
1:07 AM Changeset in webkit [6850] by darin
  • 2 edits in trunk/WebCore
  • rolled out Ken's fix for <rdar://problem/3672377> assertion failure in AppendNodeCommandImpl::doApply due to non-0 exception code trying to insert a DIV markup string (it was making most layout tests fail)
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::checkAddChild): Rolled check back in.
1:01 AM Changeset in webkit [6849] by hyatt
  • 3 edits in trunk/WebCore

Add a truncation variable to text run boxes that will eventually be used to know how to cut out some of the glyphs when
rendering.

Reviewed by darin

  • khtml/rendering/render_text.cpp: (RenderText::clearTextOverflowTruncation):
  • khtml/rendering/render_text.h: (khtml::InlineTextBox:::InlineRunBox): (khtml::InlineTextBox::clearTruncation):
12:53 AM Changeset in webkit [6848] by darin
  • 7 edits in trunk/WebKit

Reviewed by Maciej.

  • fixed some things for GC that Patrick missed, or that happened after the branch
  • Carbon.subproj/HIWebView.m: (HIWebViewConstructor): Use CFRetain instead of retain. (HIWebViewDestructor): Use CFRelease instead of release.
  • Misc.subproj/WebFileDatabase.m: (-[WebFileDatabase initWithPath:]): Use release instead of dealloc.
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageContext finalize]): Had [super dealloc] here by mistake; change to [super finalize].
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer finalize]): Added.
  • WebView.subproj/WebDebugDOMNode.m: (-[WebDebugDOMNode initWithWebFrameView:]): Use release instead of dealloc.
  • WebView.subproj/WebRenderNode.m: (-[WebRenderNode initWithWebFrameView:]): Use release instead of dealloc.
12:46 AM Changeset in webkit [6847] by darin
  • 11 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed some things for GC that Patrick missed, or that happened after the branch
  • kwq/DOM-CSS.mm: (-[DOMStyleSheet finalize]): Added. (-[DOMStyleSheetList finalize]): Added. (-[DOMCSSStyleSheet finalize]): Added. (-[DOMMediaList finalize]): Added. (-[DOMCSSRuleList finalize]): Added. (-[DOMCSSRule finalize]): Added. (-[DOMCSSStyleDeclaration finalize]): Added. (-[DOMCSSValue finalize]): Added. (-[DOMRGBColor finalize]): Added. (-[DOMRect finalize]): Added. (-[DOMCounter finalize]): Added.
  • kwq/DOM.mm: (-[DOMObject finalize]): Added. (-[DOMNode finalize]): Added. (-[DOMNamedNodeMap finalize]): Added. (-[DOMNodeList finalize]): Added. (-[DOMImplementation finalize]): Added. (-[DOMRange finalize]): Added. (-[DOMNodeFilter finalize]): Added. (-[DOMNodeIterator finalize]): Added. (-[DOMTreeWalker dealloc]): Removed unneeded nil check. (-[DOMTreeWalker finalize]): Added.
  • kwq/DOMHTML.mm: (-[DOMHTMLCollection finalize]): Added. (-[DOMHTMLOptionsCollection finalize]): Added.
  • kwq/KWQClipboard.mm: (KWQClipboard::KWQClipboard): Use KWQRetain instead of retain. (KWQClipboard::~KWQClipboard): Use KWQRelease instead of release.
  • kwq/KWQEditCommand.mm: (-[KWQEditCommand finalize]): Added.
  • kwq/KWQFont.mm: (QFont::~QFont): Use KWQRelease instead of release.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent): Use KWQRetain instead of retain, and KWQRelease instead of release. (KWQKHTMLPart::mouseDown): Use KWQRetain instead of retain, and KWQRelease instead of release. (KWQKHTMLPart::mouseDragged): Use KWQRetain instead of retain, and KWQRelease instead of release. (KWQKHTMLPart::mouseUp): Use KWQRetain instead of retain, and KWQRelease instead of release. (KWQKHTMLPart::mouseMoved): Use KWQRetain instead of retain, and KWQRelease instead of release. (KWQKHTMLPart::sendContextMenuEvent): Use KWQRetain instead of retain, and KWQRelease instead of release.
  • kwq/KWQPageState.mm: (-[KWQPageState finalize]): Added. Filed <rdar://problem/3694163> about the fact that this is not right.
  • kwq/KWQTimer.mm: (-[KWQSingleShotTimerTarget finalize]): Added.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge finalize]): Added. Filed <rdar://problem/3694165> about the fact that this is not right.
12:38 AM Changeset in webkit [6846] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • fixed some things for GC that Patrick missed, or that happened after the branch
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject dealloc]): Moved removeNativeReference call here from private object. (-[WebScriptObject finalize]): Added.
  • added some missing nil checks
  • bindings/objc/objc_instance.mm: (ObjcInstance::ObjcInstance): Check for nil. (ObjcInstance::~ObjcInstance): Check for nil. (ObjcInstance::operator=): Check for nil.
12:24 AM Changeset in webkit [6845] by hyatt
  • 1 edit in trunk/WebCore/khtml/rendering/bidi.cpp

Typo in src comment.

12:23 AM Changeset in webkit [6844] by trey
  • 2 edits in trunk/WebKit

Fix ASSERT/crash we get sometimes when dragging link images. Turns
out there was an uninitialized variable for the image size,
so at random we would try to create huge images that could not
be focused.

Reviewed by Maciej and Darin.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _dragImageForLinkElement:]): Trivial fix to not use += with uninited variable.
12:21 AM Changeset in webkit [6843] by hyatt
  • 7 edits in trunk/WebCore

Initial work on text truncation. Working top-down, I think I've made all the changes I will need to bidi.cpp
and to the block code itself. The rest of the code can be concentrated in the render_line and render_text files.

Reviewed by darin

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren): (khtml::RenderBlock::findNextLineBreak): (khtml::RenderBlock::deleteEllipsisLineBoxes): (khtml::RenderBlock::checkLinesForTextOverflow):
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_line.cpp: (RootInlineBox::detach): (RootInlineBox::detachEllipsisBox): (RootInlineBox::canAccommodateEllipsis): (RootInlineBox::placeEllipsis):
  • khtml/rendering/render_line.h: (khtml::RootInlineBox::RootInlineBox):
  • khtml/rendering/render_text.cpp: (RenderText::clearTextOverflowTruncation):
  • khtml/rendering/render_text.h:
12:01 AM Changeset in webkit [6842] by trey
  • 2 edits in trunk/WebCore

3692690 - REGRESSION: canceling drag from WebView cause link to load
Just need to take extra care to cancel any click handling in
all cases once we're committed to doing the drag.

Reviewed by Darin.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent): Call invalidateClick once we're past the hysteresis point, and definitely going to try to start a drag and drop.
Note: See TracTimeline for information about the timeline view.