Timeline
Jun 18, 2004:
- 9:33 PM Changeset in webkit [6900]
-
- 4 copies3 deletes in tags/JavaScriptCore-146~1
This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-146~1'.
- 9:33 PM Changeset in webkit [6899] by
-
- 2 edits in branches/WWDC-2004-branch/JavaScriptCore
- versioning for JSC-146~1
- 9:25 PM Changeset in webkit [6898] by
-
- 2 edits in branches/WWDC-2004-branch/JavaScriptCore
- merge this fix from HEAD. Even if we can't submit this to Tiger for WWDC, we'll still need it for the Dashboard demo. No harm in merging this now.
2004-06-16 Richard Williamson <rjw@apple.com>
Fixed <rdar://problem/3702287> Crash returning nil from bound ObjC
This turned out to be a show stopper for Dashboard. Accessing a nil
ObjC property from JS caused a crash. Similar to the problem
3696112 fixed below.
Reviewed by Trey.
- bindings/objc/objc_runtime.mm: (KJS::Bindings::ObjcField::valueFromInstance):
- 8:49 PM Changeset in webkit [6897]
-
- 1 copy23 deletes in branches/unlabeled-1.384.2.1.2
This commit was manufactured by cvs2svn to create branch
'unlabeled-1.384.2.1.2'.
- 8:49 PM Changeset in webkit [6896]
-
- 1 copy22 deletes in branches/unlabeled-1.2930.2.4.2
This commit was manufactured by cvs2svn to create branch
'unlabeled-1.2930.2.4.2'.
- 8:49 PM Changeset in webkit [6895]
-
- 7 copies2 deletes in tags/WebCore-146~1
This commit was manufactured by cvs2svn to create tag
'WebCore-146~1'.
- 8:49 PM Changeset in webkit [6894]
-
- 7 copies1 delete in branches/WWDC-demo-branch
This commit was manufactured by cvs2svn to create branch
'WWDC-demo-branch'.
- 8:49 PM Changeset in webkit [6893] by
-
- 2 edits in branches/WWDC-2004-branch/WebCore
- versioning for WebCore-146.1
- 6:41 PM Changeset in webkit [6892] by
-
- 2 edits in trunk/JavaScriptCore
Fixed <rdar://problem/3702287> Crash returning nil from bound ObjC
This turned out to be a show stopper for Dashboard. Accessing a nil
ObjC property from JS caused a crash. Similar to the problem
3696112 fixed below.
Reviewed by Trey.
- bindings/objc/objc_runtime.mm: (KJS::Bindings::ObjcField::valueFromInstance):
- 6:16 PM Changeset in webkit [6891] by
-
- 2 edits in branches/WWDC-2004-branch/WebCore
- merge this change from HEAD
2004-06-18 Trey Matteson <trey@apple.com>
3702053 - DHTML dragging destination can't control the cursor (by setting the drop operation)
Fallout from security work, but an easy fix.
Reviewed by Darin
- kwq/KWQClipboard.mm: (KWQClipboard::setDropEffect): Allow dest side to set dropEffect.
- 6:08 PM Changeset in webkit [6890] by
-
- 2 edits in branches/WWDC-2004-branch/WebCore
- merge this change from HEAD
2004-06-18 Darin Adler <Darin Adler>
Reviewed by John.
- re-fixed <rdar://problem/3701893> show expert preferences notes in xcode causes crash (in EllipsisBox code)
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintEllipsisBoxes): Check !isInlineFlow rather than checking hasMarkupTruncation. Otherwise, we break plain old non-markup truncation.
- 6:05 PM Changeset in webkit [6889] by
-
- 2 edits in branches/WWDC-2004-branch/WebCore
- merge this change from HEAD
2004-06-18 Darin Adler <Darin Adler>
Reviewed by John.
- fixed <rdar://problem/3701893> show expert preferences notes in xcode causes crash (in EllipsisBox code)
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintEllipsisBoxes): Only walk the ellipsis list if hasMarkupTruncation is true.
- 4:58 PM Changeset in webkit [6888] by
-
- 2 edits in trunk/WebCore
3702053 - DHTML dragging destination can't control the cursor (by setting the drop operation)
Fallout from security work, but an easy fix.
Reviewed by Darin
- kwq/KWQClipboard.mm: (KWQClipboard::setDropEffect): Allow dest side to set dropEffect.
- 4:50 PM Changeset in webkit [6887] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
- re-fixed <rdar://problem/3701893> show expert preferences notes in xcode causes crash (in EllipsisBox code)
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintEllipsisBoxes): Check !isInlineFlow rather than checking hasMarkupTruncation. Otherwise, we break plain old non-markup truncation.
- 4:21 PM Changeset in webkit [6886] by
-
- 3 edits in trunk/WebCore
Reviewed by John.
- fixed <rdar://problem/3701893> show expert preferences notes in xcode causes crash (in EllipsisBox code)
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintEllipsisBoxes): Only walk the ellipsis list if hasMarkupTruncation is true.
- 1:57 PM Changeset in webkit [6885] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin
- fixed <rdar://problem/3534851> Pop up windows not showing up within SAP's BW Module (changing location.href on new window created by window.open)
- khtml/khtml_part.cpp: (KHTMLPart::scheduleRedirection): allow new redirect to win if delay <= current delay, not just <
Jun 17, 2004:
- 3:46 PM Changeset in webkit [6884] by
-
- 3 edits in trunk
set version to 147u
- 3:39 PM Changeset in webkit [6883]
-
- 3 copies in branches/WWDC-2004-branch
This commit was manufactured by cvs2svn to create branch
'WWDC-2004-branch'.
- 3:39 PM Changeset in webkit [6882]
-
- 3 copies in tags/WWDC-2004-anchor
This commit was manufactured by cvs2svn to create tag
'WWDC-2004-anchor'.
- 3:39 PM Changeset in webkit [6881]
-
- 3 copies in tags/Safari-146
This commit was manufactured by cvs2svn to create tag 'Safari-146'.
- 3:39 PM Changeset in webkit [6880] by
-
- 6 edits in trunk
Safari-146 stamp
- 1:18 PM Changeset in webkit [6879] by
-
- 2 edits in trunk/WebKit
Changed private headers to be pubic for npapi.h and npfunctions.h. That
API was approved but never marked as public in the project file. This change does
not make npruntime.h public, which contains the not yet approved changes
for script-ability of netscape plugins. Unfortunately, that API will not
be public for WWDC.
Reviewed by Chris.
- WebKit.pbproj/project.pbxproj:
- 11:24 AM Changeset in webkit [6878] by
-
- 2 edits in trunk/WebCore
Fixed <rdar://problem/3698867> setting the canvas or parent to display:none and updating the causes a nil-deref
Ensured that we have a renderer before rendering.
Reviewed by John.
- khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):
- 11:09 AM Changeset in webkit [6877] by
-
- 9 edits in trunk/WebCore
Fix for 3674601, "Read More..." links should trail articles in Emerson.
Reviewed by darin
- khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren): (khtml::RenderBlock::deleteEllipsisLineBoxes): (khtml::RenderBlock::checkLinesForTextOverflow):
- khtml/rendering/render_block.cpp: (khtml:::RenderFlow): (khtml::RenderBlock::paintEllipsisBoxes): (khtml::RenderBlock::nodeAtPoint): (khtml::shouldCheckLines): (khtml::getLineAtIndex): (khtml::getHeightForLineCount): (khtml::RenderBlock::lineAtIndex): (khtml::RenderBlock::lineCount): (khtml::RenderBlock::heightForLineCount): (khtml::RenderBlock::clearTruncation):
- khtml/rendering/render_block.h: (khtml::RenderBlock::setHasMarkupTruncation): (khtml::RenderBlock::hasMarkupTruncation):
- khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutVerticalBox):
- khtml/rendering/render_line.cpp: (khtml::EllipsisBox::m_str): (khtml::InlineBox::adjustPosition): (khtml::InlineFlowBox::adjustPosition): (khtml::InlineFlowBox::clearTruncation): (khtml::EllipsisBox::paint): (khtml::EllipsisBox::nodeAtPoint): (khtml::RootInlineBox::clearTruncation): (khtml::RootInlineBox::placeEllipsis): (khtml::RootInlineBox::paintEllipsisBox): (khtml::RootInlineBox::hitTestEllipsisBox): (khtml::RootInlineBox::adjustPosition): (khtml::RootInlineBox::childRemoved):
- khtml/rendering/render_line.h: (khtml::InlineBox::clearTruncation):
- khtml/rendering/render_text.cpp:
- khtml/rendering/render_text.h: (khtml::InlineTextBox::clearTruncation):
- 1:30 AM Changeset in webkit [6876] by
-
- 9 edits in trunk
WebCore:
3698514 - coordinates in ondragstart and ondrag events are wrong
This part fixes the ondragstart coords. We salt away the window-based mouseDown
location, since we need that when we dispatch the ondragstart event. Previously
we were errantly using a mouseDown point that had already been converted to view
coords, and then the dispatch converted it again.
Reviewed by Maciej.
- kwq/KWQKHTMLPart.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent): Use window based mouse event coords to dispatch event. (KWQKHTMLPart::mouseDown): Save window based mouse event coords .
WebKit:
3698514 - coordinates in ondragstart and ondrag events are wrong
This part fixes the ondrag coords. I thought Cocoa passed us the mouse location
in draggedImage:movedTo:, but no, it's the position of the dragged image.
WebCore needs the mouse location, so to calc that we must save away the
offset of the mouse relative to the image when we kick off the drag.
Reviewed by Maciej.
- Misc.subproj/WebNSViewExtras.h:
- Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:rect:event:pasteboard:source:offset:]): Add the ability to return the offset of the cursor wrt to the drag image, since this routine generates its own drag image and positions it.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Calc the offset of the cursor wrt to the drag image in the myriad of ways that we kick off the drag. (-[WebHTMLView draggedImage:movedTo:]): Adjust the location by the offset we save when we kicked off the drag. (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
- WebView.subproj/WebHTMLViewInternal.h:
- WebView.subproj/WebImageView.m: (-[WebImageView mouseDragged:]): Pass nil for new arg, we don't care.
Jun 16, 2004:
- 9:52 PM Changeset in webkit [6875]
-
- 5 copies2 deletes in tags/WebCore-145~1
This commit was manufactured by cvs2svn to create tag
'WebCore-145~1'.
- 9:52 PM Changeset in webkit [6874] by
-
- 2 edits in trunk/WebCore
- versioning and ChangeLog marker for WebCore-145.1 (WebCore-145 plus the selection fix)
- 6:38 PM Changeset in webkit [6873] by
-
- 15 edits in trunk
WebCore:
Fix for 3596620, implement a subset of CSS3 text truncation for Emerson.
Reviewed by mjs
- khtml/rendering/bidi.cpp: (khtml::RenderBlock::checkLinesForTextOverflow):
- khtml/rendering/font.cpp: (Font::checkSelectionPoint):
- khtml/rendering/font.h:
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject): (khtml::RenderBlock::paintFloats): (khtml::RenderBlock::paintEllipsisBoxes):
- khtml/rendering/render_block.h:
- khtml/rendering/render_line.cpp: (InlineBox::canAccommodateEllipsis): (InlineBox::placeEllipsisBox): (InlineFlowBox::paintDecorations): (InlineFlowBox::placeEllipsisBox): (EllipsisBox::paint): (RootInlineBox::placeEllipsis): (RootInlineBox::placeEllipsisBox):
- khtml/rendering/render_line.h: (khtml::EllipsisBox::m_str): (khtml::RootInlineBox::ellipsisBox):
- khtml/rendering/render_text.cpp: (InlineTextBox::placeEllipsisBox): (InlineTextBox::paintDecoration): (InlineTextBox::offsetForPosition): (RenderText::positionForCoordinates): (RenderText::paint):
- khtml/rendering/render_text.h:
- kwq/KWQFontMetrics.h:
- kwq/KWQFontMetrics.mm: (QFontMetrics::checkSelectionPoint):
- kwq/WebCoreTextRenderer.h:
WebKit:
In order to support truncation in Emerson, enhance pointToOffset so that it needn't include partial
character glyphs (the left half of a glyph).
Reviewed by mjs
- WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer pointToOffset:style:position:reversed:includePartialGlyphs:]): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]): (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:includePartialGlyphs:]):
- 6:19 PM Changeset in webkit [6872] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
<rdar://problem/3697602> REGRESSION (144.2-TOT) Selection highlight does not draw
- khtml/rendering/render_canvas.cpp: (RenderCanvas::setSelection):
- 5:54 PM Changeset in webkit [6871] by
-
- 2 edits in trunk/JavaScriptCore
Fixed <rdar://problem/3696112>: nil from an Objective-C class seems to get wrapped as a JavaScript proxy that will not print.
This turned out to be a show stopper for Dashboard. We now
return Undefined() when nil is returned from a ObjC method
that returns an object type.
Reviewed by Maciej.
- bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue):
- 4:46 PM Changeset in webkit [6870] by
-
- 3 edits in trunk
change version number to 146u -- the tree is open
- 4:32 PM Changeset in webkit [6869]
-
- 3 copies in tags/Safari-145
This commit was manufactured by cvs2svn to create tag 'Safari-145'.
- 4:32 PM Changeset in webkit [6868] by
-
- 6 edits in trunk
Safari-145 stamp
- 11:37 AM Changeset in webkit [6867] by
-
- 1 edit in trunk/WebKit/WebKit.pbproj/project.pbxproj
Reviewed by Darin.
- fixed <rdar://problem/3685827> Add standard news feeds from marketing.
- BookmarksController.m: (-[BookmarksController mergeBuiltInBookmarksIfNecessary]): Use a different file for Tiger than for Panther; only the Tiger one has the news feeds in it.
- English.lproj/BuiltInBookmarks.plist: new file that contains news feeds from marketing
- English.lproj/OldBuiltInBookmarks.plist: Added. New name for old file.
- WebBookmark.m: (-[WebBookmark dictionaryRepresentation]): #ifdeffed hack to avoid writing out UUIDs; used for creating built-in bookmarks file
- WebBookmarkLeaf.m: (-[WebBookmarkLeaf dictionaryRepresentation]): #ifdeffed hack to avoid writing out last visited time; used for creating built-in bookmarks file
- WebBookmarkList.m: (-[WebBookmarkList dictionaryRepresentation]): #ifdeffed hack to avoid writing out proxy bookmarks; used for creating built-in bookmarks file
- WebBrowser.pbproj/project.pbxproj: updated for new file
- 11:18 AM Changeset in webkit [6866] by
-
- 2 edits in trunk/WebKit
- fixed <rdar://problem/3696081> REGRESSION: <WebKit/CarbonUtils.h> doesn't build any more
Reviewed by Trey.
- Carbon.subproj/CarbonUtils.h: Fixed include. Need to include <ApplicationServices/ApplicationServices.h> to get CGImageRef; can't include an individual header.
- 11:09 AM Changeset in webkit [6865]
-
- 1 copy39 deletes in branches/unlabeled-1.48.4/WebCore/khtml/html
This commit was manufactured by cvs2svn to create branch
'unlabeled-1.48.4'.
- 11:09 AM Changeset in webkit [6864] by
-
- 13 edits in trunk/WebCore
Fixed 3695730: Added support for document.embeds[], much like
document.applets[], to allow access to a plugin's exported interface.
Reviewed by Chris.
- khtml/dom/html_document.cpp: (HTMLDocument::embeds):
- khtml/dom/html_document.h:
- khtml/ecma/kjs_dom.cpp: (KJS::getRuntimeObject):
- khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): (KJS::HTMLElement::tryGet): (KJS::HTMLCollection::tryGet): (KJS::HTMLCollection::getNamedItems):
- khtml/ecma/kjs_html.h: (KJS::HTMLDocument::):
- khtml/ecma/kjs_html.lut.h: (KJS::):
- khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::calcLength): (HTMLCollectionImpl::getItem): (HTMLCollectionImpl::getNamedItem):
- khtml/html/html_miscimpl.h: (DOM::HTMLCollectionImpl::):
- khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::getEmbedInstance):
- khtml/html/html_objectimpl.h:
- kwq/KWQKHTMLPart.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::getEmbedInstanceForView):
