Context Navigation

Misc.subproj/WebKitErrors.m: (registerErrors): register string for WebKitErrorPlugInCancelledConnection
Misc.subproj/WebKitErrorsPrivate.h:
Plugins.subproj/WebBaseNetscapePluginStream.h:
Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]): use renamed WEB_REASON_PLUGIN_CANCELLED constant (-[WebBaseNetscapePluginStream destroyStream]): ditto
Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation cancelWithReason:]): if the reason is WEB_REASON_PLUGIN_CANCELLED, cancel the load with WebKitErrorPlugInCancelledConnection
Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream cancelWithReason:]): ditto

WebBrowser:

Fixed: <rdar://problem/3701269> change in error handling behavior from 10.3.3 to 10.3.4 breaks unreleased Adobe PDF plug-in

Reviewed by john.

LoadProgressMonitor.m:
LocationChangeHandler.m: if the error is WebKitErrorPlugInCancelledConnection ignore it (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]): ditto

10:46 AM Changeset in webkit [6902] by vicki

1 edit in trunk/WebCore/ChangeLog-2005-08-23

add a release marker for WebCore-146.1

10:24 AM Changeset in webkit [6901] by vicki

1 edit in trunk/JavaScriptCore/ChangeLog

add release marker for JSC-146.1

Jun 18, 2004:

9:33 PM Changeset in webkit [6900]

4 copies
3 deletes in tags/JavaScriptCore-146~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-146~1'.

9:33 PM Changeset in webkit [6899] by vicki

2 edits in branches/WWDC-2004-branch/JavaScriptCore

versioning for JSC-146~1

9:25 PM Changeset in webkit [6898] by vicki

2 edits in branches/WWDC-2004-branch/JavaScriptCore

merge this fix from HEAD. Even if we can't submit this to Tiger for WWDC, we'll still need it for the Dashboard demo. No harm in merging this now.

2004-06-16 Richard Williamson <rjw@apple.com>

Fixed <rdar://problem/3702287> Crash returning nil from bound ObjC

This turned out to be a show stopper for Dashboard. Accessing a nil
ObjC property from JS caused a crash. Similar to the problem
3696112 fixed below.

Reviewed by Trey.

bindings/objc/objc_runtime.mm: (KJS::Bindings::ObjcField::valueFromInstance):

8:49 PM Changeset in webkit [6897]

1 copy
23 deletes in branches/unlabeled-1.384.2.1.2

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.384.2.1.2'.

8:49 PM Changeset in webkit [6896]

1 copy
22 deletes in branches/unlabeled-1.2930.2.4.2

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.2930.2.4.2'.

8:49 PM Changeset in webkit [6895]

7 copies
2 deletes in tags/WebCore-146~1

This commit was manufactured by cvs2svn to create tag
'WebCore-146~1'.

8:49 PM Changeset in webkit [6894]

7 copies
1 delete in branches/WWDC-demo-branch

This commit was manufactured by cvs2svn to create branch
'WWDC-demo-branch'.

8:49 PM Changeset in webkit [6893] by vicki

2 edits in branches/WWDC-2004-branch/WebCore

versioning for WebCore-146.1

6:41 PM Changeset in webkit [6892] by rjw

2 edits in trunk/JavaScriptCore

Fixed <rdar://problem/3702287> Crash returning nil from bound ObjC

This turned out to be a show stopper for Dashboard. Accessing a nil
ObjC property from JS caused a crash. Similar to the problem
3696112 fixed below.

Reviewed by Trey.

bindings/objc/objc_runtime.mm: (KJS::Bindings::ObjcField::valueFromInstance):

6:16 PM Changeset in webkit [6891] by vicki

2 edits in branches/WWDC-2004-branch/WebCore

merge this change from HEAD

2004-06-18 Trey Matteson <trey@apple.com>

3702053 - DHTML dragging destination can't control the cursor (by setting the drop operation)

Fallout from security work, but an easy fix.

Reviewed by Darin

kwq/KWQClipboard.mm: (KWQClipboard::setDropEffect): Allow dest side to set dropEffect.

6:08 PM Changeset in webkit [6890] by vicki

2 edits in branches/WWDC-2004-branch/WebCore

merge this change from HEAD

2004-06-18 Darin Adler <Darin Adler>

Reviewed by John.

re-fixed <rdar://problem/3701893> show expert preferences notes in xcode causes crash (in EllipsisBox code)

khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintEllipsisBoxes): Check !isInlineFlow rather than checking hasMarkupTruncation. Otherwise, we break plain old non-markup truncation.

6:05 PM Changeset in webkit [6889] by vicki

2 edits in branches/WWDC-2004-branch/WebCore

merge this change from HEAD

2004-06-18 Darin Adler <Darin Adler>

Reviewed by John.

fixed <rdar://problem/3701893> show expert preferences notes in xcode causes crash (in EllipsisBox code)

khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintEllipsisBoxes): Only walk the ellipsis list if hasMarkupTruncation is true.

4:58 PM Changeset in webkit [6888] by trey

2 edits in trunk/WebCore

3702053 - DHTML dragging destination can't control the cursor (by setting the drop operation)

Fallout from security work, but an easy fix.

Reviewed by Darin

kwq/KWQClipboard.mm: (KWQClipboard::setDropEffect): Allow dest side to set dropEffect.

4:50 PM Changeset in webkit [6887] by darin

2 edits in trunk/WebCore

Reviewed by John.

re-fixed <rdar://problem/3701893> show expert preferences notes in xcode causes crash (in EllipsisBox code)

khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintEllipsisBoxes): Check !isInlineFlow rather than checking hasMarkupTruncation. Otherwise, we break plain old non-markup truncation.

4:21 PM Changeset in webkit [6886] by darin

3 edits in trunk/WebCore

Reviewed by John.

fixed <rdar://problem/3701893> show expert preferences notes in xcode causes crash (in EllipsisBox code)

khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintEllipsisBoxes): Only walk the ellipsis list if hasMarkupTruncation is true.

1:57 PM Changeset in webkit [6885] by sullivan

2 edits in trunk/WebCore

Reviewed by Darin

fixed <rdar://problem/3534851> Pop up windows not showing up within SAP's BW Module (changing location.href on new window created by window.open)

khtml/khtml_part.cpp: (KHTMLPart::scheduleRedirection): allow new redirect to win if delay <= current delay, not just <

Jun 17, 2004:

3:46 PM Changeset in webkit [6884] by vicki

3 edits in trunk

set version to 147u

3:39 PM Changeset in webkit [6883]

3 copies in branches/WWDC-2004-branch

This commit was manufactured by cvs2svn to create branch
'WWDC-2004-branch'.

3:39 PM Changeset in webkit [6882]

3 copies in tags/WWDC-2004-anchor

This commit was manufactured by cvs2svn to create tag
'WWDC-2004-anchor'.

3:39 PM Changeset in webkit [6881]

3 copies in tags/Safari-146

This commit was manufactured by cvs2svn to create tag 'Safari-146'.

3:39 PM Changeset in webkit [6880] by vicki

6 edits in trunk

Safari-146 stamp

1:18 PM Changeset in webkit [6879] by rjw

2 edits in trunk/WebKit

Changed private headers to be pubic for npapi.h and npfunctions.h. That
API was approved but never marked as public in the project file. This change does
not make npruntime.h public, which contains the not yet approved changes
for script-ability of netscape plugins. Unfortunately, that API will not
be public for WWDC.

Reviewed by Chris.

WebKit.pbproj/project.pbxproj:

11:24 AM Changeset in webkit [6878] by rjw

2 edits in trunk/WebCore

Fixed <rdar://problem/3698867> setting the canvas or parent to display:none and updating the causes a nil-deref

Ensured that we have a renderer before rendering.

Reviewed by John.

khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):

11:09 AM Changeset in webkit [6877] by hyatt

9 edits in trunk/WebCore

Fix for 3674601, "Read More..." links should trail articles in Emerson.

Reviewed by darin

khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren): (khtml::RenderBlock::deleteEllipsisLineBoxes): (khtml::RenderBlock::checkLinesForTextOverflow):
khtml/rendering/render_block.cpp: (khtml:::RenderFlow): (khtml::RenderBlock::paintEllipsisBoxes): (khtml::RenderBlock::nodeAtPoint): (khtml::shouldCheckLines): (khtml::getLineAtIndex): (khtml::getHeightForLineCount): (khtml::RenderBlock::lineAtIndex): (khtml::RenderBlock::lineCount): (khtml::RenderBlock::heightForLineCount): (khtml::RenderBlock::clearTruncation):
khtml/rendering/render_block.h: (khtml::RenderBlock::setHasMarkupTruncation): (khtml::RenderBlock::hasMarkupTruncation):
khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutVerticalBox):
khtml/rendering/render_line.cpp: (khtml::EllipsisBox::m_str): (khtml::InlineBox::adjustPosition): (khtml::InlineFlowBox::adjustPosition): (khtml::InlineFlowBox::clearTruncation): (khtml::EllipsisBox::paint): (khtml::EllipsisBox::nodeAtPoint): (khtml::RootInlineBox::clearTruncation): (khtml::RootInlineBox::placeEllipsis): (khtml::RootInlineBox::paintEllipsisBox): (khtml::RootInlineBox::hitTestEllipsisBox): (khtml::RootInlineBox::adjustPosition): (khtml::RootInlineBox::childRemoved):
khtml/rendering/render_line.h: (khtml::InlineBox::clearTruncation):
khtml/rendering/render_text.cpp:
khtml/rendering/render_text.h: (khtml::InlineTextBox::clearTruncation):

1:30 AM Changeset in webkit [6876] by trey

9 edits in trunk

WebCore:

3698514 - coordinates in ondragstart and ondrag events are wrong

This part fixes the ondragstart coords. We salt away the window-based mouseDown
location, since we need that when we dispatch the ondragstart event. Previously
we were errantly using a mouseDown point that had already been converted to view
coords, and then the dispatch converted it again.

Reviewed by Maciej.

kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent): Use window based mouse event coords to dispatch event. (KWQKHTMLPart::mouseDown): Save window based mouse event coords .

WebKit:

3698514 - coordinates in ondragstart and ondrag events are wrong

This part fixes the ondrag coords. I thought Cocoa passed us the mouse location
in draggedImage:movedTo:, but no, it's the position of the dragged image.
WebCore needs the mouse location, so to calc that we must save away the
offset of the mouse relative to the image when we kick off the drag.

Reviewed by Maciej.

Misc.subproj/WebNSViewExtras.h:
Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:rect:event:pasteboard:source:offset:]): Add the ability to return the offset of the cursor wrt to the drag image, since this routine generates its own drag image and positions it.
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Calc the offset of the cursor wrt to the drag image in the myriad of ways that we kick off the drag. (-[WebHTMLView draggedImage:movedTo:]): Adjust the location by the offset we save when we kicked off the drag. (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
WebView.subproj/WebHTMLViewInternal.h:
WebView.subproj/WebImageView.m: (-[WebImageView mouseDragged:]): Pass nil for new arg, we don't care.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed