Timeline
Jun 22, 2004:
- 5:16 PM Changeset in webkit [6907] by
-
- 2 edits in trunk/WebCore
Fixed <rdar://problem/3707162>: accessing embeds[] plug-in interface may crash
embedInstance was uninitialized.
Reviewed by Chris.
- khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::HTMLEmbedElementImpl):
Jun 21, 2004:
- 4:50 PM Changeset in webkit [6906] by
-
- 2 edits in trunk/WebKit
- English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
- 3:13 PM Changeset in webkit [6905] by
-
- 3 edits in trunk/WebKit
Made WebKitErrorDescriptionPlugInCancelledConnection have its own description string
(Not for software update branch)
Reviewed by john.
- English.lproj/Localizable.strings:
- Misc.subproj/WebKitErrors.m:
- 3:05 PM Changeset in webkit [6904] by
-
- 2 edits in trunk/WebKit
Made WebKitErrorDescriptionPlugInCancelledConnection properly reuse an already localized string to avoid loc changes.
Reviewed by john.
- ChangeLog:
- Misc.subproj/WebKitErrors.m:
- 2:28 PM Changeset in webkit [6903] by
-
- 7 edits in trunk/WebKit
WebKit:
Fixed: <rdar://problem/3701269> change in error handling behavior from 10.3.3 to 10.3.4 breaks unreleased Adobe PDF plug-in
Reviewed by john.
- Misc.subproj/WebKitErrors.m: (registerErrors): register string for WebKitErrorPlugInCancelledConnection
- Misc.subproj/WebKitErrorsPrivate.h:
- Plugins.subproj/WebBaseNetscapePluginStream.h:
- Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]): use renamed WEB_REASON_PLUGIN_CANCELLED constant (-[WebBaseNetscapePluginStream destroyStream]): ditto
- Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation cancelWithReason:]): if the reason is WEB_REASON_PLUGIN_CANCELLED, cancel the load with WebKitErrorPlugInCancelledConnection
- Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream cancelWithReason:]): ditto
WebBrowser:
Fixed: <rdar://problem/3701269> change in error handling behavior from 10.3.3 to 10.3.4 breaks unreleased Adobe PDF plug-in
Reviewed by john.
- LoadProgressMonitor.m:
- LocationChangeHandler.m: if the error is WebKitErrorPlugInCancelledConnection ignore it (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]): ditto
- 10:46 AM Changeset in webkit [6902] by
-
- 1 edit in trunk/WebCore/ChangeLog-2005-08-23
add a release marker for WebCore-146.1
- 10:24 AM Changeset in webkit [6901] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
add release marker for JSC-146.1
Jun 18, 2004:
- 9:33 PM Changeset in webkit [6900]
-
- 4 copies3 deletes in tags/JavaScriptCore-146~1
This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-146~1'.
- 9:33 PM Changeset in webkit [6899] by
-
- 2 edits in branches/WWDC-2004-branch/JavaScriptCore
- versioning for JSC-146~1
- 9:25 PM Changeset in webkit [6898] by
-
- 2 edits in branches/WWDC-2004-branch/JavaScriptCore
- merge this fix from HEAD. Even if we can't submit this to Tiger for WWDC, we'll still need it for the Dashboard demo. No harm in merging this now.
2004-06-16 Richard Williamson <rjw@apple.com>
Fixed <rdar://problem/3702287> Crash returning nil from bound ObjC
This turned out to be a show stopper for Dashboard. Accessing a nil
ObjC property from JS caused a crash. Similar to the problem
3696112 fixed below.
Reviewed by Trey.
- bindings/objc/objc_runtime.mm: (KJS::Bindings::ObjcField::valueFromInstance):
- 8:49 PM Changeset in webkit [6897]
-
- 1 copy23 deletes in branches/unlabeled-1.384.2.1.2
This commit was manufactured by cvs2svn to create branch
'unlabeled-1.384.2.1.2'.
- 8:49 PM Changeset in webkit [6896]
-
- 1 copy22 deletes in branches/unlabeled-1.2930.2.4.2
This commit was manufactured by cvs2svn to create branch
'unlabeled-1.2930.2.4.2'.
- 8:49 PM Changeset in webkit [6895]
-
- 7 copies2 deletes in tags/WebCore-146~1
This commit was manufactured by cvs2svn to create tag
'WebCore-146~1'.
- 8:49 PM Changeset in webkit [6894]
-
- 7 copies1 delete in branches/WWDC-demo-branch
This commit was manufactured by cvs2svn to create branch
'WWDC-demo-branch'.
- 8:49 PM Changeset in webkit [6893] by
-
- 2 edits in branches/WWDC-2004-branch/WebCore
- versioning for WebCore-146.1
- 6:41 PM Changeset in webkit [6892] by
-
- 2 edits in trunk/JavaScriptCore
Fixed <rdar://problem/3702287> Crash returning nil from bound ObjC
This turned out to be a show stopper for Dashboard. Accessing a nil
ObjC property from JS caused a crash. Similar to the problem
3696112 fixed below.
Reviewed by Trey.
- bindings/objc/objc_runtime.mm: (KJS::Bindings::ObjcField::valueFromInstance):
- 6:16 PM Changeset in webkit [6891] by
-
- 2 edits in branches/WWDC-2004-branch/WebCore
- merge this change from HEAD
2004-06-18 Trey Matteson <trey@apple.com>
3702053 - DHTML dragging destination can't control the cursor (by setting the drop operation)
Fallout from security work, but an easy fix.
Reviewed by Darin
- kwq/KWQClipboard.mm: (KWQClipboard::setDropEffect): Allow dest side to set dropEffect.
- 6:08 PM Changeset in webkit [6890] by
-
- 2 edits in branches/WWDC-2004-branch/WebCore
- merge this change from HEAD
2004-06-18 Darin Adler <Darin Adler>
Reviewed by John.
- re-fixed <rdar://problem/3701893> show expert preferences notes in xcode causes crash (in EllipsisBox code)
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintEllipsisBoxes): Check !isInlineFlow rather than checking hasMarkupTruncation. Otherwise, we break plain old non-markup truncation.
- 6:05 PM Changeset in webkit [6889] by
-
- 2 edits in branches/WWDC-2004-branch/WebCore
- merge this change from HEAD
2004-06-18 Darin Adler <Darin Adler>
Reviewed by John.
- fixed <rdar://problem/3701893> show expert preferences notes in xcode causes crash (in EllipsisBox code)
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintEllipsisBoxes): Only walk the ellipsis list if hasMarkupTruncation is true.
- 4:58 PM Changeset in webkit [6888] by
-
- 2 edits in trunk/WebCore
3702053 - DHTML dragging destination can't control the cursor (by setting the drop operation)
Fallout from security work, but an easy fix.
Reviewed by Darin
- kwq/KWQClipboard.mm: (KWQClipboard::setDropEffect): Allow dest side to set dropEffect.
- 4:50 PM Changeset in webkit [6887] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
- re-fixed <rdar://problem/3701893> show expert preferences notes in xcode causes crash (in EllipsisBox code)
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintEllipsisBoxes): Check !isInlineFlow rather than checking hasMarkupTruncation. Otherwise, we break plain old non-markup truncation.
- 4:21 PM Changeset in webkit [6886] by
-
- 3 edits in trunk/WebCore
Reviewed by John.
- fixed <rdar://problem/3701893> show expert preferences notes in xcode causes crash (in EllipsisBox code)
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintEllipsisBoxes): Only walk the ellipsis list if hasMarkupTruncation is true.
- 1:57 PM Changeset in webkit [6885] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin
- fixed <rdar://problem/3534851> Pop up windows not showing up within SAP's BW Module (changing location.href on new window created by window.open)
- khtml/khtml_part.cpp: (KHTMLPart::scheduleRedirection): allow new redirect to win if delay <= current delay, not just <
