Timeline

Jun 25, 2004:

4:49 PM Changeset in webkit [6951] by trey

• 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fix "reviewed by" line.

3:53 PM Changeset in webkit [6950] by trey

• 3 edits in trunk/WebKit

WebKit:

Added new utility method.

Reviewed by John.

• WebView.subproj/WebFrame.m: (-[WebFrame _isDescendantOfFrame:]): New code.
• WebView.subproj/WebFramePrivate.h:

WebBrowser:

3562182 - repro Safari crash when altering specific form field

The basic problem was that JS would disable the search field on submit, which prevents
AK from sending a proper endEditing notification, which left the FormCompletionControler
hung out to dry. We now watch for page transitions, and clear the FormCC then.

Reviewed by John

• BrowserWebController.h:
• BrowserWebController.m: (-[BrowserWebView dataSourceHasChanged:forFrame:]): New callback from LocationChangeHandler, just pass through to FormDelegate. (-[FormDelegate controlTextDidBeginEditing:inFrame:]): Add ASSERT to catch similiar trouble in the figure. (-[FormDelegate controlTextDidEndEditing:inFrame:]): Ditto. (-[FormDelegate controlTextDidChange:inFrame:]): Ditto (-[FormDelegate control:textView:doCommandBySelector:inFrame:]): Ditto. (-[FormDelegate frameHasChanged:]): Clear state when page transitions out from under us.
• CompletionController.m: (+[CompletionController setCurrentCompletionController:]): Make the current comp controller a non-retained reference. Side pointers like this do not want to keep around objects with pointers into UI widgetry. (-[CompletionController dealloc]): Clear the current comp controller if we're going away.
• FormCompletionController.h:
• FormCompletionController.m: (-[FormCompletionController webFrame]): New getter.
• LocationChangeHandler.m: Cleaned up a bunch of silly code due to old rote conversion. (-[LocationChangeHandler webView:didStartProvisionalLoadForFrame:]): (-[LocationChangeHandler webView:didReceiveServerRedirectForProvisionalLoadForFrame:]): (-[LocationChangeHandler webView:didCommitLoadForFrame:]): Let WebView know of commit. (-[LocationChangeHandler webView:didReceiveTitle:forFrame:]): (-[LocationChangeHandler webView:didReceiveIcon:forFrame:]): (-[LocationChangeHandler webView:didChangeLocationWithinPageForFrame:]): (-[LocationChangeHandler webView:willCloseFrame:]):

Jun 24, 2004:

10:20 PM Changeset in webkit [6949] by trey

• 2 edits in trunk/WebCore

3710422 - REGRESSION: Safari crashes trying to send onbeforecut event at about://blank

Simple fix - don't try to send the event to the body element if we have no body element.

Reviewed by NOBODY (OOPS!).

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::dispatchCPPEvent):

7:16 PM Changeset in webkit [6948]

• 20 copies
  3 deletes in tags/WebKit-125~3

This commit was manufactured by cvs2svn to create tag 'WebKit-125~3'.

7:16 PM Changeset in webkit [6947] by vicki

• 2 edits in branches/Safari-1-2-branch/WebKit

• versioning for SUPanMoccasin, WebKit-125.3

7:15 PM Changeset in webkit [6946]

• 61 copies
  2 deletes in tags/WebCore-125~7

This commit was manufactured by cvs2svn to create tag
'WebCore-125~7'.

7:15 PM Changeset in webkit [6945] by vicki

• 2 edits in branches/Safari-1-2-branch/WebCore

• versioning for SUPanMoccasin, WebCore-125.7

7:14 PM Changeset in webkit [6944]

• 6 copies
  4 deletes in tags/JavaScriptCore-125~5

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-125~5'.

7:14 PM Changeset in webkit [6943] by vicki

• 2 edits in branches/Safari-1-2-branch/JavaScriptCore

• versioning for SUPanMoccasin, JSC-125.5

6:54 PM Changeset in webkit [6942]

• 8 copies
  2 deletes in tags/WebCore-146~1~1

This commit was manufactured by cvs2svn to create tag
'WebCore-146~1~1'.

6:54 PM Changeset in webkit [6941] by vicki

• 2 edits in branches/WWDC-demo-branch/WebCore

• versioning for the demo

6:52 PM Changeset in webkit [6940] by vicki

• 2 edits in branches/WWDC-demo-branch/WebCore

• roll this change to a branch, for the demo (one more try)

2004-06-22 Richard Williamson <​rjw@apple.com>

Fixed <rdar://problem/3707162>: accessing embeds[] plug-in interface may crash

embedInstance was uninitialized.

Reviewed by Chris.

• khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::HTMLEmbedElementImpl):

6:09 PM Changeset in webkit [6939] by vicki

• 2 edits in branches

• versioning for the demo changes, WebCore-146.1.1

6:07 PM Changeset in webkit [6938] by vicki

• 3 edits in branches

• merge this change for the WWDC demo

2004-06-22 Richard Williamson <​rjw@apple.com>

Fixed <rdar://problem/3707162>: accessing embeds[] plug-in interface may crash

embedInstance was uninitialized.

Reviewed by Chris.

• khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::HTMLEmbedElementImpl):

6:02 PM Changeset in webkit [6937]

• 4 copies
  3 deletes in tags/WebKit-146~0~1

This commit was manufactured by cvs2svn to create tag
'WebKit-146~0~1'.

6:02 PM Changeset in webkit [6936] by vicki

• 2 edits in branches/WWDC-demo-branch/WebKit

• versioning for demo changes, WebKit-146.0.1

5:58 PM Changeset in webkit [6935] by vicki

• 2 edits in branches/WWDC-demo-branch/WebKit

• roll this change to a branch for the WWDC demo

2004-06-24 Richard Williamson <​rjw@apple.com>

Fixed <rdar://problem/3710313>: CGContext not zeroed when WebImageRenderer is copied
The context ivar of WebImageRenderer wasn't being nil when the object was copied.

Reviewed by Darin.

• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer copyWithZone:]): (-[WebImageRenderer dealloc]): (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):

5:28 PM Changeset in webkit [6934] by rjw

• 2 edits in trunk/WebKit

Fixed <rdar://problem/3710313>: CGContext not zeroed when WebImageRenderer is copied
The context ivar of WebImageRenderer wasn't being nil when the object was copied.

Reviewed by Darin.

• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer copyWithZone:]): (-[WebImageRenderer dealloc]): (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):

5:06 PM Changeset in webkit [6933] by vicki

• 2 edits in branches/Safari-1-2-branch/WebCore

• fix a build error that cropped up from the merge for the radio button fix, 3673762

• khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::parseAttribute): (HTMLInputElementImpl::reset):

4:15 PM Changeset in webkit [6932] by vicki

• 2 edits in branches/Safari-1-2-branch/WebKit

• merge this change from HEAD for SUPanMoccasin, also for 3704961

2004-06-21 Chris Blumenberg <​cblu@apple.com>

Made WebKitErrorDescriptionPlugInCancelledConnection properly reuse an already localized string to avoid loc changes.

Reviewed by john.

• ChangeLog:
• Misc.subproj/WebKitErrors.m:

4:10 PM Changeset in webkit [6931] by vicki

• 7 edits in branches/Safari-1-2-branch/WebKit

• merge this change from HEAD for SUPanMoccasin, 3704961

2004-06-21 Chris Blumenberg <​cblu@apple.com>

Fixed: <rdar://problem/3701269> change in error handling behavior from 10.3.3 to 10.3.4 breaks unreleased Adobe PDF plug-in

Reviewed by john.

• Misc.subproj/WebKitErrors.m: (registerErrors): register string for WebKitErrorPlugInCancelledConnection
• Misc.subproj/WebKitErrorsPrivate.h:
• Plugins.subproj/WebBaseNetscapePluginStream.h:
• Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]): use renamed WEB_REASON_PLUGIN_CANCELLED constant (-[WebBaseNetscapePluginStream destroyStream]): ditto
• Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation cancelWithReason:]): if the reason is WEB_REASON_PLUGIN_CANCELLED, cancel the load with WebKitErrorPlugInCancelledConnection
• Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream cancelWithReason:]): ditto

WebBrowser:

• merge this change from HEAD for SUPanMoccasin, 3704961

2004-06-21 Chris Blumenberg <​cblu@apple.com>

Fixed: <rdar://problem/3701269> change in error handling behavior from 10.3.3 to 10.3.4 breaks unreleased Adobe PDF plug-in

Reviewed by john.

• LoadProgressMonitor.m:
• LocationChangeHandler.m: if the error is WebKitErrorPlugInCancelledConnection ignore it (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]): ditto

3:51 PM Changeset in webkit [6930] by vicki

• 4 edits in branches/Safari-1-2-branch/WebKit

• merge this change from HEAD for SUPanMoccasin, 3704493

2004-06-15 Trey Matteson <​trey@apple.com>

3639321 - Harvard PIN authentication ends up sending PIN as clear text with POST action

When going back/forward to an item, if we went there originally via a POST,
we ask the user about rePOSTing, and if they say yes, we resend the POST.
This rePOST case is triggered by the form data that we saved on the b/f item.
In the case of this bug, the overall navigation was accomplished by a POST,
then a redirect, causing a GET. When a load of type redirect achieves the Committed
stage, we replace the current URL in the b/f item with the new URL (instead of
adding a new item to the b/f list).

The bug is that at the same time we should also update the form data in
the b/f item to match that of the new request. I think this will normally
mean nil'ing it out, unless there's some way for the result of the redirect
to be another POST.

The security leak occurred because we did not clear the form data on the item,
so when going back or forward to the page, we would go into the rePOSTing code,
even though we eventually reached that page via a GET (caused by the redirect).
So we would do a POST to the redirect URL containing the private data sent in
the original POST.

Reviewed by mjs and rjw.

• History.subproj/WebHistoryItem.m: (-[WebHistoryItem _setFormInfoFromRequest:]): New method, just wraps 3 old set methods. (-[WebHistoryItem formData]): Diff being dumb, no change. (-[WebHistoryItem formContentType]): Ditto (-[WebHistoryItem formReferrer]): Ditto
• History.subproj/WebHistoryItemPrivate.h:
• WebView.subproj/WebFrame.m: (-[WebFrame _createItem:]): Call new WebHistoryItem method - no change in real behavior (-[WebFrame _transitionToCommitted:]): Clear out the form data at the key time, to fix the bug.

3:46 PM Changeset in webkit [6929] by trey

• 2 edits in trunk/WebKit

WebKit:

3672725 - Assertion failure in URLCompletion code with particular set of bookmarks

Problem was caused by a URL with unescaped unicodes getting into
the Bookmarks file, presumably from import from IE. We now test
for this case and convert the data on the way in as if it were
user-entered.

Reviewed by John and Darin.

• History.subproj/WebHistoryItem.m: (-[WebHistoryItem initFromDictionaryRepresentation:]):

WebBrowser:

A little extra timing logging added as part of fixing 3672725.

Reviewed by John.

• URLCompletionController.m: (+[URLCompletionController _loadDB]):

3:23 PM Changeset in webkit [6928] by trey

• 6 edits in trunk

Hmm, I thought this was working when I checked it in, but now it's not.
So once more with feeling, eliminate the cvs warnings for all *mode*
files within XCode doc wrappers.

3:19 PM Changeset in webkit [6927] by vicki

• 2 edits in branches/Safari-1-2-branch/WebCore

• merge this change from HEAD for SUPanMoccasin, 3704509

2004-06-02 David Hyatt <​hyatt@apple.com>

Fix for 3673931, negative margins on objects that dodge floats not handled correctly.

Reviewed by darin

• khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlockChildren):

3:16 PM Changeset in webkit [6926] by vicki

• 2 edits in branches/Safari-1-2-branch/WebCore

• merge this change from HEAD for SUPanMoccasin, 3703230

2004-06-18 John Sullivan <​sullivan@apple.com>

Reviewed by Darin

• fixed <rdar://problem/3534851> Pop up windows not showing up within SAP's BW Module (changing location.href on new window created by window.open)

• khtml/khtml_part.cpp: (KHTMLPart::scheduleRedirection): allow new redirect to win if delay <= current delay, not just <

3:13 PM Changeset in webkit [6925] by vicki

• 3 edits in branches/Safari-1-2-branch/WebCore

• merge this change from HEAD for SUPanMoccasin, 3673762

2004-05-20 Darin Adler <Darin Adler>

Reviewed by Maciej.

• fixed <rdar://problem/3575385>: (multiple radio buttons checked when arriving at sites (poll at www.1170kfaq.com, many others))

• khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::parseHTMLAttribute): Use setChecked to set the default value if we are still in "use default checked" mode. That way, other radio buttons will be unchecked properly and the proper changed methods will be dispatched. (HTMLInputElementImpl::reset): Ditto.
• khtml/html/html_formimpl.h: (DOM::HTMLInputElementImpl::checked): Changed to just return m_checked. The m_useDefaultChecked flag is now only really looked at when you parse a checked attribute; that's because m_checked and m_defaultChecked are kept equal as long as m_useDefaultChecked is true.

1:53 PM Changeset in webkit [6924] by trey

• 6 edits in trunk

Added *.mode% to all .cvsignore files in XCode project doc wrappers.
Then copied the result to all the XCode wrappers that had none.

1:27 PM Changeset in webkit [6923] by trey

• 8 edits in trunk

WebCore:

3704950 drag image in DB ConfigBar has horizontal graphics turd WebCore JavaScript

When we generate a drag image (or a selection image too, for that matter) we
translate the CTM using a CG call. Later, WebImageRenderer adjusts the pattern
phase based on the CTM of the focused view, which doesn't include our translate.
So we must inform WebKit about the additional phase adjustment.

Reviewed by Richard

• kwq/KWQKHTMLPart.mm: Tell WebKit about the phase adjustment. (KWQKHTMLPart::imageFromRect):
• kwq/WebCoreGraphicsBridge.h:
• kwq/WebCoreGraphicsBridge.m: (-[WebCoreGraphicsBridge setAdditionalPatternPhase:]): New routine to receive the phase adjustment.

WebKit:

3704950 drag image in DB ConfigBar has horizontal graphics turd WebCore JavaScript

When we generate a drag image (or a selection image too, for that matter) we
translate the CTM using a CG call. Later, WebImageRenderer adjusts the pattern
phase based on the CTM of the focused view, which doesn't include our translate.
So we must inform WebKit about the additional phase adjustment.

Reviewed by Richard

• WebCoreSupport.subproj/WebGraphicsBridge.h:
• WebCoreSupport.subproj/WebGraphicsBridge.m: (-[WebGraphicsBridge setAdditionalPatternPhase:]): New trivial setter. (-[WebGraphicsBridge additionalPatternPhase]): ...and getter.
• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer tileInRect:fromPoint:context:]): Take any additional phase adjustment into account when setting phase.

1:20 PM Changeset in webkit [6922] by trey

• 8 edits in trunk/WebCore

3679986 - screenX and screenY are flipped and relative to the bottom left of the WebView, rather than the screen
3699510 - synthesized click events have bogus screen coords

Reviewed by Darin.

• khtml/khtmlview.cpp: (KHTMLView::dispatchDragEvent): Generate screen coords for drag events using new func. (KHTMLView::dispatchMouseEvent): Ditto.
• khtml/khtmlview.h:
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchMouseEvent): Comment tricky semantics. Calc screen coords in apple-specific way.
• kwq/KWQKHTMLView.mm: (KHTMLView::viewportToGlobal): Passthrough to window widget.
• kwq/KWQScrollView.mm:
• kwq/KWQWindowWidget.h:
• kwq/KWQWindowWidget.mm: (KWQWindowWidget::mapToGlobal): Call former code factored to new method below. (KWQWindowWidget::viewportToGlobal): New method to convert "viewport" (which for us really means NSWindow coords) to screen coords.

11:58 AM Changeset in webkit [6921] by trey

• 7 edits in trunk

WebCore:

3693420 - onbeforecut and onbeforepaste need real implementaion

Reviewed by Chris.

• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::mayCut): Dispatch event to DHTML. (KWQKHTMLPart::mayCopy): Ditto (KWQKHTMLPart::mayPaste): Ditto (KWQKHTMLPart::tryCut): No more need to send fake onbefore event (KWQKHTMLPart::tryCopy): Ditto (KWQKHTMLPart::tryPaste): Ditto
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge mayDHTMLCut]): Standard glue (-[WebCoreBridge mayDHTMLCopy]): Ditto (-[WebCoreBridge mayDHTMLPaste]): Ditto

WebKit:

3693420 - onbeforecut and onbeforepaste need real implementaion

Reviewed by Chris.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView validateUserInterfaceItem:]): Check with WebCore to see if cut, copy, paste should be enabled.

11:43 AM Changeset in webkit [6920] by darin

• 4 edits in trunk/WebCore

Reviewed by John.

• fixed <rdar://problem/3709385> Find on page doesn't find a string at the very end of the file

• khtml/misc/khtml_text_operations.cpp: (khtml::findPlainText): Rearrange loop to avoid an early exit once we have all the characters we need, but are at the end of the range we are searching.

• fixed <rdar://problem/3102271>: (text areas have scroll bars even when they don't need them)
• fixed <rdar://problem/3665430>: (horizontal scroll bar of text area does not show, even when text is wide in "no wrap" mode)

• kwq/KWQTextArea.mm: (-[KWQTextArea _configureTextViewForWordWrapMode]): Added. Helper method that sets up the view for a new word wrap mode. (-[KWQTextArea _createTextView]): Moved much of the code inside _configureTextViewForWordWrapMode. (-[KWQTextArea _frameSizeChanged]): Added. Method shared by setFrame: and initWithFrame: to avoid duplicate code that was there before. The old code also had redundant code to update the text container size, but NSText handles that automatically. (-[KWQTextArea initWithFrame:]): Set wrap to YES by default, which is the key to fixing bug 3665430. Call setAutohidesScrollers:YES, which fixes bug 3102271. Also call the new _frameSizeChanged method. (-[KWQTextArea setWordWrap:]): Call _configureTextViewForWordWrapMode instead of trying to do the work here. The old version did both too little and too much. (-[KWQTextArea setFrame:]): Call _frameSizeChanged instead of trying to do the work here. The old version did both too little and too much.

11:42 AM Changeset in webkit [6919]

• 11 copies
  3 deletes in tags/WebKit-146~1

This commit was manufactured by cvs2svn to create tag 'WebKit-146~1'.

11:42 AM Changeset in webkit [6918] by vicki

• 2 edits in branches/WWDC-2004-branch/WebKit

• versioning for Safari 1.3 Developer Beta, WebKit 146.1

11:41 AM Changeset in webkit [6917] by cblu

• 3 edits in trunk/JavaScriptCore

JavaScriptCore:

Ignore .mode1 files in JavaScriptCore.pbproj

Reviewed by kocienda.

• JavaScriptCore.pbproj/.cvsignore:

Tests:

Made TestBindingsPlugin compile again.
Removed TestPlugin from CVS since NetscapeMoviePlugin is a better Netscape plug-in example.

Reviewed by kocienda.

• TestBindingsPlugin/TestBindingsPlugin.pbproj/.cvsignore: Added.
• TestBindingsPlugin/TestBindingsPlugin.pbproj/project.pbxproj:
• TestBindingsPlugin/main.c: (NPP_GetValue): (NPP_SetValue):
• TestPlugin/English.lproj/InfoPlist.strings: Removed.
• TestPlugin/TestPlugin.pbproj/project.pbxproj: Removed.
• TestPlugin/main.c: Removed.
• TestPlugin/npapi.h: Removed.
• TestPlugin/test_plugin.html: Removed.

WebBrowser:

Ignore .mode1 files in WebBrowser.pbproj

Reviewed by kocienda.

• WebBrowser.pbproj/.cvsignore:

WebKitExamples:

Ignore .mode1 and other files in WebKitMoviePlugIn.xcode and NetscapeMoviePlugIn.xcode.

Reviewed by kocienda.

• NetscapeMoviePlugIn/NetscapeMoviePlugIn.xcode/.cvsignore: Added.
• WebKitMoviePlugIn/WebKitMoviePlugIn.xcode/.cvsignore: Added.
• WebKitMoviePlugIn/WebKitMoviePlugIn.xcode/project.pbxproj: Tiger updated the project

11:36 AM Changeset in webkit [6916]

• 11 copies
  2 deletes in tags/WebCore-146~2

This commit was manufactured by cvs2svn to create tag
'WebCore-146~2'.

11:36 AM Changeset in webkit [6915] by vicki

• 2 edits in branches/WWDC-2004-branch/WebCore

• versioning for Safari 1.3 Developer Beta, WebCore-146.2

11:34 AM Changeset in webkit [6914]

• 16 copies
  3 deletes in tags/JavaScriptCore-146~2

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-146~2'.

11:34 AM Changeset in webkit [6913] by vicki

• 2 edits in branches/WWDC-2004-branch/JavaScriptCore

versioning for the 1.3 Developer Beta build, JavaScriptCore-146.2

11:22 AM Changeset in webkit [6912] by sullivan

• 3 edits in trunk/WebCore

Darin made this change on my machine; I reviewed it.

• fixed <rdar://problem/3698333> Find on page doesn't find a particular string with a newline in the source

• khtml/misc/khtml_text_operations.cpp: (khtml::TextIterator::handleTextBox): Clear m_lastTextNodeEndedWithCollapsedSpace after taking it into account.

11:22 AM Changeset in webkit [6911] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Darin.

• fixed <rdar://problem/3706792> 8A161: Choosing text encoding for error page opens finder window!?

• WebView.subproj/WebFrame.m: (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]): take unreachableURL into account

11:19 AM Changeset in webkit [6910] by vicki

• 29 edits in branches/WWDC-2004-branch

JavaScriptCore:

• merge this change from HEAD, for Safari 1.3 Developer Beta

2004-06-23 Richard Williamson <​rjw@apple.com>

Implemented changes for latest npruntime.h.

Reviewed by Chris.

• JavaScriptCore.pbproj/project.pbxproj:
• bindings/NP_jsobject.cpp: (listFromVariantArgs): (identiferFromNPIdentifier): (_NPN_CreateScriptObject): (NPN_Call): (NPN_Evaluate): (NPN_GetProperty): (NPN_SetProperty): (NPN_RemoveProperty):
• bindings/NP_jsobject.h:
• bindings/c/c_class.cpp: (CClass::methodsNamed): (CClass::fieldNamed):
• bindings/c/c_instance.cpp: (CInstance::invokeMethod):
• bindings/c/c_utility.cpp: (convertNPVariantToValue):
• bindings/c/c_utility.h:
• bindings/npruntime.cpp: (stringIdentifierEqual): (stringIdentifierHash): (getStringIdentifierDictionary): (intIdentifierEqual): (intIdentifierHash): (getIntIdentifierDictionary): (NPN_GetStringIdentifier): (NPN_GetStringIdentifiers): (NPN_GetIntIdentifier): (NPN_IdentifierIsString): (NPN_UTF8FromIdentifier): (NPN_VariantToInt32): (NPN_VariantToDouble): (NPN_SetException):
• bindings/npruntime.h:
• bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:KJS::root:Bindings::]):
• bindings/runtime_object.cpp: (RuntimeObjectImp::~RuntimeObjectImp):
• bindings/runtime_root.cpp: (KJS::Bindings::rootForInterpreter):
• bindings/testbindings.cpp: (initializeIdentifiers): (logMessage): (setDoubleValue): (setIntValue): (setBooleanValue):

WebCore:

• merge this change from HEAD, for Safari 1.3 Developer Beta

2004-06-23 Richard Williamson <​rjw@apple.com>

Implemented changes for latest npruntime.h.

Reviewed by Chris.

• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): (KWQKHTMLPart::windowScriptNPObject): (KWQKHTMLPart::getEmbedInstanceForView):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge windowScriptObject]): (-[WebCoreBridge windowScriptNPObject]):

WebKit:

• merge this change from HEAD, for Safari 1.3 Developer Beta

2004-06-23 Richard Williamson <​rjw@apple.com>

Implemented changes for latest npruntime.h.
Made npruntime.h public.

Reviewed by Chris.

• Plugins.subproj/WebBaseNetscapePluginView.h:
• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView pluginScriptableObject]): (-[WebBaseNetscapePluginView forceRedraw]): (-[WebBaseNetscapePluginView getVariable:value:]):
• Plugins.subproj/WebBaseNetscapePluginViewPrivate.h:
• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
• Plugins.subproj/npapi.h:
• Plugins.subproj/npapi.m: (NPN_GetValue):
• Plugins.subproj/npfunctions.h:
• Plugins.subproj/npruntime.h:
• WebKit.pbproj/project.pbxproj:

Jun 23, 2004:

5:36 PM Changeset in webkit [6909] by rjw

• 29 edits in trunk

WebKit:

Implemented changes for latest npruntime.h.
Made npruntime.h public.

Reviewed by Chris.

• Plugins.subproj/WebBaseNetscapePluginView.h:
• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView pluginScriptableObject]): (-[WebBaseNetscapePluginView forceRedraw]): (-[WebBaseNetscapePluginView getVariable:value:]):
• Plugins.subproj/WebBaseNetscapePluginViewPrivate.h:
• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
• Plugins.subproj/npapi.h:
• Plugins.subproj/npapi.m: (NPN_GetValue):
• Plugins.subproj/npfunctions.h:
• Plugins.subproj/npruntime.h:
• WebKit.pbproj/project.pbxproj:

WebCore:

Implemented changes for latest npruntime.h.

Reviewed by Chris.

• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): (KWQKHTMLPart::windowScriptNPObject): (KWQKHTMLPart::getEmbedInstanceForView):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge windowScriptObject]): (-[WebCoreBridge windowScriptNPObject]):

JavaScriptCore:

Implemented changes for latest npruntime.h.

Reviewed by Chris.

• JavaScriptCore.pbproj/project.pbxproj:
• bindings/NP_jsobject.cpp: (listFromVariantArgs): (identiferFromNPIdentifier): (_NPN_CreateScriptObject): (NPN_Call): (NPN_Evaluate): (NPN_GetProperty): (NPN_SetProperty): (NPN_RemoveProperty):
• bindings/NP_jsobject.h:
• bindings/c/c_class.cpp: (CClass::methodsNamed): (CClass::fieldNamed):
• bindings/c/c_instance.cpp: (CInstance::invokeMethod):
• bindings/c/c_utility.cpp: (convertNPVariantToValue):
• bindings/c/c_utility.h:
• bindings/npruntime.cpp: (stringIdentifierEqual): (stringIdentifierHash): (getStringIdentifierDictionary): (intIdentifierEqual): (intIdentifierHash): (getIntIdentifierDictionary): (NPN_GetStringIdentifier): (NPN_GetStringIdentifiers): (NPN_GetIntIdentifier): (NPN_IdentifierIsString): (NPN_UTF8FromIdentifier): (NPN_VariantToInt32): (NPN_VariantToDouble): (NPN_SetException):
• bindings/npruntime.h:
• bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:KJS::root:Bindings::]):
• bindings/runtime_object.cpp: (RuntimeObjectImp::~RuntimeObjectImp):
• bindings/runtime_root.cpp: (KJS::Bindings::rootForInterpreter):
• bindings/testbindings.cpp: (initializeIdentifiers): (logMessage): (setDoubleValue): (setIntValue): (setBooleanValue):

5:23 PM Changeset in webkit [6908] by vicki

• 3 edits in trunk

• bump the version number in TOT to 148u, since I burned 147 for the WWDC demo build