Timeline

Jun 29, 2004:

4:37 PM Changeset in webkit [6952] by trey

• 4 edits in trunk/WebCore

DHTML dragging - source should have access to the operation chosen
by the destination.

Reviewed by John

• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::dragSourceEndedAt): Set the destination's operation on the clipboard.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge dragExitedWithDraggingInfo:]): For completeness we set the source op for the ondragexit event. (-[WebCoreBridge concludeDragForDraggingInfo:]): Ditto for the drop event. (-[WebCoreBridge dragSourceEndedAt:operation:]): Pass through of operation.

Jun 25, 2004:

4:49 PM Changeset in webkit [6951] by trey

• 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fix "reviewed by" line.

3:53 PM Changeset in webkit [6950] by trey

• 3 edits in trunk/WebKit

WebKit:

Added new utility method.

Reviewed by John.

• WebView.subproj/WebFrame.m: (-[WebFrame _isDescendantOfFrame:]): New code.
• WebView.subproj/WebFramePrivate.h:

WebBrowser:

3562182 - repro Safari crash when altering specific form field

The basic problem was that JS would disable the search field on submit, which prevents
AK from sending a proper endEditing notification, which left the FormCompletionControler
hung out to dry. We now watch for page transitions, and clear the FormCC then.

Reviewed by John

• BrowserWebController.h:
• BrowserWebController.m: (-[BrowserWebView dataSourceHasChanged:forFrame:]): New callback from LocationChangeHandler, just pass through to FormDelegate. (-[FormDelegate controlTextDidBeginEditing:inFrame:]): Add ASSERT to catch similiar trouble in the figure. (-[FormDelegate controlTextDidEndEditing:inFrame:]): Ditto. (-[FormDelegate controlTextDidChange:inFrame:]): Ditto (-[FormDelegate control:textView:doCommandBySelector:inFrame:]): Ditto. (-[FormDelegate frameHasChanged:]): Clear state when page transitions out from under us.
• CompletionController.m: (+[CompletionController setCurrentCompletionController:]): Make the current comp controller a non-retained reference. Side pointers like this do not want to keep around objects with pointers into UI widgetry. (-[CompletionController dealloc]): Clear the current comp controller if we're going away.
• FormCompletionController.h:
• FormCompletionController.m: (-[FormCompletionController webFrame]): New getter.
• LocationChangeHandler.m: Cleaned up a bunch of silly code due to old rote conversion. (-[LocationChangeHandler webView:didStartProvisionalLoadForFrame:]): (-[LocationChangeHandler webView:didReceiveServerRedirectForProvisionalLoadForFrame:]): (-[LocationChangeHandler webView:didCommitLoadForFrame:]): Let WebView know of commit. (-[LocationChangeHandler webView:didReceiveTitle:forFrame:]): (-[LocationChangeHandler webView:didReceiveIcon:forFrame:]): (-[LocationChangeHandler webView:didChangeLocationWithinPageForFrame:]): (-[LocationChangeHandler webView:willCloseFrame:]):